Commit Graph

2268 Commits

Author SHA1 Message Date
Matan Borenkraout
53225e8d17
refactor(explore): remove side effect in render from CalendarFrame for DatePicker (#15147) 2021-06-15 13:26:42 +03:00
Ville Brofeldt
9c3c3fa125
feat(native-filters): add optional time col to time range (#15117) 2021-06-15 13:25:28 +03:00
Kamil Gabryjelski
9ba2983f42
chore: Bump plugin-chart-pivot-table to 0.17.57 (#15168)
* chore: Bump plugin-chart-pivot-table to 0.17.57

* Bump other superset-ui packages to 0.17.56

* Fix package-lock
2021-06-15 12:02:40 +02:00
Michael S. Molina
b3c197903c
chore: Scrolls top when opening a select filter (#15141) 2021-06-15 10:10:23 +02:00
ʈᵃᵢ
98ec365374
feat(webpack): configure publicPath via ASSET_BASE_URL env var (#15105) 2021-06-14 18:55:58 -06:00
Phillip Kelley-Dotson
e2abf59534
feat(Explore): add sort to edit dataset modal (#14872)
* inital commit

* refac

* fix ui issues and sort

* fix lint

* add suggestions

* lint

* add suggestions

* add enum

* add enum to inter
2021-06-14 15:20:22 -07:00
Ajay M
045fa1bc7a
feat(dashboard): Let users download full CSV of a table (#15046)
* - Convert SliceHeader to TSX in progress
- Add menu option to download full CSV. Probably will change it

* Add Download Full CSV feature, and tests

* Added more tests, more TS fixes

* Added feature flag

* Update @superset-ui package versions

* Update @superset-ui packages versions

* use backend config instead of hardcoding number of rows

* Update tests

* front end test fix

* Lint fixes and test fixes
2021-06-14 14:26:18 -07:00
Michael S. Molina
82ad053e50
fix: Filter overlay in dashboard when scrolling (#15140) 2021-06-14 15:34:36 +02:00
Kamil Gabryjelski
3866044938
fix(native-filters): Don't send unnecessary PUT request on dashboard render (#15146)
* fix(native-filters): Don't send unnecessary PUT request on dashboard render

* Run native filters scopes only if feature flag is enabled

* Change action name

* Run native filters scopes only if at least 1 filter added

* Fix lint
2021-06-14 14:33:59 +02:00
gordern
57035c1b93
fix: improve dashboard fullscreen text (#15139) 2021-06-14 17:54:37 +08:00
Yaozong Liu
856a2bd5ed
fix(explore): fix y-axis lower bound 0 value (#15091) 2021-06-13 11:24:39 +08:00
Phillip Kelley-Dotson
8e6a5a6f52
chore: Homepage cleanup (#14823)
* initial commit

* update welcome

* fix lint

* add enum

* more choring

* fix lint

* redo logic for api stick api calls

* fix test

* fix chart test

* lint fix and remove unused code

* fix flicker and add suggestions

* lint

* fix test

* add suggestions

* add suggestions and fix test

* revert packagelock

* fix space
2021-06-11 18:47:42 -07:00
Beto Dealmeida
53df152362
feat: show spinner on exports (#15107)
* feat: show spinner on exports

* Set cookie only if token is passed

* Use iframe

* Small fixes

* Fix lint

* Remove stale test

* Add explicit type
2021-06-11 17:25:00 -07:00
Kamil Gabryjelski
ff2d5888d9
feat(native-filters): Defer loading filters data until filter is visible (#15120)
* feat(native-filters): Defer running query until native filter is in view

* Fix default values not displaying
2021-06-11 11:10:16 -07:00
Kamil Gabryjelski
51f0d4fd98
feat(native-filters): Hide filters which don't affect any visible charts (#15063)
* feat(native-filters): Hide filters which don't affect any visible charts

* Fix lint errors

* Add comments

* Code review fix

* Fix tests

* Refactor logic in FilterControls
2021-06-11 13:41:08 +02:00
Ville Brofeldt
5e825cf063
fix(native-filters): handle descending sorting correctly (#15112) 2021-06-11 11:44:16 +03:00
Kamil Gabryjelski
3456dd571c
fix(native-filters): fix Select filter crashing when changing filter type (#15090) 2021-06-10 18:11:31 -06:00
Ajay M
f8b270d419
fix(explore): Explore page boolean filter is broken for Presto DB (#14952)
* Front end update - modify OPERATORS, to have SQL operation and display value

* Updated tests

* More tests

* Remove OPERATOR imports

* Fix break tests

* PR comments

* fix issue with comparator loading

* rename a variable

* Linting
2021-06-10 09:08:04 -07:00
Ville Brofeldt
c0eff8faf6
fix(native-filters): empty label indicator (#15084) 2021-06-10 16:56:55 +03:00
Ville Brofeldt
6c9f15a6e4
fix(native-filters): show error if default value query failed (#15005)
* fix(native-filters): show error if query failed

* address comments
2021-06-10 16:56:31 +03:00
Michael S. Molina
1468026883
chore: Improves the native filters UI/UX - iteration 7 (#15017) 2021-06-10 15:24:00 +03:00
Ville Brofeldt
8aaa6036d7
fix(native-filters): remove hard-coded default time range (#15015)
* fix(native-filters): use default for time range from explore

* fix tests
2021-06-10 14:49:37 +03:00
Ville Brofeldt
65714cc201
fix(dnd): add isExtra prop to Option (#15080) 2021-06-10 12:13:20 +03:00
Yongjie Zhao
834bb9409d
fix(datasets): consistent dataset list (#15014) 2021-06-10 10:05:33 +08:00
Erik Ritter
e8414dfb52
fix: disappearing tooltips on dashboards (#15073) 2021-06-09 18:41:40 -07:00
Beto Dealmeida
4d24d4dc9a
fix: confirm overwrite and password on import (#15056)
* fix: confirm overwrite and password on import

* Add tests
2021-06-09 18:05:31 -07:00
Beto Dealmeida
1db92cc13a
feat: spinner for imports (#15055)
* Update tests

* feat: spinner for imports

* Use loading button instead

* Small fixes

* Small fix
2021-06-09 16:14:49 -07:00
AAfghahi
2d3f552b51
adding fetching to query status (#15064) 2021-06-09 16:11:49 -07:00
Beto Dealmeida
256e1452fe
feat: style import button (#15057)
* feat: style import button

* Update tests

* Update test
2021-06-09 15:40:53 -07:00
Elizabeth Thompson
0c470feaef
move metric parsing to state instantiation (#15069) 2021-06-09 14:54:25 -07:00
ʈᵃᵢ
821519fcfa
build(webpack): use [contenthash] instead of [chunkhash] (#14942) 2021-06-09 13:59:17 -06:00
Beto Dealmeida
3f527c7a45
fix: font regression in SQL Lab (#14960)
* fix: font regression in SQL Lab

* Fix tests
2021-06-08 15:52:57 -07:00
Lyndsi Kay Williams
6cc179b7bf
close icon aligned (#14870) 2021-06-08 13:10:13 -04:00
Lyndsi Kay Williams
94c86c3837
Centered down-arrow icons in top navbar (#14846) 2021-06-08 13:09:35 -04:00
Michael S. Molina
1af91ed756
fix: Adds left padding to dashboard edit mode when filter bar is closed (#15024) 2021-06-08 15:58:15 +03:00
Ville Brofeldt
efd7007701
fix(native-filters): show overridden chart name on scoping tree (#15038) 2021-06-08 14:55:11 +03:00
Kamil Gabryjelski
0e07a5ca03
fix(explore): Datepicker glitch on hover outside the modal (#15033) 2021-06-08 07:46:09 +02:00
Geido
a1ca0b2e6b
Add ming-height to empty tab (#14878) 2021-06-07 22:55:16 -06:00
Geido
12fcb3132c
Remove nowrap (#14954) 2021-06-07 22:50:05 -06:00
Elizabeth Thompson
21aa3daae3
display all metric results in editor (#15031) 2021-06-07 19:12:56 -07:00
David Aaron Suddjian
cf15fe0d03
fix(dashboard): custom css should be removed on unmount (#15025)
* fix(dashboard): custom css should be removed on unmount

* better comment

* remove unnecessary typecast

* move type to top level scope
2021-06-07 14:04:56 -07:00
Ville Brofeldt
422c32cb7d
feat(filter-box): hide druid options if druid not enabled (#14921)
* feat(filter-box): hide druid options if druid not enabled

* add bootstrap export
2021-06-07 13:49:56 -06:00
AAfghahi
7f4e036433
fix: adding additional configs and colors for queryHistory (#14995)
* added additional configs and colors for queryHistory

* added condition to status icon

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx
2021-06-07 14:10:28 -04:00
Maxime Beauchemin
8798da41a7
chore: rename 'Source' to 'Database' for consistency (#15021) 2021-06-07 10:34:52 -07:00
Ville Brofeldt
de1b140617
chore(ci): fix ci conflict (#15016) 2021-06-07 18:27:54 +03:00
Ville Brofeldt
d2a6e8cd20
fix(native-filters): avoid double load on initialization (#15012) 2021-06-07 13:47:02 +03:00
simcha90
1fc08523af
feat(native-filters): Support default to first value in select filter (#14869)
* fix:fix get permission function

* feat: add async filters support

* revert: revert ff

* feat: add async filters support

* fix: merge with master

* fix: remove tests

* lint: fix lint

* fix: fix CR notes

* fix: fix with master

* test: fix tests

* refactor: update logic for default first value

* fix: get requiredFirst

* fix: support instant

* docs: update text

* docs: fix comments

* docs: update texts
2021-06-07 13:41:19 +03:00
Yongjie Zhao
c8cf4b6bbf
fix: toggle fullscreen on the dashboard (#14979) 2021-06-04 22:24:57 +08:00
Ville Brofeldt
355223d3fe
feat(native-filters): add markers and number formatter + simple tests (#14981) 2021-06-04 16:22:54 +03:00
Kamil Gabryjelski
8c01c13d90
fix(native-filters): Fix "undefined" error after editing a filter (#14984)
* fix(native-filters): Fix "undefined" error after editing a filter

* Remove console log
2021-06-04 15:15:37 +02:00
Ville Brofeldt
6955ed287b
fix(native-filters): remove implied fetch predicate (#14982) 2021-06-04 13:45:53 +03:00
Ville Brofeldt
61a438a0cd
fix(native-filters): update cascaded filter state on change (#14980) 2021-06-04 14:01:44 +08:00
Ville Brofeldt
20b86f81e7
fix(filter box): replace freeform where clause with ilike (#14900) 2021-06-04 06:43:07 +03:00
Corbin Robb
004a6d9e54
refactor: Convert TableElement.jsx component from class to functional with hooks (#14830)
* Change TableElement from a class component to a functional component

* Replace class state checks in TableElement_spec.jsx with checks testing elements they change

* Refactor small bit of logic to use optional chaining

* Add optional chaining to some logic

* Fix IconTooltip and add IconTooltip to the collapse button

* Fix custom icon using IconToolTip so it better matches the original

* Update collapse/expand icon to use Icons component instead of importing from antdesign directly

* Fix eslint errors

* Clean up some code for readability

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-06-03 16:04:56 -07:00
cccs-jc
f652908a70
fix: renamed sqllab filters to _filters (#14971) 2021-06-03 21:22:50 +03:00
Ville Brofeldt
765e9dd932
feat(native-filters): apply cascading without instant filtering (#14966) 2021-06-03 17:48:46 +03:00
Ville Brofeldt
78d30896f3
chore: bump superset-ui to 0.17.53 (#14968) 2021-06-03 16:37:42 +03:00
Ville Brofeldt
f94c6d2763
fix(native-filters): cascading filters not rendering in tab (#14964) 2021-06-03 12:04:23 +03:00
Yongjie Zhao
e6bc7c99e7
feat: add type_generic and is_dttm to table metadata (#14863) 2021-06-03 08:20:47 +08:00
AAfghahi
53505c2acb
additional safeguard (#14953) 2021-06-02 12:02:22 -07:00
Kamil Gabryjelski
405f95b6af
feat(dashboard/native-filters): Hide filters out of scope of current tab (#14933)
* Optimize finding charts and tabs in scope

* Put filters out of scope in Collapse

* Use lastFocusedTabId instead of directPathToChild

* Fix tests

* Fix cypress test

* Uncomment e2e test
2021-06-02 20:38:18 +02:00
Michael S. Molina
b6f00e69e1
chore: Improves the native filters UI/UX - iteration 6 (#14932) 2021-06-02 09:03:13 +03:00
Lyndsi Kay Williams
06945ccbcf
feat: Icon Button (#14818)
* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
2021-06-01 20:47:42 -07:00
Elizabeth Thompson
8cc97e4790
feat: validation db modal (#14832)
* split db modal file

* hook up available databases

* use new validation component
2021-06-01 18:18:17 -04:00
AAfghahi
fac6b7c207
fix: Remove Icon and align close button on DatasetModal (#14902)
* aligned DatabaseModal header

* revisions
2021-06-01 14:53:59 -04:00
AAfghahi
eced510708
fix: Query History cosmetic issues (#14885)
* easiest fix

* Query History Cosmetic Issues

* added revisions

* beto revisions
2021-06-01 14:53:12 -04:00
cccs-jc
eef489c667
feat: add support for filters in sqlLab (#14765) 2021-06-01 21:23:51 +03:00
Ville Brofeldt
66282c3313
chore: customize adhoc filter icon and fix creatable label (#14896)
* chore: customize adhoc filter icon and fix creatable label

* use common icon component

* simplify code
2021-05-31 09:45:12 +03:00
simcha90
e43112c5f9
feat(native-filter): Hide native filters (#14784)
* fix:fix get permission function

* feat: support showFilters

* fix: fix CR notes

* fix: fix lint issues
2021-05-31 09:05:57 +03:00
simcha90
50c5dcbb0a
test(native-filters): add test for Select filter (#14919)
* fix:fix get permission function

* test: tests for select filter
2021-05-31 09:02:46 +03:00
Geido
d86880d49b
Revert style (#14840) 2021-05-30 23:11:57 -06:00
rijojoseph07
a85f5c1344
feat(trino): add support for user impersonation (#14843)
* trino impersonation feature

* Extra options label update

* Update superset/db_engine_specs/trino.py

Co-authored-by: Đặng Minh Dũng <dungdm93@live.com>

Co-authored-by: rijojoseph01 <rijo.joseph@myntra.com>
Co-authored-by: Đặng Minh Dũng <dungdm93@live.com>
2021-05-29 09:54:18 +03:00
Hugh A. Miles II
0eb34be789
leverage qs to create new tab (#14855) 2021-05-28 10:05:36 -07:00
Kamil Gabryjelski
507d4d791f
chore: Bump @superset-ui/legacy-preset-chart-deckgl to 0.4.7 (#14871) 2021-05-28 17:30:21 +02:00
Kamil Gabryjelski
f82a085175
feat(dashboard): Highlight tabs that contain a chart in scope of focused native filter (#14865)
* feat(dashboard): Highlight tabs that contain a chart in scope of focused native filter

* Optimizations and improvements

* Use Set instead of array

* Simplify logic

* Change variable name
2021-05-28 11:32:32 +02:00
Michael S. Molina
8519a09086
chore: Improves the native filters UI/UX - iteration 5 (#14882) 2021-05-28 10:29:16 +03:00
Geido
fce8ac27f0
Add style (#14839) 2021-05-28 09:32:51 +03:00
Ville Brofeldt
b72e5e0aae
feat(native-filters): improve inverse selection indicators (#14873) 2021-05-28 07:45:37 +03:00
Yongjie Zhao
acbbced20b
fix: timerange in filter box error (#14890) 2021-05-28 11:28:58 +08:00
Kamil Gabryjelski
281d637674
Don't run query when control panel has errors (#14687) 2021-05-27 08:13:17 -07:00
AAfghahi
877201f1e0
margin style (#14849) 2021-05-27 10:39:19 -04:00
Michael S. Molina
a6d54b681b
chore: Improves the native filters UI/UX - iteration 4 (#14854) 2021-05-27 13:37:36 +03:00
Geido
ad4ce83327
fix(native-filter): Default value multi-select height in native filters (#14816)
* Fix height

* Fix height sidebar

* Move style
2021-05-27 13:05:58 +03:00
Ville Brofeldt
2b4e0ec9e0
feat(native-filters): sort selected values on blur (#14842)
* feat(native-filters): sort selected values on blur

* remove new icons
2021-05-27 09:36:33 +03:00
Yongjie Zhao
9f54231af1
fix: filterbox apply single value (#14841)
* fix: filterbox apply single value

* fix ci

* fix e2e
2021-05-27 14:00:48 +08:00
Ville Brofeldt
bd2c087f78
fix(native-filters): remove indicators outside scope (#14838)
* fix(native-filters): remove indicators outside scope

* lint
2021-05-27 07:53:52 +03:00
AAfghahi
80d22f5b33
report dropdown (#14852) 2021-05-26 17:17:35 -04:00
Ville Brofeldt
e466066229
chore(native-filters): introduce experimental feature flag (#14814)
* chore(native-filters): introduce experimental feature flag

* break out util and add tests

* fix import
2021-05-26 17:20:33 +03:00
Einat Bertenthal
3224e75193
feat: show max tag count in select filter (#14486)
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
2021-05-26 14:17:58 +03:00
Michael S. Molina
0c0eccb81a
chore: Improves the native filters UI/UX - iteration 3 (#14824) 2021-05-26 10:49:00 +03:00
Einat Bertenthal
dfe030b835
feat: chart gallery search improvement (#14484)
* feat: chart gallery search improvement

* test: adding unit test for VizTypeControl

* fix: lint errors

Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
2021-05-25 18:41:53 +03:00
Kamil Gabryjelski
63dc035d6a
feat(explore): Remove default for time range filter and Metrics (#14661)
* feat(explore): Remove default for time range filter and Metrics

* Merge errors with same messages

* Fix e2e test

* Rename a variable

* Bump packages

* Fix unit tests
2021-05-25 15:55:41 +02:00
Einat Bertenthal
add35f9fe4
fix: set table name width to not hide icons when name is too long (#14489)
* fix: set table name width to now hide icons when name is too long

* fix: table style

Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
2021-05-25 16:44:28 +03:00
Ville Brofeldt
9a96dac3a7
fix(native-filters): loop bug by simplify state handling (#14788) 2021-05-25 15:03:22 +03:00
simcha90
9bf07cc428
fix(native-filters): Manage default value of filters by superset (#14785)
* fix:fix get permission function

* feat: manage default value in superset
2021-05-25 11:25:13 +03:00
AAfghahi
252c64b397
fix: Additional ResultSet tests (#14741)
* fixing tests

* added testing

* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* removed decribe

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-05-24 17:42:09 -04:00
Beto Dealmeida
65f90096fd
fix: use encodeURIComponent when getting table metadata (#14790) 2021-05-24 12:20:31 -07:00
Elizabeth Thompson
fbe6f16052
database modal should close on connect with tab layout (#14771) 2021-05-24 13:13:56 -04:00
Ville Brofeldt
e9657afe4b
feat(native-filters): add search all filter options (#14710)
* feat(native-filters): add search all filter options

* add tests

* fix default value

* implement ILIKE operator

* rebump packages

* fix test

* address comments

* fix state changes coming from application

* fix debouncer
2021-05-24 16:33:59 +03:00
Yongjie Zhao
8484ee653f
fix: extra query in Dashboard when native filter enabled (#14770) 2021-05-24 20:53:14 +08:00
Michael S. Molina
bee6f3ba8a
chore: Improves the native filters UI/UX - iteration 2 (#14753) 2021-05-24 15:22:05 +03:00
simcha90
2b2a8c4bcd
fix(native filters): Fix explore state (#14779)
* fix:fix get permission function

* fix: fix ownState for unsaved explore chart
2021-05-24 14:00:26 +03:00
Kamil Gabryjelski
d03c608ce1
fix(explore): DndColumnSelect not handling controls with "multi: false" (#14737)
* fix(explore): DndColumnSelect not handling controls with multi={false}

* Implement translations for singular and plural cases

* Fix test
2021-05-24 09:53:46 +02:00
Beto Dealmeida
9e13476714
feat: enable user impersonation in GSheets (#14767) 2021-05-22 13:46:36 -07:00
Beto Dealmeida
fb662698ce
fix: add DB should not say it's Postgres (#14766) 2021-05-22 13:46:19 -07:00
Yongjie Zhao
d71b8b38d6
Revert "fix(dashboard): multiple query trigger when native filter enabled (#14734)" (#14762)
This reverts commit 88de4109e7.
2021-05-22 15:11:58 +08:00
Elizabeth Thompson
c7aee4e27b
feat: save database with new dynamic form (#14583)
* split db modal file

* split db modal file

* hook up available databases

* add comment
2021-05-21 18:25:56 -04:00
Michael S. Molina
04d94d2b6c
chore: Removes ColorSchemeControl.less (#14199) 2021-05-21 14:46:01 -07:00
Geido
fb6d21a168
fix(explore): Icons width (#14717)
* Revert width and margin

* Adjust width

* Increase margin
2021-05-21 14:41:55 -07:00
Phillip Kelley-Dotson
f96fea166c
feat: make tabs sticky in homepage (#14695)
* inital commit

* lint

* fix loading state for edit activity

* add dep

* lint fix

* add condition

* lint being lint
2021-05-21 14:37:54 -07:00
Michael S. Molina
1e8b6eb848
fix: Fixes right menu layout in different screen sizes (#14689) 2021-05-21 11:21:21 -07:00
Yongjie Zhao
88de4109e7
fix(dashboard): multiple query trigger when native filter enabled (#14734)
* fix(dashboard): multiple query trigger when native filter enabled

* fix lint

* wip
2021-05-21 09:24:42 -07:00
Kamil Gabryjelski
c831655913
feat(native-filters): Highlight charts affected by focused native filter (#14693)
* Highlight charts affected by focused native filter

* Remove tabs animation on dashboard

* Remove a test that checks for "animated={true}" prop on tabs

* Move hooks types to a separate interface
2021-05-21 15:54:33 +02:00
Phillip Kelley-Dotson
29828f8552
fix: homepage card layout (#14725)
* initial commit

* ensure card lsize
2021-05-20 19:43:12 -07:00
Michael S. Molina
173c486d4a
fix: Unable to clear default value in native select filter (#14739) 2021-05-20 19:42:33 -07:00
David Aaron Suddjian
0e86a6b81c
fix(sqllab): don't store user in localstorage (#14722)
* fix(sqllab): remove user info from localstorage

* filter out user data when loading localstorage
2021-05-20 16:35:56 -07:00
Lyndsi Kay Williams
e4103c272e
feat: Labeled Error-bound Input (#14530)
* Error Input Form created

* Adjusting styling

* testing complete

* Corrected component naming in Form

* testing complete

* Corrected component naming in Form

* Renamed stories file to appropriate name

* add image for alert

* Fixed test

* Switched from px to theme

* Adjusting LabeledErrorBoundInputProps

* validation now accepts a string

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-05-20 14:01:27 -07:00
Michael S. Molina
d924223950
chore: Improves the native filters UI/UX - iteration 1 (#14714) 2021-05-20 19:52:01 +03:00
Yaozong Liu
ea37274180
fix(explore): fix clearing select data causes popover dismiss (#14221)
* fix(explore): fix clearing select data causes popover dismiss

* wip: lint

* wip: lint
2021-05-20 17:26:27 +03:00
Elizabeth Thompson
a9d888ad40
check limiting factor on query results (#14719) 2021-05-19 14:38:57 -07:00
David Aaron Suddjian
26c0b30ec9
fix(explore): add padding to the adhoc filter value select (#14679) 2021-05-19 14:08:41 -07:00
David Aaron Suddjian
152b0d0575
fix(explore): checkbox form control formatting (#14701)
* fix(explore): add inline option for the field that only gets used in one place

* typescriptify

* unnecessary component wrapping
2021-05-19 14:04:09 -07:00
Hugh A. Miles II
4160e45398
feat: Add headers for DatabaseModal (#14647)
* update styles sheets

* save this

* add backend

* update backend reference

* update styles

* my style updates

* sticky header
2021-05-19 13:20:02 -04:00
Hugh A. Miles II
ec0a7922fe
feat: Add Parameters fields to GET Database (#14653) 2021-05-19 10:25:20 -04:00
Michael S. Molina
be8c176df2
chore: Removes less from SliceAdder (#14448) 2021-05-19 00:16:44 -07:00
Geido
a0881fb157
Add filter_box full height (#14657) 2021-05-19 00:13:16 -07:00
Evan Rusackas
c2bd684454
fix(Explore): fixes broken layout of tooltips (#14529)
* fix: moves LESS styles into Emotion, fixes broken layout of tooltips

* fix: tests

* style: linting

* style: better styling location
2021-05-18 21:55:09 -07:00
Beto Dealmeida
c3d1f1084e
feat: redirect 404/500 to static pages (#14677)
* feat: redirect 404/500 to static pages

* Show pages only on html requests
2021-05-18 20:50:39 -07:00
Ajay M
90378ed94e
fix(explore): #10098 boolean filter not working (#14567)
* Restrict operators when column is boolean

* refactor 'isOperatorRelevant' a little bit

* Include 'BOOLEAN' to handle presto

* Update tests

* number column should show bool operators

* fix test - some dbs translate true/false to 1/0

* Fix tests and add linting

* When column type is boolean, show bool operators

* Address PR comments - simplify conditions

* Fix a linting error

* Addressing PR comment - remove unused variables
2021-05-18 14:39:19 -07:00
Ajay M
84e8dc71f6
feat(dashboard): View query of the chart in dashboard (#14667)
* Extract view query component out

* Typo correction

* Fix and rename tests

* Remove logs, and test code

* Rename file - fix tests

* Fix a typo

* Linting errors, add Apache License Header
2021-05-18 13:17:11 -07:00
AAfghahi
a7a011cce5
feat: Better return messages in SQL Editor (#14381)
* Sqllab limit

* Add migration script

* Set default values

* initial push

* revisions

* moving migration to separate PR

* revisions

* Fix apply_limit_to_sql

* all but tests

* added unit tests

* result set

* first draft

* revisions

* made user required prop, added it to all places ResultSet is imported

* changed QueryTable test to allow for useSelector

* Query Table working

* working with heights

* fixed scrolling

* got rid of animated

* fixed tests, revisions

* revisions

* revisions

* heights

* fun with heights

* alert state

* aaron helped me fix this

* better alert messages

* fixed result set test

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-05-18 11:02:06 -07:00
Michael S. Molina
32f5f365d8
fix: Fixes email body when sharing a chart by email (#14664) 2021-05-18 00:43:36 -07:00
Yaozong Liu
2320bd44d4
fix(sqllab): fix error message (#14651) 2021-05-17 16:20:03 -07:00
Geido
b5e9854ddc
Fix tooltip position (#14656) 2021-05-17 15:49:06 -07:00
Geido
9a9f093e63
Add max width (#14663) 2021-05-17 15:31:09 -07:00
Geido
7a050c59e4
fix(explore): Fix column number calculation (#14665)
* Fixes columns calc

* Fix type
2021-05-17 15:30:12 -07:00
Phillip Kelley-Dotson
3ad8b546e6
fix: nav submenu dropdown styles (#14580)
* fix nav submenu dropdown styles

* lint

* fix mobile view styles

* run lint

* address comments

* undo comit lock files

* Update superset-frontend/src/common/components/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-05-17 13:58:02 -07:00
Michael S. Molina
fd8b2cb89b
fix: Fixes group by control icon colors (#14674) 2021-05-17 13:53:32 -07:00
Geido
ea96d95622
Clear search (#14655) 2021-05-17 13:30:16 -07:00
Michael S. Molina
9deb7aa3c1
chore: Replaces Icon with Icons component - iteration 1 (#14469) 2021-05-17 10:24:56 -07:00
Michael S. Molina
4e6169e0f9
chore: Adjust language picker theme to match other menus (#14644) 2021-05-17 10:24:30 -07:00
Michael S. Molina
1b47902e47
chore: Removes react-bootstrap and react-bootstrap-slider (#14641) 2021-05-17 10:22:22 -07:00
Phillip Kelley-Dotson
60f903ff58
fix: fix submenu header double line (#14631)
* fix submenu header

* remove unused css

* lint

* address comment

* address more comments
2021-05-14 14:57:54 -07:00
David Aaron Suddjian
884ded0507
fix: roles undefined on public dashboards (#14648) 2021-05-14 14:28:47 -07:00
David Aaron Suddjian
f16c708fab
fix(dashboard): check edit permissions correctly on frontend (#14626)
* fix(dashboard): check edit permissions correctly on frontend

* fix types, appease linter

* handle nulls better
2021-05-14 12:18:38 -07:00
Michael S. Molina
9cb4a4602f
fix: Fixes top level tabs and automatic scroll (#14624) 2021-05-14 11:50:20 -07:00
Geido
3466cb253e
Fix class name (#14609) 2021-05-14 11:05:52 -07:00
Cedric Gampert
74473e2ad1
fix: do not render favorite favStars and filters for anonymous user (#14120)
* fix: do not render favorite favStar and filter for anonymous user

* fix: prevent anonymous user to trigger the favstar view route

* fix: lint over previous commit

* fix: linter follow-up
2021-05-14 08:05:50 -07:00
Ville Brofeldt
97c9e37c24
perf: memoize db_engine_spec in database (#14638)
* perf: memoize db_engine_spec in sqla table classes

* remove extended cypress timeouts
2021-05-14 12:49:35 +03:00
Evan Rusackas
bf90885828
fix: Removing specific column widths, letting things flex naturally. (#14637) 2021-05-14 12:12:37 +03:00
Phillip Kelley-Dotson
e4e23ea487
fix: fix adhocpopovers tab animate. (#14478)
* fix popover

* addd tabs default css

* fix lint

* fix tests

* address comments

* lint fix

* fix test

* lint
2021-05-13 20:30:27 -07:00
Michael S. Molina
e4d24242b4
refactor: Bootstrap to AntD - NavDropdown (#14557) 2021-05-13 14:54:09 -07:00
Michael S. Molina
d31958cbd2
fix: Fixes #12672 (#14525) 2021-05-13 12:53:24 -07:00
Geido
1e601483e3
fix(explore): Filters Tooltip is not showing the full content (#14618)
* Add getTooltipTitle

* Fix tests
2021-05-13 10:03:22 -07:00
Evan Rusackas
568061e8d4
feat: bumping echarts plugin, adding new treemap plugin (#14560)
* chore: bumping echarts plugin

* feat: Upgrading to new treemap

* bump @superset-ui/plugin-chart-echarts 0.17.47

Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-05-13 22:52:17 +08:00
Ville Brofeldt
3f6bd1e4a4
feat: add generic type to column payload (#14547)
* feat: add generic type to column payload

* feat: add generic type to column payload

* xit flaky test
2021-05-13 09:36:09 +03:00
Evan Rusackas
ad699e8b48
fix: don't show busted label for unknown data types (#14585) 2021-05-12 23:16:54 -07:00
Michael S. Molina
331eb10fb9
refactor: Bootstrap to AntD - Form - iteration 4 (#14546) 2021-05-12 23:01:43 -07:00
Phillip Kelley-Dotson
3eef38f309
refactor: change xsm Icons and dnd icons to new dynamic icons (#14419)
* intial commit

* fix test and add more icons

* fix lint
2021-05-12 22:52:25 -07:00
Phillip Kelley-Dotson
5f7722cb36
fix: error icon spacing in explore (#14597)
* fix error message icon

* lint
2021-05-12 22:42:40 -07:00
Beto Dealmeida
31f406a526
feat: API endpoint to validate databases using separate parameters (#14420)
* feat: new endpoint for validating database parameters

* Rebase

* Remove broken tests
2021-05-12 18:32:10 -07:00
Ville Brofeldt
f1c32b9576
feat(native-filters): add sort metric to select (#14590) 2021-05-12 23:28:45 +03:00
Hugh A. Miles II
0d240c3841
fix: properly keep state on queryEditorSetSql on tabstateview PUT (#14579)
* send queryid up with setSQL

* pass latest query id

* update

* cleanup
2021-05-12 15:20:26 -04:00
Phillip Kelley-Dotson
bfbf767663
fix: dashboard side actions (#14587)
* fix dashboard side actions

* lint being lint
2021-05-12 11:47:29 -07:00
Grace Guo
ada380982b
fix: bring back dashboard perf logger (#14584)
* fix: bring back dashboard perf logger

* add test
2021-05-12 08:25:46 -07:00
Evan Rusackas
6d786d4d47
fix: Adds space under dataset change warning (#14582)
* fix: Adding a little margin under the warning about changing datasets

* feat: moves Alert spacing from a css override to an Alert prop

* fix: prop needs to be optional... proptional

* fix: moving the typing to a better spot, adding the new prop to storybook.

* style: linting
2021-05-12 10:44:14 +08:00
Geido
b960843015
fix: Menu does not appear on scroll in Dashboard (#14566)
* Fix menu

* Fix test
2021-05-11 11:38:58 -07:00
Evan Rusackas
eaeb8f71c8
style: adding padding to the sides of badges, so they look less claustrophobic (#14569) 2021-05-11 11:36:58 -07:00
Geido
3a4536acac
fix: Column name and icons alignment in the Datasource Panel (Explore) (#14551)
* Fix column name alignment

* Fix space wrap
2021-05-11 10:27:46 -07:00
Geido
e21beb76f1
fix: White space between Chart and Data panel in Explore (#14495)
* Adjust white space

* Adjust chart padding
2021-05-10 13:03:43 -07:00
Phillip Kelley-Dotson
cee22e28c0
refactor: remove panel from userinfo component (#14364)
* first pass

* fix merge

* fix lint

* covert pane to styled comp

* add theme

* fix lint

* fix test

* remove unused import
2021-05-08 15:04:16 -07:00
Phillip Kelley-Dotson
e16c4d856e
refactor(navbar): migrate Bootstrap navbar to AntD menus (#14184)
* initial commit

* more polish

* fix types and remove tests

* fix tests, update menu css, add oetc

* fix lint and precommit

* fix test

* update css, address comments

* fix lint

* update submenu for extra buttons

* remove block and lint

* fix lint

* remove block

* adjust margin

* test round 2

* test round 3

* about section

* src/components/Menu/Menu.test.tsx

* remove redundant test

* fmore pointed test

* fix lint

* remove unused css

* fix dashboard nav view

* update comments

* use suggestion

* lint-fix

* move css, fix dropdown and text

* lint

* rearchitect main nav component

* run lint fix

* nit
2021-05-08 14:57:59 -07:00
Michael S. Molina
e7a4734742
chore: Removes tabs animation by default (#14496) 2021-05-08 14:22:16 -07:00
Michael S. Molina
79ff96269b
refactor: Bootstrap to AntD - Form - iteration 3 (#14502) 2021-05-08 12:34:52 -07:00
Evan Rusackas
4f000cc8d1
fix: bringing metric type icon styles into SelectControl (#14531) 2021-05-08 15:47:25 +08:00
Ville Brofeldt
66a4c94a1e
fix(chart-data): handle url_params in csv export and native filters (#14526) 2021-05-07 21:07:44 +03:00
simcha90
e8e838e279
feat(native-filters): Auto apply changes in FiltersConfigModal (#14461)
* fix:fix get permission function

* feat: auto apply changes after save filters config modal

* fix: repopulate default values

* test: fix tests

* test: fix tests

* fix: fix CR notes

* fix: fix CR notes
2021-05-07 13:06:59 +03:00
Ville Brofeldt
680c96ec54
feat(explore): collapse time section if no ts columns (#14493)
* feat(explore): collapse time section if no ts columns

* fix viz change bug

* fix test
2021-05-07 11:55:54 +03:00
Mayur
05c24056b5
add new plugin (#14516) 2021-05-07 10:21:00 +03:00
Ville Brofeldt
19b408b08d
chore: bump superset-ui to 0.17.44 (#14515) 2021-05-07 09:31:34 +03:00
Geido
10a53b7f5d
fix: Add extra check to loggerMiddleware (#14492)
* Add extra check

* Update superset-frontend/src/middleware/loggerMiddleware.js

Co-authored-by: Evan Rusackas <evan@preset.io>

* Fix linting issue

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-05-06 22:39:58 -07:00
Michael S. Molina
68058b0ad9
chore: Moves spec files to the src folder - iteration 4 (#14380) 2021-05-05 22:01:05 -07:00
Michael S. Molina
331310db9b
refactor: Bootstrap to AntD - Form - iteration 2 (#14379) 2021-05-05 22:00:37 -07:00
Michael S. Molina
fa510df624
chore: Adds QueryParamProvider to testing helper (#14195) 2021-05-05 21:58:40 -07:00
Rob DiCiuccio
fa0915d9e6
Attempt to reduce asyncEvent test flakiness (#14497) 2021-05-05 19:34:13 -07:00
Elizabeth Thompson
9b42eec064
feat: db modal split (#14470)
* refactor: split db modal file (#14436)

* split db modal file

* fix tests

* fix extra options

* update database id methodology
2021-05-05 19:03:19 -04:00
AAfghahi
12baba03cc
fix: Query History (#14498)
* fix for QUery History

* fixed
2021-05-05 17:00:32 -04:00
Michael S. Molina
f9567efe81
fix: Fix #13831 (#14490) 2021-05-05 13:48:48 -07:00
Ajay M
c832542570
fix(dashboard): Prevent char overflow when displaying chart description (#14467)
* Force refresh the chart on toggle display description

* Use forceUpdate instead of forceRefresh

* Instead of forceUpdate, add a state for desciption height

Co-authored-by: Ajay Mancheery <ajaymancheery@Ajays-MacBook-Pro.local>
2021-05-05 13:30:10 -07:00
Jesse Yang
ae256a9119
chore: bump sankey and pivot table chart to 0.17.43 (#14477) 2021-05-05 11:17:18 -07:00
Evan Rusackas
8ccd19629a
fix: explore flex layout is sometimes too short (#14481) 2021-05-05 10:21:15 -07:00
Michael S. Molina
7182a1b390
chore: Removes common storybook (#14418) 2021-05-05 09:53:14 -07:00
Kamil Gabryjelski
b030c9801c
chore: Move styles from .less stylesheet to emotion in Explore (#14485)
* Move some styles from .less stylesheet to emotion in Explore

* Replace Global styles with local styled components

* Address comments
2021-05-05 15:36:52 +02:00
Ville Brofeldt
93c7f5bb44
fix(annotations): pass force param to annotation request (#14483)
* fix(annotations): pass force param to annotation request

* use strtobool

* add util for parsing bools
2021-05-05 13:52:17 +03:00
Ville Brofeldt
5aef6bccd1
feat(viz): add funnel chart (#14480) 2021-05-05 14:26:12 +08:00
Jesse Yang
23014e9233
chore: upgrade @emotion (#14454) 2021-05-04 15:26:16 -07:00
Elizabeth Thompson
2242f74818
Revert "refactor: split db modal file (#14436)" (#14466)
This reverts commit 2d991ec359.
2021-05-04 14:40:58 -04:00
David Aaron Suddjian
21cf12a480
chore(dashboard): Integrate dashboard app into the SPA bundle (#14356)
* chore(dashboard): Integrate dashboard app into the SPA bundle

* fix url params

* change variable name

* change title correctly

* custom css

* lint

* remove unused file

* remove content assertions from dashboard tests

* fix case with missing bootstrap data

* fix: respect crud views flag

* crud views -> spa

* remove unused dashboard templates

* fix: remove unused variable

* fix: missed a spot with the crudViews -> spa

* router link to dashboard from dashboard list page

* link using the router when in card mode

* lint

* fix tests, add memory router

* remove  dashboard app files

* split up the bundle a little more

* use webpack preload
2021-05-04 08:51:17 -07:00
Amit Miran
158ac302d8
chore: bump table plugin to 0.17.42 (#14460) 2021-05-04 17:41:02 +03:00
simcha90
582900c170
perf(native-filters): Load native filters after charts (#14443)
* fix:fix get permission function

* refactor: filter default value

* refactor: update default value loading

* refactor: apply defaultValues

* lint: fix lint

* lint: fix lint

* test: fix test

* refactor: use extraFormData for reload charts

* feat: load native filters after after charts

* feat: load filters after charts

* fix: revert changes

* test: fix timers

* test: fix tests
2021-05-04 16:07:40 +03:00
Duy Nguyen Hoang
9a22fb00d9
fix: CSV Export permission is not consistent (#13713) 2021-05-04 10:19:58 +03:00
Jesse Yang
a75e4af99b
fix(viz): bump superset-ui to fix bugs in table and graph chart (#14438) 2021-05-03 16:23:42 -07:00
Elizabeth Thompson
2d991ec359
refactor: split db modal file (#14436)
* split db modal file

* fix tests
2021-05-03 17:00:41 -04:00
simcha90
bbb1f2d757
perf(native-filters): avoid unnecessary reloading of charts (#14408)
* fix:fix get permission function

* refactor: filter default value

* refactor: update default value loading

* refactor: apply defaultValues

* lint: fix lint

* lint: fix lint

* test: fix test

* refactor: use extraFormData for reload charts

* test: fix tests

* test: fix tests

* test: fix tests
2021-05-03 14:56:41 +03:00
simcha90
abbf4bf05a
refactor(native-filters): allow cascading only for filter_select (#14441)
* fix:fix get permission function

* refactor: allow cascading only for filter_select
2021-05-02 13:16:10 +03:00
simcha90
1f8de1d06c
test(maximize-chart): Add tests to maximize chart action (#14371)
* fixed FullSize charts broken #13600

* Update ChartHolder.jsx

* fix:fix get permission function

* test: adding tests to full screen

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

Co-authored-by: toop <mytoop@163.com>
2021-05-02 09:27:38 +03:00
AAfghahi
e507508b48
feat: Logic added to limiting factor column in Query model (#13521)
* Sqllab limit

* Add migration script

* Set default values

* initial push

* revisions

* Update superset/views/core.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* moving migration to separate PR

* with migration

* revisions

* Fix apply_limit_to_sql

* all but tests

* added unit tests

* revisions

* Update superset/sql_lab.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/sql_parse.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* fixed black issue

* Update superset/views/core.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* updated logic

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-04-30 15:15:18 -07:00
Hugh A. Miles II
efcdc8cb9b
change relationship (#14435) 2021-04-30 17:27:05 -04:00
Sam Faber-Manning
b147fa84e2
fix: parse simple string error message values (#14360)
* fix parsing error messages that are formatted as single strings

* fix other instances of error typing
2021-04-30 09:30:53 -07:00
Ville Brofeldt
319125ec3b
fix(native-filters): fix filter scope error (#14426) 2021-04-30 12:20:02 +03:00
Michael S. Molina
a52ff13b5d
chore: Moves Card to the components folder (#14139) 2021-04-29 11:51:41 -07:00
Geido
545e257537
feat: Dynamic imports for the Icons component (#14318)
* Add aria-label and twotone

* Enhance LazyIcon

* Fix tests and solve ject warnings

* Add new line

* Revert package-lock to master

* Fix failing test

* Implement icon overrides

* Fix failing storybook

* Clean up

* Improve var name
2021-04-29 11:49:39 -07:00
Ville Brofeldt
1c16261651
fix(native-filters): always show filters without dataset (#14409) 2021-04-29 14:25:39 +03:00
eriendeng
2dc3fa3f21
fix error getting partitionQuery from table.partition (#14369)
Co-authored-by: eriendeng <eriendeng@tencent.com>
2021-04-29 10:42:11 +03:00
Michael S. Molina
1d6a746a09
refactor: Boostrap to AntD - Tabs (#14048) 2021-04-28 23:49:50 -07:00
Ville Brofeldt
4410fd047e
fix(native-filters): default value not populated on second opening (#14401) 2021-04-29 09:09:47 +03:00
Michael S. Molina
b38aadf9e4
chore: Moves the branding folder to the assets folder (#14166) 2021-04-28 22:17:21 -07:00
Ville Brofeldt
183b5ae362
fix(sqllab): fix error due to anonymous user (#14390) 2021-04-28 19:57:45 +03:00
Ville Brofeldt
43ee52be57
fix(native-filters): force update control value on change (#14385)
* fix(native-filters): force update control value on change

* fix test
2021-04-28 11:41:22 +03:00
simcha90
fc0c1155c2
fix(native-filters): fix lint (#14387)
* fix:fix get permission function

* lint: fix types
2021-04-28 10:16:21 +03:00
simcha90
2486fd4f6d
feat(native-filters): Show/Hide filter bar by metdata ff (#14261)
* fix:fix get permission function

* feat: hide native filters by metadata

* fix: fix show_native_filters name

* fix: metadata

* chore: add migration to hide native_filters in all existing dashboards

* chore: fix pre-commit

* fix: make migration migration dashboard with filter_box only

* fix: pre-commit

* feat: hide filter bar if no permission edit and no filters

* fix: remove migration

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-04-28 07:49:03 +03:00
ʈᵃᵢ
86d2a616c1
fix(emotion): add separate namespace for menu app (#14362) 2021-04-27 15:53:55 -06:00
Evan Rusackas
8e6803f65f
chore: Bumping lodash version in Superset (#14203)
* Bumping lodash in main package

* new package lock with updated lodash
2021-04-27 14:54:56 -06:00
Hugh A. Miles II
44c09b5383
feat: Setup supersetText configuration to overwrite errors (#14256)
* Setup error message overwrite config`

* fix

* bad reabse

* bad rebase 2

* remove unneeded comment

* working dynamic importing

* saveeee

* working textUtil file

* add ignore tslint

* fix linting

* fix linting

* import order

* setup guard statements

* linting again

* linting again

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-04-27 15:03:35 -04:00
Ville Brofeldt
40fb94dcca
feat(native-filters): add optional sort metric to select filter (#14346)
* feat(native-filters): add optional sort metric to select filter

* use verbose name when defined

* fixes

* lint

* disable flaky test

* disable flaky test

* disable flaky test
2021-04-27 20:28:38 +03:00
Ville Brofeldt
87a895cc4a
feat(native-filters): add refresh button to default value picker (#14375)
* feat(native-filters): add refresh button to default value picker

* skip flaky test
2021-04-27 19:18:34 +03:00
Kamil Gabryjelski
41ccebce91
feat(native-filters): Use datasets in dashboard as default options for native filters (#14374)
* Use defaultOptions in dataset picker

* Remove console log

* Temporarily skip failing test
2021-04-27 18:04:57 +03:00
Kamil Gabryjelski
20ab0869fa
feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters (#14313)
* Implement adhoc filters in Range and Select native filters

* Add time picker

* Remove additional filters from datamask

* Create separate stylesheet for AdhocFilterControl in native filters

* Rename Time picker to Time range

* Fix columns in AdhocFilter empty when creating a new filter

* Skip flaky test
2021-04-27 11:08:05 +02:00
simcha90
03e4a5b6b7
fix(native-filters): Update filter saving (#14370)
* fix:fix get permission function

* fix: not reload charts after save filters

* fix: not reload charts after save filters

* fix: temp commit type

* lint: add typing
2021-04-27 11:20:04 +03:00
Michael S. Molina
d0be1ff79e
chore: Moves Tabs to the components folder (#14136) 2021-04-27 00:15:21 -07:00
Amit Miran
22f9e12a3b
chore: bump 0.17.38 (#14355)
* chore: bump 0.17.37

* chore: update package-lock

* chore: revert echarts upgrade

* bump echarts package to 0.17.38

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-04-27 09:30:39 +03:00
Phillip Kelley-Dotson
69f2af9fb6
refactor(addslicecontainer): move slice container panel from bootstrap panel to ant-d (#14035)
* slice boostrap panel to ant-d

* remove panel

* remove space

* fix lint

* fix addslicecontainer

* Update AddSliceContainer.tsx
2021-04-26 22:13:49 -07:00
Sam Faber-Manning
6898dd916f
update default cron settings for new alerts and reports (#14363) 2021-04-26 18:11:15 -07:00
Michael S. Molina
4fbb572568
refactor: Bootstrap to AntD - Form - iteration 1 (#14106) 2021-04-26 15:03:53 -07:00
Lily Kuang
876779865c
feat(alert/report): update content format radio buttons (#14235)
* update content format selection ui

* translations

* update test
2021-04-26 11:33:55 -07:00
Ville Brofeldt
8a0d321084
fix(native-filters): allowClear only when required not checked (#14353)
* fix(native-filters): allowClear only when required not checked

* Update superset-frontend/src/filters/components/Select/controlPanel.ts

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2021-04-26 20:48:17 +03:00
simcha90
7ff35dfdfb
fix(native-filters): Fix indicators (#14334)
* fix:fix get permission function

* fix: hide featured filters

* test: fix FF in tests

* test: fix FF in tests

* fix: fix unset cross filters
2021-04-26 13:22:11 +03:00
simcha90
3e8bf96642
fix(native-filters): Fix first loading of charts (#14332)
* fix:fix get permission function

* fix: fix unnecessary loading for native filters

* test: fix mocks
2021-04-25 13:58:53 +03:00
Ville Brofeldt
e392e2ed39
feat(native-filters): add option to create value in select filter (#14314)
* feat(native-filters): add option to create value in select filter

* address comments
2021-04-24 08:26:24 +03:00
Michael S. Molina
aada73302f
chore: Moves spec files to the src folder - iteration 3 (#14202) 2021-04-23 16:19:12 -07:00
Michael S. Molina
1bc73f2cba
chore: Moves spec files to the src folder - iteration 2 (#14201) 2021-04-23 16:18:46 -07:00
Michael S. Molina
98b450aa76
chore: Moves spec files to the src folder - iteration 1 (#14200) 2021-04-23 16:18:16 -07:00
Michael S. Molina
58534b36c5
chore: Improves Icons storybook (#14193) 2021-04-23 09:57:12 -07:00
Ville Brofeldt
2b57ebaffd
feat(native-filters): add tooltip to control values (#14312) 2021-04-23 19:29:51 +03:00
Yongjie Zhao
67535bb320
refactor: reorganize dateFilterUtils.tx (#14309)
* refactor: reorganize dateFilterUtils.tx

* move spec to src dirctory
2021-04-23 16:05:50 +08:00
Yongjie Zhao
d1afca4fa1
fix: custom TimeRange can not input value (#14084) 2021-04-23 15:20:37 +08:00
Michael S. Molina
b963624e12
refactor: Boostrap to AntD - Row/Col (#14100) 2021-04-22 20:57:17 -07:00
Michael S. Molina
3e23c103dc
chore: Moves WarningIconWithTooltip to own folder (#14123) 2021-04-22 13:50:11 -07:00
zuzana-vej
86233d1676
chore: SQLLab row limit warning using Alert component (#14298) 2021-04-22 10:12:46 -07:00
Lyndsi Kay Williams
70cfb7752c
chore: Code cleanup in DatabaseModal (#14196) 2021-04-21 13:41:50 -04:00
Jesse Yang
2dd20df03d
fix(dashboard): draft dashboards should be viewable (#14207)
* fix(dashboard): draft dashboards should have open access

* Remove a duplicate test
2021-04-21 09:54:51 -07:00
Yaozong Liu
852e840575
fix(explore): CUSTOM SQL tab should automatically update (#14194)
* fix(explore): CUSTOM SQL tab should automatically update

* fix(explore): CUSTOM SQL tab should automatically update

* fix: lint

* fix(explore): default value

Co-authored-by: Yongjie Zhao <yongjiezhao@apache.org>

Co-authored-by: liuyaozong <liuyaozong@baijiahulian.com>
Co-authored-by: stephenLYZ <vueact@gmail.com>
Co-authored-by: Yongjie Zhao <yongjiezhao@apache.org>
2021-04-21 14:30:18 +08:00
Yongjie Zhao
0dfb32cf08
fix: incorrect module reference (#14258) 2021-04-21 10:37:24 +08:00
Lyndsi Kay Williams
a846015f4d
fix: Center each import icon and add a tooltip II (#14192) 2021-04-20 19:59:48 -04:00
Hugh A. Miles II
392d8a8107
fix: Handle bad permission errors for bigquery test connections (#14147)
* starter make file

* yea

* move messaging to config

* Delete Makefile

* remove

* checkout

* check for db generic errors

* checkout bad files

* add proper message

* add docs for new permissions codes

* Update superset/errors.py

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>

* Update superset/errors.py

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>

* rename var

* starter regex

* fix

* fix

* fix linting

* update test

* yerp

* fixed test

* added regex

* Apply suggestions from code review

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* address comments

* update docs

* prettier

* fux

* add space

* Update errors.py

* Update types.ts

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-04-20 19:19:36 -04:00
Elizabeth Thompson
ff665fa5a7
feat: restyle database modal (#14092)
* restyle database modal

* change name of tab to Basic

* update test with RTL better RTL render statement

* change color and position of required asterisk

* refactor db logic
2021-04-20 18:21:07 -04:00
Erik Ritter
97e086051c
chore: bump superset-ui (#14253) 2021-04-20 15:16:58 -07:00
Amit Miran
13d4902711
feat(native-filters): select group by support (#14217)
* chore: initial commit

* feat: groupby filter

Co-authored-by: Simcha Shats <simcha.shats@nielsen.com>
2021-04-20 18:52:33 +03:00
Michael S. Molina
42fb2286ad
chore: Moves Dropdown to the components folder (#14126) 2021-04-20 08:48:28 -07:00
Michael S. Molina
d1b458c4c5
chore: Moves Radio to the components folder (#14133) 2021-04-20 08:48:10 -07:00
Michael S. Molina
8441590812
chore: Moves Tooltip to the components folder (#14137) 2021-04-20 08:47:47 -07:00
Michael S. Molina
ec79b7be1f
chore: Moves the staticPages folder to the assets folder (#14167) 2021-04-20 08:47:24 -07:00
simcha90
7e5440a359
test(native-filters): Filter config modal test (#14245)
* test: add tests for filter bar

* test: merge filter bar tests with master

* test: add test for filter set

* test: filter set tests

* test: merge with master

* test: fix tests for filter bar

* test: filter config modal

* test: add select filter

* feat: filter config modal

* lint: fix lint

* lint: fix TS

* test: test testWithId
2021-04-20 14:07:08 +03:00
Kamil Gabryjelski
6119d8e998
Fix filter edit popover not opening in DnD mode (#14243) 2021-04-20 11:45:48 +02:00
simcha90
d386e66f59
test(native-filters): add integration tests for filter bar (#14098)
* test: add tests for filter bar

* test: merge filter bar tests with master

* test: add test for filter set

* test: filter set tests

* test: merge with master

* test: fix tests for filter bar

* fix: fix CR notes

* fix: fix CR notes
2021-04-20 12:24:12 +03:00
simcha90
9d67b46576
fix(native-filters): fix remove native filters (#14218)
* fix:fix get permission function

* fix: clean data mask on chart removing

* refactor: fix reducer
2021-04-20 09:48:23 +03:00
Michael S. Molina
c2d11ac53e
chore: Moves InfoTooltip to the components folder (#14128) 2021-04-19 16:25:29 -07:00
Amit Miran
ca359402bd
chore: bump package.json (#14222)
* chore: bump package.json

* chore: bump package.json and lock
2021-04-19 06:52:24 +03:00
simcha90
c01f8101eb
fix(cross-filters): Fix missed metadata (#14220)
* fix:fix get permission function

* fix: fix missed metadata case
2021-04-18 18:46:38 +03:00
Michael S. Molina
77a9cc7088
chore: Moves Collapse to the components folder (#14124) 2021-04-16 15:55:04 -07:00
Michael S. Molina
b83ee46d0f
chore: Moves Modal to the components folder (#14130) 2021-04-16 15:49:53 -07:00
Beto Dealmeida
c7112d1c48
feat: error messages for Presto connections (#14172)
* chore: rename connection errors

* feat: error messages for Presto connections

* Add unit tests

* Update docs/src/pages/docs/Miscellaneous/issue_codes.mdx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-04-16 15:49:47 -04:00
Erik Ritter
01f13c5678
chore: type some SQL Lab components (#14178)
* chore: type some SQL Lab components

* Update superset-frontend/src/SqlLab/components/QueryHistory.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-16 09:16:16 -07:00
Ville Brofeldt
7e0e9ac3fc
feat(viz): add mixed and radar chart (#14197) 2021-04-16 23:59:32 +08:00
Kamil Gabryjelski
cab110e354
Enable the new pivot table (#14187) 2021-04-16 10:46:50 +02:00
Michael S. Molina
be78cd1a1f
chore: Configures Jest to ignore storybook files when collecting coverage statistics (#14164) 2021-04-15 23:17:31 -07:00
Michael S. Molina
018caa528a
chore: Moves Switch to the components folder (#14135) 2021-04-15 22:54:26 -07:00
Michael S. Molina
e4c8084285
chore: Moves DropdownButton to the components folder (#14127) 2021-04-15 22:46:18 -07:00
Michael S. Molina
ec75dc178b
chore: Moves CronPicker to the components folder (#14125) 2021-04-15 22:44:12 -07:00
Phillip Kelley-Dotson
38a1f65646
chore(toggle thumbnails): use localstorage for toggle (#14013)
* use localstorage for toggle

* fix lint

* add check
2021-04-15 22:03:46 -07:00
Lily Kuang
df7e2b6a8e
feat(alert/report): chart as csv format attachment for email and slack (#13828)
* add ui for setting report format

* refactor default notification format

* init csv data alert report

* add report format to report_schedule model

* add ALERTS_ATTACH_REPORTS feature flag

* fix lint

* update check image tag

* fix migrations

Co-authored-by: samtfm <sam@preset.io>
2021-04-15 14:07:49 -07:00
Beto Dealmeida
21c6efea67
chore: rename connection errors (#14169) 2021-04-15 10:57:02 -07:00
Phillip Kelley-Dotson
fbf0149d8b
refactor(userInfo): userinfo panel to styled component (#14090)
* migrate component

* fix lint

* remove collapse

* fix test
2021-04-15 09:24:34 -07:00
AAfghahi
eadff5f41e
feat: invalid DB name error messages (MySQL/Postgres/Redshift) (#14146)
* initial DB custom errors for mysql

* added redshift and postgres
2021-04-15 08:02:47 -07:00
simcha90
8ef572a412
refactor(native-filters): update dataMask and ExtraFormData schema (#13983)
* refactor: updates usage of `ownFilters` to `ownState`

* refactor: update dataMask (final)

* lint: fix lint

* refactor: revert feat

* fix: fix missed chart configuration

* add filter set migration

* apply new changes

* fix migration revision

* update migration

* fix jest mock

* js lint

* fix test types

* update tests and types

* remove append_form_data from tests

* fix findExistingFilterSet tests

* add migration test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-04-15 17:43:29 +03:00
Ville Brofeldt
68e11cd47f
fix(dashboard): filter set hydration not working (#14129) 2021-04-15 06:09:12 +03:00
AAfghahi
f1acb2f974
horizontal scroll (#14140) 2021-04-14 16:31:13 -07:00
Jesse Yang
6755083e3a
fix(dashboard): incorrect perm for users with multiple roles (#14148) 2021-04-14 16:04:09 -07:00
Lyndsi Kay Williams
36bd6d8303
feat: FE: Import for Queries II (#14091)
* Copied changes over

* Tests passing

* Import testing complete
2021-04-14 16:02:35 -07:00
krsnik93
ef1f048d81
feat: add Echarts gauge chart (#14072)
* feat: echarts gauge chart

* fix

* change plugin order

Co-authored-by: root <root@superset.ikrsnik.devonly.net>
2021-04-14 09:25:26 -07:00
Geido
474f1e2044
test: Add tests for Dashboard Header and HeaderActionsDropdown components (#13973)
* Add tests for HeaderActionsDropdown - WIP

* Fix trigger node

* Add types

* Clean up

* Add tests for Header

* Delete obsolete tests

* Add factory and clean up

* Add opposite case

* Fix file name

* Include latest changes
2021-04-14 06:54:24 -07:00
dependabot[bot]
a548b69201
build(deps): bump urijs from 1.19.4 to 1.19.6 in /superset-frontend (#13393)
Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.4 to 1.19.6.
- [Release notes](https://github.com/medialize/URI.js/releases)
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md)
- [Commits](https://github.com/medialize/URI.js/compare/v1.19.4...v1.19.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-13 23:15:27 -07:00
Michael S. Molina
cfe927bebb
test: Adds tests for the FixedOrMetricControl component (#13705) 2021-04-13 15:26:31 -07:00
Michael S. Molina
c8a794368d
refactor: Bootstrap to AntD - ListGroup (#13996)
* refactor: Bootstrap to AntD - ListGroup

* Improves theme handling on touched files
2021-04-13 15:26:02 -07:00
AAfghahi
b77477a9dd
feat: invalid hostname and password error messages (MySQL) (#14089)
* custom errors for mySQL

* initial custom errors and tests for MySQL

* revisions
2021-04-13 14:42:31 -07:00
dependabot[bot]
83b8d1bc1b
build(deps): bump y18n from 4.0.0 to 4.0.1 in /superset-frontend (#13886)
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-13 13:07:45 -07:00
Jesse Yang
3c88d2542c
fix(country-map): update geojson and control layout (#14063) 2021-04-13 10:14:27 -07:00
simcha90
f453287a07
fix:fix get permission function (#14099) 2021-04-13 09:36:13 -07:00
Lyndsi Kay Williams
6392d41ac9
fix: Fixed saved query export (#14086)
* Fixed saved query export

* Te
sting implemented
2021-04-13 08:09:08 -07:00
Amit Miran
8c5b6b1263
feat(dashboard_rbac): provide data access based on dashboard access (#13992)
* feat: provide data access based onb dashboard access

* chore: adjust code after CR comments

* fix: add brackets

* fix: type

* chore: add tests

* fix: pre-commit

* fix: pre-commit and lint

* fix: fix test

* fix: pre-commit

* fix: fix local pylint warnings

* revert: birth_names pylint  change bc it  affects tests

* Update superset/security/manager.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset/security/manager.py

* Update tests/utils_tests.py

* fix: after CR

* fix: after CR from ville

* chore: update roles description

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-04-13 16:23:31 +03:00
Amit Miran
9c5264af0d
feat(can_share): can share chart and dashboard (#14076)
* feat: share chart  - can_share_chart
share dashboard can_share_dashboard

* fix: pre-commit

* fix: userCanShare tests

* fix: after hugh CR

* fix: adjust after spa refactor
2021-04-13 13:54:14 +03:00
Michael S. Molina
b394733ff3
test: Adds tests to the UndoRedoKeyListeners component (#13919) 2021-04-12 23:51:57 -07:00
Michael S. Molina
55257ab48c
chore: Adds dataMask reducer to reducerIndex (#13951) 2021-04-12 23:50:20 -07:00
Geido
11869dc076
test: Tests audit for the Dashboard FilterBar (#13916)
* Add FilterBar tests

* Finalize FilterBar tests

* Add tests for FilterBar Header

* Add tests for FilterBar FilterConfigurationLink

* Add tests for FilterBar FilterSets EditSection

* Add tests for FilterBar FilterSets

* Clean up

* Add tests for FilterBar FilterSetUnit

* Add tests for FilterBar FilterSets FiltersHeader

* Add tests for FilterBar FilterSets Footer

* Fix linting

* Fix import

* Fix minor changes

* Fix import

* Add factory and clean up
2021-04-12 23:28:19 -07:00
Michael S. Molina
92a66921e0
refactor: Bootstrap to AntD - Slider (#13989) 2021-04-12 16:28:06 -07:00
Phillip Kelley-Dotson
4bb29b6f04
chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306)
* add hook for future async api calls

* test to see conflict

* add async middleware and update reducers

* working async dashboard load

* implement getcharts api

* add user permissions to explore and dashboard bootstrap data

* integrate api calls with getinitial state

* update namings

* accept an id or a slug in the dashboard charts api

* add permissions function

* fix merge

* update state

* get dashboard charts by id or slug

* fix undefined states

* variable names

* stop using some more bootstrap data

* fix metadata reference

* remove unused bootstrap from the template

* add errorboundry to dashboard

* refactoring, fixing

* update permissions

* add just roles

* id is supposed to be a string

* unused vars

* get datasources from api

* make onError optional

* use resource hooks, better error boundary

* add loading state for dashboardroute

* remove console

* add conditional

* more conditionals

* testing out a possible fix for cypress

* convert edit/standalone test to cypress

* remove bootstrappy assertions

* lint

* fix dashboard edit history issue

* rename stuff

* address recent native filters schema change

* remove unused getInitialState

* remove .only from test

* hooksy redux usage

* Revert "more conditionals"

This reverts commit 25c8ed61b4.

* cleanup

* undo unnecessary change

* actually need conditions here

* certainty

* Revert "certainty"

This reverts commit 77dea1915b.

* more permutations (untested yolo)

* Update superset-frontend/src/chart/chartReducer.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* import style

* comment

* cleaner dashboardInfo

* remove debug code

* use memo for getPermissions

* fix lint

* adjust name/location of DashboardPage

* move logic for REMOVE_SLICE_LEVEL_LABEL_COLORS to DAO

* stop using full_data()

* remove unused (and now useless) json=true query param

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2021-04-12 16:10:29 -07:00
Beto Dealmeida
786dadc836
feat: invalid password error message (Postgres) (#14038) 2021-04-12 14:03:21 -07:00
Kamil Gabryjelski
bf22487e23
Make chart exclude itself from cross filtering (#14046) 2021-04-12 14:08:07 +03:00
simcha90
d6bd160250
fix: fix bug when remove chart not removing it's related cross filter data (#14081) 2021-04-12 10:54:31 +03:00
simcha90
468638c5b8
feat(native-filters): Add default first value to select filter (#13726)
* feat: native filters first default value

* fix: fix CR notes

* feat: add support for `Place` type

* refactor: sync with master

* feat: add first value to Select filters

* refactor: fix CR notes

* refactor: updates usage of `ownFilters` to `ownState`

* Revert "refactor: updates usage of `ownFilters` to `ownState`"

This reverts commit 58b91998

* fix: revert mocks

* fix: fix CR notes

* chore: update package json

* chore: update package json

* chore: update package json

* test: fix tests

* fix: fix BE empty metrics

* lint: fix lint

* fix: fix BE empty metrics

* refactor: fix Cr notes
2021-04-12 09:22:33 +03:00
Bruno Motta
66201e7c55
test: FilterSets-utils (#14028)
* Tests for "nativeFilters/FilterBar/FilterSets/utils"

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/generateFiltersSetId.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Fix: Lint error

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:07:37 -07:00
Bruno Motta
95ed8735f1
chore: well component to card component(Updating PR #12200) (#14033)
* replace Well componenet with Card component

* Fix lint errors

* Fix lint

* Addressing comments

* Addressing comments

* Fix lint errors

* Exporting Card from index.tsx and adding storybook variants

* Fix some refactoring

* Fix errors

* solving conflicts and lint errors

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:06:44 -07:00
Ville Brofeldt
bfa6140b15
fix(viz): bump superset-ui 0.17.30 (#14045)
* fix(viz): bump superset-ui 0.17.30

* fix test

* bump react-table to match the version in superset-ui
2021-04-09 20:49:38 +03:00
Bruno Motta
ff08d423a9
Tests for ControlItems (#13975) 2021-04-09 09:54:35 -07:00
Bruno Motta
1920811cf2
test: Tabs (#13941)
* Test for Tabs component

* Fix: "creteProps" to "createProps"

* Update superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:54:16 -07:00
Bruno Motta
011af825a9
test: Tab (#13937)
* Tests for Tab component

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:53:54 -07:00
Bruno Motta
ec3f8d07f4
test: SliceHeader (#13888)
* tests for SliceHeader

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:14:16 -07:00
Bruno Motta
36f101e500
test: ShareMenuItems (#13860)
* Tests for ShareMenuItems

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:13:05 -07:00
Bruno Motta
c0017b3262
Tests for ColumnSelect (#13991) 2021-04-09 09:02:39 -07:00
Beto Dealmeida
c60a93db9c
feat: add extract_errors to Postgres (#13997)
* feat: add extract_errors to Postgres

* Add unit tests

* Fix lint

* Fix unit tests
2021-04-08 13:24:54 -07:00
Michael S. Molina
784d29b57c
chore: Moves Fade component into TableElement (#13458) 2021-04-08 12:56:21 -07:00
Jack Fragassi
5dd971eaf5
fix: execution log crashes for logs with no uuid (#13998)
* Fix execution log when no execution id

* Use single quotes

* Pretty
2021-04-08 06:50:23 -07:00
Lyndsi Kay Williams
7697bc297c
feat: FE: Export for Queries II (#13981)
* package.lock upgrade

* Copied changes from old PR

* Cleaned up ternaries

* Added export check for VERSIONED_EXPORT feature flag
2021-04-08 09:22:15 -04:00
Michael S. Molina
b5c95c537c
test: Adds tests to the CssEditor component (#13933) 2021-04-07 14:40:24 -07:00
Geido
6c06866583
test: Tests and Storybook entry for the IndeterminateCheckbox Component (#13502)
* Add tests for IndeterminateCheckbox

* Add storybook entry

* Fix linting issue

* Remove mocked icon

* Add jest.fn to mockedProps
2021-04-07 13:34:19 -07:00
Bruno Motta
dcb9f7cff1
test: DataTablesPane (#13736)
* Tests for DataTablesPane

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Using factory for props

* replacing "data-test"

* removing "act" from tests and fix error

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-07 11:35:27 -07:00
Bruno Motta
284402c583
test: AdhocMetricEditPopover (#13787)
* tests for AdhocMetricEditPopover

* replace "factoryProps" for "createProps"

* removing unnecessary if

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-04-07 10:34:29 -07:00
Geido
cc075f23ef
test: Tests and Storybook entry for the TableView Component (#13501)
* Refactor TableView tests

* Add more tests

* Add storybook entry

* Remove unnecessary control
2021-04-07 10:33:55 -07:00
Yongjie Zhao
f06d53455c
fix: annotation modal dateRangePicker saved invalid value (#13969) 2021-04-07 22:02:29 +08:00
Yongjie Zhao
e3efaba775
test: prevent flaky frontend unit test case (#13984)
* test: prevent flaky unit test case

* Update superset-frontend/spec/javascripts/datasource/ChangeDatasourceModal_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-07 20:08:04 +08:00
Yongjie Zhao
56dc74e09f
fix: Pie chart not displayed in viz (#13987) 2021-04-07 17:08:24 +08:00
Beto Dealmeida
a82d72fef6
feat: initial work to make v1 API compatible with SIP-40 and SIP-41 (#13960)
* WIP

* Use errorhandler

* Add response schema

* Fix status on HTTPException

* s/found/encountered/g

* Fix test

* Fix lint

* Fix lint and test
2021-04-06 22:06:32 -07:00
Bruno Motta
1638e6e932
test: exploreUtils (#13719)
* Tests for exploreUtils

* removing eslint-disable

* applying factory

* Removing skip tests and code comments.

* Improving test name

* remove comments

* Improving "shouldUseLegacyApi" tests

* fixing typo
2021-04-06 21:35:34 -07:00
Michael S. Molina
4602ead10c
test: Adds tests to the filter scope components (#13887) 2021-04-06 21:31:35 -07:00
Bruno Motta
ab0f5e3087
test: PropertiesModal (Dashboard) (#13931)
* Tests for PropertiesModal (Dashboard)

* fix: fetchMock
2021-04-06 14:00:35 -07:00
Geido
c0888dc16d
Add tests for FilterBar CascadeFilterControl (#13950) 2021-04-06 11:15:17 -07:00
AAfghahi
7fb138381f
fix: Data table z index in sql Editor (#13972) 2021-04-06 12:42:48 -04:00
Grace Guo
4b29789b64
fix: null exception from adhoc metric popover (#13955) 2021-04-06 13:36:59 +08:00
Jesse Yang
b9e601487a
chore: bump @superset-ui/plugin-chart-table to 0.17.28 (#13953)
* chore: bump @superset-ui/plugin-chart-table to 0.17.28

* Bump chrono-node
2021-04-06 09:55:35 +08:00
AAfghahi
f19f2c3ac8
fix: Floating Menu in SQL Left Bar (#13858)
* floating table git issue

* made changes

* floating table git issue

* made changes

* long table names

* floating table git issue

* made changes

* floating table git issue

* made changes

* long table names

* floating table git issue

* made changes

* floating table git issue

* made changes

* long table names

* table values

* aligned

* active key

* changed to customStyle

* update dropdown styles

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-04-05 15:54:28 -07:00
Hugh A. Miles II
d006178c03
refactor: move CTAS/CVAS field II (#13877)
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
2021-04-05 16:57:40 -04:00
Bruno Motta
d489d0018c
test: SliceHeaderControls (#13895)
* tests for SliceHeaderControls

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* fix lint error

* Improving accessibility

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-05 13:34:06 -07:00
Geido
fa1e028974
Add dedicated dir and storybook (#13553) 2021-04-05 13:11:50 -07:00
Bruno Motta
592c566bb4
test: PropertiesModal (#13818)
* Tests for test-PropertiesModal

* finish fetchMock to solve conflicts

* clean fetchMock
2021-04-05 11:24:10 -07:00
Bruno Motta
203512e189
test: CrossFilterScopingForm (#13875)
* tests for CrossFilterScopingForm

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-05 11:16:04 -07:00
Bruno Motta
12982ef387
tests for FilterIndicator (#13873) 2021-04-05 11:14:30 -07:00
Bruno Motta
f2d65989ab
Tests for DetailsPanel (#13872) 2021-04-05 11:13:15 -07:00
Geido
9a4de232a7
test: Enhance tests and directory structure for FilterControl components (#13745)
* Enhance directory structure

* Enhance paths

* Move AdhocFilter

* Add AdhocFilterPopoverTrigger tests

* Move import

* Enhance AdhocFilterOption tests

* Linting

* Fix linting

* Update superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterOption/AdhocFilterOption.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterOption/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Enhance

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-05 11:05:35 -07:00
Michael S. Molina
61129f749f
test: Adds tests to the TimeSeriesColumnControl component (#13712) 2021-04-05 11:04:58 -07:00
Bruno Motta
7e394e556a
test: FilterBoxItemControl (#13753)
* Tests for FilterBoxItemControl

* factory for props

* fix lint
2021-04-05 11:00:20 -07:00
Bruno Motta
555d7bbb35
test: CollectionControl (#13656)
* Tests for CollectionControl

* add role to icon

* applying factory to props
2021-04-05 10:52:24 -07:00
Michael S. Molina
35f33e8276
test: Adds storybook to Dropdown and DropdownButton components (#13482) 2021-04-05 10:48:59 -07:00
simcha90
e06290663a
fix(colors): fix color schemes (#13945)
* fix: fix color schemes

* fix: tests case
2021-04-04 15:53:21 +03:00
Elizabeth Thompson
abd4051f7a
catch collapse onchange (#13927) 2021-04-03 00:00:34 -07:00
Bruno Motta
e829aa52eb
Tests for "CrossFilterScopingModal/utils" (#13876) 2021-04-02 17:06:42 -07:00
David Aaron Suddjian
e640b7f0e0
chore(dashboard): Datasource -> Dataset (#13939)
* chore(dashboard): Datasource -> Dataset

* lint

* more renaming datasource -> dataset
2021-04-02 16:47:16 -07:00
Michael S. Molina
a0a00e6470
test: Adds tests to the PublishedStatus component (#13892) 2021-04-02 14:26:06 -07:00
AAfghahi
4187d9e4c4
fix: adjusted tab height (#13822) 2021-04-02 12:44:45 -04:00
Amit Miran
f6f412b4ae
chore: bump to new superset-ui version (#13932) 2021-04-02 18:27:10 +03:00
Jesse Yang
65940770ac
feat(explore): adhoc column formatting for Table chart (#13758) 2021-04-01 23:28:42 -07:00
Michael S. Molina
a1442497d4
test: Fixes PropertiesModal_spec (#13548) 2021-04-01 11:42:14 -07:00
Michael S. Molina
42c7e2cae6
test: Adds tests to dnd controls (#13650) 2021-04-01 09:11:33 -07:00
Michael S. Molina
bb677b8ef1
test: Adds tests to the AnnotationLayer component (#13748) 2021-04-01 09:10:42 -07:00
Geido
9156f089ff
test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799)
* Refactor and enhance tests

* Fix linting issues
2021-03-31 23:14:51 -07:00
Geido
a5c4db3aee
Add tests (#13778) 2021-03-31 23:08:56 -07:00
Bruno Motta
1dbc1496b2
test: DisplayQueryButton (#13750)
* Tests for DisplayQueryButton component

* add factories to props and fetch-mock

* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 23:08:20 -07:00
Evan Rusackas
a7f48c6599
Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905) 2021-03-31 21:32:46 -07:00
Erik Ritter
5315d2cc2d
Revert "fix: select table overlay (#13694)" (#13901)
This reverts commit b247279ffe.
2021-03-31 18:47:38 -07:00
Michael S. Molina
6fd62e3f7e
test: Adds tests to the OptionControls component (#13729) 2021-03-31 18:07:22 -07:00
Bruno Motta
ec5d2f5f32
test: DatasourceControl (#13605)
* Tests for DatasourceControl

* fix: lint error

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove error comment

* replace component data-test

* factory to props

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 17:52:45 -07:00
Bruno Motta
9fd297f636
tests for function handleScroll (#13896) 2021-03-31 17:49:43 -07:00
Michael S. Molina
28fe6e0ef1
test: Adds tests to the CustomFrame component (#13675)
* test: Adds tests to the CustomFrame component

* Replaces full path with relative path
2021-03-31 15:53:07 -07:00
Michael S. Molina
7ae80e9d66
test: Adds tests to the AdvancedFrame component (#13664)
* test: Adds tests to AdvancedFrame component

* Replaces full path with relative path
2021-03-31 15:52:03 -07:00
Bruno Motta
1252fd700e
test: DataTableControl (#13668)
* Tests for DataTableControl

* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 15:45:30 -07:00
Michael S. Molina
8ddcba82e0
chore: Removes Select duplication (#13477) 2021-03-31 15:42:14 -07:00
Michael S. Molina
9d6832dc27
test: Adds tests and storybook to CertifiedIcon component (#13457) 2021-03-30 14:31:35 -07:00
Michael S. Molina
3c4591ef15
chore: Moves CheckboxIcons to Checkbox folder (#13459) 2021-03-30 13:55:10 -07:00
Michael S. Molina
6fe4cc0c51
chore: Removes Popover duplication (#13462) 2021-03-30 13:54:53 -07:00
Beto Dealmeida
ce2760edf7
fix: allow spaces in DB names (#13800) 2021-03-30 10:12:10 -07:00
Jack Fragassi
304e3b36eb
feat(alerts & reports): Easier to read execution logs (#13752)
* Prep for migration

* Migration for execution id column

* Generate execution ids for alerts and reports

* Change execution id range

* Add execution id to API endpoint

* Add execution id to execution log view

* Change execution id range

* Change execution id to a uuid

* Fix execution id type

* Switch state and exec. id columns

* Change db column to UUIDType

* Python lint

* Fix failing frontend tests

* execution_id -> uuid

* Fix migration head

* lint

* Use celery task id as the execution id

* lint

* lint for real

* Fix tests
2021-03-30 08:46:16 -07:00
Michael S. Molina
4ae9b819d3
fix: Disallows negative options remaining (#13749) 2021-03-30 08:34:12 -07:00
Ville Brofeldt
3394421fa8
fix(native-filters): add global async query support to native filters (#13837)
* fix(native-filters): improve loading styles for filter component

* round up fractional grid unit

* fix(native-filters): add support for global async queries

* move form item out of default value component

* move default value hook declaration to form

* delete LoadingBox
2021-03-30 07:50:52 +03:00
Michael S. Molina
ac43f4c491
Displays row limit warning with Alert component (#13854) 2021-03-29 17:04:33 -07:00
Jack Fragassi
33f7845010
fix(alerts and reports): Unify timestamp format on execution log view (#13718)
* Unify timestamp format on execution log view

* Fix lint
2021-03-29 13:30:19 -07:00
zuzana-vej
467848d8f7
fix(sqllab): warning message when rows limited (#13841) 2021-03-29 10:47:51 -07:00
Ville Brofeldt
9fa52b50ed
fix(native-filters): improve loading styles for filter component (#13794)
* fix(native-filters): improve loading styles for filter component

* round up fractional grid unit

* remove LoadingBox
2021-03-29 10:23:01 +03:00
cccs-jc
24f805ebc4
feat: added support to configure the default explorer viz (#13610)
* added support to configure the default explorer viz

* code review fix

* lint

Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-03-26 15:27:36 -07:00
David Aaron Suddjian
db1d598f50
fix(cypress): avoid referencing detached dom nodes (#13825) 2021-03-26 14:46:31 -07:00
David Aaron Suddjian
a45a5e1060
chore(cypress): Make the e2e tests more behavior-driven (#13784)
* chore(cypress): make the load dashboard test behavior driven

* remove bootstrap usage from controls test, + new utils

* fix save test to not use bootstrap dat

* remove bootstrap usage from the filter test

* fix race condition

* remove bootstrap from url params test

* fix lint

* remove unused const

* add chart specs for the tab test

* attempt removing bootstrap data from tabs tests

* fix cypress async/sync confusion

* remove redundant assertions

* attempt fixing tab test

* attempt fixing tabs test

* cleanup commented code

* better aliases so you can tell what they are in the logs

* remove unused imports

* get the line chart alias before clicking the tab

* simplify getChartGridComponent

* wait for all the charts before force refresh

* fix tabs test

* one more time with the tabs test

* another edit to tabs test

* fix flaky test

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
2021-03-26 09:20:13 -07:00
AAfghahi
b247279ffe
fix: select table overlay (#13694) 2021-03-26 10:39:39 -04:00
AAfghahi
64f967cb2d
refactor: New schedule query button (#13797) 2021-03-26 09:56:59 -04:00
Michael S. Molina
be8f8d9c1f
test: Adds storybook and tests to PopoverDropdown component (#13547)
* test: Adds storybook and tests to PopoverDropdown component

* Changes to use gridUnit and theme hook
2021-03-26 05:29:03 -07:00
Bruno Motta
416f188328
test: SelectAsyncControl (#13638)
* SelectAsyncControl tests

* fix: lint error

* applying factory to  props
2021-03-25 22:07:05 -07:00
Bruno Motta
2aedaaa03e
test: DatabaseSelector (#13581)
* Moving DatabaseSelector to a folder

* Tests for DatabaseSelector

* Using factory for props

* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* apply waitFor and remove act

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-25 22:01:13 -07:00
Geido
930cbea2e1
test: Tests, dedicated directory and Storybook for the ProgressBar component (#13534)
* Move to own dir and add storybook

* Add tests
2021-03-25 15:44:00 -07:00
Phillip Kelley-Dotson
3e4c3bddb9
feat(homescreen and cards): Toggle thumbnails off or on and feature flag (#13683) 2021-03-25 13:21:04 -04:00
AAfghahi
1d5c58d005
refactor: SouthPane into functional component (#13676) 2021-03-24 23:00:12 -04:00
Hugh A. Miles II
71ca5aca5b
refactor: Revert "refactor: ScheduleQueryButton into functional component (#134… (#13785)
This reverts commit 2c3d9e9b1e.
2021-03-24 22:50:59 -04:00
AAfghahi
2c3d9e9b1e
refactor: ScheduleQueryButton into functional component (#13443) 2021-03-24 17:46:24 -04:00
Cemre Mengu
ff0c9e93c3
feat: use cross-env when running dev-server (#13743)
* feat: use cross-env when running dev-server

* use cross-env for other inline env vars
2021-03-24 09:19:00 -07:00
Yaozong Liu
f18d14a51a
fix(explore): make horizontal scroll appears in data panel (#13566)
* fix(explore): make horizontal scroll appear

* fix(explore): 34px -> 33px

* fix(lint): dataTablesPane lint

* fix(lint): prettier dataTablesPane

* fix(explore): use gridUnit rather than hardcode

Co-authored-by: liuyaozong <liuyaozong@baijiahulian.com>
2021-03-24 17:47:57 +02:00
Bruno Motta
fd7c9eb71e
test: DatasourcePanelDragWrapper (#13627)
* Tests for DatasourcePanelDragWrapper

* Absolute import path
2021-03-23 09:54:06 -07:00
Rob DiCiuccio
452b53092b
feat: Refactor asyncEvent middleware and add websocket support (#13696) 2021-03-23 07:23:23 -07:00
Phillip Kelley-Dotson
bbc306c64f
chore(homepage): separate out api calls to make homepage load more dynamically (#13500)
* separate out api calls

* add new loading states

* remove consoles

* update tests

* fix types and lint

* make code more robust and add test

* address comments

* address comments

* fix lint
2021-03-22 15:10:42 -07:00
simcha90
aa92c1e7eb
refactor(native-filters): refactor filter bar (#13723)
* fix: fix removeing native filter

* fix: fix native-cross filters

* fix: fix native-cross filters

* fix: fix native-cross filters

* fix: fix function declaration

* refactor: before pull

* refactor: refactor filter bar

* chore: add lic

* lint: fix lint
2021-03-22 17:03:44 +02:00
Ville Brofeldt
1a67f1564c
fix(cross-filters): only apply filters if ff is set (#13704)
* fix(cross-filters): only apply filters if ff is set

* fix missing parent
2021-03-20 10:56:02 +02:00
Grace Guo
fa072cd74e
fix: dashboard filter scope bug (#13695)
* fix: dashboard filter scope bug

* fix comments

* fix function/variables name
2021-03-19 10:39:09 -07:00
Ville Brofeldt
87d1afcc65
fix(cross-filters): expand relevant indicator sections (#13703) 2021-03-19 11:52:03 +02:00
Bruno Motta
375ded92ef
test: usePrevious hook (#13554) 2021-03-18 18:30:50 -07:00
AAfghahi
ebd4a917f7
refactor: Share sql lab query (#13630) 2021-03-18 17:07:24 -04:00
AAfghahi
df9352f2b4
fix: data column in SQL lab left panel open by default (#13624)
* fix table expand

* Left Panel Expand

* added tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-03-18 13:28:24 -07:00
simcha90
7e6beb5ebf
fix(native-filters): fix removing native filter (#13688)
* fix: fix removeing native filter

* fix: fix native-cross filters

* fix: fix native-cross filters

* fix: fix native-cross filters

* fix: fix function declaration
2021-03-18 21:11:50 +02:00
Bruno Motta
e6c5bf4d54
test: useChangeEffect (#13555) 2021-03-18 11:50:50 -07:00
Elizabeth Thompson
b97bbed2a9
fix: allow option to generate new query (#13488) 2021-03-18 14:42:31 -04:00
Ville Brofeldt
ecfcaea803
fix(dashboard): missing parents in directPathToFilter (#13691) 2021-03-18 19:43:41 +02:00
Ville Brofeldt
81b64204c7
fix(cross-filters): add a control panel to range filter (#13692) 2021-03-18 19:43:25 +02:00
Jesse Yang
69a5ed9a1e
fix: use FeatureFlags in @superset-ui/core (#13679) 2021-03-18 09:13:50 -07:00
Jesse Yang
08d0deb720
fix: clean up incorrect usage of TypeScript type in PropTypes (#13681) 2021-03-18 09:12:13 -07:00
simcha90
577ecc284f
feat(cross-filter): Cross filter badge (#13687) 2021-03-18 17:59:13 +02:00
Ville Brofeldt
13f7e0d755
feat(native-filters): add temporal support to select filter (#13622) 2021-03-18 16:15:43 +02:00
Erik Ritter
64785c20bd
feat: add warning metadata to tables and metrics (#13606) 2021-03-17 21:27:34 -07:00
Beto Dealmeida
db57f90a34
feat: better error message when adding DBs (#13601)
* WIP

* Adding tests

* Add unit tests

* Show error message

* Fix lint

* Fix after rebase
2021-03-17 20:29:26 -07:00
Yongjie Zhao
7b74eb2730
chore(explore): added debounce in DateFilter (#13660) 2021-03-17 09:04:50 -06:00
simcha90
0e0c99b2fb
feat(cross-filters): Add scoping for cross filters (#13625)
* feat: cross filter modal

* refactor: add charts metadata

* refactor: add charts metadata

* feat: cross filters scoping

* fix: fix CR notes

* test: fix test

* lint: fix lint
2021-03-17 14:00:32 +02:00
Maxime Beauchemin
4bdb958ce6
fix: 'Run in SQL Lab' redirect bug (#13657) 2021-03-16 21:47:39 -07:00
Jesse Yang
bd1d6acb0c
fix(query): order by adhoc metrics should trigger group by (#13434)
* fix(query): properly select adhoc metrics in orderby

* Throw error when sql is empty

* Allow `metrics` to be None

* Always use alias in orderby for metrics

* Bump table chart version and migrate histogram to typescript

* Fix Histogram without groupby

* Fix Presto birth names test

* Raw records mode should not aggregate
2021-03-16 21:00:03 -07:00
Dmytro Mudrov
72d19b6b35
fix(sqllab): Table name and schema are encoded twice during fetching table metadata on SQL Lab page. (#13636)
Co-authored-by: dmitry.mudrov <dmitrym.mudrov@agileengine.com>
2021-03-16 19:18:08 -07:00
Lily Kuang
21cc49509f
chore: improve modal error handling (#13342)
* improve modal error handling

* update hook to handle string error message
2021-03-16 09:33:36 -07:00
Lily Kuang
10d88726db
update test (#13463) 2021-03-16 09:33:17 -07:00
Lily Kuang
f2c50f62ad
fix antd select dropdown issue (#13585) 2021-03-16 09:32:15 -07:00
Geido
df5fb5a97c
test: Tests and dedicated directory for the SupersetResourceSelect Component (#13508)
* Refactor

* Clean up

* Add license

* Use findBy
2021-03-15 16:09:02 -07:00
Jesse Yang
868e063b03
feat: add ErrorBoundary to chart controls (#13584) 2021-03-15 14:44:18 -07:00
Lily Kuang
cd2f53ed7b
switch message content between chart and dashboard AlertReportModal (#13537) 2021-03-15 12:00:53 -07:00
ʈᵃᵢ
4de6040d89
fix(dashboard|chart): use correct url for favorite_status and change request type to rison (#13557) 2021-03-15 10:53:16 -06:00
simcha90
a35825de7b
feat(filter-set): Filter set edge cases (#13576)
* refactor(native-filters): move data mask to root reducer

* refactor: update rest stuff for dataMask

* refactor: add ownCrrentState to explore

* fix: fix immer reducer

* fix: merge with master

* refactor: support explore dataMask

* refactor: support explore dataMask

* docs: add comment

* refactor: remove json stringify

* fix: fix failed cases

* feat: filter bat buttons start

* fix: fix CR notes

* fix: fix cascade filters

* fix: fix CR notes

* refactor: add clear all

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

* feat: buttons in filter bar

* lint: update imports

* feat: add tabs for filter sets

* feat: add buttons to filter set

* feat: first phase add filter sets

* fix: undo FF

* refactor: continue filter sets

* fix: fix CR notes

* refactor: header

* fix: fix CR notes

* fix: fix CR notes

* refactor: continue filter sets

* lint: fix lint

* refactor: continue filter sets

* fix: fix filter bar opening

* refactor: continue filter sets

* refactor: continue filter sets

* refactor: continue filter sets

* feat: filters sets history

* feat: filters sets history

* fix: filter set name

* refactor: fix expand filters case

* fix: fix CR notes

* refactor: filter sets

* refactor: filter sets

* refactor: filter sets

* refactor: filter sets

* refactor: update sets

* feat: edit filter set

* refactor: add warning icon

* fix: fix CR notes

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/EditSection.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* fix: fix CR notes

* feat: filter set edge cases

* lint: fix lint

* lint: fix TS

* refactor: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-03-15 14:29:22 +02:00
Kamil Gabryjelski
ae66f5fa78
feat(explore): Drag and drop UX improvements (#13598)
* Create a metric immediately when saved metric is dropped

* Display borders around control boxes when metric or column is dragged

* Fix imports

* Display ghost button

* Rename placeholder to ghostButton
2021-03-15 12:47:13 +02:00
Elizabeth Thompson
67ffea8248
fix: always pass a string as a value to ace editor (#13563)
* always pass a string as a value to ace editor

* fix some syntax
2021-03-12 17:09:02 -08:00
AAfghahi
a0e3754173
feat: create hooks to redux component (#13487)
* created TypedSelector

* made changes

* made discussed changes
2021-03-12 11:03:56 -08:00
Yongjie Zhao
817b740f59
chore: metric refactor iteration 1 (#13596) 2021-03-12 23:11:05 +08:00
Yongjie Zhao
1a46f93057
chore(explore): bump superset-ui 0.17.19 (#13593) 2021-03-12 15:16:59 +08:00
Kamil Gabryjelski
d439da2fe0
feat: Implement drag and drop for metrics (#13575)
* Convert MetricsControl to functional component

* Implement drag and drop for metrics

* Implement customizable placeholder for DndSelectLabel
2021-03-12 12:31:17 +08:00
Jesse Yang
7656b2e68b
refactor: convert controlUtils to TypeScript (2 of 2) (#13520) 2021-03-11 17:19:15 -08:00
Ville Brofeldt
901acd936f
feat(native-filters): add sort option to select filter (#13569)
* feat(native-filters): add sort option to select filter

* remove from useEffect

* disable flaky cypress tests
2021-03-11 16:49:01 -08:00
Bruno Motta
fd4e5c85b2
test: CronPicker (#13549) 2021-03-11 16:12:08 -06:00
Bruno Motta
b5ea5d085c
test: TableCollection (#13583) 2021-03-11 16:08:16 -06:00
Geido
d1f6245bcd
test: Tests, dedicated directory and Storybook for the Badge component (#13513)
* Move to dir and add storybook

* Add tests

* Remove no-restricted-imports
2021-03-10 12:29:59 -08:00
Jesse Yang
b9884fb55b
fix: IS NULL filter operator for numeric columns (#13496) 2021-03-10 10:15:25 -08:00
simcha90
70ccc26421
fix: fix initial filter loading (#13546) 2021-03-10 15:43:39 +02:00
simcha90
d509b157fd
feat(filter-set): Update existing filter set (#13545)
* refactor(native-filters): move data mask to root reducer

* refactor: update rest stuff for dataMask

* refactor: add ownCrrentState to explore

* fix: fix immer reducer

* fix: merge with master

* refactor: support explore dataMask

* refactor: support explore dataMask

* docs: add comment

* refactor: remove json stringify

* fix: fix failed cases

* feat: filter bat buttons start

* fix: fix CR notes

* fix: fix cascade filters

* fix: fix CR notes

* refactor: add clear all

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

* feat: buttons in filter bar

* lint: update imports

* feat: add tabs for filter sets

* feat: add buttons to filter set

* feat: first phase add filter sets

* fix: undo FF

* refactor: continue filter sets

* fix: fix CR notes

* refactor: header

* fix: fix CR notes

* fix: fix CR notes

* refactor: continue filter sets

* lint: fix lint

* refactor: continue filter sets

* fix: fix filter bar opening

* refactor: continue filter sets

* refactor: continue filter sets

* refactor: continue filter sets

* feat: filters sets history

* feat: filters sets history

* fix: filter set name

* refactor: fix expand filters case

* fix: fix CR notes

* refactor: filter sets

* refactor: filter sets

* refactor: filter sets

* refactor: filter sets

* refactor: update sets

* feat: edit filter set

* refactor: add warning icon

* fix: fix CR notes

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/EditSection.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* fix: fix CR notes

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-03-10 15:43:24 +02:00
simcha90
1d1a1cdc20
feat(filter-set): Filter set history (#13529)
* refactor(native-filters): move data mask to root reducer

* refactor: update rest stuff for dataMask

* refactor: add ownCrrentState to explore

* fix: fix immer reducer

* fix: merge with master

* refactor: support explore dataMask

* refactor: support explore dataMask

* docs: add comment

* refactor: remove json stringify

* fix: fix failed cases

* feat: filter bat buttons start

* fix: fix CR notes

* fix: fix cascade filters

* fix: fix CR notes

* refactor: add clear all

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

* feat: buttons in filter bar

* lint: update imports

* feat: add tabs for filter sets

* feat: add buttons to filter set

* feat: first phase add filter sets

* fix: undo FF

* refactor: continue filter sets

* fix: fix CR notes

* refactor: header

* fix: fix CR notes

* fix: fix CR notes

* refactor: continue filter sets

* lint: fix lint

* refactor: continue filter sets

* fix: fix filter bar opening

* refactor: continue filter sets

* refactor: continue filter sets

* refactor: continue filter sets

* feat: filters sets history

* feat: filters sets history

* fix: filter set name

* refactor: fix expand filters case

* fix: fix CR notes

* refactor: filter sets

* fix: fix CR notes

* refactor: filter sets
2021-03-10 11:10:47 +02:00
Michael S. Molina
fc36de2d1f
test: Adds tests and storybook to PopoverSection component (#13438)
* test: Adds storybook to PopoverSection component

* test: Adds tests and storybook to PopoverSection component
2021-03-09 12:08:10 -08:00
Michael S. Molina
f0a9dccc70
test: Adds storybook and tests to AsyncEsmComponent (#13517) 2021-03-09 12:01:57 -08:00
Michael S. Molina
6d2d3addc2
test: Adds storybook to AlteredSliceTag component (#13516) 2021-03-09 12:01:31 -08:00
Ville Brofeldt
375797f649
feat(native-filters): add timegrain and column filter (#13484)
* feat(native-filters): add timegrain and column filter

* add fetch values predicate

* bump deps

* lint

* fix test

* add python test for legacy merge

* fix default value and isInitialized to not check strict equality

* Address comments

* add FilterValue type

* address review comments
2021-03-09 17:27:46 +02:00
simcha90
9b8e2555bf
feat(filter-set): adding new filters (#13515)
* refactor(native-filters): move data mask to root reducer

* refactor: update rest stuff for dataMask

* refactor: add ownCrrentState to explore

* fix: fix immer reducer

* fix: merge with master

* refactor: support explore dataMask

* refactor: support explore dataMask

* docs: add comment

* refactor: remove json stringify

* fix: fix failed cases

* feat: filter bat buttons start

* fix: fix CR notes

* fix: fix cascade filters

* fix: fix CR notes

* refactor: add clear all

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

* feat: buttons in filter bar

* lint: update imports

* feat: add tabs for filter sets

* feat: add buttons to filter set

* feat: first phase add filter sets

* fix: undo FF

* fix: fix CR notes

* fix: fix CR notes

* lint: fix lint

* fix: fix filter bar opening

* refactor: continue filter sets
2021-03-09 12:01:37 +02:00
Michael S. Molina
6e4825165a
test: Adds storybook to ConfirmStatusChange component (#13412) 2021-03-08 22:19:56 -08:00
simcha90
f504b7fdd6
feat(native-filters): Filter set tabs (#13507) 2021-03-07 16:03:48 +02:00
Kamil Gabryjelski
7b370e6f17
feat: Implement drag and drop columns for filters (#13340)
* Implement DnD feature for filters

* minor refactor

* Fix types

* Fix undefined error

* Refactor

* Fix ts errors

* Fix conflicting dnd types

* Bump superset-ui packages

* Change DndItemType case to PascalCase

* Remove redundant null check

* Fix

* Fix csrf mock api call
2021-03-07 11:54:08 +02:00
simcha90
3970d7316b
feat(native-filters): Update filter bar buttons (#13506)
* refactor(native-filters): move data mask to root reducer

* refactor: update rest stuff for dataMask

* refactor: add ownCrrentState to explore

* fix: fix immer reducer

* fix: merge with master

* refactor: support explore dataMask

* refactor: support explore dataMask

* docs: add comment

* refactor: remove json stringify

* fix: fix failed cases

* feat: filter bat buttons start

* fix: fix CR notes

* fix: fix cascade filters

* fix: fix CR notes

* refactor: add clear all

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

* feat: buttons in filter bar

* lint: update imports

* test: fix tests
2021-03-07 11:27:22 +02:00
simcha90
45972e9945
refactor(native-filters): Move filtersState to dataMask redux root (#13437) 2021-03-07 09:34:12 +02:00
Michael S. Molina
d0714a0972
chore: Moves ChartIcon to own folder (#13454) 2021-03-05 21:23:03 -08:00
Michael S. Molina
0b213bf484
test: Adds tests and storybook to RefreshLabel (#13409) 2021-03-05 21:21:01 -08:00
Michael S. Molina
975dc2fe98
chore: Moves ListView test to component folder (#13324) 2021-03-05 20:52:12 -08:00
Michael S. Molina
095c15a1f1
chore: Moves InfoTooltip component to own folder (#13485) 2021-03-05 20:51:22 -08:00
Michael S. Molina
4284800cf1
test: Adds storybook to Switch component (#13479) 2021-03-05 20:50:01 -08:00
Michael S. Molina
c1e9287cf1
test: Adds storybook to SearchInput component (#13410)
* test: Adds storybook to SearchInput component

* Fixes placeholder text

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-03-05 20:48:13 -08:00
Michael S. Molina
b6b7982a81
chore: Moves BootstrapSliderWrapper to own folder (#13460) 2021-03-05 20:46:46 -08:00
Beto Dealmeida
8d48d2e37b
fix(sqllab): per-tab hide left bar (#13288)
* fix (sqllab): per-tab hide left bar

* Load state when switching tabs
2021-03-05 11:16:11 -08:00
Erik Ritter
d2e03ab9b4
fix: Remove view in sql lab from druid datasources (#13469) 2021-03-04 14:54:29 -08:00
Sam Faber-Manning
0318b6d4ae
feat: Add error pages (#13144)
* add custom error pages for 404 and 500 responses

* refactor error page styles into separate template

* move error pages to superset-frontend

* fix whitespace on error pages

* refactor error pages to be generated by jinja

* generate static error pages with webpack
2021-03-04 09:58:16 -08:00
Ayan Ginet
483405fff9
chore: Migrating dashboard/components/menu from jsx to tsx (#13361)
* fix: constant icon size

* clean up

* dashboard/components/menu jsx -> tsx

* more types

* package-lock.json sync

* package-lock fix

* fix

* lint fix

* added comment about event type
2021-03-04 08:40:42 -08:00
simcha90
7f0fbb5b45
refactor: add set data mask to build query (#13417)
* refactor: add set data mask to build query

* refactor: update hooks placement
2021-03-04 10:08:37 +02:00
Yongjie Zhao
ca27b00f3a
chore: disable drag metrics and columns in datasourcePanel (#13450) 2021-03-04 12:21:57 +08:00
Michael S. Molina
cfc83c271c
chore: Moves TableSelector tests to component's folder (#13411) 2021-03-03 15:44:36 -08:00
Jesse Yang
dc1eb305b1
refactor: convert controlUtils to TypeScript (1 of 2) (#13401) 2021-03-03 14:51:36 -08:00
Moriah Kreeger
26e36ae484
fix: annotation layer modal err handling (#12341)
* annotation layer modal err handling

* address comments
2021-03-03 11:28:05 -08:00
AAfghahi
66a7318fa2
refactor: Query search into functional component (#13102) 2021-03-03 10:18:14 -05:00
AAfghahi
9c9862ff5b
feat: Added Rows Returned (#13190) 2021-03-03 10:17:33 -05:00
Mayur
8b38d63b7d
changes added (#13431) 2021-03-03 13:52:54 +02:00
simcha90
dc170397c5
feat(dashboard_rbac): manage roles for dashboard (#13145)
* feat(dashboard_rbac): manage roles for dashboard

* test: fix tests

* fix: fix empty roles

Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
2021-03-03 12:31:41 +02:00
Michael S. Molina
65cec1872d
chore: Removes unused Hotkeys component (#13408) 2021-03-02 16:46:51 -08:00
Michael S. Molina
327e9b05c0
test: Adds storybook to FormRow component (#13407) 2021-03-02 16:41:53 -08:00
Michael S. Molina
51f05ea257
test: Adds storybook to AnchorLink component (#13406) 2021-03-02 16:39:04 -08:00
Michael S. Molina
c3e19b2cf1
test: Adds storybook to IconTooltip component (#13415) 2021-03-02 16:36:40 -08:00
Michael S. Molina
45aa812cb0
test: Adds storybook to EditableTitle component (#13362) 2021-03-02 16:35:52 -08:00
Michael S. Molina
e9d5d3b137
Adds tests and storybook to CopyToClipboard component (#13359) 2021-03-02 16:34:55 -08:00
Geido
7d270bced6
test: ErrorMessage components tests (#13358)
* Add tests for ErrorAlert

* Add BasicErrorAlert tests

* Add DatabaseErrorMessage tests

* Add useRedux property

* Finalize DatabaseErrorMessage tests

* Add ErrorMessageWithStackTrace tests

* Move getErrorMessageComponentRegistry test to dedicated directory

* Clean up getErrorMessageComponentRegistry

* Add IssueCode tests

* Add tests for ParameterErrorMessage

* Add tests for TimeoutErrorMessage

* Fix linting issue
2021-03-02 16:34:10 -08:00
Jesse Yang
f2616294e6
chore: convert chartReducer to TypeScript (#13374) 2021-03-02 15:58:30 -08:00
simcha90
f19a830d9b
refactor(self-trigger): Split native filters state (#13137)
* feat: add cross filters

* refactor: fix CR notes

* lint: fix lint

* lint: fix lint

* feat: POC adding filters set feature

* chore: pre-commit

* refactor: under chage

* lint: fix TS

* fix: fix FF name

* refactor: move to behaviors

* lint: fix lint

* refactor: update state of native filters

* refactor: finish refactor nativeFilter state

* feat: split native filters state

* refactor: refactor Time filter to use new API

* refactor: refactor Time filter to use new API

* refactor: fix CR notes

* fix: fix update values in filter bar

* refactor: save filter sets in meta

* feat(filter-sets): save filters sets in metadata

* refactor: partially fix ts

* refactor: merge conflicts

* refactor: add behaviors property

* refactor: add behaviors property

* fix: undo py changes

* fix: under some changes

* refactor: synx with master

* fix: undo FF

* fix: undo FF

* lint: ts-ignore

* chore: update lock file

* refactor: update enum

* refactor: naming of enum

* test: fix test

* test: update mocks

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-03-02 09:03:26 +02:00
Yongjie Zhao
488da65986
feat(viz): implement time picker on filter box (#13377)
* refactor(explore): restructure DateFilterControl

* fix UT

* remove datasource props

* remove unused files

* fix DateFilterControl in filterbox over length
2021-03-02 07:50:58 +08:00
Elizabeth Thompson
391d909d1e
npm audit security updates (#13367) 2021-03-01 23:51:23 +02:00
Michael S. Molina
fd5ce35728
test: Adds storybook to Timer component (#13343) 2021-03-01 12:55:10 -08:00
Michael S. Molina
19c8a62254
chore: Moves OnPasteSelect tests to component's folder (#13338) 2021-03-01 12:54:18 -08:00
Michael S. Molina
f91b4388ba
chore: Moves FilterableTable test to component folder (#13322) 2021-03-01 12:53:17 -08:00
Geido
5811e3f1ee
test: ErrorBoundary dedicated directory and tests (#13276)
* Add tests for ErrorBoundary

* Remove original ErrorBoundary file

* Prefer absolute path
2021-03-01 12:05:24 -08:00
Michael S. Molina
a36c8336ec
chore: Migrates RefreshChartOverlay into Chart (#13274)
* Migrates RefreshChartOverlay into Chart

* Removes unused Chart width prop
2021-03-01 12:04:16 -08:00
Michael S. Molina
6028a691b7
Improves ButtonGroup tests (#13273) 2021-03-01 11:57:33 -08:00
Geido
36fda5e840
test: FormLabel dedicated directory and tests (#13270)
* Form label directory and tests

* Fix linting

* Remove unnecessary data-test-id
2021-03-01 10:28:32 -08:00
Jesse Yang
3c62069bbb
refactor(explore): convert ControlPanelsContainer to typescript (#13221) 2021-02-28 10:10:15 -08:00
Bruno Motta
f706e6e7a2
test: Tests for OmniContainer (#13305) 2021-02-26 11:21:51 -08:00
Rob DiCiuccio
b4ca39ceeb
fix(celery): Reset DB connection pools for forked worker processes (#13350)
* Reset sqlalchemy connection pool on celery process fork

* Fix race condition with async chart loading state

* pylint: ignore

* prettier
2021-02-26 08:05:40 -08:00
Yongjie Zhao
1e3130d588
feat(explore): ColumnSelectControl with drag-and-drop (#13210)
* initial dnd

* shift group by items

* lint

* fix shift options

* wip

* wip

* fix shift action

* support scalar dimentions

* control rename to DndColumnSelectControl

* remove unused files

* added feature flag

* ff to False by default

* fix ut

* lint

* improve code smell

* added indicator

* replace value when column is scalcar

* scalar to isArray

* var rename

* minor fix

* update dependence

* minor fix
2021-02-26 16:48:23 +08:00
Bruno Motta
f9fc85453e
test: Pagination component (#13277)
* Moving Pagination.tsx to the Pagination folder and splitting components into diferent files

* Tests for Pagination components

* replace fireEvent for user-event

* Fix: Pagination references

* Rename PaginationButtonProps file

* Exchanging render imports

* pagination with attribute components

* switch "PaginationButtonProps.ts" to "types.ts"

* remove "Pagination.PaginationWrapper" from ListViewPagination.tsx

* fix: removing PaginationWrapper from tests

* removing data-test-id

* update PaginationProps
2021-02-25 22:36:54 -08:00
Michael S. Molina
cd3f5214fa
test: Adds tests to TableLoader component (#13299) 2021-02-25 17:23:47 -08:00
Michael S. Molina
7055c05218
Moves AsyncSelect component and tests to own folder (#13314) 2021-02-25 16:00:35 -08:00
Geido
f3f37b0229
test: Menu component tests (#13302)
* Add tests for the Menu component

* Clean up and add  NewMenu - SubMenu tests

* Remove obsolete SubMenu test

* Add LanguagePicker tests
2021-02-25 15:51:26 -08:00
Bruno Motta
45cca3a945
test: CacheLabel (#13318)
* add HTMLAttributes on Label Component

* Split TooltipContent

* moving "CacheLabel.jsx" to "CacheLabel" folder

* remove "data-test-id"

* Fix timestamp name

* removing unused file
2021-02-25 15:48:34 -08:00
Bruno Motta
abfd3734cf
test: tests for component FaveStar (#13320)
* test for FaveStar

* removing comment
2021-02-25 15:47:28 -08:00
Evan Rusackas
33bec57619
chore: migrating some LESS (#13296) 2021-02-25 15:44:58 -08:00
David Aaron Suddjian
e11d0cbf44
refactor: Introduce api resource hooks, fetch owners for chart errors (#13218)
* refactor: introduce api resource hooks, fix error owners

* comment

* vestigial comment

* not a function

* clarification

* vestigial comment

* filter the api for a leaner response

* reorganize code, add resource hook catalog

* better names

* implement state management in redux

* Revert "implement state management in redux"

This reverts commit d64d50a99f.

* add tests for hooks
2021-02-25 14:41:35 -08:00
Michael S. Molina
72721845e1
test: Adds tests to URLShortLinkButton component (#13319) 2021-02-25 10:59:36 -08:00
Bruno Motta
8395b3d6c8
test: Tests for DeleteModal component (#13286)
* tests for DeleteModal component

* fix: test attribute

* removing config from DeleteModal.test.tsx

* re-run tests

* Update superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* Update superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* Update superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* Update superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-02-25 10:56:07 -08:00
AAfghahi
776685736c
sql Lab buttons (#13174) 2021-02-25 09:51:48 -08:00
Geido
8ab45c90cc
refactor: New Icon system with Enhanced Antd Custom Icon (#12229)
* Enhance custom icon

* Minor fix

* Move DashboardList icon trash icon to enhanced

* Enhance trash icon on lists

* Enhance actions icons card view

* Add storybook entry for custom icons

* Test delete button

* Remove commented line

* Fix linting issue

* Enhance Antd icons

* Enhance existing icons up to BoltSmallRunIcon

* Remove unused import

* Import/Exports all icons from index

* Export all existing icons

* Implement more enhanced icons

* Add data-id on edit buttons

* Fix lint issue

* Inherit color

* Apply original color to actions

* Fix linting issue

* Fix typo

* Change ModeHoriz to MoreHoriz
2021-02-24 19:36:40 -08:00
Mayur
6954114f84
feat: add Echarts Graph chart (#13111)
* update preset file

* migration added

* bug fix

* lint

* Update superset/migrations/versions/1412ec1e5a7b_legacy_force_directed_to_echart.py

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* version bump

* bummp dependency

* add package.lock

* merge migrations

* add integration test

* lint

* remove unnecessary params from test

* check key existance in migrations

* test to typescript

* Update graph.test.ts

* fix migration downstream head

* Upgrade to lockfileversion 2

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-02-23 16:47:20 -08:00
Bruno Motta
8ef52babfe
fix(test): change data-test-id to data-test in FlashProvider (#13304) 2021-02-23 13:20:09 -08:00
Đặng Minh Dũng
e8114be99a
docs: Connecting to Trino Databases (#13171)
* feat: add trino logo

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* chores: update image links in README.md

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* docs: add Trino Connecting to Databases doc

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
2021-02-23 14:32:21 -05:00
Michael S. Molina
9a05d6afe5
Migrates Collapse component from Bootstrap to AntD (#12920) 2021-02-23 10:24:08 -08:00
Jesse Yang
e4a0233181
test: use data-test for testIdAttribute (#13292) 2021-02-23 11:43:35 -06:00
ʈᵃᵢ
75677f42bc
fix(listview): preserve bulk selections when view mode is changed (#13284) 2021-02-23 11:17:31 -06:00
Bruno Motta
6297ad7c8b
test: Switching FlashProvider to function component & creating tests (#13220) 2021-02-23 10:46:12 -06:00
Evan Rusackas
8db5d43969
fix: style tweaks for inconsistent button spacing (#13254)
* fix: button margin glitches

* removing unncessary fragment

* removing grid gap

* Revert "removing unncessary fragment"

This reverts commit 659e27348f.
2021-02-22 22:49:59 -08:00
Jesse Yang
af3a46048d
fix(home): missing key and invalid dates in Recents cards (#13291) 2021-02-22 20:30:52 -08:00
Moriah Kreeger
fc180ab2a6
fix: add alert report timeout limits (#12926)
* prevent working timeout and grace period from being set to negative numbers

* add extra validation

* lint

* fix black

* fix isort

* add js tests

* fix lint + more python schema validation

* add report schema test for timeout limits

* add extra test for null grace period
2021-02-22 11:12:10 -08:00
Michael S. Molina
741219e84d
test: add Tests and Storybook for AsyncAceEditor (#13241) 2021-02-22 11:06:23 -08:00
Lily Kuang
1e2ea36e70
disable redirect when bulk select enabled (#13245) 2021-02-22 09:27:18 -08:00
simcha90
9b5e66b728
refactor(native-filters): Refactor filters config modal module (#13268)
* refactor(native-filters): Refactor filters config modal module

* fix: fix import

* lint: fix import
2021-02-22 09:23:38 +02:00
Ville Brofeldt
87d6ad28ad
chore(viz): bump superset-ui 0.17.10 (#13258) 2021-02-22 08:24:31 +02:00
Michael S. Molina
42ab57850d
Migrate Bootstrap Alert to AntD (#12101) (#12122) 2021-02-21 20:50:18 -08:00
Michael S. Molina
7ee8d114d2
fix: SqlEditor_spec tests (#13186) 2021-02-21 20:49:51 -08:00
Lily Kuang
d8bd8ec896
fix(alert/report): alert modal loading dropdown options (#13222)
* alert modal loading

* add ui test
2021-02-22 01:59:33 +00:00
pavlozt
4bc2daf4c1
fix: TimeTable average with nulls calculations (#13122) 2021-02-20 19:46:00 +02:00
Kamil Gabryjelski
c1aacde304
fix(explore): Fix downloading as image charts which use Mapbox (#13181)
* Fix downloading as image charts which use Mapbox

* Remove unused prop

* Bump deckgl version
2021-02-20 19:45:03 +02:00
Kamil Gabryjelski
19a60435b0
chore: bump node.js to v14 (#13215)
* Bump node version to v15.8.0

* Update node version in Dockerfile and docker-compose.yml

* Set node version to LTS - v14.15.5

* Bump node version in .nvmrc
2021-02-20 19:42:51 +02:00
Thinking Chen
eea5fe3b60
fix: add the untranslated text content of Chart page, Sql Editor page and some dashboard label in messages.pot (#13123) 2021-02-19 17:54:22 -08:00
Jesse Yang
571b53e9cf
refactor: add frontend debounce constants (#13250) 2021-02-19 17:47:44 -08:00
Kamil Gabryjelski
42ff4fc19a
fix(explore): Reset values in TextControl only when datasource changes (#13211)
* Reset values in TextControl only when datasource changes

* Fix undefined error
2021-02-19 15:28:49 +02:00
Hugh A. Miles II
85d1e80544
fix: Update display string when sqlalchemy doc config us changed (#13219) 2021-02-18 17:04:13 -05:00
Geido
63e4e8a62b
test: Tests and Storybook entry for the ModalTriggerComponent (#13213)
* Kickstart tests

* Finalize tests

* Add storybook entry

* Remove unnecessary args types
2021-02-18 10:53:50 -08:00
Amit Miran
bcaa484aa9
fix: uncapitalize filter name (#13217) 2021-02-18 20:43:52 +02:00
Geido
66653ef306
test: Tests and Storybook entry for the Popover component (#13176)
* Initial Popover tests

* Add more cases

* Add Popover storybook entry

* Improve storybook entry

* Clean up
2021-02-18 10:18:24 -08:00
Geido
409fc83ca9
chore: Tab title to be empty when creating a new tab (#12773)
* Remove unwanted package lock

* Edit on new and autofocus

* Update test

* Remove autofocus
2021-02-18 10:14:59 -08:00
Michael S. Molina
9335b9c983
Migrates DropdownButton component from Bootstrap to AntD (#13002) 2021-02-18 10:14:21 -08:00
AAfghahi
9489f0b8f4
refactor: HighligthedSQL into functional component with Typescript (#13098) 2021-02-18 13:01:34 -05:00
Beto Dealmeida
3d23adec5e
chore: use shillelagh instead of gsheetsdb (#13185)
* chore: use shillelagh instead of gsheetsdb

* Fix tests

* Clean up code and remove duplication

* Fix test

* Tighten dep
2021-02-18 09:48:18 -08:00
Hugh A. Miles II
3c58fc5ef5
feat: Move SQLAlchemy url reference to config (#13182) 2021-02-18 12:42:15 -05:00
simcha90
2ff8741248
feat(filter-sets): Saving filter sets in metadata (#13205)
* feat: POC adding filters set feature

* lint: fix TS

* fix: fix FF name

* refactor: fix CR notes

* fix: fix update values in filter bar

* refactor: save filter sets in meta

* feat(filter-sets): save filters sets in metadata
2021-02-18 15:43:10 +02:00
Bruno Motta
f85497e69b
test: Adding test and storybook to "Loading" component. (#13179)
* moving Loading.tsx to the Loading folder

* Creating storybook for Loading component

* Creating unit test for Loading component

* fix eof on package.json

* Improving accessibility and interface

* just to run CI again
2021-02-18 00:43:09 -08:00
Michael S. Molina
fcd443d366
Creates storybook and tests for Tooltip component (#13184) 2021-02-17 22:51:35 -08:00
Hugh A. Miles II
d48b894573
fix: Grab datasets initially onMount (#13160) 2021-02-17 21:12:06 -05:00
Michael S. Molina
ad4ca2223e
feat: one-click copy chart and dashboard URL (#13037)
Closes #10328
2021-02-17 14:14:08 -08:00
michellethomas
91db008d72
fix: accept null groupby in form data for timeseries table viz (#13086)
* Allowing timeseries table groupby to be null in form data

* Check truthiness for is_group_by

Co-authored-by: michelle_thomas <michelle.thomas@airbnb.com>
2021-02-17 13:45:39 -08:00
simcha90
5cbe2ac760
feat(filters-set): basic implementation for managing user filter sets (#13031)
* feat: POC adding filters set feature

* lint: fix TS

* fix: fix FF name

* refactor: fix CR notes

* fix: fix update values in filter bar
2021-02-17 21:06:12 +02:00
simcha90
450215549f
fix: cross filter functionality (#13178) 2021-02-17 20:59:37 +02:00
David Aaron Suddjian
e01015f792
fix: handle lack of dynamic plugins (#13141)
* handle lack of plugins

* clearer logic
2021-02-17 20:08:43 +02:00
Lily Kuang
e1bb7f4364
fix(alert/report): bulk select mode should be deactivated (#12977)
* close bulk delete when switch between alert and report

* update test for alert/report list
2021-02-17 09:45:00 -08:00
simcha90
ad2aed5a68
fix(native-filters): Apply range filter (#13164)
* refactor: update range build query

* fix: apply range filter filtering

* fix: range resize action

* refactor: fix CR notes
2021-02-17 16:08:33 +02:00
simcha90
9c9becc3d5
fix: correct apply of native filter scopes (#13165) 2021-02-17 11:24:14 +02:00
David Aaron Suddjian
189aced320
refactor: remove deprecated chart.edit_url field from frontend usage (#13142) 2021-02-16 19:54:43 -08:00
Kamil Gabryjelski
da478531b2
Fix chart panel overflowing (#13154) 2021-02-17 09:37:35 +08:00
ʈᵃᵢ
c787f46f10
perf: add lazy loading along react-router routes and router links in menu (#13087) 2021-02-16 14:48:35 -08:00
ʈᵃᵢ
8b40bf695f
style: table sort icon alignment (#13139) 2021-02-16 11:23:40 -08:00
Lily Kuang
f10dbbe0ac
fix(alert/report): add/edit modal issue (#12955)
* fix alert modal

* add test for edit modal
2021-02-16 11:18:39 -08:00
Kamil Gabryjelski
44723eabbe
fix(explore): Certificate icon not displaying for certified metrics (#13133)
* Fix certificate icon not displaying for certified metrics

* Remove redundant function

* Fix grammar mistake
2021-02-16 08:56:19 -08:00
Michael S. Molina
981deaaa22
Change test environment to jsdom (#13149) 2021-02-16 08:48:16 -08:00
simcha90
5aa38ef929
feat(native-filters): enable filter indicator and make datasource optional (#13148)
* refactor: continue decouple native filters

* refactor(native-filters): decouple native filter parms from config modal

* lint: fix TS errors

* lint: fix TS errors

* refactor: update filter badge

* refactor: rename ant filters

* test: fix tests

* test: fix tests

* refactor: remove 18 from dataset
2021-02-16 16:12:35 +02:00
Jesse Yang
c9f76d58f0
chore: upgrade to npm 7 and superset-ui 0.17.9 (#13100) 2021-02-15 09:45:29 -10:00
Jesse Yang
613945a200
fix(FilterBox): treat empty defaultValues as null (#13109)
* fix(FilterBox): treat empty defaultValues as null

* Add a unit test and move constant around
2021-02-15 08:35:47 -08:00
Kamil Gabryjelski
d0b00bc08f
fix: Fix switching viz type to and from Filter box (#13094)
* Fix switching viz_type to and from filter_box

* Remove RESET_FIELDS action

* Restore removed log

* Refactor reducer logic
2021-02-15 08:05:40 -08:00
Victor Malai
24ebf10976
feat: add sort_by_metric for charts with single metric (#13058) 2021-02-15 02:59:50 -08:00
Amit Miran
d55a040acd
feat(native-filters): hide filterBar and toggle icon when in editMode (#13108) 2021-02-14 22:37:48 +02:00
simcha90
2010e64c94
refactor(native-filters): decouple params from filter config modal (first phase) (#13021)
* refactor: decouple params from filter config modal (first phase)

* refactor: remove unnecessary fields

* refactor: fix CR notes

* fix: fix controlValues

* refactor: fix Cr notes

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-02-14 10:38:15 +02:00
Ville Brofeldt
bc4c837da3
fix(native-filters): set currentValue null when empty (#13000) 2021-02-13 21:01:12 +02:00
simcha90
dae1258903
feat(native-filters): add storybook entry for select filter (#13005)
* refactor: update native filters ignores

* refactor: use behaviour variable

* refactor: move story for Filter select

* chore: update dependencies

* lint: fix lint

* remove unnecessary changes

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-02-13 13:11:18 +02:00
simcha90
d6fc720f4c
feat(native-filters): Time native filter (#12992)
* Add Time Filter component

* Improve Time Filter component

* Fix import errors

* Display Time Filter

* Remove console logs

* Change Control Panel

* Remove unnecessary files

* Use time range override

* test: fix tests

* feat: re run pipeline

* fix: fix some case for Time filter

* fix: merge with master

* use original time range

* fix height

* add cross filter behavior

* apply filters on initialization

* add applied filter to overrides

* add unit tests for merge_extra_form_data

Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-02-13 12:09:54 +02:00
simcha90
956f276e70
feat(cross-filters): add cross filters (#12662)
* feat: add cross filters

* refactor: fix CR notes

* lint: fix lint

* lint: fix lint

* chore: pre-commit

* refactor: under chage

* refactor: move to behaviors

* lint: fix lint

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-02-12 09:58:19 +02:00
Kamil Gabryjelski
85d02620b7
fix(explore): Enable selecting an option not included in suggestions (#13029) 2021-02-11 23:15:46 -08:00
Michael S. Molina
86807e40b7
Improves RTL configuration (#13079)
- Adds plugin:jest-dom/recommended to ESLint plugins list to enforce tests best practices

- Moves import @testing-library/jest-dom/extend-expect; from setup.ts to testing-library.tsx to avoid matchers collision

- Adds @testing-library/user-event to help simulate users events
2021-02-11 15:32:22 -08:00
Jesse Yang
6bc28a087c
chore: lock down npm to v6 (#13069) 2021-02-11 10:49:34 -08:00
Moriah Kreeger
7f7e113de2
add required * indicator to message content/notif method (#12931) 2021-02-11 10:17:53 -08:00
simcha90
c5781cde60
feat(style): hide dashboard header by url parameter (#12918)
* feat(native-filters): hide dashboard header bu url parameter

* lint: fix lint

* test: add tests

* test: fix test

* refactor: upgrade standalone param

* fix: pre-commit and extract to method is_standalone_mode

* test: fix tests

* test: fix tests

* fix: fix standalone statement

* refactor: fix CR notes

* chore: pre-commit

* fix: fix sticky tabs + update CR notes

* lint: fix lint

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* lint: fix lint

* refactor: fix cr notes

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-02-11 15:05:35 +02:00
Ville Brofeldt
42c4facb7e
fix(explore): pie chart label bugs (#13052) 2021-02-11 11:23:40 +02:00
AAfghahi
6c9f315b77
fix: Disabled state button transition time (#13008)
* button fix

* tooltips disabled when it is disabled, border width changed

* added isDisabled to tooltip

* worked on transition times

* cleaned up transition to be local instead of global

* made it local

* linted

* trying to resolve a conflict
2021-02-10 20:36:33 -08:00
Beto Dealmeida
249b51bfba
fix: vertical scroll in query history (#13042) 2021-02-10 07:31:46 -08:00
Daniel Vaz Gaspar
3e0681b438
fix: UI toast typo (#13026)
* fix: UI toast typo

* translate

* fix error msg
2021-02-10 08:17:54 +00:00
Thinking Chen
4ba98bf8c8
fix: untranslated text content of Dashboard page (#13024)
* fix: fix the untranslated text content of Dashboard page

* fix: add the untranslated text content of Dashboard page in messages.pot

* fix linting error

Co-authored-by: chenx <yuxiang1989>
2021-02-09 10:34:22 -08:00
Michael S. Molina
d5e6190998
Refresh dashboard list after bulk delete (#12945) 2021-02-08 16:49:23 -08:00
Michael S. Molina
dd0af74019
Updates storybook to version 6.1.17 (#13014) 2021-02-08 16:47:09 -08:00
Kamil Gabryjelski
2ce79823df
feat: Save datapanel state in local storage (#12996)
* Save datapanel state in local storage

* Export string to a constant

* Move local storage helpers to separate file

* Use helper functions in ExploreViewContainer
2021-02-08 16:42:59 -08:00
AAfghahi
69b0ed663d
fix: added text and changed margins (#12923) 2021-02-08 17:26:55 -05:00
simcha90
c440d98fad
refactor(native-filters): refactor code of native filters (#12889)
* refactor(native-filters): refactor code of native filters

* refactor: update refactor dependencies

* refactor: update refactor dependencies

* lint: fix lint

* fix: merge with master

* chore: fix selector
2021-02-08 13:26:58 +02:00
Lyndsi Kay Williams
022d18d359
refactor: TemplateParamsEditor.jsx converted from class to functional component (#12873)
* TemplateParamsEditor.jsx converted from class to functional component

* Fixed import in SqlEditor.jsx

* Corrected renderDoc

* Corrected renderModalBody

* Corrected functional name and import

* Corrected props

* Corrected modalBody and incorporated renderDoc

* Removed t strings

* Removed unnecessary single quotes

* Editor text updating correctly

* Split useState into three different hooks

* Removed onChangefunc, adjusted component to use onChange and code from props through useEffect

* Added parsedJSON reset to catch in useEffect

* Put a throttle on the onChange

* Switched from throttle to debounce
2021-02-07 21:44:39 -08:00
Beto Dealmeida
76bcc446f0
fix: SQL Lab editor height in Safari (#12973) 2021-02-05 13:10:07 -08:00
adam-stasiak-polidea
3235d918aa
test: Added some Cypress tests for Native Filters (#12180) 2021-02-04 22:54:00 -08:00
Phillip Kelley-Dotson
3bb14ab950
feat: reset metrics on dataset change (#12782)
* reset metrics on dataset change take one

* remove code

* part 2 or reseting adhoc controls

* update input controls and customize defaults

* remove conosles

* remove extra method

* simplify logic for controls reset and have them use their defaults

* remove consoles

* add annotation control to defaultvalues

* remove line
2021-02-05 14:08:27 +08:00
AAfghahi
ac3e16d0ac
fix: SqlLab Run button fix (#12956)
* button fix

* tooltips disabled when it is disabled, border width changed

* added isDisabled to tooltip
2021-02-04 20:21:43 -08:00
Kasia Kucharczyk
973306461c
[11907] Added detecting top scroll on Dashboard header (#12953) 2021-02-04 13:22:16 -08:00
Ville Brofeldt
ac73991913
fix(viz): improve dtype inference logic (#12933) 2021-02-04 10:47:27 -08:00
Jesse Yang
9982fdebd8
test: fix table chart sort order E2E tests (#12936)
* test: fix table chart sort order E2E tests

* Upgrade npm packages
2021-02-04 13:27:45 +02:00
Victor Malai
77093a874e
Add inclusive and exclusive for date start and end (#12859) 2021-02-04 14:55:02 +08:00
Victor Malai
137cf5d4d9
Add row limit control for timeseries table (#12887) 2021-02-04 14:29:14 +08:00
Ville Brofeldt
86b982a0a3
fix(viz): bump table viz to fix ordering bug (#12930) 2021-02-03 16:29:23 -08:00
Phillip Kelley-Dotson
76c225db7e
feat(explore): clear search on dataset change (#12909) 2021-02-03 00:02:45 -08:00
Beto Dealmeida
ab3f4bd94b
feat: add separate endpoint to fetch function names for autocomplete (#12840)
* WIP

* Add unit test for API

* Add spec

* Fix unit test

* Fix unit test

* Fix test

* Fix test

* Add period to error message
2021-02-02 18:01:01 -08:00
Michael S. Molina
5a79a7d993
Migrates Radio component from Bootstrap to AntD. (#12738) 2021-02-02 11:26:26 -08:00
simcha90
275e57f4f1
feat(style-theme): add support for custom superset themes (#12858)
* feat(style-theme): add support for custom superset themes

* refactor: update var names

* refactor: update name of theme
2021-02-02 13:09:49 +02:00
simcha90
5a9bf53246
refactor(color-schemes): refactor setting of color schemes (#12857)
* refactor(color-schemes): refactor setting of color schemes

* refactor: fix TS types
2021-02-02 11:31:21 +02:00
simcha90
465d986617
feat(native-filters): Add defaultValue for Native filters modal (#12199)
* refactor: sync Scoping tree with Forms data

* refactor: update scoping tree

* refactor: update scope tree logic to be more UX friendly

* test: fix tests

* lint: fix lin CR notes

* chore: temp

* fix: fix jsx

* feat: Init value

* refactor: move effect to utils

* chore: add comments

* feat: updates for default value in native filters

* refactor: move multi values management to Modal

* feat: added currentState to filterState
fix: Reset all fixed

* style: update filter styles

* fix: process selection of same filter

* fix: fix double choose select

* fix: fix order of cascading filters

* fix: fix CR comments

* fix: fix CR comments
2021-02-02 11:28:12 +02:00
ʈᵃᵢ
941d924df3
fix(menu): always show settings dropdown (#12877) 2021-02-02 09:17:15 +00:00
Michael S. Molina
2adfb85597
Migrates Label component from Bootstrap to AntD. (#12774) 2021-02-01 22:15:07 -08:00
Michael S. Molina
c781ab8adf
Migrates Button component from Bootstrap to AntD (#12832) 2021-02-01 15:13:10 -08:00
Jesse Yang
783aae19c9
chore: bump superset-ui packages to v0.17.2 and v0.17.3 (#12854)
* chore: bump superset-ui packages to v0.17.2 and v0.17.3

* Bump also the nvd3 chart
2021-02-01 14:32:55 +02:00
Agata Stawarz
30be86f811
chore(native-filters): Connect indicator magnifier with Filter Bar (#12812)
* Add direct path to child to native filter components

* Implement focus for cascading filters

* Remove empty line
2021-01-30 15:15:44 +02:00
Ville Brofeldt
61e56b5027
fix(explore): add current savedMetric to dropdown (#12835) 2021-01-29 22:51:35 +02:00
Lyndsi Kay Williams
8bc5c40eab
refactor: change Windows new tab shortcut to ctrl + q (#12772) 2021-01-29 12:49:13 -05:00
Kamil Gabryjelski
c6093a7469
fix: Remove double tooltip from metric label (#12736)
* Remove tooltip from AdhocMetricOption

* Lint fix

* Add tooltip for adhoc metrics

* Typo fix
2021-01-29 17:01:58 +02:00
Nikola Gigić
1603e82a03
chore(explore): Metric/Column and Filter popover unexpectedly closes on scroll (#12817)
* fix

* address filter popup
2021-01-29 16:53:00 +02:00
Jesse Yang
e3db935c62
refactor: migrate table chart to new API (#10270)
* refactor: migrate table chart to new API

* chore: bump superset-ui to 0.17.0

* Fix Cypress tests

* Apply soft-conversion to numeric metrics

Fix time column formatting test

* Add translation to chart does not exist error

* Bump to 0.17.1
2021-01-29 13:12:09 +02:00
Yongjie Zhao
642a76f6cc
fix(explore): time picker can not be switched between now and specific (#12793)
* fix(explore): time picker can not be switched between now and specifc

* fix linting

* fix type

* fix UT
2021-01-29 13:35:57 +08:00
Kamil Gabryjelski
fcaa0acad5
chore: Upgrade react-dnd to 11.1.3 (#12815) 2021-01-28 18:34:56 -08:00
Ye Ding
34549cb5b7
docs: Add support for Hologres (#12710) 2021-01-28 16:36:06 -08:00
Moriah Kreeger
fa8c492acd
fix: rm grace period field for reports modal (#12800)
* add rc4 changelog entries

(cherry picked from commit 5719fefdd4)

* only show grace period for alerts + fix dropdown styling

* fix lint

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-01-28 15:17:14 -08:00
Lyndsi Kay Williams
17bdaaaa2d
refactor: Updated tooltip help text in edit database > SQL Lab settings (#12795) 2021-01-28 13:27:29 -05:00
Kamil Gabryjelski
14de7b4791
feat(explore): Make metric title respond to changes immediately (#12747)
* Make metric title respond to changes immediately

* Bug fix

* Change type to Metric

* Bug fix
2021-01-28 08:58:39 +02:00
Nikola Gigić
c475f6b173
chore(explore): Reorder dataset search results based on property relevance (#12770) 2021-01-27 17:49:02 -08:00
Daniel Vaz Gaspar
11ca7301b5
docs: fix 1.0.0 README images (v2) (#12792) 2021-01-27 18:50:54 +00:00
Daniel Vaz Gaspar
044d1ae3a3
docs: fix, keep old names from screenshot images to pypi releases (#12664)
* fix: keep old names from screenshot images to pypi releases

* change db logos to github raw content

* add gallery link
2021-01-27 13:53:03 +00:00
Ville Brofeldt
997befcacd
fix(explore): pass partitionColumn when creating new adhoc filter (#12789)
* fix(explore): pass partitionColumn when creating new adhoc filter

* add default value to state

* remove duplicated code

* update translations
2021-01-27 15:48:54 +02:00
Ayan Ginet
7acbb3c845
fix(explore): Dataset icon remains constant when dragging. (#12761)
* fix: constant icon size

* clean up
2021-01-27 14:10:36 +08:00
ʈᵃᵢ
3ed915146d
fix(alerts/reports): misconfigured useEffect hook breaks form validation in prod builds (#12779) 2021-01-26 13:44:15 -08:00
simchaNielsen
da63b4b0ea
test(native-filters): scoping tree in native filters modal (#12655)
* test: add test to scoping tree in native filters

* test: rename mocks
2021-01-26 14:23:07 +02:00
Michael S. Molina
6bf5d2c06d
Fix tests errors and warnings - iteration 3 (#12212) (#12219) 2021-01-25 23:40:59 -08:00
Michael S. Molina
22d52eadb2
Fix tests errors and warnings - iteration 5 (#12212) (#12224) 2021-01-25 23:35:57 -08:00
Michael S. Molina
20503f92ae
Fix tests errors and warnings - iteration 6 (#12212) (#12227) 2021-01-25 23:34:05 -08:00
simchaNielsen
4d04565c9a
feat(native-filters): apply scoping of native filters to dashboard (#12716)
* feat: scoping native filters in dashboard

* test: add tests / fix reducer

* test: fix tests

* chore: merge with master

* fix: fix undefined cases

* fix: fix code according cypress

* refactor: fix mocks according CRs

* chore: re run pipeline
2021-01-26 09:29:49 +02:00
Michael S. Molina
0c08bb87c3
Fix tests errors and warnings - iteration 4 (#12212) (#12223) 2021-01-25 23:24:41 -08:00
Michael S. Molina
0fc9da6be7
Fix tests errors and warnings - iteration 7 (#12212) (#12245) 2021-01-25 23:19:16 -08:00
Jesse Yang
e8857bac04
fix: missing select menu background (#12759) 2021-01-25 22:19:55 -08:00
Jesse Yang
ab741d7218
fix(explore): incorrect missing datasource condition (#12758) 2021-01-26 12:37:38 +08:00
Phillip Kelley-Dotson
a5df4c60a2
feat: default timepicker to last week when dataset is changed (#12609)
* set up timepicker to last when dataset is changed

* simplify logic for dataset change

* update modal code

* remove uneeded code

* fix bug

* fix bug
2021-01-26 11:14:52 +08:00
Jesse Yang
55c8f9ba60
feat(explore): allow opening charts with missing dataset (#12705) 2021-01-25 15:09:03 -08:00
Jesse Yang
29ad78e11a
chore: upgrade Cypress to 6.2.1 (#12605) 2021-01-25 15:05:43 -08:00
Geido
1b2611c211
refactor(explore): Enhance Dataset and Control panel Collapse components (#12218) 2021-01-25 15:05:19 -08:00
Michael S. Molina
3fb183349f
Fix tests errors and warnings - iteration 2 (#12212) (#12214) 2021-01-25 12:03:16 -08:00
Kamil Gabryjelski
90856544e9
Replace space with tabulator and enter as separators (#12730) 2021-01-25 17:01:10 +02:00
Nikola Gigić
9ab804b2bd
chore[explore]: Save date if Ok not clicked (#12731)
* Save date if Ok not clicked

* answering. comments
2021-01-25 19:48:45 +08:00
Yongjie Zhao
307e3a9f65
chore(explore): added tooltips to timepicker (#12580)
* wip

* wip

* fix lint

* fix: tooltip cosmetic

* wip

* add license
2021-01-25 15:58:15 +08:00
Nikola Gigić
bcbd8f9326
chore(explore): Save Resizable width to localStorage (#12593) 2021-01-24 20:30:09 -08:00
Yongjie Zhao
9e58eb809e
fix(explore): deprecated x periods pattern in new time picker value (#12552) 2021-01-23 23:41:15 -08:00
Jesse Yang
ef839f674d
fix: remove whitespace at the bottom of select dropdown (#12699) 2021-01-24 09:10:32 +08:00
Kasia Kucharczyk
dc740ecc1e
[12486] Top tab dropdown indicator moved closer to the bottom of edge (#12658) 2021-01-23 15:48:38 +08:00
Ville Brofeldt
ede879022c
fix(multiline): return all chart data on initial request (#12660)
* fix(multiline): return chart data on data request

* bump package

* optimize chart retrieval and fix chart form_data
2021-01-23 15:01:50 +08:00
Agata Stawarz
0c38134e5c
fix(native-filters): Reset column field for removed dataset (#12519)
* Reset column field for removed dataset

* Fix issue with cleaning exisiting field

* Fix lint error and remove unnecessary import

* Change message text for wrong filter

* Add Basic Error Alert component

* Fix hiding error after filter correction
2021-01-23 13:24:31 +08:00
Agata Stawarz
b37598cc97
fix(native-filters): Improve UI for long native filters names (#12524)
* Fix UI for long native filters names

* Add Filter width const

* Refactor Filter Bar and Config Modal

* Break word for long Filter Control titles
2021-01-23 13:24:15 +08:00
Agata Stawarz
9c53ad48aa
fix(native-filters): Show incompatible native filters indicator (#12687)
* Show incompatible native filters indicator

* Add Native Filters mocks and tests to Filter Badge

* Compare filter names in deduplication logic

* Add indicator key

* Remove unnecessary import
2021-01-23 13:23:21 +08:00
Jesse Yang
7e77975d22
feat(explore): better search for dataset pane (#12675)
1. Upgrade match-sorter from 4.1.0 to 6.1.0
2. Add a debounce delay of 200 milliseconds to reduce excessive rendering (and searching)
3. Set keepDiacritics to true to improve performance
4. Display count of filtered results in "Showing x of xx", instead of the total results
5. Rank certified metrics to the top
2021-01-22 14:26:55 -08:00
Jesse Yang
55232e235a
fix: faster search for Change Dataset modal (#12669) 2021-01-22 14:26:02 -08:00
Geido
b32b6cd5de
fix(explore): Certified metric icons are various sizes (#12690) 2021-01-22 13:14:40 -08:00
Michael S. Molina
e80cd61e06
Apply capitalization guidelines - iteration 5 (#12343) (#12451) 2021-01-22 10:11:48 -08:00
Michael S. Molina
fc20e8b594
Apply capitalization guidelines - iteration 4 (#12343) (#12450) 2021-01-22 10:11:38 -08:00
Michael S. Molina
5d3265b6db
Apply capitalization guidelines - iteration 3 (#12343) (#12449) 2021-01-22 10:11:28 -08:00
Jesse Yang
57fa6d2cf9
fix: explore page style fix, remove unnecessary scroll bars (#12649)
* fix: various style touch on Explore page

* More style fixes

* Force 100% height for sidebars

* Fix linting
2021-01-22 09:18:13 -08:00
Michael S. Molina
7838f035ae
Apply capitalization guidelines - iteration 9 (#12343) (#12455) 2021-01-21 21:46:29 -08:00
Michael S. Molina
217034e990
Apply capitalization guidelines - iteration 8 (#12343) (#12454) 2021-01-21 21:46:18 -08:00
Michael S. Molina
d9388d4535
Apply capitalization guidelines - iteration 7 (#12343) (#12453) 2021-01-21 21:46:06 -08:00
Michael S. Molina
2a587f6cb1
Apply capitalization guidelines - iteration 6 (#12343) (#12452) 2021-01-21 21:45:44 -08:00
Michael S. Molina
8532e6d9e1
Apply capitalization guidelines - iteration 2 (#12343) (#12448) 2021-01-21 21:45:12 -08:00
Kamil Gabryjelski
6280b34483
fix(explore): don't allow selecting duplicated saved metric (#12657) 2021-01-21 15:51:59 -08:00
Kamil Gabryjelski
a90ebd94d4
fix(explore): Error message not displayed correctly in Timeseries table chart (#12659)
* Fix error message not displayed correctly in Timeseries table chart

* Fix lint error
2021-01-22 12:42:44 +13:00
Geido
3444d654ed
fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals (#12598) 2021-01-21 10:34:41 -08:00
Ville Brofeldt
734fb75219
chore(viz): bump superset-ui packages to 0.16.9 (#12632) 2021-01-21 13:50:47 +02:00
Kasia Kucharczyk
effd717094
[12601] Hovered menu items on dashboard - brought back padding and added margin on top of chart (#12603) 2021-01-21 11:32:34 +02:00
Agata Stawarz
c72c39bffd
feat(native-filters): Show alert for unsaved filters after cancelling Filter Config Modal (#12554)
* Add Alert when native filter is canceled and not saved

* Improve styles and setting styles visible

* Improve displaying filter names

* Add tests for canceling native filter modal

* Fix linter errors

* Refactor Cancel Confirmation Alert
2021-01-20 20:57:28 -08:00
Srini Kadamati
7577f47706
docs: update README.MD and FAQ Page for Superset 1.0 launch (#12499)
* fixed whitespace

* commit exclusion of package-lock from large file size precommit hook

* Converted all PNG files to JPG files to save space, stay under <500kb file size

* added link to release notes for 1.0
2021-01-20 16:27:19 -08:00
Kasia Kucharczyk
b592165f68
fix: dropdown indicator in tabs has proper width and position (#12584)
Closes #12481 , partially fix #12486
2021-01-20 14:18:42 -08:00
Michael S. Molina
c85b4c75b1
Fix translation files and update documentation (#12595) 2021-01-20 10:50:24 -08:00
simchaNielsen
2463215d73
refactor: Sync Scoping tree with Forms data (#12171)
* refactor: sync Scoping tree with Forms data

* refactor: update scoping tree

* refactor: update scope tree logic to be more UX friendly

* test: fix tests

* lint: fix lin CR notes

* fix: fix jsx

* refactor: revert type changes

* refactor: revert type changes

* lint: fix lint

* lint: fix lint

* test: fix test

* fix: process initial dashboard case

* lint: fix lint / tests
2021-01-20 11:40:53 +02:00
Nikola Gigić
a422c765c7
chore(chart): Save modal select placeholder value (#12413)
* Fix SaveModal select value

* var name change and null

* Address Comments
2021-01-19 22:17:56 -08:00
Kamil Gabryjelski
853d34beba
fix(explore): Disable saved metric name edit in Metric popover (#12582) 2021-01-19 12:28:55 -08:00
Duy Nguyen Hoang
862ddd9cb4
fix: chart disappears in standalone slice (#12606) 2021-01-19 11:56:24 -08:00
Hugh A. Miles II
68fe2208ba
fix: save tabs when saving the query bug (#12607)
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-01-19 14:27:48 -05:00
Geido
c347ddbfb6
Switch button position (#12604) 2021-01-19 10:26:46 -08:00
Evan Rusackas
dd4256a841 chore: bumping superset UI packages (0.16.7 + 0.16.8) (#12564)
* chore: package bump manifest (package.json)

* fresh package lock
2021-01-19 09:38:04 -08:00
Yongjie Zhao
9771b82c94
refactor(explore): move MetricControl and FilterControl to sub-component (#12446)
* wip

* wip

* wip

* wip

* move spec

* wip

* wip

* remove unused file

* wip

* wip

* Update superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopoverSqlTabContent_spec.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/explore/components/AdhocFilterOption_spec.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopoverTitle_spec.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-01-19 22:46:28 +08:00
Nikola Gigić
a0f3bb8dbe
feat(chart): Add expression, description and verbose name to search filter (#12549) 2021-01-18 09:38:19 -08:00
Kasia Kucharczyk
4ddb55b930
fix: row component handler is visible (#12498) 2021-01-17 16:38:17 -09:00
Hugh A. Miles II
db4664ec11
fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555) 2021-01-15 18:00:33 -05:00
Beto Dealmeida
39c6ef2c75
fix: incorrect cursor position Firefox (#12423)
* fix: incorrect cursor position Firefox

* Use different font

* Fix lint

* Use Lucida Console
2021-01-15 14:00:23 -08:00
Beto Dealmeida
cce05e888b
fix: height on grid results (#12558) 2021-01-15 13:54:55 -08:00
Kamil Gabryjelski
e1eeeebe53
fix: Select options overflowing Save chart modal on Explore view (#12522)
* Fix select options overflowing modal

* fix unit test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-01-15 12:43:33 +02:00
Jesse Yang
1dd3344206
fix(explore): Add Time section back to FilterBox (#12537) 2021-01-14 22:09:33 -08:00
Jesse Yang
41b7eb3d04
fix(explore): time table control panel (#12532) 2021-01-14 19:17:35 -08:00
Agata Stawarz
57e37ed4d5
fix: Displaying filter indicators (#12252)
* Fix chart filter indicator to match native filter indicator

* Refactor indicators deduplication
2021-01-14 10:57:41 -08:00
Geido
c1b8a46d01
fix: Popover closes on change of dropdowns values (#12410) 2021-01-14 10:33:20 -08:00
Jesse Yang
eec78560f2
build: fix emotion theme errors when npm link @superset-ui/core (#12510) 2021-01-14 10:20:13 -08:00
Ville Brofeldt
78baf46eb2
ci(cypress): disable failing test (#12523) 2021-01-14 19:40:28 +02:00
Karol Kostrzewa
241f380e2e
test: World bank examples (#12161)
* add world bank data fixture

* fix fixture cleanup, add fixture to dashboard_tests

* apply world bank fixtures, fix tests

* fix fixture typo, dashboard ids

* fix export dashboard metadata

* fix test_export_dashboard_command_key_order

* fix export dash tests, not add row when no orphans

* debug timeout

* fixes after merge

* fix lint

* run pre-commit

* comment test for debug

* fix save.test.js

Co-authored-by: Karol Kostrzewa <karol.kostrzewa@polidea.com>
2021-01-13 14:20:05 -08:00
Michael S. Molina
87ac22ba52
Fix list filters vertical alignment (#12497) 2021-01-13 13:58:05 -08:00
Moriah Kreeger
628a9b2b7b
keep modal open on error, utilize useEffect (#12360) 2021-01-13 10:53:31 -08:00
Lily Kuang
908c0f2b52
remove crontab guru link (#12467) 2021-01-13 10:49:54 -08:00