pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 13:57:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: Scrolls top when opening a select filter (#15141)

Browse Source
This commit is contained in:
Michael S. Molina 2021-06-15 05:10:23 -03:00 committed by GitHub
parent 90d9097841
commit b3c197903c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
View File

@ -29,12 +29,20 @@ import {
t,
tn,
} from '@superset-ui/core';
import React, { useCallback, useEffect, useMemo, useState } from 'react';
import React, {
RefObject,
ReactElement,
useCallback,
useEffect,
useMemo,
useState,
} from 'react';
import { Select } from 'src/common/components';
import debounce from 'lodash/debounce';
import { SLOW_DEBOUNCE } from 'src/constants';
import { useImmerReducer } from 'use-immer';
import Icons from 'src/components/Icons';
import { usePrevious } from 'src/common/hooks/usePrevious';
import { PluginFilterSelectProps, SelectValue } from './types';
import { StyledSelect, Styles } from '../common';
import { getDataRecordFormatter, getSelectExtraFormData } from '../../utils';
@ -115,6 +123,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
return [...firstData, ...restData];
}, [col, selectedValues, data]);
const [isDropdownVisible, setIsDropdownVisible] = useState(false);
const wasDropdownVisible = usePrevious(isDropdownVisible);
const [currentSuggestionSearch, setCurrentSuggestionSearch] = useState('');
const [dataMask, dispatchDataMask] = useImmerReducer(reducer, {
extraFormData: {},
@ -276,6 +285,14 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
onSelect={clearSuggestionSearch}
onBlur={handleBlur}
onDropdownVisibleChange={setIsDropdownVisible}
dropdownRender={(
originNode: ReactElement & { ref?: RefObject<HTMLElement> },
) => {
if (isDropdownVisible && !wasDropdownVisible) {
originNode.ref?.current?.scrollTo({ top: 0 });
}
return originNode;
}}
onFocus={setFocusedFilter}
// @ts-ignore
onChange={handleChange}