pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: roles undefined on public dashboards (#14648)

This commit is contained in:
David Aaron Suddjian 2021-05-14 14:28:47 -07:00 committed by GitHub
parent ba5d66cb0a
commit 884ded0507
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
superset-frontend/src/dashboard/util/findPermission.test.ts
View File

@ -132,6 +132,13 @@ describe('canUserEditDashboard', () => {
it('rejects nonexistent users', () => {
expect(canUserEditDashboard(dashboard, null)).toEqual(false);
});
it('rejects missing roles', () => {
// in redux, when there is no user, the user is actually set to an empty object,
// so we need to handle missing roles as well as a missing user.s
expect(
canUserEditDashboard(dashboard, {} as UserWithPermissionsAndRoles),
).toEqual(false);
});
it('rejects "admins" if the admin role does not have edit rights for some reason', () => {
expect(
canUserEditDashboard(dashboard, {

2
superset-frontend/src/dashboard/util/findPermission.ts
View File

@ -48,6 +48,6 @@ export const canUserEditDashboard = (
dashboard: Dashboard,
user?: UserWithPermissionsAndRoles | null,
) =>
!!user &&
!!user?.roles &&
(isUserAdmin(user) || isUserDashboardOwner(dashboard, user)) &&
findPermission('can_write', 'Dashboard', user.roles);