pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 13:57:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(native-filters): default value not populated on second opening (#14401)

Browse Source
This commit is contained in:
Ville Brofeldt 2021-04-29 09:09:47 +03:00 committed by GitHub
parent b38aadf9e4
commit 4410fd047e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
View File

@ -124,19 +124,7 @@ export const FiltersConfigForm: React.FC<FiltersConfigFormProps> = ({
const forceUpdate = useForceUpdate();
const [datasetDetails, setDatasetDetails] = useState<Record<string, any>>();
// make sure the formFilter is populated
if (!form.getFieldValue('filters')) {
setNativeFilterFieldValues(form, filterId, filterToEdit || {});
forceUpdate();
}
const formFilter = form.getFieldValue('filters')[filterId];
useEffect(() => {
setNativeFilterFieldValues(form, filterId, {
defaultValue: filterToEdit?.defaultValue,
});
forceUpdate();
}, [form, forceUpdate, filterId, filterToEdit?.defaultValue]);
const formFilter = form.getFieldValue('filters')?.[filterId] || {};
const nativeFilterItems = getChartMetadataRegistry().items;
const nativeFilterVizTypes = Object.entries(nativeFilterItems)

7
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/state.ts
View File

@ -45,11 +45,4 @@ export const useBackendFormUpdate = (
forceUpdate,
filterId,
]);
useEffect(() => {
setNativeFilterFieldValues(form, filterId, {
defaultValue: formFilter?.defaultValue,
});
forceUpdate();
}, [form, formFilter?.defaultValue, forceUpdate, filterId]);
};