fix: font regression in SQL Lab (#14960)

* fix: font regression in SQL Lab

* Fix tests
This commit is contained in:
Beto Dealmeida 2021-06-08 15:52:57 -07:00 committed by GitHub
parent a59bbbc544
commit 3f527c7a45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 14 additions and 3 deletions

View File

@ -44,6 +44,7 @@ const mockedProps = {
message: 'Error message',
},
source: 'dashboard' as ErrorSource,
subtitle: 'Error message',
};
test('should render', () => {

View File

@ -35,6 +35,7 @@ interface DatabaseErrorExtra {
function DatabaseErrorMessage({
error,
source = 'dashboard',
subtitle,
}: ErrorMessageComponentProps<DatabaseErrorExtra>) {
const { extra, level, message } = error;
@ -81,7 +82,7 @@ ${extra.issue_codes.map(issueCode => issueCode.message).join('\n')}`;
return (
<ErrorAlert
title={t('%s Error', extra.engine_name || t('DB engine'))}
subtitle={message}
subtitle={subtitle}
level={level}
source={source}
copyText={copyText}

View File

@ -50,7 +50,13 @@ export default function ErrorMessageWithStackTrace({
error.error_type,
);
if (ErrorMessageComponent) {
return <ErrorMessageComponent error={error} source={source} />;
return (
<ErrorMessageComponent
error={error}
source={source}
subtitle={subtitle}
/>
);
}
}

View File

@ -44,6 +44,7 @@ const mockedProps = {
message: 'Error message',
},
source: 'dashboard' as ErrorSource,
subtitle: 'Error message',
};
test('should render', () => {

View File

@ -54,6 +54,7 @@ const findMatches = (undefinedParameters: string[], templateKeys: string[]) => {
function ParameterErrorMessage({
error,
source = 'sqllab',
subtitle,
}: ErrorMessageComponentProps<ParameterErrorExtra>) {
const { extra, level, message } = error;
@ -112,7 +113,7 @@ ${extra.issue_codes.map(issueCode => issueCode.message).join('\n')}`;
return (
<ErrorAlert
title={t('Parameter error')}
subtitle={message}
subtitle={subtitle}
level={level}
source={source}
copyText={copyText}

View File

@ -88,6 +88,7 @@ export type ErrorMessageComponentProps<
> = {
error: SupersetError<ExtraType>;
source?: ErrorSource;
subtitle?: React.ReactNode;
};
export type ErrorMessageComponent = React.ComponentType<ErrorMessageComponentProps>;