* split db modal file
* split db modal file
* hook up available databases
* add comment
* split db modal file
* hook up available databases
* use new validation component
* first draft
* use new validation component
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* get tests passing
* Removed logo from test
* split db modal file
* hook up available databases
* use new validation component
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* saving for now
* revisions
* fix package-lock.json
* update styles
* save
* # This is a combination of 6 commits.
# This is the 1st commit message:
feat: validation db modal (#14832)
* split db modal file
* hook up available databases
* use new validation component
# This is the commit message #2:
feat: Icon Button (#14818)
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
# This is the commit message #3:
chore: Improves the native filters UI/UX - iteration 6 (#14932)
# This is the commit message #4:
fix: is_temporal should overwrite is_dttm (#14894)
* fix: is_temporal should overwrite is_dttm
* move up
# This is the commit message #5:
fix: time parser truncate to first day of year/month (#14945)
# This is the commit message #6:
hook up available databases
* fix test for db modal
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* more revisions
* create 1 function for setting the DB
* add function to preferred section
* small refactor and added styling
* used db.backend
* add new footer buttons
* add finsh buttong
* refactor db modal render
* fix comments issue
* added engine to model
* elizabeth revisions
* add header
* add bottom footer to sqlalchemy form
* # This is a combination of 6 commits.
# This is the 1st commit message:
feat: validation db modal (#14832)
* split db modal file
* hook up available databases
* use new validation component
# This is the commit message #2:
feat: Icon Button (#14818)
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
# This is the commit message #3:
chore: Improves the native filters UI/UX - iteration 6 (#14932)
# This is the commit message #4:
fix: is_temporal should overwrite is_dttm (#14894)
* fix: is_temporal should overwrite is_dttm
* move up
# This is the commit message #5:
fix: time parser truncate to first day of year/month (#14945)
# This is the commit message #6:
hook up available databases
* fix test for db modal
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* elizabeth revisions
* add back headers
* add step
* feat: Dynamic Form for edit DB Modal (#14845)
* split db modal file
* split db modal file
* hook up available databases
* add comment
* split db modal file
* hook up available databases
* use new validation component
* first draft
* use new validation component
* get tests passing
* split db modal file
* hook up available databases
* use new validation component
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* revisions
* fix package-lock.json
* # This is a combination of 6 commits.
# This is the 1st commit message:
feat: validation db modal (#14832)
* split db modal file
* hook up available databases
* use new validation component
# This is the commit message #2:
feat: Icon Button (#14818)
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
# This is the commit message #3:
chore: Improves the native filters UI/UX - iteration 6 (#14932)
# This is the commit message #4:
fix: is_temporal should overwrite is_dttm (#14894)
* fix: is_temporal should overwrite is_dttm
* move up
# This is the commit message #5:
fix: time parser truncate to first day of year/month (#14945)
# This is the commit message #6:
hook up available databases
* fix test for db modal
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* more revisions
* used db.backend
* added engine to model
* elizabeth revisions
* elizabeth revisions
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: hughhhh <hughmil3s@gmail.com>
* address comments
* oops
* # This is a combination of 6 commits.
# This is the 1st commit message:
feat: validation db modal (#14832)
* split db modal file
* hook up available databases
* use new validation component
# This is the commit message #2:
feat: Icon Button (#14818)
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
# This is the commit message #3:
chore: Improves the native filters UI/UX - iteration 6 (#14932)
# This is the commit message #4:
fix: is_temporal should overwrite is_dttm (#14894)
* fix: is_temporal should overwrite is_dttm
* move up
# This is the commit message #5:
fix: time parser truncate to first day of year/month (#14945)
# This is the commit message #6:
hook up available databases
* fix test for db modal
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* remove merge conflicts
* small fix on blocking creating
* feat(db-connection-ui): Big Query Add Database Form (#14829)
* fix(native-filters): Manage default value of filters by superset (#14785)
* fix:fix get permission function
* feat: manage default value in superset
* fix(native-filters): loop bug by simplify state handling (#14788)
* fix: set table name width to not hide icons when name is too long (#14489)
* fix: set table name width to now hide icons when name is too long
* fix: table style
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
* feat(explore): Remove default for time range filter and Metrics (#14661)
* feat(explore): Remove default for time range filter and Metrics
* Merge errors with same messages
* Fix e2e test
* Rename a variable
* Bump packages
* Fix unit tests
* feat: chart gallery search improvement (#14484)
* feat: chart gallery search improvement
* test: adding unit test for VizTypeControl
* fix: lint errors
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
* Update schemas.py
* Update bigquery.py
* Fix tests
* big query form is appearing on the screen
* add name to allow for actions to get picked up
* working post for saving db via paste
* working file upload
* switch to textare
* better styles
* add delete buttong
* save formating
* wrap encrypted_extra
* formatting component
* clear out file input before reloading
* remove default driver
* address comments
* fix things off rebase
* small refactore
* more patches
* checkout space file
* fix variable ref
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Einat Bertenthal <einatbar@users.noreply.github.com>
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* feat: adding SSL Toggle to Create Database Modal (#14976)
* first draft of SSL Toggle
* added payload data
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* changed tooltips based on stephen advice
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
* feat(database-connection-ui) Allow configuration of Database Images from SupersetText (#15023)
* saving this for now
* fix some styles
* add database images
* fix
* enforce only numbers
* add default iamge
* fix bug
* additional params to the DatabaseConnectionForm (#15071)
* additional params to the DatabaseConnectionForm
* save passing params up to api
* feat: Added Steps and centralized Headers (#15041)
* fix superset_text issue (#15095)
* fix edit issue by returning parameters properly (#15101)
* feat: added alerts (#15103)
* added alerts
* revisions
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* fix: fixing api tests for database connections (#15124)
* fixing api tests
* added test for no config method on create
* added config method to validation tests
* fix(db-connection-ui): Additional Query Parameters render (#15150)
* working query params
* move condition out before update or create
* fix type script issues
* feat(db-connection-ui): Move fields from Extra section and split engine and metadata (#15143)
* working edit extra options
* acquired most of json
* recontruct json
* add schema array
* add proper styles
* fix tslint issues
* remove console.log
* this is working
* style: Database connect UI Polish - Step 1 (#15119)
* save avg
* Styled step 1
* Remove Alert
* Finished styling, added ellipsis library to IconButton
* Fixed text margin
Co-authored-by: hughhhh <hughmil3s@gmail.com>
* fix app from merge
* fix tslint issues
* fix all tslint issue on feature branch
* catch errors for dialects with no driver set
* fix dremio issue
* fix dialect issue without driver attr
* Styled step 3 (#15187)
* feat: adding server-side validation and unmasked password on create (#15151)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* validation and password masking
* revisions and validation range
* revisions
* added beto revisions
* added tests for port range
* added config to available
* testing, rtl
* made tests always pass
* feat: add Close/Finish buttons to DBModal on Edit (#15199)
* fix(db-connection-ui): Allow Dynamic Big Query Edits (#15185)
* working big query edits
* fix big stoping users from moving to next step
* fix default
* save defaults
* fix tslint
* remove object
* fix styling
* fix: Connect on DB Connection wasn't working (#15201)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* fixed the connect button
* make available alphabetically sort
* make available alphabetically sort II
* fix selection
* remove console.log
* fix styling
* fix: fix api_test and typeScript error (#15202)
* fix big query issue
* allow for query params
* feat: Added Dynamic form link to SQL Alchemy Form (#15208)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* added dynamic form link
* fix: fix api tests for test_available (#15210)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* fixes api tests
* feat: added Spinner to DB Modal (#15229)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* Made header sticky (#15204)
* fix: make Edit DB modal look similar to create Modal (#15231)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* changed edit
* fix: DB Connection UI R2 Fixes (#15232)
* fix display name refill
* fix order of additional params to always be at the bottom
* remove schema check on validation
* make encryption last
* fix json file upload
* fix additional params issue
* remove comments
* add back validation
* small fixes on bigquery edit
* only wrap encrypted with bigquery
* specific conditions for wrapping big query items
* dix additional params
* fix allow display name in sqlalchemy form
* backend before engine
* fix: do not use Marshmallow validation in partial params validation (#15236)
* fix: do not use Marshmallow validation in partial params validation
* Fix lint
* Update test
* make display name required
* reset validation errors onClose (#15243)
* fix: Edit for all dynamic forms (#15244)
* fix edit for dynamic forms
* fix linting
* fix edit on sqlalchemy forms
* fix big query reference
* remove extra if
* wrap configuration method (#15274)
* add more specific engine elastic search (#15287)
* do a deep copy of obj before POST (#15298)
* feat: add Back button to extra options (#15300)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* first draft
* working
* added back button to create modal
* revisions and testing
* chore: Add tooltips and button to Connect Postgresql DB Modal Form (#15179)
* Added tooltips. Still need to place in the right spot.
* Revert to where I started.
* Added 3 tooltips, 1 Button(need link config). BigQuery not added yet.
* Added tooltip BigOuery modal. `span` above upload btn missing `*`
* Added tooltip to `Host` field. Alignment needs to be fixed.
* Stuck trying to add conditional render of tooltip to LabeledErrorBoundInput
* Clean commit for review
* Dynamic tooltip componet created. Needs alignment of SVG still.
* Fixed typo.
* Added line spacing back in
* Changed required props to optional/Remove comment
* Fixed alignment of tooltips & moved 2tooltips outside of Btn
* Added one more line space back in
* Removed Typo
* Removed another typo
* Flixed linter error
* Created test for tooltip.
* Added expectation for visible tooltipIcon
Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>
* style: Database Modal UI Polish (#15234)
* Corrected polishing tasks from Clubhouse ticket
* More UI polish
* Added more polish
* Moved encryption field and created constant value for viewBox in InfoToolTip
* feat: allow editing (#15308)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* elizabeth fixed the edit issue
* feat: Added error alert for DB connection Modal (#15242)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* added errorAlert
* added revisions
* current work
* revisions
* fix: validation on edit (#15310)
* fix: Big Query Error messaging (#15334)
* remove validation check
* remove validation check
* fix error messaging
* stop validation on big query
* add condition for skipping specific engines for validation
* if no params
* update styles
* feat: big Query using back button (#15338)
* fix: password errors on validation (#15372)
* filter out password supply for validation
* filter password
* feat: updated Error Alert (#15377)
* Updated styling (#15379)
* fix password error filter
* feat: Arash/password field error (#15388)
* fix: Back Button on Create for DB conncetion (#15389)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* fixing backButton on Create
* fix doc (#15393)
* style: Database Connection Modal UI Polish R5 (#15412)
* Fixed inconsistent header spacing in step 1
* Touched up tooltips
* Added red *s to BigQuery form
* Centered modal window
* make alerts configurable (#15404)
* fix: Allow users to override database connection docs (#15434)
* allow users to override docs
* fix linting issue
* fix: Error Icon not showing up on errored input fieds on validation (#15431)
* Fixed now-show error icon
Signed-off-by: andrewbastian <andrew.bastian@gmail.com>
* Changed `%` to `px`
* Fixed lint error
* Changed units to `theme.gridUnit`
* test: RTL testing on DatabaseModal (#15394)
* RTL testing on DatabaseModal
* Continued RTL testing on DatabaseModal
* Code cleanup
* Removed a comment that missed my radar
* test: Add e2e testing (#15376)
* create boilerplate for cypress test
* added 1 more test
* add more test cases
* saving this for development
* lit
* remove name
* update pass
* remove unused test
* fix merge conflicts
* Fixed "connetion" typo (#15458)
* fix: Database connection modal touch up (#15463)
* Removed unnecessary TODO and named the remaining ones
* Added translation functionality
* Fixed typo in Database Modal RTL test
* Update modal.test.ts
* fix: Showing errors for SQLA forms (#15462)
* fix documentation links
* fix sqlalchemy onCreate
* Fixing SQLA error messaging
* fix logic for extra save
* fix this issue
* fix: Update Invalid Port SIP-40 Reference (#15464)
* Fixed jumpy header text
* fix: Edit Modal not saving properly (#15468)
* Aligned info icons on dynamic form
* fix: merge conflict (#15479)
* chore: simplify errors and issue codes (#15437)
* Fix issue number
* Fix test
* Fixed line-height in header, also fixed translation functions in BigQuery
* Updated placeholder text in additional params field
* Fixed padding in edit form
* Corrected placeholder text in BigQuery > Service Account field
* Make linter happy
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Arash <arash.afghahi@gmail.com>
Co-authored-by: hughhhh <hughmil3s@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Einat Bertenthal <einatbar@users.noreply.github.com>
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Andrew Bastian <50464395+andrewbastian@users.noreply.github.com>
Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>
* snowflake errors
* added big query
* added to setup error messages, first test
* all big query testing added
* added snowflake test
* added syntax error
* added syntax errors to most used databases
* intial commit
* fix test
* Update superset-frontend/src/components/LastUpdated/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Adding a show all button to the column/metrics list in the explore view
* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx
Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx
Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com>
* Fixing typo
Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com>
* fix: Enlarged select filter value
* fix: Makes the label take the whole width
* fix: Moves the required icon before the cascade icon
* fix: Fixes the cascading icon overlap with big texts
* fix time range default value
* defer time filter rendering to inView event
* avoid double fetching of time ranges
* lint
* move set to resolved promise
* fix(native-filters): default value checkbox in config modal
* disable checkbox if required
* simplify styling logic
* make default value mandatory if checked
* address comments
* Add min-height/width TrashIcon SVG(18px/18px)-Edit Dataset modal
* Reworked styling to be inline on SVG component via CSS from `emotion`
* Changed parameter from `css` to 'style'
* Fixed lint error.
* Changed `style` back to `css`
Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>
* Implement initial structure
* Add aria-label
* Rename files
* Refactor single mode new options
* Clean up
* Add select at every corner in storybook
* Clean up
* Add pagination
* Move selected options at the top
* Clean up
* Add license
* Refactor
* Improve pagination
* Fetch when allowNewOptions
* Clean up
* Convert TableElement to typescript
* Change type names to better match naming conventions in other files
* Fix import order and update tests on TableElement
* Remove defaultProps
* Destructure the props
* Use Rest and Spread syntax to condense props destructuring
* Fix TypeScript errors and add comment to explain antd props and types weirdness
* Remove comment, add consistency with other files, and use method chaining to make more concise
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* - Convert SliceHeader to TSX in progress
- Add menu option to download full CSV. Probably will change it
* Add Download Full CSV feature, and tests
* Added more tests, more TS fixes
* Added feature flag
* Update @superset-ui package versions
* Update @superset-ui packages versions
* use backend config instead of hardcoding number of rows
* Update tests
* front end test fix
* Lint fixes and test fixes
* fix(native-filters): Don't send unnecessary PUT request on dashboard render
* Run native filters scopes only if feature flag is enabled
* Change action name
* Run native filters scopes only if at least 1 filter added
* Fix lint
* Front end update - modify OPERATORS, to have SQL operation and display value
* Updated tests
* More tests
* Remove OPERATOR imports
* Fix break tests
* PR comments
* fix issue with comparator loading
* rename a variable
* Linting
* added additional configs and colors for queryHistory
* added condition to status icon
* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx
* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx
* Change TableElement from a class component to a functional component
* Replace class state checks in TableElement_spec.jsx with checks testing elements they change
* Refactor small bit of logic to use optional chaining
* Add optional chaining to some logic
* Fix IconTooltip and add IconTooltip to the collapse button
* Fix custom icon using IconToolTip so it better matches the original
* Update collapse/expand icon to use Icons component instead of importing from antdesign directly
* Fix eslint errors
* Clean up some code for readability
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* Optimize finding charts and tabs in scope
* Put filters out of scope in Collapse
* Use lastFocusedTabId instead of directPathToChild
* Fix tests
* Fix cypress test
* Uncomment e2e test
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
* feat(dashboard): Highlight tabs that contain a chart in scope of focused native filter
* Optimizations and improvements
* Use Set instead of array
* Simplify logic
* Change variable name
* feat(explore): Remove default for time range filter and Metrics
* Merge errors with same messages
* Fix e2e test
* Rename a variable
* Bump packages
* Fix unit tests
* fixing tests
* added testing
* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* removed decribe
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Highlight charts affected by focused native filter
* Remove tabs animation on dashboard
* Remove a test that checks for "animated={true}" prop on tabs
* Move hooks types to a separate interface
* Error Input Form created
* Adjusting styling
* testing complete
* Corrected component naming in Form
* testing complete
* Corrected component naming in Form
* Renamed stories file to appropriate name
* add image for alert
* Fixed test
* Switched from px to theme
* Adjusting LabeledErrorBoundInputProps
* validation now accepts a string
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Restrict operators when column is boolean
* refactor 'isOperatorRelevant' a little bit
* Include 'BOOLEAN' to handle presto
* Update tests
* number column should show bool operators
* fix test - some dbs translate true/false to 1/0
* Fix tests and add linting
* When column type is boolean, show bool operators
* Address PR comments - simplify conditions
* Fix a linting error
* Addressing PR comment - remove unused variables
* Sqllab limit
* Add migration script
* Set default values
* initial push
* revisions
* moving migration to separate PR
* revisions
* Fix apply_limit_to_sql
* all but tests
* added unit tests
* result set
* first draft
* revisions
* made user required prop, added it to all places ResultSet is imported
* changed QueryTable test to allow for useSelector
* Query Table working
* working with heights
* fixed scrolling
* got rid of animated
* fixed tests, revisions
* revisions
* revisions
* heights
* fun with heights
* alert state
* aaron helped me fix this
* better alert messages
* fixed result set test
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* fix: do not render favorite favStar and filter for anonymous user
* fix: prevent anonymous user to trigger the favstar view route
* fix: lint over previous commit
* fix: linter follow-up
* fix: Adding a little margin under the warning about changing datasets
* feat: moves Alert spacing from a css override to an Alert prop
* fix: prop needs to be optional... proptional
* fix: moving the typing to a better spot, adding the new prop to storybook.
* style: linting
* Force refresh the chart on toggle display description
* Use forceUpdate instead of forceRefresh
* Instead of forceUpdate, add a state for desciption height
Co-authored-by: Ajay Mancheery <ajaymancheery@Ajays-MacBook-Pro.local>
* chore(dashboard): Integrate dashboard app into the SPA bundle
* fix url params
* change variable name
* change title correctly
* custom css
* lint
* remove unused file
* remove content assertions from dashboard tests
* fix case with missing bootstrap data
* fix: respect crud views flag
* crud views -> spa
* remove unused dashboard templates
* fix: remove unused variable
* fix: missed a spot with the crudViews -> spa
* router link to dashboard from dashboard list page
* link using the router when in card mode
* lint
* fix tests, add memory router
* remove dashboard app files
* split up the bundle a little more
* use webpack preload
* Add aria-label and twotone
* Enhance LazyIcon
* Fix tests and solve ject warnings
* Add new line
* Revert package-lock to master
* Fix failing test
* Implement icon overrides
* Fix failing storybook
* Clean up
* Improve var name
* fix:fix get permission function
* feat: hide native filters by metadata
* fix: fix show_native_filters name
* fix: metadata
* chore: add migration to hide native_filters in all existing dashboards
* chore: fix pre-commit
* fix: make migration migration dashboard with filter_box only
* fix: pre-commit
* feat: hide filter bar if no permission edit and no filters
* fix: remove migration
Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
* feat(native-filters): add optional sort metric to select filter
* use verbose name when defined
* fixes
* lint
* disable flaky test
* disable flaky test
* disable flaky test
* Implement adhoc filters in Range and Select native filters
* Add time picker
* Remove additional filters from datamask
* Create separate stylesheet for AdhocFilterControl in native filters
* Rename Time picker to Time range
* Fix columns in AdhocFilter empty when creating a new filter
* Skip flaky test
* fix:fix get permission function
* fix: not reload charts after save filters
* fix: not reload charts after save filters
* fix: temp commit type
* lint: add typing
* restyle database modal
* change name of tab to Basic
* update test with RTL better RTL render statement
* change color and position of required asterisk
* refactor db logic
* test: add tests for filter bar
* test: merge filter bar tests with master
* test: add test for filter set
* test: filter set tests
* test: merge with master
* test: fix tests for filter bar
* fix: fix CR notes
* fix: fix CR notes
* chore: type some SQL Lab components
* Update superset-frontend/src/SqlLab/components/QueryHistory.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* add ui for setting report format
* refactor default notification format
* init csv data alert report
* add report format to report_schedule model
* add ALERTS_ATTACH_REPORTS feature flag
* fix lint
* update check image tag
* fix migrations
Co-authored-by: samtfm <sam@preset.io>
* add hook for future async api calls
* test to see conflict
* add async middleware and update reducers
* working async dashboard load
* implement getcharts api
* add user permissions to explore and dashboard bootstrap data
* integrate api calls with getinitial state
* update namings
* accept an id or a slug in the dashboard charts api
* add permissions function
* fix merge
* update state
* get dashboard charts by id or slug
* fix undefined states
* variable names
* stop using some more bootstrap data
* fix metadata reference
* remove unused bootstrap from the template
* add errorboundry to dashboard
* refactoring, fixing
* update permissions
* add just roles
* id is supposed to be a string
* unused vars
* get datasources from api
* make onError optional
* use resource hooks, better error boundary
* add loading state for dashboardroute
* remove console
* add conditional
* more conditionals
* testing out a possible fix for cypress
* convert edit/standalone test to cypress
* remove bootstrappy assertions
* lint
* fix dashboard edit history issue
* rename stuff
* address recent native filters schema change
* remove unused getInitialState
* remove .only from test
* hooksy redux usage
* Revert "more conditionals"
This reverts commit 25c8ed61b4.
* cleanup
* undo unnecessary change
* actually need conditions here
* certainty
* Revert "certainty"
This reverts commit 77dea1915b.
* more permutations (untested yolo)
* Update superset-frontend/src/chart/chartReducer.ts
Co-authored-by: Evan Rusackas <evan@preset.io>
* import style
* comment
* cleaner dashboardInfo
* remove debug code
* use memo for getPermissions
* fix lint
* adjust name/location of DashboardPage
* move logic for REMOVE_SLICE_LEVEL_LABEL_COLORS to DAO
* stop using full_data()
* remove unused (and now useless) json=true query param
Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
* Tests for "nativeFilters/FilterBar/FilterSets/utils"
* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/generateFiltersSetId.test.ts
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Fix: Lint error
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* replace Well componenet with Card component
* Fix lint errors
* Fix lint
* Addressing comments
* Addressing comments
* Fix lint errors
* Exporting Card from index.tsx and adding storybook variants
* Fix some refactoring
* Fix errors
* solving conflicts and lint errors
* Update superset-frontend/src/common/components/Card.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/Card.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Test for Tabs component
* Fix: "creteProps" to "createProps"
* Update superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for Tab component
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* tests for SliceHeader
* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for ShareMenuItems
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DataTablesPane
* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Using factory for props
* replacing "data-test"
* removing "act" from tests and fix error
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* test: prevent flaky unit test case
* Update superset-frontend/spec/javascripts/datasource/ChangeDatasourceModal_spec.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* tests for SliceHeaderControls
* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* fix lint error
* Improving accessibility
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* tests for CrossFilterScopingForm
* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DisplayQueryButton component
* add factories to props and fetch-mock
* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DatasourceControl
* fix: lint error
* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Remove error comment
* replace component data-test
* factory to props
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DataTableControl
* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Prep for migration
* Migration for execution id column
* Generate execution ids for alerts and reports
* Change execution id range
* Add execution id to API endpoint
* Add execution id to execution log view
* Change execution id range
* Change execution id to a uuid
* Fix execution id type
* Switch state and exec. id columns
* Change db column to UUIDType
* Python lint
* Fix failing frontend tests
* execution_id -> uuid
* Fix migration head
* lint
* Use celery task id as the execution id
* lint
* lint for real
* Fix tests
* fix(native-filters): improve loading styles for filter component
* round up fractional grid unit
* fix(native-filters): add support for global async queries
* move form item out of default value component
* move default value hook declaration to form
* delete LoadingBox
* added support to configure the default explorer viz
* code review fix
* lint
Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
* chore(cypress): make the load dashboard test behavior driven
* remove bootstrap usage from controls test, + new utils
* fix save test to not use bootstrap dat
* remove bootstrap usage from the filter test
* fix race condition
* remove bootstrap from url params test
* fix lint
* remove unused const
* add chart specs for the tab test
* attempt removing bootstrap data from tabs tests
* fix cypress async/sync confusion
* remove redundant assertions
* attempt fixing tab test
* attempt fixing tabs test
* cleanup commented code
* better aliases so you can tell what they are in the logs
* remove unused imports
* get the line chart alias before clicking the tab
* simplify getChartGridComponent
* wait for all the charts before force refresh
* fix tabs test
* one more time with the tabs test
* another edit to tabs test
* fix flaky test
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
* Moving DatabaseSelector to a folder
* Tests for DatabaseSelector
* Using factory for props
* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* apply waitFor and remove act
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* separate out api calls
* add new loading states
* remove consoles
* update tests
* fix types and lint
* make code more robust and add test
* address comments
* address comments
* fix lint
* fix(query): properly select adhoc metrics in orderby
* Throw error when sql is empty
* Allow `metrics` to be None
* Always use alias in orderby for metrics
* Bump table chart version and migrate histogram to typescript
* Fix Histogram without groupby
* Fix Presto birth names test
* Raw records mode should not aggregate
* Create a metric immediately when saved metric is dropped
* Display borders around control boxes when metric or column is dragged
* Fix imports
* Display ghost button
* Rename placeholder to ghostButton
* add custom error pages for 404 and 500 responses
* refactor error page styles into separate template
* move error pages to superset-frontend
* fix whitespace on error pages
* refactor error pages to be generated by jinja
* generate static error pages with webpack