mirror of https://github.com/apache/superset.git
refactor: icon to icons for listviewcomponent (#15408)
* initial commit * fix dashboard cypress tests * fix more tests * fix more tests * fix listviews
This commit is contained in:
parent
246368e9dc
commit
7f2f51b2bd
|
@ -22,7 +22,7 @@ describe('chart card view', () => {
|
|||
beforeEach(() => {
|
||||
cy.login();
|
||||
cy.visit(CHART_LIST);
|
||||
cy.get('[data-test="card-view"]').click();
|
||||
cy.get('[aria-label="card-view"]').click();
|
||||
});
|
||||
|
||||
it('should load cards', () => {
|
||||
|
|
|
@ -22,7 +22,7 @@ describe('chart card view filters', () => {
|
|||
beforeEach(() => {
|
||||
cy.login();
|
||||
cy.visit(CHART_LIST);
|
||||
cy.get('[data-test="card-view"]').click();
|
||||
cy.get('[aria-label="card-view"]').click();
|
||||
});
|
||||
|
||||
it('should filter by owners correctly', () => {
|
||||
|
@ -89,7 +89,7 @@ describe('chart list view filters', () => {
|
|||
beforeEach(() => {
|
||||
cy.login();
|
||||
cy.visit(CHART_LIST);
|
||||
cy.get('[data-test="list-view"]').click();
|
||||
cy.get('[aria-label="list-view"]').click();
|
||||
});
|
||||
|
||||
it('should filter by owners correctly', () => {
|
||||
|
|
|
@ -22,7 +22,7 @@ describe('chart list view', () => {
|
|||
beforeEach(() => {
|
||||
cy.login();
|
||||
cy.visit(CHART_LIST);
|
||||
cy.get('[data-test="list-view"]').click();
|
||||
cy.get('[aria-label="list-view"]').click();
|
||||
});
|
||||
|
||||
it('should load rows', () => {
|
||||
|
|
|
@ -22,7 +22,7 @@ describe('Dashboard card view', () => {
|
|||
beforeEach(() => {
|
||||
cy.login();
|
||||
cy.visit(DASHBOARD_LIST);
|
||||
cy.get('[data-test="card-view"]').click();
|
||||
cy.get('[aria-label="card-view"]').click();
|
||||
});
|
||||
|
||||
xit('should load cards', () => {
|
||||
|
|
|
@ -22,7 +22,7 @@ describe('dashboard filters card view', () => {
|
|||
beforeEach(() => {
|
||||
cy.login();
|
||||
cy.visit(DASHBOARD_LIST);
|
||||
cy.get('[data-test="card-view"]').click();
|
||||
cy.get('[aria-label="card-view"]').click();
|
||||
});
|
||||
|
||||
it('should filter by owners correctly', () => {
|
||||
|
@ -73,7 +73,7 @@ describe('dashboard filters list view', () => {
|
|||
beforeEach(() => {
|
||||
cy.login();
|
||||
cy.visit(DASHBOARD_LIST);
|
||||
cy.get('[data-test="list-view"]').click();
|
||||
cy.get('[aria-label="list-view"]').click();
|
||||
});
|
||||
|
||||
it('should filter by owners correctly', () => {
|
||||
|
|
|
@ -22,7 +22,7 @@ describe('dashboard list view', () => {
|
|||
beforeEach(() => {
|
||||
cy.login();
|
||||
cy.visit(DASHBOARD_LIST);
|
||||
cy.get('[data-test="list-view"]').click();
|
||||
cy.get('[aria-label="list-view"]').click();
|
||||
});
|
||||
|
||||
xit('should load rows', () => {
|
||||
|
|
|
@ -23,7 +23,7 @@ import Alert from 'src/components/Alert';
|
|||
import { ReactComponent as EmptyImage } from 'images/empty.svg';
|
||||
import cx from 'classnames';
|
||||
import Button from 'src/components/Button';
|
||||
import Icon from 'src/components/Icon';
|
||||
import Icons from 'src/components/Icons';
|
||||
import IndeterminateCheckbox from 'src/components/IndeterminateCheckbox';
|
||||
import { TableCollection, Pagination } from 'src/components/dataViewCommon';
|
||||
import CardCollection from './CardCollection';
|
||||
|
@ -142,7 +142,7 @@ const ViewModeContainer = styled.div`
|
|||
display: inline-block;
|
||||
border-radius: ${({ theme }) => theme.gridUnit / 2}px;
|
||||
padding: ${({ theme }) => theme.gridUnit}px;
|
||||
padding-bottom: 0;
|
||||
padding-bottom: ${({ theme }) => theme.gridUnit * 0.5}px;
|
||||
|
||||
&:first-of-type {
|
||||
margin-right: ${({ theme }) => theme.gridUnit * 2}px;
|
||||
|
@ -182,7 +182,7 @@ const ViewModeToggle = ({
|
|||
}}
|
||||
className={cx('toggle-button', { active: mode === 'card' })}
|
||||
>
|
||||
<Icon name="card-view" />
|
||||
<Icons.CardView />
|
||||
</div>
|
||||
<div
|
||||
role="button"
|
||||
|
@ -193,7 +193,7 @@ const ViewModeToggle = ({
|
|||
}}
|
||||
className={cx('toggle-button', { active: mode === 'table' })}
|
||||
>
|
||||
<Icon name="list-view" />
|
||||
<Icons.ListView />
|
||||
</div>
|
||||
</ViewModeContainer>
|
||||
);
|
||||
|
|
|
@ -142,7 +142,7 @@ describe('ChartList', () => {
|
|||
});
|
||||
|
||||
it('renders a table view', async () => {
|
||||
wrapper.find('[data-test="list-view"]').first().simulate('click');
|
||||
wrapper.find('[aria-label="list-view"]').first().simulate('click');
|
||||
await waitForComponentToPaint(wrapper);
|
||||
expect(wrapper.find('table')).toExist();
|
||||
});
|
||||
|
|
|
@ -143,7 +143,7 @@ describe('DashboardList', () => {
|
|||
});
|
||||
|
||||
it('renders a table view', async () => {
|
||||
wrapper.find('[data-test="list-view"]').first().simulate('click');
|
||||
wrapper.find('[aria-label="list-view"]').first().simulate('click');
|
||||
await waitForComponentToPaint(wrapper);
|
||||
expect(wrapper.find('table')).toExist();
|
||||
});
|
||||
|
|
Loading…
Reference in New Issue