pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: Removes tabs animation by default (#14496)

This commit is contained in:
Michael S. Molina 2021-05-08 18:22:16 -03:00 committed by GitHub
parent 79ff96269b
commit e7a4734742
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx
View File

@ -131,7 +131,7 @@ describe('DashboardBuilder', () => {
it('should set animated=true on Tabs for perf', () => {
const wrapper = setup({ dashboardLayout: undoableDashboardLayoutWithTabs });
const tabProps = wrapper.find(ParentSize).find(Tabs).props();
expect(tabProps.animated).toBe(true);
expect(tabProps.animated).toEqual({ inkBar: true, tabPane: false });
});
it('should render a TabPane and DashboardGrid for first Tab', () => {

3
superset-frontend/src/components/Tabs/Tabs.tsx
View File

@ -104,7 +104,7 @@ const Tabs = Object.assign(StyledTabs, {
Tabs.defaultProps = {
fullWidth: true,
animated: true,
animated: { inkBar: true, tabPane: false },
};
const StyledEditableTabs = styled(StyledTabs)`
@ -138,6 +138,7 @@ export const EditableTabs = Object.assign(StyledEditableTabs, {
EditableTabs.defaultProps = {
type: 'editable-card',
fullWidth: false,
animated: { inkBar: true, tabPane: false },
};
EditableTabs.TabPane.defaultProps = {