pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: use data-test for testIdAttribute (#13292)

This commit is contained in:
Jesse Yang 2021-02-23 07:43:35 -10:00 committed by GitHub
parent 75677f42bc
commit e4a0233181
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/spec/helpers/setup.ts
View File

@ -21,5 +21,5 @@ import './shim';
import { configure as configureTestingLibrary } from '@testing-library/react';
configureTestingLibrary({
testIdAttribute: 'data-test-id',
testIdAttribute: 'data-test',
});

8
superset-frontend/src/components/ModalTrigger/index.jsx
View File

@ -91,7 +91,7 @@ export default class ModalTrigger extends React.Component {
<>
<Button
className="modal-trigger"
data-test-id="btn-modal-trigger"
data-test="btn-modal-trigger"
tooltip={this.props.tooltip}
onClick={this.open}
>
@ -104,11 +104,7 @@ export default class ModalTrigger extends React.Component {
/* eslint-disable jsx-a11y/interactive-supports-focus */
return (
<>
<span
data-test-id="span-modal-trigger"
onClick={this.open}
role="button"
>
<span data-test="span-modal-trigger" onClick={this.open} role="button">
{this.props.triggerNode}
</span>
{this.renderModal()}