pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-20 04:29:47 -04:00
Code Issues Packages Projects Releases Wiki Activity
8,816 Commits 251 Branches 499 Tags 1.6 GiB
df861706e3
Commit Graph

2357 Commits

Author SHA1 Message Date
Ville Brofeldt
9515ba68dc
chore: bump superset-ui to 0.18.17 (#17310) 2021-11-02 09:13:33 +02:00
Elizabeth Thompson
bea8502ebd
run npm install to fix a bad package version (#17314) 2021-11-01 13:57:28 -07:00
Yongjie Zhao
1f2a7a40c4
fix: datatable crash when column is empty string (#17303) 
* fix: datatable crash when column is empty string

* typo
 2021-11-01 23:58:31 +08:00
jinghua-qa
abf24bbb5d
test: add native filter part2 (#17283) 
* add native filter part2

* fix lint

* remove unused code

* fix lint after modified
 2021-11-01 11:36:47 -03:00
AAfghahi
5948a9fd02
fix(AlertReportModal): Text Area Change (#17176) 
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention
 2021-10-29 15:30:20 -07:00
Hugh A. Miles II
d0bad96b1a
fix: Allow users to update database in Dataset Edit Modal (#17265) 
* add condition to fix save

* remove console.log
 2021-10-29 14:19:37 -07:00
Lyndsi Kay Williams
456efc0c20
fix(reports): Owners no longer showing undefined in reports (#17223) 
* Owners no longer showing undefined

* Reverted owners change

* removed print

* Owners now defined - frontend only solution!

* Remove arbitrary space
 2021-10-29 10:17:47 -07:00
Kamil Gabryjelski
fa44325a36
fix(explore): Metrics disappearing after removing metric from dataset (#17201) 
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls
 2021-10-29 16:15:19 +02:00
jinghua-qa
9ef9adfd78
test: added some sanity test for native filter (#17231) 
* add sanity native filter cypress e2e test

* add liscense

* fix front-end lint

* fix fail

* remove unuse import
 2021-10-29 11:08:18 +08:00
John Bodley
ce558e0764
chore: bump superset-ui to 0.18.17 (#17270) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-10-28 14:44:57 -07:00
Yongjie Zhao
be6cca561d
chore: bump deckgl 0.4.13 (#17266) 2021-10-28 16:24:15 +08:00
Phillip Kelley-Dotson
93f59e055e
chore: remove supersetTheme with withTheme (#17069) 
* remove supersettheme

* migrate Datasourceeditor to rtl

* lint fix

* remove file

* fix import

* fix test

* fix lint

* spread tests and remove unused code

* fix lint
 2021-10-27 12:42:56 -07:00
Ajay M
65f1644208
feat(dashboard): Add description to the native filter (#17025) 
* Adding description works

* Add some tests

* Fix tests

* Styled look good

* Tests successful

* Address PR comments

* fix a test
 2021-10-27 11:45:31 -07:00
Yongjie Zhao
faf7c74e44
chore: bump superset-ui v0.18.16 (#17251) 
* chore: import ES module from chart-controls

* chore: bump superset-ui v0.18.16
 2021-10-27 23:35:48 +08:00
Ville Brofeldt
4316fe6ae6
fix(annotataion): handle required fields properly (#17234) 2021-10-27 08:42:28 +03:00
Ajay M
743f4b6512
Fix resetting does not clear form (#17217) 2021-10-26 19:13:47 -07:00
Michael S. Molina
dd71035e58
chore: Removes the ChartIcon component (#17216) 2021-10-26 09:02:31 -03:00
Yongjie Zhao
dbf5225e1f
chore: bump to superset-ui 0.18.15 (#17232) 
* bump 0.18.15

* prettier and update lock file
 2021-10-26 19:25:34 +08:00
Geido
5f8f67e679
Fix tools position (#17221) 2021-10-26 13:00:33 +03:00
Ben Elgren
3641093a44
allow owners to edit chart title (#17047) 2021-10-26 12:58:07 +03:00
Geido
48fd3c185c
chore: Add docs to the Select component props (#17171) 
* Add docs

* Add overall description

* Remove trailing space
 2021-10-26 12:50:23 +03:00
simcha90
cf284ba3c7
fix(native-filters): Fix update ownState (#17181) 
* fix:fix get permission function

* fix: fix own state update

* refactor: fix CR notes
 2021-10-26 11:39:16 +03:00
Evan Rusackas
ef01cbb625
fix: reenabling terser plugin for webpack (#17205) 
* fix: reenabling terser plugin

* undoing accidental commit inclusion

* prettier ✨

* moving the dots.
 2021-10-25 15:47:09 -06:00
Elizabeth Thompson
08aab3b399
use full results as csv type (#17194) 2021-10-25 09:36:10 -07:00
Michael S. Molina
4c96ae76e3
chore: Breaks the dataViewCommon folder into TableCollection and Pagination (#17132) 2021-10-25 08:47:24 -03:00
Michael S. Molina
55be249870
fix: Order of Select items when unselecting (#17169) 
* fix: Order of Select items when unselecting

* Adds a property comparator that supports strings and numbers

* Uses a named export for propertyComparator
 2021-10-25 08:47:01 -03:00
Shiva Raisinghani
ef3afbde82
refactor: Repeated boilerplate code between upload to database forms (#16756) 
* abstract boilerplate code into class and rename csv to file

* add db migration

* fix some stuff

* more renaming of csv to file

* rename in translations

* update down revision

* update down revision

* bump chart version

* switch to alter column name approach in db migration

* fix db migration for MySQL

* db migration conflict
 2021-10-25 13:53:06 +03:00
Hugh A. Miles II
b5246b29df
feat: Hide nav create with RBAC (#17157) 
* recommit

* Update MenuRight.tsx
 2021-10-23 03:47:56 -04:00
David Aaron Suddjian
a63a01f158
small changes to dashboard->explore code (#17145) 2021-10-22 10:53:01 -07:00
Youkyoung Cha
35cbcc4643
fix: auto refresh interval won't be updated (#17112) 
* fix: auto refresh interval won't be updated

* leave only cirtical changes
 2021-10-22 12:23:46 +03:00
Phillip Kelley-Dotson
824e62bd1f
fix: dropdown placement for cascading filters popover (#17046) 
* inital fix

* remove content wrapper

* allow dropdown to overflow in long chart

* only pass through filtercontrol

* change to auto

* add ref and pass to child

* fix bug

* fix lint

* add type

* remove code

* add currrent param
 2021-10-21 21:25:25 -06:00
Erik Ritter
80a459f43b
feat: support disabling domain sharding with a query param (#17177) 2021-10-21 12:49:59 -07:00
Geido
91199c30d8
Handle undefined (#17183) 2021-10-21 19:34:32 +03:00
Kamil Gabryjelski
860e481a97
fix(explore): timestamp format when copy datatable to clipboard (#17166) 
* fix(explore): timestamp format when copy datatable to clipboard

* Fix test

* Fix test

* Use translation for aria label

* Memoize stringified cells

* Fix test
 2021-10-21 16:05:14 +02:00
Geido
e5a03423f9
chore(Dashboard): Disable save button in Native Filters when an error is present (#17037) 
* Disable save on error

* Remove removed erroredFilter

* Fix cdisabled check
 2021-10-21 16:43:58 +03:00
Hugh A. Miles II
cd9e99402d
feat: Add prettier to pre-commit workflow (#17134) 
* save

* fix

* fix pre-commit
 2021-10-20 20:53:52 -04:00
Geido
f580f6bcba
fix(Explore): Undefined owners (#17167) 
* Reconcile owners data

* Fix on save
 2021-10-20 09:45:58 -06:00
Michael S. Molina
e32acd22fd
chore: Moves the datasource components to the components folder (#17130) 2021-10-20 08:13:24 -03:00
Phillip Kelley-Dotson
4cc095c10a
update ui packages to 18.14 (#17151) 2021-10-19 08:36:58 -07:00
AAfghahi
dacf79719e
remove title from cancel svg (#17147) 2021-10-18 17:03:55 -04:00
Grace Guo
96f4421961
fix: sql lab crash caused by invalid template (#17133) 2021-10-18 11:09:23 -07:00
Elizabeth Thompson
ae4ced8da6
fix: update values for default timezone selector (#17124) 
* update values for default timezone selector

* fix casing and comment

* Update TimezoneSelector.test.tsx
 2021-10-18 09:39:20 -07:00
Kamil Gabryjelski
2ad9101d1e
perf(native-filters): Decrease number of unnecessary rerenders in native filters (#17115) 
* perf(native-filters): decrease number of redundant rerenders

* More perf improvements

* lint fix
 2021-10-18 14:56:52 +02:00
David Aaron Suddjian
57f869cf22
fix(explore): remove unnecessary parameters from the explore url (#17123) 
* remove unnecessary parameters from the explore url

* refactor, test
 2021-10-18 15:30:15 +03:00
simcha90
37944e18d6
feat(Filter-sets): connect to api (#17055) 
* fix:fix get permission function

* feat: filtersets new

* feat: connect filter sets to api

* lint: fix lint

* doc: add comment
 2021-10-17 09:56:54 +03:00
Hugh A. Miles II
40b88f04f6
feat: DBC UI Snowflake Form (#16856) 
* update snowflake spec for dyanmic form

* feat(snowflake): Snowflake dynamic form (#16861)

* snowflake frontend

* snowflake frontend

* refactor(DB Connections): Build Snowflake Dynamic Form (#16875)

* moved all non-BasicParameters into own field

* refactored DB Connection Form made ValidatedInput

* quick fix

* fixed ValidatedInputField (#16934)

* add logic to check for required fields (#17022)

* fix

* fix linting

* remove host

* Update EncryptedField.tsx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
 2021-10-16 20:46:06 -04:00
Ajay M
9e6d5fc775
feat(dashboard): Let users re-arrange native filters (#16154) 
* feat. flag: ON

* refactor filter tabs

* WIP

* Drag and Rearrange, styling

* refactoring dnd code

* Add apache license header

* Fix bug reported during PR review

* Minor fix on remove

* turn off filters

* Fix status

* Fix a test

* Address PR comments

* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* indent

* PR comments

* PR comments

* Fix failing tests

* Styling

* Fix remove filter

* Fix the drag issue

* Save works

* fix

* Write tests

* Style changes

* New Icon

* Grab & Grabbing Cursor

* Commented out code

* Fix tests, fix CI

* Fix failing tests

* Fix test

* Style fixes

* portal nodes dependency

* More style fixes

* PR comments

* add unique ids to collapse panels

* Filter removal bug fixed

* PR comments

* Fix test warnings

* delete filter tabs

* Fix the breaking test

* Fix warnings

* Fix the weird bug on cancel

* refactor

* Fix broken scope
 2021-10-15 16:56:33 -07:00
David Aaron Suddjian
4a9107d7f1
chore: upgrade highlight.js (#17067) 2021-10-15 10:17:45 -07:00
Phillip Kelley-Dotson
98f6edd16a
upgrade to 18.3 (#17121) 2021-10-15 08:51:45 -07:00
Ville Brofeldt
e055e59a19
chore: remove redundant po2json dev dependency (#17129) 2021-10-15 15:25:39 +03:00
simcha90
eebc953dd5
feat: Custom filters control (#17006) 
* fix:fix get permission function

* feat: customize filter control

* fix: fix types

* fix: fix merge

* refactor: update according CR

* refactor: fix CR notes
 2021-10-15 14:14:04 +03:00
wijnanjo
c9c669d179
fix for undefined userId (#17117) 
Co-authored-by: jo.wijnant <jo.wijnant@kontron.com>
 2021-10-15 01:08:57 -07:00
Lyndsi Kay Williams
5253193708
fix: Update package-lock.json of superset-frontend and cypress-base (#17125) 
* Copied changes from original PR, minus package-lock.json files

* Reverted command name change

* Fixing superset-ui and package-lock.json

* superset-ui to 0.18.12

* Update cypress package-lock
 2021-10-14 18:28:56 -07:00
Lyndsi Kay Williams
732e5891e5
test: Cypress 7.0.0 migration (#16911) 
* Copied changes from original PR, minus package-lock.json files

* Reverted command name change

* Fixed package.json in superset-frontend

* Test adjustments
 2021-10-14 17:01:11 -07:00
Lyndsi Kay Williams
635898a76d
fix(sqllab): Hover tooltip flashes in SQL Lab (#17068) 
* Changed SQL Lab result column header-style width to max-content

* Changed .ant-tooltip-open to block and tooltip placement to topLeft

* Moved tooltip style changes to local implementation instead of global
 2021-10-14 16:23:22 -07:00
Yongchan Hong
7a2e39449a
feat(config): Add none force-refresh option for auto refresh (#17039) 
* feat(config): Add none force-refresh option for auto refresh

* use general config

* fix lint issues

* last lint fix
 2021-10-14 21:31:10 +03:00
Kamil Gabryjelski
3ad7483dc1
fix(dashboard): race condition between hydrating dashboard and set active tabs (#17084) 
* fix(dashboard): race condition between hydrating dashboard and set active tabs

* Fix linting

* Change variable name
 2021-10-13 20:18:44 +02:00
Beto Dealmeida
40e9add641
fix: accept headers on import (#17080) 
* fix: accept headers on import

* Add unit test
 2021-10-13 10:06:00 -07:00
John Bodley
b9ff85d9ea
chore(engine): Translate fractional time grains—requires @superset-ui bump (#17078) 
* chore(engine): Translate fractional time grains

* Bump @superset-ui

Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-10-12 21:40:48 -07:00
Hugh A. Miles II
959fd763a8
fix: Owners selection in dataset edit UX (#17063) 
* boilerplate

* update owner select component

* this is working

* update onchange

* refactorig

* you need to useMemo or things break

* update test

* prettier

* move logic into bootstrap data endpoint

* address concerns

* oops

* oops

* fix test
 2021-10-12 20:27:56 -04:00
Erik Ritter
153469dba9
fix: error alert levels again (#17027) 2021-10-11 12:28:36 -07:00
Gabriel Romero
83a783de58
style: Update text for SLL Tooltip (#16993) 
* Updated tooltip text to match Trello task.

* Added graphlib

* Update DatabaseConnectionForm.tsx

Co-authored-by: Gabriel Romero <gabrielromero@Gabriels-MacBook-Pro.local>
 2021-10-11 10:08:52 -07:00
jinghua-qa
f2d41dc416
fix(other): column name in created content on profile page (#17029) 
* fix: fix name in created content on profile page

* add more fix on mutater
 2021-10-11 23:21:05 +08:00
Geido
14b7f6cdba
fix: Exclude SUPERSET_DEFAULT from the list of available color schemes (#17018) 
* Handle SUPERSET_DEFAULT theme

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
 2021-10-11 16:16:06 +03:00
Beto Dealmeida
16a1df75fc
fix: clear modal state after adding dataset (#17044) 
* fix: clear modal state after adding dataset

* Fix test

* Small fixes
 2021-10-10 16:21:14 -07:00
Michael S. Molina
7c1c89c94b
fix: Loading indicator of table and schema selectors (#17040) 2021-10-08 16:17:43 -03:00
Phillip Kelley-Dotson
2c8e06e929
initial fix (#16998) 2021-10-08 10:56:14 -07:00
Phillip Kelley-Dotson
bdbcfbc8fc
fix: show onhover menu only in edit mode (#17034) 
* fix on markdown hover menu

* lint-fix
 2021-10-08 10:54:16 -07:00
AAfghahi
e32a12fa0b
bug fix (#17019) 2021-10-08 10:19:04 -07:00
Geido
a6173f1929
chore(Dashboard): Highlight errored filters on the left pane of the Native Filters form plus several enhancements (#16940) 
* Implement errored filters

* Clean up

* Handle errors on the fly

* Implement handleErroredFilters

* Reset errors
 2021-10-08 17:33:04 +03:00
Geido
a57ae35011
fix: Verify when null value should be undefined in Select (#17013) 
* Check for null value

* Safety chek SelectControl and SelectAsyncControl
 2021-10-08 17:32:09 +03:00
Geido
42efcdf027
chore(Dashboard): Implement dedicated message for missing dataset (#16959) 
* Implement dedicated message

* Clean up
 2021-10-08 17:01:00 +03:00
Erik Ritter
ea700384b3
fix: error alerts again (#17026) 2021-10-07 15:30:56 -07:00
Erik Ritter
03cdbac8bb
fix: error alerts js crash (#17015) 2021-10-07 13:09:54 -07:00
AAfghahi
50ad09bbdc
removing paramProperties (#17024) 2021-10-07 15:28:41 -04:00
Michael S. Molina
be211437de
fix: Filtering db names while creating dataset is not working (#17023) 2021-10-07 16:23:51 -03:00
Michael S. Molina
c471a85170
fix: Unnecessary queries when changing filter values (#16994) 2021-10-07 13:07:33 -03:00
Evan Rusackas
5f73ca85d5
feat(linting): restrict direct use of supersetTheme in favor of ThemeProvider (#17001) 
* feat: restrict direct use of supersetTheme

* allowing a couple of safe instances of supersetTheme
 2021-10-07 08:26:57 -06:00
Geido
66b0877445
Strict undefined check SelectControl (#17008) 2021-10-07 17:22:52 +03:00
Kamil Gabryjelski
45908ff104
fix(dashboard): Race condition when setting activeTabs with nested tabs (#17007) 
* fix(dashboard): Race condition when setting activeTabs with nested tabs

* Remove activeTabs prop from Tabs
 2021-10-07 14:23:26 +02:00
Yongjie Zhao
6cdb324377
chore: bump superset-ui 0.18.10 (#17009) 2021-10-07 19:37:41 +08:00
Geido
a782a62097
chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609) 
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
 2021-10-07 14:20:32 +03:00
jinghua-qa
6dc00b3e3f
fix: letter format of sort chart in dashboard edit (#17003) 2021-10-07 16:29:16 +08:00
Evan Rusackas
ac509611b6
chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor (#16999) 
* chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor

* putting the background back in, but using the theme.

* should be no need for this import anymore.
 2021-10-07 09:46:37 +02:00
Evan Rusackas
66fbce9dec
chore: removing use of supersetTheme in favor of ThemeProvider (#17000) 2021-10-07 10:36:57 +03:00
Lyndsi Kay Williams
90cfa7fb22
fix: FilterableTable result div width (#16912) 
* FilterableTable result div width is now inherit

* Changed style to css
 2021-10-06 13:14:35 -07:00
Hugh A. Miles II
40861b3db3
fix: check if owners are actually being updated in PUT /datasets/<id> (#16941) 
* check if owners are actually being updated

* move logic to FE

* fix

* fix
 2021-10-06 11:26:02 -07:00
Michael S. Molina
191033cb44
chore: Translates the favorite filter param (#16990) 2021-10-06 11:04:14 -03:00
Michael S. Molina
c57719128f
fix: When click on "View all" from favorite tab, get error (#16988) 2021-10-06 08:18:56 -03:00
David Aaron Suddjian
1cd0124fd5
chore: upgrade babel (#16885) 
* upgrade babel versions

* upgrade babel eslint parser

* fix test
 2021-10-05 15:02:57 -07:00
Erik Ritter
2757b93fea
fix: Use production build config for cypress tests (#16978) 
* fix: Use production build config for cypress tests

* set usedExports to global
 2021-10-05 11:13:33 -07:00
Youkyoung Cha
93ebe3d963
fix: handle mixed time-series error (#16928) 
* rebase to master

* Fix line 402

Co-authored-by: yougyoung <yougyoung@pubg.com>
 2021-10-05 16:00:22 +03:00
Elizabeth Thompson
5866d5ebb0
fix: Revert "fix: RBAC hide right menu (#16902)" (#16968) 
* Revert "fix: RBAC hide right menu (#16902)"

This reverts commit 87baac7650.

* fix failing test
 2021-10-04 19:18:12 -07:00
Grace Guo
85e3cec521
chore:upgrade superset-ui dependencies (#16965) 2021-10-04 15:31:36 -07:00
Phillip Kelley-Dotson
50ad84bd03
chore: refactor header menu to show in header grid component (#16689) 
* initial commit

* add delete to markdown
 2021-10-04 15:01:17 -07:00
Ville Brofeldt
739d8418a7
fix(build): make npm linking work pt. 2 (#16958) 
* fix(build): make npm linking work pt. 2

* remove explicit symlinks conf
 2021-10-04 19:47:07 +03:00
Geido
3f0756f637
chore: Select component refactoring - SelectControl - Iteration 5 (#16510) 
* Refactor Select DatasourceEditor

* Fire onChange with allowNewOptions

* Clean up

* Refactor Select in AnnotationLayer

* Handle on clear

* Update tests

* Refactor Select in SpatialControl

* Show search

* Refactor Select in FilterBox

* Remove search where unnecessary

* Update SelectControl - WIP

* Refactor Controls

* Update SelectControl tests

* Clean up

* Test allowNewOptions false

* Use SelectControl AnnotationLayer

* Use SelectControl SpatialControl

* Clean up

* Render custom label

* Show search

* Implement filterOption

* Improve filterOption

* Update Cypress

* Update Cypress table test

* Use value for defaultValue

* Merge with latest changes

* Reconcile with latest Select changes

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Revert changes to test

* Call onPopoverClear when v value is undefined

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
 2021-10-04 18:24:41 +03:00
Michael S. Molina
1ab36c94f3
chore: Moves spec files to the src folder - iteration 7 (#16943) 2021-10-04 10:56:49 -03:00
Michael S. Molina
028f6c0d3f
chore: Moves spec files to the src folder - iteration 6 (#16935) 2021-10-04 10:56:30 -03:00
Yongjie Zhao
6225c9a4a3
fix: replace absolute difference with difference in legacy charts (#16931) 2021-10-02 09:10:20 +08:00
Phillip Kelley-Dotson
3f6a24fe1a
chore: add certified columns to top of list (#16910) 
* initial commit

* inital commit

* add suggestions

* remove changes

* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
 2021-10-01 11:50:03 -07:00
Ville Brofeldt
a07c9d591b
fix(dashboard): recursive parent on dashboard components (#16933) 
* fix(dashboard): don't add recursive parents on wrapper component

* add test

* refine logic and add new test
 2021-10-01 08:13:38 -07:00
Michael S. Molina
90f711f45c
chore: Moves spec files to the src folder - iteration 5 (#16927) 2021-10-01 11:24:41 -03:00
Hugh A. Miles II
87baac7650
fix: RBAC hide right menu (#16902) 
* add provider to right menu

* add roles code

* bad pull
 2021-09-30 14:33:54 -04:00
Michael S. Molina
87290ddcc8
fix: Native filters cyclic dependency (#16921) 2021-09-30 14:55:54 -03:00
Michael S. Molina
c5d23fbcc7
fix: Unable to add dataset (#16925) 2021-09-30 14:52:48 -03:00
Geido
7f330c9692
Verify undefined operatorId (#16923) 2021-09-30 18:53:48 +03:00
Geido
c8db435730
fix(Explore): Clear filter value when changing columns (#16871) 
* Clear filter value onChange

* Clear filter value on user change action
 2021-09-30 17:18:08 +03:00
Michael S. Molina
1a38ec6c43
chore: Adds the drag icon (#16919) 2021-09-30 10:29:12 -03:00
Michael S. Molina
3d520f2cc9
fix: Inclusive sign in time range display (#16906) 
* fix: Time range display to show inclusive range

* Skips flakky test
 2021-09-30 09:57:07 -03:00
Michael S. Molina
ae26967c4e
fix: Disable lazy loading for the Database selector (#16908) 
* fix: Disable lazy loading for the Database selector

* Fixes the tests
 2021-09-30 09:29:27 -03:00
Michael S. Molina
05632b9804
chore: Moves the stylesheets folder to the assets folder (#16880) 
* chore: Moves the stylesheets folder to the assets folder

* Changes {src} to src
 2021-09-30 09:28:38 -03:00
Ville Brofeldt
77e7d162d2
ci: check npm lockfile version (#16916) 2021-09-30 10:43:38 +02:00
Hugh A. Miles II
331de0c4ae
fix: Fix Uniqueness check before update for Sqllab Overwrites (#16859) 
* add condition to make sure columns are available before throwing

* fix

* remove database_id from history changed

* refactor update call to datasets

* cleanup

* oops

* prettier
 2021-09-29 13:38:29 -04:00
AAfghahi
904c506591
fixing db connection (#16899) 2021-09-29 10:02:34 -07:00
Michael S. Molina
4da4fe4136
fix: Removing parent filter causes incorrect state of child filter (#16876) 
* fix: Removing parent filter causes incorrect state of child filter

* removed to isRemoved

* Shows (deleted) when the parent is removed

* Removes unnecessary code
 2021-09-29 13:04:07 -03:00
simcha90
3d8cc15cba
fix: Clear native filters state (#16893) 
* fix:fix get permission function

* fix: clear native filters state
 2021-09-29 13:50:21 +03:00
Michael S. Molina
e3b14fe170
fix: Overhead when changing the filter name (#16877) 2021-09-29 07:37:02 -03:00
AAfghahi
aa747219ad
feat: Add Private Google Sheets to dynamic form (#16628) 
* first pass private gsheets

* made encrypted extra into string, refactored onParametersChanged

* private sheets working, credential_info errors

* all but test connection working

* first pass private gsheets

* made encrypted extra into string, refactored onParametersChanged

* private sheets working, credential_info errors

* all but test connection working

* Regenerate package-lock.json

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-09-28 17:08:50 -07:00
Ville Brofeldt
9ac55d9afa
fix(build): enable hot reloading of linked packages (#16867) 2021-09-28 16:21:17 +02:00
Michael S. Molina
27a40d2a67
chore: Upgrades Storybook to version 6.3.8 to make it compatible with Webpack 5 (#16857) 2021-09-27 14:51:53 -03:00
Geido
d3f6145aba
fix(dashboard): Fill form with the latest values when undo in native filters (#16851) 
* Set undoFormValues

* Reorganize

* Revert check

* Fix and clean up

* Fix pre-filter and sort values
 2021-09-27 09:39:26 -07:00
Geido
667b88c800
chore: Select component refactoring - TimeSeriesColumnControl - Iteration 5 (#16442) 
* Refactor Select

* Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Fix tests

* Mock debounce

* Add debounce

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
 2021-09-27 18:19:03 +03:00
Geido
271ec6ec75
chore: Select component refactoring - SaveModal - Iteration 5 (#16446) 
* Refactor Select

* Fix Cypress

* Reconcile with master

* Use onChange over onSelect

* Reconcile with latest changes

* Update Cypress

* Update Cypress test

* Fix lint
 2021-09-27 18:14:58 +03:00
Geido
ab9f8cb2ea
chore: Select component refactoring - PropertiesModal - Iteration 5 (#16445) 
* Refactor Select

* Update tests and checks

* Clean up props

* Update ariaLabel

* Reconcile with master changes

* Apply enhancements

* Fix lint
 2021-09-27 18:12:59 +03:00
Geido
e40ff3ada6
chore: Select component refactoring - DndColumnSelectControl - Iteration 5 (#16440) 
* Refactor Select

* Update ariaLabel

* Reconcile with latest Select changes

* Fix lint

* Enhance labels
 2021-09-27 17:27:14 +03:00
Geido
913df18075
chore: Select component refactoring - MetricControl - Iteration 5 (#16423) 
* Refactor Select

* Render saved metric option

* Update tests

* Fix Cypress and ariaLabels

* Fix lint

* Lint Cypress

* Reconcile with latest Select changes
 2021-09-27 17:25:51 +03:00
Geido
8ad03c4f25
chore: Select component refactoring - FilterControl - Iteration 5 (#15777) 
* Refactor Select for AdhocFilterEditPopoverSqlTabContent

* Refactor Selects

* Fix numeric options

* Clean up

* Fix Select value

* Add showSearch

* Display null label

* Implement StyledSelect

* Update superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSqlTabContent/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Fix aria-label

* Revert MetricControls changes

* Update ariaLabel

* Reconcile with latest Select changes

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
 2021-09-27 17:23:52 +03:00
Ville Brofeldt
f703c12ae8
chore: bump superset-ui to 0.18.8 (#16850) 2021-09-27 11:54:05 +03:00
Stephen Liu
100760c464
fix(gallery): Hide the bottom info section when no chart is being selected (#16840) 2021-09-27 15:21:25 +08:00
Ville Brofeldt
0a8d0c6e7f
fix(native-filters): emitted filter label format (#16828) 2021-09-27 09:36:55 +03:00
Ville Brofeldt
42fa54881a
fix(native-filters): filter indicator stale state (#16831) 2021-09-27 08:34:39 +03:00
Ville Brofeldt
a3413197de
chore: upgrade to Node 16 (#16809) 
* chore: upgrade to Node 16

* add docs

* fix test
 2021-09-25 07:26:35 +02:00
AAfghahi
04f7ecad1c
display tooltip when disabled (#16837) 2021-09-24 12:56:33 -07:00
Erik Ritter
55e2872dbf
Fix 500 tab title (#16836) 2021-09-24 12:20:00 -07:00
Michael S. Molina
1ff682f3a9
fix: Updates the selected values when changing the native filter type, column or default value (#16833) 2021-09-24 14:07:20 -03:00
Erik Ritter
c933250dad
chore: Remove immutable.js (#16823) 2021-09-23 22:23:42 -07:00
Beto Dealmeida
6921d94861
fix: show Import button only if has perms (#16763) 
* fix: show Import button only if has perms

* Fix tests
 2021-09-23 14:55:21 -07:00
Ville Brofeldt
4086bedb68
chore: bump superset to 0.18.6 (#16807) 2021-09-23 14:03:03 +03:00
Phillip Kelley-Dotson
a198dbb19b
feat: add certifiedby & certification details fields to the edit dataset columns fields (#16454) 
* add migration

* add backend and frontend for certified

* update migration with batch

* fix integration test and update Updating.md

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* change method name

* add tooltip info

* add mixin

* merge heads

* address comments

* fix select label styles

* add extra field

* fix test?

* add extra field to put schema

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
 2021-09-22 15:09:30 -07:00
Lyndsi Kay Williams
63aadd3fe4
test: RTL overhaul - hackathon (#16626) 
* CachedLabel_spec fully converted to RTL

* ColumnTypeLabel_spec fully converted to RTL

* MissingChart_spec fully converted to RTL

* RefreshIntervalModal_spec mostly converted to RTL

* HoverMenu_spec mostly converted to RTL

* ResizableContainer_spec fully converted to RTL

* ResizableHandle_spec fully converted to RTL

* AggregateOption_spec fully converted to RTL

* CheckboxControl_spec fully converted to RTL

* ColorPickerControl_spec to RTL

* Finished converting ColorPickerControl_spec to RTL/TS, also converted RefreshIntervalModal_spec to TS

* Added unknown type to ColumnTypeLabelProps

* Fixed ColumnTypeLabel_spec
 2021-09-22 11:37:35 -07:00
Beto Dealmeida
4af5ae08f9
fix: encode rison characters when searching (#16768) 2021-09-22 10:06:24 -07:00
Michael S. Molina
99d15b25b0
chore: Moves the images folder to the assets folder (#14429) 
* chore: Moves the images folder to the assets folder

* Rebases
 2021-09-22 10:28:51 -03:00
Kamil Gabryjelski
486e0d412c
chore: Upgrade Webpack to v5 (#16701) 
* Upgrade Webpack to v5

* Remove mapbox hack

* Replace url-loaders and file-loaders with asset modules

* Remove 1 rule

* Change --colors to --color

* Remove invalid option (--no-progress)

* Remove url-loader, bump plugin

* Fix AnnotationLayer formula check

* Remove redundant tests

* Bump cypress packages

* Remove old comment

* Fix tests

* Remove checks for number of scripts in markdown test

* Cosmetic changes

* Add tests

* Fix test

* Fix test

* Fixes test warnings

* disable flaky test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
 2021-09-22 14:24:54 +03:00
Michael S. Molina
9b17e86b44
chore: Moves messageToasts to the components folder (#14431) 
* chore: Moves messageToasts to the components folder

* Rebases
 2021-09-22 07:44:54 -03:00
Michael S. Molina
b6d78bf4f2
refactor: Changes the list views to use the new Select component (#16393) 
* chore: Change the list views to use the new Select component

* Fix Cypress tests

* Enables search for all controls

* Adjusts controls width

* Removes 'Me' and keeps the logged user on top

* Fixes tests

* Uses the borderless version for the filters

* Fixes the tests

* Reverts the Select theme to the default

* Rebases and fixes js error

* Fixes failing test

* Removes unused withTheme
 2021-09-22 07:44:18 -03:00
Michael S. Molina
596e1cdf9b
refactor: Changes the DatabaseSelector and TableSelector to use the new Select component (#16483) 2021-09-22 07:43:46 -03:00
Ville Brofeldt
1d5100daa2
fix(dataset): retain is_dttm if set on metadata sync (#16776) 2021-09-22 10:13:49 +03:00
Elizabeth Thompson
d375538671
only fetch db function when db exists in sql lab (#16754) 2021-09-21 09:40:02 -07:00
Elizabeth Thompson
f032cc254c
fix shared query (#16753) 2021-09-21 09:38:23 -07:00
simcha90
985aa06439
chore: Upgrade immer package version (#16741) 
* fix:fix get permission function

* chore: update immer

* chore: update immer
 2021-09-20 09:36:56 +03:00
Yongjie Zhao
67b13308ca
chore: bump superset-ui 0.18.5 (#16725) 2021-09-18 08:06:08 +08:00
Ville Brofeldt
836b5e2c86
feat: add support for generic series limit (#16660) 
* feat: add support for generic series limit

* refine series_columns logic

* update docs

* bump superset-ui

* add note to UPDATING.md

* remove default value for timeseries_limit
 2021-09-16 12:09:08 +03:00
Michael S. Molina
86290cc0e5
chore: Improves the Select component to avoid additional queries when all values have been loaded (#16712) 
* chore: Improves the Select component to avoid additional queries when all values have been loaded

* Handles the logic in handlePaginateFetch and removes the use effect
 2021-09-15 15:39:58 -03:00
Michael S. Molina
adc3d24c21
fix: Ignore case and special keys when searching (#16706) 2021-09-15 07:33:43 -03:00
Stephen Liu
b0ac5d1625
perf(dashboard): fix filter-box performance bug (#16702) 2021-09-15 08:40:46 +03:00
David Aaron Suddjian
540277ebb1
chore: Add option to set a custom color scheme as default (#16540) 
* upgrade superset-ui for new flag

* configurable default categorical scheme

* dry refactor

* doc example

* Update superset-frontend/src/setup/setupColors.ts

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* re-adding # type: ignore (suggestion from ville)

* ugh... missed a space.

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
 2021-09-14 11:09:03 -07:00
Ville Brofeldt
1d890f8913
fix(explore): make clicked dnd filters unique (#16700) 2021-09-14 18:01:21 +03:00
Geido
fecd4124fa
fix: Select refactoring known issues (#16666) 
* Clean up and reorganize effects

* Enhance optionFilterProps

* Render custom label

* Remove prop filtering

* Create options

* Create option from value in single mode

* Change to customLabel

* Show search by default

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Apply minor changes

* Fixes a bug that was failing CI

* Adds more tests to the component

* Apply customLabel in ColorSchemeControl

* Remove customLabel from rendered Option

* Hide No data when allowNewOptions

* Remove unnecessary prop from tests

* Adjust loading height

* Show no data with fetchOnlyOnSearch

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
 2021-09-14 17:39:27 +03:00
Ville Brofeldt
c99cacbdd2
fix(explore): only refresh data panel on relevant changes (#16699) 
* fix(explore): only refresh data panel on relevant changes

* add comment and supress warning
 2021-09-14 15:58:05 +03:00
AAfghahi
376c685838
feat: adding logging to validation (#16527) 
* adding logging to validation

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-09-13 16:09:40 -07:00
cccs-joel
c6ac10716a
feat: show build number value in the About if present in the config (#14955) 2021-09-13 10:59:08 -07:00
Grace Guo
b0b996582c
fix: reset perf logger timer for soft navigation for SPA pages (#16668) 
* fix: reset perf logger timer for soft navigation for SPA pages

* fix comments

* fix extra comments

Co-authored-by: grace_guo <grace_guo@grace-guos-MacBook-Pro.local>
 2021-09-13 10:16:07 -07:00
simcha90
668ae23f28
feat: Tabs in column (#16593) 
* fix:fix get permission function

* feat: add tabs inside column

* lint: fix lint

* test: fix test

* test: fix tests

* test: fix tests

* fix: pass onChangeTab function through layout
 2021-09-13 09:02:29 +03:00
Ajay M
4b70d46355
feat(dashboard): Native filters - add type to native filter configuration (#16549) 
* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* PR comments

* PR comments

* Fix failing tests
 2021-09-09 09:46:44 -07:00
Michael S. Molina
e9e6c5de8a
chore: Writes the tests for the new Select component (#16638) 
* chore: Writes the tests for the new Select component

* Uses array destructuring
 2021-09-09 08:38:33 -03:00
Kamil Gabryjelski
788c0c3dae
fix(dashboard): label colors included in explore url (#16621) 2021-09-08 15:38:02 +02:00
Ville Brofeldt
9dfa33fedf
fix(dnd): make clicked dnd metrics unique (#16632) 2021-09-08 13:21:21 +03:00
Elizabeth Thompson
519baa6f00
fix: params in sql lab are jumpy in the ace editor (#16536) 
* fix jumpy params

* remove cypress tests
 2021-09-07 09:38:45 -07:00
Michael S. Molina
37c2020035
chore: Merges latest Select changes (#16587) 2021-09-07 10:41:55 -03:00
Kamil Gabryjelski
effcf3b50f
perf(dashboard): decrease number of rerenders of FiltersBadge (#16545) 
* perf(dashboard): decrease rerenders in FiltersBadge

* implement caching of dashboard filter indicators

* Implement caching for native filter indicators
 2021-09-07 12:03:43 +02:00
Kamil Gabryjelski
7faa5c6aff
perf(dashboard): reduce rerenders of DragDroppable (#16525) 
* perf(dashboard): reduce rerenders of DragDroppable

* lint fix
 2021-09-07 11:19:07 +02:00
Duy Nguyen Hoang
3fe2e6ec73
Remove export CSV in old filter box (#16592) 2021-09-06 14:40:24 +03:00
Ville Brofeldt
7cbced8833
chore(deps): bump superset-ui to 0.18.2 (#16601) 2021-09-06 12:20:29 +03:00
simcha90
df5c0fbce9
feat: Experimental cross-filter plugins (#16594) 
* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF
 2021-09-06 08:25:14 +03:00
Beto Dealmeida
9bb890ebed
fix: impersonate user label/tooltip (#16573) 2021-09-03 09:42:11 -07:00
Elizabeth Thompson
a0db5367d2
bump emotion to help with cache clobbering (#16559) 2021-09-02 13:48:21 -07:00
Michael S. Molina
02798a3517
fix: Adds a loading message when needed in the Select component (#16531) 2021-09-02 13:17:47 -03:00
Yongjie Zhao
2e11b05d73
chore: bump superset-ui to 0.18.1 (#16563) 2021-09-02 09:03:43 +03:00
Ville Brofeldt
75a1b19174
chore: bump superset-ui to 0.18.0 (#16544) 2021-09-02 13:16:03 +08:00
Yongjie Zhao
80c39daa85
fix: can't drop column when name overlap (#16482) 2021-09-01 13:52:10 +08:00
Geido
f001c44727
Make Modal draggable and resizable (#16447) 2021-08-31 12:46:44 +03:00
Phillip Kelley-Dotson
a616b8785e
make chart rerender on timeseries change (#16411) 2021-08-30 16:43:14 -07:00
Phillip Kelley-Dotson
960d1e4d5d
fix: stop endless loading when dataset no longer exist (#16511) 
* initial fix

* add const

* add translate
 2021-08-30 16:42:02 -07:00
Grace Guo
2199f65373
fix: sql lab refetch button (#16469) 
* fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)

* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments

(cherry picked from commit 408d58f937)

* handle exception caused by invalid query id
 2021-08-30 15:47:00 -07:00
Ville Brofeldt
147637a02d
fix(native-filters): add handle undefined control value gracefully (#16468) 2021-08-27 14:03:05 +03:00
Erik Ritter
8adc31d14c
Revert "chore: Changes the DatabaseSelector to use the new Select component (#16334)" (#16478) 
This reverts commit c768941f2f.
 2021-08-26 22:28:04 -03:00
Jesse Yang
a413f796a6
fix(explore): JS error for creating new metrics from columns (#16477) 2021-08-26 17:04:45 -07:00
AAfghahi
ee2eccdb67
fix: queryEditor bug (#16452) 
* queryEditor bug

* update tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
 2021-08-26 15:20:02 -07:00
Kamil Gabryjelski
f422f1ea49
perf(dashboard): decouple redux props from dashboard components (#16421) 
* perf(dashboard): decouple redux props from dashboard components

* Lint fix

* Dont make copy of filters object

* Remove unnecessary exports
 2021-08-26 21:54:11 +02:00
Kamil Gabryjelski
8ad495a572
perf(dashboard): reduce number of rerenders of Charts (#16444) 
* perf(dashboard): reduce number of rerenders of Charts

* Remove static property

* Cleanup
 2021-08-26 21:53:44 +02:00
Yongjie Zhao
577ede4b12
fix: prevent page crash when chart can't render (#16464) 2021-08-26 22:26:01 +08:00
Ville Brofeldt
1c71eda70f
fix(native-filters): handle null values in value filter (#16460) 
* fix(native-filters): handle null values in value filter

* lint
 2021-08-26 15:26:53 +03:00
Jesse Yang
ec087507e5
refactor(explore): improve typing for Dnd controls (#16362) 2021-08-26 01:23:14 -07:00
Ville Brofeldt
18be181946
fix(explore): update overwrite button on perm change (#16437) 
* fix(explore): update overwrite on perm change

* remove redundant user_id prop

* fix types

* fix user type

* fix tests

* fix lint
 2021-08-26 06:24:33 +03:00
Geido
db11c3e6c8
feat: Draggable and Resizable Modal (#16394) 
* Implement resizable prop

* Implement resizableConfig

* Implement fluid Syntax Highlighter

* Implement draggable

* Destroy on close

* Implement draggableConfig

* Enhance with footer calculation

* Add new line

* Make whole header draggable trigger
 2021-08-25 16:11:16 +03:00
Maxhui
6a2cec51c5
fix(dashboard): undo and redo buttons weird alignment (#16417) 
* fix(dashboard-ui): undo and redo buttons weird alignment

* fix(Explore control pane): keyboard nav & focus

* lint: lint frontend

* fix: fix redo and undo button style

* lint: lint line

* lint: lint line

Co-authored-by: xuzhebin <maxhui2020@gmail.com>
 2021-08-25 08:52:59 -03:00
Grace Guo
08b8aa277f
fix: setupPlugin in chart list page (#16413) 
* fix: setupPlugin in chart list page

* fix the order of setupPlugins call

* Fix jest test on loading geojson

* add jest changes

* fix unit tests

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
 2021-08-24 23:10:46 -07:00
Grace Guo
78d8089b18
fix: Disable Slack notification method if no api token (#16367) 
* feat: allow company choose alert/report notification methods

* fix: disable Slack as notification method if no api token

* fix unit test

* improve typing
 2021-08-24 17:28:50 -07:00
AAfghahi
631ad02a76
fix: copy to Clipboard order (#16299) 
* copy to Clipboard order

* centralized copyToClipboard

* fixed table order

* fixed tests

* added colnames to all viz types

* added colnames to all viz types

* added colnames to all viz types
 2021-08-24 14:47:09 -07:00
Ville Brofeldt
5eded9fe1b
chore(viz): bump superset-ui to 0.17.87 (#16420) 2021-08-24 11:10:23 -07:00
Evan Rusackas
81241b6024
Revert "fix(explore): let admin overwrite slice (#16290)" (#16408) 
This reverts commit d13b081cfe.
 2021-08-24 09:38:41 -06:00
Michael S. Molina
6a5568764e
chore: Removes the TODOs and uses the default page size (#16422) 2021-08-24 11:44:27 -03:00
Michael S. Molina
575e7af859
fix: Show cross filter option only when cross filter is enabled (#16391) 2021-08-24 09:13:39 -03:00
Geido
9a37ad1a1e
fix: Return original document title when leaving a dashboard (#16323) 
* Return original title on unmount

* Name var originalDocumentTitle
 2021-08-24 15:08:13 +03:00
Michael S. Molina
1fc9318594
chore: Changes the AlertReportModal to use the new Select component (#16144) 
* chore: Changes the AlertReportModal to use the new Select component

* Gives time to close the select before changing the type
 2021-08-24 08:19:27 -03:00
Geido
c14364c616
chore: Enhance Omnibar (#16273) 
* Fix style and implement ESC

* Include ESC test case

* Move pagination outside of table

* Update superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Enhance

* Handle close

* Localize placeholder

* Fix tests

* Clear input on close

* Destroy modal on close

* Clean up

* Fix tests

Co-authored-by: Evan Rusackas <evan@preset.io>
 2021-08-24 11:52:07 +03:00
AAfghahi
a6aad52e38
fix: regex for multi-region IPs (#16410) 
* regex for multi-region IPs

* Update index.tsx
 2021-08-23 13:54:25 -07:00
Michael S. Molina
c768941f2f
chore: Changes the DatabaseSelector to use the new Select component (#16334) 2021-08-23 15:41:03 -03:00
Michael S. Molina
0cdc7675b4
chore: Displays the dataset description in a tooltip in the datasets list (#16392) 2021-08-23 15:38:53 -03:00
Phillip Kelley-Dotson
3faf653e5f
initial commit (#16366) 2021-08-20 17:46:55 -06:00
Erik Ritter
a9f502b67b
fix: big number default date format (#16383) 2021-08-20 16:08:54 -07:00
Phillip Kelley-Dotson
c5081991fc
initial commit (#16380) 2021-08-20 16:59:53 -06:00
Lyndsi Kay Williams
518c3c9ae0
test: Functional RTL for email report modal II (#16148) 
* Email Report Modal validation testing

* Starting RTL testing for email report

* Calendar icon now rendering!

* Create report testing in dashboard

* make linter happy

* Fixing weird error

* Removed ExploreChartHeader_spec

* Fixed dashboard header test

* revert changes from merge

* Fix tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
 2021-08-20 10:08:36 -07:00
Ville Brofeldt
575ee24a99
fix: call external metadata endpoint with correct rison object (#16369) 2021-08-20 11:43:57 +03:00
Hugh A. Miles II
50d896f1b7
fix: Fix parsing onSaving reports toast when user hasn't saved chart (#16330) 
* don't maniuplate error message

* remove extra idx reference

* u

* change print

* update with test

* add case for dashboards

* fix test
 2021-08-19 14:04:23 -04:00
Ville Brofeldt
86f4e691d4
chore(viz): bump deckgl plugin to 0.4.11 (#16353) 2021-08-19 19:19:48 +03:00
Geido
c5c28618a5
fix: Blank space in Change dataset modal without warning message (#16324) 
* Make scrollTable flex

* Revert unclosable warning
 2021-08-19 16:46:25 +02:00
Evan Rusackas
42cd21e383
chore: bump superset-ui to v0.17.85 (#16350) 2021-08-19 09:32:24 +03:00
Elizabeth Thompson
efe850b731
adjust initial state (#16329) 2021-08-18 13:18:36 -07:00
Kamil Gabryjelski
a547dcb73e
fix(explore): reordering columns with dnd sometimes glitching (#16322) 
* fix(explore): reordering columns with dnd sometimes glitching

* Fix metrics and filters popover being stale after reordering
 2021-08-18 18:39:05 +02:00
Kamil Gabryjelski
2c595b09ea
chore(explore): make metric/column search input clearable (#16320) 
* chore(explore): make metric/column search input clearable

* Fix typo

* Fix test
 2021-08-18 12:23:23 +02:00
Elizabeth Thompson
4960b5ee2b
pass correct report_format (#16306) 2021-08-17 18:31:38 -07:00
Beto Dealmeida
7a284bb9e8
fix: allow reports to update query_context (#16303) 2021-08-17 16:39:27 -07:00
Grace Guo
b87e0b32ac
refactor: rearrange dashboard page js bundles (#16285) 2021-08-17 16:12:05 -07:00
Beto Dealmeida
3c0aefb61a
Revert "fix: disable text reports for now (#16257)" (#16296) 
This reverts commit ee9a384758.
 2021-08-17 14:21:15 -07:00
Phillip Kelley-Dotson
f581e0402b
change filter (#16280) 2021-08-17 09:37:39 -07:00
AAfghahi
f5fbfef618
timezone editor (#16281) 2021-08-17 09:32:17 -07:00
Kamil Gabryjelski
203c311ca3
feat(explore): make dnd controls clickable (#16119) 
* Make ghost buttons clickable

* Popover for column control

* Make column dnd ghost button clickable

* Prefill operator only if column is defined

* Remove data-tests

* lint fix

* Hide new features behind a feature flag

* Change ghost button texts

* Remove caret for non clickable columns
 2021-08-17 14:56:39 +02:00
Geido
9876c36f6e
Fix table height (#16275) 2021-08-17 09:58:13 +02:00
Ville Brofeldt
d13b081cfe
fix(explore): let admin overwrite slice (#16290) 2021-08-17 10:55:33 +03:00
Ville Brofeldt
2be84e78d2
chore(explore): remove unnecessary favstar redirect (#16288) 2021-08-17 09:09:38 +03:00
Beto Dealmeida
ee9a384758
fix: disable text reports for now (#16257) 
* fix: disable text reports for now

* Update tests
 2021-08-16 08:16:48 -07:00
Michael S. Molina
0668eaad6a
chore: Improves the flow to create a new chart (#16252) 
* chore: Improves the flow to create a new chart

* Adds a comment about selector specificity
 2021-08-16 11:56:47 -03:00
Geido
22231addec
Move pagination outside of table (#16232) 2021-08-16 16:43:49 +02:00
Elizabeth Thompson
3709131089
check roles before fetching reports (#16260) 2021-08-13 20:41:03 -07:00
Phillip Kelley-Dotson
a5dbe6a14d
fix examples tab for dashboard (#16253) 2021-08-13 14:56:32 -07:00
Phillip Kelley-Dotson
f94695480a
chore: bump superset-ui packages to 0.17.84 (#16251) 
* initial bump

* commit pack-lock file
 2021-08-13 13:40:26 -06:00
Michael S. Molina
720e5b111a
chore: Shows the dataset description in the gallery dropdown (#16200) 
* chore: Shows the dataset description in the gallery dropdown

* chore: Adjusts the tooltip positioning, fixes the search and removes unnecessary bootstrap data
 2021-08-13 15:08:12 -03:00
Geido
c09f6ed15b
fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168) 
* Fix style and implement ESC

* Include ESC test case

* Update superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
 2021-08-13 18:44:49 +02:00
Yongjie Zhao
6cd15d54a0
refactor: external metadata fetch API (#16193) 
* refactor: external metadata api

* fix comments

* fix ut

* fix fe lint

* fix UT

* fix UT
 2021-08-13 20:56:42 +08:00
Kamil Gabryjelski
517a678cd7
fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233) 
* fix(dashboard): cross filter chart highlight when filters badge icon pressed

* Fix tests

* Fix tests

* break out label logic

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
 2021-08-13 10:02:28 +02:00
Beto Dealmeida
5d3d6b6eae
fix: validate_parameters and query (#16241) 
* fix: validate_parameters and query

* add onQueryChange
 2021-08-12 18:05:27 -07:00
Evan Rusackas
cdcc161846
fix: Remove Advanced Analytics tag for 2 charts (#16240) 
* removing AA tag from TimeTableChartPlugin

* package bump for echarts (removes AA tag there)

* package-lock bump for new echarts plugin
 2021-08-12 15:32:39 -06:00
AAfghahi
9d0dc561fc
Revert "feat: Changing Dataset names (#16199)" (#16235) 
This reverts commit adb3ebbba3.
 2021-08-12 13:59:44 -07:00
Hugh A. Miles II
171514360e
feat: Allow users to connect via legacy SQLA form (#16201) 
* hugh/dbui-other

* remove extra condition

* add not callable

* Update .pylintrc

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-08-12 15:10:42 -04:00
Geido
a1e18ed110
fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060) 
* Implement dynamic tooltip

* Normalize and consolidate

* Clean up

* Refactor and clean up

* Remove unnecessary var

* Fix type import

* Update superset-frontend/src/explore/components/controls/OptionControls/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove unnecessary styled span

* Show full tooltip title

* Force show tooltip

* Force show tooltip D&D off

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
 2021-08-12 11:48:16 -06:00
Geido
2c5731aea3
Show/hide tooltips (#16192) 2021-08-12 11:42:48 -06:00
Kamil Gabryjelski
a16e290765
fix(explore): conditional formatting value validators (#16230) 
* fix(explore): conditional formatting value validators

* Fix typing, make validator more generic

* Remove commented code
 2021-08-12 14:31:29 +02:00
Phillip Kelley-Dotson
c79de7abd7
initial fix (#16212) 2021-08-11 15:50:50 -07:00