pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(native-filters): filter indicator stale state (#16831)

This commit is contained in:
Ville Brofeldt 2021-09-27 07:34:39 +02:00 committed by GitHub
parent ef95458547
commit 42fa54881a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts
View File

@ -212,7 +212,7 @@ export const selectIndicatorsForChart = (
};
const cachedNativeIndicatorsForChart = {};
let cachedNativeFilterDataForChart: any = {};
const cachedNativeFilterDataForChart: any = {};
const defaultChartConfig = {};
export const selectNativeIndicatorsForChart = (
nativeFilters: Filters,
@ -230,10 +230,10 @@ export const selectNativeIndicatorsForChart = (
cachedNativeIndicatorsForChart[chartId] &&
areObjectsEqual(cachedFilterData?.appliedColumns, appliedColumns) &&
areObjectsEqual(cachedFilterData?.rejectedColumns, rejectedColumns) &&
cachedNativeFilterDataForChart?.nativeFilters === nativeFilters &&
cachedNativeFilterDataForChart?.dashboardLayout === dashboardLayout &&
cachedNativeFilterDataForChart?.chartConfiguration === chartConfiguration &&
cachedNativeFilterDataForChart?.dataMask === dataMask
cachedFilterData?.nativeFilters === nativeFilters &&
cachedFilterData?.dashboardLayout === dashboardLayout &&
cachedFilterData?.chartConfiguration === chartConfiguration &&
cachedFilterData?.dataMask === dataMask
) {
return cachedNativeIndicatorsForChart[chartId];
}
@ -326,14 +326,11 @@ export const selectNativeIndicatorsForChart = (
}
const indicators = crossFilterIndicators.concat(nativeFilterIndicators);
cachedNativeIndicatorsForChart[chartId] = indicators;
cachedNativeFilterDataForChart = {
...cachedNativeFilterDataForChart,
cachedNativeFilterDataForChart[chartId] = {
nativeFilters,
dashboardLayout,
chartConfiguration,
dataMask,
};
cachedNativeFilterDataForChart[chartId] = {
appliedColumns,
rejectedColumns,
};