fix: Filtering db names while creating dataset is not working (#17023)

This commit is contained in:
Michael S. Molina 2021-10-07 16:23:51 -03:00 committed by GitHub
parent 9ef2861fbd
commit be211437de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 10 deletions

View File

@ -251,6 +251,7 @@ export default function DatabaseSelector({
return renderSelectRow(
<Select
ariaLabel={t('Select database or type database name')}
optionFilterProps={['database_name', 'value']}
data-test="select-database"
header={<FormLabel>{t('Database')}</FormLabel>}
lazyLoading={false}

View File

@ -181,6 +181,7 @@ const Select = ({
mode = 'single',
name,
notFoundContent,
onError,
onChange,
onClear,
optionFilterProps = ['label', 'value'],
@ -328,15 +329,18 @@ const Select = ({
setSearchedValue('');
};
const onError = (response: Response) =>
getClientErrorObject(response).then(e => {
const { error } = e;
setError(error);
const internalOnError = useCallback(
(response: Response) =>
getClientErrorObject(response).then(e => {
const { error } = e;
setError(error);
if (props.onError) {
props.onError(error);
}
});
if (onError) {
onError(error);
}
}),
[onError],
);
const handleData = (data: OptionsType) => {
let mergedData: OptionsType = [];
@ -391,13 +395,13 @@ const Select = ({
setAllValuesLoaded(true);
}
})
.catch(onError)
.catch(internalOnError)
.finally(() => {
setIsLoading(false);
setIsTyping(false);
});
},
[allValuesLoaded, fetchOnlyOnSearch, options],
[allValuesLoaded, fetchOnlyOnSearch, internalOnError, options],
);
const handleOnSearch = useMemo(