pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Unable to add dataset (#16925)

This commit is contained in:
Michael S. Molina 2021-09-30 14:52:48 -03:00 committed by GitHub
parent 7f330c9692
commit c5d23fbcc7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/src/views/CRUD/data/dataset/AddDatasetModal.tsx
View File

@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import React, { FunctionComponent, useState } from 'react';
import React, { FunctionComponent, useState, useEffect } from 'react';
import { styled, t } from '@superset-ui/core';
import { useSingleViewResource } from 'src/views/CRUD/hooks';
import { isEmpty, isNil } from 'lodash';
@ -60,9 +60,9 @@ const DatasetModal: FunctionComponent<DatasetModalProps> = ({
addDangerToast,
);
const setSaveButtonState = () => {
useEffect(() => {
setDisableSave(isNil(datasourceId) || isEmpty(currentTableName));
};
}, [currentTableName, datasourceId]);
const onDbChange = (db: {
id: number;
@ -70,17 +70,14 @@ const DatasetModal: FunctionComponent<DatasetModalProps> = ({
backend: string;
}) => {
setDatasourceId(db.id);
setSaveButtonState();
};
const onSchemaChange = (schema?: string) => {
setSchema(schema);
setSaveButtonState();
};
const onTableChange = (tableName: string) => {
setTableName(tableName);
setSaveButtonState();
};
const onSave = () => {