pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(explore): let admin overwrite slice (#16290)

This commit is contained in:
Ville Brofeldt 2021-08-17 10:55:33 +03:00 committed by GitHub
parent 2be84e78d2
commit d13b081cfe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/src/explore/components/PropertiesModal/index.tsx
View File

@ -175,7 +175,7 @@ export default function PropertiesModal({
buttonStyle="primary"
// @ts-ignore
onClick={onSubmit}
disabled={!owners || submitting || !name}
disabled={submitting || !name}
cta
>
{t('Save')}

5
superset/views/core.py
View File

@ -122,6 +122,7 @@ from superset.views.base import (
get_error_msg,
get_user_roles,
handle_api_exception,
is_user_admin,
json_error_response,
json_errors_response,
json_success,
@ -787,7 +788,9 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
# slc perms
slice_add_perm = security_manager.can_access("can_write", "Chart")
slice_overwrite_perm = is_owner(slc, g.user) if slc else False
slice_overwrite_perm = (
is_owner(slc, g.user) or is_user_admin() if slc else False
)
slice_download_perm = security_manager.can_access("can_csv", "Superset")
form_data["datasource"] = str(datasource_id) + "__" + cast(str, datasource_type)