pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(reports): Owners no longer showing undefined in reports (#17223) 

* Owners no longer showing undefined

* Reverted owners change

* removed print

* Owners now defined - frontend only solution!

* Remove arbitrary space
This commit is contained in:
Lyndsi Kay Williams 2021-10-29 12:17:47 -05:00 committed by GitHub
parent 0a660a1a38
commit 456efc0c20
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
View File

@ -524,7 +524,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
contentType === 'dashboard' ? currentAlert?.dashboard?.value : null,
database: currentAlert?.database?.value,
owners: (currentAlert?.owners || []).map(
owner => (owner as MetaObject).value,
owner => (owner as MetaObject).value || owner.id,
),
recipients,
report_format:
@ -972,9 +972,11 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
label: (resource.database as DatabaseObject).database_name,
}
: undefined,
owners: (resource.owners || []).map(owner => ({
value: owner.id,
label: `${(owner as Owner).first_name} ${(owner as Owner).last_name}`,
owners: (alert?.owners || []).map(owner => ({
value: (owner as MetaObject).value || owner.id,
label:
(owner as MetaObject).label ||
`${(owner as Owner).first_name} ${(owner as Owner).last_name}`,
})),
// @ts-ignore: Type not assignable
validator_config_json: