Commit Graph

2000 Commits

Author SHA1 Message Date
David Aaron Suddjian
7330aefeac
feat: deprecate plugins by their metadata (#15882) 2021-07-24 16:52:07 +08:00
John Bodley
4ba17092fa
fix: Ensure SupersetError.extra is always a dict (#15848)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-24 10:19:30 +12:00
Duy Nguyen Hoang
73b436ab9f
fix: Unable to create alerts/report after introduced creation_method (#15760) 2021-07-24 09:36:29 +12:00
Kamil Gabryjelski
d408ff8466
fix(explore): show multi queries results in View query modal and data pane (#15840)
* fix(explore): show multiple queries in View query modal

* show multiple queries result in data pane

* fix tests

* lint fix
2021-07-23 17:04:22 +02:00
Elizabeth Thompson
9c854ff1f1
bump typescript (#15847) 2021-07-22 16:30:25 -07:00
Geido
ebec353351
fix(dashboard): Remove edit from url params when discarding changes (#15709)
* Remove edit from url params

* Change replace to assign
2021-07-22 12:58:43 -07:00
Geido
d4bec135e8
Render value immediately (#15820) 2021-07-22 11:46:01 -07:00
Michael S. Molina
e660de6936
chore: Adds lazy loading to the Select component (#15799) 2021-07-22 15:17:31 -03:00
Phillip Kelley-Dotson
04c0680f6e
feat(homepage): conditionally render viewed tab and move examples to chart and dashboard table (#15792)
* test examples

* fix lint

* more lint

* last test

* add suggestions

* fix lint

* fix wrong localstor

* fix tests

* add suggestions

* Update superset-frontend/src/views/CRUD/types.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* fix lint

* fix default tab

* fix test

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-22 10:41:49 -07:00
Kamil Gabryjelski
5e1c469f42
feat(explore): default aggregate for string/numeric columns when creating metric (#15798)
* feat(explore): default aggregate for string/numeric columns when creating metric

* Fix for editing items with the same label

* Replace componentDidUpdate with getDerivedStateFromProps

* Wrap changes in feature flag
2021-07-22 18:23:10 +02:00
Kamil Gabryjelski
040b94119b
chore: bump superset-ui to 0.17.71 (#15839) 2021-07-22 17:10:45 +02:00
Yongjie Zhao
b9d3338153
fix: dataTablesPane cell render undefine when the dot in metric label (#15817)
* fix: dataTablesPane cell render undefine when the dot in metric label

* fix UT
2021-07-22 22:09:27 +08:00
Michael S. Molina
fdb40350bb
chore: Changes the pagination API of the Select component (#15802) 2021-07-22 07:32:04 -03:00
Beto Dealmeida
211319673f
fix: publish the new example dashboards (#15803)
* fix: publish the new example dashboards

* Fix tests
2021-07-21 17:26:03 -07:00
Geido
fefcea7979
fix(Explore): Cell height and spacing for Data panel (#15821)
* Fix height and spacing

* Remove unnecessary padding
2021-07-21 14:30:55 -07:00
Beto Dealmeida
9a79a5775b
feat: store query context when saving charts (#15824)
* WIP

* Add migration

* Fix tests
2021-07-21 13:54:39 -07:00
Geido
cbd37801a0
Add z-index only on maximize (#15800) 2021-07-20 11:08:50 -06:00
Michael S. Molina
ad773ffe79
chore: Improves the Select component UI/UX - iteration 4 (#15480) 2021-07-20 13:29:42 -03:00
Yongjie Zhao
dd800162c5
chore: bump 0.17.70 (#15795) 2021-07-20 19:32:40 +08:00
Yongjie Zhao
3b7441663c
chore: Add tags to the new viz gallery (#15734)
* chore: add tags to gallery

* fix UT

* fix lint

* redesign tags filter

* chore: change to Highly-used and fix some css

* fix UT

Co-authored-by: stephenLYZ <750188453@qq.com>
2021-07-20 17:59:59 +08:00
Kamil Gabryjelski
9ff2531cd0
fix(dashboard): Add resize handles to right and bottom of component (#15778)
* fix(dashboard): Add resize handles to right and bottom of component

* Fix test
2021-07-20 11:23:37 +02:00
stellalc7
9a14aed152
fix: margin right on warning icon to 8px (#15715)
* changed margin right on warning icon to 8px

* fixed to grid units from pixels
2021-07-19 13:53:24 -07:00
Geido
a7cbcde9bf
fix: Edit physical dataset from the Edit Dataset modal (#15770)
* Remove unnecessary onChange

* Remove confliciting onChange

* Revert unnecessary change

* Enhance and fix tests
2021-07-19 14:39:01 -04:00
Kamil Gabryjelski
239336c3e8
fix(explore): dnd multiple columns doesn't work (#15781) 2021-07-19 20:18:10 +02:00
Hugh A. Miles II
7d0f6ab7f5
fix: Fixing schemas_allowed_for_upload field in database connection UX (#15750) 2021-07-19 12:12:37 -04:00
Geido
45c3ae0bf9
chore: Select component refactoring - ColorSchemeControl - Iteration 5 (#15555)
* Enhance Select

* Transition Select to Antd

* Update test

* Fix Cypress

* Change name to aria-label

* Update Cypress search val

* Test Cypress selection
2021-07-19 00:07:40 -06:00
Geido
5cc4f3c4b9
chore: Select component refactoring - DateFilterControl - Iteration 5 (#15571)
* Transition to Antd for DateFilterLabel

* Enhance styles

* Fix test

* Update superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-19 00:04:07 -06:00
Geido
4e79ffd471
Set label max width (#15710) 2021-07-18 22:10:38 -06:00
Yongjie Zhao
069d5cb6a4
chore: bump superet-ui 0.17.69 (#15767) 2021-07-19 02:00:39 +08:00
Kamil Gabryjelski
4234031cba
feat(explore): UX improvements for drag'n'dropping time column (#15740) 2021-07-19 01:52:34 +08:00
Kamil Gabryjelski
e9383e6d00
chore(explore): Bump plugin-chart-pivot-table (#15742) 2021-07-16 18:22:16 +02:00
Kamil Gabryjelski
71924eb40b
fix(explore): wrong error message in conditional formatting (#15732) 2021-07-16 18:02:12 +02:00
Erik Ritter
fe68e45f52
fix: Reduce js bundle size (#15721) 2021-07-16 07:02:37 -07:00
Kamil Gabryjelski
66c28d653f
fix(explore): DndColumnSelect sometimes not working with multi: false (#15731)
* fix(explore): DndColumnSelect not working with multi: false

* fix values not synchronized when dataset changes
2021-07-16 14:20:13 +02:00
ʈᵃᵢ
0ed97eb696
docs: update dev superset version (#15718) 2021-07-15 20:02:01 -06:00
Phillip Kelley-Dotson
234e3081a5
feat(homepage): move savequeries table and render open conditionally (#15711)
* initial commit

* make collapsable
2021-07-15 16:53:23 -06:00
Geido
625468c56a
Fix style (#15662) 2021-07-15 15:26:00 -07:00
Jesse Yang
e305f2a5f3
perf(dashboard): make loading datasets non-blocking (#15699) 2021-07-15 12:26:26 -07:00
Beto Dealmeida
d908dd6689
chore: better copy for SQL dialog (#15714) 2021-07-15 12:20:47 -07:00
Beto Dealmeida
b489cffb57
fix: no lazy translation on SupersetError (#15669)
* fix: no lazy translation on SupersetError

* Small fixes
2021-07-14 16:54:11 -07:00
gordern
22494b642e
fix: remove form invalid title (#15679) (#15680) 2021-07-14 16:55:47 -06:00
David Aaron Suddjian
985af72ac3
fix(dashboard): Make the View Chart In Explore menu option a link (#15668)
* hey look, it's a real anchor tag!

* get the explore chart url into the link

* add doc comments to the functions

* remove pointless test

* update weird tests

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-07-14 15:12:20 -06:00
Phillip Kelley-Dotson
5d86b8dde6
refactor: remove old Icon component (#15690)
* remove old Icon component

* remove mock fn's
2021-07-14 14:04:56 -07:00
Phillip Kelley-Dotson
070f0b6cb2
refactor: icon to icons for IconButton and Header component (#15647)
* initial commit

* fix test

* last one

* fix cypress

* remove gridunit for fonsize

* fix cypress

* more data-test removal

* last one

* more data-test
2021-07-14 11:04:21 -07:00
Michael S. Molina
ac01d91c28
fix: Show affected filters when interacting with the filters (#15634) 2021-07-14 15:01:15 -03:00
Michael S. Molina
154f460446
chore: Removes unnecessary uses of preselectNativeFilters (#15688) 2021-07-14 14:53:00 -03:00
ʈᵃᵢ
de17acd618
feat(menu): expand support for custom branding (#15628) 2021-07-14 10:51:53 -06:00
Geido
a1793f304e
fix(dashboard): Filters panel height (#15661)
* Fix container height

* Add min height vh

* Remove offset when standalone

* Clean up
2021-07-14 16:06:17 +02:00
Phillip Kelley-Dotson
1483e04381
refactor: icon to icons for Querytable, datasource test, and copyclipboard story (#15665)
* initial commit

* fix theme

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-13 14:24:59 -07:00
Michael S. Molina
e6bbca3f61
chore: Preserve native filters selection after refresh (#15583) 2021-07-13 15:14:18 -03:00
Peter Kosztolanyi
02032ee8a4
feat: cancel db query on stop (#15403)
* feat: cancel db query on stop

* fix pylint

* Add unit tests

* Do not bind multiple times

* Stop only running queries

* Postgres to cancel only the required query

* Remove extra log

* Add docstring

* Better types, docstring and naming

* Use python3 format strings

* Update superset/sql_lab.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Add cancel_query_on_windows_unload option to database

* Return cancel_query as bool

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-13 12:09:22 -04:00
Kamil Gabryjelski
a914e3c1cb
feat(explore): Implement conditional formatting component (#15651)
* feat(explore): Implement conditional formatting

* Improved validation

* Fix undefined error

* Refactor after code review

* Add licenses

* Remove redundant div

* Remove formatters when corresponding column is removed
2021-07-13 18:05:16 +02:00
Phillip Kelley-Dotson
8efd94a14f
refactor: icon to icons for navbar (#15643)
* initial commit

* remove code
2021-07-13 08:31:12 -07:00
Michael S. Molina
f0c0d7492c
chore: Reverts reset form in native filters (#15644) 2021-07-13 08:38:32 -03:00
Evan Rusackas
52ad779a27
fix: safe removal of tab with filters still scoped to a non-existing chart (#15650) 2021-07-12 23:43:53 -06:00
Hugh A. Miles II
2dc8bd6c30
fix: Fix test connection for extra fields (#15645)
* create serialize json function

* remove console.log

* use function
2021-07-12 20:19:45 -07:00
Yongjie Zhao
517f8c0a7a
chore: bump superset-ui/plugin-chart-echarts 0.17.65 (#15633)
* chore: bump echart 0.17.65

* npm lock file
2021-07-13 09:48:42 +08:00
Hugh A. Miles II
2252f3396c
fix: Remove default values for engine and schemas (#15635)
* remove default values

* don't set initial value on save

* set defaults for engine_params

* update with JSON.parse
2021-07-12 15:37:44 -07:00
Phillip Kelley-Dotson
34542db3b6
refactor: icon to icons for syntaxhighlighter and querylist components (#15618)
* initial commit

* make changes

* more simplify

* remove code

* add prop

* remove unsued code
2021-07-12 11:35:26 -07:00
David Aaron Suddjian
257385e888
feat(explore): Upgraded viz select gallery (#15303)
* add modal layout with description, rework styles

* thirty percent

* test correctly

* avoid any changes in modal height

* typescriptify

* feat(viz): add categories to the viz picker (#15304)

* feat(viz): add categories to the viz picker

* fix test types

* add a catch-all category

* tweak layout

* upgrade superset-ui to get new metadata

* do i look like i know what a jpeg is

* fix tests

* lint

* remove script count test requirement

* fix e2e test

* feat(explore): Viz picker search improvements (#15399)

* upgrade superset-ui, install fuse.js

* add metadata to plugin context

* get search working

* layout improvements

* fix tests

* Update superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* use typography size instead of grid unit

* comments

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* feat(explore): Examples image gallery in the viz type control (#15489)

* feat(explore): add section for example images in viz type control

* fix jpg webpack config

* formatting

* feat(Explore): Viz gallery component tweaks (#15520)

* separate viz gallery from the modal

* use gallery directly in add slice view

* more formatting on the add slice container

* restyle the thumbnail list

* explicit thumbnail width and height

* remove crappy hack

* remove useless line

* comment

* sort categories

* comments

* tweak search behavior

* fix tests

* open gallery to the currently selected viz type

* null safety

* show all plugins when searching empty string

* get the new metadatas

* adjust categories scrolling behavior

* add time series table metadata

* upgrade superset-ui

* attempt fixing tests

* upgrade descriptions

* fix unit test

* attempt fixing e2e again

* max width for viz gallery

* update package lock

* undo unnecessary webpack changes

* don't show search results until something is entered

* force modal to open to selected viz type

* tweaks to search behavior

* gallery layout tweaks

* enshrine pivot table v2 in a place of honor

* feat(viz): Clear viz gallery when navigating between categories (#15577)

* start viz gallery with null selection, clear when switching categories

* fix AddSliceContainer tests

* show a message when there is no viz type selected

* composition > inheritance

* clarify searching code

* comment

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-12 10:59:10 -07:00
Phillip Kelley-Dotson
d8a15e60b9
refactor: icon to icons for sqllab (#15593)
* initial commit

* rid of theme

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-12 10:24:16 -07:00
Phillip Kelley-Dotson
79d3d06c8a
refactor: icon to icons for homepage and card compompents (#15624)
* initial commit

* add listviewcard

* remove plural
2021-07-12 10:23:45 -07:00
Beto Dealmeida
5d86ffe768
fix: duplicate DB names (#15614) 2021-07-12 09:36:46 -07:00
simcha90
d70ac21054
fix(native-filters): Fix required filters (#15572)
* fix:fix get permission function

* fix: filters required state

* fix: fix CR notes

* fix: removre required message

* fix: fix validation state
2021-07-12 08:55:11 -03:00
aspedrosa
7ec6bdff7c
fix: avoid fetching favorite status for anonymous user (#15590)
* avoid fetching favorite status for anonymous user

* add test + fix types

* fix lint errors
2021-07-09 15:52:16 -07:00
AAfghahi
2ebba519c9
clears errors when closing out of modal (#15623) 2021-07-09 14:15:16 -07:00
AAfghahi
faf6fcd83e
fix: Database List Sorted (#15619)
* sorted the database list

* revisions

* cloned the array

* one more time with feeling

* added documentation link as well
2021-07-09 13:06:17 -07:00
Phillip Kelley-Dotson
600473ff72
refactor: icon to icons for toasts component (#15579)
* initial commit

* remove code

* fix test

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/messageToasts/components/Toast.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-09 10:50:48 -07:00
Lyndsi Kay Williams
b5fc03f964
fix: Database Connection Modal - corrected tooltip alignment and info alert width (#15612)
* Added margins to info alerts

* Tooltips aligned
2021-07-09 10:01:16 -07:00
Phillip Kelley-Dotson
cc765b51c7
refactor: icon to icons for annotations & css templates modals (#15611)
* inital commit

* add css templates
2021-07-09 09:48:01 -07:00
Phillip Kelley-Dotson
abc18b13d0
initial commit (#15597) 2021-07-09 09:45:07 -07:00
Andrew Bastian
ee8b1ed15a
chore: update dataset count badge and tash icon sizing (#15608)
* update trash icon size

* changed badge icon `height` to `16px` (using `gridUnits` and centered text inside via `line-height`

* changed badge icon `height` to `16px` (using `gridUnits`), centered text inside via `line-height`, alignedItems inside div w/flex
2021-07-09 07:33:25 -07:00
Yongjie Zhao
367d47bec5
chore: bumping superset-ui 0.17.64 (#15615)
* chore: bumping superset-ui 0.17.64

* fix jest
2021-07-09 18:29:57 +08:00
Yaozong Liu
7e9674a8fa
refactor(annotation): improve annotation modal (#15359) 2021-07-09 13:14:06 +08:00
Yaozong Liu
1d572ca92b
fix(dashboard-list): change name of dashboard is not reflected instantly (#15186)
* fix: change name of dashboard is not reflected instantly

* fix: id

* fix: update info

* fix: add changed_on_delta_humanized
2021-07-09 11:28:33 +08:00
Phillip Kelley-Dotson
2be52c0659
refactor: icon to icons for controls (#15568)
* initial commit

* Update DateFilterLabel.tsx
2021-07-08 17:32:42 -06:00
Evan Rusackas
026eefdb36
Revert "Open in _self (#14778)" (#15588)
This reverts commit faae27bd2f.
2021-07-08 16:00:35 -07:00
Phillip Kelley-Dotson
4ab565ca36
refactor: icon to icons for sliceheader component (#15567)
* initial commit

* put back code
2021-07-08 14:24:43 -07:00
Evan Rusackas
4685d86d63
fix: Revert "chore: Bump @svgr/webpack to 5.5.0" (#15589)
* Revert "chore: bump @svgr/webpack to 5.5.0 (#15349)"

This reverts commit 53aa35177a.

* refreshing package-lock after rebasing
2021-07-08 14:23:59 -06:00
AAfghahi
ad85e7be52
added isEditMode (#15594) 2021-07-08 13:00:21 -07:00
Hugh A. Miles II
e539d08074
fix: DBC UI tooltip aligment (#15595) 2021-07-08 12:26:38 -07:00
Phillip Kelley-Dotson
86a59a2927
initial fix (#15581) 2021-07-08 07:41:03 -03:00
Phillip Kelley-Dotson
abd999bd6b
refactor: icon to icons for filterbadge components (#15557)
* initial commit

* fix test
2021-07-08 11:53:35 +08:00
Phillip Kelley-Dotson
58cda8f8d6
refactor: icon to icons for nativeFilter components (#15528)
* initial commit for cascade filters

* migrate delete icon

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* add uniform style for icons

* fix lint

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2021-07-07 14:13:44 -07:00
Phillip Kelley-Dotson
cd4f97926c
initial commit (#15551) 2021-07-07 10:20:40 -07:00
Phillip Kelley-Dotson
29dd0844bf
refactor: icon to icons for headeractionsdropdown (#15560)
* initial commit

* fix test

* fix cypress

* fix markdown cypress test
2021-07-07 10:20:15 -07:00
Geido
314d49c13b
Enhance Select (#15550) 2021-07-06 13:07:33 -03:00
Phillip Kelley-Dotson
07852c3528
refactor: icon to icons for popoversection (#15461) 2021-07-05 16:00:37 +08:00
David Aaron Suddjian
83d50dd9fd
chore: add metadata for filter box plugin (#15521)
* chore: add metadata for filter box plugin

* Update superset-frontend/src/visualizations/FilterBox/FilterBoxChartPlugin.js
2021-07-05 14:01:33 +08:00
Phillip Kelley-Dotson
fb322b5bab
refactor: migrate to icons for searchinput icons (#15533)
* initial commit

* fix test

* fix lint
2021-07-05 13:59:56 +08:00
gordern
b20293d1b1
fix: click card view link to 404 page when card rendering(#15526) 2021-07-05 13:55:41 +08:00
simcha90
2cb13e695e
fix(native-filters): Fix native filters config modal (#15506)
* fix:fix get permission function

* fix: native filters

* fix: remove unneccesary space fo filters / fix some crashes
2021-07-04 11:26:59 +03:00
Lyndsi Kay Williams
68704a595b
fix: Database connection R6 fixes (#15486)
* split db modal file

* split db modal file

* hook up available databases

* add comment

* split db modal file

* hook up available databases

* use new validation component

* first draft

* use new validation component

* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* get tests passing

* Removed logo from test

* split db modal file

* hook up available databases

* use new validation component

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* saving for now

* revisions

* fix package-lock.json

* update styles

* save

* # This is a combination of 6 commits.
# This is the 1st commit message:

feat: validation db modal (#14832)

* split db modal file

* hook up available databases

* use new validation component
# This is the commit message #2:

feat: Icon Button (#14818)

* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
# This is the commit message #3:

chore: Improves the native filters UI/UX - iteration 6 (#14932)


# This is the commit message #4:

fix: is_temporal should overwrite is_dttm (#14894)

* fix: is_temporal should overwrite is_dttm

* move up
# This is the commit message #5:

fix: time parser truncate to first day of year/month (#14945)


# This is the commit message #6:

hook up available databases

* fix test for db modal

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* more revisions

* create 1 function for setting the DB

* add function to preferred section

* small refactor and added styling

* used db.backend

* add new footer buttons

* add finsh buttong

* refactor db modal render

* fix comments issue

* added engine to model

* elizabeth revisions

* add header

* add bottom footer to sqlalchemy form

* # This is a combination of 6 commits.
# This is the 1st commit message:

feat: validation db modal (#14832)

* split db modal file

* hook up available databases

* use new validation component
# This is the commit message #2:

feat: Icon Button (#14818)

* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
# This is the commit message #3:

chore: Improves the native filters UI/UX - iteration 6 (#14932)


# This is the commit message #4:

fix: is_temporal should overwrite is_dttm (#14894)

* fix: is_temporal should overwrite is_dttm

* move up
# This is the commit message #5:

fix: time parser truncate to first day of year/month (#14945)


# This is the commit message #6:

hook up available databases

* fix test for db modal

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* elizabeth revisions

* add back headers

* add step

* feat: Dynamic Form for edit DB Modal (#14845)

* split db modal file

* split db modal file

* hook up available databases

* add comment

* split db modal file

* hook up available databases

* use new validation component

* first draft

* use new validation component

* get tests passing

* split db modal file

* hook up available databases

* use new validation component

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* revisions

* fix package-lock.json

* # This is a combination of 6 commits.
# This is the 1st commit message:

feat: validation db modal (#14832)

* split db modal file

* hook up available databases

* use new validation component
# This is the commit message #2:

feat: Icon Button (#14818)

* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
# This is the commit message #3:

chore: Improves the native filters UI/UX - iteration 6 (#14932)


# This is the commit message #4:

fix: is_temporal should overwrite is_dttm (#14894)

* fix: is_temporal should overwrite is_dttm

* move up
# This is the commit message #5:

fix: time parser truncate to first day of year/month (#14945)


# This is the commit message #6:

hook up available databases

* fix test for db modal

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* more revisions

* used db.backend

* added engine to model

* elizabeth revisions

* elizabeth revisions

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: hughhhh <hughmil3s@gmail.com>

* address comments

* oops

* # This is a combination of 6 commits.
# This is the 1st commit message:

feat: validation db modal (#14832)

* split db modal file

* hook up available databases

* use new validation component
# This is the commit message #2:

feat: Icon Button (#14818)

* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
# This is the commit message #3:

chore: Improves the native filters UI/UX - iteration 6 (#14932)


# This is the commit message #4:

fix: is_temporal should overwrite is_dttm (#14894)

* fix: is_temporal should overwrite is_dttm

* move up
# This is the commit message #5:

fix: time parser truncate to first day of year/month (#14945)


# This is the commit message #6:

hook up available databases

* fix test for db modal

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* remove merge conflicts

* small fix on blocking creating

* feat(db-connection-ui): Big Query Add Database Form (#14829)

* fix(native-filters): Manage default value of filters by superset (#14785)

* fix:fix get permission function

* feat: manage default value in superset

* fix(native-filters): loop bug by simplify state handling (#14788)

* fix: set table name width to not hide icons when name is too long (#14489)

* fix: set table name width to now hide icons when name is too long

* fix: table style

Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>

* feat(explore): Remove default for time range filter and Metrics (#14661)

* feat(explore): Remove default for time range filter and Metrics

* Merge errors with same messages

* Fix e2e test

* Rename a variable

* Bump packages

* Fix unit tests

* feat: chart gallery search improvement (#14484)

* feat: chart gallery search improvement

* test: adding unit test for VizTypeControl

* fix: lint errors

Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>

* Update schemas.py

* Update bigquery.py

* Fix tests

* big query form is appearing on the screen

* add name to allow for actions to get picked up

* working post for saving db via paste

* working file upload

* switch to textare

* better styles

* add delete buttong

* save formating

* wrap encrypted_extra

* formatting component

* clear out file input before reloading

* remove default driver

* address comments

* fix things off rebase

* small refactore

* more patches

* checkout space file

* fix variable ref

Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Einat Bertenthal <einatbar@users.noreply.github.com>
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* feat: adding SSL Toggle to Create Database Modal (#14976)

* first draft of SSL Toggle

* added payload data

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* changed tooltips based on stephen advice

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>

* feat(database-connection-ui) Allow configuration of Database Images from SupersetText (#15023)

* saving this for now

* fix some styles

* add database images

* fix

* enforce only numbers

* add default iamge

* fix bug

* additional params to the DatabaseConnectionForm (#15071)

* additional params to the DatabaseConnectionForm

* save passing params up to api

* feat: Added Steps and centralized Headers (#15041)

* fix superset_text issue (#15095)

* fix edit issue by returning parameters properly (#15101)

* feat: added alerts (#15103)

* added alerts

* revisions

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>

* fix: fixing api tests for database connections (#15124)

* fixing api tests

* added test for no config method on create

* added config method to validation tests

* fix(db-connection-ui): Additional Query Parameters render (#15150)

* working query params

* move condition out before update or create

* fix type script issues

* feat(db-connection-ui): Move fields from Extra section and split engine and metadata (#15143)

* working edit extra options

* acquired most of json

* recontruct json

* add schema array

* add proper styles

* fix tslint issues

* remove console.log

* this is working

* style: Database connect UI Polish - Step 1 (#15119)

* save avg

* Styled step 1

* Remove Alert

* Finished styling, added ellipsis library to IconButton

* Fixed text margin

Co-authored-by: hughhhh <hughmil3s@gmail.com>

* fix app from merge

* fix tslint issues

* fix all tslint issue on feature branch

* catch errors for dialects with no driver set

* fix dremio issue

* fix dialect issue without driver attr

* Styled step 3 (#15187)

* feat: adding server-side validation and unmasked password on create (#15151)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* validation and password masking

* revisions and validation range

* revisions

* added beto revisions

* added tests for port range

* added config to available

* testing, rtl

* made tests always pass

* feat: add Close/Finish buttons to DBModal on Edit (#15199)

* fix(db-connection-ui): Allow Dynamic Big Query Edits (#15185)

* working big query edits

* fix big stoping users from moving to next step

* fix default

* save defaults

* fix tslint

* remove object

* fix styling

* fix: Connect on DB Connection wasn't working (#15201)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* fixed the connect button

* make available alphabetically sort

* make available alphabetically sort II

* fix selection

* remove console.log

* fix styling

* fix: fix api_test and typeScript error (#15202)

* fix big query issue

* allow for query params

* feat: Added Dynamic form link to SQL Alchemy Form (#15208)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* added dynamic form link

* fix: fix api tests for test_available (#15210)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* fixes api tests

* feat: added Spinner to DB Modal (#15229)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* Made header sticky (#15204)

* fix: make Edit DB modal look similar to create Modal (#15231)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* changed edit

* fix: DB Connection UI R2 Fixes (#15232)

* fix display name refill

* fix order of additional params to always be at the bottom

* remove schema check on validation

* make encryption last

* fix json file upload

* fix additional params issue

* remove comments

* add back validation

* small fixes on bigquery edit

* only wrap encrypted with bigquery

* specific conditions for wrapping big query items

* dix additional params

* fix allow display name in sqlalchemy form

* backend before engine

* fix: do not use Marshmallow validation in partial params validation (#15236)

* fix: do not use Marshmallow validation in partial params validation

* Fix lint

* Update test

* make display name required

* reset validation errors onClose (#15243)

* fix: Edit for all dynamic forms (#15244)

* fix edit for dynamic forms

* fix linting

* fix edit on sqlalchemy forms

* fix big query reference

* remove extra if

* wrap configuration method (#15274)

* add more specific engine elastic search (#15287)

* do a deep copy of obj before POST (#15298)

* feat: add Back button to extra options (#15300)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* first draft

* working

* added back button to create modal

* revisions and testing

* chore: Add tooltips and button to Connect Postgresql DB Modal Form (#15179)

* Added tooltips. Still need to place in the right spot.

* Revert to where I started.

* Added 3 tooltips, 1 Button(need link config). BigQuery not added yet.

* Added tooltip BigOuery modal. `span` above upload btn missing `*`

* Added tooltip to `Host` field. Alignment needs to be fixed.

* Stuck trying to add conditional render of tooltip to LabeledErrorBoundInput

* Clean commit for review

* Dynamic tooltip componet created. Needs alignment of SVG still.

* Fixed typo.

* Added line spacing back in

* Changed required props to optional/Remove comment

* Fixed alignment of tooltips & moved 2tooltips outside of Btn

* Added one more line space back in

* Removed Typo

* Removed another typo

* Flixed linter error

* Created test for tooltip.

* Added expectation for visible tooltipIcon

Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>

* style: Database Modal UI Polish (#15234)

* Corrected polishing tasks from Clubhouse ticket

* More UI polish

* Added more polish

* Moved encryption field and created constant value for viewBox in InfoToolTip

* feat: allow editing (#15308)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* elizabeth fixed the edit issue

* feat: Added error alert for DB connection Modal  (#15242)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* added errorAlert

* added revisions

* current work

* revisions

* fix: validation on edit (#15310)

* fix: Big Query Error messaging (#15334)

* remove validation check

* remove validation check

* fix error messaging

* stop validation on big query

* add condition for skipping specific engines for validation

* if no params

* update styles

* feat: big Query using back button (#15338)

* fix: password errors on validation (#15372)

* filter out password supply for validation

* filter password

* feat: updated Error Alert (#15377)

* Updated styling (#15379)

* fix password error filter

* feat: Arash/password field error (#15388)

* fix: Back Button on Create for DB conncetion (#15389)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* fixing backButton on Create

* fix doc (#15393)

* style: Database Connection Modal UI Polish R5 (#15412)

* Fixed inconsistent header spacing in step 1

* Touched up tooltips

* Added red *s to BigQuery form

* Centered modal window

* make alerts configurable (#15404)

* fix: Allow users to override database connection docs (#15434)

* allow users to override docs

* fix linting issue

* fix: Error Icon not showing up on  errored input fieds on validation (#15431)

* Fixed now-show error icon

Signed-off-by: andrewbastian <andrew.bastian@gmail.com>

* Changed `%` to `px`

* Fixed lint error

* Changed units to `theme.gridUnit`

* test: RTL testing on DatabaseModal (#15394)

* RTL testing on DatabaseModal

* Continued RTL testing on DatabaseModal

* Code cleanup

* Removed a comment that missed my radar

* test: Add e2e testing (#15376)

* create boilerplate for cypress test

* added 1 more test

* add more test cases

* saving this for development

* lit

* remove name

* update pass

* remove unused test

* fix merge conflicts

* Fixed "connetion" typo (#15458)

* fix: Database connection modal touch up (#15463)

* Removed unnecessary TODO and named the remaining ones

* Added translation functionality

* Fixed typo in Database Modal RTL test

* Update modal.test.ts

* fix: Showing errors for SQLA forms (#15462)

* fix documentation links

* fix sqlalchemy onCreate

* Fixing SQLA error messaging

* fix logic for extra save

* fix this issue

* fix: Update Invalid Port SIP-40 Reference (#15464)

* Fixed jumpy header text

* fix: Edit Modal not saving properly (#15468)

* Aligned info icons on dynamic form

* fix: merge conflict (#15479)

* chore: simplify errors and issue codes (#15437)

* Fix issue number

* Fix test

* Fixed line-height in header, also fixed translation functions in BigQuery

* Updated placeholder text in additional params field

* Fixed padding in edit form

* Corrected placeholder text in BigQuery > Service Account field

* Make linter happy

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Arash <arash.afghahi@gmail.com>
Co-authored-by: hughhhh <hughmil3s@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Einat Bertenthal <einatbar@users.noreply.github.com>
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Andrew Bastian <50464395+andrewbastian@users.noreply.github.com>
Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>
2021-07-02 12:19:26 -05:00
Phillip Kelley-Dotson
ea2a98fcc2
refactor: icon to icons for popovercomponent (#15451)
* initial commit

* fix test

* lint

* align icon

* remove consoles
2021-07-02 08:07:06 -07:00
Ville Brofeldt
ee2ee48661
feat(cross-filters): add option to clear set cross filters (#15500)
* feat(cross-filters): add option to clear set cross filters

* lint

* fix indicator size, remove bolded text and rephrase text
2021-07-02 17:04:05 +03:00
John Bodley
99fe9c5657
fix: Utilizing dashboard native filter feature flag (#15519)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-02 14:49:04 +03:00
Yaozong Liu
81633e99ae
refactor(dashboard): [chart-maximize-mode]put chart full-size state in redux (#15384)
* refactor(dashboard): [chart-maximize-mode]put full-size status to redux

* fix: ci
2021-07-02 13:11:00 +03:00
Beto Dealmeida
cbc4aa8dc1
feat: extra table metadata for Google Sheets (#14775)
* feat: GSheets extra table metadata

* Bump version
2021-07-01 19:27:26 -07:00
Hugh A. Miles II
d4480f5c9a
feat: Database Connection UI (#14881) 2021-07-01 14:40:27 -07:00
Phillip Kelley-Dotson
7f2f51b2bd
refactor: icon to icons for listviewcomponent (#15408)
* initial commit

* fix dashboard cypress tests

* fix more tests

* fix more tests

* fix listviews
2021-07-01 12:36:16 -06:00
Yaozong Liu
246368e9dc
fix(sqllab): add new tab when add sql query (#15492) 2021-07-01 12:32:15 -06:00
Phillip Kelley-Dotson
7889564250
refactor: icon to icons for infotooltip component (#15398)
* intital commit

* align label texts and icons

* fix style
2021-07-01 08:52:17 -07:00
Mironov Danil
665459fbca
feat(native-filters): add null option to value filter (#15419)
* fix: add null var to native filter (#15291)

* small fix

* refactoring code

* restructure the JS code

* update testcase
2021-07-01 16:06:10 +03:00
Kamil Gabryjelski
0ff3253afd
fix(native-filters): chartsInScope were not recalculated in some cases (#15498)
* fix(native-filters): chartsInScope were not recalculated in some cases

* Small refactor
2021-07-01 14:47:14 +02:00
Ville Brofeldt
f286647140
chore(native-filters): remove instant filtering option (#15365)
* chore(native-filters): remove instant filtering option

* fix test
2021-07-01 13:38:56 +03:00
Einat Bertenthal
e5d4765986
feat(dashboard-groupby): group by - add ability to exclude columns (#15454)
* feat: group by - add ability to exclude columns

* fix: create column select in a more generic way

* fix: MR comments

* fix: remove description

* fix: multiple value bug in column select

* fix: initial value bug

* fix: lint

* fix: unit tests

* fix: MR comments

* fix: MR comment

Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
2021-07-01 13:28:07 +03:00
Beto Dealmeida
e606477ec1
feat: more SIP-40 errors (#15482) 2021-06-30 16:32:59 -07:00
Abhishek Jog
cad5ba828c
documentation changes for netezza (#15475) 2021-06-30 10:58:33 -04:00
simcha90
5f96e63bbb
fix(native-filters): Fix clear all button (#15438)
* fix:fix get permission function

* fix: "clear all" async flow

* lint: fix lint

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* lint: fix lint

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-06-30 14:59:04 +03:00
Phillip Kelley-Dotson
ebb3efce5a
initial commit (#15466) 2021-06-30 03:32:57 -07:00
Beto Dealmeida
149c5fd594
feat: add more SIP-40 errors to SQL Lab (#15436) 2021-06-29 18:17:16 -07:00
AAfghahi
743d9cc928
feat: Better Errors in SQL Lab (#15432)
* snowflake errors

* added big query

* added to setup error messages, first test

* all big query testing added

* added snowflake test

* added syntax error

* added syntax errors to most used databases
2021-06-29 16:48:27 -07:00
Kamil Gabryjelski
4a394cd6fb
fix(dashboard): native filters highlight with multiple tabs jumps to first tab (#15455) 2021-06-29 20:26:55 +03:00
Ville Brofeldt
4630abb5a8
feat(native-filters): add support for preselect filters (#15427)
* feat(native-filters): add support for sharing preselected filters

* abc

* add serialization
2021-06-29 18:57:49 +03:00
Ville Brofeldt
dd407331a6
fix(native-filters): filter type check when using experimental flag (#15446) 2021-06-29 15:04:39 +03:00
Kamil Gabryjelski
f109da479d
perf(dashboard): Improve perf of highlighting charts in scope of active filter (#15424)
* perf(dashboard): Improve perf of highlighting charts in scope of active filter

* More optimizations

* fix tests

* Fix lint

* bug fix
2021-06-29 12:55:53 +02:00
Sonya Smirnova
fa6b25d257
fix(explore): switch to correct scheme registry for custom sequential color schemes (#15314)
* Switch to correct scheme registry for custom sequential color schemes

* Linting
2021-06-29 11:43:42 +03:00
krsnik93
b8f4e7d093
fix: add dashboard markdown id (#15418)
Co-authored-by: root <root@src4.ikrsnik.devonly.net>
2021-06-29 11:42:28 +03:00
Geido
faae27bd2f
Open in _self (#14778) 2021-06-29 11:38:00 +03:00
Phillip Kelley-Dotson
076f774daf
refactor: icon to icons for lastupdated component (#15401)
* intial commit

* fix test

* Update superset-frontend/src/components/LastUpdated/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-06-29 00:32:54 -07:00
Phillip Kelley-Dotson
a0179ac513
refactor: icon to icons for inderteminatecheckbox icon (#15397)
* initial commit

* fix cypress tests

* Update superset-frontend/src/components/IndeterminateCheckbox/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-06-29 00:32:17 -07:00
Beto Dealmeida
21d1fb55c6
feat: more error messages (#15409) 2021-06-28 14:51:31 -07:00
Michael S. Molina
e713912fdf
chore: Uses mixed case for native filters headers (#15433) 2021-06-28 17:09:31 -03:00
Michael S. Molina
0b7e524f02
fix: Select item when allowNewOptions is true and the Enter is pressed (#15429) 2021-06-28 15:29:58 -03:00
Michael S. Molina
ac18c90da2
fix: Cascading filter popover widens automatically (#15390) 2021-06-28 20:03:14 +03:00
Grace Guo
1c4cb28e91
fix: double click slq lab table cell (#15400) 2021-06-28 17:05:46 +03:00
Marek Šuppa
93447d1903
Update Header.jsx (#13467)
* Fix typo in the warning that gets displayed with the `positionJSON` is too large/long.
2021-06-28 17:02:41 +03:00
Ville Brofeldt
ddcf461749
fix(native-filters): show human readable time grain label in indicator (#15411)
* fix(native-filters): show human readable time grain label in indicator

* lint

* simplify
2021-06-28 13:35:14 +03:00
cccs-RyanS
b9b903f8e6
feat: Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown) (#15153)
* Adding a show all button to the column/metrics list in the explore view

* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx

Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx

Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com>

* Fixing typo

Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com>
2021-06-27 23:16:53 +03:00
Kamil Gabryjelski
09c44d05fd
feat(native-filters): Hide non-numeric columns in numeric range filter (#15385)
* feat(native-filters): Hide non-numeric columns in numeric range filter

* Return true if type_generic undefined

* Code review comments

* Replace any with string

* fix tests

* add missing columns to select

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-06-27 07:35:17 +03:00
Phillip Kelley-Dotson
f3f018423a
initial commit (#15392) 2021-06-25 14:48:03 -07:00
Michael S. Molina
bdb9b0a9be
chore: Rewrites dashboard IconButton component (#14174) 2021-06-25 15:15:20 -03:00
Michael S. Molina
1e8fb8b55c
chore: Migrates ControlHeader icons (#15265) 2021-06-25 15:12:42 -03:00
Michael S. Molina
a7e103765a
chore: Improves the Select component UI/UX - iteration 3 (#15363) 2021-06-25 11:01:39 -06:00
Phillip Kelley-Dotson
95b9e2e185
refactor: icon to icons for favestar component (#15371)
* initial commit

* initial commit

* fix cypress test

* fix favstar cypress test

* fix card view

* fix other card view
2021-06-25 09:48:22 -07:00
Phillip Kelley-Dotson
9330c6ed0d
initial commit (#15380) 2021-06-25 09:46:26 -07:00
Michael S. Molina
819118be13
fix: Enlarged select filter value (#15373)
* fix: Enlarged select filter value

* fix: Makes the label take the whole width

* fix: Moves the required icon before the cascade icon

* fix: Fixes the cascading icon overlap with big texts
2021-06-25 13:33:12 -03:00
Kamil Gabryjelski
53aa35177a
chore: bump @svgr/webpack to 5.5.0 (#15349) 2021-06-24 23:33:59 -06:00
Phillip Kelley-Dotson
a3f4e4ad9e
refactor: icon to icons in erroralert component (#15341)
* initial commit

* initial commit

* lint
2021-06-24 18:05:22 -07:00
Phillip Kelley-Dotson
a477505291
refactor: icon to icons for basicerror componenet (#15336)
* initial commit

* initial commit

* fix test

* lint fix

* Update superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* lint

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-06-24 09:37:13 -07:00
stellalc7
680b447bc4
style(sqllab): update table count styling (#15200)
* Change text style and opacity

* Edit changes to text style and opacity for table length

* Edit changes to text style and opacity
2021-06-24 08:04:04 -07:00
Beto Dealmeida
241ee32f56
feat: custom error SQL Lab timeout (#15342)
* feat: custom error SQL Lab timeout

* Update test
2021-06-24 08:02:49 -07:00
Ville Brofeldt
b3cdff4995
fix(native-filters): show default text on filter scoping tree (#15351) 2021-06-24 11:01:24 +03:00
Kamil Gabryjelski
f0b64190b5
feat(native-filters): Set default scope by filters' and charts' datasets (#15302)
* feat(native-filters): Set default scope by filter's and charts datasets

* Fix undefined error

* Use JSON.stringify in dependency array

* Fix lint issue

* Lock scope after switching radio buttons

* Fix weird eslint issue

* Change prop names

* Implement useComponentDidUpdate

* Fix lint

* Refactor useComponentDidUpdate

* Remove screen.debug()
2021-06-24 09:23:35 +02:00
Ajay M
352656a398
Fix issue #15335 (#15339) 2021-06-24 10:09:15 +08:00
Phillip Kelley-Dotson
e1ceb7f7cc
refactor: Icon to icons for certifiedIcon (#15306)
* initial commit

* updated css

* fix lint
2021-06-23 14:49:17 -06:00
Erik Ritter
7a1223ca7d
Revert "build(webpack): use [contenthash] instead of [chunkhash] (#14942)" (#15285)
This reverts commit 821519fcfa.
2021-06-23 09:41:19 -07:00
Phillip Kelley-Dotson
f35ce394bf
refactor: migrate icon to icons in tablecollection (#15309)
* initial commit

* fix flaky test

* remove line
2021-06-23 09:40:06 -07:00
Beto Dealmeida
4b00c152cc
feat: implement specific errors for SQL Lab (#15206)
* RESULTS_BACKEND_NOT_CONFIGURED_ERROR

* DML_NOT_ALLOWED_ERROR

* INVALID_CxAS_QUERY_ERROR

* Fix lint

* Add more tests
2021-06-23 07:58:20 -07:00
Kamil Gabryjelski
b89ee0cb38
fix(native-filters): Assume that temporal columns exist if column_types is undefined (#15324)
* fix(native-filters): Assume that temporal columns exist if column_types is undefined

* Allow column_types to be an empty array
2021-06-23 12:09:58 +02:00
Kamil Gabryjelski
6324490dd3
fix(dashboard): Close FiltersBadge popover on window resize (#15305) 2021-06-23 10:14:41 +02:00
Yaozong Liu
f31d573561
feat(editable-title): move and scroll to the end (#15270) 2021-06-23 08:01:14 +03:00
Phillip Kelley-Dotson
c211f7df8e
refactor: icon to icons in DatasourceEditor (#15240)
* intial commit

* lint

* fix test

* fix lint

* remove console.

* Removing pixel placement override.

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-06-22 15:07:09 -07:00
Michael S. Molina
fc1a62b78c
chore: Improves the Select component UI/UX - iteration 2 (#15235) 2021-06-22 16:04:01 -03:00
Grace Guo
5b2eb8d933
Revert "fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)" (#15301)
This reverts commit 408d58f937.
2021-06-22 11:08:29 -07:00
Ben Reinhart
ab153e66cc
feat: Synchronously return cached charts (#15157)
* feat: Synchronously return cached charts

* Fix lint issue

* Fix python lint error

* Change getChartDataRequest to return response

* Fix lint errors

* Add test

* explore_json: skip cached data check for forced refresh

Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
2021-06-22 10:00:57 -07:00
Ville Brofeldt
cef3dc0b02
fix(native-filters): improve time range filter performance (#15295)
* fix time range default value

* defer time filter rendering to inView event

* avoid double fetching of time ranges

* lint

* move set to resolved promise
2021-06-22 14:38:16 +03:00
simcha90
048609d120
feat(native-filters): Show/Highlight errored/focused status (#15276)
* fix:fix get permission function

* feat: show error status for required filters

* test: fix tests

* refactor: fix CR notes
2021-06-22 14:25:08 +03:00
Ville Brofeldt
b28d7eace3
fix(native-filters): default value checkbox in config modal (#15257)
* fix(native-filters): default value checkbox in config modal

* disable checkbox if required

* simplify styling logic

* make default value mandatory if checked

* address comments
2021-06-21 15:58:30 +03:00
Matan Borenkraout
14598d4d5d
chore: add dry false config to CleanWebpackPlugin (#14691) 2021-06-21 10:21:45 +03:00
Phillip Kelley-Dotson
cee403212b
initail commit (#15261) 2021-06-19 19:06:10 -07:00
Andrew Bastian
2cf99467fc
chore: Add height/width TrashIcon SVG(18px/18px)-Edit Dataset modal (#14956)
* Add min-height/width TrashIcon SVG(18px/18px)-Edit Dataset modal

* Reworked styling to be inline on SVG component via CSS from `emotion`

* Changed parameter from `css` to 'style'

* Fixed lint error.

* Changed `style` back to `css`

Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>
2021-06-18 08:50:11 -07:00
Kamil Gabryjelski
c7c63751e9
feat(native-filters): Hide time filters if loaded datasets don't have temporal columns (#15225)
* feat(native-filters): Hide time filters if loaded datasets don't have temporal columns

* Remove "px" suffixes to fix warnings

* Disable an option instead of hiding filter types

* Fix tests

* Add 2 more tests
2021-06-17 16:51:11 +02:00
Michael S. Molina
ea8507b4e2
fix: Filter bar not occupying 100% height when filter sets FF unset (#15228) 2021-06-17 16:38:14 +03:00
simcha90
388eb01f06
feat(native-filters): Disable Apply button if filter required (#15222)
* fix:fix get permission function

* fix: fix select first value by clear all

* lint: fix lint

* feat: disable select on missed value

* fix: refactor ff

* feat: connect nulls for line chart

* lint: fix lint

* docs: fix message

* fix: fix CR comments

* fix: fix Collapsed items

* fix: fix Collapsed items
2021-06-17 16:35:33 +03:00
Ville Brofeldt
7237324983
chore: bump superset-ui to 0.17.58 (#15220) 2021-06-17 11:21:27 +03:00
simcha90
fe5381dcb8
fix(native-filters): Fix Select Default First Value by clicked Clear All (#15219)
* fix:fix get permission function

* fix: fix select first value by clear all

* lint: fix lint
2021-06-17 11:14:21 +03:00
Yaozong Liu
e5187a479a
fix(dashboard): fix nested tab (#15134) 2021-06-16 23:31:52 -06:00
Phillip Kelley-Dotson
cb10427b1e
fix dataset select list (#15203) 2021-06-16 21:56:40 -06:00
Grace Guo
408d58f937
fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)
* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments
2021-06-16 16:57:31 -07:00
Phillip Kelley-Dotson
ca89292faa
refactor: refactor Icon to Icons in sqlEditor component (#14463)
* add triangle-down

* lint fix

* add suggestions
2021-06-16 14:14:36 -06:00
Beto Dealmeida
d625f5f111
feat: show rich error messages on past failed queries (#15158)
* feat: store SIP-40 error payload with queries

* Set errors in query on load
2021-06-16 12:58:14 -07:00
Yaozong Liu
e689b0d445
fix(dashboard): duplicated toast (#15138) 2021-06-16 21:44:37 +03:00
Geido
d578ae9897
feat: Select component (Iteration 1) (#15121)
* Implement initial structure

* Add aria-label

* Rename files

* Refactor single mode new options

* Clean up

* Add select at every corner in storybook

* Clean up

* Add pagination

* Move selected options at the top

* Clean up

* Add license

* Refactor

* Improve pagination

* Fetch when allowNewOptions

* Clean up
2021-06-16 11:05:58 -06:00
Michael S. Molina
dafaaaeb28
chore: Changes the dashboard highlight color when selecting a filter (#15192) 2021-06-16 15:45:31 +02:00
Michael S. Molina
fc8ad4f984
chore: Makes the refresh button only appear when the filter has a dataset (#15194) 2021-06-16 16:07:23 +03:00
Michael S. Molina
4289929745
chore: Allows the user to force fetch the default values (#15178) 2021-06-16 14:17:34 +03:00
Michael S. Molina
0c22266041
chore: Improves the native filters bar layout (#15115) 2021-06-16 14:17:14 +03:00
Phillip Kelley-Dotson
d30f3c8149
fix space (#15175) 2021-06-15 16:16:59 -07:00
Corbin Robb
b179863e25
refactor: Convert TableElement to TypeScript (#14978)
* Convert TableElement to typescript

* Change type names to better match naming conventions in other files

* Fix import order and update tests on TableElement

* Remove defaultProps

* Destructure the props

* Use Rest and Spread syntax to condense props destructuring

* Fix TypeScript errors and add comment to explain antd props and types weirdness

* Remove comment, add consistency with other files, and use method chaining to make more concise

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-06-15 13:29:45 -07:00
Elizabeth Thompson
7dc0cee5be
add another wait for chart element (#15108) 2021-06-15 10:00:36 -07:00
Kamil Gabryjelski
5316dc89a8
fix(dashboard): Prevent rerendering View Query modal on window resize (#15172)
* fix(dashboard): Prevent rerendering View Query modal on window resize

* Fix lint
2021-06-15 13:16:31 +02:00
Matan Borenkraout
53225e8d17
refactor(explore): remove side effect in render from CalendarFrame for DatePicker (#15147) 2021-06-15 13:26:42 +03:00
Ville Brofeldt
9c3c3fa125
feat(native-filters): add optional time col to time range (#15117) 2021-06-15 13:25:28 +03:00
Kamil Gabryjelski
9ba2983f42
chore: Bump plugin-chart-pivot-table to 0.17.57 (#15168)
* chore: Bump plugin-chart-pivot-table to 0.17.57

* Bump other superset-ui packages to 0.17.56

* Fix package-lock
2021-06-15 12:02:40 +02:00
Michael S. Molina
b3c197903c
chore: Scrolls top when opening a select filter (#15141) 2021-06-15 10:10:23 +02:00
ʈᵃᵢ
98ec365374
feat(webpack): configure publicPath via ASSET_BASE_URL env var (#15105) 2021-06-14 18:55:58 -06:00
Phillip Kelley-Dotson
e2abf59534
feat(Explore): add sort to edit dataset modal (#14872)
* inital commit

* refac

* fix ui issues and sort

* fix lint

* add suggestions

* lint

* add suggestions

* add enum

* add enum to inter
2021-06-14 15:20:22 -07:00
Ajay M
045fa1bc7a
feat(dashboard): Let users download full CSV of a table (#15046)
* - Convert SliceHeader to TSX in progress
- Add menu option to download full CSV. Probably will change it

* Add Download Full CSV feature, and tests

* Added more tests, more TS fixes

* Added feature flag

* Update @superset-ui package versions

* Update @superset-ui packages versions

* use backend config instead of hardcoding number of rows

* Update tests

* front end test fix

* Lint fixes and test fixes
2021-06-14 14:26:18 -07:00
Michael S. Molina
82ad053e50
fix: Filter overlay in dashboard when scrolling (#15140) 2021-06-14 15:34:36 +02:00
Kamil Gabryjelski
3866044938
fix(native-filters): Don't send unnecessary PUT request on dashboard render (#15146)
* fix(native-filters): Don't send unnecessary PUT request on dashboard render

* Run native filters scopes only if feature flag is enabled

* Change action name

* Run native filters scopes only if at least 1 filter added

* Fix lint
2021-06-14 14:33:59 +02:00
gordern
57035c1b93
fix: improve dashboard fullscreen text (#15139) 2021-06-14 17:54:37 +08:00
Yaozong Liu
856a2bd5ed
fix(explore): fix y-axis lower bound 0 value (#15091) 2021-06-13 11:24:39 +08:00
Phillip Kelley-Dotson
8e6a5a6f52
chore: Homepage cleanup (#14823)
* initial commit

* update welcome

* fix lint

* add enum

* more choring

* fix lint

* redo logic for api stick api calls

* fix test

* fix chart test

* lint fix and remove unused code

* fix flicker and add suggestions

* lint

* fix test

* add suggestions

* add suggestions and fix test

* revert packagelock

* fix space
2021-06-11 18:47:42 -07:00
Beto Dealmeida
53df152362
feat: show spinner on exports (#15107)
* feat: show spinner on exports

* Set cookie only if token is passed

* Use iframe

* Small fixes

* Fix lint

* Remove stale test

* Add explicit type
2021-06-11 17:25:00 -07:00
Kamil Gabryjelski
ff2d5888d9
feat(native-filters): Defer loading filters data until filter is visible (#15120)
* feat(native-filters): Defer running query until native filter is in view

* Fix default values not displaying
2021-06-11 11:10:16 -07:00
Kamil Gabryjelski
51f0d4fd98
feat(native-filters): Hide filters which don't affect any visible charts (#15063)
* feat(native-filters): Hide filters which don't affect any visible charts

* Fix lint errors

* Add comments

* Code review fix

* Fix tests

* Refactor logic in FilterControls
2021-06-11 13:41:08 +02:00
Ville Brofeldt
5e825cf063
fix(native-filters): handle descending sorting correctly (#15112) 2021-06-11 11:44:16 +03:00
Kamil Gabryjelski
3456dd571c
fix(native-filters): fix Select filter crashing when changing filter type (#15090) 2021-06-10 18:11:31 -06:00
Ajay M
f8b270d419
fix(explore): Explore page boolean filter is broken for Presto DB (#14952)
* Front end update - modify OPERATORS, to have SQL operation and display value

* Updated tests

* More tests

* Remove OPERATOR imports

* Fix break tests

* PR comments

* fix issue with comparator loading

* rename a variable

* Linting
2021-06-10 09:08:04 -07:00
Ville Brofeldt
c0eff8faf6
fix(native-filters): empty label indicator (#15084) 2021-06-10 16:56:55 +03:00
Ville Brofeldt
6c9f15a6e4
fix(native-filters): show error if default value query failed (#15005)
* fix(native-filters): show error if query failed

* address comments
2021-06-10 16:56:31 +03:00
Michael S. Molina
1468026883
chore: Improves the native filters UI/UX - iteration 7 (#15017) 2021-06-10 15:24:00 +03:00
Ville Brofeldt
8aaa6036d7
fix(native-filters): remove hard-coded default time range (#15015)
* fix(native-filters): use default for time range from explore

* fix tests
2021-06-10 14:49:37 +03:00
Ville Brofeldt
65714cc201
fix(dnd): add isExtra prop to Option (#15080) 2021-06-10 12:13:20 +03:00
Yongjie Zhao
834bb9409d
fix(datasets): consistent dataset list (#15014) 2021-06-10 10:05:33 +08:00
Erik Ritter
e8414dfb52
fix: disappearing tooltips on dashboards (#15073) 2021-06-09 18:41:40 -07:00
Beto Dealmeida
4d24d4dc9a
fix: confirm overwrite and password on import (#15056)
* fix: confirm overwrite and password on import

* Add tests
2021-06-09 18:05:31 -07:00
Beto Dealmeida
1db92cc13a
feat: spinner for imports (#15055)
* Update tests

* feat: spinner for imports

* Use loading button instead

* Small fixes

* Small fix
2021-06-09 16:14:49 -07:00
AAfghahi
2d3f552b51
adding fetching to query status (#15064) 2021-06-09 16:11:49 -07:00
Beto Dealmeida
256e1452fe
feat: style import button (#15057)
* feat: style import button

* Update tests

* Update test
2021-06-09 15:40:53 -07:00
Elizabeth Thompson
0c470feaef
move metric parsing to state instantiation (#15069) 2021-06-09 14:54:25 -07:00
ʈᵃᵢ
821519fcfa
build(webpack): use [contenthash] instead of [chunkhash] (#14942) 2021-06-09 13:59:17 -06:00
Beto Dealmeida
3f527c7a45
fix: font regression in SQL Lab (#14960)
* fix: font regression in SQL Lab

* Fix tests
2021-06-08 15:52:57 -07:00
Lyndsi Kay Williams
6cc179b7bf
close icon aligned (#14870) 2021-06-08 13:10:13 -04:00
Lyndsi Kay Williams
94c86c3837
Centered down-arrow icons in top navbar (#14846) 2021-06-08 13:09:35 -04:00
Michael S. Molina
1af91ed756
fix: Adds left padding to dashboard edit mode when filter bar is closed (#15024) 2021-06-08 15:58:15 +03:00
Ville Brofeldt
efd7007701
fix(native-filters): show overridden chart name on scoping tree (#15038) 2021-06-08 14:55:11 +03:00
Kamil Gabryjelski
0e07a5ca03
fix(explore): Datepicker glitch on hover outside the modal (#15033) 2021-06-08 07:46:09 +02:00
Geido
a1ca0b2e6b
Add ming-height to empty tab (#14878) 2021-06-07 22:55:16 -06:00
Geido
12fcb3132c
Remove nowrap (#14954) 2021-06-07 22:50:05 -06:00
Elizabeth Thompson
21aa3daae3
display all metric results in editor (#15031) 2021-06-07 19:12:56 -07:00
David Aaron Suddjian
cf15fe0d03
fix(dashboard): custom css should be removed on unmount (#15025)
* fix(dashboard): custom css should be removed on unmount

* better comment

* remove unnecessary typecast

* move type to top level scope
2021-06-07 14:04:56 -07:00
Ville Brofeldt
422c32cb7d
feat(filter-box): hide druid options if druid not enabled (#14921)
* feat(filter-box): hide druid options if druid not enabled

* add bootstrap export
2021-06-07 13:49:56 -06:00
AAfghahi
7f4e036433
fix: adding additional configs and colors for queryHistory (#14995)
* added additional configs and colors for queryHistory

* added condition to status icon

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx
2021-06-07 14:10:28 -04:00
Maxime Beauchemin
8798da41a7
chore: rename 'Source' to 'Database' for consistency (#15021) 2021-06-07 10:34:52 -07:00
Ville Brofeldt
de1b140617
chore(ci): fix ci conflict (#15016) 2021-06-07 18:27:54 +03:00
Ville Brofeldt
d2a6e8cd20
fix(native-filters): avoid double load on initialization (#15012) 2021-06-07 13:47:02 +03:00
simcha90
1fc08523af
feat(native-filters): Support default to first value in select filter (#14869)
* fix:fix get permission function

* feat: add async filters support

* revert: revert ff

* feat: add async filters support

* fix: merge with master

* fix: remove tests

* lint: fix lint

* fix: fix CR notes

* fix: fix with master

* test: fix tests

* refactor: update logic for default first value

* fix: get requiredFirst

* fix: support instant

* docs: update text

* docs: fix comments

* docs: update texts
2021-06-07 13:41:19 +03:00
Yongjie Zhao
c8cf4b6bbf
fix: toggle fullscreen on the dashboard (#14979) 2021-06-04 22:24:57 +08:00
Ville Brofeldt
355223d3fe
feat(native-filters): add markers and number formatter + simple tests (#14981) 2021-06-04 16:22:54 +03:00
Kamil Gabryjelski
8c01c13d90
fix(native-filters): Fix "undefined" error after editing a filter (#14984)
* fix(native-filters): Fix "undefined" error after editing a filter

* Remove console log
2021-06-04 15:15:37 +02:00
Ville Brofeldt
6955ed287b
fix(native-filters): remove implied fetch predicate (#14982) 2021-06-04 13:45:53 +03:00
Ville Brofeldt
61a438a0cd
fix(native-filters): update cascaded filter state on change (#14980) 2021-06-04 14:01:44 +08:00
Ville Brofeldt
20b86f81e7
fix(filter box): replace freeform where clause with ilike (#14900) 2021-06-04 06:43:07 +03:00
Corbin Robb
004a6d9e54
refactor: Convert TableElement.jsx component from class to functional with hooks (#14830)
* Change TableElement from a class component to a functional component

* Replace class state checks in TableElement_spec.jsx with checks testing elements they change

* Refactor small bit of logic to use optional chaining

* Add optional chaining to some logic

* Fix IconTooltip and add IconTooltip to the collapse button

* Fix custom icon using IconToolTip so it better matches the original

* Update collapse/expand icon to use Icons component instead of importing from antdesign directly

* Fix eslint errors

* Clean up some code for readability

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-06-03 16:04:56 -07:00
cccs-jc
f652908a70
fix: renamed sqllab filters to _filters (#14971) 2021-06-03 21:22:50 +03:00
Ville Brofeldt
765e9dd932
feat(native-filters): apply cascading without instant filtering (#14966) 2021-06-03 17:48:46 +03:00
Ville Brofeldt
78d30896f3
chore: bump superset-ui to 0.17.53 (#14968) 2021-06-03 16:37:42 +03:00
Ville Brofeldt
f94c6d2763
fix(native-filters): cascading filters not rendering in tab (#14964) 2021-06-03 12:04:23 +03:00
Yongjie Zhao
e6bc7c99e7
feat: add type_generic and is_dttm to table metadata (#14863) 2021-06-03 08:20:47 +08:00
AAfghahi
53505c2acb
additional safeguard (#14953) 2021-06-02 12:02:22 -07:00
Kamil Gabryjelski
405f95b6af
feat(dashboard/native-filters): Hide filters out of scope of current tab (#14933)
* Optimize finding charts and tabs in scope

* Put filters out of scope in Collapse

* Use lastFocusedTabId instead of directPathToChild

* Fix tests

* Fix cypress test

* Uncomment e2e test
2021-06-02 20:38:18 +02:00
Michael S. Molina
b6f00e69e1
chore: Improves the native filters UI/UX - iteration 6 (#14932) 2021-06-02 09:03:13 +03:00
Lyndsi Kay Williams
06945ccbcf
feat: Icon Button (#14818)
* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
2021-06-01 20:47:42 -07:00
Elizabeth Thompson
8cc97e4790
feat: validation db modal (#14832)
* split db modal file

* hook up available databases

* use new validation component
2021-06-01 18:18:17 -04:00
AAfghahi
fac6b7c207
fix: Remove Icon and align close button on DatasetModal (#14902)
* aligned DatabaseModal header

* revisions
2021-06-01 14:53:59 -04:00
AAfghahi
eced510708
fix: Query History cosmetic issues (#14885)
* easiest fix

* Query History Cosmetic Issues

* added revisions

* beto revisions
2021-06-01 14:53:12 -04:00
cccs-jc
eef489c667
feat: add support for filters in sqlLab (#14765) 2021-06-01 21:23:51 +03:00
Ville Brofeldt
66282c3313
chore: customize adhoc filter icon and fix creatable label (#14896)
* chore: customize adhoc filter icon and fix creatable label

* use common icon component

* simplify code
2021-05-31 09:45:12 +03:00