pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 13:57:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fixing schemas_allowed_for_upload field in database connection UX (#15750)

Browse Source
This commit is contained in:
Hugh A. Miles II 2021-07-19 12:12:37 -04:00 committed by GitHub
parent 281cb92bfa
commit 7d0f6ab7f5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
View File

@ -257,9 +257,8 @@ function dbReducer(
...JSON.parse(action.payload.extra || ''),
metadata_params: JSON.stringify(extra_json?.metadata_params),
engine_params: JSON.stringify(extra_json?.engine_params),
schemas_allowed_for_csv_upload: JSON.stringify(
schemas_allowed_for_csv_upload:
extra_json?.schemas_allowed_for_csv_upload,
),
};
}

5
superset/models/core.py
View File

@ -20,6 +20,7 @@ import enum
import json
import logging
import textwrap
from ast import literal_eval
from contextlib import closing
from copy import deepcopy
from datetime import datetime
@ -668,6 +669,10 @@ class Database(
self,
) -> List[str]:
allowed_databases = self.get_extra().get("schemas_allowed_for_csv_upload", [])
if isinstance(allowed_databases, str):
allowed_databases = literal_eval(allowed_databases)
if hasattr(g, "user"):
extra_allowed_databases = config["ALLOWED_USER_CSV_SCHEMA_FUNC"](
self, g.user