* fix(chart & alert): make to show metrics properly
* fix(chart & alert): make to remove duplicate metrics
* fix(chart & alert): make to restore metrics control alert slice
* fix(chart & alert): make to fix lint issue
* add BUSINESS_TYPE_ADDONS to config with example callback
* Removing uneeded whitespace
* [Work in progress] Modifying cidr function to allow for single ip and adding port outline
* Added test REST endpoint, added some more ports
I've thrown in a test.py script as well that will try to connect to the
business_type endpoint.
* Moving code from config.py into the business api
Very simple api is exposed that will allow someone to call a checkport
endpoint and get back a response.
* Removing commented out bits.
* Adding fucntion dict back to the config
* Moving business_type endpoint to charts
* Adding schema for get endpoint
* Removing imports, updating docstring, fixing typo
Just some small changes as described in the title. I've updated the
test.py as well so it functions with the endpoint changes.
* Adding translation dict
* Fixing ops
* Adding check for list
* Modifying changes to add quotes where needed
Also changed BusinessTypeResponse to resp.
* Adding in some code to call the filter config
If a column starts with "cidr_" it will call the code in config.py to
try to translate the filter. Nothing is changed in the JSON being
executed, just some information is dumped to console.
* Porting Ryan's changes
* Adding migration script (as per Ryan's PR)
* Fixing typo
* Prettier fixes
* [CLDN-1043] Adding rough version of filter changes for business types
* fix down migration
* Fixing bugs after merge
* adding functionality to appy filters in back end
* Fixing linting issues
* fix down revision
* Changing conversion callback to handle multiple values at once
* Adding string representation of values
* Code cleanup plus fixing debouce to only be called once for each entry
* Removing non needed logginh
* Changing operator list to use sting values
* Using text value operators
* Removing clear operator call
* Moving business type endpoints
* fix down revision
* Adding port functions
* update migration
* fix bad rebase and add ff
* implement validator
* dont add invalid values to response
* [CLDN-1205] Added a new exception type for a business type translation error. Added the error message in the display_value field within the business type response. Modified the IP and Port business types to populate the error message field in the response if an error occurs
* [CLDN-1205] Added meaningful error message for port translation errors
* Removing status field from businesstype Response and adding in error message
* [CLDN-1205] Added check to make sure the port business type is within the valid range of ports, if it is not, it will populate the error message
* [CLDN-1205] Fixed the if statement that checks to see if the string_value is in the valid range of port numbers. It did not corrently verify this before now.
* [CLDN-1205] Fixed an error where it was trying to use string_value in <= statements. I just casted string_value to an integer if it is numeric, which allows <= operators to be used on it
* [CLDN-1207] Added unit tests for the cidr_func and port_translation_func functions which are located in /superset/config.py
* [CLDN-1207] removed the assertRaises line as it does not work with the cidr_func and port_translation_func functions
* [CLDN-1207] Added the skeleton of the test_cidr_translate_filter_func unit test, still need to update what the expected response from the function will be.
* [CLDN-1207] Added the remainder of the back-end unit tests for the business types
* [CLDN-1207] Fixed the syntax error which caused the test_cidr_translate_filter_func_NOT_IN_double unit test to fail
* [CLDN-1207] Removed the logging that was added for debugging purposes
* [CLDN-1207] Formatted the commands_tests.py file to make it nicer to look at/read through
* [CLDN-1207] Fixed the code so that it conformed to the pylint requirements (i.e., pylint no longer complains about the code in commands_tests.py)
* [CLDN-1207] Modified some of the docstrings so they made better use of the 100 character per line, line limit
* [CLDN-1207] Added the beginnings of the unit tests for the
business types API
* [CLDN-1207] Added a comment to the top of the commands_tests.py file explaining how to run the unit tests. This prevents the next person who tries to run them from having to waste time trying the different forms of testing that Superset supports (e.g., pytest, tox, etc.)
* [CLDN-1207] Added a grammar fix to the comments describing how to run the unit tests
* [CLDN-1207] Modified the description of the business_type API endpoints as they did not represent what the API was actually doing
* [CLDN-1207] Added further instructions on how to run the unit tests that are within the business_type/api_tests.py file
* add request validation
* disable request if business type missing
* [CLDN-1207] Unit tests for the business type API are now working, however, they need to be modified to make use of @mock as we don't want to have to run the server to be able to run the unit tests
* Removing businesss types deffinitons from config
* Adding select to only show valid business types
* Fixed Enzyme tests
* Added scalfolding for selecting filter dropdown
* Adding intigration tests
* fix revision
* fix typos and unnecessary requests
* break out useBusinessTypes
* Added front-end RTL unit tests for the business type API endpoint
* Fixed error from unit tests
* Added a unit test to ensure the operator list is updated after a business type API response is received
* Removing elect compoenet for business types
* Adding feature flag and allowing saving when no business type present
* fixing useEffect hooks
* Adding feature flag to model
* Changing behavior such that an empty string returns a default response
* add form validation
* Modified comments in unit test as command to run test has changed
* Modified comments in unit test as filename to run test has changed
* Modified the api_tests.py file to conform to the linting requirements
* Changed the name of one of the tests to reflect what the test is actually testing
* Added cypress back to the package.json
* Added informative comments
* Updated comments in files as well as removed imports which were not being used
* Changes made by npm run prettier
* Fixed spelling mistakes
* Updated models.py to remove placeholder comments used in development
* Added feature flag mocking in unit test
* Fixing open api failure
* Fixing business types to pass unit tests
* Reverting unsafe connections back to false
* Removing print statement
* Adding business tpye to export test
* setting default feature flag to false for business type
* Reverting pre commit
* Reverting pre commit and running pre commit
* Reverting pre commit and running pre commit
* Fixing formatting
* Adding license
* Fixing Linting
* Protecting api enpoints
* updating model
* Fixing code path when business type exists
* Linting
* Linting
* Fixing linting
* Fixing spelling
* Fixing schemas
* Fixing app import
* fixing item render
* Added RTL test to make sure business type operator list is updated after API response
* Fixing linting
* fix migration
* Changing unit tests
* Fixing import and DB migration after rebase
* Renaming to advanced types
* Fixing Linting
* More renaming
* Removing uneeded change
* Fixing linting and test errors
* Removing unused imports
* linting
* Adding more detailed name for migration
* Moving files to plugins
* more renaming
* Fixing schema name
* Disabling feature flag that should not be enabled by default
* Adding extra cehck
* NameChange
* formatting
* Fixing equals check
* Moveing all advanced type classes and types to one file, and converting tests to functional
* Adding advanced type to test and fix linitng
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Dan Parent <daniel.parent@cse-cst.gc.ca>
Co-authored-by: GITHUB_USERNAME <EMAIL>
Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com>
* feat(explore): Show confirmation modal if user exits Explore without saving changes
* Fix calling cleanup func unnecessarily
* Fix comparing AdhocMetric instance with JSON object
* Replace sliceFormData with the initial form data
* fix(column-header-tooltip): make that hide the tooltip when the cloumn header is turncated
* fix(column-header-tooltip): fix lint
* fix(column-header-tooltip): make to dynamic tooltip header in FilterTable
* fix(column-header-tooltip): make to fix the lint issue
* fix(column-header-tooltip): make to remove the tooltip option
* fix(column-header-tooltip): make to add test and storybook for dynamic tooltip
* fix(column-header-tooltip): make to fix lint
* fix(db & connection): make to show/hide the password when only creating db connection
* fix(db & connection): make to fix unit test of Database Modal
* fix(import): make to add the error alert
* fix(import): make to add licence
* fix(import): make to create ErrorAlert component and use errorMessage spelling
* feat: add empty states to sqlab editor and select
* add suggestions and test
* update type
* lint fix and add suggestions
* fix typo
* run lint
* remove unused code
* fix test
* remove redux for propagation and other suggestions
* add t
* lint
* fix text and remove code
* ts and fix t in p
* fix spelling
* remove unused prop
* add fn to prop change state
* remove unused code
* remove unused types
* update code and test
* fix lint
* fix ts
* update ts
* add type export and fix test
* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* remove handlerror and unused code
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* feat(explore): Move save button to header, run button to bottom of control panel
* Make the tabs sticky
* Add error icon to Data tab
* Show message when creating chart and all controls are filled correctly
* Add tests and storybook
* Fix tests
* Disable save button when control have errors
* Fix types
* Apply code review comments
* Replace styled with css
* Remove unused import
* rebase
* more progress
* Fix unintended changes
* DB import goes to step 3
* debugging
* DB list refreshing properly
* import screens flowing properly
* Code cleanup
* Fixed back button on import flow
* Remove import db tooltip test
* Fix test
* Password field resets properly
* Changed import modal state dictators and removed unneeded comment
* Removed unneeded param pass and corrected modal spelling
* Fixed typos
* Changed file to fileList
* Clarified import footer comment
* Cleaned passwordNeededField and confirmOverwriteField state checks
* debugging
* Import state flow fixed
* Removed unneeded importModal check in unreachable area
* Fixed import db footer behavior when pressing back on step 2
* Import db button now at 14px
* Removed animation from import db button
* Fixed doble-loading successToast
* Fixed errored import behavior
* Updated import password check info box text
* Connect button disables while importing db is loading
* Connect button disables while overwrite confirmation is still needed
* Connect button disables while password confirmation is still needed
* Removed gray line under upload filename
* Hide trashcan icon on import filename
* Modal scroll behavior fixed for importing filename
* Changed errored to failed
* RTL testing for db import
* Move chart header to top of the page
* Implement truncating and dynamic input
* fix typing
* Prevent cmd+z undoing changes when not in edit mode
* Fix tests, add missing types
* Show changed title in altered
* feat(explore): SQL popover in datasource panel
* Fix acequire not defined
* Rebase and fix tests
* Disable highlighting gutter
* Use ace-build acequire instead of brace
* feat(dashboard): Implement empty states in empty tabs
* Change button to in text link
* Add edit dashboard button to dashboard empty state
* Add tests
* Fix test
* feat(explore): Move chart actions to a dropdown menu
* Fix tests and add some new ones
* Add background color to embed code button
* Fix cypress tests
* Move copy permalink to actions menu
* Remove unused function
* Move share by email above embed code
* Fix test
* Fix test
* Fix test
* Fix test
* Fix test
* fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart
* fix(export-add): make to setup the default error message
* fix(report-add): make to allow the errorMessage undefined in LabeledErrorBoundInput component
* fix(fonts): Import all necessary font packages
* Make html tags themable
* Set bold font weight to 600, add medium font weight to theme
* Replace hard coded font weights with theme variables
* Change some font weight light elements to normal
* Fix tests
* Fix bug in pivot table
* Address code review comments
* wip
* feat: make 401 responses configurable in SupersetClient
* sort
* guest unauthorized handler
* add toast container to embedded app
* add option for toast presenter to go at the top
* remove confusing comms logging
* lint
* Update superset-frontend/src/embedded/index.tsx
* type correction
* remove ENABLE_REACT_CRUD_VIEWS feature flag
* docs
* deal with problematic tests
* empty test suite
* skip test
* test conditions changed
* removing the tests instead of skipping
* make that the comma can be added by removing it from token separators in select component.
* fix(explore comma): add the allowTokenSeperators props into Select
* fix(explore comma): make to allow to customize the token separators in Select.
* fix(explore comma): make to add the unit test and story book.
* fix(explore comma): make to fix the lint
* fix(explore comma): make to fix the spell & add tokenSeparatprs props to PickedSelectProps
* Update Select.tsx
* fix(explore comma): make to run lint fix
* fix: allow to select <NULL> in a native filter single mode
* fix lint issue
* Update superset-frontend/src/components/Select/utils.ts
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* fix
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* fix(altered-modal): make all text fields wrap
* fix(altered-modal): limit the wrap text in particular column
* fix(altered-modal): make to update the unit test
* fix(altered-modal): make to fix the type of columnsForWrapText
* fix(alerted-modal): make to fix the type of columnsForWrapTest with string type
* fix(15849): Removed the tooltip from CopyToClipboard button in sqllab
* chore(sqllab): added props for tooltip in CopyToClipboard component
* fix(sqllab): Added arg to storybook and refactor the component
* fix(sqllab): added a test case for hideTooltip
* fix(delete-modal): Changed the color of the help text with grayScale.dark1 in DeleteModal
* Update superset-frontend/src/components/DeleteModal/index.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* fix errors with rison and useQueryParams
* add test for encode/decode
* add rison link and make test case more readable
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* add sorting for query results grid and add natural order sort
* modify tests for natural/original order state
* clean up setState
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* feat(dashboard): Implement empty states for dashboard
* Add empty state to native filters
* Add missing license
* Remove redundant string types from EmptyState
* chore: fix misspelling of button
* changed QuerySearch/index.jsx to index.tsx
* updated Query type at src/SqlLab/types.ts/Query and extended it into QueryTable
* updated defaultQueryLimit to be optional at ResultSetProps of superset-frontend/src/SqlLab/components/ResultSet/index.tsx
* moved statusAttributes into useMemo hook so that it will not make the dependencies of useMemo Hook change on every render and statusAttributes is only used within useMomo hook
* reset package-lock.json and package.json at frontend
* Acquired redux rootestate type for SqlLab, to be used at useSelector(state)
* updated query to be Query type and added a comment for q.status on line 178
* updated queryTable for typescript conversion
* updated actions type on QueryHistory and QuerySearch
* updated type for actions in SouthPane
* created type for SqlLab redux
Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* feat(dashboard): embedded dashboard UI configuration (#17175) (#17450)
* setup embedded provider
* update ui configuration
* fix test
* feat: Guest token (for embedded dashboard auth) (#17517)
* generate an embed token
* improve existing tests
* add some auth setup, and rename token
* fix the stuff for compatibility with external request loaders
* docs, standard jwt claims, tweaks
* black
* lint
* tests, and safer token decoding
* linting
* type annotation
* prettier
* add feature flag
* quiet pylint
* apparently typing is a problem again
* Make guest role name configurable
* fake being a non-anonymous user
* just one log entry
* customizable algo
* lint
* lint again
* 403 works now!
* get guest token from header instead of cookie
* Revert "403 works now!"
This reverts commit df2f49a6d4.
* fix tests
* Revert "Revert "403 works now!""
This reverts commit 883dff38f1.
* rename method
* correct import
* feat: entry for embedded dashboard (#17529)
* create entry for embedded dashboard in webpack
* add cookies
* lint
* token message handshake
* guestTokenHeaderName
* use setupClient instead of calling configure
* rename the webpack chunk
* simplified handshake
* embedded entrypoint: render a proper app
* make the embedded page accept anonymous connections
* format
* lint
* fix test
# Conflicts:
# superset-frontend/src/embedded/index.tsx
# superset/views/core.py
* lint
* Update superset-frontend/src/embedded/index.tsx
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* comment out origins checks
* move embedded for core to dashboard
* pylint
* isort
Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* feat: Authorizing guest access to embedded dashboards (#17757)
* helper methods and dashboard access
* guest token dashboard authz
* adjust csrf exempt list
* eums don't work that way
* Remove unnecessary import
* move row level security tests to their own file
* a bit of refactoring
* add guest token security tests
* refactor tests
* clean imports
* variable names can be too long apparently
* missing argument to get_user_roles
* don't redefine builtins
* remove unused imports
* fix test import
* default to global user when getting roles
* missing import
* mock it
* test get_user_roles
* infer g.user for ease of tests
* remove redundant check
* tests for guest user security manager fns
* use algo to get rid of warning messages
* tweaking access checks
* fix guest token security tests
* missing imports
* more tests
* more testing and also some small refactoring
* move validation out of parsing
* fix dashboard access check again
* add more test
Co-authored-by: Lily Kuang <lily@preset.io>
* feat: Row Level Security rules for guest tokens (#17836)
* helper methods and dashboard access
* guest token dashboard authz
* adjust csrf exempt list
* eums don't work that way
* Remove unnecessary import
* move row level security tests to their own file
* a bit of refactoring
* add guest token security tests
* refactor tests
* clean imports
* variable names can be too long apparently
* missing argument to get_user_roles
* don't redefine builtins
* remove unused imports
* fix test import
* default to global user when getting roles
* missing import
* mock it
* test get_user_roles
* infer g.user for ease of tests
* remove redundant check
* tests for guest user security manager fns
* use algo to get rid of warning messages
* tweaking access checks
* fix guest token security tests
* missing imports
* more tests
* more testing and also some small refactoring
* move validation out of parsing
* fix dashboard access check again
* rls rules for guest tokens
* test guest token rls rules
* more flexible rls rules
* lint
* fix tests
* fix test
* defaults
* fix some tests
* fix some tests
* lint
Co-authored-by: Lily Kuang <lily@preset.io>
* SupersetClient guest token test
* Apply suggestions from code review
Co-authored-by: Lily Kuang <lily@preset.io>
Co-authored-by: Lily Kuang <lily@preset.io>
* Update existing tests
* Add backend test
* feat: add force option to report screenshots
* Add tests
* Rebase fixes
* Do not force screenshot on dashboard alerts
* fix: Select component sort function sorting by label instead of value on numbers
* fix: change select component default sorting to sort by the initial index rather than a property like value or label
* fix: select sorting add sortOptions to select components using sortByProperty
* fix: change select component back, add order to options coming in from SelectControl
* fix: select component options intitial sort bug
* fix: add test cases for select fix
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* Floating nums now sorting correctly with parseFloatingNums function
* Floating numbers AND strings now sorting correctly, +locale comparison
* Added NULL handling back to sort function
* Moved parseFloatingNums outside of sortResults
* Removed localeCompare and added testing
* Add equality check back to sort function
* Added floatValue nit
* Fix NULL styling in gridCell
* removed unnecessary imports
* Added null styling back to renderGridCell
* Cleaned up a little code as per Elizabeth
* Found another little cleanup spot
* fix: Order of Select items when unselecting
* Adds a property comparator that supports strings and numbers
* Uses a named export for propertyComparator
* abstract boilerplate code into class and rename csv to file
* add db migration
* fix some stuff
* more renaming of csv to file
* rename in translations
* update down revision
* update down revision
* bump chart version
* switch to alter column name approach in db migration
* fix db migration for MySQL
* db migration conflict
* Changed SQL Lab result column header-style width to max-content
* Changed .ant-tooltip-open to block and tooltip placement to topLeft
* Moved tooltip style changes to local implementation instead of global
* chore: Change the list views to use the new Select component
* Fix Cypress tests
* Enables search for all controls
* Adjusts controls width
* Removes 'Me' and keeps the logged user on top
* Fixes tests
* Uses the borderless version for the filters
* Fixes the tests
* Reverts the Select theme to the default
* Rebases and fixes js error
* Fixes failing test
* Removes unused withTheme
* chore: Improves the Select component to avoid additional queries when all values have been loaded
* Handles the logic in handlePaginateFetch and removes the use effect
* Clean up and reorganize effects
* Enhance optionFilterProps
* Render custom label
* Remove prop filtering
* Create options
* Create option from value in single mode
* Change to customLabel
* Show search by default
* Update superset-frontend/src/components/Select/Select.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/components/Select/Select.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/components/Select/Select.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Apply minor changes
* Fixes a bug that was failing CI
* Adds more tests to the component
* Apply customLabel in ColorSchemeControl
* Remove customLabel from rendered Option
* Hide No data when allowNewOptions
* Remove unnecessary prop from tests
* Adjust loading height
* Show no data with fetchOnlyOnSearch
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
* fix: setupPlugin in chart list page
* fix the order of setupPlugins call
* Fix jest test on loading geojson
* add jest changes
* fix unit tests
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
* copy to Clipboard order
* centralized copyToClipboard
* fixed table order
* fixed tests
* added colnames to all viz types
* added colnames to all viz types
* added colnames to all viz types
* Fix style and implement ESC
* Include ESC test case
* Move pagination outside of table
* Update superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Enhance
* Handle close
* Localize placeholder
* Fix tests
* Clear input on close
* Destroy modal on close
* Clean up
* Fix tests
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* chore: implement new mockup to the new viz gallery
* fix: update package-lock
* fix: add license
* fix: reduce duplication and fit within the sidebar
* fix: ut
* initial commit
* fix theme
* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* add modal layout with description, rework styles
* thirty percent
* test correctly
* avoid any changes in modal height
* typescriptify
* feat(viz): add categories to the viz picker (#15304)
* feat(viz): add categories to the viz picker
* fix test types
* add a catch-all category
* tweak layout
* upgrade superset-ui to get new metadata
* do i look like i know what a jpeg is
* fix tests
* lint
* remove script count test requirement
* fix e2e test
* feat(explore): Viz picker search improvements (#15399)
* upgrade superset-ui, install fuse.js
* add metadata to plugin context
* get search working
* layout improvements
* fix tests
* Update superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* use typography size instead of grid unit
* comments
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* feat(explore): Examples image gallery in the viz type control (#15489)
* feat(explore): add section for example images in viz type control
* fix jpg webpack config
* formatting
* feat(Explore): Viz gallery component tweaks (#15520)
* separate viz gallery from the modal
* use gallery directly in add slice view
* more formatting on the add slice container
* restyle the thumbnail list
* explicit thumbnail width and height
* remove crappy hack
* remove useless line
* comment
* sort categories
* comments
* tweak search behavior
* fix tests
* open gallery to the currently selected viz type
* null safety
* show all plugins when searching empty string
* get the new metadatas
* adjust categories scrolling behavior
* add time series table metadata
* upgrade superset-ui
* attempt fixing tests
* upgrade descriptions
* fix unit test
* attempt fixing e2e again
* max width for viz gallery
* update package lock
* undo unnecessary webpack changes
* don't show search results until something is entered
* force modal to open to selected viz type
* tweaks to search behavior
* gallery layout tweaks
* enshrine pivot table v2 in a place of honor
* feat(viz): Clear viz gallery when navigating between categories (#15577)
* start viz gallery with null selection, clear when switching categories
* fix AddSliceContainer tests
* show a message when there is no viz type selected
* composition > inheritance
* clarify searching code
* comment
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* split db modal file
* split db modal file
* hook up available databases
* add comment
* split db modal file
* hook up available databases
* use new validation component
* first draft
* use new validation component
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* get tests passing
* Removed logo from test
* split db modal file
* hook up available databases
* use new validation component
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* saving for now
* revisions
* fix package-lock.json
* update styles
* save
* # This is a combination of 6 commits.
# This is the 1st commit message:
feat: validation db modal (#14832)
* split db modal file
* hook up available databases
* use new validation component
# This is the commit message #2:
feat: Icon Button (#14818)
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
# This is the commit message #3:
chore: Improves the native filters UI/UX - iteration 6 (#14932)
# This is the commit message #4:
fix: is_temporal should overwrite is_dttm (#14894)
* fix: is_temporal should overwrite is_dttm
* move up
# This is the commit message #5:
fix: time parser truncate to first day of year/month (#14945)
# This is the commit message #6:
hook up available databases
* fix test for db modal
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* more revisions
* create 1 function for setting the DB
* add function to preferred section
* small refactor and added styling
* used db.backend
* add new footer buttons
* add finsh buttong
* refactor db modal render
* fix comments issue
* added engine to model
* elizabeth revisions
* add header
* add bottom footer to sqlalchemy form
* # This is a combination of 6 commits.
# This is the 1st commit message:
feat: validation db modal (#14832)
* split db modal file
* hook up available databases
* use new validation component
# This is the commit message #2:
feat: Icon Button (#14818)
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
# This is the commit message #3:
chore: Improves the native filters UI/UX - iteration 6 (#14932)
# This is the commit message #4:
fix: is_temporal should overwrite is_dttm (#14894)
* fix: is_temporal should overwrite is_dttm
* move up
# This is the commit message #5:
fix: time parser truncate to first day of year/month (#14945)
# This is the commit message #6:
hook up available databases
* fix test for db modal
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* elizabeth revisions
* add back headers
* add step
* feat: Dynamic Form for edit DB Modal (#14845)
* split db modal file
* split db modal file
* hook up available databases
* add comment
* split db modal file
* hook up available databases
* use new validation component
* first draft
* use new validation component
* get tests passing
* split db modal file
* hook up available databases
* use new validation component
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* revisions
* fix package-lock.json
* # This is a combination of 6 commits.
# This is the 1st commit message:
feat: validation db modal (#14832)
* split db modal file
* hook up available databases
* use new validation component
# This is the commit message #2:
feat: Icon Button (#14818)
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
# This is the commit message #3:
chore: Improves the native filters UI/UX - iteration 6 (#14932)
# This is the commit message #4:
fix: is_temporal should overwrite is_dttm (#14894)
* fix: is_temporal should overwrite is_dttm
* move up
# This is the commit message #5:
fix: time parser truncate to first day of year/month (#14945)
# This is the commit message #6:
hook up available databases
* fix test for db modal
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* more revisions
* used db.backend
* added engine to model
* elizabeth revisions
* elizabeth revisions
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: hughhhh <hughmil3s@gmail.com>
* address comments
* oops
* # This is a combination of 6 commits.
# This is the 1st commit message:
feat: validation db modal (#14832)
* split db modal file
* hook up available databases
* use new validation component
# This is the commit message #2:
feat: Icon Button (#14818)
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
# This is the commit message #3:
chore: Improves the native filters UI/UX - iteration 6 (#14932)
# This is the commit message #4:
fix: is_temporal should overwrite is_dttm (#14894)
* fix: is_temporal should overwrite is_dttm
* move up
# This is the commit message #5:
fix: time parser truncate to first day of year/month (#14945)
# This is the commit message #6:
hook up available databases
* fix test for db modal
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* remove merge conflicts
* small fix on blocking creating
* feat(db-connection-ui): Big Query Add Database Form (#14829)
* fix(native-filters): Manage default value of filters by superset (#14785)
* fix:fix get permission function
* feat: manage default value in superset
* fix(native-filters): loop bug by simplify state handling (#14788)
* fix: set table name width to not hide icons when name is too long (#14489)
* fix: set table name width to now hide icons when name is too long
* fix: table style
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
* feat(explore): Remove default for time range filter and Metrics (#14661)
* feat(explore): Remove default for time range filter and Metrics
* Merge errors with same messages
* Fix e2e test
* Rename a variable
* Bump packages
* Fix unit tests
* feat: chart gallery search improvement (#14484)
* feat: chart gallery search improvement
* test: adding unit test for VizTypeControl
* fix: lint errors
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
* Update schemas.py
* Update bigquery.py
* Fix tests
* big query form is appearing on the screen
* add name to allow for actions to get picked up
* working post for saving db via paste
* working file upload
* switch to textare
* better styles
* add delete buttong
* save formating
* wrap encrypted_extra
* formatting component
* clear out file input before reloading
* remove default driver
* address comments
* fix things off rebase
* small refactore
* more patches
* checkout space file
* fix variable ref
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Einat Bertenthal <einatbar@users.noreply.github.com>
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* feat: adding SSL Toggle to Create Database Modal (#14976)
* first draft of SSL Toggle
* added payload data
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* changed tooltips based on stephen advice
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
* feat(database-connection-ui) Allow configuration of Database Images from SupersetText (#15023)
* saving this for now
* fix some styles
* add database images
* fix
* enforce only numbers
* add default iamge
* fix bug
* additional params to the DatabaseConnectionForm (#15071)
* additional params to the DatabaseConnectionForm
* save passing params up to api
* feat: Added Steps and centralized Headers (#15041)
* fix superset_text issue (#15095)
* fix edit issue by returning parameters properly (#15101)
* feat: added alerts (#15103)
* added alerts
* revisions
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* fix: fixing api tests for database connections (#15124)
* fixing api tests
* added test for no config method on create
* added config method to validation tests
* fix(db-connection-ui): Additional Query Parameters render (#15150)
* working query params
* move condition out before update or create
* fix type script issues
* feat(db-connection-ui): Move fields from Extra section and split engine and metadata (#15143)
* working edit extra options
* acquired most of json
* recontruct json
* add schema array
* add proper styles
* fix tslint issues
* remove console.log
* this is working
* style: Database connect UI Polish - Step 1 (#15119)
* save avg
* Styled step 1
* Remove Alert
* Finished styling, added ellipsis library to IconButton
* Fixed text margin
Co-authored-by: hughhhh <hughmil3s@gmail.com>
* fix app from merge
* fix tslint issues
* fix all tslint issue on feature branch
* catch errors for dialects with no driver set
* fix dremio issue
* fix dialect issue without driver attr
* Styled step 3 (#15187)
* feat: adding server-side validation and unmasked password on create (#15151)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* validation and password masking
* revisions and validation range
* revisions
* added beto revisions
* added tests for port range
* added config to available
* testing, rtl
* made tests always pass
* feat: add Close/Finish buttons to DBModal on Edit (#15199)
* fix(db-connection-ui): Allow Dynamic Big Query Edits (#15185)
* working big query edits
* fix big stoping users from moving to next step
* fix default
* save defaults
* fix tslint
* remove object
* fix styling
* fix: Connect on DB Connection wasn't working (#15201)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* fixed the connect button
* make available alphabetically sort
* make available alphabetically sort II
* fix selection
* remove console.log
* fix styling
* fix: fix api_test and typeScript error (#15202)
* fix big query issue
* allow for query params
* feat: Added Dynamic form link to SQL Alchemy Form (#15208)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* added dynamic form link
* fix: fix api tests for test_available (#15210)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* fixes api tests
* feat: added Spinner to DB Modal (#15229)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* Made header sticky (#15204)
* fix: make Edit DB modal look similar to create Modal (#15231)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* changed edit
* fix: DB Connection UI R2 Fixes (#15232)
* fix display name refill
* fix order of additional params to always be at the bottom
* remove schema check on validation
* make encryption last
* fix json file upload
* fix additional params issue
* remove comments
* add back validation
* small fixes on bigquery edit
* only wrap encrypted with bigquery
* specific conditions for wrapping big query items
* dix additional params
* fix allow display name in sqlalchemy form
* backend before engine
* fix: do not use Marshmallow validation in partial params validation (#15236)
* fix: do not use Marshmallow validation in partial params validation
* Fix lint
* Update test
* make display name required
* reset validation errors onClose (#15243)
* fix: Edit for all dynamic forms (#15244)
* fix edit for dynamic forms
* fix linting
* fix edit on sqlalchemy forms
* fix big query reference
* remove extra if
* wrap configuration method (#15274)
* add more specific engine elastic search (#15287)
* do a deep copy of obj before POST (#15298)
* feat: add Back button to extra options (#15300)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* first draft
* working
* added back button to create modal
* revisions and testing
* chore: Add tooltips and button to Connect Postgresql DB Modal Form (#15179)
* Added tooltips. Still need to place in the right spot.
* Revert to where I started.
* Added 3 tooltips, 1 Button(need link config). BigQuery not added yet.
* Added tooltip BigOuery modal. `span` above upload btn missing `*`
* Added tooltip to `Host` field. Alignment needs to be fixed.
* Stuck trying to add conditional render of tooltip to LabeledErrorBoundInput
* Clean commit for review
* Dynamic tooltip componet created. Needs alignment of SVG still.
* Fixed typo.
* Added line spacing back in
* Changed required props to optional/Remove comment
* Fixed alignment of tooltips & moved 2tooltips outside of Btn
* Added one more line space back in
* Removed Typo
* Removed another typo
* Flixed linter error
* Created test for tooltip.
* Added expectation for visible tooltipIcon
Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>
* style: Database Modal UI Polish (#15234)
* Corrected polishing tasks from Clubhouse ticket
* More UI polish
* Added more polish
* Moved encryption field and created constant value for viewBox in InfoToolTip
* feat: allow editing (#15308)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* elizabeth fixed the edit issue
* feat: Added error alert for DB connection Modal (#15242)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* added errorAlert
* added revisions
* current work
* revisions
* fix: validation on edit (#15310)
* fix: Big Query Error messaging (#15334)
* remove validation check
* remove validation check
* fix error messaging
* stop validation on big query
* add condition for skipping specific engines for validation
* if no params
* update styles
* feat: big Query using back button (#15338)
* fix: password errors on validation (#15372)
* filter out password supply for validation
* filter password
* feat: updated Error Alert (#15377)
* Updated styling (#15379)
* fix password error filter
* feat: Arash/password field error (#15388)
* fix: Back Button on Create for DB conncetion (#15389)
* fix: add icons (#15122)
* added alerts
* revisions
* added icon
* spinner
* fixing backButton on Create
* fix doc (#15393)
* style: Database Connection Modal UI Polish R5 (#15412)
* Fixed inconsistent header spacing in step 1
* Touched up tooltips
* Added red *s to BigQuery form
* Centered modal window
* make alerts configurable (#15404)
* fix: Allow users to override database connection docs (#15434)
* allow users to override docs
* fix linting issue
* fix: Error Icon not showing up on errored input fieds on validation (#15431)
* Fixed now-show error icon
Signed-off-by: andrewbastian <andrew.bastian@gmail.com>
* Changed `%` to `px`
* Fixed lint error
* Changed units to `theme.gridUnit`
* test: RTL testing on DatabaseModal (#15394)
* RTL testing on DatabaseModal
* Continued RTL testing on DatabaseModal
* Code cleanup
* Removed a comment that missed my radar
* test: Add e2e testing (#15376)
* create boilerplate for cypress test
* added 1 more test
* add more test cases
* saving this for development
* lit
* remove name
* update pass
* remove unused test
* fix merge conflicts
* Fixed "connetion" typo (#15458)
* fix: Database connection modal touch up (#15463)
* Removed unnecessary TODO and named the remaining ones
* Added translation functionality
* Fixed typo in Database Modal RTL test
* Update modal.test.ts
* fix: Showing errors for SQLA forms (#15462)
* fix documentation links
* fix sqlalchemy onCreate
* Fixing SQLA error messaging
* fix logic for extra save
* fix this issue
* fix: Update Invalid Port SIP-40 Reference (#15464)
* Fixed jumpy header text
* fix: Edit Modal not saving properly (#15468)
* Aligned info icons on dynamic form
* fix: merge conflict (#15479)
* chore: simplify errors and issue codes (#15437)
* Fix issue number
* Fix test
* Fixed line-height in header, also fixed translation functions in BigQuery
* Updated placeholder text in additional params field
* Fixed padding in edit form
* Corrected placeholder text in BigQuery > Service Account field
* Make linter happy
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Arash <arash.afghahi@gmail.com>
Co-authored-by: hughhhh <hughmil3s@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Einat Bertenthal <einatbar@users.noreply.github.com>
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Andrew Bastian <50464395+andrewbastian@users.noreply.github.com>
Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>
* snowflake errors
* added big query
* added to setup error messages, first test
* all big query testing added
* added snowflake test
* added syntax error
* added syntax errors to most used databases
* intial commit
* fix test
* Update superset-frontend/src/components/LastUpdated/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Implement initial structure
* Add aria-label
* Rename files
* Refactor single mode new options
* Clean up
* Add select at every corner in storybook
* Clean up
* Add pagination
* Move selected options at the top
* Clean up
* Add license
* Refactor
* Improve pagination
* Fetch when allowNewOptions
* Clean up
* Front end update - modify OPERATORS, to have SQL operation and display value
* Updated tests
* More tests
* Remove OPERATOR imports
* Fix break tests
* PR comments
* fix issue with comparator loading
* rename a variable
* Linting
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
* Error Input Form created
* Adjusting styling
* testing complete
* Corrected component naming in Form
* testing complete
* Corrected component naming in Form
* Renamed stories file to appropriate name
* add image for alert
* Fixed test
* Switched from px to theme
* Adjusting LabeledErrorBoundInputProps
* validation now accepts a string
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Sqllab limit
* Add migration script
* Set default values
* initial push
* revisions
* moving migration to separate PR
* revisions
* Fix apply_limit_to_sql
* all but tests
* added unit tests
* result set
* first draft
* revisions
* made user required prop, added it to all places ResultSet is imported
* changed QueryTable test to allow for useSelector
* Query Table working
* working with heights
* fixed scrolling
* got rid of animated
* fixed tests, revisions
* revisions
* revisions
* heights
* fun with heights
* alert state
* aaron helped me fix this
* better alert messages
* fixed result set test
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* fix: Adding a little margin under the warning about changing datasets
* feat: moves Alert spacing from a css override to an Alert prop
* fix: prop needs to be optional... proptional
* fix: moving the typing to a better spot, adding the new prop to storybook.
* style: linting
* chore(dashboard): Integrate dashboard app into the SPA bundle
* fix url params
* change variable name
* change title correctly
* custom css
* lint
* remove unused file
* remove content assertions from dashboard tests
* fix case with missing bootstrap data
* fix: respect crud views flag
* crud views -> spa
* remove unused dashboard templates
* fix: remove unused variable
* fix: missed a spot with the crudViews -> spa
* router link to dashboard from dashboard list page
* link using the router when in card mode
* lint
* fix tests, add memory router
* remove dashboard app files
* split up the bundle a little more
* use webpack preload
* Add aria-label and twotone
* Enhance LazyIcon
* Fix tests and solve ject warnings
* Add new line
* Revert package-lock to master
* Fix failing test
* Implement icon overrides
* Fix failing storybook
* Clean up
* Improve var name
* Implement adhoc filters in Range and Select native filters
* Add time picker
* Remove additional filters from datamask
* Create separate stylesheet for AdhocFilterControl in native filters
* Rename Time picker to Time range
* Fix columns in AdhocFilter empty when creating a new filter
* Skip flaky test
* test: add tests for filter bar
* test: merge filter bar tests with master
* test: add test for filter set
* test: filter set tests
* test: merge with master
* test: fix tests for filter bar
* fix: fix CR notes
* fix: fix CR notes
* add hook for future async api calls
* test to see conflict
* add async middleware and update reducers
* working async dashboard load
* implement getcharts api
* add user permissions to explore and dashboard bootstrap data
* integrate api calls with getinitial state
* update namings
* accept an id or a slug in the dashboard charts api
* add permissions function
* fix merge
* update state
* get dashboard charts by id or slug
* fix undefined states
* variable names
* stop using some more bootstrap data
* fix metadata reference
* remove unused bootstrap from the template
* add errorboundry to dashboard
* refactoring, fixing
* update permissions
* add just roles
* id is supposed to be a string
* unused vars
* get datasources from api
* make onError optional
* use resource hooks, better error boundary
* add loading state for dashboardroute
* remove console
* add conditional
* more conditionals
* testing out a possible fix for cypress
* convert edit/standalone test to cypress
* remove bootstrappy assertions
* lint
* fix dashboard edit history issue
* rename stuff
* address recent native filters schema change
* remove unused getInitialState
* remove .only from test
* hooksy redux usage
* Revert "more conditionals"
This reverts commit 25c8ed61b4.
* cleanup
* undo unnecessary change
* actually need conditions here
* certainty
* Revert "certainty"
This reverts commit 77dea1915b.
* more permutations (untested yolo)
* Update superset-frontend/src/chart/chartReducer.ts
Co-authored-by: Evan Rusackas <evan@preset.io>
* import style
* comment
* cleaner dashboardInfo
* remove debug code
* use memo for getPermissions
* fix lint
* adjust name/location of DashboardPage
* move logic for REMOVE_SLICE_LEVEL_LABEL_COLORS to DAO
* stop using full_data()
* remove unused (and now useless) json=true query param
Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
* replace Well componenet with Card component
* Fix lint errors
* Fix lint
* Addressing comments
* Addressing comments
* Fix lint errors
* Exporting Card from index.tsx and adding storybook variants
* Fix some refactoring
* Fix errors
* solving conflicts and lint errors
* Update superset-frontend/src/common/components/Card.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/Card.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
