Commit Graph

962 Commits

Author SHA1 Message Date
Kamil Gabryjelski
3e6bcbb98d
Remove "required" from SaveModal Add to dashboard field (#11693) 2020-11-16 15:07:24 -08:00
Evan Rusackas
86651cd451
fix: default dashboard/chart cards are vector with perfect corners (#11684)
* fix: default dashboard/chart cards are vector with perfect corners

* fix: adding licenses
2020-11-16 09:26:07 -08:00
adam-stasiak-polidea
2f036e9359
chore: V1 charts load cypress tests (#11685)
* Enabled assertion on v1 chart request

* added missing code after rebase

* extracted alias logic to function

* modified v1 requests to contain form data, added assertion on ui elements using slice id from request
2020-11-16 09:08:35 +02:00
Rob DiCiuccio
700c7c524e
build(cypress): Fix issue with cypress code-coverage plugin when running locally (#11698)
* Update @cypress/code-coverage to latest

* Set nyc reporter to html/text

* Revert dashboard list test changes from #11613

* Update codecov reporting to summary format

* Add json reporter for codecov.io

* Silence inline coverage reports
2020-11-15 13:16:34 -08:00
Grace Guo
7d27996867
chore: remove a few obsolete logic (#11676) 2020-11-13 23:16:05 -08:00
Kamil Gabryjelski
2b107ed33d
Fix overflow hidden issues in Dashboard Builder tabs (#11691) 2020-11-13 23:14:02 -08:00
ʈᵃᵢ
218f58edb7
fix(saved query): handle null sql field (#11679) 2020-11-13 13:15:24 -10:00
Craig Rueda
95246e8812
feat: Adding docker build/push (#11616)
* Adding docker build/push

* Adding build script

* Trying username

* Updating build script

* Fixing script path?

* Lising envvars

* Pulling HEAD

* Actually pushing

* Fixing build / SHA

* Logout before login

* updating docker login

* Fixing docker login

* Trying stdin pwd

* Adding check for forks

* Fixing tagging

* Fixing refspec

* Updating Dockerfile-dev

* Adding license to script

* Fixing Cypress tests
2020-11-13 11:32:18 -08:00
Jesse Yang
ec8ccd4cf1
feat: keep modal open when saving database failed (#11618) 2020-11-12 16:10:14 -08:00
Kamil Gabryjelski
3ad65bc163
fix: Dropdown menu not closing on Dashboard view (#11671) 2020-11-12 14:48:48 -08:00
Maxime Beauchemin
5cb6c25ca0
docs: add support for Google Analytics on superset.apache.org (#11613)
* docs: add support for Google Analytics

* fix failing cypress test in list_view.test.ts

* xit some tests
2020-11-12 13:57:05 -08:00
ʈᵃᵢ
432e5ab460
feat: Query History CRUD list view (#11574) 2020-11-12 11:55:13 -10:00
ʈᵃᵢ
1dc4c4746e
fix(dashboard): ordering for add chart widget (#11672) 2020-11-12 11:10:45 -10:00
Kasia Kucharczyk
4af7264a2c
fix: make higher chart box resizable (#11673)
* Added visible resizible icon to all types of blocks in tabs

* Adjusted position of hovered framwes and edited markdown
2020-11-12 11:53:48 -08:00
Elizabeth Thompson
b277f19808
keep placeholder on multiselect (#11289) 2020-11-12 11:36:24 -08:00
Ville Brofeldt
2718909314
feat: add ECharts BoxPlot chart (#11199)
* feat: add ECharts BoxPlot chart

* lint

* fix cypress tests

* lint

* remove viz.py shim

* bump plugin package

* skip non-legacy plugin cypress dashboard tests

* fix cypress tests

* disable cypress tests for non-leagcy charts

* fix bad rebase

* use midpoint interpolation for quartile calculation

* bump packages and add support for no groupby

* whitespace

* whitespace

* linting

* fix tests

* xit mathjs load test

* bump mathjs to 8.0.1

* disable cypress filter test for v1 charts
2020-11-12 10:01:04 +02:00
Kamil Gabryjelski
6ef4d2a991
Restructure chart header to wrap nicely (#11643) 2020-11-11 20:18:04 -08:00
Elizabeth Thompson
f3b68cbbbe
add import icon (#11652) 2020-11-11 13:48:53 -08:00
Jesse Yang
4f21dea55f
feat(dev): dont override asset manifest in dev-server (#11648)
Override manifest.json only when `npm run dev`, not `npm run
dev-server`.  This allows developers to compare between the
current version of Superset with what they are working on
without switching back and forth between branches.

All they need to do is to first start the current version with
production build:

```
npm run build
superset run -p 8088
```

Then start the dev server in another window:

```
npm run dev-server
```
2020-11-11 13:14:45 -08:00
Grace Guo
a9f9c4bbd5
[fix] handle null value in date filter (#11655) 2020-11-11 09:32:26 -08:00
ʈᵃᵢ
329e72885c
fix(saved-query): handle case where sql_tables in undefined (#11649) 2020-11-10 15:26:29 -10:00
Evan Rusackas
73cc938358
style: various little tweaks to home screen stylin' (#11650)
* adding bottom padding

* making light gray backgrounds match

* vertical centering of empty state content.

* linting 

* fixing card radii

* fixing corner radius... thumb was covering corner border.
2020-11-10 17:20:31 -08:00
Jesse Yang
75245177e9
chore: pin node and npm versions (#11646) 2020-11-10 15:58:54 -08:00
Jesse Yang
339d0d73bc
feat(sankey-viz): allow sort by metric and bump superset-ui packages (#11626) 2020-11-10 15:58:00 -08:00
Rob DiCiuccio
14aa729e66
build(deps-dev): update cypress to 5.5.0, improvements for running locally (#11603)
* reduce numTestsKeptInMemory to 0 to prevent Chrome OOM crash

* Add cypress-run-chrome script, update docs and cypress_build.sh

* Upgrade Cypress to latest version

* tox: add missing 'cypress' env, cleanup flask server

* Fix failing dashboard edit test syntax

* Reduce retry count to 1

* Prettier test
2020-11-10 15:51:47 -08:00
adam-stasiak-polidea
4eff80c3f3
chore: enabled cypress test in filter file (#11458)
* enabled cypress test in filter file

* added delay to typing

* additional assertion and timeout

* Modified test logic - changed user's action to selection from list instead of typing (unstable with cypress)
2020-11-10 15:18:20 -08:00
Kamil Gabryjelski
98d1c6964c
refactor: Remove reactable arc (#11535)
* Refactor DisplayQueryButton into functional component and use react-table

* Refactor EstimateQueryCostButton to functional component

* Use react-table instead of reactable-arc

* Remove reactable-arc dependency

* Add margin for copy button

* Make search case insensitive
2020-11-10 15:13:29 -08:00
Evan Rusackas
3b89d2307a
fix: card thumbnails now always show border. (#11638)
Co-Authored-By: Evan Rusackas <evan@preset.io>
2020-11-10 08:58:39 -08:00
adam-stasiak-polidea
4d41cf900d
Disabled bubble test (#11630) 2020-11-09 18:58:28 -08:00
Grace Guo
966a826720
fix: js unit test when save dash (#11632) 2020-11-09 17:56:30 -08:00
Evan Rusackas
d315dd96f0
style: fixing tall filter indicators (#11631)
Co-Authored-By: Evan Rusackas <evan@preset.io>
2020-11-09 16:17:32 -08:00
David Aaron Suddjian
5be1dbe28b
feat(dashboard): leaner filter indicator panel with wrapped text (#11592)
* feat(dashboard): leaner filter indicator panel with wrapped text

* remove summary from filter indicator panel
2020-11-09 14:23:43 -08:00
Kamil Gabryjelski
0c6aeef927
Fix datetime picker issues (#11621) 2020-11-09 14:13:27 -08:00
Grace Guo
b9284d3a3c
fix(dashboard): use server-side lastModifiedTime for co-edit check (#11614)
* fix: [dashboard][co-edit] Round client-side lastModifiedTime

* another try: server-side returns last_updated_time in save_dash response
2020-11-09 13:30:40 -08:00
Lily Kuang
dda95ed250
feat: annotation delete modal, bulk delete and empty state (#11540) 2020-11-09 11:25:16 -10:00
Jesse Yang
92a9acd5c9
fix: minor style touch on dashboards (#11570) 2020-11-08 21:26:56 -08:00
Jesse Yang
6ab03feed8
chore: clean up mountedTab (#11569) 2020-11-08 21:09:27 -08:00
adam-stasiak-polidea
24ba5301d1
Fixed unstable test (#11583) 2020-11-08 17:53:43 -08:00
Kasia Kucharczyk
ea0abbffb4
fix: extended droppable area on the top of dashboards (#11525)
* Extended droppable area on the top

* Empty dashboard detects almost whole area to place first element
2020-11-08 17:35:39 -08:00
dependabot[bot]
849e7e9668
build(deps-dev): bump less from 3.9.0 to 3.12.2 in /superset-frontend (#11597)
Bumps [less](https://github.com/less/less.js) from 3.9.0 to 3.12.2.
- [Release notes](https://github.com/less/less.js/releases)
- [Changelog](https://github.com/less/less.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/less/less.js/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-08 10:02:54 -08:00
Evan Rusackas
d86117331d
chore: cleaning out old deckgl controls (#11564) 2020-11-06 22:41:08 -08:00
Phillip Kelley-Dotson
d8373f2bb9
chore(home-screen): fixes for loading states, flicker issue, and reduction of api calls (#11557)
* fixes for loading states, flicker issue, api calls

* fix filter bug

* add high res images

* bug fixes for cards and face pile, change imgs to svgs, and address comments

* update from comments

* add stopprop

* fix tests

* add liscenses

* remove unused type

* fix types

* add license

* fix lint
2020-11-06 19:35:13 -08:00
Kamil Gabryjelski
a6bf95e30b
fix: Filter and Metric popovers not closing after clicking Save (#11607)
* Fix filter popover not closing

* Fix metric popover not closing

* Add e2e tests
2020-11-06 14:23:12 -08:00
Evan Rusackas
32e52e94e0
style: Wrap chart titles again (#11602)
* style: letting chart titles wrap again

* deleting comment
2020-11-06 11:10:45 -08:00
ʈᵃᵢ
79a6e9b0d2
fix(dashboard): order charts by changed_on (#11594) 2020-11-06 11:02:03 -08:00
Kamil Gabryjelski
6d5d92a6fe
fix: Issues with filters and metrics popovers (#11578)
* Fix bugs in AdhocFilterEditPopover

* Fix bugs in AdhocMetricEditPopover

* Remove handleMultiComparatorInputHeightChange function

* Fix tests
2020-11-05 20:00:43 -08:00
Kamil Gabryjelski
1490f3074d
refactor: Replace react-bootstrap MenuItems with Antd Menu (#11554)
* Refactor SliceHeaderControls

* Refactor DisplayQueryButton

* Fix duplicate keys

* Refactor SliceAdder

* Move css from styles to Emotion

* Fix e2e test
2020-11-05 13:30:03 -08:00
Kasia Kucharczyk
091432ea8e
Changed top overflow for charts. (#11579) 2020-11-05 11:35:41 -08:00
dependabot[bot]
094360392b
build(deps): bump @emotion/core in /superset-frontend (#11518)
Bumps [@emotion/core](https://github.com/emotion-js/emotion) from 10.0.28 to 10.0.35.
- [Release notes](https://github.com/emotion-js/emotion/releases)
- [Changelog](https://github.com/emotion-js/emotion/blob/master/CHANGELOG.md)
- [Commits](https://github.com/emotion-js/emotion/compare/@emotion/core@10.0.28...@emotion/core@10.0.35)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-05 10:26:15 -08:00
dependabot[bot]
39a4a62940
build(deps-dev): bump @storybook/addon-essentials in /superset-frontend (#11573)
Bumps [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/addons/essentials) from 6.0.13 to 6.0.28.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.0.28/addons/essentials)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-05 10:25:10 -08:00
dependabot[bot]
52145f8683
build(deps): bump core-js from 3.2.1 to 3.6.5 in /superset-frontend (#11522)
Bumps [core-js](https://github.com/zloirock/core-js) from 3.2.1 to 3.6.5.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.2.1...v3.6.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-04 22:37:53 -08:00
adam-stasiak-polidea
280ba95e46
chore: Cypress dashboard list selectors refactor (#11314)
* cypress selectors refactor in dasboard list tests

* fixed tests

* fixes after rebase
2020-11-04 14:34:21 -08:00
Kamil Gabryjelski
3e35ddd609
refactor: Replace react-bootstrap MenuItems with Antd Menu (#11555)
* Remove MenuItem from SubMenu

* Fix tests

* Refactor PopoverDropdown

* Refactor Button

* Remove redundant Menu import
2020-11-04 14:32:38 -08:00
David Aaron Suddjian
ef7087adb6
fix(dashboard): properly unset mountedTab in reducer (#11558) 2020-11-04 14:27:32 -08:00
Beto Dealmeida
d999802795
Front end for VERSIONED_EXPORT (#11559) 2020-11-04 14:22:12 -08:00
Kamil Gabryjelski
128ddfabb6
fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs (#11445)
* Fix paste not working in Metrics and Filter inputs

* Use noOp instead of empty function

* Use default Select component instead of OnPasteSelect

* Revert onPaste override
2020-11-04 13:48:48 -08:00
Kamil Gabryjelski
ad98981d9d
refactor: Replace react-bootstrap MenuItems with Antd Menu (#11487)
* Remove MenuItem from CopyToClipboard

* Refactor DateFilterControl

* fixup! Remove MenuItem from CopyToClipboard

* Remove console log

* Refactor LanguagePicker

* Refactor HeaderActionsDropdown

* Remove dir with Menu component

* Add imports to common/components/index

* Fix after rebase
2020-11-04 13:47:25 -08:00
Moriah Kreeger
69810170f7
style: database modal updates (#11311) 2020-11-04 11:03:39 -08:00
Moriah Kreeger
094359cc5b
fix: add sort option to filters, sort chart list filter options (#11370) 2020-11-04 11:02:33 -08:00
Kamil Gabryjelski
937f9ca277
refactor: Replace react-bootstrap dialogs with Antd dialogs (#11527)
* Refactor Dialogs in dashboard properties modal

* Refactor Dialogs in explore properties modal

* Refactor dialogs in DatasourceModal

* Refactor dialogs in ExploreResultsButton

* Remove react-bootstrap-dialog from ExploreCtasResultsButton

* Remove react-bootstrap-dialog dependency

* Remove unnecessary functions from Modal

* Bump antd version to fix a bug

* Fix unit tests

* Fix e2e test

* Change antd version to 4.5.4 to fix tests

* Reenable all tests in control

* Another version bump to fix tests
2020-11-03 22:07:21 -08:00
Kamil Gabryjelski
15111db6c5
refactor: Use Antd Menu in Menu component (#11528)
* Menu dropdown refactored

* MenuObject refactored

* Fix unit tests

* Style menu

* Use theme variables
2020-11-03 16:19:15 -08:00
Moriah Kreeger
536346ff5e
feat: annotation layers delete logic + linking w/ annotation view (#11530) 2020-11-03 13:01:20 -08:00
Lily Kuang
eef4809978
feat: annotation edit modal with antd datepicker (#11500) 2020-11-03 12:59:13 -08:00
ʈᵃᵢ
edb9619731
refactor: reduce number of api calls needed to fetch favorite status for charts and dashboards (#11502) 2020-11-02 21:26:14 -08:00
Jesse Yang
fac29f9dff
refactor: rewrite and enhance chart control withVerification (#11435)
* refactor: rewrite and enhance chart control withVerification

* Add toasts for failed messages; fixes popover render
2020-11-02 15:06:20 -08:00
David Aaron Suddjian
d7aa3d792b
fix(dashboard): multiple lines and indentation when editing json (#11501)
* multiple lines and indentation when editing json

* fix tests, address pr feedback

* remove json minification
2020-11-02 13:39:04 -08:00
Kamil Gabryjelski
a874b14a8a
refactor: Replace react-bootstrap Tabs with Antd Tabs in DashboardBuilder (#11160)
* Replace tabs in DashboardBuilder

* Fix tests

* Fix styling of anchor

* Fix

* Fix cypress test

* Fix tests

* Fix e2e tests

* Use data-tests

* Move tabs styles from superset.less to Emotion

* Restyle tabs in DashboardBuilder

* Test fix

* Fix styling
2020-11-02 13:31:55 -08:00
Hugh A. Miles II
6c6ded139b
fix: Update "View In SQL Lab" Flow to render source query from datasource object (#11476) 2020-11-02 11:44:20 -08:00
Jesse Yang
5d9448f3fe
feat: globally disable underscore for links in menu items (#11491) 2020-11-02 00:03:18 -08:00
Kamil Gabryjelski
19f2deb27f
refactor: Replace react-bootstrap Modals with Antd in Explore (#11389)
* VizTypeControl

* SaveModal

* explore/PropertiesModal

* Fix e2e tests

* Remove console logs

* Fix tests

* Fix test

* Fix e2e test

* Remove unnecessary fragment

* Fix e2e tests

* Fix e2e test
2020-11-01 23:04:53 -08:00
Maxime Beauchemin
e3b6dbe62d
chore: run 'npm audit fix', bump react-syntax-highlighter (#11512) 2020-10-31 15:21:46 -07:00
Kamil Gabryjelski
55a3404b71
refactor: Replace react-bootstrap tabs with Antd tabs (#11118)
* Replace tabs in BuilderComponentPane

* Replace tabs in ControlPanelsContainer

* Replace tabs in AdhocMetricEditPopover

* Replace Tabs in DatasourceEditor

* Replace tabs in AdhocFilterEditPopover

* Replace tabs in DateFilterControl

* Bug fix

* Change Tab styles

* Fix tests

* Fix cypress tests

* Lint fix

* Fix tests

* Change Tabs style in ControlPanelsContainer

* Change tabs content height

* Lint fix

* Add data test

* Fix e2e test

* Move Tabs file to separate dir

* Fix after rebase

* Fix e2e tests

* Fix after rebase
2020-10-30 22:05:31 -07:00
Moriah Kreeger
01ddbd0697
feat: annotation layers modal + filters (#11494) 2020-10-30 15:51:46 -07:00
dependabot[bot]
5d9560c408
build(deps-dev): bump node-fetch in /superset-frontend (#11485)
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-10-30 14:19:44 -07:00
dependabot[bot]
fe3fdd27e7
build(deps): bump lodash in /superset-frontend/cypress-base (#11483)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-10-30 14:19:09 -07:00
Phillip Kelley-Dotson
cd1d89b2b1
fix: import for moment in ActivityTable (#11506) 2020-10-30 13:20:10 -07:00
Erik Ritter
ca40877640
feat: add certifications to tables (#11450) 2020-10-30 11:28:01 -07:00
Phillip Kelley-Dotson
f7051eaade
feat: home screen mvp (#11206)
* step 1: broken stuff!

* first steps

* more adding and slicing

* step 1: broken stuff!

* can now filter dashboards/charts for "Edited" tabs (filter by changed_by o_m)

* more updates

* update recent card

* add icon

* Adding Expand Icon to Collapse component

* more updates

* clean up code

* remove lock file

* remove consoles

* fixing subnav button height shift

* lil' ascii arrows

* update branch

* update test part 1

* remove consoles

* fix typescript

* add images and update emptystate

* add changes

* update chart card

* fix css issues from rebase

* add suggestions

* more changes

* update tests and clear typescript errors

* Update superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* update from comments

* more updates..

* fix rebase

* fix pesky type errors

* test fixes

* lint fix

* Update superset-frontend/spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/views/CRUD/welcome/EmptyState.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/components/Menu/SubMenu.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/components/ListViewCard/index.tsx

Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>

* Update superset-frontend/src/components/ListViewCard/index.tsx

Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>

* add suggestions

* fix lint

* remove unused code

* toast getrecentActivityobjs

* add some suggestions

* remove types for now

* cypress fix

* remove unused type

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>
2020-10-29 21:59:31 -07:00
Jesse Yang
93693690a3
feat: disable save button when saving datasource (#11493) 2020-10-29 16:13:47 -07:00
Beto Dealmeida
1d9d905497
fix: prevent race condition when canceling query (#11449) 2020-10-29 14:34:58 -07:00
ʈᵃᵢ
f918ca14aa
fix(datasets): add custom filter for virtual datasets based on sql attribute (#11452) 2020-10-29 13:11:33 -07:00
Kasia Kucharczyk
ed3dca420f
Added z index to resizible char (#11456) 2020-10-29 10:39:35 -07:00
Jesse Yang
e0503408de
feat(explore): change save button text when users cannot override (#11281) 2020-10-29 09:41:29 -07:00
Evan Rusackas
68d493ebf5
fix: dashboard tab only shows move cursor when editing (#11480) 2020-10-29 00:35:32 -07:00
Evan Rusackas
e024267447
fix: Unwinds icon fallout that came along with filters PR (#11474)
* Unwinds icon revamp that came along with filters PR.

* cleanup/linting

* removing unused import
2020-10-28 19:44:39 -07:00
David Aaron Suddjian
18658f45be
feat(dashboards): Filter status indicators (#10936)
* Initial commit of new filters badge.

* refactor applied/rejected filters code

* finished filter indicators

* filter badge tested

* unnecessary imports

* formatting and types

* fixes

* license

* code quality tweaks

* state management for showing focused filter scope

* clean up filter key extraction code

* remove unnecessary styles

* temp css to demonstrate highlighting

* fix focused filter logic

* no more color badges

* new toys for highlighting dash components (#11144)

* tweak style for the filter chart when filter is focused

* style: Filters p0 css2 (#11151)

* nixing background tweak

* src paths

* another quick theme color

* src paths, adjusting pill icon color, changing icons, showing applied/busted counts

* linting stuff

* fixing and tweaking tests

* show filter indicator when filters are not active

* chart title bar cleanup

* open the right panel when popover opens

* unused import

* fix EditableTitle tests

* margin on dashboard header

* show the chart dropdown menu

* fix blur filter breaking dropdowns

* style tweak - no pointer events when irrelevant charts are blurred

* fix box shadow on filter highlight

* it's an array

* attempt fixing e2e

* style: filters p0 icon churn (#11215)

* new filters icon

* icon styling

* bigger icons in list views

* better sizing of table actions and favStars

* more icon sizing...

* fixing more button size jankiness

* linting

* Filters performance (#11255)

* fixing time filter "ok" button

* making unset filter menu collapsible

* sort alphabetically

* fix highlighting when removing items

* try a flex layout (for browser render perf)

* more specific transitioning

* temp: comment out some code as a test

* temp: comment out more code

* temp: remove possibly expensive computations from ChartHolder

* Revert "temp: comment out some code as a test"

This reverts commit 309b880e90.

* Revert "temp: comment out more code"

This reverts commit 64c88b2cba.

* Revert "temp: remove possibly expensive computations from ChartHolder"

This reverts commit 37ce0214f0.

* experiment: upgrade react-select to v3

* Revert "experiment: upgrade react-select to v3"

This reverts commit c3972ba486.

* fix the damn problem

* remove code used for testing purposes

* awful hack to avoid adding a class to a container

* approaching infinity... and not beyond!

* fix ref forwarding

* add theme to tests as necessary

* fix(extra-filters): add logic for identifying applied extra filters (#11325)

* fix: use dashboard id for stable cache key (#11293)

* fix: button translations missing (#11187)

* button translations missing

* blank space before text

* feat: update time_compare description and choices (#11294)

* feat: update time_compare description and choices

* Update sections.jsx

* fix(extra-filters): add logic for identifying applied extra filters

* lint

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* address design feedback

* slight tweak to panel logic, keep panels open that user has opened

* rearrange code to be more graceful

* fix: bump superset-ui/core (#11385)

* use is_dttm instead of is_temporal

* types, names

* only show unset filter panel if there are unset filters

* fix highlighting the filter control

* fix filterbox layout

* translations

* fix cypress

* actually add the test attribute

* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* formatting

* add link comment to hack

* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* stop importing lodash

* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* skip broken test

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* adjust colors of titles

* linting

* no indicators when chart is loading

* support all time fields

* fix lock file

Co-authored-by: Natalie Ruhe <natalie@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2020-10-28 15:46:24 -07:00
Moriah Kreeger
e9dba18466
feat: annotation layers CRUD list view (#11432) 2020-10-28 15:45:07 -07:00
Kamil Gabryjelski
52294c836a
refactor: Replace react-bootstrap Modals with Antd in Datasource (#11390)
* ChangeDatasourceModal

* DatasourceModal

* DeleteModal, AddDatasetModal

* Fix tests

* Remove unused file

* Fix e2e tests

* Fix test

* Remove it.only

* Fix after rebase

* Fix e2e tests

* Fix data-test in modal

* Lint fix
2020-10-28 14:42:13 -07:00
Ville Brofeldt
e230865216
chore(chart-data): add annotations and url params to chart data schema (#11393)
* chore(chart-data): add annotations to chart data schema

* bump superset-ui packages

* xit flaky cypress tests
2020-10-28 23:41:39 +02:00
Lily Kuang
e5e35634de
feat: annotations list CRUD view (#11446)
* annotations list CRUD view

* comment out modal

* update test

* fix lint
2020-10-28 12:19:50 -07:00
adam-stasiak-polidea
894b94a345
enabled skipped tests in AdhocMetrics Cypress (#11455) 2020-10-28 10:06:16 -07:00
Kamil Gabryjelski
b2636f01bb
fix: Explore popovers issues (#11428)
* Fix spaces and comas not working in filter popover

* Fix popup not opening automatically

* Add e2e test

* Remove only from test

* Remove redundant test, add checking label content

* Add comments to e2e test

* Fix unit test

* Use destructuring

* Always open popup for functions and saved metrics, too

* Fix popover for adhoc metrics too

* Small refactor to consistency

* Refactor for consistency

* Remove redundant functions

* Test fix

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2020-10-28 09:38:52 -07:00
Evan Rusackas
eecabf9b2e
fix: a space adds the space. (#11401)
* fix: a space adds the space.

* linting. Ugh.
2020-10-27 23:47:42 -07:00
Evan Rusackas
68411677e9
fix: Fixing broken Cypress test (#11453)
* fixing bad data-test selector

* linting

* typo... because I got all excited.
2020-10-27 22:51:38 -07:00
Kamil Gabryjelski
155b5edec1
refactor: Use Antd Modals instead of react-bootstrap Modals (#11366)
* Make Modal responsive

* ErrorAlert

* OmniContainer

* dashboard/PropertiesModal

* Fix e2e tests

* Lint fix

* E2E test fix

* Fix test

* Use grid units

* Change padding to padding-left/right
2020-10-27 13:08:04 -07:00
adam-stasiak-polidea
a99d795eaf
chore: cypress selectors refactor in explore module (#11309)
* cypress selectors refactor in explore module

* added delay to typing to make test more stable

* fixed missing click
2020-10-27 13:01:45 -07:00
adam-stasiak-polidea
4bebf51453
chore: Cypress chart selectors refactor (#11312)
* cypress selectors refactor in chart list tests

* fixed wrong selector
2020-10-27 11:38:05 -07:00
David Aaron Suddjian
055781f4a9
fix filter highlighting (#11439) 2020-10-27 08:38:24 -07:00
Ville Brofeldt
ecdff724ea
feat: enable metadata sync for virtual tables (#10645)
* feat: enable metadata sync for virtual tables

* add migration and check for empty schema name

* simplify request

* truncate trailing column attributes for MySQL

* add unit test

* use db_engine_spec func to truncate collation and charset

* Remove redundant migration

* add more tests

* address review comments and apply templating to query

* add todo for refactoring

* remove schema from tests

* check column datatype
2020-10-27 07:58:38 +02:00
Ville Brofeldt
8575439f48
fix: is_temporal should be overridden by is_dttm value (#11429) 2020-10-27 07:22:27 +02:00
Kasia Kucharczyk
94e0f0cc2a
Moved css of inline inputs of DateFilterControl to css of FilterBox where it appears. (#11427) 2020-10-26 21:50:27 -07:00
Maxime Beauchemin
5b968e9651
fix: multiple issues with FilterPopover (#11412)
* fix: Custom SQL in FilterPopover

* Also fix #11394

* linting

* fix tests
2020-10-26 21:48:06 -07:00
adam-stasiak-polidea
df15a6fc51
Configured babel plugin for removing data-test from production code (#11327) 2020-10-26 21:16:02 -07:00
Hugh A. Miles II
fd8f4e9215
feat(explore): update the order of datasource dropdown menu (#11424) 2020-10-26 20:44:44 -07:00
Hugh A. Miles II
81f77fd28e
feat: hide datasource legacy based on featureflag (#11371) 2020-10-26 17:31:29 -07:00
ʈᵃᵢ
2227b13b52
fix: better error messages for dashboard properties modal (#11382) 2020-10-26 16:36:37 -07:00
ʈᵃᵢ
59885c4dea
fix: saved query list sort by database (#11430) 2020-10-26 16:36:03 -07:00
ʈᵃᵢ
910791b00b
fix: better error message for chart properties modal (#11381) 2020-10-26 13:33:19 -07:00
Evan Rusackas
af337b9e5a
Let the header wrap! (#10724) 2020-10-26 13:15:16 -07:00
Kamil Gabryjelski
894ca3c09b
refactor: Use Modals from Antd instead of react-bootstrap (#11330)
* Refactor ModalTrigger to use antd modal

* Refactor a few components

* dynamic width

* Fix unit tests

* Use i18n for button text
2020-10-26 11:20:10 -07:00
Kasia Kucharczyk
604a519d8b
fix: keeping Markdown content while resizing window on Dashboard (#11392)
* Fix: keeping markup content while resizing it

* Added bind and fixed linter

* Added resize case in Markdown editor to cypress test
2020-10-26 11:12:49 -07:00
Kasia Kucharczyk
ba314c0f6f
Moved frame from below to currently focused window (#11423)
Thanks for the fix!
2020-10-26 11:11:51 -07:00
Kamil Gabryjelski
6acae9ab6d
refactor: Replace usages of reactable in TimeTable (#11239)
* Refactor TimeTable to use react-table

* Fix import

* Refactor TimeTable into functional component
2020-10-26 10:25:41 -07:00
Jesse Yang
ac498ddd23
chore: upgrade TypeScript (3.8.3 -> 4.0.3) (#11421)
* chore: upgrade TypeScript (3.8.3 -> 4.0.3)

* Refactor the button component
2020-10-25 22:01:41 -07:00
Maxime Beauchemin
0ab15373fa
style: fix labels vertical align (#11415)
* style: fix labels vertical align

* addressed comments

* just adding the space for now

* fix timer
2020-10-25 17:55:22 -07:00
Jesse Yang
70ea7ae776
fix: error handling for webpack proxy (#11420) 2020-10-25 17:14:56 -07:00
Jesse Yang
8aecffd83b
refactor: typing for explore Control and messageToasts (#11416) 2020-10-24 21:40:36 -07:00
ʈᵃᵢ
d02a61f21c
feat(dashboard): fetch charts by owners instead of created_by (#11336) 2020-10-24 14:43:20 -07:00
adam-stasiak-polidea
f2c89af83f
chore: Fixed skipped cypress test - refresh dashboard function (#11375)
* Fixed skipped cypress dashboard/controls.test.js and fixed MenuItem setting state to 'loading' while refreshing

* fixed wrong cypress command in test
2020-10-24 11:29:30 -07:00
Evan Rusackas
efdda8b69e
chore: Button cruft cleanup (#11342)
* toggleSchedule

* cleaning up run query button

* removing unnecessary (subtle!) style overrides

* bulk action classname to button style prop

* nixing btn-primary

* nixing cancelQuery class

* togglesave

* nixing autocomplete class

* linting

* nixing button classes of 'ok' and 'reset'

* unoing diagnostic test

* begrudgingly adding an m-r-3 class... for now

* this is not a class to worry about

* test fixes for limit control

* updating TODO notes, calling it a day for now.

* gah... copy paste error.
2020-10-23 10:42:29 -07:00
Kamil Gabryjelski
ad88a06d61
refactor: Use Antd Dropdown instead of react-bootstrap in DatasourceControl (#11395)
* Create Tooltip component

* Refactor DatasourceControl

* Bug fix

* Lint fix

* E2E test fix

* Move menu item keys to constants

* Remove LESS file

* Test fix

* Test fix

* Lint fix
2020-10-23 09:08:35 -07:00
Lily Kuang
93d9bd9a04
fix dataset editor for saving schema (#11396) 2020-10-22 21:59:04 -07:00
Evan Rusackas
d64260fc0e
fix: long labels now truncate with ellipsis (#11400) 2020-10-22 18:35:37 -07:00
Elizabeth Thompson
43b92b220f
fix: dashboard edit/save errors (#10834)
* use conditional operator for lookup

* editing dashboard title should update after save

* uncomment test

* fix json metadata save

* json metadata color scheme should overwrite state

* test's functionality is no longer applicable

* add lastModifiedTime to DashboardInfo
2020-10-22 14:33:22 -07:00
Kamil Gabryjelski
30c71fd794
refactor: Replace react-bootstrap tabs with Antd tabs on Profile (#11211)
* Create styled Antd Tabs and Dropdown

* Replace Tabs in Profile view

* Change some hard coded variables to theme

* Lint fix
2020-10-22 14:19:37 -07:00
Kamil Gabryjelski
dc5e5a978b
refactor: Replace usages of reactable in TableLoader (#11240)
* Refactor TableLoader to use react-bootstrap

* Remove unnecessary css classes

* Fix import

* Fix styling for no data

* Refactor TableLoader into functional component

* Convert TableLoader to typescript
2020-10-22 14:00:02 -07:00
Jesse Yang
04ee4a2d08
build: let webpack proxy server handle more content encoding (#11376) 2020-10-22 13:25:17 -07:00
Maxime Beauchemin
64b5aae6bc
style: improve the "Create New Chart" screen's usability (#11383)
* style: make disabled buttons more readable

* making more of a CTA for VizControl
2020-10-22 10:16:58 -07:00
Daniel Vaz Gaspar
85e28dd04c
perf(api): improve API info performance (#11346) 2020-10-22 08:55:13 +01:00
Evan Rusackas
6c5da18926
removing outlines on a few key elements (#11372) 2020-10-21 22:02:54 -07:00
Moriah Kreeger
a2a614d760
feat: CSS Templates List Actions (#11271) 2020-10-21 20:32:59 -07:00
Kamil Gabryjelski
9dfe9aef39
Fix overflowing tabs (#11367) 2020-10-21 20:10:52 -07:00
Maxime Beauchemin
69046f08d4
style(sqllab): wrap text in monospace db-provided error messages (#11354) 2020-10-21 17:35:20 -07:00
Maxime Beauchemin
6dd5d5cf26
style: make <Label/> not uppercase (#11355) 2020-10-21 17:29:28 -07:00
Evan Rusackas
6fe7b4a202
feat: adding feature flags to escape/hide html in markdown (#11340)
* utilizing feature flag for html escapement

* use src alias

* Feature flag to allow hiding of HTML tags

* strips js attr

* better feature flag naming

* simplifying

* Adding comments to new feature flags

* shorter comment, because pylint,

* pedantic change to get black to format a file
2020-10-21 15:07:27 -07:00
ʈᵃᵢ
225c905bd5
fix(listview): hide actions column if no actions are allowed (#11337) 2020-10-21 09:27:48 -07:00
Evan Rusackas
cae54ac00e
style: using correct + icon on New Query button (#11353)
* style: using correct + icon on New Query button

* non-meaningful whitespace removed.
2020-10-20 22:44:11 -07:00
Maxime Beauchemin
796a2a6924
fix: error around latest partition in BigQuery (#11274)
* fix: error around latest partition in BigQuery

* lint

* Going with a backend-first approach

* fix test

* add an extra test
2020-10-20 21:34:46 -07:00
Maxime Beauchemin
c360413fc2
style(menu): clean up right menu - leaving only "Settings" (#11227)
* style(menu): clean up right menu - leaving only settings

* bring pre-commit back

* fix frontend tests

* pre-commit

* re-introduce subtle '+'
2020-10-20 21:33:28 -07:00
Kamil Gabryjelski
3a0fcdacd3
Fix tabs switching in SouthPane (#11343) 2020-10-20 14:24:27 -07:00
Lily Kuang
6f3d4c131f
feat: css template add/edit modal (#11296) 2020-10-20 12:15:39 -07:00
Lily Kuang
9f8d0e7a06
fix: update table_name and schema on dataset editor (#11218)
* fix dataset editor for updating table_name and schema

* update test

* remove table_name from restrict list

* fix pylint

* fix cypress test

* fix test
2020-10-20 09:38:57 -07:00
adam-stasiak-polidea
55ae259b13
chore: Dashboard cypress refactor (#11280)
* moved dashboard tests to use data-test attributes

* linter

* fix for unstable save test
2020-10-19 21:36:20 -07:00
Kamil Gabryjelski
9266f0a4a8
refactor: Replace usages of reactable in ChangeDatasourceModal (#11241)
* Refactor ChangeDatasourceModal to use react-table

* Fix import

* Moved columns declaration out of component scope
2020-10-19 20:44:21 -07:00
Kamil Gabryjelski
901a42b1df
refactor: Replace usages of Popover from react-bootstrap with Antd (#11163)
* New popover component

* LimitControl

* Moar components migrated

* TimeSeriesColumnControl

* Hotkeys

* ColorPicker

* FilterBoxItemCOntrol

* AdhocFilterEditPopover

* AdhocMetric

* AnnotationLayerControl

* DateFilterControl

* Tests fix

* Fix linting issue

* Fix tests

* Bug fix

* Test fix

* Remove Antd global stylesheet

* Fix linting

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test
2020-10-19 20:42:33 -07:00
ʈᵃᵢ
4208ca76e0
refactor: replace AvatarIcon instances with FacePile (#11279) 2020-10-19 20:23:16 -07:00
Kamil Gabryjelski
735123d1f5
refactor: Refactor QueryTable to use react-table (#11216)
* Refactor QueryTable to use react-table

* Fix lodash import

* Fix tests

* Fix imports and QuerySearch styles

* Update superset-frontend/src/SqlLab/components/QuerySearch.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/SqlLab/components/QuerySearch.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Lint fix

* Refactored QueryTable into functional component

* Remove calculating content height

* Lint fix

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-10-18 22:32:13 -07:00
Kamil Gabryjelski
31e4a90440
Fix overflowing tab's styling in TabbedSqlEditors (#11303) 2020-10-16 14:23:21 -07:00
Grace Guo
8863c939ad
fix: should update last_modified_time in client-side after save dash (#11305) 2020-10-16 10:54:35 -07:00
Yongjie Zhao
afee008a10
fix CTAS and CVAS buttons invisible (#11300) 2020-10-16 08:02:39 -07:00
Erik Ritter
9856f99620
feat: update time_compare description and choices (#11294)
* feat: update time_compare description and choices

* Update sections.jsx
2020-10-15 21:28:09 -07:00
rubenSastre
4f0a06dda5
fix: button translations missing (#11187)
* button translations missing

* blank space before text
2020-10-15 21:27:26 -07:00
Jesse Yang
a720bba40e
chore: upgrade vis plugins npm packages (#11272)
https://github.com/apache-superset/superset-ui/compare/v0.15.4...v0.15.8
2020-10-15 10:41:10 -07:00
Kamil Gabryjelski
9aef9c5764
fix: Fix styling in SqlLab when tabs overflow (#11287)
* Fix styling in SqlLab when tabs overflow

* Use theme variables
2020-10-15 08:38:13 -07:00
adam-stasiak-polidea
fc03549299
chore: Added data-test attributes for testing (#11254)
* Added data-test attributes for testing

* fixed incorrect naming change

* review changes
2020-10-14 16:12:01 -07:00
ʈᵃᵢ
a6224a2ed2
fix(query search): use new api to fetch users (#11260) 2020-10-14 13:52:48 -07:00
Erik Ritter
fc74b5d4a2
Revert "fix: keep placeholder in multivalue select when a value exists (#11181)" (#11270)
This reverts commit 31cc4155b7.
2020-10-14 12:58:58 -07:00
Kamil Gabryjelski
820fa473a7
refactor: Implement TableView component (#11217) 2020-10-14 11:15:34 -07:00
Ville Brofeldt
2a4ca9fa98
fix(crud): set default extra value (#11262) 2020-10-14 19:05:20 +03:00
Lily Kuang
cd7392e618
update dashboard edit modal (#11258) 2020-10-13 20:50:02 -07:00
Jesse Yang
eb389ba8d4
build: update webpack for npm linking plugins (#11253) 2020-10-13 16:54:06 -07:00
Elizabeth Thompson
31cc4155b7
fix: keep placeholder in multivalue select when a value exists (#11181) 2020-10-13 13:45:31 -07:00
Grace Guo
88af85ac53
fix: show TIME COLUMN options in dashboard (#11210)
* fix: show TIME COLUMN options in dashboard

* add unit test
2020-10-12 21:43:30 -07:00
Grace Guo
4f4367edf3
feat: prevent co-edit dashboard collision (#11220)
* feat: prevent co-edit dashboard collision

* fix comments
2020-10-12 17:58:32 -07:00
Maxime Beauchemin
ae87b0c767
fix: questioning a few lines that force an ORDER clause (#11153)
* draft: questioning a few lines that force an ORDER clause

* sorting by main metric DESC by default
2020-10-12 14:53:37 -07:00
Lily Kuang
8e58730092
fix(dataset): update user list endpoint (#11221) 2020-10-12 17:11:00 +01:00
Yongjie Zhao
16d36a776c
fix(cypress): table viz failed to run in postgres12 (#11230) 2020-10-11 11:28:13 -07:00
Kamil Gabryjelski
b071344531
refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab (#11212)
* Create styled Antd Tabs and Dropdown

* Replace Tabs in SqlLab
2020-10-09 23:11:25 -07:00
Moriah Kreeger
a6fc3d2384
feat: CSS Templates List (#11189) 2020-10-09 16:32:31 -07:00
ʈᵃᵢ
7b0dabd7aa
style(listview): various changes to get closer to SIP-34 designs (#11101) 2020-10-09 13:06:26 -07:00
John Bodley
2a447ff466
Revert "refactor: Replace react-bootstrap tabs with Antd tabs (#11090)" (#11194)
This reverts commit 4fd993c4e0.

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-10-07 16:21:24 -07:00
Lily Kuang
a0713938b3
fixed undefined names error (#11180) 2020-10-06 22:11:16 -07:00
Moriah Kreeger
21c8d672a8
fix: save query modal/button styling + convert to ant-d modal (#11164) 2020-10-06 16:55:17 -07:00
Lily Kuang
2eb400a2fc
chore: remove SIP_34_SAVED_QUERIES_UI feature flag (#11175) 2020-10-06 15:13:41 -07:00
Maxime Beauchemin
c8a5dec84d
style(dashboard): minor improvements to chart context menu (#11170)
Bumping "Explore/edit chart" as the first option. Getting rid of the
old "edit chart properties" deprecated CRUD link
2020-10-06 12:55:13 -07:00
Maxime Beauchemin
f109f11ceb
style: fix too light form labels in DatabaseModal + DRY css (#11056)
eventually should be moved away from bootstrap and onto a DRY
ControlLabel component in our design system.
2020-10-06 12:51:00 -07:00
Maxime Beauchemin
b2af0c0e22
style(sqllab): make database errors more clear and render as monospace (#11075)
* style(sqllab): make database errors more clear and render as monospace

In SQL Lab, when a database error message is returned, generally because
of a user error in the SQL, it's identified as an "Unexpected Error" and
some of the text formatting of the error message (\n, spaces, tabs, ...)
are lost as they are rendered in html.

This PR identifies the error as a "Database Error", and renders like
more like a <pre>, using a monospace font.

* fix the build

* addressing comments

* addressed comments

* lint + removing cruft

* addressing comments
2020-10-06 12:50:38 -07:00
Grace Guo
13963acefb
fix: Fix Time Column dropdown for date filter (#11149) 2020-10-06 11:51:10 -07:00
Maxime Beauchemin
3d7b805755
chore: more 'datasource' -> 'dataset' renaming (#11055)
* chore: more 'datasource' -> 'dataset' renaming

* fix build

* explicitely setting disabled to false to avoid cypress confusion

* fix tests

* RAT
2020-10-05 20:04:17 -07:00
Lily Kuang
152315d0f4
feat: saved query preview modal (#11135) 2020-10-05 16:21:59 -07:00
Erik Ritter
3d76f81bf7
Revert "refactor: Remove usages of reactable from TimeTable (#11046)" (#11150)
This reverts commit f01b8a30f7.
2020-10-02 22:21:10 -07:00
Kamil Gabryjelski
07f87149e6
fix: Enable ESLint rule default-props-match-prop-types (#11058)
* Re-enable ESLint rule default-props-match-props-types

* Add cypress test for switching tabs

* fix

* Typo fix

* Test fix
2020-10-02 15:54:56 -07:00
Elizabeth Thompson
d95b7c2a73
fix: clean up prop type errors in jest tests (#11120) 2020-10-02 14:59:04 -07:00
Ville Brofeldt
662fb43350
fix(examples): missing expressions in birth_names (#11141)
* fix(examples): missing expressions in birth_names

* disable flaky tests
2020-10-02 23:47:38 +03:00
Kamil Gabryjelski
4fd993c4e0
refactor: Replace react-bootstrap tabs with Antd tabs (#11090)
* Replace tabs in profile

* Replace tabs in SouthPane

* Replace tabs in TabbedSqlEditors

* Add typing for dropdown

* Add license

* Remove isSelected

* Fixes

* Add data-test

* Fix test

* Remove unnecessary style

* Remove unnecessary style

* Tests fix

* Tests fix

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Tabs.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Remove inModal prop

* Remove inModal from storybook

* Move inline style to styled component

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-10-02 13:07:52 -07:00
Jesse Yang
53cd05d74a
perf(explore): render datasource details only when needed (#10924) 2020-10-02 12:15:06 -07:00
ʈᵃᵢ
269644d18e
style: override ace edit error icon (#11139) 2020-10-02 09:45:36 -07:00
Elizabeth Thompson
a4e1dc9c27
add info about case sensitive search (#11124) 2020-10-01 21:30:39 -07:00
ʈᵃᵢ
017e5acd14
style(listview): dynamic card size and grid spacing (#11111) 2020-10-01 15:44:42 -07:00
Maxime Beauchemin
5f55d94b9b
style: rename label 'table name'->'dataset name' (#11126) 2020-10-01 15:13:01 -07:00
Phillip Kelley-Dotson
07716ffd76
chore: refactor submenu's right nav to accept list of buttons (#11102)
* submenu right-nav button refactor

* undo changes

* fix lint

* fix test

* update pr with suggested changes and test

* fix lint

* use enum to define btn style props

* add suggestions

* update savedquery buttons
2020-10-01 15:05:49 -07:00
ʈᵃᵢ
7a72082d31
fix: Revert "Replace reactable with DataTable from superset-ui in QueryTable (#10981)" (#11125)
This reverts commit e93d92e8ac.
2020-10-01 10:06:22 -07:00
Maxime Beauchemin
c4d96f64ff
fix: SpatialControl popover won't open (#11127)
Recently a change related to emotion styling not properly working through
react-bootstrap's popover broke the SpatialControl.

This PR makes SpatialControl use antd's equivalent, and addresses the
issue as a result: emotion's styling context is preserved through
this superior popover.
2020-09-30 23:12:51 -07:00
Moriah Kreeger
e7a4265c30
feat: saved query list actions (#11109) 2020-09-30 18:18:34 -07:00
Lily Kuang
5b284e67eb
feat: add created by chart CRUD view (#11067) 2020-09-30 13:53:04 -07:00
Erik Ritter
fa5dab85c4
feat: more specific presto error messages (#11099) 2020-09-29 21:50:58 -07:00
Evan Rusackas
0409b12a55
style: fix secondary label border (#11100) 2020-09-29 14:15:18 -07:00
Moriah Kreeger
b8d616a9d2
feat: saved query list view + sort/filters (#11005) 2020-09-29 13:39:10 -07:00
Ville Brofeldt
80e395559d
fix: echarts timeseries groupby (#11103)
* fix: echarts timeseries groupby

* address review comment
2020-09-29 14:25:38 +03:00
Lily Kuang
8b458ac172
fix: double scroll bars on dataset editor (#11095)
* fix double scroll bar on dataset editor

* add table name to virtual tab
2020-09-28 19:28:27 -07:00
Lily Kuang
e337355162
refactor: table selector on dataset editor (#10914)
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
2020-09-28 11:16:03 -07:00
ʈᵃᵢ
1dc05d4c12
feat(charts): modify custom api filter to include more fields (#11054) 2020-09-28 10:18:34 -07:00
Kamil Gabryjelski
2fd8fca207
chore: Clean up some console warnings (#11061)
* Upgrade a few packages

* Update some prop types

* Update HTML

* Moar warning fixes

* Remove wrapper div
2020-09-28 09:43:21 -07:00
Kamil Gabryjelski
f01b8a30f7
refactor: Remove usages of reactable from TimeTable (#11046)
* Use ListView instead of reactable

* Refactor TimeTable

* Spark column width fix
2020-09-28 09:42:06 -07:00
Kamil Gabryjelski
a879622e07
refactor: Remove usages of reactable from AlteredSliceTag (#11012)
* Remove usages of reactable in AlteredSliceTag

* Fix tests

* Move mocked data to fixtures file

* Use optional chaining

* Remove default value, change a unit test logic

* Code review fixes
2020-09-28 09:41:08 -07:00
Maxime Beauchemin
046bd02d65
style: improve "Datasource & Chart Type" <Label>s (#10971)
* style: improve default <Label>

* fix name-shifting icon

* adding some styles to remove the inner drop shadow from the 'more' button

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-09-28 08:32:25 -07:00
Evan Rusackas
497d3f3910
fix: Adding timeout to flaky cypress test, to wait for animation to complete (#11074)
* adding timeout for animation

* 1s timeout
2020-09-27 20:08:21 -07:00
Evan Rusackas
cff034e2cf
chore: cleaning out unused code from utils (#11076)
* removing unused stuff (and some jquery) from utils.js

* linting
2020-09-27 20:08:05 -07:00
Maxime Beauchemin
7f1e4e441d
fix: surface connection error messages on the client (#11077)
* fix: surface connection error messages on the client

* typo

* lint
2020-09-26 16:09:40 -07:00
Yongjie Zhao
1493450a6f
fix(jest): using UTC mock date (#11079) 2020-09-26 14:53:41 -07:00
Evan Rusackas
23d62f37a6
removing unused component (#11072) 2020-09-25 23:02:01 -07:00
Evan Rusackas
8cba1c823d
changing to the correct hex color (#11073) 2020-09-25 21:09:59 -07:00
Maxime Beauchemin
8e6f7d6598
style: remove unecessary padding (#11071) 2020-09-25 17:22:46 -07:00
Moriah Kreeger
374b06b4dd
fix: database list checkboxes (#11068) 2020-09-25 16:28:22 -07:00
Evan Rusackas
eeeb21077d
feat: adding all icons from the design system to the codebase (#11033)
* error -> error-solid

* warning -> warning-solid

* all the new icons mixed in!

* card-view -> card_view

* circle-check-solid -> circle_check_solid

* corrected circle-check to new name and correct (stroke) icon

* sort-asc/desc -> sort_asc/desc

* databases -> database

* compass -> nav_explore

* pencil -> edit-alt

* more pencil migrations

* easy list view rename

* star -> favorite (changed in Figma)

* removing deprecated icon

* renaming icon to mach figma

* More -> More Horiz

* forgot to change this when ranming the file

* updating some icon names in use

* adding hella icons

* fixing errant viewboxes

* removing dropdown-arrow in favor of triangle-down

* adding key to storybook map.

* fixing icon component reference

* tweaks to fave star styling to support revised icon

* fixing a bad icon inclusion

* missed a license

* touchup to virtual dataset... will tweak later.

* e2e fix

* linting
2020-09-25 14:49:30 -07:00
Erik Ritter
052d7a0a3e
fix: sql lab autocomplete width (#11063) 2020-09-25 10:13:21 -07:00
Evan Rusackas
d056e3dfd3
clickable labels have outlines, storybook shows them (#11034) 2020-09-24 20:50:44 -07:00
Srini Kadamati
66e49807ef
fixed routes for customer in docs (#11052) 2020-09-24 20:43:03 -07:00
Grace Guo
3467d2d8d6
Revert "style: fix checkbox color (#10970)" (#11051)
This reverts commit e4e78b66fa.
2020-09-24 16:53:02 -07:00
Lily Kuang
ea105bc23b
feat: add "created by" to dashboard CRUD view (#11030) 2020-09-24 14:33:55 -07:00
Grace Guo
f99753a800
Revert "ESLint: Re-enable rule default-props-match-prop-types (#10868)" (#11050)
This reverts commit 9f01a7fdf8.
2020-09-24 12:33:38 -07:00
ʈᵃᵢ
eded51b2f8
feat(saved_queries): add custom api filter for all string & text fields (#11031) 2020-09-24 11:05:25 -07:00
Grace Guo
8e9b0b3f11
fix: dashboard edit button (again) (#11029) 2020-09-23 15:42:06 -07:00
Maxime Beauchemin
dc76a2688e
style(explore): use tertiary button against gray background (#11011)
"primary" style buttons seem to expect a white background and really
look muted against the gray background. Using "tertiary" style button makes
things much better.

Eventually we may reconsider the layout and gray background and go back
to secondary, but for now this makes these important pop much more
2020-09-23 11:44:39 -07:00
Grace Guo
0409393a4e
fix: [dashboard] should not show edit button when user has no edit permit (#11024) 2020-09-23 10:55:32 -07:00
Jesse Yang
7549dad12d
fix: timer component, fixes #10849, closes #11002 (#11004) 2020-09-23 10:53:24 -07:00
ʈᵃᵢ
345fe07d64
fix: menu shows a 0 when there are not settings (#11009) 2020-09-23 09:22:45 -07:00
Lily Kuang
02ab5cc644
fix: Add Item Overflow on Dataset Editor (#10983)
* move add item button to the top

* fix cypress

* fix cypress
2020-09-22 22:19:41 -07:00
Beto Dealmeida
d992c306c2
Bring back import menu (#11007) 2020-09-22 19:32:44 -07:00
ʈᵃᵢ
0d1f6119a6
feat(listview): feature flag config to set default viewing mode (#10986) 2020-09-22 18:01:19 -07:00
Jesse Yang
220c410df4
build: add react-hooks linting (#11006)
Fixed a couple of criticle errors and left the warnings as is (mostly
from react-hooks/exhaustive-deps).

Let's fix the warnings in future PRs as sometimes unexhaustive deps
are intentional.
2020-09-22 15:09:22 -07:00
Kamil Gabryjelski
e93d92e8ac
Replace reactable with DataTable from superset-ui in QueryTable (#10981)
* Replace reactable with DataTable from superset-ui in QueryTable

* Fix tests

* Fix pagination

* Fix tests
2020-09-22 13:24:30 -07:00
Kamil Gabryjelski
9f01a7fdf8
ESLint: Re-enable rule default-props-match-prop-types (#10868)
* Re-enable rule default-props-match-prop-types

* Restore default props and remove isRequired

* Remove unused props
2020-09-22 13:17:41 -07:00
Ville Brofeldt
a9eab33d64
feat: add ECharts Pie chart (#10966)
* feat: introduce echarts pie chart

* lint

* remove viz.py shim

* remove tests

* fix cypress test

* fix test
2020-09-22 19:27:40 +03:00
Maxime Beauchemin
3be8bdad9a
docs: add gallery screenshot & link in README (#10988)
* docs: add gallery screenshot & link in README

* deallowing large files
2020-09-21 22:48:55 -07:00
Evan Rusackas
193796ca16
adding filters back that caused issues (#10989) 2020-09-21 19:12:34 -07:00
adam-stasiak-polidea
dc893fe1b3
chore: selectors refactor in SQLLab test suite (Cypress) (#10944)
* changed selectors for not skipped tests in sqllab suite

* linter fixes

* linter fixes
2020-09-21 15:49:44 -07:00
Kamil Gabryjelski
a8f5029cb1
ESLint: Remove ts-ignore comments (#10933)
* Upgrade json-bigint, add @types/json-bigint to deps

* Upgrade react-bootstrap-dialog

* Fix ts-ignore

* Fix ts-ignore

* Fix ts-ignore

* Upgrade react-syntax-highlighter, fix ts-ignore

* Fix ts-ignore

* Fix ts-ignore in styles.tsx

* Wrap Input in div to pass onPaste

* Change esm to cjs imports for highlighter to fix tests

* Add null checks
2020-09-21 15:47:33 -07:00
Maxime Beauchemin
e4e78b66fa
style: fix checkbox color (#10970)
* style: fix checkbox color

* lint

* wrap test into theme
2020-09-21 13:12:12 -07:00
Moriah Kreeger
4aa53244c7
fix: update the time filter for 'Last Year' option in explore (#10829)
* Update explore time filter ranges

* rm console statements

* only update moment calculation for years

* tests

* add open/close test
2020-09-21 11:39:11 -07:00
Kamil Gabryjelski
4835d3b0a2
ESLint: Re-enable rule no-access-state-in-setstate (#10870)
* Re-enable rule no-access-state-in-setstate

* Move accessing event values out of async functions
2020-09-20 23:48:23 -07:00
Kamil Gabryjelski
557a303cc5
ESLint: Enable rule no-named-as-default (#10879)
* Enable rule no-named-as-default

* Fix wrong import
2020-09-18 13:41:01 -07:00
Kamil Gabryjelski
91fd06e093
ESLint: Remove ts-ignore (#10961)
* Fix prop types of styled

* Fix props in windowed
2020-09-18 13:33:32 -07:00
Kamil Gabryjelski
ccfd293227
ESLint: no-restricted-syntax (#10889)
* Enable no-restricted syntax rule

* Fix webpack.config.js

* Remove unused function from utils/common.js

* Refactor triple nested for loop

* Fix loops in src/explore components

* Fix loops in SqlLab components

* Fix loops in AlteredSliceTag

* Fix loops in FilterableTable

* Add fixtures and uinit tests for findControlItem

* Add license
2020-09-18 09:05:57 -07:00
Elizabeth Thompson
ed9b50be2c
chore: upgrade cypress to use retries (#10923) 2020-09-17 12:54:50 -07:00
Moriah Kreeger
5623cd64ca
feat: update saved query backend routing + add savedquery list (#10922)
* Update saved query backend routing + add savedquery list

* add spec fileg

* add FE flag for SIP_34_SAVED_QUERIES_UI
2020-09-16 21:08:40 -07:00
Yongjie Zhao
af75bee582
feat: adding dashboard toggle fullscreen button (#10840) 2020-09-16 14:20:52 -07:00
Elizabeth Thompson
a3519b42cb
fix lint errors (#10918)
Co-authored-by: Elizabeth Thompson <elizabeth@preset.io>
2020-09-16 13:42:27 -07:00
Kamil Gabryjelski
281305e0cf
Enable anchor-has-content rule (#10908) 2020-09-16 13:27:52 -07:00
Elizabeth Thompson
0d90bc9920
chore: update port that cypress runs on for local vs test (#10847) 2020-09-16 12:31:03 -07:00
Elizabeth Thompson
d3e9c565b7
feat: use svg for checkbox component (#10799)
* use svg for checkbox component

* add vertical align to svg

* use emotion styling

* update import to superset core

Co-authored-by: Elizabeth Thompson <elizabeth@preset.io>
2020-09-16 12:03:14 -07:00
Elizabeth Thompson
13cc1a3d2d
fix: front end CI tests and test runner (#10897) 2020-09-16 11:35:18 -07:00
Maxime Beauchemin
0870d3ae2b
docs: add back issue code links (#10903)
* docs: add back issue code links

closes: https://github.com/apache/incubator-superset/issues/10852

* Addressing comments
2020-09-16 09:28:53 -07:00
Jesse Yang
d4291edffa
build: optimize eslint import resolver configs (#10901)
Use `node` resolver and `node` env for `webpack.config.js`, use
`webpack` resolver only for `src`.
2020-09-16 09:26:14 -07:00
Maxime Beauchemin
3b035d2af3
docs: redirect http -> https (#10900)
* docs: redirect http -> https

* fix issues
2020-09-16 08:24:08 -07:00
Jesse Yang
4eeee4c2eb
chore: enable eslint-import-resolver-typescript (#10895)
Let eslint understand tsconfig.json when importing modules, so we
can use `compilerOption.paths` to override where to find ts modules.
2020-09-15 15:33:49 -07:00
Moriah Kreeger
c43992bec8
feat: data menu routing (#10880) 2020-09-15 14:53:31 -07:00
Jesse Yang
0129c4253d
feat: move ace-editor and mathjs to async modules (#10837)
Follow up on #10831, move brace and mathjs to async modules so that the initial page load for dashboards most pages can be faster.
2020-09-15 14:12:06 -07:00
ʈᵃᵢ
045335a687
fix(cypress): wait for filterValues request (#10884) 2020-09-15 09:52:44 -07:00
Jesse Yang
4502690ef9
chore: clean up aphrodite (#10883) 2020-09-14 17:47:39 -07:00
Kamil Gabryjelski
01f90107e1
ESLint: Re-enable rule no-unused-vars (#10865)
* Re-enable rule no-unused-vars

* fixup! Re-enable rule no-unused-vars
2020-09-14 15:42:06 -07:00
Kamil Gabryjelski
e28f3d6220
Re-enable rule line-between-class-members (#10862) 2020-09-14 15:41:32 -07:00
Kamil Gabryjelski
91b8c8afc9
Re-enable rule state-in-constructor (#10873) 2020-09-14 13:31:11 -07:00
Kamil Gabryjelski
767044bfe5
ESLint: Re-enable rule control-has-associated-label (#10866)
* Re-enable rule control-has-associated-label

* Change aria-label message in DatasourceControl

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-09-14 13:00:39 -07:00
Kamil Gabryjelski
2d8f4e3aaf
Re-enable rule no-else-return (#10861) 2020-09-14 13:00:07 -07:00
Kamil Gabryjelski
76275ec410
Enable rule no-plusplus (#10876) 2020-09-14 11:59:32 -07:00
Kamil Gabryjelski
d93b2b99b2
Re-enable rule sort-comp (#10872) 2020-09-14 10:45:05 -07:00
Kamil Gabryjelski
a75c36281d
Re-enable rule jsx-curly-brace-presence (#10869) 2020-09-14 10:44:03 -07:00
Kamil Gabryjelski
c5193ca018
Re-enable rule no-non-null-assertion (#10864) 2020-09-14 10:40:20 -07:00
Kamil Gabryjelski
1908a94c7e
ESLint: Re-enable rule no-restricted-globals (#10863)
* Re-enable rule no-restricted-globals

* Fix missing semicolons
2020-09-14 10:39:46 -07:00
Kamil Gabryjelski
7f1012360a
Re-enable no-useless-path-segments rule (#10860) 2020-09-14 10:38:18 -07:00
Kamil Gabryjelski
906a629b33
Re-enable rule no-unused-state (#10871) 2020-09-14 10:31:16 -07:00
Kamil Gabryjelski
352e8a1afd
Re-enable rule prefer-destructuring (only for objects) (#10867) 2020-09-14 10:11:20 -07:00
Kamil Gabryjelski
c51168a30a
Re-enable no-confusing-arrow rule (#10874) 2020-09-14 10:03:37 -07:00
Kamil Gabryjelski
8a774d59ed
Eslint dependencies versions updates (#10839)
* Update eslint version to 7.8.1

* Give names to unnamed functions  to fix lint errors

* Update eslint-import-resolver-webpack

* Update eslint-plugin-cypress

* Add eslint-plugin-react-hooks

* Update necessary peer dependencies for eslint-config-airbnb

* Update eslint airbnb config and ts plugins

* Remove "this" from functional component

* Disable all rules that cause new errors

* Fix linting errors in tests

* Add licenses to .eslintrc files

* Add path and zlib to package.json

* Disable incompatible rule in eslint-plugin-cypress

* Remove redundant config for typescript linting

* Mark disabled rules with comments

* Remove path and zlib from deps, disable import rule for webpack files
2020-09-13 23:59:02 -07:00
Moriah Kreeger
686c19abcf
Fix test_connection POST body (#10846) 2020-09-11 23:33:43 -07:00
Maxime Beauchemin
6cb67017a5
style: white toolbar for SQL Lab (#10851) 2020-09-11 23:27:25 -07:00
Moriah Kreeger
7cd96edcdf
feat: add/edit database modal form sections UI (#10745) 2020-09-11 09:53:18 -07:00
John Bodley
a3e2e65121
fix: Making the database read-only (#10823)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-09-10 16:23:24 -07:00
Jesse Yang
d80f406239
build: optimize webpack code split (#10831) 2020-09-10 15:11:21 -07:00
Ville Brofeldt
8a9ae811d0
fix(sql-lab): relax column name restrictions (#10816) 2020-09-10 07:54:37 +03:00
Jesse Yang
9a59bdda48
refactor: merge/upgrade superset-ui packages (#10790)
* refactor: merge/upgrade superset-ui packages

* Fix flaky big number test

* Fix Flaky AdhocFilters test
2020-09-09 13:18:55 -07:00
ʈᵃᵢ
50672bb11b
feat: database delete warning (#10800) 2020-09-08 18:54:02 -07:00
Jesse Yang
cda232bf15
fix: ColorSchemeControl should not use CreatableSelect (#10814)
* fix: ColorSchemeControl should not be CreatableSelect

   Currently if you type to search in ColorSchemeControl it crashes the
whole page.

* Make it possible to filter by label

* Fix ColorSchemeControl unit test
2020-09-08 18:38:50 -07:00
ʈᵃᵢ
92f2353f80
feat: filters for database list view (#10772) 2020-09-04 16:23:38 -07:00
Grace Guo
596200528d
fix: disable domain sharding on explore view (#10787) 2020-09-03 15:42:39 -07:00
Shaoqing Hu
9bcb15091c
fix: can not type 0.05 in TextControl (#10778) 2020-09-03 12:11:34 -07:00
Evan Rusackas
824cea24ba
More Label touchups (margins) (#10722)
* labels with onClick don't need .pointer. No labels need `m-r-5`

* making Timer a proper Label

* a little linting

* addresing (helpful, thanks) comment
2020-09-02 23:13:58 -07:00
ʈᵃᵢ
7bccb38a60
feat: SIP-34 table list view for databases (#10705) 2020-09-02 11:48:21 -07:00
ʈᵃᵢ
5a4370012b
refactor: convert DatasetList schema filter to use new distinct api (#10746) 2020-09-02 11:07:37 -07:00
Evan Rusackas
e0deaad5e3
chore: removing fsevents dependency (#10751) 2020-09-02 10:37:23 -07:00
Ville Brofeldt
8c564fba38
feat(viz): add ECharts Timeseries chart (#10752)
* initial commit

* Change reference to new echarts plugin

* initial commit

* Change reference to new echarts plugin

* moving dependencies to plugin

* adding pie chart

* rename piechart key

* lint

* Bump packages and implement echarts colors

* remove pie for now

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-09-02 09:18:59 +03:00
Evan Rusackas
5a106eb8f5
moving all @types to dev dependencies (#10750) 2020-09-01 15:32:39 -07:00
Evan Rusackas
807bd656c6
Fix: Rejiggering some dependencies, trying to get CI to pass (#10747)
* removing two duplicate devdependencies - leaving dependencies

* bumping shuffled dependencies, making fsevents non-optional

* bumping @babel/cli

* Another bump
2020-08-31 20:50:46 -07:00
Evan Rusackas
cd144b68ac
style: Tabs now support AntD compound components (+ basic stories) (#10728)
* Supporting compound coponents, adding stories

* Adding a coupe o' knobs just for fun.
2020-08-31 13:56:59 -07:00
Maxime Beauchemin
3d8857ecc8
style: rename 'Source' top nav item to 'Data' (#10715)
* style: rename 'Source' top nav item to 'Data'

* Fix tests

* tables -> datasets

* rename datasource -> dataset

* lint

* more renaming

* use npm ci
2020-08-29 18:09:47 -07:00
Evan Rusackas
9fe30ab71e
style: Pass at propagating (and enhancing) Button component throughout Superset (#10649)
* getting rid of weird focus/active outline ring

* Buttons... buttons _everywhere_

* linting

* Nixing views/CRUD/dataset/Button component

* fixing 2 typing errors

* fixing more TS errors

* prefer src path for include

* one more real button, one less CSS class

* one more "button" to "Button"

* Published Status is now a proper clickable Label

* nixing the CRUD button again

* touching up stories, with SupersetButton story

* SIP-34 button colors

* adding polished package to mix colors

* updating button colors to match Superset theme

* abstracting away from bootstrap-specific props (might pivot libraries soon!)

* more abstraction from bsStyle/bsSize props

* exchanging styles for a prop

* linting

* restoring feature flag to stock

* using src alias

* last <button> replacement

* this classname would never be applied

* more linting action

* fixing unsupported bsSize 'medium', and cta typing error

* more cta action

* unnecessary styles

* errant bsSize prop

* cleanup

* tweaks to make new New button work

* Linting

* fixing a couple tests

* fixing theme based test failure

* margin tweak for NEW button

* another fixed test

* another fixed test

* fixing two more tests

* fixing last broken tests.

* always be linting

* Adding tertiary/dashed buttons

* cleaning up QueryAndSave buttons

* fixing "link" button styles

* fixing/updating link button styles

* cta buttons on Modal component

* linting.

* exporting button story knobs, making ALL knobs safe for export.

* capitalizing a file... no big whoop

* Basic button tests

* renaming button - temporarily

* renaming file to fix capitalization issue

* passing theme through to a difficult popover.

* fixin' a newly busted unit test

* lint fixin'

* oops, shouldn't have changed this prop!

* adding a dive() to themedShallow, and fixing a cypress/jest test

* addressing lint stuff

* touching up stories, with SupersetButton story

* SIP-34 button colors

* updating button colors to match Superset theme

* abstracting away from bootstrap-specific props (might pivot libraries soon!)

* linting

* restoring feature flag to stock

* cleanup

* Linting

* renaming button - temporarily

* renaming file to fix capitalization issue

* oops, shouldn't have changed this prop!

* adding a dive() to themedShallow, and fixing a cypress/jest test

* addressing lint stuff

* nixing new modal button

* Fixing another popover/button issue that should break cypress

* lint 

* passing classNames through to new button (should fix some tests)

* cleaning unused classes, making cypress tests use data attrs

* fixin' the test

* fixing another class-based test with data-test attr

* no longer passing theme as prop to buttons in popovers... themeprovider is better

* outline/border tweaks!
2020-08-28 17:34:28 -07:00
ʈᵃᵢ
d3bdea3805
fix: move menu reorg logic from crud app into Menu component (#10717) 2020-08-28 13:56:01 -07:00
Ville Brofeldt
dd0bc472e3
refactor(database): use SupersetResultSet on SqlaTable.get_df() (#10707)
* refactor(database): use SupersetResultSet on SqlaTable.get_df()

* lint

* change cypress test
2020-08-28 21:12:03 +03:00
Moriah Kreeger
c715cad48e
feat: base tabbed modal for new database CRUD UI (#10668) 2020-08-27 14:28:06 -07:00
ʈᵃᵢ
937b868321
style: add border between menu and submenu (#10698) 2020-08-27 14:15:22 -07:00
Lily Kuang
7abdf53944
fix: card view failed cypress tests (#10699) 2020-08-27 11:33:12 -07:00
Moriah Kreeger
8d94534881
style: Move security/manage navigation tabs into a settings dropdown (#10439) 2020-08-27 10:21:51 -07:00
Grace Guo
7fc227c92d
fix: shorten url with extra request parameters (#10693) 2020-08-27 09:53:20 -07:00
ʈᵃᵢ
81525c3e9d
feat(listview): set default view mode based on THUMBNAIL feature flag (#10691)
* feat(listview): set default view mode based on THUMBNAIL feature flag

* add spec

* better generic typing for ListView

* lint

* fix specs
2020-08-27 09:40:32 -07:00
Lily Kuang
bb92c1f84d
feat: chart and dashboard card list view e2e cypress test (#10669)
* card view cypress tests

* update test config

* chart filter cypress test

* move setting to superset test config

* update test description card view
2020-08-27 09:38:12 -07:00
Ville Brofeldt
aaf04cc344
fix(filter-box): don't add empty filter to filtersChoices (#10687)
* fix(filter-box): don't add empty filter to filtersChoices

* add test
2020-08-27 12:36:02 +03:00
ʈᵃᵢ
6ff96cfc72
refactor: useListViewResource hook for charts, dashboards, datasets (#10680) 2020-08-26 15:39:18 -07:00
ʈᵃᵢ
bc0fc4ea25
fix: SubMenu css (#10682) 2020-08-26 14:00:20 -07:00
Evan Rusackas
a95e5c9327
fix: layout flexiness (#10681) 2020-08-26 09:49:58 -07:00
Evan Rusackas
4b40d44b5c
style: Fancier menus, more SIP-34-ish (#10423)
* style: shinier menus

* fixing mouseover glitch

* unused import

* rm emotion-reset

* restoring default config values

* lint fixes 

* a bit more pizzaz to the underlines (max's idea), fading active background

* simplifying navtitle -> label

* RBNavDropdown  -> ReactBootstrapNavDropdown

* nixing whitespace

* replacing !importants with better selector specificity

* moving Menu LESS into Emotion

* no more border!

* fixing border issue

* language picker, account dropdown now use new dropdown component

* nixing whitespace in comment

* nixing duplicate styling

* removing borders on FAB navbar

* explicit font coloring

* linting
2020-08-24 23:16:44 -07:00
Evan Rusackas
fdfb7cdfd2
Eslint error cleanup (#10657)
* moving two console errors to logger errors

* nixing unused map index

* nixing unused param

* linting

* changing an alert to a toast

* fixing tests

* lint fix

* one letter change, just to see if iti gets CI to pass this test.
2020-08-24 14:04:27 -07:00
auxten
0f44d3edf2
Fix add chart page frontend i18n issue (#9321) 2020-08-22 21:04:18 +03:00
ʈᵃᵢ
45fee60b62
fix: remove FAB rendered menu in favor of react based one (#10401) 2020-08-21 17:19:00 -07:00
Grace Guo
aa8ff8759c
feat: use shorten url in standalone iframe (#10651) 2020-08-21 15:27:15 -07:00
ʈᵃᵢ
b86c0e5727
feat(listview): skeleton loading states for table and card collections (#10606) 2020-08-21 10:32:37 -07:00
Evan Rusackas
878f06d133
feat: Getting fancier with Storybook (#10647)
* Niftier paddings

* upgrading storybook, fixing glob pattern

* moving a couple storybook dependencies to dev dependencies

* fixing annoying lint issue about dev dependencies needing to be dependencies

* adds essential addons, fixes backgrounds

* newline tweaks

* comment about no-extraneous-dependencies, higher specificity on that rule, other linting stuff

* a *python* linter doesn't like this whitespace?!

* putting the linespace back

* ugh, found the space causing CI issues... I think
2020-08-20 22:41:25 -07:00
Erik Ritter
cb1989a4fd
feat: bump superset-ui for certified tag (#10650) 2020-08-20 16:56:18 -07:00
ʈᵃᵢ
7301a363c1
feat: setup react page with submenu for datasources listview (#10642) 2020-08-20 11:42:17 -07:00
Erik Ritter
38da552a57
feat: add certification to metrics (#10630) 2020-08-19 20:45:33 -07:00
Ville Brofeldt
5136c5c16e
feat(viz-plugins): add date formatting to pivot-table (#10637)
* feat: make pivot table dates formattable

* Bump npm packages
2020-08-19 23:55:59 +03:00
Evan Rusackas
84d08cb8da
fix: controls scroll issue (#10644) 2020-08-19 13:19:40 -07:00
Evan Rusackas
b0380befa1
feat: Allow tests files in /src (plus Label component tests) (#10634)
* allow tests in jest confg

* sample stories for Label component

* passing tests

* stories to tsx!

* excluding knobs exports from published stories

* ts fix

* ts fix

* Label test to TS

* explicitly ignoring test files in webpack bundling

* linting stuff

* adding comment about test file exclusions
2020-08-19 12:54:26 -07:00
Evan Rusackas
d0953874f2
chore: splitting button stories into separate stories (#10631)
* splitting button stories into separate stories

* lint
2020-08-18 22:47:27 -07:00
Lily Kuang
a3ac5061fe
feat: card view bulk select (#10607) 2020-08-18 18:04:36 -07:00
Evan Rusackas
ec7874ff98
style: Label styling/storybook touchups (#10627)
* colors corrected, hover/cursory only change if there's an onClick

* adding info label, breaking gallery out to its own story

* linting

* fixing bad class name

* now with fading!

* now supporting additional (non-bootstrap) label styles

* adding new secondary/primary labels to gallery

* fixing map key react warning

* using the new secondary label in the ChartList view

* linting

* fixing TS issue
2020-08-18 15:42:00 -07:00
Evan Rusackas
844b471509
fix: removing unsupported modal sizes (#10625)
* fix: removing unsupported modal sizes

* linting!

* NOT specifying bsSize seems to have the same effect as (unsupported) "medium"

* supporting 'large' and 'small' over 'lg' and 'sm'
2020-08-18 14:33:39 -07:00
Ville Brofeldt
ca5dc4256f
feat(datasource): remove deleted columns and update column type on metadata refresh (#10619)
* fix: remove missing columns on metadata refresh

* add tests

* lint and simplify

* lint

* reduce locals

* fix label style
2020-08-18 21:47:13 +03:00
Maxime Beauchemin
0d3caf08e5
chore: npm audit fix as of 2020-08-15 (#10613)
* chore: npm audit fix as of 2020-08-15

* --force

* fixing copy-webpack-plugin

* lint

* resolve conflicts
2020-08-17 15:27:01 -07:00
Evan Rusackas
f868580f64
chore: bump react-redux to 5.1.2, whittling console noise (#10602)
* chore: bump react-redux to 5.1.2

* fixing spy, and thus the breaking test.

* relabeling tests to UNSAFE_componentWillReceiveProps because why not.
2020-08-16 21:29:08 -07:00
Evan Rusackas
ed9b6dbf2b
fixing console error about bad html attribute (#10604) 2020-08-16 20:21:21 -07:00
Evan Rusackas
08211953b2
chore: migrate console logs to logging service (#10608) 2020-08-16 20:20:47 -07:00
Grace Guo
ca9ca99510
refactor: [migration] convert iframe chart into dashboard markdown component (#10590)
* refactor: [migration] convert iframe chart into dashboard markdown component

* remove 3 viz_types

* fix comments
2020-08-16 14:43:30 -07:00
Lily Kuang
03a62f15d8
feat: sort card view by Alphabetical, Recently Modified, and Least Recently Modified (#10601) 2020-08-14 15:07:37 -07:00
ʈᵃᵢ
db88cec431
feat: SIP-34 card/grid views for dashboards and charts (#10526) 2020-08-13 14:46:56 -07:00
Evan Rusackas
a3fd2b420e
fix: More tweaks needed after adding Doctype tag (#10504)
* fixing last-of-type specificity

* Simplifying/consolidating styles

* fixing filterbox in explore

* linting

* adding some px to font sizes

* fixing in-dash overflow

* removing px for one special fontsize case

* simplifying, addressing comments
2020-08-13 11:50:14 -07:00
Erik Ritter
a8197976fe
fix: error message modal overflow (#10580) 2020-08-11 17:20:39 -07:00
Jesse Yang
1b111b677e
feat(table-viz): translation and metric column header align right (#10549) 2020-08-11 12:56:32 -07:00
David Aaron Suddjian
83af9d12f8
fix(sqllab): Handle long table names in SQL Lab (#10518)
* widen the autocomplete menu for table names

* display the full table name in a tooltip

* license

* Update superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* src importing

* move autocomplete width css to main.less

* use html title attribute instead of tooltip

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-08-11 09:50:46 -07:00
Jesse Yang
a37b635674
fix(dashboard): add animation state to fix tab switch re-renders (#10475) 2020-08-11 00:57:50 -07:00
Maxime Beauchemin
613dd12fbf
fix: misaligned LimitControl buttons and port jsx->tsx (#10529)
* fix: misaligned LimitControl buttons and port jsx->tsx

* addressed comments
2020-08-10 15:35:39 -07:00
David Aaron Suddjian
7f84927504
fix(dashboard): changing the chart title, except not (#10527)
* changing slice names in dashboard should not change chart title

* comprehensions > loops
2020-08-07 18:06:58 -07:00
Jesse Yang
b6c6b6800a
fix: table viz query mode switch not working (#10552) 2020-08-07 14:15:03 -07:00
Erik Ritter
4765f8b10d
fix: embedded chart height (#10551) 2020-08-07 13:53:18 -07:00
Tanmay Laud
a6fa02aaec
chore: Migrate Timer component from jsx to tsx (#10455)
* migrated LanguagePicker.jsx to tsx

* Migrated Menu.jsx to tsx

* migrated MenuObject.jsx to tsx

* migrated NewMenu.jsx to tsx

* Migrated UserMenu.jsx to tsx

* removed unnecessary export from UserMenu

* added language definition in LanguagePicker

* removed unnecessary exports from Menu.tsx

* used typeof guard for childs

* changed LanguageProps to Languages

* removed unnecessary type casting

* fixed linting errors

* migrated Checkbox to tsx

* Migrated Timer component to tsx

* fixed linting errors

* fixed test cases

* removed unused import in timer spec

* reverting changes

* renamed and then modified Timer

* changes for review comments

* fixed incorrect clear

* using stopTimer in stopwatch

* fixed lint issues

* added explicit timer cleanup

* fixed lint issue

* fixed memory leak

* renamed Timer

* added changes after git mv
2020-08-07 09:30:17 -07:00
Jesse Yang
ea0db0d195
bugfix: table chart query mode initial value (#10544) 2020-08-07 02:25:48 -07:00
Maxime Beauchemin
0bad77f0fe
chore: TypeScript <Label /> (#10494)
* chore: TypeScript <Label />

* rebase

* chore: TypeScript <Label />

* rebase

* A bunch o' test fixes. One more to go!

* helper for mountying Emotional components with Enzyme

* asf license

* fixed last test, some linting

* improve the storybook

* Adressing comments

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-08-06 22:33:07 -07:00
Erik Ritter
2055ecc1ba
feat: refactor error components and add database issue code (#10473)
* feat: refactor error components and add database issue code

* Apply suggestions from code review

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2020-08-06 13:22:24 -07:00
Maxime Beauchemin
ece91928a9
style: use tabs in dashboard edit pane (#10394)
* style: use tabs in dashboard edit pane

* fix tests

* more hackin'

* getting ready to rip cell measurer

* working

* pogress

* Fix cards

* done

* fix jest

* fix cy
2020-08-05 18:53:53 -07:00
Natalie Ruhe
51a88cb19b
feat: Add antd to the codebase (#10508) 2020-08-05 13:50:30 -07:00