pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: default dashboard/chart cards are vector with perfect corners (#11684) 

* fix: default dashboard/chart cards are vector with perfect corners

* fix: adding licenses
This commit is contained in:
Evan Rusackas 2020-11-16 09:26:07 -08:00 committed by GitHub
parent 5700f8d363
commit 86651cd451
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 53 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
superset-frontend/images/chart-card-fallback.png
View File

Binary file not shown.
Side by Side

Before

Width:  |  Height:  |  Size: 3.1 KiB

27
superset-frontend/images/chart-card-fallback.svg Normal file
View File

File diff suppressed because one or more lines are too long
Side by Side

After

Width:  |  Height:  |  Size: 8.5 KiB

BIN
superset-frontend/images/dashboard-card-fallback.png
View File

Binary file not shown.
Side by Side

Before

Width:  |  Height:  |  Size: 2.6 KiB

22
superset-frontend/images/dashboard-card-fallback.svg Normal file
View File

@ -0,0 +1,22 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<svg width="467" height="269" viewBox="0 0 467 269" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M0 0H467V269H0V0Z" fill="#D9DBE4"/>
<path fill-rule="evenodd" clip-rule="evenodd" d="M62 45C59.7909 45 58 46.7909 58 49V220C58 222.209 59.7909 224 62 224H166C168.209 224 170 222.209 170 220V49C170 46.7909 168.209 45 166 45H62ZM182 139C179.791 139 178 140.791 178 143V220C178 222.209 179.791 224 182 224H406C408.209 224 410 222.209 410 220V143C410 140.791 408.209 139 406 139H182ZM178 49C178 46.7909 179.791 45 182 45H286C288.209 45 290 46.7909 290 49V126C290 128.209 288.209 130 286 130H182C179.791 130 178 128.209 178 126V49ZM302 45C299.791 45 298 46.7909 298 49V126C298 128.209 299.791 130 302 130H406C408.209 130 410 128.209 410 126V49C410 46.7909 408.209 45 406 45H302Z" fill="#ECEEF2"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.5 KiB

4
superset-frontend/src/components/ListViewCard/ListViewCard.stories.tsx
View File

@ -19,8 +19,8 @@
import React from 'react';
import { action } from '@storybook/addon-actions';
import { withKnobs, boolean, select, text } from '@storybook/addon-knobs';
import DashboardImg from 'images/dashboard-card-fallback.png';
import ChartImg from 'images/chart-card-fallback.png';
import DashboardImg from 'images/dashboard-card-fallback.svg';
import ChartImg from 'images/chart-card-fallback.svg';
import { Dropdown, Menu } from 'src/common/components';
import Icon from 'src/components/Icon';
import FaveStar from 'src/components/FaveStar';

2
superset-frontend/src/views/CRUD/chart/ChartCard.tsx
View File

@ -133,7 +133,7 @@ export default function ChartCard({
title={chart.slice_name}
url={bulkSelectEnabled ? undefined : chart.url}
imgURL={chart.thumbnail_url || ''}
imgFallbackURL="/static/assets/images/chart-card-fallback.png"
imgFallbackURL="/static/assets/images/chart-card-fallback.svg"
description={t('Last modified %s', chart.changed_on_delta_humanized)}
coverLeft={<FacePile users={chart.owners || []} />}
coverRight={

2
superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx
View File

@ -139,7 +139,7 @@ function DashboardCard({
}
url={bulkSelectEnabled ? undefined : dashboard.url}
imgURL={dashboard.thumbnail_url}
imgFallbackURL="/static/assets/images/dashboard-card-fallback.png"
imgFallbackURL="/static/assets/images/dashboard-card-fallback.svg"
description={t(
'Last modified %s',
dashboard.changed_on_delta_humanized,