pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 00:29:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix filter highlighting (#11439)

Browse Source
This commit is contained in:
David Aaron Suddjian 2020-10-27 08:38:24 -07:00 committed by GitHub
parent 427058b4dc
commit 055781f4a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
superset-frontend/src/explore/components/controls/DateFilterControl.jsx
View File

@ -221,7 +221,6 @@ class DateFilterControl extends React.Component {
this.close = this.close.bind(this);
this.handleClick = this.handleClick.bind(this);
this.handleClickTrigger = this.handleClickTrigger.bind(this);
this.isValidSince = this.isValidSince.bind(this);
this.isValidUntil = this.isValidUntil.bind(this);
this.onEnter = this.onEnter.bind(this);
@ -306,17 +305,6 @@ class DateFilterControl extends React.Component {
}
}
handleClickTrigger() {
// when user clicks OverlayTrigger,
// popoverContainer component will be created after handleClickTrigger
// and before handleClick handler
if (!this.popoverContainer) {
this.props.onOpenDateFilterControl();
} else {
this.props.onCloseDateFilterControl();
}
}
close() {
let val;
if (
@ -369,6 +357,11 @@ class DateFilterControl extends React.Component {
}
handleVisibleChange(visible) {
if (visible) {
this.props.onOpenDateFilterControl();
} else {
this.props.onCloseDateFilterControl();
}
this.setState({ popoverVisible: visible });
}
@ -606,7 +599,6 @@ class DateFilterControl extends React.Component {
trigger="click"
placement="right"
content={this.renderPopover()}
onClick={this.handleClickTrigger}
visible={this.state.popoverVisible}
onVisibleChange={this.handleVisibleChange}
>