pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

temp: remove possibly expensive computations from ChartHolder

This commit is contained in:
David Aaron Suddjian 2020-10-15 18:22:03 -07:00
parent 64c88b2cba
commit 37ce0214f0
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
View File

@ -211,15 +211,15 @@ class ChartHolder extends React.Component {
}
// figure out if this chart is in the focused filter's scope
const { chartId } = component.meta;
const isFocusedFilterChart =
focusedFilterScope && chartId === focusedFilterScope.chartId;
const includedInFilterScope =
focusedFilterScope &&
!isFocusedFilterChart &&
getChartIdsInFilterScope({
filterScope: focusedFilterScope.scope,
}).includes(chartId);
// const { chartId } = component.meta;
// const isFocusedFilterChart =
// focusedFilterScope && chartId === focusedFilterScope.chartId;
// const includedInFilterScope =
// focusedFilterScope &&
// !isFocusedFilterChart &&
// getChartIdsInFilterScope({
// filterScope: focusedFilterScope.scope,
// }).includes(chartId);
return (
<DragDroppable