From 37ce0214f0007386e35f113805a8a9abd291152a Mon Sep 17 00:00:00 2001 From: David Aaron Suddjian Date: Thu, 15 Oct 2020 18:22:03 -0700 Subject: [PATCH] temp: remove possibly expensive computations from ChartHolder --- .../components/gridComponents/ChartHolder.jsx | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx b/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx index c12ea3374e..d7f49cda41 100644 --- a/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx +++ b/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx @@ -211,15 +211,15 @@ class ChartHolder extends React.Component { } // figure out if this chart is in the focused filter's scope - const { chartId } = component.meta; - const isFocusedFilterChart = - focusedFilterScope && chartId === focusedFilterScope.chartId; - const includedInFilterScope = - focusedFilterScope && - !isFocusedFilterChart && - getChartIdsInFilterScope({ - filterScope: focusedFilterScope.scope, - }).includes(chartId); + // const { chartId } = component.meta; + // const isFocusedFilterChart = + // focusedFilterScope && chartId === focusedFilterScope.chartId; + // const includedInFilterScope = + // focusedFilterScope && + // !isFocusedFilterChart && + // getChartIdsInFilterScope({ + // filterScope: focusedFilterScope.scope, + // }).includes(chartId); return (