pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-16 02:29:39 -04:00
Code Issues Packages Projects Releases Wiki Activity
6,595 Commits 252 Branches 502 Tags 1.6 GiB
55232e235a
Commit Graph

962 Commits

Author SHA1 Message Date
ʈᵃᵢ
fda3a2fe7c
fix: disable browser autocomplete for DeleteModal (#12043) 2020-12-14 14:10:55 -08:00
Hugh A. Miles II
3d56f58ef5
fix: Explore "Change Dataset" UX Enhancements (#12006) 2020-12-14 13:17:20 -05:00
Lily Kuang
d5b16bcd85
fix schema datasource modal (#12018) 2020-12-14 08:44:47 -08:00
Geido
1afe91579e
refactor: Existing Antd Collapse to enhanced (#12013) 
* Move ProgressBar to Antd

* Remove trailing space

* Fix linting issues

* Export enhanced Progress only

* Move existing antd Collapse to enhanced Collapse

* Move enhanced props up to Collapse only

* Add stories for enhanced Collapse

* Add 100% height for overflow

* Improve text light story
 2020-12-13 22:57:08 -08:00
Evan Rusackas
fee9bbe57b
style: Restoring menu highlights (#12024) 
* restoring highlights

* fixing copypasta
 2020-12-13 22:48:26 -08:00
Victor Malai
022d755640
refactor : Change menu name and reorder items (#11993) 
* Change menu name and reorder items

* change type

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
 2020-12-12 21:58:57 -08:00
Victor Malai
90ed3267e4
fix: Change url & add check for active item in menu (#11915) 
* Change url & add check for active item in menu

* Refactor to pass lint validation

* Fix lint

* Revert back and remove underline
 2020-12-11 20:25:29 -08:00
Beto Dealmeida
9277a54a12
feat: add confirmation dialog for imports (#11983) 
* feat: add confirmation dialog for imports

* Small fixes

* Clean return
 2020-12-11 17:23:43 -08:00
Moriah Kreeger
696308715d
feat: alerts/reports add/edit modal (#11770) 2020-12-11 15:50:08 -08:00
Beto Dealmeida
2769de3731
chore: remove generic type (#12003) 
* chore: remove generic type

* Make resourceName type stricter

* Fix type

* Fix type

* Fix lint
 2020-12-11 10:52:26 -08:00
Victor Malai
12d9d1eccb
refactor : Transform SaveModal to typescript (#11951) 
* Transform SaveModal to typescript

* Revert title

* Resolve code review

* Refactor

* Refactor

* Change

* Call method

* Fix test

* ShouldPersist default false

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
 2020-12-10 23:02:03 -08:00
Rob DiCiuccio
4d329071a1
feat(SIP-39): Async query support for charts (#11499) 
* Generate JWT in Flask app

* Refactor chart data API query logic, add JWT validation and async worker

* Add redis stream implementation, refactoring

* Add chart data cache endpoint, refactor QueryContext caching

* Typing, linting, refactoring

* pytest fixes and openapi schema update

* Enforce caching be configured for async query init

* Async query processing for explore_json endpoint

* Add /api/v1/async_event endpoint

* Async frontend for dashboards [WIP]

* Chart async error message support, refactoring

* Abstract asyncEvent middleware

* Async chart loading for Explore

* Pylint fixes

* asyncEvent middleware -> TypeScript, JS linting

* Chart data API: enforce forced_cache, add tests

* Add tests for explore_json endpoints

* Add test for chart data cache enpoint (no login)

* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag

* Add tests for tasks/async_queries and address PR comments

* Bypass non-JSON result formats for async queries

* Add tests for redux middleware

* Remove debug statement

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Skip force_cached if no queryObj

* SunburstViz: don't modify self.form_data

* Fix failing annotation test

* Resolve merge/lint issues

* Reduce polling delay

* Fix new getClientErrorObject reference

* Fix flakey unit tests

* /api/v1/async_event: increment redis stream ID, add tests

* PR feedback: refactoring, configuration

* Fixup: remove debugging

* Fix typescript errors due to redux upgrade

* Update UPDATING.md

* Fix failing py tests

* asyncEvent_spec.js -> asyncEvent_spec.ts

* Refactor flakey Python 3.7 mock assertions

* Fix another shared state issue in Py tests

* Use 'sub' claim in JWT for user_id

* Refactor async middleware config

* Fixup: restore FeatureFlag boolean type

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2020-12-10 20:21:56 -08:00
Grace Guo
0fdf026cbc
feat: add invisible layer on loading chart (#11994) 2020-12-10 16:15:10 -08:00
Lily Kuang
df6efb6aa2
feat: alert/report execution log list view (#11937) 2020-12-10 15:15:13 -08:00
Beto Dealmeida
9e07e10055
chore: move passwords needed message (#12002) 2020-12-10 11:47:54 -08:00
Michael S. Molina
3a6254184a
refactor: Removes hard coded colors (#11977) 
* Removes hard coded colors

Removes hard coded colors defined in src/components/styles.ts. The colors defined in this file were used only in the Select component so they were migrated to src/components/Select/styles.tsx and ajusted to conform to the theme colors.

* Use theme context for Select styles

* Includes Theme Provider in tests with Select
 2020-12-10 11:43:57 -08:00
Beto Dealmeida
9256b6fb3d
chore: consolidate common code in importers (#11936) 
* chore: consolidate common code in importers

* Small fixes

* Small fixes
 2020-12-10 10:11:58 -08:00
Victor Malai
38bb6f3f20
fix : Fix style for header (sqllab) (#11980) 
* Fix style for header

* flex

* Refactor

* Remove styled from import

* Change width of container

* Add tooltip and set fixed width of sidebar

* Fix lint

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
 2020-12-09 23:34:43 -08:00
Mayur Newase
8cc566792a
fix(explore): changing metric aggregate doesn't update label (#11946) 
* fix: [chart]heatmap selecting metrics does not update the query results
fixes issue #11866
title's label is overriding metric label.

* Using custom label to decide label of metrics.

* lint

* Tests fixed

* early metric label check while saving from ui

* early custom label check

* removed extra space

* no state mutations

* simplify

* removed log

* nned to fix linting issue

* Lint fixed
 2020-12-10 09:30:57 +02:00
Evan Rusackas
c73904b02e
fixing rounded corners (#11990) 2020-12-09 21:07:23 -08:00
Victor Malai
5435064807
refactor : Transform FilterScopeModal to Typescript (#11964) 
* Transform from jsx to tsx

* replace any with void

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
 2020-12-09 15:46:06 -08:00
Victor Malai
e62cf0d84d
fix : adhoc filter dropdown (#11963) 
* Add z-index to popover

* Fix prettier

* Fix closing popover on select from dropdown

* Fix prettier

* Fix visibility change

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
 2020-12-09 15:44:20 -08:00
Kamil Gabryjelski
6fe1f9d78a
Debounce TextControl if change runs immediately after input (#11985) 2020-12-09 15:41:44 -08:00
Kamil Gabryjelski
a4b06d23fd
Change paddings on ListView and SubMenu (#11975) 2020-12-09 15:08:59 -08:00
Elizabeth Thompson
3c177e550b
add user to sql lab state (#11986) 2020-12-09 14:53:15 -08:00
Beto Dealmeida
36976d17f7
fix: make "DELETE" confirmation work in other languages (#11987) 
* Confirm delete i18n

* Make DELETE a parameter
 2020-12-09 14:40:07 -08:00
David Aaron Suddjian
6270fa2026
refactor: Upgrade Redux (#11967) 
* upgrade redux and react-redux, adjust types

* first round of test fixes

* fix rest of unit tests

* lint

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
 2020-12-09 11:58:42 -08:00
Hugh A. Miles II
cc44a2c01b
feat: Sqllab to Explore UX improvements (#11755) 
* create boiler modal component

* hello world modal

* setup modal flow

* setup savemodal for components

* flake8

* fix onclick reference

* working create datasource boiler

* saving spot for callback on text input

* working dataset with input box

* working redirect on completion

* get data for owners dropdown

* fix build with pull from master

* fix the filteroption

* 💯

* move state to upper component

* add overwrite state

* hacked overwrite process

* linting

* fix filter

* cleaning up the coe

* Delete preset.code-workspace

* remove unused code

* remove visualize

* update default value

* remove unneeded vars

* checkout package-lock.json

* linting

* get user id

* remove page filter

* setup proper call for updating columns in dataset

* add move to explore flow

* linting

* add param for overriding columns

* linting

* change title

* fix some tings

* cleanup

* linting

* add types in some places

* save toast

* use moment

* add error toast

* create enum for radio states

* initial state for saving query

* add tpying

* addressing concerns

* update propTypes

* add functionality for CTAS explor btn

* handle CTAS state

* fix onclick to reference upper level component

* formatting

* reset state after closing

* add error message when user doesn't pick an already selected dataset

* remove unneeded todo

* remove styling

* move async calls to api directory

* remove console.log

* add user id param

* typing

* littty

* move put to seperate file

* save

* dsf

* fix typing errors

* adding more types

* fix typing erros

* linting

* add basic spec test

* create dataset modal

* add components reference

* Rename SaveDatasetModal_spec.jsx to SaveDatasetModal_spec.tsx

* remove sinon for now

* fix typing errors on modal files

* fix linting

* address comments

* attempt to fix linting

* add props

* fix test

* fix the linting

* yerp

* fix this references

* spaces

* handleOverwriteCancel reference cleanup

* rename bool value for shouldOverwriteDataset

* fix typing for onChange

* you still the best in the world

* fix spec

* align branches

* push

* fix key names

* fix dataset reference

* lowercase

* fix save bug with tiem

* fixed styling

* fix date state after push to explore

* add disabling states

* plz refactor this

* this is working fully now

* do some renaming

* renaming

* remove console.logs

* still refactoring

* remove unneeded code

* remove unneeded variables

* still cleaning

* added interface

* fix typing issues

* cleanup unused code

* fix npm lnit

* fix initial problems

* add props to test

* remove unneeded files

* skip linting

* saving

* this works

* remove old test

* remove old test

* fix linting

* fix broken test

* remove jsx file

* refactoring

* cleanup

* remove comments

* reset user object

* fix functions

* fix this

* reverting CTAS btn flow

* remove onclick

* save frontend work

* allow for database id to be passed as param in body

* use enum

* fix linting

* style alignment

* get rid of .then

* add function to compute default value with tiem

* lit

* remove ts-error

* fix typing
 2020-12-08 17:29:41 -08:00
Victor Malai
05258ebc6c
fix(event-flow-viz): handle null metadata selection (#11885) 
* Initialize object with empty array if is multiselect, fix 500 BE error

* modify data coming
 2020-12-08 08:53:26 +02:00
Beto Dealmeida
8f1ac7ead1
feat: add modal to import dashboards (#11924) 2020-12-07 21:26:14 -08:00
Beto Dealmeida
33325f9fa6
feat: add modal to import charts (#11956) 
* WIP

* Splat props
 2020-12-07 18:33:59 -08:00
Beto Dealmeida
fbb458fa8b
feat: add modal to import datasets (#11910) 2020-12-07 16:20:25 -08:00
Beto Dealmeida
2b9695c520
feat: add modal to import databases (#11884) 
* feat: add modal to import databases

* Fix test

* Improve hook

* Remove log and needless store.

* Change JS functions
 2020-12-07 11:22:45 -08:00
Krist Wongsuphasawat
a7bba92469
chore: bump nvd3 plugin version (#11947) 2020-12-07 12:19:03 +07:00
Kamil Gabryjelski
41738df77d
feat: Results table on Explore view (#11854) 
* Upgrade react-split

* Implement split on ExploreChartPanel

* Implement tabs with collapse

* Fix run query button

* Fix copy to clipboard button

* Move table controls to separate file

* Make component more generic to handle samples

* Remove samples from DisplayQueryButton

* Move data tables to separate file

* Make split dynamically controlled

* Fix unit test

* Fix arrow not centered

* fixup! Fix arrow not centered

* Change copy button paddings

* Use translations

* Fix grammar in a comment

* Fix imports

* Use grid units

* Convert new files to typescript

* Fix after rebase

* Remove forceRender

* Fix big_number test

* Delay making request until panel is opened

* White background in south panel

* fixup! White background in south panel

* Lint fix

* Lint fix

* Remove redundant prop types

* Remove console log

* Delay loading samples until user switches tab

* Add debounce to filter input

* Use gridUnit for gutter sizes

* Change types object to Record<string, any>
 2020-12-04 19:49:24 -08:00
Geido
2c323426d1
refactor: Move Badge to Antdesign (#11899) 
* Move Badge to Antdesign

* Export enhanced badge only

* Center number in badge
 2020-12-04 17:06:54 -08:00
Victor Malai
64d6fb9f6f
refactor: Extract copy functionality to utils (#11928) 
* Extract copy functionality to utils

* Refactor

* Revert bind

* WIP

* Absolute path

* Fix lint

* Remove unused resolve
 2020-12-04 17:04:41 -08:00
Kasia Kucharczyk
98dc65722c
Added check if SQL query is empty and disable shortcut for run query (#11877) 2020-12-04 10:45:43 -08:00
Lily Kuang
60122a2b2d
feat: filters for alerts and reports list view (#11900) 2020-12-04 09:58:34 -08:00
Ville Brofeldt
327a2817d3
feat: add event and interval annotation support to chart data ep (#11665) 
* feat: add event and interval annotation support to chart data ep

* add tests + refactor fixtures

* use chart dao
 2020-12-04 14:40:31 +02:00
Hugh A. Miles II
41d4fb9cb3
fix: Forgot to remove bad comments from SaveDatasetModal (#11919) 2020-12-03 17:03:40 -08:00
Geido
5b1939802d
refactor: Move ProgressBar to Antd (#11875) 
* Move ProgressBar to Antd

* Remove trailing space

* Fix linting issues

* Export enhanced Progress only
 2020-12-03 13:28:06 -08:00
Elizabeth Thompson
04f993e222
fix: adjust width for non multi select inputs (#11911) 2020-12-03 11:27:17 -08:00
Hugh A. Miles II
9ae2f95b34
feat: Adding SaveDatasetModal component (#11861) 2020-12-03 11:14:44 -08:00
Agata Stawarz
38d21acff6
fix: Check if annotation type is supported by the given chart type (#11876) 
* Check if annotation type is supported by this kind of chart

* Check if annotation type exists
 2020-12-03 10:23:23 -08:00
Evan Rusackas
53017e5a35
fix: Button storybook component size knob (#11912) 2020-12-03 10:20:24 -08:00
Evan Rusackas
38b720b0a7
style: eslint curly rule (#11913) 
* style: eslint curly rule

* curly for ts
 2020-12-03 10:20:05 -08:00
ʈᵃᵢ
8c063efa75
fix(query): sorting by user for Query History list view (#11897) 
* fix: sorting by user for Query History list view

* fix filter exception
 2020-12-03 09:12:58 +00:00
Daniel Vaz Gaspar
71c567bf3a
feat(css templates): security perm simplification (#11856) 
* feat: security converge css templates

* fix security tests

* fix JS test

* add migration

* black and fix migration
 2020-12-03 08:45:32 +00:00
Grace Guo
61064b9634
add fix for extra comments for #11781 (#11902) 2020-12-02 18:13:42 -08:00
Nikola Gigić
721f9119e1
chore: Enable jsx-a11y/anchor-is-valid (#11891) 
* Enabling ancor-is-valid

* Remove comments since no longer applies
 2020-12-02 10:14:56 -08:00
Hugh A. Miles II
0c10f9ee3f
chore: Update sqllab types (#11887) 2020-12-02 10:11:26 -08:00
Erik Ritter
f2d9f00013
feat: allow user to view their profile again (#11816) 2020-12-02 09:14:23 -08:00
Victor Malai
07288789e2
fix: Show copy icon (#11847) 
* Show copy icon

* Fix eslint

* Fix copy button on view query modal

* Remove comments
 2020-12-01 23:40:02 -08:00
Victor Malai
618a73d56e
Align icon (#11848) 2020-12-01 22:44:55 -08:00
Nikola Gigić
9514be5daf
style: remove react bootstrap fade component (#11843) 
* Replace Bootstrap Fade component with custom Emotion Fade component

* Fix lint errors

* Added test

* Fixing front-end build errors

* Fix lint errors
 2020-12-01 22:43:30 -08:00
Lily Kuang
a76eadd838
feat: report/alert list CRUD view (#11802) 2020-12-01 17:57:15 -08:00
Erik Ritter
d041d3a7f1
fix: certification icon order (#11881) 2020-12-01 17:11:09 -08:00
Grace Guo
f292015ccd
fix (dataset editor): allow Source tab readOnly mode (#11781) 
* fix (dataset editor) add read-only mode for Source tab

* add feature flag, add unit tests

* rebase and fix comment

* add message for padlock

* move padlock to the bottom of tab
 2020-12-01 17:10:33 -08:00
Jesse Yang
a5af2ade0a
test: add React Testing Library (#11771) 2020-12-01 11:14:37 -08:00
Kasia Kucharczyk
3035090915
fix: filters push out apply button on dashboard (#11580) 
* Changed height of slices in dashboard into 100%-padding, so there is no scroll appearing anymore

* Added scroll to the block on dashboard, when filters are too high

* Applied lint
 2020-12-01 10:43:50 -08:00
ʈᵃᵢ
ffa32cde14
chore: remove SIP_34_QUERY_SEARCH_UI feature flag (#11863) 2020-12-01 09:29:16 -08:00
Agata Stawarz
44e80e0175
chore: Add home link to navbar (#11851) 
* Add Home link to Navbar

* Change test text for rendering elements in the main navbar

* Display Home link only when Logo Target Path is set
 2020-11-30 23:14:42 -08:00
Elizabeth Thompson
84e0606a90
chore: move fixtures and helpers to root (#11812) 2020-11-30 14:23:56 -08:00
ʈᵃᵢ
011724750f
feat: list view filters for Query History (#11702) 2020-11-30 14:21:53 -08:00
Hugh A. Miles II
3cd94d6da9
feat: Create api abstraction layer for dataset network calls (#11855) 
* add datasets api file

* Update dataset.ts

* Update dataset.ts

* Update dataset.ts
 2020-11-30 13:27:27 -08:00
Phillip Kelley-Dotson
0e9898cb96
feat(welcome): add SQL snippets to saved queries card (#11678) 
* update savedqueries card to new layout

* update card

* update card to latest mock

* update empty state

* remove fallback

* fix query statement

* update card styles

* remove double import

* use fallbackurl prop for emptystate

* update line lenth

* Update superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* update styles and svg

Co-authored-by: Evan Rusackas <evan@preset.io>
 2020-11-30 11:53:12 -08:00
Kamil Gabryjelski
a4f44255aa
Fix chart select borders in BuilderComponentPane (#11766) 2020-11-30 09:51:54 -08:00
Kamil Gabryjelski
5ebc09b339
fix: Download as image not working on Dashboard view (#11778) 
* Fix download as image not working on Dashboard view

* Fix menu not closing before making a screenshot

* Move hardcoded selectors to variables

* Fix linting issue

* Add comments

* Close menu before taking a screenshot on Explore view

* Use style.visibility instead of timeout to hide menu for screenshot

* Change const name to uppercase

* Move variable declarations to case
 2020-11-30 09:16:38 -08:00
Daniel Vaz Gaspar
9dd33d5566
feat(saved queries): security perm simplification (#11764) 
* feat(saved queries): security perm simplification

* migration script and frontend

* add downgrade procedure

* downgrade procedure, inferred from the upgrade data

* fix JS test

* improve code

* add tests for role migration

* more tests and a short description for each one

* Improve readability

* simplify dataclass creation

* fix dataclass
 2020-11-30 13:07:39 +00:00
Erik Ritter
46664452a7
chore: type a couple easy to type files (#11838) 2020-11-29 21:52:41 -08:00
Kamil Gabryjelski
19e5ce0ac7
chore: Move styles of Dashboard and FilterScopeSelector modals to Emotion (#11779) 
* Remove unused component

* Move styles from dashboard.less and filter-scope-selector.less to Emotion

* Write padding style short-hand way
 2020-11-29 21:20:03 -08:00
Agata Stawarz
e974b0be05
Change subtabs order for Data tab (#11834) 2020-11-29 20:16:47 -08:00
Erik Ritter
671ff6c053
fix: improve Avatar text size consistency (#11837) 2020-11-29 20:08:47 -08:00
Agata Stawarz
43c69d52a4
fix: Adding and removing annotations (#11811) 
* Fix creating new annotation layer and refactor AnnotationLayer component

* Refactor checking overrides keys in AnnotationLayer

* Fix adding and editing annotations. Refactor AnnotationLayer submit and remove functions

* Remove unused parent prop from AnnotationLayer

* Fix toggling annotation layer popover

* Revert extracting annotation props to nested object

* Clean up AnnotationLayer component

* Remove unnecessary import

* Use original name for identifying annotations in add/remove actions

* Change props order and rename removeAnnotation function

* Compare annotations by reference instead of name
 2020-11-28 10:59:16 +02:00
Lily Kuang
9c69679e14
feat: filter by me on CRUD list view (#11683) 2020-11-25 11:56:48 -08:00
Grace Guo
4cbf482194
fix: add feature flag for domain sharding (#11797) 
* fix: add feature flag for domain sharding

* fix review comment

* add comment for speical case
 2020-11-25 11:47:18 -08:00
Erik Ritter
9215a31fa2
chore: type src/logger (#10815) 2020-11-25 08:21:44 -08:00
Erik Ritter
e4d02881d2
chore: unbreak frontend ci (#11806) 2020-11-24 21:43:02 -08:00
Kamil Gabryjelski
9b68b65568
refactor: Replace react-bootstrap tooltips with Antd tooltips (#11737) 
* Refactor tooltip in ColumnElement

* Refactor tooltip for Button 

* Remove redundant import

* Refactor tooltip in SqlEditor

* Increase line height in tooltip so that the text is centered

* Refactor tooltip in Link

* Refactor tooltip in AdhocMetricEditPopoverTitle

* Refactor tooltip from ControlHeader

* Refactor tooltip in DateFilterControl

* Refactor tooltip in VizTypeControl

* fixup! Refactor tooltip in AdhocMetricEditPopoverTitle

* Refactor tooltip in QueryAndSaveBtns

* fixup! Refactor tooltip in DateFilterControl

* Refactor tooltip in CopyToClipboard, fix cursor pointer

* Refactor tooltip in TooltipWrapper

* Refactor tooltip in Field/DatasourceEditor

* Remove redundant import

* Fix typing for placement prop

* Decrease margin in ColumnElement divider

* Change default export to named

* Move SqlLab Tooltip styles to Emotion

* Fix tests
 2020-11-24 13:04:55 -08:00
Erik Ritter
c0224aa928
feat: add certification info to table selector (#11785) 2020-11-24 12:13:52 -08:00
Moriah Kreeger
6019113bc6
refactor: use rison for list view filters stateful urls (#11675) 2020-11-24 11:19:48 -08:00
Agata Stawarz
91bcbc8350
refactor: Replace SqlLab components' styles using Emotion & theme variables (#11780) 
* Replace inline styles for SqlLab components using Emotion and Theme variables

* Replace styles classnames for SqlLab components using Emotion

* Remove unnecessary styles & round padding value
 2020-11-24 10:53:51 -08:00
adam-stasiak-polidea
6cb820583b
chore: controls.test supporting v1 charts and added force=true to url when r… (#11754) 
* controls.test supporting v1 charts and added force=true to url when refreshin chart with force an option

* Added verification for isCached

* added using global alias prefix

* fixed typescript error
 2020-11-24 10:50:33 -08:00
Phillip Kelley-Dotson
d364d0354c
add tool tip to cards (#11791) 2020-11-24 10:20:27 -08:00
adam-stasiak-polidea
f49525f03e
chore: enabled v1 verification in filter and url_params test files (#11712) 
* enabled v1 verification in filter test file

* added v1 support in url_params tests

* review fix
 2020-11-24 13:09:57 +02:00
Maxime Beauchemin
872a54d304
fix: annotation layer crashes when clearing type select (#11787) 2020-11-23 21:46:26 -08:00
Elizabeth Thompson
fd7e6c77fc
fix: style multiselect input (#11732) 
* style multiselect input

* add autocomplete and move input styles to styles file
 2020-11-23 14:15:11 -08:00
Erik Ritter
db7386910e
chore: fix typo (#11772) 
* chore: fix typo

* Update utils.tsx
 2020-11-20 19:23:37 -08:00
ʈᵃᵢ
fbe4a6622e
feat: SQL preview modal for Query History (#11634) 2020-11-20 16:01:06 -08:00
Kamil Gabryjelski
cdd01f4851
fix: Null error when deleting the last owner label in DatasourceEditor/settings (#11752) 
* Fix null error when deleting the last owner in SelectAsyncControl

* Replace "||" with "??"
 2020-11-19 14:10:34 -08:00
Kamil Gabryjelski
63ef649d1d
Make spacings in Settings menu more consistent (#11709) 2020-11-19 13:01:53 -08:00
Evan Rusackas
31eaa0ca20
style: dark filter popover background (#11611) 
* style: dark filter popover background

* Story to test and demonstrate the pitfalls of global styles

* nixing the story... not going to be reusing this anyway

* adding a class to isolate dark styles

* now supports all arrow directions

* placing at the bottom rather than bottom right

* adding colors, adjusting spacing

* linting
 2020-11-19 10:54:49 -08:00
Amit Miran
c79dc4763b
chore: Text change Allow Data Upload (#11736) 
* chore: Text change Allow CSV/Excel Upload

today there are 2 ways of uploading data CSV or Excel
config on the database allow_csv_upload applies to both options
so the client facing text should also indicate that

* Allow Data Upload
 2020-11-19 12:05:14 +02:00
David Aaron Suddjian
676e0bb282
docs: fix docker config paths (#11703) 
* docs: fix config paths for docker

* xit bad cypress tests
 2020-11-17 22:00:12 -08:00
Kamil Gabryjelski
1371939921
Fix missing styles in FilterScopeSelector modal (#11726) 2020-11-17 16:48:55 -08:00
Evan Rusackas
c241c6f00b
fix: prior npm font source had a glitch (#11724) 2020-11-16 21:23:54 -08:00
Kamil Gabryjelski
8a39f2799a
Fix "Select all" option in SelectControl (#11692) 2020-11-16 17:23:32 -08:00
Kamil Gabryjelski
274420bc5a
Fix ModalTriggers styling in SqlLab (#11719) 2020-11-16 17:13:37 -08:00
Evan Rusackas
871a98abe2
refactor: Load fonts from packages rather than local binaries (#11718) 
* removing binaries

* adding npm packages

* nixing unused specimen sheet

* deleting specimen sheets

* using imported css sheets from npm

* package lock

* fixing webpack issue with font loading

* raising specificity on ACE editor fonts

* linting ✨
 2020-11-16 17:10:48 -08:00
Kamil Gabryjelski
3e6bcbb98d
Remove "required" from SaveModal Add to dashboard field (#11693) 2020-11-16 15:07:24 -08:00
Evan Rusackas
86651cd451
fix: default dashboard/chart cards are vector with perfect corners (#11684) 
* fix: default dashboard/chart cards are vector with perfect corners

* fix: adding licenses
 2020-11-16 09:26:07 -08:00
adam-stasiak-polidea
2f036e9359
chore: V1 charts load cypress tests (#11685) 
* Enabled assertion on v1 chart request

* added missing code after rebase

* extracted alias logic to function

* modified v1 requests to contain form data, added assertion on ui elements using slice id from request
 2020-11-16 09:08:35 +02:00
Rob DiCiuccio
700c7c524e
build(cypress): Fix issue with cypress code-coverage plugin when running locally (#11698) 
* Update @cypress/code-coverage to latest

* Set nyc reporter to html/text

* Revert dashboard list test changes from #11613

* Update codecov reporting to summary format

* Add json reporter for codecov.io

* Silence inline coverage reports
 2020-11-15 13:16:34 -08:00
Grace Guo
7d27996867
chore: remove a few obsolete logic (#11676) 2020-11-13 23:16:05 -08:00
Kamil Gabryjelski
2b107ed33d
Fix overflow hidden issues in Dashboard Builder tabs (#11691) 2020-11-13 23:14:02 -08:00
ʈᵃᵢ
218f58edb7
fix(saved query): handle null sql field (#11679) 2020-11-13 13:15:24 -10:00
Craig Rueda
95246e8812
feat: Adding docker build/push (#11616) 
* Adding docker build/push

* Adding build script

* Trying username

* Updating build script

* Fixing script path?

* Lising envvars

* Pulling HEAD

* Actually pushing

* Fixing build / SHA

* Logout before login

* updating docker login

* Fixing docker login

* Trying stdin pwd

* Adding check for forks

* Fixing tagging

* Fixing refspec

* Updating Dockerfile-dev

* Adding license to script

* Fixing Cypress tests
 2020-11-13 11:32:18 -08:00
Jesse Yang
ec8ccd4cf1
feat: keep modal open when saving database failed (#11618) 2020-11-12 16:10:14 -08:00
Kamil Gabryjelski
3ad65bc163
fix: Dropdown menu not closing on Dashboard view (#11671) 2020-11-12 14:48:48 -08:00
Maxime Beauchemin
5cb6c25ca0
docs: add support for Google Analytics on superset.apache.org (#11613) 
* docs: add support for Google Analytics

* fix failing cypress test in list_view.test.ts

* xit some tests
 2020-11-12 13:57:05 -08:00
ʈᵃᵢ
432e5ab460
feat: Query History CRUD list view (#11574) 2020-11-12 11:55:13 -10:00
ʈᵃᵢ
1dc4c4746e
fix(dashboard): ordering for add chart widget (#11672) 2020-11-12 11:10:45 -10:00
Kasia Kucharczyk
4af7264a2c
fix: make higher chart box resizable (#11673) 
* Added visible resizible icon to all types of blocks in tabs

* Adjusted position of hovered framwes and edited markdown
 2020-11-12 11:53:48 -08:00
Elizabeth Thompson
b277f19808
keep placeholder on multiselect (#11289) 2020-11-12 11:36:24 -08:00
Ville Brofeldt
2718909314
feat: add ECharts BoxPlot chart (#11199) 
* feat: add ECharts BoxPlot chart

* lint

* fix cypress tests

* lint

* remove viz.py shim

* bump plugin package

* skip non-legacy plugin cypress dashboard tests

* fix cypress tests

* disable cypress tests for non-leagcy charts

* fix bad rebase

* use midpoint interpolation for quartile calculation

* bump packages and add support for no groupby

* whitespace

* whitespace

* linting

* fix tests

* xit mathjs load test

* bump mathjs to 8.0.1

* disable cypress filter test for v1 charts
 2020-11-12 10:01:04 +02:00
Kamil Gabryjelski
6ef4d2a991
Restructure chart header to wrap nicely (#11643) 2020-11-11 20:18:04 -08:00
Elizabeth Thompson
f3b68cbbbe
add import icon (#11652) 2020-11-11 13:48:53 -08:00
Jesse Yang
4f21dea55f
feat(dev): dont override asset manifest in dev-server (#11648) 
Override manifest.json only when `npm run dev`, not `npm run
dev-server`.  This allows developers to compare between the
current version of Superset with what they are working on
without switching back and forth between branches.

All they need to do is to first start the current version with
production build:

```
npm run build
superset run -p 8088
```

Then start the dev server in another window:

```
npm run dev-server
```
 2020-11-11 13:14:45 -08:00
Grace Guo
a9f9c4bbd5
[fix] handle null value in date filter (#11655) 2020-11-11 09:32:26 -08:00
ʈᵃᵢ
329e72885c
fix(saved-query): handle case where sql_tables in undefined (#11649) 2020-11-10 15:26:29 -10:00
Evan Rusackas
73cc938358
style: various little tweaks to home screen stylin' (#11650) 
* adding bottom padding

* making light gray backgrounds match

* vertical centering of empty state content.

* linting ✨

* fixing card radii

* fixing corner radius... thumb was covering corner border.
 2020-11-10 17:20:31 -08:00
Jesse Yang
75245177e9
chore: pin node and npm versions (#11646) 2020-11-10 15:58:54 -08:00
Jesse Yang
339d0d73bc
feat(sankey-viz): allow sort by metric and bump superset-ui packages (#11626) 2020-11-10 15:58:00 -08:00
Rob DiCiuccio
14aa729e66
build(deps-dev): update cypress to 5.5.0, improvements for running locally (#11603) 
* reduce numTestsKeptInMemory to 0 to prevent Chrome OOM crash

* Add cypress-run-chrome script, update docs and cypress_build.sh

* Upgrade Cypress to latest version

* tox: add missing 'cypress' env, cleanup flask server

* Fix failing dashboard edit test syntax

* Reduce retry count to 1

* Prettier test
 2020-11-10 15:51:47 -08:00
adam-stasiak-polidea
4eff80c3f3
chore: enabled cypress test in filter file (#11458) 
* enabled cypress test in filter file

* added delay to typing

* additional assertion and timeout

* Modified test logic - changed user's action to selection from list instead of typing (unstable with cypress)
 2020-11-10 15:18:20 -08:00
Kamil Gabryjelski
98d1c6964c
refactor: Remove reactable arc (#11535) 
* Refactor DisplayQueryButton into functional component and use react-table

* Refactor EstimateQueryCostButton to functional component

* Use react-table instead of reactable-arc

* Remove reactable-arc dependency

* Add margin for copy button

* Make search case insensitive
 2020-11-10 15:13:29 -08:00
Evan Rusackas
3b89d2307a
fix: card thumbnails now always show border. (#11638) 
Co-Authored-By: Evan Rusackas <evan@preset.io>
 2020-11-10 08:58:39 -08:00
adam-stasiak-polidea
4d41cf900d
Disabled bubble test (#11630) 2020-11-09 18:58:28 -08:00
Grace Guo
966a826720
fix: js unit test when save dash (#11632) 2020-11-09 17:56:30 -08:00
Evan Rusackas
d315dd96f0
style: fixing tall filter indicators (#11631) 
Co-Authored-By: Evan Rusackas <evan@preset.io>
 2020-11-09 16:17:32 -08:00
David Aaron Suddjian
5be1dbe28b
feat(dashboard): leaner filter indicator panel with wrapped text (#11592) 
* feat(dashboard): leaner filter indicator panel with wrapped text

* remove summary from filter indicator panel
 2020-11-09 14:23:43 -08:00
Kamil Gabryjelski
0c6aeef927
Fix datetime picker issues (#11621) 2020-11-09 14:13:27 -08:00
Grace Guo
b9284d3a3c
fix(dashboard): use server-side lastModifiedTime for co-edit check (#11614) 
* fix: [dashboard][co-edit] Round client-side lastModifiedTime

* another try: server-side returns last_updated_time in save_dash response
 2020-11-09 13:30:40 -08:00
Lily Kuang
dda95ed250
feat: annotation delete modal, bulk delete and empty state (#11540) 2020-11-09 11:25:16 -10:00
Jesse Yang
92a9acd5c9
fix: minor style touch on dashboards (#11570) 2020-11-08 21:26:56 -08:00
Jesse Yang
6ab03feed8
chore: clean up mountedTab (#11569) 2020-11-08 21:09:27 -08:00
adam-stasiak-polidea
24ba5301d1
Fixed unstable test (#11583) 2020-11-08 17:53:43 -08:00
Kasia Kucharczyk
ea0abbffb4
fix: extended droppable area on the top of dashboards (#11525) 
* Extended droppable area on the top

* Empty dashboard detects almost whole area to place first element
 2020-11-08 17:35:39 -08:00
dependabot[bot]
849e7e9668
build(deps-dev): bump less from 3.9.0 to 3.12.2 in /superset-frontend (#11597) 
Bumps [less](https://github.com/less/less.js) from 3.9.0 to 3.12.2.
- [Release notes](https://github.com/less/less.js/releases)
- [Changelog](https://github.com/less/less.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/less/less.js/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-11-08 10:02:54 -08:00
Evan Rusackas
d86117331d
chore: cleaning out old deckgl controls (#11564) 2020-11-06 22:41:08 -08:00
Phillip Kelley-Dotson
d8373f2bb9
chore(home-screen): fixes for loading states, flicker issue, and reduction of api calls (#11557) 
* fixes for loading states, flicker issue, api calls

* fix filter bug

* add high res images

* bug fixes for cards and face pile, change imgs to svgs, and address comments

* update from comments

* add stopprop

* fix tests

* add liscenses

* remove unused type

* fix types

* add license

* fix lint
 2020-11-06 19:35:13 -08:00
Kamil Gabryjelski
a6bf95e30b
fix: Filter and Metric popovers not closing after clicking Save (#11607) 
* Fix filter popover not closing

* Fix metric popover not closing

* Add e2e tests
 2020-11-06 14:23:12 -08:00
Evan Rusackas
32e52e94e0
style: Wrap chart titles again (#11602) 
* style: letting chart titles wrap again

* deleting comment
 2020-11-06 11:10:45 -08:00
ʈᵃᵢ
79a6e9b0d2
fix(dashboard): order charts by changed_on (#11594) 2020-11-06 11:02:03 -08:00
Kamil Gabryjelski
6d5d92a6fe
fix: Issues with filters and metrics popovers (#11578) 
* Fix bugs in AdhocFilterEditPopover

* Fix bugs in AdhocMetricEditPopover

* Remove handleMultiComparatorInputHeightChange function

* Fix tests
 2020-11-05 20:00:43 -08:00
Kamil Gabryjelski
1490f3074d
refactor: Replace react-bootstrap MenuItems with Antd Menu (#11554) 
* Refactor SliceHeaderControls

* Refactor DisplayQueryButton

* Fix duplicate keys

* Refactor SliceAdder

* Move css from styles to Emotion

* Fix e2e test
 2020-11-05 13:30:03 -08:00
Kasia Kucharczyk
091432ea8e
Changed top overflow for charts. (#11579) 2020-11-05 11:35:41 -08:00
dependabot[bot]
094360392b
build(deps): bump @emotion/core in /superset-frontend (#11518) 
Bumps [@emotion/core](https://github.com/emotion-js/emotion) from 10.0.28 to 10.0.35.
- [Release notes](https://github.com/emotion-js/emotion/releases)
- [Changelog](https://github.com/emotion-js/emotion/blob/master/CHANGELOG.md)
- [Commits](https://github.com/emotion-js/emotion/compare/@emotion/core@10.0.28...@emotion/core@10.0.35)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-11-05 10:26:15 -08:00
dependabot[bot]
39a4a62940
build(deps-dev): bump @storybook/addon-essentials in /superset-frontend (#11573) 
Bumps [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/addons/essentials) from 6.0.13 to 6.0.28.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.0.28/addons/essentials)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-11-05 10:25:10 -08:00
dependabot[bot]
52145f8683
build(deps): bump core-js from 3.2.1 to 3.6.5 in /superset-frontend (#11522) 
Bumps [core-js](https://github.com/zloirock/core-js) from 3.2.1 to 3.6.5.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.2.1...v3.6.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-11-04 22:37:53 -08:00
adam-stasiak-polidea
280ba95e46
chore: Cypress dashboard list selectors refactor (#11314) 
* cypress selectors refactor in dasboard list tests

* fixed tests

* fixes after rebase
 2020-11-04 14:34:21 -08:00
Kamil Gabryjelski
3e35ddd609
refactor: Replace react-bootstrap MenuItems with Antd Menu (#11555) 
* Remove MenuItem from SubMenu

* Fix tests

* Refactor PopoverDropdown

* Refactor Button

* Remove redundant Menu import
 2020-11-04 14:32:38 -08:00
David Aaron Suddjian
ef7087adb6
fix(dashboard): properly unset mountedTab in reducer (#11558) 2020-11-04 14:27:32 -08:00
Beto Dealmeida
d999802795
Front end for VERSIONED_EXPORT (#11559) 2020-11-04 14:22:12 -08:00
Kamil Gabryjelski
128ddfabb6
fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs (#11445) 
* Fix paste not working in Metrics and Filter inputs

* Use noOp instead of empty function

* Use default Select component instead of OnPasteSelect

* Revert onPaste override
 2020-11-04 13:48:48 -08:00
Kamil Gabryjelski
ad98981d9d
refactor: Replace react-bootstrap MenuItems with Antd Menu (#11487) 
* Remove MenuItem from CopyToClipboard

* Refactor DateFilterControl

* fixup! Remove MenuItem from CopyToClipboard

* Remove console log

* Refactor LanguagePicker

* Refactor HeaderActionsDropdown

* Remove dir with Menu component

* Add imports to common/components/index

* Fix after rebase
 2020-11-04 13:47:25 -08:00
Moriah Kreeger
69810170f7
style: database modal updates (#11311) 2020-11-04 11:03:39 -08:00
Moriah Kreeger
094359cc5b
fix: add sort option to filters, sort chart list filter options (#11370) 2020-11-04 11:02:33 -08:00
Kamil Gabryjelski
937f9ca277
refactor: Replace react-bootstrap dialogs with Antd dialogs (#11527) 
* Refactor Dialogs in dashboard properties modal

* Refactor Dialogs in explore properties modal

* Refactor dialogs in DatasourceModal

* Refactor dialogs in ExploreResultsButton

* Remove react-bootstrap-dialog from ExploreCtasResultsButton

* Remove react-bootstrap-dialog dependency

* Remove unnecessary functions from Modal

* Bump antd version to fix a bug

* Fix unit tests

* Fix e2e test

* Change antd version to 4.5.4 to fix tests

* Reenable all tests in control

* Another version bump to fix tests
 2020-11-03 22:07:21 -08:00
Kamil Gabryjelski
15111db6c5
refactor: Use Antd Menu in Menu component (#11528) 
* Menu dropdown refactored

* MenuObject refactored

* Fix unit tests

* Style menu

* Use theme variables
 2020-11-03 16:19:15 -08:00
Moriah Kreeger
536346ff5e
feat: annotation layers delete logic + linking w/ annotation view (#11530) 2020-11-03 13:01:20 -08:00
Lily Kuang
eef4809978
feat: annotation edit modal with antd datepicker (#11500) 2020-11-03 12:59:13 -08:00
ʈᵃᵢ
edb9619731
refactor: reduce number of api calls needed to fetch favorite status for charts and dashboards (#11502) 2020-11-02 21:26:14 -08:00
Jesse Yang
fac29f9dff
refactor: rewrite and enhance chart control withVerification (#11435) 
* refactor: rewrite and enhance chart control withVerification

* Add toasts for failed messages; fixes popover render
 2020-11-02 15:06:20 -08:00
David Aaron Suddjian
d7aa3d792b
fix(dashboard): multiple lines and indentation when editing json (#11501) 
* multiple lines and indentation when editing json

* fix tests, address pr feedback

* remove json minification
 2020-11-02 13:39:04 -08:00
Kamil Gabryjelski
a874b14a8a
refactor: Replace react-bootstrap Tabs with Antd Tabs in DashboardBuilder (#11160) 
* Replace tabs in DashboardBuilder

* Fix tests

* Fix styling of anchor

* Fix

* Fix cypress test

* Fix tests

* Fix e2e tests

* Use data-tests

* Move tabs styles from superset.less to Emotion

* Restyle tabs in DashboardBuilder

* Test fix

* Fix styling
 2020-11-02 13:31:55 -08:00
Hugh A. Miles II
6c6ded139b
fix: Update "View In SQL Lab" Flow to render source query from datasource object (#11476) 2020-11-02 11:44:20 -08:00
Jesse Yang
5d9448f3fe
feat: globally disable underscore for links in menu items (#11491) 2020-11-02 00:03:18 -08:00
Kamil Gabryjelski
19f2deb27f
refactor: Replace react-bootstrap Modals with Antd in Explore (#11389) 
* VizTypeControl

* SaveModal

* explore/PropertiesModal

* Fix e2e tests

* Remove console logs

* Fix tests

* Fix test

* Fix e2e test

* Remove unnecessary fragment

* Fix e2e tests

* Fix e2e test
 2020-11-01 23:04:53 -08:00
Maxime Beauchemin
e3b6dbe62d
chore: run 'npm audit fix', bump react-syntax-highlighter (#11512) 2020-10-31 15:21:46 -07:00
Kamil Gabryjelski
55a3404b71
refactor: Replace react-bootstrap tabs with Antd tabs (#11118) 
* Replace tabs in BuilderComponentPane

* Replace tabs in ControlPanelsContainer

* Replace tabs in AdhocMetricEditPopover

* Replace Tabs in DatasourceEditor

* Replace tabs in AdhocFilterEditPopover

* Replace tabs in DateFilterControl

* Bug fix

* Change Tab styles

* Fix tests

* Fix cypress tests

* Lint fix

* Fix tests

* Change Tabs style in ControlPanelsContainer

* Change tabs content height

* Lint fix

* Add data test

* Fix e2e test

* Move Tabs file to separate dir

* Fix after rebase

* Fix e2e tests

* Fix after rebase
 2020-10-30 22:05:31 -07:00
Moriah Kreeger
01ddbd0697
feat: annotation layers modal + filters (#11494) 2020-10-30 15:51:46 -07:00
dependabot[bot]
5d9560c408
build(deps-dev): bump node-fetch in /superset-frontend (#11485) 
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-10-30 14:19:44 -07:00
dependabot[bot]
fe3fdd27e7
build(deps): bump lodash in /superset-frontend/cypress-base (#11483) 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-10-30 14:19:09 -07:00
Phillip Kelley-Dotson
cd1d89b2b1
fix: import for moment in ActivityTable (#11506) 2020-10-30 13:20:10 -07:00
Erik Ritter
ca40877640
feat: add certifications to tables (#11450) 2020-10-30 11:28:01 -07:00
Phillip Kelley-Dotson
f7051eaade
feat: home screen mvp (#11206) 
* step 1: broken stuff!

* first steps

* more adding and slicing

* step 1: broken stuff!

* can now filter dashboards/charts for "Edited" tabs (filter by changed_by o_m)

* more updates

* update recent card

* add icon

* Adding Expand Icon to Collapse component

* more updates

* clean up code

* remove lock file

* remove consoles

* fixing subnav button height shift

* lil' ascii arrows

* update branch

* update test part 1

* remove consoles

* fix typescript

* add images and update emptystate

* add changes

* update chart card

* fix css issues from rebase

* add suggestions

* more changes

* update tests and clear typescript errors

* Update superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* update from comments

* more updates..

* fix rebase

* fix pesky type errors

* test fixes

* lint fix

* Update superset-frontend/spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/views/CRUD/welcome/EmptyState.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/components/Menu/SubMenu.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/components/ListViewCard/index.tsx

Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>

* Update superset-frontend/src/components/ListViewCard/index.tsx

Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>

* add suggestions

* fix lint

* remove unused code

* toast getrecentActivityobjs

* add some suggestions

* remove types for now

* cypress fix

* remove unused type

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>
 2020-10-29 21:59:31 -07:00
Jesse Yang
93693690a3
feat: disable save button when saving datasource (#11493) 2020-10-29 16:13:47 -07:00
Beto Dealmeida
1d9d905497
fix: prevent race condition when canceling query (#11449) 2020-10-29 14:34:58 -07:00
ʈᵃᵢ
f918ca14aa
fix(datasets): add custom filter for virtual datasets based on sql attribute (#11452) 2020-10-29 13:11:33 -07:00
Kasia Kucharczyk
ed3dca420f
Added z index to resizible char (#11456) 2020-10-29 10:39:35 -07:00
Jesse Yang
e0503408de
feat(explore): change save button text when users cannot override (#11281) 2020-10-29 09:41:29 -07:00
Evan Rusackas
68d493ebf5
fix: dashboard tab only shows move cursor when editing (#11480) 2020-10-29 00:35:32 -07:00
Evan Rusackas
e024267447
fix: Unwinds icon fallout that came along with filters PR (#11474) 
* Unwinds icon revamp that came along with filters PR.

* cleanup/linting

* removing unused import
 2020-10-28 19:44:39 -07:00
David Aaron Suddjian
18658f45be
feat(dashboards): Filter status indicators (#10936) 
* Initial commit of new filters badge.

* refactor applied/rejected filters code

* finished filter indicators

* filter badge tested

* unnecessary imports

* formatting and types

* fixes

* license

* code quality tweaks

* state management for showing focused filter scope

* clean up filter key extraction code

* remove unnecessary styles

* temp css to demonstrate highlighting

* fix focused filter logic

* no more color badges

* new toys for highlighting dash components (#11144)

* tweak style for the filter chart when filter is focused

* style: Filters p0 css2 (#11151)

* nixing background tweak

* src paths

* another quick theme color

* src paths, adjusting pill icon color, changing icons, showing applied/busted counts

* linting stuff

* fixing and tweaking tests

* show filter indicator when filters are not active

* chart title bar cleanup

* open the right panel when popover opens

* unused import

* fix EditableTitle tests

* margin on dashboard header

* show the chart dropdown menu

* fix blur filter breaking dropdowns

* style tweak - no pointer events when irrelevant charts are blurred

* fix box shadow on filter highlight

* it's an array

* attempt fixing e2e

* style: filters p0 icon churn (#11215)

* new filters icon

* icon styling

* bigger icons in list views

* better sizing of table actions and favStars

* more icon sizing...

* fixing more button size jankiness

* linting

* Filters performance (#11255)

* fixing time filter "ok" button

* making unset filter menu collapsible

* sort alphabetically

* fix highlighting when removing items

* try a flex layout (for browser render perf)

* more specific transitioning

* temp: comment out some code as a test

* temp: comment out more code

* temp: remove possibly expensive computations from ChartHolder

* Revert "temp: comment out some code as a test"

This reverts commit 309b880e90.

* Revert "temp: comment out more code"

This reverts commit 64c88b2cba.

* Revert "temp: remove possibly expensive computations from ChartHolder"

This reverts commit 37ce0214f0.

* experiment: upgrade react-select to v3

* Revert "experiment: upgrade react-select to v3"

This reverts commit c3972ba486.

* fix the damn problem

* remove code used for testing purposes

* awful hack to avoid adding a class to a container

* approaching infinity... and not beyond!

* fix ref forwarding

* add theme to tests as necessary

* fix(extra-filters): add logic for identifying applied extra filters (#11325)

* fix: use dashboard id for stable cache key (#11293)

* fix: button translations missing (#11187)

* button translations missing

* blank space before text

* feat: update time_compare description and choices (#11294)

* feat: update time_compare description and choices

* Update sections.jsx

* fix(extra-filters): add logic for identifying applied extra filters

* lint

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* address design feedback

* slight tweak to panel logic, keep panels open that user has opened

* rearrange code to be more graceful

* fix: bump superset-ui/core (#11385)

* use is_dttm instead of is_temporal

* types, names

* only show unset filter panel if there are unset filters

* fix highlighting the filter control

* fix filterbox layout

* translations

* fix cypress

* actually add the test attribute

* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* formatting

* add link comment to hack

* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* stop importing lodash

* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* skip broken test

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* adjust colors of titles

* linting

* no indicators when chart is loading

* support all time fields

* fix lock file

Co-authored-by: Natalie Ruhe <natalie@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
 2020-10-28 15:46:24 -07:00
Moriah Kreeger
e9dba18466
feat: annotation layers CRUD list view (#11432) 2020-10-28 15:45:07 -07:00
Kamil Gabryjelski
52294c836a
refactor: Replace react-bootstrap Modals with Antd in Datasource (#11390) 
* ChangeDatasourceModal

* DatasourceModal

* DeleteModal, AddDatasetModal

* Fix tests

* Remove unused file

* Fix e2e tests

* Fix test

* Remove it.only

* Fix after rebase

* Fix e2e tests

* Fix data-test in modal

* Lint fix
 2020-10-28 14:42:13 -07:00
Ville Brofeldt
e230865216
chore(chart-data): add annotations and url params to chart data schema (#11393) 
* chore(chart-data): add annotations to chart data schema

* bump superset-ui packages

* xit flaky cypress tests
 2020-10-28 23:41:39 +02:00
Lily Kuang
e5e35634de
feat: annotations list CRUD view (#11446) 
* annotations list CRUD view

* comment out modal

* update test

* fix lint
 2020-10-28 12:19:50 -07:00
adam-stasiak-polidea
894b94a345
enabled skipped tests in AdhocMetrics Cypress (#11455) 2020-10-28 10:06:16 -07:00
Kamil Gabryjelski
b2636f01bb
fix: Explore popovers issues (#11428) 
* Fix spaces and comas not working in filter popover

* Fix popup not opening automatically

* Add e2e test

* Remove only from test

* Remove redundant test, add checking label content

* Add comments to e2e test

* Fix unit test

* Use destructuring

* Always open popup for functions and saved metrics, too

* Fix popover for adhoc metrics too

* Small refactor to consistency

* Refactor for consistency

* Remove redundant functions

* Test fix

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
 2020-10-28 09:38:52 -07:00
Evan Rusackas
eecabf9b2e
fix: a space adds the space. (#11401) 
* fix: a space adds the space.

* linting. Ugh.
 2020-10-27 23:47:42 -07:00
Evan Rusackas
68411677e9
fix: Fixing broken Cypress test (#11453) 
* fixing bad data-test selector

* linting

* typo... because I got all excited.
 2020-10-27 22:51:38 -07:00
Kamil Gabryjelski
155b5edec1
refactor: Use Antd Modals instead of react-bootstrap Modals (#11366) 
* Make Modal responsive

* ErrorAlert

* OmniContainer

* dashboard/PropertiesModal

* Fix e2e tests

* Lint fix

* E2E test fix

* Fix test

* Use grid units

* Change padding to padding-left/right
 2020-10-27 13:08:04 -07:00
adam-stasiak-polidea
a99d795eaf
chore: cypress selectors refactor in explore module (#11309) 
* cypress selectors refactor in explore module

* added delay to typing to make test more stable

* fixed missing click
 2020-10-27 13:01:45 -07:00
adam-stasiak-polidea
4bebf51453
chore: Cypress chart selectors refactor (#11312) 
* cypress selectors refactor in chart list tests

* fixed wrong selector
 2020-10-27 11:38:05 -07:00
David Aaron Suddjian
055781f4a9
fix filter highlighting (#11439) 2020-10-27 08:38:24 -07:00
Ville Brofeldt
ecdff724ea
feat: enable metadata sync for virtual tables (#10645) 
* feat: enable metadata sync for virtual tables

* add migration and check for empty schema name

* simplify request

* truncate trailing column attributes for MySQL

* add unit test

* use db_engine_spec func to truncate collation and charset

* Remove redundant migration

* add more tests

* address review comments and apply templating to query

* add todo for refactoring

* remove schema from tests

* check column datatype
 2020-10-27 07:58:38 +02:00
Ville Brofeldt
8575439f48
fix: is_temporal should be overridden by is_dttm value (#11429) 2020-10-27 07:22:27 +02:00
Kasia Kucharczyk
94e0f0cc2a
Moved css of inline inputs of DateFilterControl to css of FilterBox where it appears. (#11427) 2020-10-26 21:50:27 -07:00
Maxime Beauchemin
5b968e9651
fix: multiple issues with FilterPopover (#11412) 
* fix: Custom SQL in FilterPopover

* Also fix #11394

* linting

* fix tests
 2020-10-26 21:48:06 -07:00
adam-stasiak-polidea
df15a6fc51
Configured babel plugin for removing data-test from production code (#11327) 2020-10-26 21:16:02 -07:00
Hugh A. Miles II
fd8f4e9215
feat(explore): update the order of datasource dropdown menu (#11424) 2020-10-26 20:44:44 -07:00
Hugh A. Miles II
81f77fd28e
feat: hide datasource legacy based on featureflag (#11371) 2020-10-26 17:31:29 -07:00
ʈᵃᵢ
2227b13b52
fix: better error messages for dashboard properties modal (#11382) 2020-10-26 16:36:37 -07:00
ʈᵃᵢ
59885c4dea
fix: saved query list sort by database (#11430) 2020-10-26 16:36:03 -07:00
ʈᵃᵢ
910791b00b
fix: better error message for chart properties modal (#11381) 2020-10-26 13:33:19 -07:00
Evan Rusackas
af337b9e5a
Let the header wrap! (#10724) 2020-10-26 13:15:16 -07:00
Kamil Gabryjelski
894ca3c09b
refactor: Use Modals from Antd instead of react-bootstrap (#11330) 
* Refactor ModalTrigger to use antd modal

* Refactor a few components

* dynamic width

* Fix unit tests

* Use i18n for button text
 2020-10-26 11:20:10 -07:00
Kasia Kucharczyk
604a519d8b
fix: keeping Markdown content while resizing window on Dashboard (#11392) 
* Fix: keeping markup content while resizing it

* Added bind and fixed linter

* Added resize case in Markdown editor to cypress test
 2020-10-26 11:12:49 -07:00
Kasia Kucharczyk
ba314c0f6f
Moved frame from below to currently focused window (#11423) 
Thanks for the fix!
 2020-10-26 11:11:51 -07:00
Kamil Gabryjelski
6acae9ab6d
refactor: Replace usages of reactable in TimeTable (#11239) 
* Refactor TimeTable to use react-table

* Fix import

* Refactor TimeTable into functional component
 2020-10-26 10:25:41 -07:00
Jesse Yang
ac498ddd23
chore: upgrade TypeScript (3.8.3 -> 4.0.3) (#11421) 
* chore: upgrade TypeScript (3.8.3 -> 4.0.3)

* Refactor the button component
 2020-10-25 22:01:41 -07:00
Maxime Beauchemin
0ab15373fa
style: fix labels vertical align (#11415) 
* style: fix labels vertical align

* addressed comments

* just adding the space for now

* fix timer
 2020-10-25 17:55:22 -07:00
Jesse Yang
70ea7ae776
fix: error handling for webpack proxy (#11420) 2020-10-25 17:14:56 -07:00
Jesse Yang
8aecffd83b
refactor: typing for explore Control and messageToasts (#11416) 2020-10-24 21:40:36 -07:00
ʈᵃᵢ
d02a61f21c
feat(dashboard): fetch charts by owners instead of created_by (#11336) 2020-10-24 14:43:20 -07:00
adam-stasiak-polidea
f2c89af83f
chore: Fixed skipped cypress test - refresh dashboard function (#11375) 
* Fixed skipped cypress dashboard/controls.test.js and fixed MenuItem setting state to 'loading' while refreshing

* fixed wrong cypress command in test
 2020-10-24 11:29:30 -07:00
Evan Rusackas
efdda8b69e
chore: Button cruft cleanup (#11342) 
* toggleSchedule

* cleaning up run query button

* removing unnecessary (subtle!) style overrides

* bulk action classname to button style prop

* nixing btn-primary

* nixing cancelQuery class

* togglesave

* nixing autocomplete class

* linting

* nixing button classes of 'ok' and 'reset'

* unoing diagnostic test

* begrudgingly adding an m-r-3 class... for now

* this is not a class to worry about

* test fixes for limit control

* updating TODO notes, calling it a day for now.

* gah... copy paste error.
 2020-10-23 10:42:29 -07:00
Kamil Gabryjelski
ad88a06d61
refactor: Use Antd Dropdown instead of react-bootstrap in DatasourceControl (#11395) 
* Create Tooltip component

* Refactor DatasourceControl

* Bug fix

* Lint fix

* E2E test fix

* Move menu item keys to constants

* Remove LESS file

* Test fix

* Test fix

* Lint fix
 2020-10-23 09:08:35 -07:00
Lily Kuang
93d9bd9a04
fix dataset editor for saving schema (#11396) 2020-10-22 21:59:04 -07:00
Evan Rusackas
d64260fc0e
fix: long labels now truncate with ellipsis (#11400) 2020-10-22 18:35:37 -07:00
Elizabeth Thompson
43b92b220f
fix: dashboard edit/save errors (#10834) 
* use conditional operator for lookup

* editing dashboard title should update after save

* uncomment test

* fix json metadata save

* json metadata color scheme should overwrite state

* test's functionality is no longer applicable

* add lastModifiedTime to DashboardInfo
 2020-10-22 14:33:22 -07:00
Kamil Gabryjelski
30c71fd794
refactor: Replace react-bootstrap tabs with Antd tabs on Profile (#11211) 
* Create styled Antd Tabs and Dropdown

* Replace Tabs in Profile view

* Change some hard coded variables to theme

* Lint fix
 2020-10-22 14:19:37 -07:00
Kamil Gabryjelski
dc5e5a978b
refactor: Replace usages of reactable in TableLoader (#11240) 
* Refactor TableLoader to use react-bootstrap

* Remove unnecessary css classes

* Fix import

* Fix styling for no data

* Refactor TableLoader into functional component

* Convert TableLoader to typescript
 2020-10-22 14:00:02 -07:00
Jesse Yang
04ee4a2d08
build: let webpack proxy server handle more content encoding (#11376) 2020-10-22 13:25:17 -07:00
Maxime Beauchemin
64b5aae6bc
style: improve the "Create New Chart" screen's usability (#11383) 
* style: make disabled buttons more readable

* making more of a CTA for VizControl
 2020-10-22 10:16:58 -07:00
Daniel Vaz Gaspar
85e28dd04c
perf(api): improve API info performance (#11346) 2020-10-22 08:55:13 +01:00
Evan Rusackas
6c5da18926
removing outlines on a few key elements (#11372) 2020-10-21 22:02:54 -07:00
Moriah Kreeger
a2a614d760
feat: CSS Templates List Actions (#11271) 2020-10-21 20:32:59 -07:00
Kamil Gabryjelski
9dfe9aef39
Fix overflowing tabs (#11367) 2020-10-21 20:10:52 -07:00
Maxime Beauchemin
69046f08d4
style(sqllab): wrap text in monospace db-provided error messages (#11354) 2020-10-21 17:35:20 -07:00
Maxime Beauchemin
6dd5d5cf26
style: make <Label/> not uppercase (#11355) 2020-10-21 17:29:28 -07:00
Evan Rusackas
6fe7b4a202
feat: adding feature flags to escape/hide html in markdown (#11340) 
* utilizing feature flag for html escapement

* use src alias

* Feature flag to allow hiding of HTML tags

* strips js attr

* better feature flag naming

* simplifying

* Adding comments to new feature flags

* shorter comment, because pylint,

* pedantic change to get black to format a file
 2020-10-21 15:07:27 -07:00
ʈᵃᵢ
225c905bd5
fix(listview): hide actions column if no actions are allowed (#11337) 2020-10-21 09:27:48 -07:00
Evan Rusackas
cae54ac00e
style: using correct + icon on New Query button (#11353) 
* style: using correct + icon on New Query button

* non-meaningful whitespace removed.
 2020-10-20 22:44:11 -07:00
Maxime Beauchemin
796a2a6924
fix: error around latest partition in BigQuery (#11274) 
* fix: error around latest partition in BigQuery

* lint

* Going with a backend-first approach

* fix test

* add an extra test
 2020-10-20 21:34:46 -07:00
Maxime Beauchemin
c360413fc2
style(menu): clean up right menu - leaving only "Settings" (#11227) 
* style(menu): clean up right menu - leaving only settings

* bring pre-commit back

* fix frontend tests

* pre-commit

* re-introduce subtle '+'
 2020-10-20 21:33:28 -07:00
Kamil Gabryjelski
3a0fcdacd3
Fix tabs switching in SouthPane (#11343) 2020-10-20 14:24:27 -07:00
Lily Kuang
6f3d4c131f
feat: css template add/edit modal (#11296) 2020-10-20 12:15:39 -07:00
Lily Kuang
9f8d0e7a06
fix: update table_name and schema on dataset editor (#11218) 
* fix dataset editor for updating table_name and schema

* update test

* remove table_name from restrict list

* fix pylint

* fix cypress test

* fix test
 2020-10-20 09:38:57 -07:00
adam-stasiak-polidea
55ae259b13
chore: Dashboard cypress refactor (#11280) 
* moved dashboard tests to use data-test attributes

* linter

* fix for unstable save test
 2020-10-19 21:36:20 -07:00
Kamil Gabryjelski
9266f0a4a8
refactor: Replace usages of reactable in ChangeDatasourceModal (#11241) 
* Refactor ChangeDatasourceModal to use react-table

* Fix import

* Moved columns declaration out of component scope
 2020-10-19 20:44:21 -07:00
Kamil Gabryjelski
901a42b1df
refactor: Replace usages of Popover from react-bootstrap with Antd (#11163) 
* New popover component

* LimitControl

* Moar components migrated

* TimeSeriesColumnControl

* Hotkeys

* ColorPicker

* FilterBoxItemCOntrol

* AdhocFilterEditPopover

* AdhocMetric

* AnnotationLayerControl

* DateFilterControl

* Tests fix

* Fix linting issue

* Fix tests

* Bug fix

* Test fix

* Remove Antd global stylesheet

* Fix linting

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test
 2020-10-19 20:42:33 -07:00
ʈᵃᵢ
4208ca76e0
refactor: replace AvatarIcon instances with FacePile (#11279) 2020-10-19 20:23:16 -07:00
Kamil Gabryjelski
735123d1f5
refactor: Refactor QueryTable to use react-table (#11216) 
* Refactor QueryTable to use react-table

* Fix lodash import

* Fix tests

* Fix imports and QuerySearch styles

* Update superset-frontend/src/SqlLab/components/QuerySearch.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/SqlLab/components/QuerySearch.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Lint fix

* Refactored QueryTable into functional component

* Remove calculating content height

* Lint fix

Co-authored-by: Evan Rusackas <evan@preset.io>
 2020-10-18 22:32:13 -07:00
Kamil Gabryjelski
31e4a90440
Fix overflowing tab's styling in TabbedSqlEditors (#11303) 2020-10-16 14:23:21 -07:00
Grace Guo
8863c939ad
fix: should update last_modified_time in client-side after save dash (#11305) 2020-10-16 10:54:35 -07:00
Yongjie Zhao
afee008a10
fix CTAS and CVAS buttons invisible (#11300) 2020-10-16 08:02:39 -07:00