Commit Graph

4952 Commits

Author SHA1 Message Date
smileydev 55aef4db3c
fix(chart & alert): make to show metrics properly (#19939)
* fix(chart & alert): make to show metrics properly

* fix(chart & alert): make to remove duplicate metrics

* fix(chart & alert): make to restore metrics control alert slice

* fix(chart & alert): make to fix lint issue
2022-05-16 14:22:47 -06:00
cccs-RyanS ddc01ea781
feat(business-types): initial implementation of SIP-78 (#18794)
* add BUSINESS_TYPE_ADDONS to config with example callback

* Removing uneeded whitespace

* [Work in progress] Modifying cidr function to allow for  single ip and adding port outline

* Added test REST endpoint, added some more ports

I've thrown in a test.py script as well that will try to connect to the
business_type endpoint.

* Moving code from config.py into the business api

Very simple api is exposed that will allow someone to call a checkport
endpoint and get back a response.

* Removing commented out bits.

* Adding fucntion dict back to the config

* Moving business_type endpoint to charts

* Adding schema for get endpoint

* Removing imports, updating docstring, fixing typo

Just some small changes as described in the title.  I've updated the
test.py as well so it functions with the endpoint changes.

* Adding translation dict

* Fixing ops

* Adding check for list

* Modifying changes to add quotes where needed

Also changed BusinessTypeResponse to resp.

* Adding in some code to call the filter config

If a column starts with "cidr_" it will call the code in config.py to
try to translate the filter.  Nothing is changed in the JSON being
executed, just some information is dumped to console.

* Porting Ryan's changes

* Adding migration script (as per Ryan's PR)

* Fixing typo

* Prettier fixes

* [CLDN-1043] Adding rough version of filter changes for business types

* fix down migration

* Fixing bugs after merge

* adding functionality to appy filters in back end

* Fixing linting issues

* fix down revision

* Changing conversion callback to handle multiple values at once

* Adding string representation of values

* Code cleanup plus fixing debouce to only be called once for each entry

* Removing non needed logginh

* Changing operator list to use sting values

* Using text value operators

* Removing clear operator call

* Moving business type endpoints

* fix down revision

* Adding port functions

* update migration

* fix bad rebase and add ff

* implement validator

* dont add invalid values to response

* [CLDN-1205] Added a new exception type for a business type translation error. Added the error message in the display_value field within the business type response. Modified the IP and Port business types to populate the error message field in the response if an error occurs

* [CLDN-1205] Added meaningful error message for port translation errors

* Removing status field from businesstype Response and adding in error message

* [CLDN-1205] Added check to make sure the port business type is within the valid range of ports, if it is not, it will populate the error message

* [CLDN-1205] Fixed the if statement that checks to see if the string_value is in the valid range of port numbers. It did not corrently verify this before now.

* [CLDN-1205] Fixed an error where it was trying to use string_value in <= statements. I just casted string_value to an integer if it is numeric, which allows <= operators to be used on it

* [CLDN-1207] Added unit tests for the cidr_func and port_translation_func functions which are located in /superset/config.py

* [CLDN-1207] removed the assertRaises line as it does not work with the cidr_func and port_translation_func functions

* [CLDN-1207] Added the skeleton of the test_cidr_translate_filter_func unit test, still need to update what the expected response from the function will be.

* [CLDN-1207] Added the remainder of the back-end unit tests for the business types

* [CLDN-1207] Fixed the syntax error which caused the test_cidr_translate_filter_func_NOT_IN_double unit test to fail

* [CLDN-1207] Removed the logging that was added for debugging purposes

* [CLDN-1207] Formatted the commands_tests.py file to make it nicer to look at/read through

* [CLDN-1207] Fixed the code so that it conformed to the pylint requirements (i.e., pylint no longer complains about the code in commands_tests.py)

* [CLDN-1207] Modified some of the docstrings so they made better use of the 100 character per line, line limit

* [CLDN-1207] Added the beginnings of the unit tests for the
business types API

* [CLDN-1207] Added a comment to the top of the commands_tests.py file explaining how to run the unit tests. This prevents the next person who tries to run them from having to waste time trying the different forms of testing that Superset supports (e.g., pytest, tox, etc.)

* [CLDN-1207] Added a grammar fix to the comments describing how to run the unit tests

* [CLDN-1207] Modified the description of the business_type API endpoints as they did not represent what the API was actually doing

* [CLDN-1207] Added further instructions on how to run the unit tests that are within the business_type/api_tests.py file

* add request validation

* disable request if business type missing

* [CLDN-1207] Unit tests for the business type API are now working, however, they need to be modified to make use of @mock as we don't want to have to run the server to be able to run the unit tests

* Removing businesss types deffinitons from config

* Adding select to only show valid business types

* Fixed Enzyme tests

* Added scalfolding for selecting filter dropdown

* Adding intigration tests

* fix revision

* fix typos and unnecessary requests

* break out useBusinessTypes

* Added front-end RTL unit tests for the business type API endpoint

* Fixed error from unit tests

* Added a unit test to ensure the operator list is updated after a business type API response is received

* Removing elect compoenet for business types

* Adding feature flag and allowing saving when no business type present

* fixing useEffect hooks

* Adding feature flag to model

* Changing behavior such that an empty string returns a default response

* add form validation

* Modified comments in unit test as command to run test has changed

* Modified comments in unit test as filename to run test has changed

* Modified the api_tests.py file to conform to the linting requirements

* Changed the name of one of the tests to reflect what the test is actually testing

* Added cypress back to the package.json

* Added informative comments

* Updated comments in files as well as removed imports which were not being used

* Changes made by npm run prettier

* Fixed spelling mistakes

* Updated models.py to remove placeholder comments used in development

* Added feature flag mocking in unit test

* Fixing open api failure

* Fixing business types to pass unit tests

* Reverting unsafe connections back to false

* Removing print statement

* Adding business tpye to export test

* setting default feature flag to false for business type

* Reverting pre commit

* Reverting pre commit and running pre commit

* Reverting pre commit and running pre commit

* Fixing formatting

* Adding license

* Fixing Linting

* Protecting api enpoints

* updating model

* Fixing code path when business type exists

* Linting

* Linting

* Fixing linting

* Fixing spelling

* Fixing schemas

* Fixing app import

* fixing item render

* Added RTL test to make sure business type operator list is updated after API response

* Fixing linting

* fix migration

* Changing unit tests

* Fixing import and DB migration after rebase

* Renaming to advanced types

* Fixing Linting

* More renaming

* Removing uneeded change

* Fixing linting and test errors

* Removing unused imports

* linting

* Adding more detailed name for migration

* Moving files to plugins

* more renaming

* Fixing schema name

* Disabling feature flag that should not be enabled by default

* Adding extra cehck

* NameChange

* formatting

* Fixing equals check

* Moveing all advanced type classes and types to one file, and converting tests to functional

* Adding advanced type to test and fix linitng

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Dan Parent <daniel.parent@cse-cst.gc.ca>
Co-authored-by: GITHUB_USERNAME <EMAIL>
Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com>
2022-05-16 17:58:21 +03:00
Stephen Liu 9854d2d0e8
feat(plugin-chart-echarts): support horizontal bar chart (#19918)
* feat(plugin-chart-echarts): support horizontal bar chart

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* improve controlpanel

* default value

* fix ut

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-05-16 21:48:36 +08:00
Ville Brofeldt d5802f7896
fix(generic-axes): apply contribution before flatten (#20077) 2022-05-16 16:26:31 +03:00
smileydev 1c3c3ae2ea
fix(CRUD): make to fix the dancing when crud view is on hover (#20051)
* fix(CRUD): make to fix the dancing when crud view is on hover

* fix(CRUD): make to restore font size property
2022-05-15 21:51:57 -06:00
smileydev f43dbc0dfd
fix(chart & gallery): make to add mixed time-series into recommended charts (#20064) 2022-05-14 11:20:49 +08:00
Jesse Yang 6139057dcf
test: make tabbed dashboard a little more complex (#19966) 2022-05-13 17:31:23 -07:00
Diego Medina c6dd7fedbd
fix: The dynamic form to connect to Snowflake DB is not returning any errors (#20013)
* fix: The dynamic form to connect to Snowflake DB is not returning any errors

* PR comment
2022-05-13 12:50:11 -06:00
Diego Medina dbc653d442
feat: Explore popovers should close on escape (#19902)
* feat: Explore popovers should close on escape

* review comments
2022-05-13 12:28:39 -06:00
Kamil Gabryjelski 3043a54bfc
feat(dashboard): Rearrange items in chart header controls dropdown (#20049)
* feat(dashboard): Rearrange items in chart header controls dropdown

* Fix download as image and tests
2022-05-13 19:07:19 +02:00
Kamil Gabryjelski 0f68deedf1
perf(plugin-chart-table): Add memoization to avoid rerenders (#19976)
* perf(plugin-chart-table): Add memoization to avoid rerenders

* Fix typing
2022-05-13 18:10:48 +02:00
Stephen Liu 35e6e2709c
fix(plugin-chart-echarts): tooltip of big number truncated at then bottom (#20029) 2022-05-13 22:51:42 +08:00
Stephen Liu e625c03cd5
feat(viz-gallery): add search weight for viz-name (#19581) 2022-05-13 22:51:01 +08:00
Kamil Gabryjelski 1cd002e801
chore: Create a generic header component for Explore and Dashboard (#20044)
* chore: Create a generic header component for Explore and Dashboard

* Add tests

* Fix undefined error

* Remove duplicate code

* Fix cypress test
2022-05-13 15:36:18 +02:00
Ville Brofeldt b53daa91ec
fix(plugin-chart-echarts): support adhoc x-axis (#20055)
* fix(plugin-chart-echarts): support adhoc x-axis

* simplify code
2022-05-13 16:29:51 +03:00
Michael S. Molina fff9ad05d4
fix: Fixes Tabs style (#20050) 2022-05-12 16:49:51 -03:00
Michael S. Molina a051d91493
chore: Changes the no-literal-colors lint rule to throw errors instead of warnings (#20034) 2022-05-12 15:07:56 -03:00
smileydev ded9122ceb
fix(homepage): make to show indicator when tab is choosen (#20048) 2022-05-12 11:17:49 -06:00
Michael S. Molina c4c714fffb
chore: Removes hard-coded colors from the plugins - iteration 2 (#20006)
* chore: Removes hard-coded colors from the plugins - iteration 2

* Fixes lint errors
2022-05-12 10:12:17 -03:00
Kamil Gabryjelski ca9766c109
feat(explore): Show confirmation modal if user exits Explore without saving changes (#19993)
* feat(explore): Show confirmation modal if user exits Explore without saving changes

* Fix calling cleanup func unnecessarily

* Fix comparing AdhocMetric instance with JSON object

* Replace sliceFormData with the initial form data
2022-05-12 12:24:29 +02:00
smileydev 26c81a70e7
fix(chart & filters): make to padding between textarea and buttons (#20026)
* fix(chart & filters): make to padding between textarea and buttons

* fix(chart & filters): make to change static pixel to them.gridUnit

* fix(chart & filters): make to fix lint issue
2022-05-12 15:54:21 +08:00
Evan Rusackas 60188ef654
feat(css): adds `chartId`-based class to dashboard chart holder (#19873)
* feat: adds `chartId`-based class to dashboard chart holder

* Adding comment to denote the purpose of the class in the code.
2022-05-11 15:44:37 -06:00
Lily Kuang 3e36d4a0a1
fix(embedded): third party cookies (#20019)
* debugging

* logging

* add comment

* remove logging

* Update superset-frontend/packages/superset-ui-core/src/connection/callApi/callApi.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-05-11 14:42:46 -07:00
AAfghahi fd611d7653
refactor: Refactor reports for Charts and Dashboards (#19130)
* bumping shillelagh

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* Preset io ch28954 refactor reports (#19129)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* refactoring reports

* ready for review

* added testing

* removed user reducer

* elizabeth suggestions

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

* deleted additional folder

* fixing tests

* all but styling

* bumping shillelagh

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* Preset io ch28954 refactor reports (#19129)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* refactoring reports

* ready for review

* added testing

* removed user reducer

* elizabeth suggestions

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

* deleted additional folder

* fixing tests

* all but styling

* fixed tests

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-05-11 14:19:51 -04:00
Michael S. Molina 8bb8b7f612
chore: Removes hard-coded colors - iteration 3 (#20016) 2022-05-11 15:02:13 -03:00
Etienne Baratte 2e31021ecd
fix: fix word cloud randomness (#19977) 2022-05-11 22:56:09 +08:00
Michael S. Molina a7e3d6b964
chore: Upgrades Storybook from 6.4.19 to 6.4.22 (#20008) 2022-05-11 10:09:03 -03:00
Diego Medina cede148d46
fix: native filter truncation rerendering loop on hover (#20021) 2022-05-11 09:37:43 +02:00
Diego Medina cc026e9fec
fix: URI form is blank when trying to connect from sql lab (#20004) 2022-05-11 08:57:11 +08:00
Daniel Vaz Gaspar 87a4379d0a
feat: deprecate /superset/validate_sql_json migrate to api v1 (#19935)
* feat: deprecate /superset/validate_sql_json migrate to api v1

* use new error handling

* migrate SQLLAb frontend and add tests

* debug test

* debug test

* fix frontend test on sqllab

* fix tests

* fix frontend test on sqllab

* fix tests

* fix tests

* fix tests

* fix tests
2022-05-10 21:25:39 +01:00
Smart-Codi 9376940282
fix: Table chart column config issue (#19841)
* Fix table chart column config issue

* resolve comment
2022-05-10 14:22:48 -06:00
Luis Casillas 35db7fb6c5
fix: Making chart update more truthful (#19877)
* Update index.jsx

* Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx

Fixing case

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-05-10 14:20:56 -06:00
Michael S. Molina b7cff8335b
chore: Removes hard-coded colors from the plugins - iteration 1 (#19923)
* chore: Removes hard-coded colors from the plugins - iteration 1

* Fixes lint errors

* Fixes tests
2022-05-09 10:44:13 -03:00
Geido d0b8b1e97d
feat: Applitools Cypress workflow (#19956)
* WIP

* Attempt Github Actions integration

* Add completion notification to workflow

* Update env

* Add new line

* Add license

* Fix whitespaces

* Fix Yaml indentation

* Fix afterEach

* Add initial tests

* Update config

* Use test secret

* Clean up

* Add batchName

* Disable logs - add secret

* Create separate workflow

* Clean up

* Update workflow

* Exclude applitools tests

* Update jobs name

* Run applitools tests separetely

* Fix path pattern

* Run once

* Add more initial tests

* Enhance tests

* Add dashboard edit mode test

* Move env

* Exclude applitools from sqllab test run

* Attempt pull_request_target

* Catch Applitools failures

* Clean up tests

* Add test step

* Add test step

* Remove step

* Fix SqlLab test

* Update CURL request

* Fix Yaml

* Add empty data to batch completion
2022-05-09 15:42:20 +02:00
Geido c3ba86ecc5
feat: Run Applitools on public Storybook (#19852)
* Test storybook workflow

* Add test workflow

* Fix eof

* Update workflow

* Install apt dependencies

* Schedule nightly

* Enhance workflow

* Add secret Applitools key

* Update config

* Add batchName
2022-05-09 14:17:22 +02:00
Ville Brofeldt f144de4ee2
Revert "chore(deps): bump d3-svg-legend in /superset-frontend (#19846)" (#19972)
This reverts commit 528a9cd7c7.
2022-05-06 13:11:41 +03:00
Diego Medina 7b5ba39029
fix: Fix auto-reversion of label/title in the Metrics popover (#19889) 2022-05-05 22:30:33 -06:00
Smart-Codi 0eb519c70b
add cy test for downloading chart as image (#19963) 2022-05-05 17:39:14 -06:00
Jesse Yang 54bfd8375a
chore: convert URLShortLinkButton to typescript (#19954) 2022-05-05 13:36:37 -07:00
Luis Casillas 7c3fd06fd6
style approach (#19903) 2022-05-05 14:29:09 -06:00
Jesse Yang 7b88ec7e25
refactor(ReportModal): simplify state reducer and improve error handling (#19942) 2022-05-05 10:06:40 -07:00
smileydev 902ac05372
fix(chart & table): make to allow highlight in case of numeric column (#19938)
* fix(chart & table): make to allow highlight in case of numeric column

* fix(chart & table): make to use emitFilter directly

* fix(chart & table): make to use styled component instead of inline style
2022-05-04 14:20:57 -06:00
Elizabeth Thompson 060b5c0e17
chore: remove druid datasource from the config (#19770)
* remove druid datasource from the config

* remove config related references to DruidDatasource

* Update __init__.py

* Update __init__.py

* Update manager.py

* remove config related references to DruidDatasource

* raise if instance type is not valid
2022-05-04 12:48:48 -07:00
cccs-Dustin 7d3437a98e
Modified the markdown component so that the inner column's handle's mouse target is larger (#19839) 2022-05-04 12:29:49 -07:00
Daniel Vaz Gaspar 4fdf230a56
feat: deprecate /superset/extra_table_metadata migrate to api v1 (#19921)
* feat: deprecate /superset/extra_table_metadata migrate to api v1

* use can_read to table_extra_metadata

* troubleshoot sqlite

* fix test

* fix test

* fix test

* fix frontend test on sqllab
2022-05-04 14:55:52 +01:00
Michael S. Molina e9032e95ec
chore: Adds theme object to chart properties (#19951) 2022-05-04 09:55:22 -03:00
Yongjie Zhao 24e4ab6a1f
fix: can not correctly set force in store (#19932)
* fix: can not correctly set force in store

* fix ut
2022-05-03 14:37:36 -06:00
David Aaron Suddjian 7f8279b4b3
chore: get embedded user with roles and permissions (#19813)
* feat: get user roles endpoint

* add tests

* fix test

* get user with permission and roles with full user

* frontend

* type juggling

* the hash slinging slasher

* user reducer and action

* make it happy

* result

* lint

Co-authored-by: Lily Kuang <lily@preset.io>
2022-05-03 12:58:06 -07:00
Michael S. Molina 7657e42cff
chore: Adds a storybook to FilterableTable (#19897) 2022-05-03 15:08:10 -03:00
smileydev 7b3d0f040b
feat(chart & legend): make to enable show legend by default (#19927) 2022-05-02 14:37:11 -06:00
Luis Casillas 1fa841ee29
Revert "fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode (#19362)" (#19906)
This reverts commit 6d5d03e592.
2022-05-02 11:45:43 -06:00
dependabot[bot] 6bd025d8d2
chore(deps): bump react-virtualized-auto-sizer in /superset-frontend (#19916)
Bumps [react-virtualized-auto-sizer](https://github.com/bvaughn/react-virtualized-auto-sizer) from 1.0.2 to 1.0.6.
- [Release notes](https://github.com/bvaughn/react-virtualized-auto-sizer/releases)
- [Commits](https://github.com/bvaughn/react-virtualized-auto-sizer/commits)

---
updated-dependencies:
- dependency-name: react-virtualized-auto-sizer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-02 11:24:49 -06:00
smileydev 741033e87d
fix(column-header-tooltip): make that hide the tooltip when the cloum… (#18988)
* fix(column-header-tooltip): make that hide the tooltip when the cloumn header is turncated

* fix(column-header-tooltip): fix lint

* fix(column-header-tooltip): make to dynamic tooltip header in FilterTable

* fix(column-header-tooltip): make to fix the lint issue

* fix(column-header-tooltip): make to remove the tooltip option

* fix(column-header-tooltip): make to add test and storybook for dynamic tooltip

* fix(column-header-tooltip): make to fix lint
2022-05-02 10:11:27 -06:00
Daniel Vaz Gaspar 85b0ef8526
feat: deprecate old API on core superset fave_dashboards (#19754)
* feat: deprecate old API on core superset fave_dashboards

* fix js lint

* remove unused type
2022-05-02 16:24:48 +01:00
dependabot[bot] b975eeee87
chore(deps-dev): bump eslint-plugin-prettier in /superset-frontend (#19894)
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 3.3.1 to 4.0.0.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-plugin-prettier/compare/v3.3.1...v4.0.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-29 16:20:53 -06:00
Hugh A. Miles II 8b15b68979
fix: Alpha should not be able to edit datasets that they don't own (#19854)
* fix api for checking owners

* fix styles for disabling

* fix styles for disabling

* fix lint

* fix lint

* add owners key

* plzz

* remove

* update test

* add tooltip

* add type

* fix test

* fix user reference

* lit

* fix test

* work
2022-04-29 14:21:05 -07:00
Smart-Codi 7cfd892bb9
fix: Set fixed maxWidth of the cron schedule modal (#19485)
* fix: Set fixed maxWidth of the cron schedule modal

* resolve comment

* resolve comment
2022-04-29 12:32:54 -06:00
Smart-Codi c2999fdc22
fix: Chart download as image issue (#19885) 2022-04-29 12:23:54 -06:00
dependabot[bot] 9328053521
chore(deps-dev): bump @storybook/client-api in /superset-frontend (#19878)
Bumps [@storybook/client-api](https://github.com/storybookjs/storybook/tree/HEAD/lib/client-api) from 6.4.19 to 6.4.22.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.22/lib/client-api)

---
updated-dependencies:
- dependency-name: "@storybook/client-api"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-28 15:57:48 -06:00
smileydev ea6753d27d
fix(allow-db-explore): make to check the allow virtual table explore option by default (#19883)
* fix(db & explore): make to check the allow-db-explore option by default

* fix(db-explore): make to remove console.log
2022-04-28 12:52:33 -07:00
Jinghuayao ad1338fb47
test(native filter): refactor and add new test (#19821)
* refactor and add new test

* fix lint

* fix fail test

* fix front end error

* fix frontend error

* fix fail test for front end check

* add native filter helper

* more changes

* seperated test for different state

* seperated tests by initail state

* fix failure

* one more fix

* enable test
2022-04-28 09:41:22 -07:00
Stephen Liu 11562971fb
fix(plugin-chart-echarts): [feature parity] annotation line chart color not working (#19758) 2022-04-28 19:10:58 +03:00
Ville Brofeldt d5ea537b0e
fix(plugin-chart-handlebars): fix overflow, debounce and control reset (#19879)
* fix(plugin-chart-handlebars): fix overflow

* add debounce, fix reset controls

* fix deps

* remove redundant code

* improve examples

* add last missing resetOnHides

* fix test

* use isPlainObject
2022-04-28 16:38:23 +03:00
Geido 1d50665da0
Remove font-size hacky usage (#19613) 2022-04-28 11:38:17 +02:00
Geido 0e68e42b7c
Remove hacky font-sizes (#19616) 2022-04-28 11:38:04 +02:00
Geido ed1309e6bd
fix: Dates alignment in Table viz (#19668)
* Fix dates alignment

* Add package lock changes

* Update package-lock

* Clean up
2022-04-28 11:37:49 +02:00
Ville Brofeldt 3d2fec9604
chore: fix explore pills (#19866)
* chore: fix explore pills

* fix tests

* address comments

* add test and remove redundant div

* switch to dark text
2022-04-28 10:28:47 +03:00
Diego Medina e4fca89217
fix: Cannot re-order metrics by drag and drop (#19876)
* fix: cannot-re-order-metrics-by-drag-and-drop

* add tests
2022-04-27 20:37:12 -06:00
smileydev 59ee029088
feature(filter): make to hide sort filter when time range (#19871) 2022-04-27 14:07:59 -06:00
smileydev 4a835a4299
fix(dashboard-css): make to load saved css template (#19840)
* fix(dashboard-css): make to load saved css template

* fix(dashboard-css): make to update state css with componentDidMount

* fix(dashobard-css): make to inject custom css after updateCss

* fix(dashboard-css): make to add RTL for custom css

* fix(dashboard-css): make to fix lint issue
2022-04-27 10:57:15 -06:00
Yongjie Zhao f5e9f0eb3b
feat: add Advanced Analytics into mixed time series chart (#19851) 2022-04-27 23:36:19 +08:00
dependabot[bot] 795da71751
chore(deps): bump react-syntax-highlighter in /superset-frontend (#19864)
Bumps [react-syntax-highlighter](https://github.com/react-syntax-highlighter/react-syntax-highlighter) from 15.4.5 to 15.5.0.
- [Release notes](https://github.com/react-syntax-highlighter/react-syntax-highlighter/releases)
- [Changelog](https://github.com/react-syntax-highlighter/react-syntax-highlighter/blob/master/CHANGELOG.MD)
- [Commits](https://github.com/react-syntax-highlighter/react-syntax-highlighter/compare/v15.4.5...15.5.0)

---
updated-dependencies:
- dependency-name: react-syntax-highlighter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-27 08:19:34 -06:00
Stephen Liu f9d28a1072
chore: add eslint custom plugin to prevent translation variables (#19828) 2022-04-27 17:44:13 +08:00
Erik Ritter ad878b07e4
fix: Dashboard report creation error handling (#19859) 2022-04-26 21:52:58 -07:00
Erik Ritter 768e4b7a54
fix: Update eslint error message to reflect location of antd components (#19857) 2022-04-26 21:12:43 -07:00
Smart-Codi 60e06c1692
feat: Update ShortKey for stop query running in SqlLab editor (#19692)
* feat: Update shortkey for stop query running in sqllab editor

* resolve comment

* fix invalid import useMemo
2022-04-26 21:12:47 -06:00
smileydev 1d043e53d0
fix(db & connection): make to show/hide the password when only creating db connection (#19694)
* fix(db & connection): make to show/hide the password when only creating db connection

* fix(db & connection): make to fix unit test of Database Modal
2022-04-26 16:26:07 -06:00
Diego Medina d65b77ec7d
fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options (#19778)
* fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options

* fix package.json

* fix lint
2022-04-26 16:25:40 -06:00
dependabot[bot] dc0f09586f
chore(deps): bump react-split from 2.0.9 to 2.0.14 in /superset-frontend (#19845)
Bumps [react-split](https://github.com/nathancahill/split) from 2.0.9 to 2.0.14.
- [Release notes](https://github.com/nathancahill/split/releases)
- [Changelog](https://github.com/nathancahill/split/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nathancahill/split/commits)

---
updated-dependencies:
- dependency-name: react-split
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-26 14:20:38 -06:00
dependabot[bot] 528a9cd7c7
chore(deps): bump d3-svg-legend in /superset-frontend (#19846)
Bumps [d3-svg-legend](https://github.com/susielu/d3-legend) from 1.13.0 to 2.25.6.
- [Release notes](https://github.com/susielu/d3-legend/releases)
- [Commits](https://github.com/susielu/d3-legend/compare/v1.13.0...v2.25.6)

---
updated-dependencies:
- dependency-name: d3-svg-legend
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-26 14:20:19 -06:00
dependabot[bot] 5877470aee
chore(deps-dev): bump eslint-plugin-jsx-a11y in /superset-frontend (#19847)
Bumps [eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y) from 6.4.1 to 6.5.1.
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/CHANGELOG.md)
- [Commits](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/compare/v6.4.1...v6.5.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsx-a11y
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-26 14:19:40 -06:00
Diego Medina 7645eac31f
fix: Regression on Data and Alerts & Reports Headers (#19850) 2022-04-26 14:08:07 -06:00
Josh Soref bebb10e495
chore(frontend-tests): Spelling (#19853)
* spelling: against

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: been

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: charts

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: clicking

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: columns

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: duplicate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: especially

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extensions

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fields

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: filter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: for

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: label

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: labeled

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: nativefilter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: registry

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: render

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: resizable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: response

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: successful

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: transform

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unfortunately

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: until

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: virtual

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: wrapper

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2022-04-26 10:35:01 -07:00
Josh Soref c32c505742
chore(docs): Spelling (#19675)
* spelling: adding

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: aggregate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: avoid

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: blacklist

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cached

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: discontinue

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exhaustive

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: from

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: github

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: hybrid

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: implicit

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: interim

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: introduced

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: javascript

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: logstash

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: metadata

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: password

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: recommended

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: redshift

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: refactored

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: referencing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: sqlite

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: the

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: thumbnails

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: undoes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: very

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2022-04-26 13:17:15 -03:00
Yongjie Zhao 25e572a56e
fix: count(distinct column_name) in metrics (#19842) 2022-04-26 20:03:55 +08:00
Jeremy e632b82395
feat: Adds plugin-chart-handlebars (#17903)
* adds: plugin chart handlebars

* adds: handlebars plugin to main presets

* update: npm install

* chore: lint

* adds: dateFormat handlebars helper

* deletes: unused props

* chore: linting plugin-chart-handlebars

* docs: chart-plugin-handlebars

* adds: moment to peer deps

* update: use error handling

* update: inline config, adds renderTrigger

* update: inline config, adds renderTrigger

* camelCase controls

* (plugins-chart-handlebars) adds: missing props

Adds missing propeties in test formData

* (plugin-chart-handlebars) fixes test

* (plugin-handlebars-chart) use numbers for size

* (feature-handlebars-chart) fix viz_type

* (plugin-handlebars-chart) revert

revert the viz_type change. it was in the wrong place.

* fix test and add license headers

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-04-26 14:34:28 +03:00
Ville Brofeldt 2dafff12ef
fix(explore): ignore temporary controls in altered pill (#19843) 2022-04-26 11:58:47 +03:00
dependabot[bot] 28742e5474
chore(deps-dev): bump babel-loader in /superset-frontend (#19829)
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.2.4 to 8.2.5.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel-loader/compare/v8.2.4...v8.2.5)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-25 12:27:21 -06:00
dependabot[bot] 69aeff911b
chore(deps): bump react-hot-loader in /superset-frontend (#19830)
Bumps [react-hot-loader](https://github.com/gaearon/react-hot-loader) from 4.12.20 to 4.13.0.
- [Release notes](https://github.com/gaearon/react-hot-loader/releases)
- [Changelog](https://github.com/gaearon/react-hot-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/gaearon/react-hot-loader/compare/v4.12.20...v4.13.0)

---
updated-dependencies:
- dependency-name: react-hot-loader
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-25 12:26:59 -06:00
dependabot[bot] 523bd8b79c
chore(deps-dev): bump babel-loader in /superset-frontend (#19403)
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.2.2 to 8.2.4.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel-loader/compare/v8.2.2...v8.2.4)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-24 22:53:52 -06:00
dependabot[bot] fbedfa3838
chore(deps): bump moment from 2.29.1 to 2.29.2 in /superset-frontend (#19637)
Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.29.1...2.29.2)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-24 22:53:26 -06:00
dependabot[bot] f8f057d7be
chore(deps): bump async in /superset-frontend/cypress-base (#19681)
Bumps [async](https://github.com/caolan/async) from 3.2.0 to 3.2.3.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/master/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v3.2.0...v3.2.3)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-24 22:53:04 -06:00
Diego Medina 800ced5e25
fix(sql lab): when editing a saved query, the status is lost when switching tabs (#19448) 2022-04-22 15:23:30 -06:00
Diego Medina 3f0413b8cb
fix: Cypress tests reliability improvements (#19800) 2022-04-22 14:57:25 -06:00
dependabot[bot] 0cc2d71d1a
chore(deps): bump url-parse from 1.5.7 to 1.5.10 in /superset-frontend (#19020)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-22 14:51:10 -06:00
dependabot[bot] e98199d43d
chore(deps): bump @types/d3-time in /superset-frontend (#17978)
Bumps [@types/d3-time](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/d3-time) from 1.1.1 to 3.0.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/d3-time)

---
updated-dependencies:
- dependency-name: "@types/d3-time"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-22 14:50:43 -06:00
Phillip Kelley-Dotson ad715429f9
chore: simplify error messaging in database modal (#19165)
* testing for dbconn modal error message

* remove consoles and error alert mapping

* lint fix

* update url message

* add modal fix

* update comments

* fix err msg bugs

* fix pylint

* fix line

* fix tests

* fix assertions
2022-04-21 12:44:21 -07:00
Kamil Gabryjelski 12bc30e2c7
Fix display of column config in table chart (#19806) 2022-04-21 19:08:04 +02:00
Yongjie Zhao 108a2a4eaf
fix: lost renameOperator in mixed timeseries chart (#19802) 2022-04-21 15:20:09 +08:00
smileydev dfbaba97c6
fix(chart & explore): Show labels for `SliderControl` (#19765)
* fix(chart & explore): make to show label of slidercontrol

* fix(chart & explore): make to update SliderControl props

* fix(chart & explore): make to fix lint
2022-04-20 13:58:25 -06:00
Diego Medina 7f22edfd06
fix: remove & reimplement the tests for AlertReportCronScheduler component (#19288) 2022-04-20 13:51:09 -06:00
serenajiang 5e468f7a4c
fix(world-map): remove categorical color option (#19781) 2022-04-20 09:36:28 -07:00
Kamil Gabryjelski fcc8080ff3
fix(plugin-chart-table): Resetting controls when switching query mode (#19792) 2022-04-20 17:25:31 +02:00
Stephen Liu e3a54aa3c1
feat(explore): improve UI in the control panel (#19748)
* feat(explore): improve section header of control panel

* fix checkbox control color and radio button color
2022-04-20 15:06:33 +02:00
Yongjie Zhao 4f997cd9ac
chore: fix grammar error (#19740) 2022-04-20 21:02:14 +08:00
Yongjie Zhao 3c28cd4625
feat: add renameOperator (#19776) 2022-04-20 19:48:12 +08:00
Diego Medina dfba9ea596
fix: SQL Lab UI Error: Objects are not valid as a React child (#19783) 2022-04-20 09:18:46 +03:00
Diego Medina 1c5d3b73df
fix: dashboard top level tabs edit (#19722) 2022-04-19 16:57:30 -06:00
Ville Brofeldt e061955fd0
fix(dashboard): copy permalink to dashboard chart (#19772)
* fix(dashboard): copy permalink to dashboard chart

* lint

* address comments
2022-04-19 22:34:41 +03:00
Jesse Yang 4ba62cad95
chore(build): upgrade less-loader (#19703) 2022-04-19 09:18:16 -07:00
Kamil Gabryjelski 3663a33f14
fix(explore): Double divider if no permissions for adding reports (#19777) 2022-04-19 17:47:35 +02:00
Kamil Gabryjelski 6f4480a06c
feat(explore): Replace overlay with alert banner when chart controls change (#19696)
* Rename explore alert

* Rename refreshOverlayVisible to chartIsStale

* Implement banners

* Add tests

* Add clickable text to empty state

* Fix viz type switching

* styling changes

* Fixes after rebasing

* Code review fixes

* Fix bug

* Fix redundant refreshing
2022-04-19 14:57:06 +02:00
Kamil Gabryjelski 594523e895
feat(explore): Implement data panel redesign (#19751)
* feat(explore): Redesign of data panel

* Auto calculate chart panel height and width

* Add tests

* Fix e2e tests

* Increase collapsed data panel height
2022-04-19 10:10:40 +02:00
smileydev 34323f9b5f
fix(explore): make to show the null value as N/A in view result (#19603)
* fix(explore): make to show the null value as N/A in view result

* fix(explore): make to remove console

* fix(explore): make to remove console in Cell

* fix(explore): make to translate N/A
2022-04-18 19:26:15 -06:00
smileydev a2d34ec4b8
fix(import): Add the error alert on failed database import (#19673)
* fix(import): make to add the error alert

* fix(import): make to add licence

* fix(import): make to create ErrorAlert component and use errorMessage spelling
2022-04-18 17:43:24 -06:00
Diego Medina a05ff5e598
fix: alert/report created by filter inconsistency with table display (#19518)
* fix: alert/report created by filter inconsistency with table display

* Match column order to dashboard list
2022-04-18 17:41:07 -06:00
Phillip Kelley-Dotson 06ec88eb99
feat: add empty states to sqlab editor and select (#19598)
* feat: add empty states to sqlab editor and select

* add suggestions and test

* update type

* lint fix and add suggestions

* fix typo

* run lint

* remove unused code

* fix test

* remove redux for propagation and other suggestions

* add t

* lint

* fix text and remove code

* ts and fix t in p

* fix spelling

* remove unused prop

* add fn to prop change state

* remove unused code

* remove unused types

* update code and test

* fix lint

* fix ts

* update ts

* add type export and fix test

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* remove handlerror and unused code

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-04-15 15:09:07 -07:00
Diego Medina 154f1ea8c9
fix: Dashboard Edit View Tab Headers Hidden when Dashboard Name is Long (#19472) 2022-04-15 12:58:32 -06:00
Diego Medina 8d4a52c9d0
fix(sql lab): add quotes when autocompleting table names with spaces in the editor (#19311) 2022-04-15 12:55:04 -06:00
Diego Medina bbe0af348b
fix(sql lab): Selecting edit on a query from query history doesn't update the SQL Editor properly (#19290) 2022-04-15 12:49:32 -06:00
Luis Casillas 56381f4ee8
fix: sql lab ctrl t behaved differently from clicking (#19420)
* initial approach

To have consistent behaviour when creating a new tab with ctrl+t

* consistent behaviour when creating tabs

* fixed bug and added tests

* updates to pass checks
2022-04-15 12:28:40 -06:00
Geido b8e595413f
fix: Redirect to full url on 401 (#19357)
* Redirect to full url

* Redirect to full url

* Update test
2022-04-15 20:15:30 +02:00
Kamil Gabryjelski b7759e6fd1
chore: Clean redundant dependency from useMemo dep array (#19732) 2022-04-15 14:56:34 +02:00
smileydev c320c295dc
fix(dnd&column): make to fix the blank state issue when only one column select (#19651) 2022-04-15 13:43:25 +02:00
Smart-Codi 94075983f8
feat: Remove legacy sql alchemy db connection link from G Sheet connection (#19450)
* feat: Remove legacy sql alchemy db connection link from G Sheet connection

* resolve comment
2022-04-14 14:34:15 -06:00
Smart-Codi ac2c66ccf6
fix: Line Chart Annotation Info Update (#19001)
* fix Line Chart Annotation Info Updage

* wrap annotation text with transation

* resolve comment
2022-04-14 10:46:32 -07:00
Evan Rusackas 34008f78c9
feat: Enabling source maps full time (#19710) 2022-04-14 09:08:11 -07:00
Michael S. Molina 7bc9123fe5
fix: Filter dependencies are not being applied in default values (#19698) 2022-04-14 12:58:34 -03:00
David Aaron Suddjian 4927685c30
feat: UI override registry (#19671)
* typed registry

* remove unintentional change

* lint

* fix
2022-04-14 08:44:26 -07:00
Yongjie Zhao 9425dd2cac
fix: drop the first level of MultiIndex (#19716) 2022-04-14 23:40:38 +08:00
Jesse Yang 32a9265cc0
fix(nav): infinite redirect and upload dataset nav permissions (#19708) 2022-04-13 23:29:56 -07:00
smileydev 68ed39bcd3
fix(alert & report): make to fix the issue when recreate report (#19419) 2022-04-13 11:02:33 -06:00
Smart-Codi 94e06c2b6a
fix: Reset sorting bar issue in Barchart (#19371)
* fix: Reset sorting bar issue in Barchart

* improving performance

* fix lint error
2022-04-13 11:00:15 -06:00
Diego Medina d4e7c65f6a
fix(sql lab): replace the output column in the query history table (#19370)
* fix(sql lab): replace the output column in the query history table

* improvements
2022-04-13 10:22:03 -06:00
Kamil Gabryjelski b81982d8f3
feat(explore): More explicit labels of adhoc filter operators (#19691) 2022-04-13 18:20:38 +02:00
Diego Medina 6d5d03e592
fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode (#19362)
* fix(sql lab): display the 'View Results' button in the history tab when running sync queries

* pr comment
2022-04-13 10:20:32 -06:00
Kamil Gabryjelski c8304a2821
feat(explore): Redesign of Run/Save buttons (#19558)
* feat(explore): Move save button to header, run button to bottom of control panel

* Make the tabs sticky

* Add error icon to Data tab

* Show message when creating chart and all controls are filled correctly

* Add tests and storybook

* Fix tests

* Disable save button when control have errors

* Fix types

* Apply code review comments

* Replace styled with css

* Remove unused import
2022-04-13 16:58:39 +02:00
Diego Medina 32239b04aa
fix: improve the alerts & reports modal layout on small screens (#19294) 2022-04-13 08:45:38 -06:00
Diego Medina 26a0f05759
fix(sql lab): table selector should display all the selected tables (#19257)
* fix: table Selector should clear once selected

* Multi select

* Add tests

* refactor

* PR comments
2022-04-13 08:42:12 -06:00
Kamil Gabryjelski de9fb2109d
chore(explore): Change labels "Group by"/"Series" to "Dimensions" (#19647) 2022-04-13 15:16:03 +02:00
Ville Brofeldt 2ba484fe43
fix: login button does not render (#19685)
* fix: login button does not render

* add type guard
2022-04-13 16:04:04 +03:00
Stephen Liu 059cb4ec25
fix(plugin-chart-echarts): xAxis scale is not correct when setting quarter time grain (#19686) 2022-04-13 20:48:13 +08:00
Kamil Gabryjelski ee85466f2e
fix(dashboard): Fix BigNumber causing dashboard to crash when overflowing (#19688)
* fix(dashboard): fix(plugin-chart-echarts): Fix BigNumber causing dashboard to crash when overflowing

* Add tooltips for truncated titles

* Fix type
2022-04-13 14:22:46 +02:00
Kamil Gabryjelski 4a5dddf52d
fix(explore): Change copy of cross filters checkbox (#19646) 2022-04-13 13:19:02 +02:00
dependabot[bot] 6e8e29ce53
chore(deps): bump urijs from 1.19.8 to 1.19.11 in /superset-frontend (#19679)
Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.8 to 1.19.11.
- [Release notes](https://github.com/medialize/URI.js/releases)
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md)
- [Commits](https://github.com/medialize/URI.js/compare/v1.19.8...v1.19.11)

---
updated-dependencies:
- dependency-name: urijs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 23:23:58 -06:00
Geido 59dda1fa05
fix: Navbar styles and Welcome page text (#19586)
* Enhance navbar styles

* Clean up style
2022-04-12 18:41:00 +03:00
Geido 6a3220f905
Remove TwoTone icons (#19666) 2022-04-12 17:33:12 +03:00
Geido 7b0b029318
chore: Remove wrong usage of font-size in ExploreViewContainer (#19614)
* Remove hacky usage of font-size

* Update font
2022-04-12 16:10:58 +03:00
Ville Brofeldt 87d47987b7
fix(sql-lab): do not replace undefined schema with empty object (#19664) 2022-04-12 15:13:03 +03:00
Diego Medina 955413539b
fix: Table Autosizing Has Unnecessary Scroll Bars (#19628) 2022-04-11 15:20:41 -06:00
smileydev d8b9e72682
make to change the getBreakPoints of polygon chart (#19573) 2022-04-11 15:20:20 -06:00
AAfghahi 4bf4d58423
fix: update Permissions for right nav (#19051)
* draft pr

* finished styling

* add filter

* added testing

* added tests

* added permissions tests

* Empty-Commit

* new test

* Update superset-frontend/src/views/components/MenuRight.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* revisions

* added to CRUD view

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-04-11 16:50:59 -04:00
Geido d693f4e970
Update font-sizes (#19593) 2022-04-11 16:46:06 +03:00
Geido 5d418b21a3
Remove font-size hacky usage (#19611) 2022-04-11 16:45:52 +03:00
Geido d1e17646e2
Remove hacky usage of font-size (#19615) 2022-04-11 16:45:25 +03:00
Geido 03a80d5d2f
chore: Update font-sizes in QueryPreviewModal (#19620)
* Remove hacky font-sizes

* Remove hacky font-size SavedQueryPreviewModal
2022-04-11 16:45:09 +03:00
Stephen Liu d49fd01ff3
feat(CRUD): add new empty state (#19310)
* feat(CRUD): add new empty state

* fix ci

* add svg license
2022-04-11 12:04:45 +02:00
Ville Brofeldt f21ba68a30
chore: clean up dynamic translation strings (#19641) 2022-04-11 13:02:20 +03:00
Stephen Liu a6bf041edd
feat(plugin-chart-echarts): add aggregate total for the Pie/Donuct chart (#19622) 2022-04-11 13:56:45 +08:00
Lyndsi Kay Williams d52e3867ac
feat: Move Database Import option into DB Connection modal (#19314)
* rebase

* more progress

* Fix unintended changes

* DB import goes to step 3

* debugging

* DB list refreshing properly

* import screens flowing properly

* Code cleanup

* Fixed back button on import flow

* Remove import db tooltip test

* Fix test

* Password field resets properly

* Changed import modal state dictators and removed unneeded comment

* Removed unneeded param pass and corrected modal spelling

* Fixed typos

* Changed file to fileList

* Clarified import footer comment

* Cleaned passwordNeededField and confirmOverwriteField state checks

* debugging

* Import state flow fixed

* Removed unneeded importModal check in unreachable area

* Fixed import db footer behavior when pressing back on step 2

* Import db button now at 14px

* Removed animation from import db button

* Fixed doble-loading successToast

* Fixed errored import behavior

* Updated import password check info box text

* Connect button disables while importing db is loading

* Connect button disables while overwrite confirmation is still needed

* Connect button disables while password confirmation is still needed

* Removed gray line under upload filename

* Hide trashcan icon on import filename

* Modal scroll behavior fixed for importing filename

* Changed errored to failed

* RTL testing for db import
2022-04-08 10:03:40 -07:00
Ville Brofeldt 1ad82af058
fix(select): render when empty multiselect (#19612)
* fix(select): render when empty multiselect

* disable flaky test
2022-04-08 16:40:14 +03:00
Geido 16f193c813
Catch colors when theme top level (#19571) 2022-04-08 15:20:23 +03:00
Yongjie Zhao 761d5c4208
chore: cleanup as unknown conversion (#19587) 2022-04-08 17:32:29 +08:00
Daniel Vaz Gaspar d6d2777ada
feat: deprecate old API and create new API for dashes created by me (#19434)
* feat: deprecate old API and create new API for dashes created by me

* add tests

* fix previous test

* fix test and lint

* fix sqlite test

* fix lint

* fix lint

* lint

* fix tests

* fix tests

* use dashboards get list instead

* clean unnecessary marshmallow schema

* Update superset/views/core.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* lint

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-04-08 09:05:22 +01:00
Phillip Kelley-Dotson 44e3103fc9
feat: add success toast to alerts and reports (#19482)
* feat: add success toast to alerts and reports

* remove console

* add suggestions
2022-04-07 18:45:35 -07:00
Michael S. Molina d511e4fbc4
refactor: Removes the CSS files from the Horizon plugin (#19562)
* refactor: Removes the CSS files from the Horizon plugin

* Removes the CSS file

* Uses font-size from the theme
2022-04-07 18:47:41 -03:00
Michael S. Molina f91f83d011
refactor: Removes the CSS files from the Paired T-Test plugin (#19563)
* refactor: Removes the CSS files from the Paired T Test plugin

* Adjusts some colors
2022-04-07 11:51:22 -03:00
Michael S. Molina 38fbca10e3
refactor: Removes the CSS files from the Parallel Coordinates plugin (#19539)
* refactor: Removes the CSS files from the Parallel Coordinates plugin

* Adds test

* Fixes indentation
2022-04-07 11:51:08 -03:00
Michael S. Molina 97850a80c8
refactor: Removes the CSS files from the Partition plugin (#19521)
* refactor: Removes the CSS files from the Partition plugin

* Fixes bullet

* Always use the color of the partitions
2022-04-07 11:50:51 -03:00
Michael S. Molina 06dee825a4
chore: Removes hard-coded colors from legacy-plugin-chart-sankey (#19493)
* chore: Removes hard-coded colors from legacy-plugin-chart-sankey

* Gets opacity from the theme
2022-04-07 11:50:31 -03:00
Geido 6d5771af34
chore: Remove FilterBox.less (#19462)
* Remove FilterBox less

* Fix test

* Add theme top level

* Use styledMount
2022-04-07 17:17:50 +03:00
Geido e8f3e8a24e
chore: Remove crud.less from Datasource (#19438)
* Remove crud less

* Remove unused classname

* Remove unused import

* Add theme top level
2022-04-07 15:18:01 +03:00
Geido e5bab00cb9
chore: Enhance ReactChord style with theme vars (#19517)
* Enhance style with theme vars

* Update superset-frontend/plugins/legacy-plugin-chart-chord/src/ReactChord.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-04-07 15:17:40 +03:00
Ville Brofeldt db2135109a
fix(dataset): avoid crash if database missing (#19582) 2022-04-07 13:43:17 +03:00
Geido 73e93911ac
chore: Remove TimeTable.less (#19463)
* Remove TimeTable less

* Remove className

* Update superset-frontend/src/visualizations/TimeTable/TimeTable.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-04-06 18:43:25 +03:00
Smart-Codi f6d550b7fc
fix: weight tooltip issue (#19397)
* fix: weight tooltip issue

* remove console
2022-04-06 09:28:24 -06:00
dependabot[bot] f29d92867c
chore(deps): bump minimist in /superset-frontend/cypress-base (#19549)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-06 17:41:11 +03:00
Diego Medina c6c9188a24
fix(sql lab): increase the size of the action icons in the history tab (#19313) 2022-04-06 08:21:07 -06:00
Stephen Liu 0e29871493
fix(explore): clean data when hidding control (#19039) 2022-04-06 20:25:32 +08:00
Yongjie Zhao 2daa071633
fix: big number with trendline can't calculate cumsum (#19542) 2022-04-06 19:23:01 +08:00
Michael S. Molina c4baa826d5
refactor: Removes the CSS files from the Country Map plugin (#19538) 2022-04-06 07:39:16 -03:00
Michael S. Molina 356a03833b
chore: Removes hard-coded opacity and spacing from BigNumber (#19536) 2022-04-06 07:38:33 -03:00
Michael S. Molina 6fa99d6b07
refactor: Removes the CSS files from the Sankey Loop plugin (#19494)
* refactor: Removes the CSS files from the Sankey Loop plugin

* Gets opacity from the theme
2022-04-06 07:37:56 -03:00
Ville Brofeldt 2d81c4c79f
fix(sqllab): null database with backend persistence (#19548) 2022-04-06 12:32:41 +03:00
Geido 2de5e6fac4
chore: Remove Legacy Force Directed viz plugin (#19492)
* Add theme vars

* Remove plugin
2022-04-06 11:51:51 +03:00
Smart-Codi 156ac7dd79
fix: Error Message is cut off in alerts & reports log page (#19444) 2022-04-05 23:19:45 -06:00
Kamil Gabryjelski bb96029c9d
fix(explore): Chart header icon paddings (#19534) 2022-04-06 06:50:16 +02:00
Diego Medina c5b0dc3ea6
fix: native filter dropdown not attached to parent node (#19399) 2022-04-05 22:11:56 -06:00
Smart-Codi e118b4d733
fix: Dashboard import holding issue (#19112)
* fix dashboard import holding issue

* resolve comment
2022-04-05 21:43:47 -06:00
Smart-Codi a88fa8910d
fix: Clean up custom css when dashboard unmounted (#19342)
* clean up custom css when dashboard unmounted

* resolve comment
2022-04-05 15:20:31 -06:00
Diego Medina 634693b270
fix: Dynamic form to connect to Snowflake DB is not displaying authentication errors (#19491)
* fix: Dynamic form to connect to Snowflake DB is not displaying authentication errors

* pr comments
2022-04-05 13:11:33 -06:00
Geido 1521ab3b6f
chore(Explore): Change text when saving a chart in a new dashboard (#19467)
* Change text when new dashboard

* Test buttons behavior
2022-04-05 22:05:05 +03:00
Geido a59718b094
Remove Control less (#19415) 2022-04-05 20:05:09 +03:00
Geido e391a83947
Remove unused less (#19413) 2022-04-05 20:04:47 +03:00
Kamil Gabryjelski 03d3eaacaf
feat(explore): Move timer, row counter and cached pills to chart container (#19458)
* feat(explore): Move timer, row counter and cached pills to chart container

* Hide pills in standalone mode

* Take pills out of chart-container
2022-04-05 18:03:23 +02:00
Roman Pridybailo cccec9a6ab
fix: Correct Ukraine map (#19528)
* Crimea

* Update ukraine.geojson

Co-authored-by: Roman Pridybailo <rp@vaix.ai>
2022-04-05 18:46:12 +03:00
Kamil Gabryjelski 602afbaa31
feat(explore): Move chart header to top of the page (#19529)
* Move chart header to top of the page

* Implement truncating and dynamic input

* fix typing

* Prevent cmd+z undoing changes when not in edit mode

* Fix tests, add missing types

* Show changed title in altered
2022-04-05 15:20:29 +02:00
Hugh A. Miles II c2fae82fa6
fix key reference (#19519) 2022-04-04 14:19:46 -04:00
Michael S. Molina 82a653f64b
refactor: Removes the CSS files from the Treemap plugin (#19486) 2022-04-04 13:46:46 -03:00
Michael S. Molina 47308024a3
refactor: Removes the CSS files from the Sunburst plugin (#19488) 2022-04-04 13:46:34 -03:00
Geido 4b922873ae
Add theme color (#19490) 2022-04-04 17:19:54 +03:00
Geido 7914296d8a
chore: Remove FilterbaleTableStyles.less (#19442)
* Remove FilterbaleTablesStyles less

* Add theme top level
2022-04-04 17:11:22 +03:00
Geido b601db7809
chore: Remove StyledQueryButton.less (#19441)
* Remove StyledQueryButton less

* Remove unused className
2022-04-04 17:10:20 +03:00
dudasaron b8891acf4a
fix(dashboard list): do not show favorite star for anonymous users #18210 (#19409)
* fix: Only show favorite star on dashboard list if user is logged in #18210

* Fix linter errors
2022-04-04 10:38:44 +03:00
smileydev 5db36ec81c
fix(sqllab): make to hide the delete button of most recent query history (#19358) 2022-04-03 19:59:38 -06:00
Kamil Gabryjelski 60dcd651f4
feat(explore): SQL popover in datasource panel (#19308)
* feat(explore): SQL popover in datasource panel

* Fix acequire not defined

* Rebase and fix tests

* Disable highlighting gutter

* Use ace-build acequire instead of brace
2022-04-03 13:26:56 +02:00
Michael S. Molina 5fed10dae2
refactor: Removes the CSS files from the Rose plugin (#19473) 2022-04-01 13:13:43 -03:00
Michael S. Molina 7594a02d42
chore: Removes hard-coded colors from legacy-plugin-chart-world-map (#19466) 2022-04-01 13:13:33 -03:00
Michael S. Molina 8cd03181ac
refactor: Removes the CSS files from the DeckGL plugin (#19465) 2022-04-01 13:13:16 -03:00
Stephen Liu 90c9daea08
feat(color): support analogous colors to prevent color conflict (#19325)
* feat(color): support analogous colors

* fix test

* fix range

* add some comment
2022-04-01 18:42:30 +03:00
Geido 08aca83f6c
chore: Remove index.less from showSavedQuery (#19440)
* Remove index less

* Revert change
2022-04-01 17:57:36 +03:00
Kamil Gabryjelski fc8cb22376
feat(dashboard): Implement empty states for empty tabs (#19408)
* feat(dashboard): Implement empty states in empty tabs

* Change button to in text link

* Add edit dashboard button to dashboard empty state

* Add tests

* Fix test
2022-04-01 15:23:00 +02:00
Ville Brofeldt 11bf0d09cb
chore(plugin-chart-echarts): upgrade echarts 5.3.2 (#19481) 2022-04-01 13:05:03 +03:00
Yongjie Zhao d954c3df86
fix: can't sync temporal flag on virtual table (#19366) 2022-04-01 16:40:50 +08:00
Ville Brofeldt d684ad073d
fix: request samples with default row limit (#19456)
* fix: request samples with default row limit

* lodashLint

* fix cypress test
2022-04-01 11:32:36 +03:00
Jinghuayao 2a75e4c3c3
test(native filter): add new test for dependent filter (#19392)
* add new test for dependent filter
2022-04-01 01:06:48 -07:00
Diego Medina eab9388f7c
feat(sql lab): enable ACE editor search in SQL editors (#19328) 2022-03-31 16:05:00 -07:00
Kamil Gabryjelski 1a1322d3d9
feat(explore): Move chart actions into dropdown (#19446)
* feat(explore): Move chart actions to a dropdown menu

* Fix tests and add some new ones

* Add background color to embed code button

* Fix cypress tests

* Move copy permalink to actions menu

* Remove unused function

* Move share by email above embed code

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test
2022-03-31 20:41:15 +02:00
Michael S. Molina ac6b2f2d93
refactor: Removes the CSS files from the Heatmap plugin (#19417)
* refactor: Removes the CSS files from the Heatmap plugin

* Adds peer dependencies
2022-03-31 13:32:20 -03:00
Michael S. Molina 13467beb53
refactor: Removes the CSS files from the Calendar Heatmap plugin (#19436) 2022-03-31 13:31:20 -03:00
Michael S. Molina 31095a523d
chore: Removes plugin-chart-pivot-table hard-coded colors (#19439) 2022-03-31 13:30:36 -03:00
Michael S. Molina 47abad8673
chore: Removes hard-coded colors from legacy-preset-chart-nvd3 (#19443) 2022-03-31 13:29:54 -03:00
smileydev 6d89ffbcb7
fix(dashboard): make to show the correct owned objects (#19372)
* fix(dashboard): make to show the correct owned objects

* fix(dashboard): make to filter is reusable

* fix(homepage): make sure the type Array<Filters>

* fix(homepage): make to display dashboard correctly by owners
2022-03-31 17:10:21 +03:00
David Aaron Suddjian 8e29ec5a66
feat: Embedded dashboard configuration (#19364)
* embedded dashboard model

* embedded dashboard endpoints

* DRY up using the with_dashboard decorator elsewhere

* wip

* check feature flags and permissions

* wip

* sdk

* urls

* dao option for id column

* got it working

* Update superset/embedded/view.py

* use the curator check

* put back old endpoint, for now

* allow access by either embedded.uuid or dashboard.id

* keep the old endpoint around, for the time being

* openapi

* lint

* lint

* lint

* test stuff

* lint, test

* typo

* Update superset-frontend/src/embedded/index.tsx

* Update superset-frontend/src/embedded/index.tsx

* fix tests

* bump sdk
2022-03-30 12:34:05 -07:00
Michael S. Molina 193744842b
chore: Disables no literal colors for the theme configuration (#19437) 2022-03-30 11:57:21 -03:00
Kamil Gabryjelski a076ae6d99
feat(explore): UI changes in dataset panel on Explore page (#19394)
* feat(explore): Implement new design for dataset panel

* Fixes

* Replace drag handle in dashboard builder

* Add missing types

* Type fix

* Fix tests

* Fix non-dnd version

* Fix test

* Replace margin with height
2022-03-29 21:11:08 +02:00
Michael S. Molina 816a2c3e1e
chore: Removes direct theme imports (#19368) 2022-03-29 10:15:07 -03:00
Beto Dealmeida d304849b46
feat: disable edits on external assets (#19344)
* feat: disable edits on external assets

* Update tests
2022-03-28 16:32:57 -07:00
Evan Rusackas b689ac2d11
chore: bump storybook to 6.4.19, migrating config, and linting storybook config (#19245)
* chore: bump storybook to 6.4.19 and reconfigure accordingly

* now linting the storybook directory, since it gets validated by CI

* linting 
2022-03-28 14:02:47 -03:00
Yongjie Zhao a39dd4493e
feat: linear imputation in Resample (#19393) 2022-03-28 22:30:45 +08:00
Geido 6b9113a17b
chore: Eslint custom plugin to warn about hex and literal colors (#19239)
* wip

* Add eslint custom plugin

* Refactor

* Clean up

* Update superset-frontend/buildtools/eslint-plugin-theme-colors/index.js

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Refactor

* Update superset-frontend/buildtools/eslint-plugin-theme-colors/index.js

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Clean up

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-03-28 16:11:34 +03:00
Stephen Liu 6f5778273e
chore: add type checking in plugin test directory (#19387) 2022-03-28 10:20:06 +08:00
smileydev 5ae7e54999
fix(database): make to allow the expose db as default in sqlalchemy form db (#19337) 2022-03-25 15:47:14 -06:00
Ville Brofeldt 6141a9aa4a
chore: add support for npm8 (#19365) 2022-03-25 11:07:30 +02:00
Kamil Gabryjelski 45c28c8046
feat(explore): Dataset panel option tooltips (#19259)
* feat(explore): Add description to column/metric tooltips in dataset panel

* Fix tests

* Address code review comments
2022-03-25 07:55:11 +01:00
smileydev 446358642f
fix(explore-sqllab): make that Timestamp column keep the Is temporal flagged when overwriting (#19010) 2022-03-24 18:20:39 -06:00
Yongjie Zhao e15573d445
fix: number format should editable when AA in time comparison (#19351) 2022-03-25 07:58:53 +08:00
smileydev cb0357005e
fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart (#19122)
* fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart

* fix(export-add): make to setup the default error message

* fix(report-add): make to allow the errorMessage undefined in LabeledErrorBoundInput component
2022-03-24 17:18:34 -06:00
Smart-Codi 8947eb9680
fix: Remove gap from SQLLab results bottom (#19138)
* Remove gap from SQLLab results bottom

* resolve comment
2022-03-24 16:53:43 -06:00
Kasia dc769a9a34
fix: Adaptive formatting spelling (#19359)
Co-authored-by: Kasia Zajac <kasiazajac@Kasias-MacBook-Pro-2.local>
2022-03-24 20:51:06 +01:00
Erik Ritter 2af2d00e85
fix: typo on doc string (#19346) 2022-03-24 09:15:56 +00:00
Michael S. Molina 65c204b288
fix: Null values on Explore filter (#19341) 2022-03-23 17:23:57 -04:00
Kamil Gabryjelski a08f83bc60
fix(dashboard): Chart stuck in loading state when when datasets request and chart request fail (#19327) 2022-03-23 15:43:32 +01:00
smileydev 468c5ca29a
fix(explore): make to convert null to N/A in view results (#19316)
* fix(explore): make to convert null to N/A in view results

* fix(explore): make to null formatter move before timeFormatter
2022-03-23 08:02:52 -06:00
Diego Medina 9e58916d93
fix: regression on Select component when handling null values (#19326) 2022-03-23 10:31:38 -03:00
Stephen Liu b0397beb8e
chore: add type checking in package tests directory (#19320) 2022-03-23 18:57:35 +08:00
Ville Brofeldt b7ecb14230
fix(dashboard): fix default filter bar visibility + add docs (#18741)
* fix(dashboard): fix default filter tab visibility + add tests

* fix types

* lint

* rename docs + add double bang to length
2022-03-23 08:55:03 +02:00
Yongjie Zhao 375c03e084
feat(advanced analysis): support MultiIndex column in post processing stage (#19116) 2022-03-23 13:46:28 +08:00
Evan Rusackas e45235e482
chore: fixing a pluralization typo (#19295) 2022-03-22 14:44:03 -06:00
Geido d10a3d8bba
fix: Logo resizing on page load (#19307)
* fix resizing logo

* Refactor
2022-03-22 19:34:49 +02:00