pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 13:57:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(sql lab): add quotes when autocompleting table names with spaces in the editor (#19311)

Browse Source
This commit is contained in:
Diego Medina 2022-04-15 14:55:04 -04:00 committed by GitHub
parent bbe0af348b
commit 8d4a52c9d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx
View File

@ -227,11 +227,15 @@ class AceEditorWrapper extends React.PureComponent<Props, State> {
this.props.queryEditor.schema,
);
}
let { caption } = data;
if (data.meta === 'table' && caption.includes(' ')) {
caption = `"${caption}"`;
}
// executing https://github.com/thlorenz/brace/blob/3a00c5d59777f9d826841178e1eb36694177f5e6/ext/language_tools.js#L1448
editor.completer.insertMatch(
`${data.caption}${
['function', 'schema'].includes(data.meta) ? '' : ' '
}`,
`${caption}${['function', 'schema'].includes(data.meta) ? '' : ' '}`,
);
},
};