chore: clean up dynamic translation strings (#19641)

superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts

@@ -316,7 +316,7 @@ export default function transformProps(
           type: 'text',
           ...getTotalValuePadding({ chartPadding, donut, width, height }),
           style: {
-            text: t(`Total: ${numberFormatter(totalValue)}`),
+            text: t('Total: %s', numberFormatter(totalValue)),
             fontSize: 16,
             fontWeight: 'bold',
           },

superset-frontend/src/dashboard/actions/dashboardLayout.js

@@ -210,7 +210,7 @@ export function handleComponentDrop(dropResult) {
       destination.id !== rootChildId
     ) {
       return dispatch(
-        addWarningToast(t(`Can not move top level tab into nested tabs`)),
+        addWarningToast(t('Can not move top level tab into nested tabs')),
       );
     } else if (
       destination &&

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/Footer/Footer.tsx

@@ -46,7 +46,7 @@ const Footer: FC<FooterProps> = ({
         onConfirm={onConfirmCancel}
         onDismiss={onDismiss}
       >
-        {t(`Are you sure you want to cancel?`)}
+        {t('Are you sure you want to cancel?')}
       </CancelConfirmationAlert>
     );
   }

superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx

@@ -557,7 +557,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
             return;
           }
 
-          addSuccessToast(t(`${data.type} updated`));
+          addSuccessToast(t('%s updated', data.type));
 
           if (onAdd) {
             onAdd();
@@ -573,7 +573,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
           return;
         }
 
-        addSuccessToast(t(`${data.type} updated`));
+        addSuccessToast(t('%s updated', data.type));
 
         if (onAdd) {
           onAdd(response);

superset-frontend/src/views/CRUD/annotation/AnnotationList.tsx

@@ -262,7 +262,7 @@ function AnnotationList({
       <SubMenu
         name={
           <StyledHeader>
-            <span>{t(`Annotation Layer ${annotationLayerName}`)}</span>
+            <span>{t('Annotation Layer %s', annotationLayerName)}</span>
             <span>
               {hasHistory ? (
                 <Link to="/annotationlayermodelview/list/">Back to all</Link>

superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

@@ -1035,7 +1035,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
           }
           validationMethods={{ onBlur: () => {} }}
           errorMessage={validationErrors?.password_needed}
-          label={t(`${database.slice(10)} PASSWORD`)}
+          label={t('%s PASSWORD', database.slice(10))}
           css={formScrollableStyles}
         />
       </>

superset-frontend/src/views/CRUD/welcome/EmptyState.tsx

@@ -122,11 +122,10 @@ export default function EmptyState({ tableName, tab }: EmptyStateProps) {
                 <i className="fa fa-plus" />
                 {tableName === 'SAVED_QUERIES'
                   ? t('SQL query')
-                  : t(`${tableName
+                  : tableName
                       .split('')
                       .slice(0, tableName.length - 1)
                       .join('')}
-                    `)}
               </Button>
             </ButtonContainer>
           )}