Commit Graph

11970 Commits

Author SHA1 Message Date
Phillip Kelley-Dotson 2f3e11db66
feat: blankstate metrics columns (#20755)
* add POC ExploreMixin

* Working POC
> columns are loading into page

* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Visual updates to explore datasource panel

* Temporarily make Query icon visible

* Remove Query icon visibility

* Removed isValidDatasourceType check

* Added Query preview Modal from DatasourceControl if the data source type is Query [41493]

Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component

* > fix integration point with frontend
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working

* Adjusts conditional logic approach to be extensible for additional types from DatasourceTypes options

* refactor

* set field for sql

* Fixes issue where Missing query parameters error was showing in datasourcePanel

* add query_language

* fix ds main_dttm

* Fixes issue where menu.tsx was blocking access to redux debugging for SqlLab and Explore

* Fixes issue where database id was not available to save query as dataset, adds default metric when chart source is query

* oops

* fix pre-commit to 50 errors now

* fix circuliar dep

* Disables showing Metrics section in DatasourcePanel when Query is the datasource

A follow on separate effort will enable having a default Count metric when Query is the datasource type

* adds condition to use query.columns if query.results is not present enable saving query as a dataset

* down to 26 now

* patch for pre-commit

* one more pre-commit

* added explore_json error

* added error messages

* add for metrics

* add text for columns

* add model open/close method

* add propogation and methods

* change link to span

* lint fix

* Fixes frontend lint and TypeScript errors unit test fixes will be next commit

* Aditional TypeScript error fix

* Fixes unit test failure

* fix some types

* added frontend piece

* fix type

* Fixes bad import caused by merge from master and removes duplicate showSaveDatasetModal check

* Fixes for DartasourceControl Test Suite

* Fix lint error

* Fixes unit test issues due to array instead of a component being passed to modal footer

* Fixes unit test failure for DatasourceControl and simplifies getDatasourceTitle based on PR comment

* fix ts

* pylint

* core_test fix

* Fixes line error post merge from master

* fixed from master

* fixed from master

* Fixes issue where Overwrite dataset does not work due to userid error

SPA refractor changed Redux structure that is used when in explore (which is now within SPA).  user object is at the root of the store now for anything under SPA.

* Resolves TypeScript errors with changes made for SPA merging in and changes needed for overwriting dataset from SaveDatasetModal

* fix: top right panel view query functionality

* remove unneeded code from core.py

* working samples endpoint for query

* add owner check

* update FE for it

* handle columns are dict vs object

* fix exceptions

* fix fe lint

* fix test

* add tab_name to payload

* Enables use of tab name from Query

* fix cypress test

* save columns on execution

* fix frontend build test

* remove parathesis around columns

* changing column types

* fixing samples that has literal_columns

* address comments

* add changes

* fix path

* fix merge

* fix types

* remove console

* add type

* fix linting

* update to enum

* fix test

* remove explore from buttons

* fix logic

* fix logic

* oops

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-07-26 14:32:30 -04:00
Jesse Yang 6e6d4e3169
test: suppress unnecessary fab and sqla logs (#20870) 2022-07-26 10:36:24 -07:00
John Bodley e1094e2198
fix: Add migration to add created_by_fk as explicit owner for charts and datasets (#20617)
* fix: Add migration to add created_by_fk as owner

* Update 2022-07-05_15-48_409c7b420ab0_add_created_by_fk_as_owner.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-07-26 10:22:19 -07:00
Geido a69f016bca
chore: Feature flag for embedding charts (#20804)
* Add EMBEDDABLE_CHARTS feature flag

* Pretty

* Update test
2022-07-26 17:55:44 +03:00
Yongjie Zhao cb9ae38361
fix: switch form_data between different datasource (#20867) 2022-07-26 22:13:17 +08:00
Geido 76f573a4ea
chore: Ignore Applitools by default when running Cypress tests (#20789)
* Exclude applitools by default

* Remove unnecessary check

* Trim
2022-07-26 16:57:45 +03:00
Srini Kadamati ce1974176f
docs: fix alt image issue (#20856) 2022-07-26 08:25:27 -04:00
Kamil Gabryjelski 46deb79f50
fix: Fix chart title truncating when Chrome is zoomed out (#20847) 2022-07-26 10:21:17 +02:00
Yongjie Zhao 55a89dfac9
feat: a simple LRUCache in frontend (#20842) 2022-07-26 15:02:10 +08:00
Kamil Gabryjelski 5c2c2e8040
feat(explore): UX changes in fast viz switcher (#20848)
* feat(explore): UX changes in fast viz switcher

* Fix test
2022-07-26 08:44:17 +02:00
Diego Medina 5d107b86ab
fix: explore warnings cleanup (#20864) 2022-07-26 13:28:50 +08:00
Geido 6b0c3032b2
chore: Update color scheme when deleted or changed (#20589)
* feat(explore): Use v1/explore endpoint data instead of bootstrapData

* Add tests

* Fix ci

* Remove redundant dependency

* Use form_data_key in cypress tests

* Add auth headers to for data request

* Address comments

* Remove displaying danger toast

* Conditionally add auth headers

* Address comments

* Fix typing bug

* fix

* Fix opening dataset

* Fix sqllab chart create

* Run queries in parallel

* Fallback to default color scheme

* Fix dashboard id autofill

* Fix lint

* Fix test

* Fix hydrate action

* Update dashboard colors

* Add color scheme domain

* Add check for default scheme

* Make me pretty

* Clean up

* Nit

* Clean up

* Pretty

* Fix missing sequential

* Lint

* Enhance test

* Lint

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-07-25 18:50:49 -04:00
Hugh A. Miles II 3de641c3ae
change buttons to be only save and overwrite (#20851) 2022-07-25 18:18:17 -04:00
Christian Dreier 3f943ffadb
fix: adding extraConfig to worker deployment #20828 (#20829)
* #20828 adding extraConfig to worker deployment

* fixed missing condition in volume declaration

* bumped chart version
2022-07-25 15:07:23 -07:00
Beto Dealmeida 672266ca58
fix: add complex type to pydruid (#20834)
* fix: add complex type to pydruid

* Kick jobs
2022-07-25 14:49:44 -07:00
Srini Kadamati c4564a91dc
chore: add databricks logo (#20849)
* chore: add databricks logo

* added databricks logo to Readme
2022-07-25 16:05:50 -04:00
Kamil Gabryjelski e3c6380258
chore: Change Button background color from primary.dark1 to primary.base (#20846) 2022-07-25 18:02:14 +02:00
John Bodley 8bfc9b76a6
fix: Use cache_manager.cache rather than cache_manager.data_cache for caching table metadata (#20726) 2022-07-25 08:54:59 -07:00
John Bodley 7a1aa79c52
fix: Ensure consistent rollback logic (#20811) 2022-07-25 08:18:53 -07:00
Kamil Gabryjelski 0945d4a2f4
feat: Pass dashboard context to explore through local storage (#20743)
* feat: Pass dashboard context to explore through local storage

* Remove console log

* Remove unused local storage keys

* Fix lint

* Fix link

* Fix UT

* fix lint

* fix prettier

* Fix bug

* Fix bug with some sample dashboards

* Roll back unnecessary change

* style fix

* Add comments

* Fix lint

* Address code review comments

* Fix
2022-07-25 16:44:43 +02:00
Yongjie Zhao 644148b37d
chore: add SAMPLES_ROW_LIMIT in frontend conf (#20841) 2022-07-25 15:21:16 +08:00
Stephen Liu 9bf7ed58cd
fix(plugin-chart-echarts): bar chart overflow (#20805) 2022-07-23 14:20:00 +08:00
Stephen Liu 557cf4b739
fix(dashboard): add toast if JSON metadata is invalid (#20823) 2022-07-23 14:14:28 +08:00
Yongjie Zhao 3fb5c79d77
fix: invalid dataset schema (#20826) 2022-07-23 08:34:15 +08:00
rizacavus 4ffa3c22d1
feat: Add Türkiye Map to Country Map (#20801) 2022-07-23 08:33:56 +08:00
Hugh A. Miles II 2263a76f4d
remove eleement reference (#20830) 2022-07-22 13:56:33 -04:00
Hugh A. Miles II 2c010974e8
fix: Timeseries visualization with Chart Source = Query (#20795)
* fix timmeseries

* update other references

* fix

* fix linting
2022-07-22 13:30:24 -04:00
AAfghahi 7495cdbfe0
feat: Create Chart onClick Functionality (#20809)
* explore results button

* addresing hugh comments

* changed datatype to query

* addresing eric comments
2022-07-22 12:53:01 -04:00
Diego Medina 6e0ddcf848
fix: [explore][mixed time series chart] when user change size of view query window, query B part will disappear (#20750) 2022-07-22 20:39:13 +08:00
Yongjie Zhao f011abae2b
feat: the samples endpoint supports filters and pagination (#20683) 2022-07-22 20:14:42 +08:00
nisheldo 39545352d2
chore: update Pillow to 9.1.1 (#20775) 2022-07-22 17:44:07 +08:00
Diego Medina 51869f32ac
Temporal X Axis values are not properly displayed if the time column has a custom label defined (#20819) 2022-07-22 17:05:37 +08:00
Evan Rusackas fe9eb58ede
chore: bumps the handlebars plugin package version to match the family. (#20813) 2022-07-22 15:18:45 +08:00
Diego Medina 279ab954b1
fix: chart empty state & result panel when multiple queries are executed display incorrectly (#20816) 2022-07-22 14:58:42 +08:00
Michael S. Molina 34278c2d56
fix: Redirects old Explore URLs to the new one (#20812) 2022-07-21 22:26:29 -06:00
Kamil Gabryjelski af1bddffad
fix(explore): Adhoc columns don't display correctly (#20802)
* fix(explore): Adhoc columns have empty labels

* Add unit test

* Address comments
2022-07-21 21:11:49 +02:00
Yongjie Zhao 922b4b8d1d
fix: unexpected commit causes pytest failure (#20780) 2022-07-21 09:16:44 +08:00
Michael S. Molina 3311128c5e
fix: Reverts #20749 and #20645 (#20796)
* Revert "fix: Error when saving datasource from Explore (#20749)"

This reverts commit 92f3621c75.

* Revert "refactor: Unify shared datasources reducers and actions (#20645)"

This reverts commit 2a705406e1.
2022-07-20 17:03:19 -03:00
Hugh A. Miles II 84b852c457
fix: properly set `owners` to Sqlatable.owners_data inside payload (#20794)
* properly set owners_data for sqlatabl

* fix test
2022-07-20 14:56:08 -04:00
John Bodley 5a04a28518
refactor: Blossom metric fields for dataset API column selection (#20732) 2022-07-20 10:01:32 -07:00
Just[in]Do it! 1debacaaca
feat(dashboard): Make FilterBar width resizable (#20778)
* Add Resizable panel in DashboardBuilder to adjust the width for FiltersPanel
* store the adjusted width for individual dashboard in localStorage to memorize the state
* migrate DashboardBuilder test code by testing-library and jest
2022-07-20 09:56:55 -07:00
Beto Dealmeida 2c5201fa4b
fix: Databricks views showing up as tables (#20674) 2022-07-20 09:31:42 -07:00
Stephen Liu d90b973235
fix(plugin-chart-echarts): layout broken when resizing (#20783)
* fix(plugin-chart-echarts): layout broken when resizing

* use useLayoutEffect
2022-07-20 09:40:39 -06:00
Stephen Liu d925b0c883
fix(heatmap): add detail descriptions for heatmap 'normalize across' (#20566)
* fix(heatmap): change 'Normalize Across' to 'Color Based On' and add some label

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* fix lint

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-07-20 09:39:22 -06:00
Beto Dealmeida 2a4c7cfb2a
chore: add user agent to Databricks requests (#20660) 2022-07-20 08:17:52 -07:00
Hugh A. Miles II 81bd4968d0
fix: set allow `filter_select` for Query objects in Explore (#20754)
* set allow filter select

* add small comment

* add better logic

* remove condition and reference it in backend
2022-07-20 09:08:02 -04:00
Yongjie Zhao 9c7bcfcead
fix: core coverage and add a coverage step in workflow (#20784)
* fix: core coverage

* add step in workflow
2022-07-20 08:56:03 -03:00
Cody Leff 5ed85f59a1
Fix missing metadata. (#20684) 2022-07-20 07:31:21 -03:00
Yongjie Zhao bb5b8e4c4f
chore: add coverage command in package.json (#20769) 2022-07-20 18:30:30 +08:00
Jesse Yang a64cdec8c2
fix(db): set slices.query_context to MEDIUMTEXT for mysql (#20779) 2022-07-19 18:12:44 -07:00