Commit Graph

4952 Commits

Author SHA1 Message Date
Phillip Kelley-Dotson 2f3e11db66
feat: blankstate metrics columns (#20755)
* add POC ExploreMixin

* Working POC
> columns are loading into page

* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Visual updates to explore datasource panel

* Temporarily make Query icon visible

* Remove Query icon visibility

* Removed isValidDatasourceType check

* Added Query preview Modal from DatasourceControl if the data source type is Query [41493]

Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component

* > fix integration point with frontend
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working

* Adjusts conditional logic approach to be extensible for additional types from DatasourceTypes options

* refactor

* set field for sql

* Fixes issue where Missing query parameters error was showing in datasourcePanel

* add query_language

* fix ds main_dttm

* Fixes issue where menu.tsx was blocking access to redux debugging for SqlLab and Explore

* Fixes issue where database id was not available to save query as dataset, adds default metric when chart source is query

* oops

* fix pre-commit to 50 errors now

* fix circuliar dep

* Disables showing Metrics section in DatasourcePanel when Query is the datasource

A follow on separate effort will enable having a default Count metric when Query is the datasource type

* adds condition to use query.columns if query.results is not present enable saving query as a dataset

* down to 26 now

* patch for pre-commit

* one more pre-commit

* added explore_json error

* added error messages

* add for metrics

* add text for columns

* add model open/close method

* add propogation and methods

* change link to span

* lint fix

* Fixes frontend lint and TypeScript errors unit test fixes will be next commit

* Aditional TypeScript error fix

* Fixes unit test failure

* fix some types

* added frontend piece

* fix type

* Fixes bad import caused by merge from master and removes duplicate showSaveDatasetModal check

* Fixes for DartasourceControl Test Suite

* Fix lint error

* Fixes unit test issues due to array instead of a component being passed to modal footer

* Fixes unit test failure for DatasourceControl and simplifies getDatasourceTitle based on PR comment

* fix ts

* pylint

* core_test fix

* Fixes line error post merge from master

* fixed from master

* fixed from master

* Fixes issue where Overwrite dataset does not work due to userid error

SPA refractor changed Redux structure that is used when in explore (which is now within SPA).  user object is at the root of the store now for anything under SPA.

* Resolves TypeScript errors with changes made for SPA merging in and changes needed for overwriting dataset from SaveDatasetModal

* fix: top right panel view query functionality

* remove unneeded code from core.py

* working samples endpoint for query

* add owner check

* update FE for it

* handle columns are dict vs object

* fix exceptions

* fix fe lint

* fix test

* add tab_name to payload

* Enables use of tab name from Query

* fix cypress test

* save columns on execution

* fix frontend build test

* remove parathesis around columns

* changing column types

* fixing samples that has literal_columns

* address comments

* add changes

* fix path

* fix merge

* fix types

* remove console

* add type

* fix linting

* update to enum

* fix test

* remove explore from buttons

* fix logic

* fix logic

* oops

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-07-26 14:32:30 -04:00
Geido a69f016bca
chore: Feature flag for embedding charts (#20804)
* Add EMBEDDABLE_CHARTS feature flag

* Pretty

* Update test
2022-07-26 17:55:44 +03:00
Yongjie Zhao cb9ae38361
fix: switch form_data between different datasource (#20867) 2022-07-26 22:13:17 +08:00
Geido 76f573a4ea
chore: Ignore Applitools by default when running Cypress tests (#20789)
* Exclude applitools by default

* Remove unnecessary check

* Trim
2022-07-26 16:57:45 +03:00
Kamil Gabryjelski 46deb79f50
fix: Fix chart title truncating when Chrome is zoomed out (#20847) 2022-07-26 10:21:17 +02:00
Yongjie Zhao 55a89dfac9
feat: a simple LRUCache in frontend (#20842) 2022-07-26 15:02:10 +08:00
Kamil Gabryjelski 5c2c2e8040
feat(explore): UX changes in fast viz switcher (#20848)
* feat(explore): UX changes in fast viz switcher

* Fix test
2022-07-26 08:44:17 +02:00
Diego Medina 5d107b86ab
fix: explore warnings cleanup (#20864) 2022-07-26 13:28:50 +08:00
Geido 6b0c3032b2
chore: Update color scheme when deleted or changed (#20589)
* feat(explore): Use v1/explore endpoint data instead of bootstrapData

* Add tests

* Fix ci

* Remove redundant dependency

* Use form_data_key in cypress tests

* Add auth headers to for data request

* Address comments

* Remove displaying danger toast

* Conditionally add auth headers

* Address comments

* Fix typing bug

* fix

* Fix opening dataset

* Fix sqllab chart create

* Run queries in parallel

* Fallback to default color scheme

* Fix dashboard id autofill

* Fix lint

* Fix test

* Fix hydrate action

* Update dashboard colors

* Add color scheme domain

* Add check for default scheme

* Make me pretty

* Clean up

* Nit

* Clean up

* Pretty

* Fix missing sequential

* Lint

* Enhance test

* Lint

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-07-25 18:50:49 -04:00
Hugh A. Miles II 3de641c3ae
change buttons to be only save and overwrite (#20851) 2022-07-25 18:18:17 -04:00
Srini Kadamati c4564a91dc
chore: add databricks logo (#20849)
* chore: add databricks logo

* added databricks logo to Readme
2022-07-25 16:05:50 -04:00
Kamil Gabryjelski e3c6380258
chore: Change Button background color from primary.dark1 to primary.base (#20846) 2022-07-25 18:02:14 +02:00
Kamil Gabryjelski 0945d4a2f4
feat: Pass dashboard context to explore through local storage (#20743)
* feat: Pass dashboard context to explore through local storage

* Remove console log

* Remove unused local storage keys

* Fix lint

* Fix link

* Fix UT

* fix lint

* fix prettier

* Fix bug

* Fix bug with some sample dashboards

* Roll back unnecessary change

* style fix

* Add comments

* Fix lint

* Address code review comments

* Fix
2022-07-25 16:44:43 +02:00
Stephen Liu 9bf7ed58cd
fix(plugin-chart-echarts): bar chart overflow (#20805) 2022-07-23 14:20:00 +08:00
Stephen Liu 557cf4b739
fix(dashboard): add toast if JSON metadata is invalid (#20823) 2022-07-23 14:14:28 +08:00
rizacavus 4ffa3c22d1
feat: Add Türkiye Map to Country Map (#20801) 2022-07-23 08:33:56 +08:00
AAfghahi 7495cdbfe0
feat: Create Chart onClick Functionality (#20809)
* explore results button

* addresing hugh comments

* changed datatype to query

* addresing eric comments
2022-07-22 12:53:01 -04:00
Diego Medina 6e0ddcf848
fix: [explore][mixed time series chart] when user change size of view query window, query B part will disappear (#20750) 2022-07-22 20:39:13 +08:00
Yongjie Zhao f011abae2b
feat: the samples endpoint supports filters and pagination (#20683) 2022-07-22 20:14:42 +08:00
Diego Medina 51869f32ac
Temporal X Axis values are not properly displayed if the time column has a custom label defined (#20819) 2022-07-22 17:05:37 +08:00
Evan Rusackas fe9eb58ede
chore: bumps the handlebars plugin package version to match the family. (#20813) 2022-07-22 15:18:45 +08:00
Diego Medina 279ab954b1
fix: chart empty state & result panel when multiple queries are executed display incorrectly (#20816) 2022-07-22 14:58:42 +08:00
Kamil Gabryjelski af1bddffad
fix(explore): Adhoc columns don't display correctly (#20802)
* fix(explore): Adhoc columns have empty labels

* Add unit test

* Address comments
2022-07-21 21:11:49 +02:00
Michael S. Molina 3311128c5e
fix: Reverts #20749 and #20645 (#20796)
* Revert "fix: Error when saving datasource from Explore (#20749)"

This reverts commit 92f3621c75.

* Revert "refactor: Unify shared datasources reducers and actions (#20645)"

This reverts commit 2a705406e1.
2022-07-20 17:03:19 -03:00
Just[in]Do it! 1debacaaca
feat(dashboard): Make FilterBar width resizable (#20778)
* Add Resizable panel in DashboardBuilder to adjust the width for FiltersPanel
* store the adjusted width for individual dashboard in localStorage to memorize the state
* migrate DashboardBuilder test code by testing-library and jest
2022-07-20 09:56:55 -07:00
Stephen Liu d90b973235
fix(plugin-chart-echarts): layout broken when resizing (#20783)
* fix(plugin-chart-echarts): layout broken when resizing

* use useLayoutEffect
2022-07-20 09:40:39 -06:00
Stephen Liu d925b0c883
fix(heatmap): add detail descriptions for heatmap 'normalize across' (#20566)
* fix(heatmap): change 'Normalize Across' to 'Color Based On' and add some label

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* fix lint

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-07-20 09:39:22 -06:00
Yongjie Zhao 9c7bcfcead
fix: core coverage and add a coverage step in workflow (#20784)
* fix: core coverage

* add step in workflow
2022-07-20 08:56:03 -03:00
Cody Leff 5ed85f59a1
Fix missing metadata. (#20684) 2022-07-20 07:31:21 -03:00
Yongjie Zhao bb5b8e4c4f
chore: add coverage command in package.json (#20769) 2022-07-20 18:30:30 +08:00
Cody Leff 84d4302628
fix(explore): Fix chart standalone URL for report/thumbnail generation (#20673)
* Update explore URLs.

* More URL fixes.

* Make frontend accept true/false query params case-insensitively.

* Fix URL mistake.

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-07-19 13:53:55 -03:00
Diego Medina 115ab700df
fix(sql lab): MultiSelector component render twice (#20706)
* fix(sql lab): MultiSelector component render twice

* filter null/undefined tables
2022-07-19 08:33:15 -03:00
Hugh A. Miles II 1101922178
fix change dataset (#20751) 2022-07-18 14:23:11 -04:00
Michael S. Molina 92f3621c75
fix: Error when saving datasource from Explore (#20749) 2022-07-18 14:35:19 -03:00
Hugh A. Miles II 510c1c4817
fix: set reference to columns properly for sqllab -> explore (#20747)
* set reference to columns properly

* fix logic
2022-07-18 12:32:31 -04:00
Hugh A. Miles II e5e8867394
feat: Visualize SqlLab.Query model data in Explore 📈 (#20281) 2022-07-15 19:34:02 -04:00
John Bodley a6abcd9ea8
fix: Address regression in main_dttm_col for non-dnd (#20712)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-07-14 23:51:03 -07:00
Yongjie Zhao 6b0bb80a6d
fix: columns are lost when dashboard to explore (#20699) 2022-07-14 15:43:33 +08:00
Diego Medina 558201c865
fix: "Refresh Dashboard" only refreshes active tab (#20688) 2022-07-14 11:52:36 +08:00
Antonio Rivero Martinez 5510af36cc
Save Dataset Modal: (#20691)
- Stop clearing the selected dataset after overwritting so users can overwrite as many times as they see fit
- There's a new AsyncSelect we should use now
2022-07-13 12:12:28 -06:00
Michael S. Molina 2a705406e1
refactor: Unify shared datasources reducers and actions (#20645)
* refactor: Unify shared datasources reducers and actions

* Removes column_types

* Adjusts hydrateExplore

* Revert "Removes column_types"

This reverts commit 096bbf7826.

* Fixes test
2022-07-13 13:03:36 -03:00
Michael S. Molina ec2eb3ddf8
refactor: Renders addSlice in SPA (#20675)
* refactor: Renders addSlice in SPA

* Removes unused imports

* Fixes test imports

* Removes unnecessary imports
2022-07-13 08:50:58 -03:00
Stephen Liu acdb271422
fix(line-chart): Formula Annotations on Line Charts are broken (#20687) 2022-07-13 16:42:11 +08:00
Stephen Liu bd6037ef50
fix(treemap-v2): color scheme not work when there is only one dimension (#20671) 2022-07-13 16:06:44 +08:00
Diego Medina effa7d9f58
fix(dashboard): Native filter on the dashboard with multiple tabs is displayed as out of scope (#20693) 2022-07-13 16:03:23 +08:00
Usiel Riedl 19247cc92a
Fixes datatable crash when dimension is empty (#20680)
Fixes #20679

Co-authored-by: Usiel Riedl <usiel.riedl@automattic.com>
2022-07-13 14:54:33 +08:00
Cody Leff b1020e3062
chore(explore): Update chart save to use API endpoints (#20498)
* Update SaveModal to use v1 API instead of POST /explore.

* Refactor SaveModal tests and remove obsolete ones.

* Fix redirect to /explore on save.

* Add toasts (but they don't work).

* Move logic inside try block, clarify unary-plus use.

* Add tests.

* Fix owners bug in updateSlice, enable navigation to dashboard w/o reload.

* Fix toasts.

* Fix translated strings.

* Fix unintended removal from dashboard bug.

* Fix native filters bug.

* Don't refresh Explore page after saving

* Use JSON payload shorthand.

* Prevent current dashboards being overwritten on viz type change.
2022-07-13 06:36:31 +02:00
Kamil Gabryjelski 5317462b49
Revert "feat: Reuse Dashboard redux data in Explore (#20668)" (#20689)
This reverts commit ff5b4bc0e4.
2022-07-12 16:48:08 -03:00
Kamil Gabryjelski ff5b4bc0e4
feat: Reuse Dashboard redux data in Explore (#20668) 2022-07-12 19:17:25 +02:00
Phillip Kelley-Dotson c795dc23b9
feat: have user go to explore after dataset creation (#19965)
* feat: have user go to explore after dataset creation

* change flow to create chart

* fix lint

* update with suggestions and add store for toasts

* fix ts

* fix test

* lint
2022-07-12 09:11:31 -07:00