pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: set reference to columns properly for sqllab -> explore (#20747) 

* set reference to columns properly

* fix logic
This commit is contained in:
Hugh A. Miles II 2022-07-18 12:32:31 -04:00 committed by GitHub
parent 5990ea639e
commit 510c1c4817
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/src/SqlLab/components/ResultSet/index.tsx
View File

@ -225,12 +225,12 @@ export default class ResultSet extends React.PureComponent<
const { query } = this.props;
const datasource: ISaveableDatasource = {
columns: query.columns as ISimpleColumn[],
columns: query.results.columns as ISimpleColumn[],
name: query?.tab || 'Untitled',
dbId: 1,
sql: query.sql,
templateParams: query.templateParams,
schema: query.schema,
dbId: query?.dbId,
sql: query?.sql,
templateParams: query?.templateParams,
schema: query?.schema,
};
return (

5
superset-frontend/src/explore/components/ExploreChartPanel.jsx
View File

@ -27,6 +27,7 @@ import {
t,
useTheme,
getChartMetadataRegistry,
DatasourceType,
} from '@superset-ui/core';
import { useResizeDetector } from 'react-resize-detector';
import { chartPropShape } from 'src/dashboard/util/propShapes';
@ -153,8 +154,8 @@ const ExploreChartPanel = ({
const metaDataRegistry = getChartMetadataRegistry();
const { useLegacyApi } = metaDataRegistry.get(vizType);
const vizTypeNeedsDataset = useLegacyApi && datasource.type !== 'dataset';
const vizTypeNeedsDataset =
useLegacyApi && datasource.type !== DatasourceType.Table;
// added boolean column to below show boolean so that the errors aren't overlapping
const showAlertBanner =
!chartAlert &&