mirror of https://github.com/apache/superset.git
fix: set reference to columns properly for sqllab -> explore (#20747)
* set reference to columns properly * fix logic
This commit is contained in:
parent
5990ea639e
commit
510c1c4817
|
@ -225,12 +225,12 @@ export default class ResultSet extends React.PureComponent<
|
|||
const { query } = this.props;
|
||||
|
||||
const datasource: ISaveableDatasource = {
|
||||
columns: query.columns as ISimpleColumn[],
|
||||
columns: query.results.columns as ISimpleColumn[],
|
||||
name: query?.tab || 'Untitled',
|
||||
dbId: 1,
|
||||
sql: query.sql,
|
||||
templateParams: query.templateParams,
|
||||
schema: query.schema,
|
||||
dbId: query?.dbId,
|
||||
sql: query?.sql,
|
||||
templateParams: query?.templateParams,
|
||||
schema: query?.schema,
|
||||
};
|
||||
|
||||
return (
|
||||
|
|
|
@ -27,6 +27,7 @@ import {
|
|||
t,
|
||||
useTheme,
|
||||
getChartMetadataRegistry,
|
||||
DatasourceType,
|
||||
} from '@superset-ui/core';
|
||||
import { useResizeDetector } from 'react-resize-detector';
|
||||
import { chartPropShape } from 'src/dashboard/util/propShapes';
|
||||
|
@ -153,8 +154,8 @@ const ExploreChartPanel = ({
|
|||
|
||||
const metaDataRegistry = getChartMetadataRegistry();
|
||||
const { useLegacyApi } = metaDataRegistry.get(vizType);
|
||||
const vizTypeNeedsDataset = useLegacyApi && datasource.type !== 'dataset';
|
||||
|
||||
const vizTypeNeedsDataset =
|
||||
useLegacyApi && datasource.type !== DatasourceType.Table;
|
||||
// added boolean column to below show boolean so that the errors aren't overlapping
|
||||
const showAlertBanner =
|
||||
!chartAlert &&
|
||||
|
|
Loading…
Reference in New Issue