Commit Graph

487 Commits

Author SHA1 Message Date
Kamil Gabryjelski
f109da479d
perf(dashboard): Improve perf of highlighting charts in scope of active filter (#15424)
* perf(dashboard): Improve perf of highlighting charts in scope of active filter

* More optimizations

* fix tests

* Fix lint

* bug fix
2021-06-29 12:55:53 +02:00
krsnik93
b8f4e7d093
fix: add dashboard markdown id (#15418)
Co-authored-by: root <root@src4.ikrsnik.devonly.net>
2021-06-29 11:42:28 +03:00
Michael S. Molina
e713912fdf
chore: Uses mixed case for native filters headers (#15433) 2021-06-28 17:09:31 -03:00
Michael S. Molina
ac18c90da2
fix: Cascading filter popover widens automatically (#15390) 2021-06-28 20:03:14 +03:00
Marek Šuppa
93447d1903
Update Header.jsx (#13467)
* Fix typo in the warning that gets displayed with the `positionJSON` is too large/long.
2021-06-28 17:02:41 +03:00
Kamil Gabryjelski
09c44d05fd
feat(native-filters): Hide non-numeric columns in numeric range filter (#15385)
* feat(native-filters): Hide non-numeric columns in numeric range filter

* Return true if type_generic undefined

* Code review comments

* Replace any with string

* fix tests

* add missing columns to select

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-06-27 07:35:17 +03:00
Michael S. Molina
bdb9b0a9be
chore: Rewrites dashboard IconButton component (#14174) 2021-06-25 15:15:20 -03:00
Michael S. Molina
819118be13
fix: Enlarged select filter value (#15373)
* fix: Enlarged select filter value

* fix: Makes the label take the whole width

* fix: Moves the required icon before the cascade icon

* fix: Fixes the cascading icon overlap with big texts
2021-06-25 13:33:12 -03:00
Ville Brofeldt
b3cdff4995
fix(native-filters): show default text on filter scoping tree (#15351) 2021-06-24 11:01:24 +03:00
Kamil Gabryjelski
f0b64190b5
feat(native-filters): Set default scope by filters' and charts' datasets (#15302)
* feat(native-filters): Set default scope by filter's and charts datasets

* Fix undefined error

* Use JSON.stringify in dependency array

* Fix lint issue

* Lock scope after switching radio buttons

* Fix weird eslint issue

* Change prop names

* Implement useComponentDidUpdate

* Fix lint

* Refactor useComponentDidUpdate

* Remove screen.debug()
2021-06-24 09:23:35 +02:00
Kamil Gabryjelski
b89ee0cb38
fix(native-filters): Assume that temporal columns exist if column_types is undefined (#15324)
* fix(native-filters): Assume that temporal columns exist if column_types is undefined

* Allow column_types to be an empty array
2021-06-23 12:09:58 +02:00
Kamil Gabryjelski
6324490dd3
fix(dashboard): Close FiltersBadge popover on window resize (#15305) 2021-06-23 10:14:41 +02:00
Ben Reinhart
ab153e66cc
feat: Synchronously return cached charts (#15157)
* feat: Synchronously return cached charts

* Fix lint issue

* Fix python lint error

* Change getChartDataRequest to return response

* Fix lint errors

* Add test

* explore_json: skip cached data check for forced refresh

Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
2021-06-22 10:00:57 -07:00
Ville Brofeldt
cef3dc0b02
fix(native-filters): improve time range filter performance (#15295)
* fix time range default value

* defer time filter rendering to inView event

* avoid double fetching of time ranges

* lint

* move set to resolved promise
2021-06-22 14:38:16 +03:00
simcha90
048609d120
feat(native-filters): Show/Highlight errored/focused status (#15276)
* fix:fix get permission function

* feat: show error status for required filters

* test: fix tests

* refactor: fix CR notes
2021-06-22 14:25:08 +03:00
Ville Brofeldt
b28d7eace3
fix(native-filters): default value checkbox in config modal (#15257)
* fix(native-filters): default value checkbox in config modal

* disable checkbox if required

* simplify styling logic

* make default value mandatory if checked

* address comments
2021-06-21 15:58:30 +03:00
Kamil Gabryjelski
c7c63751e9
feat(native-filters): Hide time filters if loaded datasets don't have temporal columns (#15225)
* feat(native-filters): Hide time filters if loaded datasets don't have temporal columns

* Remove "px" suffixes to fix warnings

* Disable an option instead of hiding filter types

* Fix tests

* Add 2 more tests
2021-06-17 16:51:11 +02:00
Michael S. Molina
ea8507b4e2
fix: Filter bar not occupying 100% height when filter sets FF unset (#15228) 2021-06-17 16:38:14 +03:00
simcha90
388eb01f06
feat(native-filters): Disable Apply button if filter required (#15222)
* fix:fix get permission function

* fix: fix select first value by clear all

* lint: fix lint

* feat: disable select on missed value

* fix: refactor ff

* feat: connect nulls for line chart

* lint: fix lint

* docs: fix message

* fix: fix CR comments

* fix: fix Collapsed items

* fix: fix Collapsed items
2021-06-17 16:35:33 +03:00
simcha90
fe5381dcb8
fix(native-filters): Fix Select Default First Value by clicked Clear All (#15219)
* fix:fix get permission function

* fix: fix select first value by clear all

* lint: fix lint
2021-06-17 11:14:21 +03:00
Yaozong Liu
e5187a479a
fix(dashboard): fix nested tab (#15134) 2021-06-16 23:31:52 -06:00
Yaozong Liu
e689b0d445
fix(dashboard): duplicated toast (#15138) 2021-06-16 21:44:37 +03:00
Michael S. Molina
dafaaaeb28
chore: Changes the dashboard highlight color when selecting a filter (#15192) 2021-06-16 15:45:31 +02:00
Michael S. Molina
fc8ad4f984
chore: Makes the refresh button only appear when the filter has a dataset (#15194) 2021-06-16 16:07:23 +03:00
Michael S. Molina
4289929745
chore: Allows the user to force fetch the default values (#15178) 2021-06-16 14:17:34 +03:00
Michael S. Molina
0c22266041
chore: Improves the native filters bar layout (#15115) 2021-06-16 14:17:14 +03:00
Elizabeth Thompson
7dc0cee5be
add another wait for chart element (#15108) 2021-06-15 10:00:36 -07:00
Ville Brofeldt
9c3c3fa125
feat(native-filters): add optional time col to time range (#15117) 2021-06-15 13:25:28 +03:00
Ajay M
045fa1bc7a
feat(dashboard): Let users download full CSV of a table (#15046)
* - Convert SliceHeader to TSX in progress
- Add menu option to download full CSV. Probably will change it

* Add Download Full CSV feature, and tests

* Added more tests, more TS fixes

* Added feature flag

* Update @superset-ui package versions

* Update @superset-ui packages versions

* use backend config instead of hardcoding number of rows

* Update tests

* front end test fix

* Lint fixes and test fixes
2021-06-14 14:26:18 -07:00
Michael S. Molina
82ad053e50
fix: Filter overlay in dashboard when scrolling (#15140) 2021-06-14 15:34:36 +02:00
Kamil Gabryjelski
3866044938
fix(native-filters): Don't send unnecessary PUT request on dashboard render (#15146)
* fix(native-filters): Don't send unnecessary PUT request on dashboard render

* Run native filters scopes only if feature flag is enabled

* Change action name

* Run native filters scopes only if at least 1 filter added

* Fix lint
2021-06-14 14:33:59 +02:00
gordern
57035c1b93
fix: improve dashboard fullscreen text (#15139) 2021-06-14 17:54:37 +08:00
Kamil Gabryjelski
ff2d5888d9
feat(native-filters): Defer loading filters data until filter is visible (#15120)
* feat(native-filters): Defer running query until native filter is in view

* Fix default values not displaying
2021-06-11 11:10:16 -07:00
Kamil Gabryjelski
51f0d4fd98
feat(native-filters): Hide filters which don't affect any visible charts (#15063)
* feat(native-filters): Hide filters which don't affect any visible charts

* Fix lint errors

* Add comments

* Code review fix

* Fix tests

* Refactor logic in FilterControls
2021-06-11 13:41:08 +02:00
Kamil Gabryjelski
3456dd571c
fix(native-filters): fix Select filter crashing when changing filter type (#15090) 2021-06-10 18:11:31 -06:00
Ville Brofeldt
6c9f15a6e4
fix(native-filters): show error if default value query failed (#15005)
* fix(native-filters): show error if query failed

* address comments
2021-06-10 16:56:31 +03:00
Michael S. Molina
1468026883
chore: Improves the native filters UI/UX - iteration 7 (#15017) 2021-06-10 15:24:00 +03:00
Ville Brofeldt
8aaa6036d7
fix(native-filters): remove hard-coded default time range (#15015)
* fix(native-filters): use default for time range from explore

* fix tests
2021-06-10 14:49:37 +03:00
Michael S. Molina
1af91ed756
fix: Adds left padding to dashboard edit mode when filter bar is closed (#15024) 2021-06-08 15:58:15 +03:00
Ville Brofeldt
efd7007701
fix(native-filters): show overridden chart name on scoping tree (#15038) 2021-06-08 14:55:11 +03:00
Geido
a1ca0b2e6b
Add ming-height to empty tab (#14878) 2021-06-07 22:55:16 -06:00
David Aaron Suddjian
cf15fe0d03
fix(dashboard): custom css should be removed on unmount (#15025)
* fix(dashboard): custom css should be removed on unmount

* better comment

* remove unnecessary typecast

* move type to top level scope
2021-06-07 14:04:56 -07:00
simcha90
1fc08523af
feat(native-filters): Support default to first value in select filter (#14869)
* fix:fix get permission function

* feat: add async filters support

* revert: revert ff

* feat: add async filters support

* fix: merge with master

* fix: remove tests

* lint: fix lint

* fix: fix CR notes

* fix: fix with master

* test: fix tests

* refactor: update logic for default first value

* fix: get requiredFirst

* fix: support instant

* docs: update text

* docs: fix comments

* docs: update texts
2021-06-07 13:41:19 +03:00
Yongjie Zhao
c8cf4b6bbf
fix: toggle fullscreen on the dashboard (#14979) 2021-06-04 22:24:57 +08:00
Kamil Gabryjelski
8c01c13d90
fix(native-filters): Fix "undefined" error after editing a filter (#14984)
* fix(native-filters): Fix "undefined" error after editing a filter

* Remove console log
2021-06-04 15:15:37 +02:00
Ville Brofeldt
765e9dd932
feat(native-filters): apply cascading without instant filtering (#14966) 2021-06-03 17:48:46 +03:00
Ville Brofeldt
f94c6d2763
fix(native-filters): cascading filters not rendering in tab (#14964) 2021-06-03 12:04:23 +03:00
Kamil Gabryjelski
405f95b6af
feat(dashboard/native-filters): Hide filters out of scope of current tab (#14933)
* Optimize finding charts and tabs in scope

* Put filters out of scope in Collapse

* Use lastFocusedTabId instead of directPathToChild

* Fix tests

* Fix cypress test

* Uncomment e2e test
2021-06-02 20:38:18 +02:00
Michael S. Molina
b6f00e69e1
chore: Improves the native filters UI/UX - iteration 6 (#14932) 2021-06-02 09:03:13 +03:00
simcha90
e43112c5f9
feat(native-filter): Hide native filters (#14784)
* fix:fix get permission function

* feat: support showFilters

* fix: fix CR notes

* fix: fix lint issues
2021-05-31 09:05:57 +03:00
Kamil Gabryjelski
f82a085175
feat(dashboard): Highlight tabs that contain a chart in scope of focused native filter (#14865)
* feat(dashboard): Highlight tabs that contain a chart in scope of focused native filter

* Optimizations and improvements

* Use Set instead of array

* Simplify logic

* Change variable name
2021-05-28 11:32:32 +02:00
Michael S. Molina
8519a09086
chore: Improves the native filters UI/UX - iteration 5 (#14882) 2021-05-28 10:29:16 +03:00
Ville Brofeldt
b72e5e0aae
feat(native-filters): improve inverse selection indicators (#14873) 2021-05-28 07:45:37 +03:00
Michael S. Molina
a6d54b681b
chore: Improves the native filters UI/UX - iteration 4 (#14854) 2021-05-27 13:37:36 +03:00
Geido
ad4ce83327
fix(native-filter): Default value multi-select height in native filters (#14816)
* Fix height

* Fix height sidebar

* Move style
2021-05-27 13:05:58 +03:00
Ville Brofeldt
bd2c087f78
fix(native-filters): remove indicators outside scope (#14838)
* fix(native-filters): remove indicators outside scope

* lint
2021-05-27 07:53:52 +03:00
Ville Brofeldt
e466066229
chore(native-filters): introduce experimental feature flag (#14814)
* chore(native-filters): introduce experimental feature flag

* break out util and add tests

* fix import
2021-05-26 17:20:33 +03:00
Michael S. Molina
0c0eccb81a
chore: Improves the native filters UI/UX - iteration 3 (#14824) 2021-05-26 10:49:00 +03:00
Ville Brofeldt
9a96dac3a7
fix(native-filters): loop bug by simplify state handling (#14788) 2021-05-25 15:03:22 +03:00
simcha90
9bf07cc428
fix(native-filters): Manage default value of filters by superset (#14785)
* fix:fix get permission function

* feat: manage default value in superset
2021-05-25 11:25:13 +03:00
Ville Brofeldt
e9657afe4b
feat(native-filters): add search all filter options (#14710)
* feat(native-filters): add search all filter options

* add tests

* fix default value

* implement ILIKE operator

* rebump packages

* fix test

* address comments

* fix state changes coming from application

* fix debouncer
2021-05-24 16:33:59 +03:00
Yongjie Zhao
8484ee653f
fix: extra query in Dashboard when native filter enabled (#14770) 2021-05-24 20:53:14 +08:00
Michael S. Molina
bee6f3ba8a
chore: Improves the native filters UI/UX - iteration 2 (#14753) 2021-05-24 15:22:05 +03:00
Yongjie Zhao
d71b8b38d6
Revert "fix(dashboard): multiple query trigger when native filter enabled (#14734)" (#14762)
This reverts commit 88de4109e7.
2021-05-22 15:11:58 +08:00
Yongjie Zhao
88de4109e7
fix(dashboard): multiple query trigger when native filter enabled (#14734)
* fix(dashboard): multiple query trigger when native filter enabled

* fix lint

* wip
2021-05-21 09:24:42 -07:00
Kamil Gabryjelski
c831655913
feat(native-filters): Highlight charts affected by focused native filter (#14693)
* Highlight charts affected by focused native filter

* Remove tabs animation on dashboard

* Remove a test that checks for "animated={true}" prop on tabs

* Move hooks types to a separate interface
2021-05-21 15:54:33 +02:00
Michael S. Molina
173c486d4a
fix: Unable to clear default value in native select filter (#14739) 2021-05-20 19:42:33 -07:00
Michael S. Molina
d924223950
chore: Improves the native filters UI/UX - iteration 1 (#14714) 2021-05-20 19:52:01 +03:00
Michael S. Molina
be8c176df2
chore: Removes less from SliceAdder (#14448) 2021-05-19 00:16:44 -07:00
Ajay M
84e8dc71f6
feat(dashboard): View query of the chart in dashboard (#14667)
* Extract view query component out

* Typo correction

* Fix and rename tests

* Remove logs, and test code

* Rename file - fix tests

* Fix a typo

* Linting errors, add Apache License Header
2021-05-18 13:17:11 -07:00
Michael S. Molina
32f5f365d8
fix: Fixes email body when sharing a chart by email (#14664) 2021-05-18 00:43:36 -07:00
David Aaron Suddjian
884ded0507
fix: roles undefined on public dashboards (#14648) 2021-05-14 14:28:47 -07:00
David Aaron Suddjian
f16c708fab
fix(dashboard): check edit permissions correctly on frontend (#14626)
* fix(dashboard): check edit permissions correctly on frontend

* fix types, appease linter

* handle nulls better
2021-05-14 12:18:38 -07:00
Michael S. Molina
9cb4a4602f
fix: Fixes top level tabs and automatic scroll (#14624) 2021-05-14 11:50:20 -07:00
Phillip Kelley-Dotson
e4e23ea487
fix: fix adhocpopovers tab animate. (#14478)
* fix popover

* addd tabs default css

* fix lint

* fix tests

* address comments

* lint fix

* fix test

* lint
2021-05-13 20:30:27 -07:00
Michael S. Molina
e4d24242b4
refactor: Bootstrap to AntD - NavDropdown (#14557) 2021-05-13 14:54:09 -07:00
Phillip Kelley-Dotson
bfbf767663
fix: dashboard side actions (#14587)
* fix dashboard side actions

* lint being lint
2021-05-12 11:47:29 -07:00
Grace Guo
ada380982b
fix: bring back dashboard perf logger (#14584)
* fix: bring back dashboard perf logger

* add test
2021-05-12 08:25:46 -07:00
Geido
b960843015
fix: Menu does not appear on scroll in Dashboard (#14566)
* Fix menu

* Fix test
2021-05-11 11:38:58 -07:00
Phillip Kelley-Dotson
e16c4d856e
refactor(navbar): migrate Bootstrap navbar to AntD menus (#14184)
* initial commit

* more polish

* fix types and remove tests

* fix tests, update menu css, add oetc

* fix lint and precommit

* fix test

* update css, address comments

* fix lint

* update submenu for extra buttons

* remove block and lint

* fix lint

* remove block

* adjust margin

* test round 2

* test round 3

* about section

* src/components/Menu/Menu.test.tsx

* remove redundant test

* fmore pointed test

* fix lint

* remove unused css

* fix dashboard nav view

* update comments

* use suggestion

* lint-fix

* move css, fix dropdown and text

* lint

* rearchitect main nav component

* run lint fix

* nit
2021-05-08 14:57:59 -07:00
Michael S. Molina
79ff96269b
refactor: Bootstrap to AntD - Form - iteration 3 (#14502) 2021-05-08 12:34:52 -07:00
Ville Brofeldt
66a4c94a1e
fix(chart-data): handle url_params in csv export and native filters (#14526) 2021-05-07 21:07:44 +03:00
simcha90
e8e838e279
feat(native-filters): Auto apply changes in FiltersConfigModal (#14461)
* fix:fix get permission function

* feat: auto apply changes after save filters config modal

* fix: repopulate default values

* test: fix tests

* test: fix tests

* fix: fix CR notes

* fix: fix CR notes
2021-05-07 13:06:59 +03:00
Michael S. Molina
331310db9b
refactor: Bootstrap to AntD - Form - iteration 2 (#14379) 2021-05-05 22:00:37 -07:00
Ajay M
c832542570
fix(dashboard): Prevent char overflow when displaying chart description (#14467)
* Force refresh the chart on toggle display description

* Use forceUpdate instead of forceRefresh

* Instead of forceUpdate, add a state for desciption height

Co-authored-by: Ajay Mancheery <ajaymancheery@Ajays-MacBook-Pro.local>
2021-05-05 13:30:10 -07:00
Kamil Gabryjelski
b030c9801c
chore: Move styles from .less stylesheet to emotion in Explore (#14485)
* Move some styles from .less stylesheet to emotion in Explore

* Replace Global styles with local styled components

* Address comments
2021-05-05 15:36:52 +02:00
Jesse Yang
23014e9233
chore: upgrade @emotion (#14454) 2021-05-04 15:26:16 -07:00
David Aaron Suddjian
21cf12a480
chore(dashboard): Integrate dashboard app into the SPA bundle (#14356)
* chore(dashboard): Integrate dashboard app into the SPA bundle

* fix url params

* change variable name

* change title correctly

* custom css

* lint

* remove unused file

* remove content assertions from dashboard tests

* fix case with missing bootstrap data

* fix: respect crud views flag

* crud views -> spa

* remove unused dashboard templates

* fix: remove unused variable

* fix: missed a spot with the crudViews -> spa

* router link to dashboard from dashboard list page

* link using the router when in card mode

* lint

* fix tests, add memory router

* remove  dashboard app files

* split up the bundle a little more

* use webpack preload
2021-05-04 08:51:17 -07:00
simcha90
582900c170
perf(native-filters): Load native filters after charts (#14443)
* fix:fix get permission function

* refactor: filter default value

* refactor: update default value loading

* refactor: apply defaultValues

* lint: fix lint

* lint: fix lint

* test: fix test

* refactor: use extraFormData for reload charts

* feat: load native filters after after charts

* feat: load filters after charts

* fix: revert changes

* test: fix timers

* test: fix tests
2021-05-04 16:07:40 +03:00
simcha90
bbb1f2d757
perf(native-filters): avoid unnecessary reloading of charts (#14408)
* fix:fix get permission function

* refactor: filter default value

* refactor: update default value loading

* refactor: apply defaultValues

* lint: fix lint

* lint: fix lint

* test: fix test

* refactor: use extraFormData for reload charts

* test: fix tests

* test: fix tests

* test: fix tests
2021-05-03 14:56:41 +03:00
simcha90
abbf4bf05a
refactor(native-filters): allow cascading only for filter_select (#14441)
* fix:fix get permission function

* refactor: allow cascading only for filter_select
2021-05-02 13:16:10 +03:00
simcha90
1f8de1d06c
test(maximize-chart): Add tests to maximize chart action (#14371)
* fixed FullSize charts broken #13600

* Update ChartHolder.jsx

* fix:fix get permission function

* test: adding tests to full screen

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

Co-authored-by: toop <mytoop@163.com>
2021-05-02 09:27:38 +03:00
Ville Brofeldt
319125ec3b
fix(native-filters): fix filter scope error (#14426) 2021-04-30 12:20:02 +03:00
Geido
545e257537
feat: Dynamic imports for the Icons component (#14318)
* Add aria-label and twotone

* Enhance LazyIcon

* Fix tests and solve ject warnings

* Add new line

* Revert package-lock to master

* Fix failing test

* Implement icon overrides

* Fix failing storybook

* Clean up

* Improve var name
2021-04-29 11:49:39 -07:00
Ville Brofeldt
1c16261651
fix(native-filters): always show filters without dataset (#14409) 2021-04-29 14:25:39 +03:00
Michael S. Molina
1d6a746a09
refactor: Boostrap to AntD - Tabs (#14048) 2021-04-28 23:49:50 -07:00
Ville Brofeldt
4410fd047e
fix(native-filters): default value not populated on second opening (#14401) 2021-04-29 09:09:47 +03:00
Ville Brofeldt
43ee52be57
fix(native-filters): force update control value on change (#14385)
* fix(native-filters): force update control value on change

* fix test
2021-04-28 11:41:22 +03:00
simcha90
fc0c1155c2
fix(native-filters): fix lint (#14387)
* fix:fix get permission function

* lint: fix types
2021-04-28 10:16:21 +03:00
simcha90
2486fd4f6d
feat(native-filters): Show/Hide filter bar by metdata ff (#14261)
* fix:fix get permission function

* feat: hide native filters by metadata

* fix: fix show_native_filters name

* fix: metadata

* chore: add migration to hide native_filters in all existing dashboards

* chore: fix pre-commit

* fix: make migration migration dashboard with filter_box only

* fix: pre-commit

* feat: hide filter bar if no permission edit and no filters

* fix: remove migration

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-04-28 07:49:03 +03:00
Ville Brofeldt
40fb94dcca
feat(native-filters): add optional sort metric to select filter (#14346)
* feat(native-filters): add optional sort metric to select filter

* use verbose name when defined

* fixes

* lint

* disable flaky test

* disable flaky test

* disable flaky test
2021-04-27 20:28:38 +03:00
Ville Brofeldt
87a895cc4a
feat(native-filters): add refresh button to default value picker (#14375)
* feat(native-filters): add refresh button to default value picker

* skip flaky test
2021-04-27 19:18:34 +03:00
Kamil Gabryjelski
41ccebce91
feat(native-filters): Use datasets in dashboard as default options for native filters (#14374)
* Use defaultOptions in dataset picker

* Remove console log

* Temporarily skip failing test
2021-04-27 18:04:57 +03:00
Kamil Gabryjelski
20ab0869fa
feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters (#14313)
* Implement adhoc filters in Range and Select native filters

* Add time picker

* Remove additional filters from datamask

* Create separate stylesheet for AdhocFilterControl in native filters

* Rename Time picker to Time range

* Fix columns in AdhocFilter empty when creating a new filter

* Skip flaky test
2021-04-27 11:08:05 +02:00
simcha90
03e4a5b6b7
fix(native-filters): Update filter saving (#14370)
* fix:fix get permission function

* fix: not reload charts after save filters

* fix: not reload charts after save filters

* fix: temp commit type

* lint: add typing
2021-04-27 11:20:04 +03:00
Michael S. Molina
d0be1ff79e
chore: Moves Tabs to the components folder (#14136) 2021-04-27 00:15:21 -07:00
Michael S. Molina
4fbb572568
refactor: Bootstrap to AntD - Form - iteration 1 (#14106) 2021-04-26 15:03:53 -07:00
simcha90
7ff35dfdfb
fix(native-filters): Fix indicators (#14334)
* fix:fix get permission function

* fix: hide featured filters

* test: fix FF in tests

* test: fix FF in tests

* fix: fix unset cross filters
2021-04-26 13:22:11 +03:00
simcha90
3e8bf96642
fix(native-filters): Fix first loading of charts (#14332)
* fix:fix get permission function

* fix: fix unnecessary loading for native filters

* test: fix mocks
2021-04-25 13:58:53 +03:00
Ville Brofeldt
2b57ebaffd
feat(native-filters): add tooltip to control values (#14312) 2021-04-23 19:29:51 +03:00
Michael S. Molina
b963624e12
refactor: Boostrap to AntD - Row/Col (#14100) 2021-04-22 20:57:17 -07:00
Amit Miran
13d4902711
feat(native-filters): select group by support (#14217)
* chore: initial commit

* feat: groupby filter

Co-authored-by: Simcha Shats <simcha.shats@nielsen.com>
2021-04-20 18:52:33 +03:00
Michael S. Molina
d1b458c4c5
chore: Moves Radio to the components folder (#14133) 2021-04-20 08:48:10 -07:00
Michael S. Molina
8441590812
chore: Moves Tooltip to the components folder (#14137) 2021-04-20 08:47:47 -07:00
simcha90
7e5440a359
test(native-filters): Filter config modal test (#14245)
* test: add tests for filter bar

* test: merge filter bar tests with master

* test: add test for filter set

* test: filter set tests

* test: merge with master

* test: fix tests for filter bar

* test: filter config modal

* test: add select filter

* feat: filter config modal

* lint: fix lint

* lint: fix TS

* test: test testWithId
2021-04-20 14:07:08 +03:00
simcha90
d386e66f59
test(native-filters): add integration tests for filter bar (#14098)
* test: add tests for filter bar

* test: merge filter bar tests with master

* test: add test for filter set

* test: filter set tests

* test: merge with master

* test: fix tests for filter bar

* fix: fix CR notes

* fix: fix CR notes
2021-04-20 12:24:12 +03:00
simcha90
c01f8101eb
fix(cross-filters): Fix missed metadata (#14220)
* fix:fix get permission function

* fix: fix missed metadata case
2021-04-18 18:46:38 +03:00
Michael S. Molina
77a9cc7088
chore: Moves Collapse to the components folder (#14124) 2021-04-16 15:55:04 -07:00
Michael S. Molina
b83ee46d0f
chore: Moves Modal to the components folder (#14130) 2021-04-16 15:49:53 -07:00
simcha90
8ef572a412
refactor(native-filters): update dataMask and ExtraFormData schema (#13983)
* refactor: updates usage of `ownFilters` to `ownState`

* refactor: update dataMask (final)

* lint: fix lint

* refactor: revert feat

* fix: fix missed chart configuration

* add filter set migration

* apply new changes

* fix migration revision

* update migration

* fix jest mock

* js lint

* fix test types

* update tests and types

* remove append_form_data from tests

* fix findExistingFilterSet tests

* add migration test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-04-15 17:43:29 +03:00
Ville Brofeldt
68e11cd47f
fix(dashboard): filter set hydration not working (#14129) 2021-04-15 06:09:12 +03:00
Jesse Yang
6755083e3a
fix(dashboard): incorrect perm for users with multiple roles (#14148) 2021-04-14 16:04:09 -07:00
Geido
474f1e2044
test: Add tests for Dashboard Header and HeaderActionsDropdown components (#13973)
* Add tests for HeaderActionsDropdown - WIP

* Fix trigger node

* Add types

* Clean up

* Add tests for Header

* Delete obsolete tests

* Add factory and clean up

* Add opposite case

* Fix file name

* Include latest changes
2021-04-14 06:54:24 -07:00
simcha90
f453287a07
fix:fix get permission function (#14099) 2021-04-13 09:36:13 -07:00
Amit Miran
8c5b6b1263
feat(dashboard_rbac): provide data access based on dashboard access (#13992)
* feat: provide data access based onb dashboard access

* chore: adjust code after CR comments

* fix: add brackets

* fix: type

* chore: add tests

* fix: pre-commit

* fix: pre-commit and lint

* fix: fix test

* fix: pre-commit

* fix: fix local pylint warnings

* revert: birth_names pylint  change bc it  affects tests

* Update superset/security/manager.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset/security/manager.py

* Update tests/utils_tests.py

* fix: after CR

* fix: after CR from ville

* chore: update roles description

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-04-13 16:23:31 +03:00
Amit Miran
9c5264af0d
feat(can_share): can share chart and dashboard (#14076)
* feat: share chart  - can_share_chart
share dashboard can_share_dashboard

* fix: pre-commit

* fix: userCanShare tests

* fix: after hugh CR

* fix: adjust after spa refactor
2021-04-13 13:54:14 +03:00
Michael S. Molina
b394733ff3
test: Adds tests to the UndoRedoKeyListeners component (#13919) 2021-04-12 23:51:57 -07:00
Geido
11869dc076
test: Tests audit for the Dashboard FilterBar (#13916)
* Add FilterBar tests

* Finalize FilterBar tests

* Add tests for FilterBar Header

* Add tests for FilterBar FilterConfigurationLink

* Add tests for FilterBar FilterSets EditSection

* Add tests for FilterBar FilterSets

* Clean up

* Add tests for FilterBar FilterSetUnit

* Add tests for FilterBar FilterSets FiltersHeader

* Add tests for FilterBar FilterSets Footer

* Fix linting

* Fix import

* Fix minor changes

* Fix import

* Add factory and clean up
2021-04-12 23:28:19 -07:00
Phillip Kelley-Dotson
4bb29b6f04
chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306)
* add hook for future async api calls

* test to see conflict

* add async middleware and update reducers

* working async dashboard load

* implement getcharts api

* add user permissions to explore and dashboard bootstrap data

* integrate api calls with getinitial state

* update namings

* accept an id or a slug in the dashboard charts api

* add permissions function

* fix merge

* update state

* get dashboard charts by id or slug

* fix undefined states

* variable names

* stop using some more bootstrap data

* fix metadata reference

* remove unused bootstrap from the template

* add errorboundry to dashboard

* refactoring, fixing

* update permissions

* add just roles

* id is supposed to be a string

* unused vars

* get datasources from api

* make onError optional

* use resource hooks, better error boundary

* add loading state for dashboardroute

* remove console

* add conditional

* more conditionals

* testing out a possible fix for cypress

* convert edit/standalone test to cypress

* remove bootstrappy assertions

* lint

* fix dashboard edit history issue

* rename stuff

* address recent native filters schema change

* remove unused getInitialState

* remove .only from test

* hooksy redux usage

* Revert "more conditionals"

This reverts commit 25c8ed61b4.

* cleanup

* undo unnecessary change

* actually need conditions here

* certainty

* Revert "certainty"

This reverts commit 77dea1915b.

* more permutations (untested yolo)

* Update superset-frontend/src/chart/chartReducer.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* import style

* comment

* cleaner dashboardInfo

* remove debug code

* use memo for getPermissions

* fix lint

* adjust name/location of DashboardPage

* move logic for REMOVE_SLICE_LEVEL_LABEL_COLORS to DAO

* stop using full_data()

* remove unused (and now useless) json=true query param

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2021-04-12 16:10:29 -07:00
Kamil Gabryjelski
bf22487e23
Make chart exclude itself from cross filtering (#14046) 2021-04-12 14:08:07 +03:00
simcha90
d6bd160250
fix: fix bug when remove chart not removing it's related cross filter data (#14081) 2021-04-12 10:54:31 +03:00
simcha90
468638c5b8
feat(native-filters): Add default first value to select filter (#13726)
* feat: native filters first default value

* fix: fix CR notes

* feat: add support for `Place` type

* refactor: sync with master

* feat: add first value to Select filters

* refactor: fix CR notes

* refactor: updates usage of `ownFilters` to `ownState`

* Revert "refactor: updates usage of `ownFilters` to `ownState`"

This reverts commit 58b91998

* fix: revert mocks

* fix: fix CR notes

* chore: update package json

* chore: update package json

* chore: update package json

* test: fix tests

* fix: fix BE empty metrics

* lint: fix lint

* fix: fix BE empty metrics

* refactor: fix Cr notes
2021-04-12 09:22:33 +03:00
Bruno Motta
66201e7c55
test: FilterSets-utils (#14028)
* Tests for "nativeFilters/FilterBar/FilterSets/utils"

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/generateFiltersSetId.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Fix: Lint error

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:07:37 -07:00
Bruno Motta
ff08d423a9
Tests for ControlItems (#13975) 2021-04-09 09:54:35 -07:00
Bruno Motta
1920811cf2
test: Tabs (#13941)
* Test for Tabs component

* Fix: "creteProps" to "createProps"

* Update superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:54:16 -07:00
Bruno Motta
011af825a9
test: Tab (#13937)
* Tests for Tab component

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:53:54 -07:00
Bruno Motta
ec3f8d07f4
test: SliceHeader (#13888)
* tests for SliceHeader

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:14:16 -07:00
Bruno Motta
36f101e500
test: ShareMenuItems (#13860)
* Tests for ShareMenuItems

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:13:05 -07:00
Bruno Motta
c0017b3262
Tests for ColumnSelect (#13991) 2021-04-09 09:02:39 -07:00
Michael S. Molina
b5c95c537c
test: Adds tests to the CssEditor component (#13933) 2021-04-07 14:40:24 -07:00
Michael S. Molina
4602ead10c
test: Adds tests to the filter scope components (#13887) 2021-04-06 21:31:35 -07:00
Bruno Motta
ab0f5e3087
test: PropertiesModal (Dashboard) (#13931)
* Tests for PropertiesModal (Dashboard)

* fix: fetchMock
2021-04-06 14:00:35 -07:00
Geido
c0888dc16d
Add tests for FilterBar CascadeFilterControl (#13950) 2021-04-06 11:15:17 -07:00
Bruno Motta
d489d0018c
test: SliceHeaderControls (#13895)
* tests for SliceHeaderControls

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* fix lint error

* Improving accessibility

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-05 13:34:06 -07:00
Bruno Motta
203512e189
test: CrossFilterScopingForm (#13875)
* tests for CrossFilterScopingForm

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-05 11:16:04 -07:00
Bruno Motta
12982ef387
tests for FilterIndicator (#13873) 2021-04-05 11:14:30 -07:00
Bruno Motta
f2d65989ab
Tests for DetailsPanel (#13872) 2021-04-05 11:13:15 -07:00
simcha90
e06290663a
fix(colors): fix color schemes (#13945)
* fix: fix color schemes

* fix: tests case
2021-04-04 15:53:21 +03:00
Bruno Motta
e829aa52eb
Tests for "CrossFilterScopingModal/utils" (#13876) 2021-04-02 17:06:42 -07:00
David Aaron Suddjian
e640b7f0e0
chore(dashboard): Datasource -> Dataset (#13939)
* chore(dashboard): Datasource -> Dataset

* lint

* more renaming datasource -> dataset
2021-04-02 16:47:16 -07:00