Commit Graph

487 Commits

Author SHA1 Message Date
Ajay M
9e6d5fc775
feat(dashboard): Let users re-arrange native filters (#16154)
* feat. flag: ON

* refactor filter tabs

* WIP

* Drag and Rearrange, styling

* refactoring dnd code

* Add apache license header

* Fix bug reported during PR review

* Minor fix on remove

* turn off filters

* Fix status

* Fix a test

* Address PR comments

* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* indent

* PR comments

* PR comments

* Fix failing tests

* Styling

* Fix remove filter

* Fix the drag issue

* Save works

* fix

* Write tests

* Style changes

* New Icon

* Grab & Grabbing Cursor

* Commented out code

* Fix tests, fix CI

* Fix failing tests

* Fix test

* Style fixes

* portal nodes dependency

* More style fixes

* PR comments

* add unique ids to collapse panels

* Filter removal bug fixed

* PR comments

* Fix test warnings

* delete filter tabs

* Fix the breaking test

* Fix warnings

* Fix the weird bug on cancel

* refactor

* Fix broken scope
2021-10-15 16:56:33 -07:00
Yongchan Hong
7a2e39449a
feat(config): Add none force-refresh option for auto refresh (#17039)
* feat(config): Add none force-refresh option for auto refresh

* use general config

* fix lint issues

* last lint fix
2021-10-14 21:31:10 +03:00
Kamil Gabryjelski
3ad7483dc1
fix(dashboard): race condition between hydrating dashboard and set active tabs (#17084)
* fix(dashboard): race condition between hydrating dashboard and set active tabs

* Fix linting

* Change variable name
2021-10-13 20:18:44 +02:00
Phillip Kelley-Dotson
bdbcfbc8fc
fix: show onhover menu only in edit mode (#17034)
* fix on markdown hover menu

* lint-fix
2021-10-08 10:54:16 -07:00
Geido
a6173f1929
chore(Dashboard): Highlight errored filters on the left pane of the Native Filters form plus several enhancements (#16940)
* Implement errored filters

* Clean up

* Handle errors on the fly

* Implement handleErroredFilters

* Reset errors
2021-10-08 17:33:04 +03:00
Michael S. Molina
c471a85170
fix: Unnecessary queries when changing filter values (#16994) 2021-10-07 13:07:33 -03:00
Kamil Gabryjelski
45908ff104
fix(dashboard): Race condition when setting activeTabs with nested tabs (#17007)
* fix(dashboard): Race condition when setting activeTabs with nested tabs

* Remove activeTabs prop from Tabs
2021-10-07 14:23:26 +02:00
jinghua-qa
6dc00b3e3f
fix: letter format of sort chart in dashboard edit (#17003) 2021-10-07 16:29:16 +08:00
Phillip Kelley-Dotson
50ad84bd03
chore: refactor header menu to show in header grid component (#16689)
* initial commit

* add delete to markdown
2021-10-04 15:01:17 -07:00
Michael S. Molina
1ab36c94f3
chore: Moves spec files to the src folder - iteration 7 (#16943) 2021-10-04 10:56:49 -03:00
Ville Brofeldt
a07c9d591b
fix(dashboard): recursive parent on dashboard components (#16933)
* fix(dashboard): don't add recursive parents on wrapper component

* add test

* refine logic and add new test
2021-10-01 08:13:38 -07:00
Michael S. Molina
87290ddcc8
fix: Native filters cyclic dependency (#16921) 2021-09-30 14:55:54 -03:00
Michael S. Molina
3d520f2cc9
fix: Inclusive sign in time range display (#16906)
* fix: Time range display to show inclusive range

* Skips flakky test
2021-09-30 09:57:07 -03:00
Michael S. Molina
05632b9804
chore: Moves the stylesheets folder to the assets folder (#16880)
* chore: Moves the stylesheets folder to the assets folder

* Changes {src} to src
2021-09-30 09:28:38 -03:00
Michael S. Molina
4da4fe4136
fix: Removing parent filter causes incorrect state of child filter (#16876)
* fix: Removing parent filter causes incorrect state of child filter

* removed to isRemoved

* Shows (deleted) when the parent is removed

* Removes unnecessary code
2021-09-29 13:04:07 -03:00
simcha90
3d8cc15cba
fix: Clear native filters state (#16893)
* fix:fix get permission function

* fix: clear native filters state
2021-09-29 13:50:21 +03:00
Michael S. Molina
e3b14fe170
fix: Overhead when changing the filter name (#16877) 2021-09-29 07:37:02 -03:00
Geido
d3f6145aba
fix(dashboard): Fill form with the latest values when undo in native filters (#16851)
* Set undoFormValues

* Reorganize

* Revert check

* Fix and clean up

* Fix pre-filter and sort values
2021-09-27 09:39:26 -07:00
Ville Brofeldt
42fa54881a
fix(native-filters): filter indicator stale state (#16831) 2021-09-27 08:34:39 +03:00
Ville Brofeldt
a3413197de
chore: upgrade to Node 16 (#16809)
* chore: upgrade to Node 16

* add docs

* fix test
2021-09-25 07:26:35 +02:00
Michael S. Molina
1ff682f3a9
fix: Updates the selected values when changing the native filter type, column or default value (#16833) 2021-09-24 14:07:20 -03:00
Michael S. Molina
9b17e86b44
chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00
Geido
fecd4124fa
fix: Select refactoring known issues (#16666)
* Clean up and reorganize effects

* Enhance optionFilterProps

* Render custom label

* Remove prop filtering

* Create options

* Create option from value in single mode

* Change to customLabel

* Show search by default

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Apply minor changes

* Fixes a bug that was failing CI

* Adds more tests to the component

* Apply customLabel in ColorSchemeControl

* Remove customLabel from rendered Option

* Hide No data when allowNewOptions

* Remove unnecessary prop from tests

* Adjust loading height

* Show no data with fetchOnlyOnSearch

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-14 17:39:27 +03:00
Grace Guo
b0b996582c
fix: reset perf logger timer for soft navigation for SPA pages (#16668)
* fix: reset perf logger timer for soft navigation for SPA pages

* fix comments

* fix extra comments

Co-authored-by: grace_guo <grace_guo@grace-guos-MacBook-Pro.local>
2021-09-13 10:16:07 -07:00
simcha90
668ae23f28
feat: Tabs in column (#16593)
* fix:fix get permission function

* feat: add tabs inside column

* lint: fix lint

* test: fix test

* test: fix tests

* test: fix tests

* fix: pass onChangeTab function through layout
2021-09-13 09:02:29 +03:00
Ajay M
4b70d46355
feat(dashboard): Native filters - add type to native filter configuration (#16549)
* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* PR comments

* PR comments

* Fix failing tests
2021-09-09 09:46:44 -07:00
Kamil Gabryjelski
788c0c3dae
fix(dashboard): label colors included in explore url (#16621) 2021-09-08 15:38:02 +02:00
Kamil Gabryjelski
effcf3b50f
perf(dashboard): decrease number of rerenders of FiltersBadge (#16545)
* perf(dashboard): decrease rerenders in FiltersBadge

* implement caching of dashboard filter indicators

* Implement caching for native filter indicators
2021-09-07 12:03:43 +02:00
Kamil Gabryjelski
7faa5c6aff
perf(dashboard): reduce rerenders of DragDroppable (#16525)
* perf(dashboard): reduce rerenders of DragDroppable

* lint fix
2021-09-07 11:19:07 +02:00
Duy Nguyen Hoang
3fe2e6ec73
Remove export CSV in old filter box (#16592) 2021-09-06 14:40:24 +03:00
Geido
f001c44727
Make Modal draggable and resizable (#16447) 2021-08-31 12:46:44 +03:00
Ville Brofeldt
147637a02d
fix(native-filters): add handle undefined control value gracefully (#16468) 2021-08-27 14:03:05 +03:00
Kamil Gabryjelski
f422f1ea49
perf(dashboard): decouple redux props from dashboard components (#16421)
* perf(dashboard): decouple redux props from dashboard components

* Lint fix

* Dont make copy of filters object

* Remove unnecessary exports
2021-08-26 21:54:11 +02:00
Kamil Gabryjelski
8ad495a572
perf(dashboard): reduce number of rerenders of Charts (#16444)
* perf(dashboard): reduce number of rerenders of Charts

* Remove static property

* Cleanup
2021-08-26 21:53:44 +02:00
Jesse Yang
ec087507e5
refactor(explore): improve typing for Dnd controls (#16362) 2021-08-26 01:23:14 -07:00
Maxhui
6a2cec51c5
fix(dashboard): undo and redo buttons weird alignment (#16417)
* fix(dashboard-ui): undo and redo buttons weird alignment

* fix(Explore control pane): keyboard nav & focus

* lint: lint frontend

* fix: fix redo and undo button style

* lint: lint line

* lint: lint line

Co-authored-by: xuzhebin <maxhui2020@gmail.com>
2021-08-25 08:52:59 -03:00
Michael S. Molina
575e7af859
fix: Show cross filter option only when cross filter is enabled (#16391) 2021-08-24 09:13:39 -03:00
Geido
9a37ad1a1e
fix: Return original document title when leaving a dashboard (#16323)
* Return original title on unmount

* Name var originalDocumentTitle
2021-08-24 15:08:13 +03:00
Geido
c14364c616
chore: Enhance Omnibar (#16273)
* Fix style and implement ESC

* Include ESC test case

* Move pagination outside of table

* Update superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Enhance

* Handle close

* Localize placeholder

* Fix tests

* Clear input on close

* Destroy modal on close

* Clean up

* Fix tests

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-24 11:52:07 +03:00
Lyndsi Kay Williams
518c3c9ae0
test: Functional RTL for email report modal II (#16148)
* Email Report Modal validation testing

* Starting RTL testing for email report

* Calendar icon now rendering!

* Create report testing in dashboard

* make linter happy

* Fixing weird error

* Removed ExploreChartHeader_spec

* Fixed dashboard header test

* revert changes from merge

* Fix tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-20 10:08:36 -07:00
Grace Guo
b87e0b32ac
refactor: rearrange dashboard page js bundles (#16285) 2021-08-17 16:12:05 -07:00
Elizabeth Thompson
3709131089
check roles before fetching reports (#16260) 2021-08-13 20:41:03 -07:00
Kamil Gabryjelski
517a678cd7
fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233)
* fix(dashboard): cross filter chart highlight when filters badge icon pressed

* Fix tests

* Fix tests

* break out label logic

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-08-13 10:02:28 +02:00
Elizabeth Thompson
a3102488a1
feat: add chart image info to reports from charts (#16158)
* refetch reports on props update

* add chart types to reports
2021-08-10 15:11:10 -07:00
Michael S. Molina
07f33998ac
fix: Multiple dashboard refresh triggers for the same session (#16094) 2021-08-10 09:12:28 -03:00
AAfghahi
606a7bf429
fix: change Alert Permissions (#16118)
* added google alert

* reworked permissions
2021-08-09 13:33:04 -07:00
Grace Guo
85329c374e
refactor: remove unnecessary dataset queries from dashboard requests (#16110)
* refactor: remove unnecessary dataset queries from dashboard requests

* fix comments
2021-08-06 19:01:05 -07:00
Michael S. Molina
6edc1ee3bb
chore: Replaces the select for a dropdown button in the CSS editor (#16043) 2021-08-06 07:59:15 -03:00
Michael S. Molina
e59f318ef9
chore: Changes the RefreshIntervalModal component to use the new select component (#16048) 2021-08-06 07:58:53 -03:00
Michael S. Molina
423ff50768
chore: Changes the dashboard properties modal to use the new select component (#16064) 2021-08-05 19:50:16 -07:00