Commit Graph

2178 Commits

Author SHA1 Message Date
Stephen Liu 100760c464
fix(gallery): Hide the bottom info section when no chart is being selected (#16840) 2021-09-27 15:21:25 +08:00
Ville Brofeldt 0a8d0c6e7f
fix(native-filters): emitted filter label format (#16828) 2021-09-27 09:36:55 +03:00
Ville Brofeldt 42fa54881a
fix(native-filters): filter indicator stale state (#16831) 2021-09-27 08:34:39 +03:00
Ville Brofeldt a3413197de
chore: upgrade to Node 16 (#16809)
* chore: upgrade to Node 16

* add docs

* fix test
2021-09-25 07:26:35 +02:00
AAfghahi 04f7ecad1c
display tooltip when disabled (#16837) 2021-09-24 12:56:33 -07:00
Erik Ritter 55e2872dbf
Fix 500 tab title (#16836) 2021-09-24 12:20:00 -07:00
Michael S. Molina 1ff682f3a9
fix: Updates the selected values when changing the native filter type, column or default value (#16833) 2021-09-24 14:07:20 -03:00
Erik Ritter c933250dad
chore: Remove immutable.js (#16823) 2021-09-23 22:23:42 -07:00
Beto Dealmeida 6921d94861
fix: show Import button only if has perms (#16763)
* fix: show Import button only if has perms

* Fix tests
2021-09-23 14:55:21 -07:00
Ville Brofeldt 4086bedb68
chore: bump superset to 0.18.6 (#16807) 2021-09-23 14:03:03 +03:00
Phillip Kelley-Dotson a198dbb19b
feat: add certifiedby & certification details fields to the edit dataset columns fields (#16454)
* add migration

* add backend and frontend for certified

* update migration with batch

* fix integration test and update Updating.md

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* change method name

* add tooltip info

* add mixin

* merge heads

* address comments

* fix select label styles

* add extra field

* fix test?

* add extra field to put schema

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2021-09-22 15:09:30 -07:00
Lyndsi Kay Williams 63aadd3fe4
test: RTL overhaul - hackathon (#16626)
* CachedLabel_spec fully converted to RTL

* ColumnTypeLabel_spec fully converted to RTL

* MissingChart_spec fully converted to RTL

* RefreshIntervalModal_spec mostly converted to RTL

* HoverMenu_spec mostly converted to RTL

* ResizableContainer_spec fully converted to RTL

* ResizableHandle_spec fully converted to RTL

* AggregateOption_spec fully converted to RTL

* CheckboxControl_spec fully converted to RTL

* ColorPickerControl_spec to RTL

* Finished converting ColorPickerControl_spec to RTL/TS, also converted RefreshIntervalModal_spec to TS

* Added unknown type to ColumnTypeLabelProps

* Fixed ColumnTypeLabel_spec
2021-09-22 11:37:35 -07:00
Beto Dealmeida 4af5ae08f9
fix: encode rison characters when searching (#16768) 2021-09-22 10:06:24 -07:00
Michael S. Molina 99d15b25b0
chore: Moves the images folder to the assets folder (#14429)
* chore: Moves the images folder to the assets folder

* Rebases
2021-09-22 10:28:51 -03:00
Kamil Gabryjelski 486e0d412c
chore: Upgrade Webpack to v5 (#16701)
* Upgrade Webpack to v5

* Remove mapbox hack

* Replace url-loaders and file-loaders with asset modules

* Remove 1 rule

* Change --colors to --color

* Remove invalid option (--no-progress)

* Remove url-loader, bump plugin

* Fix AnnotationLayer formula check

* Remove redundant tests

* Bump cypress packages

* Remove old comment

* Fix tests

* Remove checks for number of scripts in markdown test

* Cosmetic changes

* Add tests

* Fix test

* Fix test

* Fixes test warnings

* disable flaky test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-22 14:24:54 +03:00
Michael S. Molina 9b17e86b44
chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00
Michael S. Molina b6d78bf4f2
refactor: Changes the list views to use the new Select component (#16393)
* chore: Change the list views to use the new Select component

* Fix Cypress tests

* Enables search for all controls

* Adjusts controls width

* Removes 'Me' and keeps the logged user on top

* Fixes tests

* Uses the borderless version for the filters

* Fixes the tests

* Reverts the Select theme to the default

* Rebases and fixes js error

* Fixes failing test

* Removes unused withTheme
2021-09-22 07:44:18 -03:00
Michael S. Molina 596e1cdf9b
refactor: Changes the DatabaseSelector and TableSelector to use the new Select component (#16483) 2021-09-22 07:43:46 -03:00
Ville Brofeldt 1d5100daa2
fix(dataset): retain is_dttm if set on metadata sync (#16776) 2021-09-22 10:13:49 +03:00
Elizabeth Thompson d375538671
only fetch db function when db exists in sql lab (#16754) 2021-09-21 09:40:02 -07:00
Elizabeth Thompson f032cc254c
fix shared query (#16753) 2021-09-21 09:38:23 -07:00
simcha90 985aa06439
chore: Upgrade immer package version (#16741)
* fix:fix get permission function

* chore: update immer

* chore: update immer
2021-09-20 09:36:56 +03:00
Yongjie Zhao 67b13308ca
chore: bump superset-ui 0.18.5 (#16725) 2021-09-18 08:06:08 +08:00
Ville Brofeldt 836b5e2c86
feat: add support for generic series limit (#16660)
* feat: add support for generic series limit

* refine series_columns logic

* update docs

* bump superset-ui

* add note to UPDATING.md

* remove default value for timeseries_limit
2021-09-16 12:09:08 +03:00
Michael S. Molina 86290cc0e5
chore: Improves the Select component to avoid additional queries when all values have been loaded (#16712)
* chore: Improves the Select component to avoid additional queries when all values have been loaded

* Handles the logic in handlePaginateFetch and removes the use effect
2021-09-15 15:39:58 -03:00
Michael S. Molina adc3d24c21
fix: Ignore case and special keys when searching (#16706) 2021-09-15 07:33:43 -03:00
Stephen Liu b0ac5d1625
perf(dashboard): fix filter-box performance bug (#16702) 2021-09-15 08:40:46 +03:00
David Aaron Suddjian 540277ebb1
chore: Add option to set a custom color scheme as default (#16540)
* upgrade superset-ui for new flag

* configurable default categorical scheme

* dry refactor

* doc example

* Update superset-frontend/src/setup/setupColors.ts

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* re-adding # type: ignore (suggestion from ville)

* ugh... missed a space.

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2021-09-14 11:09:03 -07:00
Ville Brofeldt 1d890f8913
fix(explore): make clicked dnd filters unique (#16700) 2021-09-14 18:01:21 +03:00
Geido fecd4124fa
fix: Select refactoring known issues (#16666)
* Clean up and reorganize effects

* Enhance optionFilterProps

* Render custom label

* Remove prop filtering

* Create options

* Create option from value in single mode

* Change to customLabel

* Show search by default

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Apply minor changes

* Fixes a bug that was failing CI

* Adds more tests to the component

* Apply customLabel in ColorSchemeControl

* Remove customLabel from rendered Option

* Hide No data when allowNewOptions

* Remove unnecessary prop from tests

* Adjust loading height

* Show no data with fetchOnlyOnSearch

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-14 17:39:27 +03:00
Ville Brofeldt c99cacbdd2
fix(explore): only refresh data panel on relevant changes (#16699)
* fix(explore): only refresh data panel on relevant changes

* add comment and supress warning
2021-09-14 15:58:05 +03:00
AAfghahi 376c685838
feat: adding logging to validation (#16527)
* adding logging to validation

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-13 16:09:40 -07:00
cccs-joel c6ac10716a
feat: show build number value in the About if present in the config (#14955) 2021-09-13 10:59:08 -07:00
Grace Guo b0b996582c
fix: reset perf logger timer for soft navigation for SPA pages (#16668)
* fix: reset perf logger timer for soft navigation for SPA pages

* fix comments

* fix extra comments

Co-authored-by: grace_guo <grace_guo@grace-guos-MacBook-Pro.local>
2021-09-13 10:16:07 -07:00
simcha90 668ae23f28
feat: Tabs in column (#16593)
* fix:fix get permission function

* feat: add tabs inside column

* lint: fix lint

* test: fix test

* test: fix tests

* test: fix tests

* fix: pass onChangeTab function through layout
2021-09-13 09:02:29 +03:00
Ajay M 4b70d46355
feat(dashboard): Native filters - add type to native filter configuration (#16549)
* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* PR comments

* PR comments

* Fix failing tests
2021-09-09 09:46:44 -07:00
Michael S. Molina e9e6c5de8a
chore: Writes the tests for the new Select component (#16638)
* chore: Writes the tests for the new Select component

* Uses array destructuring
2021-09-09 08:38:33 -03:00
Kamil Gabryjelski 788c0c3dae
fix(dashboard): label colors included in explore url (#16621) 2021-09-08 15:38:02 +02:00
Ville Brofeldt 9dfa33fedf
fix(dnd): make clicked dnd metrics unique (#16632) 2021-09-08 13:21:21 +03:00
Elizabeth Thompson 519baa6f00
fix: params in sql lab are jumpy in the ace editor (#16536)
* fix jumpy params

* remove cypress tests
2021-09-07 09:38:45 -07:00
Michael S. Molina 37c2020035
chore: Merges latest Select changes (#16587) 2021-09-07 10:41:55 -03:00
Kamil Gabryjelski effcf3b50f
perf(dashboard): decrease number of rerenders of FiltersBadge (#16545)
* perf(dashboard): decrease rerenders in FiltersBadge

* implement caching of dashboard filter indicators

* Implement caching for native filter indicators
2021-09-07 12:03:43 +02:00
Kamil Gabryjelski 7faa5c6aff
perf(dashboard): reduce rerenders of DragDroppable (#16525)
* perf(dashboard): reduce rerenders of DragDroppable

* lint fix
2021-09-07 11:19:07 +02:00
Duy Nguyen Hoang 3fe2e6ec73
Remove export CSV in old filter box (#16592) 2021-09-06 14:40:24 +03:00
Ville Brofeldt 7cbced8833
chore(deps): bump superset-ui to 0.18.2 (#16601) 2021-09-06 12:20:29 +03:00
simcha90 df5c0fbce9
feat: Experimental cross-filter plugins (#16594)
* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF
2021-09-06 08:25:14 +03:00
Beto Dealmeida 9bb890ebed
fix: impersonate user label/tooltip (#16573) 2021-09-03 09:42:11 -07:00
Elizabeth Thompson a0db5367d2
bump emotion to help with cache clobbering (#16559) 2021-09-02 13:48:21 -07:00
Michael S. Molina 02798a3517
fix: Adds a loading message when needed in the Select component (#16531) 2021-09-02 13:17:47 -03:00
Yongjie Zhao 2e11b05d73
chore: bump superset-ui to 0.18.1 (#16563) 2021-09-02 09:03:43 +03:00
Ville Brofeldt 75a1b19174
chore: bump superset-ui to 0.18.0 (#16544) 2021-09-02 13:16:03 +08:00
Yongjie Zhao 80c39daa85
fix: can't drop column when name overlap (#16482) 2021-09-01 13:52:10 +08:00
Geido f001c44727
Make Modal draggable and resizable (#16447) 2021-08-31 12:46:44 +03:00
Phillip Kelley-Dotson a616b8785e
make chart rerender on timeseries change (#16411) 2021-08-30 16:43:14 -07:00
Phillip Kelley-Dotson 960d1e4d5d
fix: stop endless loading when dataset no longer exist (#16511)
* initial fix

* add const

* add translate
2021-08-30 16:42:02 -07:00
Grace Guo 2199f65373
fix: sql lab refetch button (#16469)
* fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)

* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments

(cherry picked from commit 408d58f937)

* handle exception caused by invalid query id
2021-08-30 15:47:00 -07:00
Ville Brofeldt 147637a02d
fix(native-filters): add handle undefined control value gracefully (#16468) 2021-08-27 14:03:05 +03:00
Erik Ritter 8adc31d14c
Revert "chore: Changes the DatabaseSelector to use the new Select component (#16334)" (#16478)
This reverts commit c768941f2f.
2021-08-26 22:28:04 -03:00
Jesse Yang a413f796a6
fix(explore): JS error for creating new metrics from columns (#16477) 2021-08-26 17:04:45 -07:00
AAfghahi ee2eccdb67
fix: queryEditor bug (#16452)
* queryEditor bug

* update tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-26 15:20:02 -07:00
Kamil Gabryjelski f422f1ea49
perf(dashboard): decouple redux props from dashboard components (#16421)
* perf(dashboard): decouple redux props from dashboard components

* Lint fix

* Dont make copy of filters object

* Remove unnecessary exports
2021-08-26 21:54:11 +02:00
Kamil Gabryjelski 8ad495a572
perf(dashboard): reduce number of rerenders of Charts (#16444)
* perf(dashboard): reduce number of rerenders of Charts

* Remove static property

* Cleanup
2021-08-26 21:53:44 +02:00
Yongjie Zhao 577ede4b12
fix: prevent page crash when chart can't render (#16464) 2021-08-26 22:26:01 +08:00
Ville Brofeldt 1c71eda70f
fix(native-filters): handle null values in value filter (#16460)
* fix(native-filters): handle null values in value filter

* lint
2021-08-26 15:26:53 +03:00
Jesse Yang ec087507e5
refactor(explore): improve typing for Dnd controls (#16362) 2021-08-26 01:23:14 -07:00
Ville Brofeldt 18be181946
fix(explore): update overwrite button on perm change (#16437)
* fix(explore): update overwrite on perm change

* remove redundant user_id prop

* fix types

* fix user type

* fix tests

* fix lint
2021-08-26 06:24:33 +03:00
Geido db11c3e6c8
feat: Draggable and Resizable Modal (#16394)
* Implement resizable prop

* Implement resizableConfig

* Implement fluid Syntax Highlighter

* Implement draggable

* Destroy on close

* Implement draggableConfig

* Enhance with footer calculation

* Add new line

* Make whole header draggable trigger
2021-08-25 16:11:16 +03:00
Maxhui 6a2cec51c5
fix(dashboard): undo and redo buttons weird alignment (#16417)
* fix(dashboard-ui): undo and redo buttons weird alignment

* fix(Explore control pane): keyboard nav & focus

* lint: lint frontend

* fix: fix redo and undo button style

* lint: lint line

* lint: lint line

Co-authored-by: xuzhebin <maxhui2020@gmail.com>
2021-08-25 08:52:59 -03:00
Grace Guo 08b8aa277f
fix: setupPlugin in chart list page (#16413)
* fix: setupPlugin in chart list page

* fix the order of setupPlugins call

* Fix jest test on loading geojson

* add jest changes

* fix unit tests

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-08-24 23:10:46 -07:00
Grace Guo 78d8089b18
fix: Disable Slack notification method if no api token (#16367)
* feat: allow company choose alert/report notification methods

* fix: disable Slack as notification method if no api token

* fix unit test

* improve typing
2021-08-24 17:28:50 -07:00
AAfghahi 631ad02a76
fix: copy to Clipboard order (#16299)
* copy to Clipboard order

* centralized copyToClipboard

* fixed table order

* fixed tests

* added colnames to all viz types

* added colnames to all viz types

* added colnames to all viz types
2021-08-24 14:47:09 -07:00
Ville Brofeldt 5eded9fe1b
chore(viz): bump superset-ui to 0.17.87 (#16420) 2021-08-24 11:10:23 -07:00
Evan Rusackas 81241b6024
Revert "fix(explore): let admin overwrite slice (#16290)" (#16408)
This reverts commit d13b081cfe.
2021-08-24 09:38:41 -06:00
Michael S. Molina 6a5568764e
chore: Removes the TODOs and uses the default page size (#16422) 2021-08-24 11:44:27 -03:00
Michael S. Molina 575e7af859
fix: Show cross filter option only when cross filter is enabled (#16391) 2021-08-24 09:13:39 -03:00
Geido 9a37ad1a1e
fix: Return original document title when leaving a dashboard (#16323)
* Return original title on unmount

* Name var originalDocumentTitle
2021-08-24 15:08:13 +03:00
Michael S. Molina 1fc9318594
chore: Changes the AlertReportModal to use the new Select component (#16144)
* chore: Changes the AlertReportModal to use the new Select component

* Gives time to close the select before changing the type
2021-08-24 08:19:27 -03:00
Geido c14364c616
chore: Enhance Omnibar (#16273)
* Fix style and implement ESC

* Include ESC test case

* Move pagination outside of table

* Update superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Enhance

* Handle close

* Localize placeholder

* Fix tests

* Clear input on close

* Destroy modal on close

* Clean up

* Fix tests

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-24 11:52:07 +03:00
AAfghahi a6aad52e38
fix: regex for multi-region IPs (#16410)
* regex for multi-region IPs

* Update index.tsx
2021-08-23 13:54:25 -07:00
Michael S. Molina c768941f2f
chore: Changes the DatabaseSelector to use the new Select component (#16334) 2021-08-23 15:41:03 -03:00
Michael S. Molina 0cdc7675b4
chore: Displays the dataset description in a tooltip in the datasets list (#16392) 2021-08-23 15:38:53 -03:00
Phillip Kelley-Dotson 3faf653e5f
initial commit (#16366) 2021-08-20 17:46:55 -06:00
Erik Ritter a9f502b67b
fix: big number default date format (#16383) 2021-08-20 16:08:54 -07:00
Phillip Kelley-Dotson c5081991fc
initial commit (#16380) 2021-08-20 16:59:53 -06:00
Lyndsi Kay Williams 518c3c9ae0
test: Functional RTL for email report modal II (#16148)
* Email Report Modal validation testing

* Starting RTL testing for email report

* Calendar icon now rendering!

* Create report testing in dashboard

* make linter happy

* Fixing weird error

* Removed ExploreChartHeader_spec

* Fixed dashboard header test

* revert changes from merge

* Fix tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-20 10:08:36 -07:00
Ville Brofeldt 575ee24a99
fix: call external metadata endpoint with correct rison object (#16369) 2021-08-20 11:43:57 +03:00
Hugh A. Miles II 50d896f1b7
fix: Fix parsing onSaving reports toast when user hasn't saved chart (#16330)
* don't maniuplate error message

* remove extra idx reference

* u

* change print

* update with test

* add case for dashboards

* fix test
2021-08-19 14:04:23 -04:00
Ville Brofeldt 86f4e691d4
chore(viz): bump deckgl plugin to 0.4.11 (#16353) 2021-08-19 19:19:48 +03:00
Geido c5c28618a5
fix: Blank space in Change dataset modal without warning message (#16324)
* Make scrollTable flex

* Revert unclosable warning
2021-08-19 16:46:25 +02:00
Evan Rusackas 42cd21e383
chore: bump superset-ui to v0.17.85 (#16350) 2021-08-19 09:32:24 +03:00
Elizabeth Thompson efe850b731
adjust initial state (#16329) 2021-08-18 13:18:36 -07:00
Kamil Gabryjelski a547dcb73e
fix(explore): reordering columns with dnd sometimes glitching (#16322)
* fix(explore): reordering columns with dnd sometimes glitching

* Fix metrics and filters popover being stale after reordering
2021-08-18 18:39:05 +02:00
Kamil Gabryjelski 2c595b09ea
chore(explore): make metric/column search input clearable (#16320)
* chore(explore): make metric/column search input clearable

* Fix typo

* Fix test
2021-08-18 12:23:23 +02:00
Elizabeth Thompson 4960b5ee2b
pass correct report_format (#16306) 2021-08-17 18:31:38 -07:00
Beto Dealmeida 7a284bb9e8
fix: allow reports to update query_context (#16303) 2021-08-17 16:39:27 -07:00
Grace Guo b87e0b32ac
refactor: rearrange dashboard page js bundles (#16285) 2021-08-17 16:12:05 -07:00
Beto Dealmeida 3c0aefb61a
Revert "fix: disable text reports for now (#16257)" (#16296)
This reverts commit ee9a384758.
2021-08-17 14:21:15 -07:00
Phillip Kelley-Dotson f581e0402b
change filter (#16280) 2021-08-17 09:37:39 -07:00
AAfghahi f5fbfef618
timezone editor (#16281) 2021-08-17 09:32:17 -07:00
Kamil Gabryjelski 203c311ca3
feat(explore): make dnd controls clickable (#16119)
* Make ghost buttons clickable

* Popover for column control

* Make column dnd ghost button clickable

* Prefill operator only if column is defined

* Remove data-tests

* lint fix

* Hide new features behind a feature flag

* Change ghost button texts

* Remove caret for non clickable columns
2021-08-17 14:56:39 +02:00
Geido 9876c36f6e
Fix table height (#16275) 2021-08-17 09:58:13 +02:00
Ville Brofeldt d13b081cfe
fix(explore): let admin overwrite slice (#16290) 2021-08-17 10:55:33 +03:00
Ville Brofeldt 2be84e78d2
chore(explore): remove unnecessary favstar redirect (#16288) 2021-08-17 09:09:38 +03:00
Beto Dealmeida ee9a384758
fix: disable text reports for now (#16257)
* fix: disable text reports for now

* Update tests
2021-08-16 08:16:48 -07:00
Michael S. Molina 0668eaad6a
chore: Improves the flow to create a new chart (#16252)
* chore: Improves the flow to create a new chart

* Adds a comment about selector specificity
2021-08-16 11:56:47 -03:00
Geido 22231addec
Move pagination outside of table (#16232) 2021-08-16 16:43:49 +02:00
Elizabeth Thompson 3709131089
check roles before fetching reports (#16260) 2021-08-13 20:41:03 -07:00
Phillip Kelley-Dotson a5dbe6a14d
fix examples tab for dashboard (#16253) 2021-08-13 14:56:32 -07:00
Phillip Kelley-Dotson f94695480a
chore: bump superset-ui packages to 0.17.84 (#16251)
* initial bump

* commit pack-lock file
2021-08-13 13:40:26 -06:00
Michael S. Molina 720e5b111a
chore: Shows the dataset description in the gallery dropdown (#16200)
* chore: Shows the dataset description in the gallery dropdown

* chore: Adjusts the tooltip positioning, fixes the search and removes unnecessary bootstrap data
2021-08-13 15:08:12 -03:00
Geido c09f6ed15b
fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168)
* Fix style and implement ESC

* Include ESC test case

* Update superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-13 18:44:49 +02:00
Yongjie Zhao 6cd15d54a0
refactor: external metadata fetch API (#16193)
* refactor: external metadata api

* fix comments

* fix ut

* fix fe lint

* fix UT

* fix UT
2021-08-13 20:56:42 +08:00
Kamil Gabryjelski 517a678cd7
fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233)
* fix(dashboard): cross filter chart highlight when filters badge icon pressed

* Fix tests

* Fix tests

* break out label logic

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-08-13 10:02:28 +02:00
Beto Dealmeida 5d3d6b6eae
fix: validate_parameters and query (#16241)
* fix: validate_parameters and query

* add onQueryChange
2021-08-12 18:05:27 -07:00
Evan Rusackas cdcc161846
fix: Remove Advanced Analytics tag for 2 charts (#16240)
* removing AA tag from TimeTableChartPlugin

* package bump for echarts (removes AA tag there)

* package-lock bump for new echarts plugin
2021-08-12 15:32:39 -06:00
AAfghahi 9d0dc561fc
Revert "feat: Changing Dataset names (#16199)" (#16235)
This reverts commit adb3ebbba3.
2021-08-12 13:59:44 -07:00
Hugh A. Miles II 171514360e
feat: Allow users to connect via legacy SQLA form (#16201)
* hugh/dbui-other

* remove extra condition

* add not callable

* Update .pylintrc

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-12 15:10:42 -04:00
Geido a1e18ed110
fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060)
* Implement dynamic tooltip

* Normalize and consolidate

* Clean up

* Refactor and clean up

* Remove unnecessary var

* Fix type import

* Update superset-frontend/src/explore/components/controls/OptionControls/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove unnecessary styled span

* Show full tooltip title

* Force show tooltip

* Force show tooltip D&D off

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-08-12 11:48:16 -06:00
Geido 2c5731aea3
Show/hide tooltips (#16192) 2021-08-12 11:42:48 -06:00
Kamil Gabryjelski a16e290765
fix(explore): conditional formatting value validators (#16230)
* fix(explore): conditional formatting value validators

* Fix typing, make validator more generic

* Remove commented code
2021-08-12 14:31:29 +02:00
Phillip Kelley-Dotson c79de7abd7
initial fix (#16212) 2021-08-11 15:50:50 -07:00
Phillip Kelley-Dotson b4555dfa4f
fix: sorting on "Modified By" in chart table (#16208)
* initial fix

* Update ChartList.tsx

change sort to first name
2021-08-11 15:31:10 -07:00
Kamil Gabryjelski ccfc95fbe6
fix(explore): adhoc metrics popover resets label after hovering outside (#16196)
* fix(explore): adhoc metrics popover resets label after hovering outside

* Remove irrelevant tests and skip rest

* Use ensureIsArray
2021-08-11 10:05:08 -06:00
AAfghahi 6c304b83a9
feat: Changing Dataset names (#16199)
* added google alert

* changing Dataset Names
2021-08-11 08:59:59 -07:00
Kamil Gabryjelski 98fc29cbbb
fix(explore): metric label disappearing in some scenarios (#16190) 2021-08-11 14:05:44 +02:00
Ville Brofeldt 4df3672baa
chore: bump superset-ui to 0.17.82 (#16186) 2021-08-11 10:08:12 +03:00
Phillip Kelley-Dotson a30d884cfc
fix: change listivew card layouts to the new homepage card layout (#16171)
* initial commit

* removing CardStylesOverrides (unused)

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-10 20:26:24 -07:00
Junlin Chen 9841c78967
chore: switch back tag name to popular from highly-used (#16174)
* chore: switch back tag name to popular from highly-used

* new package lock

* new package lock with npm 7

* fix lint

* remove package changes

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 20:23:14 -07:00
Phillip Kelley-Dotson a0c9b9d9c2
fix: ensure created user entities do not show inside examples (#16176)
* initial commit

* fix lint

* Update superset-frontend/src/views/CRUD/utils.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/views/CRUD/utils.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/views/CRUD/utils.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-10 19:53:47 -07:00
Elizabeth Thompson 628169a171
feat: change query predicate to text (#16160)
* change query predicate to text

* make input multiline

* remove value that is too long for the downgrade

* keep logging lint rule
2021-08-10 17:52:01 -07:00
AAfghahi 2dc0bdda5d
feat: Added multi-regional IPs to Database Connections (#16170)
* added google alert

* multi-regional IPs

* beto revisions

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 17:25:49 -07:00
Beto Dealmeida 9f52c103ac
fix: isDynamic function (#16175)
* fix: isDynamic function

* trigger tests
2021-08-10 16:28:43 -07:00
Elizabeth Thompson a3102488a1
feat: add chart image info to reports from charts (#16158)
* refetch reports on props update

* add chart types to reports
2021-08-10 15:11:10 -07:00
Geido 5e64d65a8b
Hide Safari default tooltip (#16145) 2021-08-10 14:38:13 -06:00
Beto Dealmeida 7b3fce7e81
fix: revert data endpoint name (#16162) 2021-08-10 11:59:27 -07:00
Hugh A. Miles II 3f86a54ac1
fix: turn on SSL in database edit form show 500 error (#16151)
* fix error for query.update

* converrt before making request

* fix query params

* remove unchanged files

* this

* update tsconfig
2021-08-10 13:31:28 -04:00
Hugh A. Miles II fd80ae34a3
fix: Make sheet_name into a `ValidationInputError` (#16056)
* setup validates for name

* add error type

* fix linting

* fix test

* remove errors

* fix number

* fix test
2021-08-10 13:07:31 -04:00
Phillip Kelley-Dotson f0e3b68cc2
fix: ensure that users viewing chart does not automatically save edit data (#16077)
* add last_change_at migration

* add last_saved_by db migration

* finish rest of api migration

* run precommit

* fix name

* run precommitt

* remove unused mods

* merge migrations

* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/migrations/versions/f6196627326f_update_chart_permissions.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* fix test

* precommit

* remove print

* fix test

* change test

* test commit

* test 2

* test 3

* third time the charm

* fix put req

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 10:29:49 -06:00
Ville Brofeldt 63ace7b288
feat(cross-filters): add support for temporal filters (#16139)
* feat(cross-filters): add support for temporal filters

* fix test

* make filter optional

* remove mocks

* fix more tests

* remove unnecessary optionality

* fix even more tests

* bump superset-ui

* add isExtra to schema

* address comments

* fix presto test
2021-08-10 17:18:46 +01:00
Elizabeth Thompson 5488a8a948
add config to hide some user menu items (#16156) 2021-08-10 09:03:13 -07:00
Kamil Gabryjelski 6e1d16d956
feat(explore): each control can define its own canDrop for dnd (#16090)
* feat(explore): each control can define its own canDrop for dnd

* Make canDropValue optional

* Add onDropValue
2021-08-10 17:04:42 +02:00
Phillip Kelley-Dotson a70248736f
feat: add sticky state to tables and loadingcards state. (#16102)
* initial feat commit

* fix chart and dash rendering onload

* Update superset-frontend/src/views/CRUD/welcome/Welcome.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* fix jumpyness and add const

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-08-10 06:43:59 -07:00
Michael S. Molina 273ab3d257
fix: Safari is not showing scroll bars in Explore (#16089) 2021-08-10 10:41:52 -03:00
Michael S. Molina 07f33998ac
fix: Multiple dashboard refresh triggers for the same session (#16094) 2021-08-10 09:12:28 -03:00
Yongjie Zhao bb1d8fe4ef
fix: boolean type into SQL 'in' operator (#16107)
* fix: boolean type into SQL 'in' operator

* fix ut

* fix ut again

* update url

* remove blank line
2021-08-10 19:21:46 +08:00
Maxime Beauchemin 79e8d77acc
chore: remove TerserPlugin step for build (#16163) 2021-08-10 17:09:40 +08:00
Lyndsi Kay Williams 3712ee02fa
additional params field fixed (#16161) 2021-08-09 19:13:37 -07:00
AAfghahi 606a7bf429
fix: change Alert Permissions (#16118)
* added google alert

* reworked permissions
2021-08-09 13:33:04 -07:00
AAfghahi 5ce38839e7
feat: better errors for report in charts and dashboard (#16131)
* added google alert

* better errors and report actions
2021-08-09 13:32:52 -07:00
AAfghahi a51851308b
feat: added google alert to DB Connection Form (#16095)
* added google alert

* using superset_text

* made google alert public and others private

* Hugh revisions
2021-08-09 14:08:06 -04:00
Kamil Gabryjelski b7cc89c6d4
fix(explore): dnd error when dragging metric if multi: false (#16088)
* fix(explore): dnd error when dragging metric if multi: false

* Fix error for non-dnd controls
2021-08-09 18:15:50 +02:00
adam-stasiak 578a9e9d53
build: Removed jsx-remove-data-test-id usage from code for multi-build-variant testing (#15386)
* enabled customized production build with testIds

* fix for docker

* changed substitution

* changed substitution
2021-08-09 10:11:26 -06:00
Kamil Gabryjelski 6ac4f4ef2f
chore(explore): change dnd placeholders (#16116)
* chore(explore): change dnd placeholders

* Fix tests and lint
2021-08-09 17:50:11 +02:00
Maxime Beauchemin df50a47777
chore: add stats logging to thumbnail api (#16133) 2021-08-09 08:34:51 -07:00
Geido b07c80a839
Adjust width (#16092) 2021-08-09 17:25:33 +02:00
Yongjie Zhao 3bbcc30d69
fix: virtual dataset wont work (#16132) 2021-08-07 20:43:12 +08:00
Grace Guo 85329c374e
refactor: remove unnecessary dataset queries from dashboard requests (#16110)
* refactor: remove unnecessary dataset queries from dashboard requests

* fix comments
2021-08-06 19:01:05 -07:00
Kamil Gabryjelski 772da8de63
fix(explore): revert dnd column dependency array change to fix infinite rerenders (#16115)
* fix(explore): revert dnd column dependency array change to fix infinite rerenders

* Remove console.log

* Remove comment
2021-08-06 17:59:22 +02:00
ʈᵃᵢ b80f018691
fix: move watermark to about section (#16097) 2021-08-06 05:48:22 -07:00
Michael S. Molina 6edc1ee3bb
chore: Replaces the select for a dropdown button in the CSS editor (#16043) 2021-08-06 07:59:15 -03:00
Michael S. Molina e59f318ef9
chore: Changes the RefreshIntervalModal component to use the new select component (#16048) 2021-08-06 07:58:53 -03:00
Michael S. Molina 423ff50768
chore: Changes the dashboard properties modal to use the new select component (#16064) 2021-08-05 19:50:16 -07:00
David Aaron Suddjian e6292a89bb
fix(explore): drag & drop column select component triggering onChange unnecessarily (#16073)
* fix(explore): avoid sync until after first render

* fix example
2021-08-05 15:38:28 -07:00
David Aaron Suddjian 23072161e2
fix(dashboard): user id can be null when there is an anonymous user (#15592) 2021-08-05 15:35:10 -07:00
AAfghahi e6274e0764
change button color (#16093) 2021-08-05 10:38:30 -07:00
Kamil Gabryjelski af204ff449
chore(explore): bump deckgl to 0.4.9 (#16086) 2021-08-05 18:10:23 +02:00
Kamil Gabryjelski a59d458e41
chore(explore): Create new entrypoints for Echarts Timeseries (#15942)
* feat(explore): Create new entrypoints for Echarts Timeseries

* Change order of some charts

* bump superset-ui

* also bump echarts package

* fix UT

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-08-05 07:28:16 +02:00
Hugh A. Miles II 11a2d4dfdd
fix: Remove grey bar for TableElement component when `metadata` is empty (#16054)
* create serialize json function

* remove grey space with no metadata

* remove console log
2021-08-04 17:07:20 -04:00
Ville Brofeldt 7ef97a54e2
feat(explore): add automatic conditional formatter to pivot table v2 (#16045) 2021-08-04 22:12:20 +03:00
AAfghahi 4359650b7d
fix: Adding report bug (#16065)
* report add fix

* added theme
2021-08-04 11:37:46 -07:00
Ville Brofeldt 86cecaeec5
fix(native-filters): add support for boolean cols to select (#16061) 2021-08-04 21:05:55 +03:00
Duy Nguyen Hoang 2c55cc6558
fix: Align alert solid small svg center (#15762) 2021-08-04 12:00:50 -06:00
Michael S. Molina 1917464d2b
fix: Fix the Select unselect for object values (#16062) 2021-08-04 11:52:39 -03:00
Ville Brofeldt 7332055ff6
chore: bump superset-ui to 0.17.78 (#16058) 2021-08-04 13:03:34 +03:00
Yongjie Zhao 430ebe18aa
fix: sync columns in explore page (#16042) 2021-08-03 09:49:08 -07:00
Beto Dealmeida ec22acb786
fix: handle schemas_allowed_for_csv_upload serde (#16038)
* fix: handle schemas_allowed_for_csv_upload serde

* Add migration
2021-08-03 09:10:32 -07:00
Hugh A. Miles II 4cb79e5017
fix: Fix long dashboards screenshot emails (#15954)
* create serialize json function

* create new setting for reports

* cleanup

* address comments

* up the attributes
2021-08-02 16:37:34 -04:00
Kamil Gabryjelski 5917407b9c
fix(explore): filter popover opening after removing a filter (#16024) 2021-08-02 22:01:17 +02:00
Michael S. Molina 76a13dfc9a
fix: Modal is blinking when opening (#16035) 2021-08-02 16:18:54 -03:00
Geido 39913d286a
Implement sectionId (#16022) 2021-08-02 12:12:36 -07:00
Ville Brofeldt c8a8347b43
chore: bump superset-ui to 0.17.77 (#16034) 2021-08-02 11:48:54 -07:00
Michael S. Molina a889cb3505
chore: Auto focus the viz gallery select (#16025) 2021-08-02 14:59:17 -03:00
Elizabeth Thompson e0576786c3
add feature flag to header bar (#16031) 2021-08-02 10:57:29 -07:00
Elizabeth Thompson 5031a67597
feat: Self subscribe reports (#16027)
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-08-02 09:12:09 -07:00
Kamil Gabryjelski 3061b6ad09
fix(explore): fix undefined error when using dnd (#16020) 2021-08-02 15:22:32 +02:00
Geido 475f9cdc35
fix: Sort Metrics by ID DESC (order of creation) in the Datasource Editor (#15971)
* Sort metrics by ID

* Fix undefined metrics
2021-08-02 11:16:01 +02:00
Yongjie Zhao a786373fff
feat: auto sync table columns when change dataset (#15887)
* feat: auto sync dataset metadata when change dataset

* diablo sync button when edit mode

* handle undefine schema

* fix py UT

* fix FE UT

* improve test coverage

* fix UT
2021-08-02 16:55:31 +08:00
David Aaron Suddjian 46188c1011
fix(explore): calculate query staleness correctly (#15994) 2021-07-31 19:46:34 -06:00
Beto Dealmeida ce6bc3b598
fix: save DB with with query (#15991) 2021-07-31 10:48:15 -07:00
Jesse Yang b73d7baedf
fix(dashboard): FilterBox JS error when datasets API is slow (#15993) 2021-07-30 22:06:29 -07:00
stellalc7 324ecb31fc
fix: three button styles to tertiary (#15978)
* changed margin right on warning icon to 8px

* fixed to grid units from pixels

* Changed three buttons styles to tertiary
2021-07-31 10:25:55 +08:00
Phillip Kelley-Dotson 5fd798afb7
chore: change dropdown icons from horizontal to vertical (#15958)
* change icons

* add size

* fix storybook

* fix favstar, add new icons, and others

* fix lint
2021-07-30 17:02:40 -06:00
serenajiang c37c56c2e4
Revert "fix: Select a query from History and Run (#15891)" (#15992)
This reverts commit 8c7e09e500.
2021-07-30 15:24:07 -07:00
Elizabeth Thompson 908db3ab31
fix select width (#15986) 2021-07-30 14:58:03 -07:00
Michael S. Molina a3a762e5a7
fix: Dataset field required 2 clicks to select when dashboard was empty (#15985) 2021-07-30 17:23:00 -03:00
Beto Dealmeida f1b57c0d88
fix: DB add modal (#15981) 2021-07-30 14:32:48 -04:00
Michael S. Molina cc704dd53a
fix: Cancel alert is not appearing to all native filters modal fields (#15925) 2021-07-30 11:59:36 -03:00
Michael S. Molina eb78f4332f
fix: Name change is not lost in left side of modal when return to edition after aborting changes (#15952) 2021-07-30 08:21:12 -03:00
Michael S. Molina e8f18f4dbf
fix: Drag inner tab to outer tab while editing a dashboard will show an error (#15946) 2021-07-30 08:20:43 -03:00
Geido c2e4290392
fix(dashboard): Add required message in the tooltip for the time range filter (#15941)
* Add required msg in tooltip

* Fix lint

* Keep red border on hover
2021-07-30 09:44:33 +02:00