pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Dataset field required 2 clicks to select when dashboard was empty (#15985)

This commit is contained in:
Michael S. Molina 2021-07-30 17:23:00 -03:00 committed by GitHub
parent f1b57c0d88
commit a3a762e5a7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
View File

@ -510,7 +510,8 @@ const FiltersConfigForm = (
setHasDefaultValue,
] = useDefaultValue(formFilter, filterToEdit);
const showDataset = !datasetId || datasetDetails;
const showDataset =
!datasetId || datasetDetails || formFilter?.dataset?.label;
useEffect(() => {
if (hasDataset && hasFilledDataset && hasDefaultValue && isDataDirty) {

3
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
View File

@ -171,7 +171,8 @@ export function FiltersConfigModal({
setCurrentFilterId(initialCurrentFilterId);
setRemovedFilters({});
setSaveAlertVisible(false);
setFormValues({ filters: {}, changed: false });
setFormValues({ filters: {} });
form.setFieldsValue({ changed: false });
};
const getFilterTitle = (id: string) =>