Commit Graph

2103 Commits

Author SHA1 Message Date
Michael S. Molina
87290ddcc8
fix: Native filters cyclic dependency (#16921) 2021-09-30 14:55:54 -03:00
Michael S. Molina
c5d23fbcc7
fix: Unable to add dataset (#16925) 2021-09-30 14:52:48 -03:00
Geido
7f330c9692
Verify undefined operatorId (#16923) 2021-09-30 18:53:48 +03:00
Geido
c8db435730
fix(Explore): Clear filter value when changing columns (#16871)
* Clear filter value onChange

* Clear filter value on user change action
2021-09-30 17:18:08 +03:00
Michael S. Molina
1a38ec6c43
chore: Adds the drag icon (#16919) 2021-09-30 10:29:12 -03:00
Michael S. Molina
3d520f2cc9
fix: Inclusive sign in time range display (#16906)
* fix: Time range display to show inclusive range

* Skips flakky test
2021-09-30 09:57:07 -03:00
Michael S. Molina
ae26967c4e
fix: Disable lazy loading for the Database selector (#16908)
* fix: Disable lazy loading for the Database selector

* Fixes the tests
2021-09-30 09:29:27 -03:00
Michael S. Molina
05632b9804
chore: Moves the stylesheets folder to the assets folder (#16880)
* chore: Moves the stylesheets folder to the assets folder

* Changes {src} to src
2021-09-30 09:28:38 -03:00
Ville Brofeldt
77e7d162d2
ci: check npm lockfile version (#16916) 2021-09-30 10:43:38 +02:00
Hugh A. Miles II
331de0c4ae
fix: Fix Uniqueness check before update for Sqllab Overwrites (#16859)
* add condition to make sure columns are available before throwing

* fix

* remove database_id from history changed

* refactor update call to datasets

* cleanup

* oops

* prettier
2021-09-29 13:38:29 -04:00
AAfghahi
904c506591
fixing db connection (#16899) 2021-09-29 10:02:34 -07:00
Michael S. Molina
4da4fe4136
fix: Removing parent filter causes incorrect state of child filter (#16876)
* fix: Removing parent filter causes incorrect state of child filter

* removed to isRemoved

* Shows (deleted) when the parent is removed

* Removes unnecessary code
2021-09-29 13:04:07 -03:00
simcha90
3d8cc15cba
fix: Clear native filters state (#16893)
* fix:fix get permission function

* fix: clear native filters state
2021-09-29 13:50:21 +03:00
Michael S. Molina
e3b14fe170
fix: Overhead when changing the filter name (#16877) 2021-09-29 07:37:02 -03:00
AAfghahi
aa747219ad
feat: Add Private Google Sheets to dynamic form (#16628)
* first pass private gsheets

* made encrypted extra into string, refactored onParametersChanged

* private sheets working, credential_info errors

* all but test connection working

* first pass private gsheets

* made encrypted extra into string, refactored onParametersChanged

* private sheets working, credential_info errors

* all but test connection working

* Regenerate package-lock.json

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-28 17:08:50 -07:00
Ville Brofeldt
9ac55d9afa
fix(build): enable hot reloading of linked packages (#16867) 2021-09-28 16:21:17 +02:00
Michael S. Molina
27a40d2a67
chore: Upgrades Storybook to version 6.3.8 to make it compatible with Webpack 5 (#16857) 2021-09-27 14:51:53 -03:00
Geido
d3f6145aba
fix(dashboard): Fill form with the latest values when undo in native filters (#16851)
* Set undoFormValues

* Reorganize

* Revert check

* Fix and clean up

* Fix pre-filter and sort values
2021-09-27 09:39:26 -07:00
Geido
667b88c800
chore: Select component refactoring - TimeSeriesColumnControl - Iteration 5 (#16442)
* Refactor Select

* Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Fix tests

* Mock debounce

* Add debounce

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-09-27 18:19:03 +03:00
Geido
271ec6ec75
chore: Select component refactoring - SaveModal - Iteration 5 (#16446)
* Refactor Select

* Fix Cypress

* Reconcile with master

* Use onChange over onSelect

* Reconcile with latest changes

* Update Cypress

* Update Cypress test

* Fix lint
2021-09-27 18:14:58 +03:00
Geido
ab9f8cb2ea
chore: Select component refactoring - PropertiesModal - Iteration 5 (#16445)
* Refactor Select

* Update tests and checks

* Clean up props

* Update ariaLabel

* Reconcile with master changes

* Apply enhancements

* Fix lint
2021-09-27 18:12:59 +03:00
Geido
e40ff3ada6
chore: Select component refactoring - DndColumnSelectControl - Iteration 5 (#16440)
* Refactor Select

* Update ariaLabel

* Reconcile with latest Select changes

* Fix lint

* Enhance labels
2021-09-27 17:27:14 +03:00
Geido
913df18075
chore: Select component refactoring - MetricControl - Iteration 5 (#16423)
* Refactor Select

* Render saved metric option

* Update tests

* Fix Cypress and ariaLabels

* Fix lint

* Lint Cypress

* Reconcile with latest Select changes
2021-09-27 17:25:51 +03:00
Geido
8ad03c4f25
chore: Select component refactoring - FilterControl - Iteration 5 (#15777)
* Refactor Select for AdhocFilterEditPopoverSqlTabContent

* Refactor Selects

* Fix numeric options

* Clean up

* Fix Select value

* Add showSearch

* Display null label

* Implement StyledSelect

* Update superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSqlTabContent/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Fix aria-label

* Revert MetricControls changes

* Update ariaLabel

* Reconcile with latest Select changes

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-09-27 17:23:52 +03:00
Ville Brofeldt
f703c12ae8
chore: bump superset-ui to 0.18.8 (#16850) 2021-09-27 11:54:05 +03:00
Stephen Liu
100760c464
fix(gallery): Hide the bottom info section when no chart is being selected (#16840) 2021-09-27 15:21:25 +08:00
Ville Brofeldt
0a8d0c6e7f
fix(native-filters): emitted filter label format (#16828) 2021-09-27 09:36:55 +03:00
Ville Brofeldt
42fa54881a
fix(native-filters): filter indicator stale state (#16831) 2021-09-27 08:34:39 +03:00
Ville Brofeldt
a3413197de
chore: upgrade to Node 16 (#16809)
* chore: upgrade to Node 16

* add docs

* fix test
2021-09-25 07:26:35 +02:00
AAfghahi
04f7ecad1c
display tooltip when disabled (#16837) 2021-09-24 12:56:33 -07:00
Erik Ritter
55e2872dbf
Fix 500 tab title (#16836) 2021-09-24 12:20:00 -07:00
Michael S. Molina
1ff682f3a9
fix: Updates the selected values when changing the native filter type, column or default value (#16833) 2021-09-24 14:07:20 -03:00
Erik Ritter
c933250dad
chore: Remove immutable.js (#16823) 2021-09-23 22:23:42 -07:00
Beto Dealmeida
6921d94861
fix: show Import button only if has perms (#16763)
* fix: show Import button only if has perms

* Fix tests
2021-09-23 14:55:21 -07:00
Ville Brofeldt
4086bedb68
chore: bump superset to 0.18.6 (#16807) 2021-09-23 14:03:03 +03:00
Phillip Kelley-Dotson
a198dbb19b
feat: add certifiedby & certification details fields to the edit dataset columns fields (#16454)
* add migration

* add backend and frontend for certified

* update migration with batch

* fix integration test and update Updating.md

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* change method name

* add tooltip info

* add mixin

* merge heads

* address comments

* fix select label styles

* add extra field

* fix test?

* add extra field to put schema

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2021-09-22 15:09:30 -07:00
Lyndsi Kay Williams
63aadd3fe4
test: RTL overhaul - hackathon (#16626)
* CachedLabel_spec fully converted to RTL

* ColumnTypeLabel_spec fully converted to RTL

* MissingChart_spec fully converted to RTL

* RefreshIntervalModal_spec mostly converted to RTL

* HoverMenu_spec mostly converted to RTL

* ResizableContainer_spec fully converted to RTL

* ResizableHandle_spec fully converted to RTL

* AggregateOption_spec fully converted to RTL

* CheckboxControl_spec fully converted to RTL

* ColorPickerControl_spec to RTL

* Finished converting ColorPickerControl_spec to RTL/TS, also converted RefreshIntervalModal_spec to TS

* Added unknown type to ColumnTypeLabelProps

* Fixed ColumnTypeLabel_spec
2021-09-22 11:37:35 -07:00
Beto Dealmeida
4af5ae08f9
fix: encode rison characters when searching (#16768) 2021-09-22 10:06:24 -07:00
Michael S. Molina
99d15b25b0
chore: Moves the images folder to the assets folder (#14429)
* chore: Moves the images folder to the assets folder

* Rebases
2021-09-22 10:28:51 -03:00
Kamil Gabryjelski
486e0d412c
chore: Upgrade Webpack to v5 (#16701)
* Upgrade Webpack to v5

* Remove mapbox hack

* Replace url-loaders and file-loaders with asset modules

* Remove 1 rule

* Change --colors to --color

* Remove invalid option (--no-progress)

* Remove url-loader, bump plugin

* Fix AnnotationLayer formula check

* Remove redundant tests

* Bump cypress packages

* Remove old comment

* Fix tests

* Remove checks for number of scripts in markdown test

* Cosmetic changes

* Add tests

* Fix test

* Fix test

* Fixes test warnings

* disable flaky test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-22 14:24:54 +03:00
Michael S. Molina
9b17e86b44
chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00
Michael S. Molina
b6d78bf4f2
refactor: Changes the list views to use the new Select component (#16393)
* chore: Change the list views to use the new Select component

* Fix Cypress tests

* Enables search for all controls

* Adjusts controls width

* Removes 'Me' and keeps the logged user on top

* Fixes tests

* Uses the borderless version for the filters

* Fixes the tests

* Reverts the Select theme to the default

* Rebases and fixes js error

* Fixes failing test

* Removes unused withTheme
2021-09-22 07:44:18 -03:00
Michael S. Molina
596e1cdf9b
refactor: Changes the DatabaseSelector and TableSelector to use the new Select component (#16483) 2021-09-22 07:43:46 -03:00
Ville Brofeldt
1d5100daa2
fix(dataset): retain is_dttm if set on metadata sync (#16776) 2021-09-22 10:13:49 +03:00
Elizabeth Thompson
d375538671
only fetch db function when db exists in sql lab (#16754) 2021-09-21 09:40:02 -07:00
Elizabeth Thompson
f032cc254c
fix shared query (#16753) 2021-09-21 09:38:23 -07:00
simcha90
985aa06439
chore: Upgrade immer package version (#16741)
* fix:fix get permission function

* chore: update immer

* chore: update immer
2021-09-20 09:36:56 +03:00
Yongjie Zhao
67b13308ca
chore: bump superset-ui 0.18.5 (#16725) 2021-09-18 08:06:08 +08:00
Ville Brofeldt
836b5e2c86
feat: add support for generic series limit (#16660)
* feat: add support for generic series limit

* refine series_columns logic

* update docs

* bump superset-ui

* add note to UPDATING.md

* remove default value for timeseries_limit
2021-09-16 12:09:08 +03:00
Michael S. Molina
86290cc0e5
chore: Improves the Select component to avoid additional queries when all values have been loaded (#16712)
* chore: Improves the Select component to avoid additional queries when all values have been loaded

* Handles the logic in handlePaginateFetch and removes the use effect
2021-09-15 15:39:58 -03:00
Michael S. Molina
adc3d24c21
fix: Ignore case and special keys when searching (#16706) 2021-09-15 07:33:43 -03:00
Stephen Liu
b0ac5d1625
perf(dashboard): fix filter-box performance bug (#16702) 2021-09-15 08:40:46 +03:00
David Aaron Suddjian
540277ebb1
chore: Add option to set a custom color scheme as default (#16540)
* upgrade superset-ui for new flag

* configurable default categorical scheme

* dry refactor

* doc example

* Update superset-frontend/src/setup/setupColors.ts

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* re-adding # type: ignore (suggestion from ville)

* ugh... missed a space.

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2021-09-14 11:09:03 -07:00
Ville Brofeldt
1d890f8913
fix(explore): make clicked dnd filters unique (#16700) 2021-09-14 18:01:21 +03:00
Geido
fecd4124fa
fix: Select refactoring known issues (#16666)
* Clean up and reorganize effects

* Enhance optionFilterProps

* Render custom label

* Remove prop filtering

* Create options

* Create option from value in single mode

* Change to customLabel

* Show search by default

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Apply minor changes

* Fixes a bug that was failing CI

* Adds more tests to the component

* Apply customLabel in ColorSchemeControl

* Remove customLabel from rendered Option

* Hide No data when allowNewOptions

* Remove unnecessary prop from tests

* Adjust loading height

* Show no data with fetchOnlyOnSearch

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-14 17:39:27 +03:00
Ville Brofeldt
c99cacbdd2
fix(explore): only refresh data panel on relevant changes (#16699)
* fix(explore): only refresh data panel on relevant changes

* add comment and supress warning
2021-09-14 15:58:05 +03:00
AAfghahi
376c685838
feat: adding logging to validation (#16527)
* adding logging to validation

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-13 16:09:40 -07:00
cccs-joel
c6ac10716a
feat: show build number value in the About if present in the config (#14955) 2021-09-13 10:59:08 -07:00
Grace Guo
b0b996582c
fix: reset perf logger timer for soft navigation for SPA pages (#16668)
* fix: reset perf logger timer for soft navigation for SPA pages

* fix comments

* fix extra comments

Co-authored-by: grace_guo <grace_guo@grace-guos-MacBook-Pro.local>
2021-09-13 10:16:07 -07:00
simcha90
668ae23f28
feat: Tabs in column (#16593)
* fix:fix get permission function

* feat: add tabs inside column

* lint: fix lint

* test: fix test

* test: fix tests

* test: fix tests

* fix: pass onChangeTab function through layout
2021-09-13 09:02:29 +03:00
Ajay M
4b70d46355
feat(dashboard): Native filters - add type to native filter configuration (#16549)
* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* PR comments

* PR comments

* Fix failing tests
2021-09-09 09:46:44 -07:00
Michael S. Molina
e9e6c5de8a
chore: Writes the tests for the new Select component (#16638)
* chore: Writes the tests for the new Select component

* Uses array destructuring
2021-09-09 08:38:33 -03:00
Kamil Gabryjelski
788c0c3dae
fix(dashboard): label colors included in explore url (#16621) 2021-09-08 15:38:02 +02:00
Ville Brofeldt
9dfa33fedf
fix(dnd): make clicked dnd metrics unique (#16632) 2021-09-08 13:21:21 +03:00
Elizabeth Thompson
519baa6f00
fix: params in sql lab are jumpy in the ace editor (#16536)
* fix jumpy params

* remove cypress tests
2021-09-07 09:38:45 -07:00
Michael S. Molina
37c2020035
chore: Merges latest Select changes (#16587) 2021-09-07 10:41:55 -03:00
Kamil Gabryjelski
effcf3b50f
perf(dashboard): decrease number of rerenders of FiltersBadge (#16545)
* perf(dashboard): decrease rerenders in FiltersBadge

* implement caching of dashboard filter indicators

* Implement caching for native filter indicators
2021-09-07 12:03:43 +02:00
Kamil Gabryjelski
7faa5c6aff
perf(dashboard): reduce rerenders of DragDroppable (#16525)
* perf(dashboard): reduce rerenders of DragDroppable

* lint fix
2021-09-07 11:19:07 +02:00
Duy Nguyen Hoang
3fe2e6ec73
Remove export CSV in old filter box (#16592) 2021-09-06 14:40:24 +03:00
Ville Brofeldt
7cbced8833
chore(deps): bump superset-ui to 0.18.2 (#16601) 2021-09-06 12:20:29 +03:00
simcha90
df5c0fbce9
feat: Experimental cross-filter plugins (#16594)
* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF
2021-09-06 08:25:14 +03:00
Beto Dealmeida
9bb890ebed
fix: impersonate user label/tooltip (#16573) 2021-09-03 09:42:11 -07:00
Elizabeth Thompson
a0db5367d2
bump emotion to help with cache clobbering (#16559) 2021-09-02 13:48:21 -07:00
Michael S. Molina
02798a3517
fix: Adds a loading message when needed in the Select component (#16531) 2021-09-02 13:17:47 -03:00
Yongjie Zhao
2e11b05d73
chore: bump superset-ui to 0.18.1 (#16563) 2021-09-02 09:03:43 +03:00
Ville Brofeldt
75a1b19174
chore: bump superset-ui to 0.18.0 (#16544) 2021-09-02 13:16:03 +08:00
Yongjie Zhao
80c39daa85
fix: can't drop column when name overlap (#16482) 2021-09-01 13:52:10 +08:00
Geido
f001c44727
Make Modal draggable and resizable (#16447) 2021-08-31 12:46:44 +03:00
Phillip Kelley-Dotson
a616b8785e
make chart rerender on timeseries change (#16411) 2021-08-30 16:43:14 -07:00
Phillip Kelley-Dotson
960d1e4d5d
fix: stop endless loading when dataset no longer exist (#16511)
* initial fix

* add const

* add translate
2021-08-30 16:42:02 -07:00
Grace Guo
2199f65373
fix: sql lab refetch button (#16469)
* fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)

* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments

(cherry picked from commit 408d58f937)

* handle exception caused by invalid query id
2021-08-30 15:47:00 -07:00
Ville Brofeldt
147637a02d
fix(native-filters): add handle undefined control value gracefully (#16468) 2021-08-27 14:03:05 +03:00
Erik Ritter
8adc31d14c
Revert "chore: Changes the DatabaseSelector to use the new Select component (#16334)" (#16478)
This reverts commit c768941f2f.
2021-08-26 22:28:04 -03:00
Jesse Yang
a413f796a6
fix(explore): JS error for creating new metrics from columns (#16477) 2021-08-26 17:04:45 -07:00
AAfghahi
ee2eccdb67
fix: queryEditor bug (#16452)
* queryEditor bug

* update tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-26 15:20:02 -07:00
Kamil Gabryjelski
f422f1ea49
perf(dashboard): decouple redux props from dashboard components (#16421)
* perf(dashboard): decouple redux props from dashboard components

* Lint fix

* Dont make copy of filters object

* Remove unnecessary exports
2021-08-26 21:54:11 +02:00
Kamil Gabryjelski
8ad495a572
perf(dashboard): reduce number of rerenders of Charts (#16444)
* perf(dashboard): reduce number of rerenders of Charts

* Remove static property

* Cleanup
2021-08-26 21:53:44 +02:00
Yongjie Zhao
577ede4b12
fix: prevent page crash when chart can't render (#16464) 2021-08-26 22:26:01 +08:00
Ville Brofeldt
1c71eda70f
fix(native-filters): handle null values in value filter (#16460)
* fix(native-filters): handle null values in value filter

* lint
2021-08-26 15:26:53 +03:00
Jesse Yang
ec087507e5
refactor(explore): improve typing for Dnd controls (#16362) 2021-08-26 01:23:14 -07:00
Ville Brofeldt
18be181946
fix(explore): update overwrite button on perm change (#16437)
* fix(explore): update overwrite on perm change

* remove redundant user_id prop

* fix types

* fix user type

* fix tests

* fix lint
2021-08-26 06:24:33 +03:00
Geido
db11c3e6c8
feat: Draggable and Resizable Modal (#16394)
* Implement resizable prop

* Implement resizableConfig

* Implement fluid Syntax Highlighter

* Implement draggable

* Destroy on close

* Implement draggableConfig

* Enhance with footer calculation

* Add new line

* Make whole header draggable trigger
2021-08-25 16:11:16 +03:00
Maxhui
6a2cec51c5
fix(dashboard): undo and redo buttons weird alignment (#16417)
* fix(dashboard-ui): undo and redo buttons weird alignment

* fix(Explore control pane): keyboard nav & focus

* lint: lint frontend

* fix: fix redo and undo button style

* lint: lint line

* lint: lint line

Co-authored-by: xuzhebin <maxhui2020@gmail.com>
2021-08-25 08:52:59 -03:00
Grace Guo
08b8aa277f
fix: setupPlugin in chart list page (#16413)
* fix: setupPlugin in chart list page

* fix the order of setupPlugins call

* Fix jest test on loading geojson

* add jest changes

* fix unit tests

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-08-24 23:10:46 -07:00
Grace Guo
78d8089b18
fix: Disable Slack notification method if no api token (#16367)
* feat: allow company choose alert/report notification methods

* fix: disable Slack as notification method if no api token

* fix unit test

* improve typing
2021-08-24 17:28:50 -07:00
AAfghahi
631ad02a76
fix: copy to Clipboard order (#16299)
* copy to Clipboard order

* centralized copyToClipboard

* fixed table order

* fixed tests

* added colnames to all viz types

* added colnames to all viz types

* added colnames to all viz types
2021-08-24 14:47:09 -07:00
Ville Brofeldt
5eded9fe1b
chore(viz): bump superset-ui to 0.17.87 (#16420) 2021-08-24 11:10:23 -07:00
Evan Rusackas
81241b6024
Revert "fix(explore): let admin overwrite slice (#16290)" (#16408)
This reverts commit d13b081cfe.
2021-08-24 09:38:41 -06:00
Michael S. Molina
6a5568764e
chore: Removes the TODOs and uses the default page size (#16422) 2021-08-24 11:44:27 -03:00
Michael S. Molina
575e7af859
fix: Show cross filter option only when cross filter is enabled (#16391) 2021-08-24 09:13:39 -03:00