pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-19 20:19:37 -04:00
Code Issues Packages Projects Releases Wiki Activity
11,226 Commits 251 Branches 499 Tags 1.6 GiB
375c03e084
Commit Graph

2176 Commits

Author SHA1 Message Date
Kamil Gabryjelski
c77d24cda3
fix: undefined error when adding extra sequential color scheme (#18152) 2022-01-24 19:20:49 +01:00
Kamil Gabryjelski
e632193eb0
feat(explore): more toast feedback on user actions in Explore (#18108) 
* feat(explore): add toasts feedback when user copies chart url

* Show toast message when updating chart properties

* Change toast type to success when saving chart

* Use success toast from props

* Fix tests

* Use withToasts instead of dispatch

* Use PropertiesModalProps instead of any
 2022-01-24 11:42:24 +01:00
Kamil Gabryjelski
d9eef8ec2f
feat(dashboard): add toast feedback to dashboard actions (#18114) 2022-01-24 11:42:12 +01:00
Kamil Gabryjelski
9fa2812343
feat(annotation): add toast feedback to annotation templates (#18116) 2022-01-24 11:41:39 +01:00
Stephen Liu
b083b3421f
fix(explore): fix chart embed code modal glitch (#17843) 2022-01-21 09:11:33 -07:00
Adam Dobrawy
a5e805ef2a
refactor: migrate RowCountLabel to TypeScript & added story (#18105) 
* enable superbook for explore component

* migrate RowCountLabel to TypeScript

* add storybook for RowCountLabel
 2022-01-20 15:35:09 +01:00
Adam Dobrawy
c3a17a7228
Migrate Checkbox story to tsx - see #18100 (#18101) 
Looks good!
 2022-01-20 15:33:45 +01:00
Josue Lugaro
035638c958
refactor: sqleditorleftbar to functional (#17807) 
* Working on converting sqleditorleftbar to functional component

* Creating draft PR to address bug

* Still working on solving re rendering bug

* infinite rerender fix

* Creating draft PR to address bug

* Cleaning up in preparation for push

* Made changes suggested by Elizabeth

* Fixed issues as per Lindsey's comment

Co-authored-by: Arash <arash.afghahi@gmail.com>
 2022-01-19 15:06:28 -06:00
Stephen Liu
22896f2803
feat: add chart description in info tooltip (#17207) 
* feat: add chart list description

* fix: text overflow

* fix: text-overflow with line-height
 2022-01-19 21:24:17 +08:00
AAfghahi
88db2cc0ab
refactor(sql_lab): SQL Lab Persistent Saved State (#17771) 
* a lot of console logs

* testing

* test

* added saved_query to remoteId

* created useEffect so that title properly changes in modal

* Update superset-frontend/src/SqlLab/actions/sqlLab.js

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
 2022-01-18 13:10:31 -05:00
Stephen Liu
3b64563f3f
fix(dashboard): scope of nativefilter not update (#18048) 2022-01-18 16:51:51 +08:00
Grace Guo
26dc600aff
fix: handle null values in time-series table (#18039) 2022-01-13 21:47:07 -08:00
Erik Ritter
343d3f8f7a
fix: Disable filtering on wide result sets (#18021) 2022-01-13 10:11:18 -08:00
Beto Dealmeida
51090c3f1b
feat: shorter timeout on test_connection (#18001) 
* feat: shorter timeout on test_connection

* pip-compile-multi --no-upgrade

* Fix for SQLite

* Return 408

* Add test
 2022-01-12 13:01:34 -08:00
Erik Ritter
27000da2f8
fix: SQL Lab sorting of non-numbers (#18006) 2022-01-12 11:09:59 -08:00
AAfghahi
536ca1f62c
chore(DatasourceEditor): Create Datasource Legacy Editor Feature Flag (#18003) 
* a lot of console logs

* adding new feature flag for datasource editor
 2022-01-12 14:02:53 -05:00
Yongjie Zhao
46715b295c
refactor: remove unused ts-jest (#17996) 2022-01-11 23:43:45 +08:00
Phillip Kelley-Dotson
3d829fc3c8
fix: dashboard reload crash (#17992) 
* fix dashboard reload

* add more strict case
 2022-01-10 18:34:28 -08:00
Lyndsi Kay Williams
f7add546ad
Fixed error handling in Report modal (#17988) 2022-01-10 17:01:08 -06:00
Phillip Kelley-Dotson
c139312bb3
fix: dashboard full screen layout (#17985) 
* fix: full screen mode for dashboard

* remove console
 2022-01-10 15:58:39 -07:00
Lyndsi Kay Williams
df69920a2e
Moved dataset editor lock to top of component (#17930) 2022-01-10 16:55:00 -06:00
Lyndsi Kay Williams
f6b9393999
Tooltip no longer dancing (#17931) 2022-01-10 16:54:38 -06:00
serenajiang
05d9cde203
feat: update time comparison choices (again) (#17968) 2022-01-10 10:08:15 -08:00
Stephen Liu
bd9e1235a9
fix(dashboard): scope status of filter not update in dashboard metadata (#17945) 
* fix(dashboard): scope status of filter not update in dashboard metadata

* fix save
 2022-01-10 10:19:25 -07:00
Kamil Gabryjelski
35f4c33245
fix(native-filters): apply default value correctly when it's set (#17982) 2022-01-10 17:32:31 +01:00
Evan Rusackas
c0a769581f
chore: bump typescript to 4.5.4, and adjust storybook story. (#17971) 
* chore: bump typescript to 4.5.4, and adjust storybook story to pass linting

* ugh... missed a space. Thanks, linter :)

* nixing erroneous package lock file
 2022-01-09 21:01:59 -07:00
Phillip Kelley-Dotson
765c72a858
fix: update slug name (#17961) 
* fix: fix update slug name

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
 2022-01-07 11:37:12 -08:00
Michael S. Molina
647bbf1ea1
chore: Moves spec files to the src folder - iteration 10 (#17902) 
* chore: Moves spec files to the src folder - iteration 10

* Fixes test

* Fixes lint problem

* Uses styledMount in test
 2022-01-07 15:24:15 -03:00
Michael S. Molina
bb7e979142
chore: Moves spec files to the src folder - iteration 9 (#17901) 2022-01-07 15:23:57 -03:00
Stephen Liu
2ae29c9281
fix(Select): options will be overwritten due to seState (#17951) 2022-01-07 08:09:25 -07:00
Michael S. Molina
e6ef7da758
chore: Moves spec files to the src folder - iteration 8 (#17899) 
* chore: Moves spec files to the src folder - iteration 8

* Fixes tests
 2022-01-07 09:25:45 -03:00
Michael S. Molina
aa91662ec8
chore: Moves the Menu to views/components folder (#17897) 
* chore: Moves the Menu to views/components folder

* Fixes imports
 2022-01-07 09:25:31 -03:00
Michael S. Molina
53d8d383cc
chore: Moves the hooks folder to the src folder (#17896) 2022-01-07 09:25:06 -03:00
Hugh A. Miles II
9e69940171
feat: Update query states to use spinner vs. progress bar (#17804) 
* lit

* remove reference for progress bar

* update to loading

* update switch out spinner for loading when progress hits 100

* update test
 2022-01-05 10:43:42 -08:00
Yongjie Zhao
ceecc7047b
chore: remove unused eslintrc (#17860) 
* chore: remove unused eslintrc

* remove unused lint

* add comments

* change comments
 2022-01-05 19:31:12 +08:00
David Aaron Suddjian
de3d3973a2
fix: process color scheme configs correctly (#17786) 2022-01-04 15:27:10 -08:00
Stephen Liu
07998fea68
fix(explore): simple tab content input problem (#17872) 2022-01-03 12:41:19 +08:00
Beto Dealmeida
9baeafec93
feat: configure force_screenshot (#17855) 
* Update existing tests

* Add backend test

* feat: add force option to report screenshots

* Add tests

* Rebase fixes

* Do not force screenshot on dashboard alerts

* feat: bypass cache on screenshots for alerts

* Update existing tests

* Add tests

* feat: configure force_screenshot
 2021-12-22 13:46:00 -08:00
Beto Dealmeida
2cd8054358
feat: add force option to report screenshots (#17853) 
* Update existing tests

* Add backend test

* feat: add force option to report screenshots

* Add tests

* Rebase fixes

* Do not force screenshot on dashboard alerts
 2021-12-22 12:16:04 -08:00
Lyndsi Kay Williams
d2ed1b72dc
chore: Help user to find the input fields in the dataset editor (#17824) 
* Updated fields in Metrics and Calculated Columns tabs inside dataset editor, deleted label in expanded Metrics tab

* Fix tests

* Vertically aligned rows in columns tab
 2021-12-22 12:21:37 -06:00
Beto Dealmeida
b7707e8ff7
feat: bypass cache on screenshots for alerts (#17695) 
* feat: bypass cache on screenshots for alerts

* Update existing tests

* Add backend test

* Add frontend test
 2021-12-22 08:26:38 -08:00
Stephen Liu
ec48dd5c40
fix(dashboard): update native filter info in metadata is not updated (#17842) 2021-12-22 08:47:27 +02:00
Phillip Kelley-Dotson
cfd851aa13
fix: replace datamask with key from new key value api (#17680) 
* afirst stage to ccheck to get initial datamask

* clean up code and update typescript

* remove consoles

* fix ts and update copy dashboard url

* use key when one doesn't exists

* lint clean up

* fix errors

* add suggested changes

* remove line

* add tests and add changes for copydashboard

* fix lint

* fix lint

* fix lint

* Update superset-frontend/src/dashboard/components/Header/index.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* add timeout

* fix test

* fix test, add qs to cypress and add suggestions

* add suggestions

* fix lint

* more suggested changes for backwards comapat

* fix lint

* cleanup naming and add qs parse to tests

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* more changes and fix lint

* remove nativefiler param

* fix path

* remove con

* simplify logic

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
 2021-12-21 09:08:48 -08:00
Stephen Liu
d5768ab649
fix(explore): make SORT-Descending visible if Sort-by has value (#17726) 2021-12-21 15:27:21 +08:00
Erik Ritter
5b0aa27f2b
feat: Persist SQL Lab autocomplete setting across tabs and visits (#17708) 2021-12-20 15:53:48 -08:00
Erik Ritter
6edc183c5f
chore: Refactor localstorage into typesafe version (#17832) 2021-12-20 13:58:59 -08:00
Holger Bruch
61a6aa0f97
Map schemes json to SequentialScheme (#17813) 2021-12-20 09:38:24 +02:00
Srini Kadamati
53e2fa6f57
chore: updated screenshots in README.md and added recent events (#17650) 
* chore: updated screenshots in readme.md and added recent events

* chore: updated pinot superset connection instructions

* fixed outdated slack link

* addressed all outstanding feedback!

* updated package lock

* reverted package.json to master

* Update README.md

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
 2021-12-17 11:43:46 -05:00
Grace Guo
c5af7a48df
fix: [alert] allow decimal for alert threshold value (#17751) 
* fix: [alert] add tooltip message for alert threshold value

* support decimal value for alert condition threshold

* add integration test
 2021-12-16 22:51:23 -08:00
Ville Brofeldt
961766e833
fix(filter-sets): 404 on dashboard load (#17777) 2021-12-16 11:27:46 +02:00
Geido
274fb37a91
fix: Remove positions from json_metadata (#17766) 
* Remove positions from json_metadata

* Update superset-frontend/src/dashboard/components/PropertiesModal/index.tsx

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

* Indent

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
 2021-12-15 11:32:31 -07:00
Kamil Gabryjelski
124af4c566
chore(explore): Migrate BigNumber to v1 api [ID-28][ID-55] (#17587) 
* chore(explore): Migrate BigNumber to v1 api

* Move to echarts

* Use Echarts trendline

* Fix imports

* Fix parsing dates as strings

* Add from_dttm and to_dttm to v1 chart response

* Fix post processing

* Fix timeRangeFixed

* Fix tests

* Remove from and to dttm from cache

* Cleanup date formatting

* Fix storybook

* Fix missing types

* Fix timestamp with timezone

* Add types to demo's tsconfig

* bug fix

* fix import

* Fix cypress tests

* add sort

* add resample to handle missing values properly

* Sync ChartDataResponseResult schema with ts interface

* Lint fix

* Add migration

* Fix migration

* Remove pass

* Re-raise the exception in migration

* Typo fix

* Update revision

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
 2021-12-15 10:15:14 +01:00
Stephen Liu
142b5bc506
fix: local warning in the frontend development (#17727) 2021-12-15 09:52:42 +02:00
Beto Dealmeida
2a6e5e5e5c
fix: import DB errors (#17748) 2021-12-14 18:32:57 -08:00
Beto Dealmeida
63d9693f21
feat: add main datetime column to dataset editor (#17739) 
* feat: add main dttm col to dataset editor

* Add tests
 2021-12-14 14:47:08 -08:00
Geido
4b969710e4
Rename CertifiedIcon to CertifiedBadge (#17715) 2021-12-10 11:45:53 -07:00
Kamil Gabryjelski
b5b6ceb1b3
fix(explore): don't apply time range filter to Samples table (#17711) 2021-12-10 11:40:11 -07:00
Geido
8de93871d7
Fix flacky header (#17690) 2021-12-10 18:25:40 +02:00
Geido
dad8c20af7
fix(Dashboard): Copy dashboard with duplicating charts 500 error (#17707) 
* Fix copy dashboard with charts

* Fix Cypress test
 2021-12-09 16:25:01 -07:00
Stephen Liu
bdc4e7a322
fix(explore): deck.gl Multiple chart broken (#17703) 2021-12-09 20:03:02 +02:00
Geido
12bd1fcde5
fix: Save properties after applying changes in Dashboard (#17570) 
* Refactor PropertiesModal

* Update json_metadata fully

* Clean up

* Verify values

* Catch changed to metadata

* Always updated dashboard info on update

* Avoid unnecessary fetches

* Formt

* Fix copy dashboards

* Fixes onUpdate onCopy handlers

* Pylint

* Update tests

* Clean up

* Handle data on show

* Change Save to Apply

* Update Cypress save test

* Update Cypress edit prop test

* Update PropertiesModal test

* Fix duplicate request with cross filters

* Improve code style

* Fix typo

* Lint
 2021-12-09 10:03:07 -07:00
Corbin Robb
f476ba23a2
fix(select): select component sort functionality on certain options (#17638) 
* fix: Select component sort function sorting by label instead of value on numbers

* fix: change select component default sorting to sort by the initial index rather than a property like value or label

* fix: select sorting add sortOptions to select components using sortByProperty

* fix: change select component back, add order to options coming in from SelectControl

* fix: select component options intitial sort bug

* fix: add test cases for select fix

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
 2021-12-09 11:40:25 -05:00
Geido
aad2abe7f0
Fix undefined error (#17692) 2021-12-08 13:30:41 -07:00
Geido
46cdc77ae6
fix: Redirect on 401 (#17597) 
* Redirect on 401

* Bump FAB

* Format

* Update Cypress save test

* Revert Cypress change

* Bump FAB 3.4.1rc2

* Update test

* Update return statement

* Update api test

* Update datasets api test

* Update datasets api 401s to 403s

* Add typeguard

* Use Promise.resolve

* Update callApiAndParseWithhTimeout test

* Disable parseResponse test

* Try catch

* Handle npm 8 issues
 2021-12-08 13:14:30 -07:00
Ville Brofeldt
c4b04952d0
feat: customize recent activity access (#17589) 
* feat: customize recent activity access

* address comments

* fix and add tests

* add alert assertion and UPDATING.md entry

* replace .get_id() with .id

* fix updating comment

* update config name
 2021-12-08 11:30:23 +02:00
Lyndsi Kay Williams
05752e3fe8
fix(sqllab): Floating numbers not sorting correctly in result column (#17573) 
* Floating nums now sorting correctly with parseFloatingNums function

* Floating numbers AND strings now sorting correctly, +locale comparison

* Added NULL handling back to sort function

* Moved parseFloatingNums outside of sortResults

* Removed localeCompare and added testing

* Add equality check back to sort function

* Added floatValue nit
 2021-12-03 16:31:46 -08:00
Kamil Gabryjelski
07e8837093
feat(explore): export csv data pivoted for Pivot Table [ID-9] (#17512) 
* feat(explore): export csv data pivoted for Pivot Table

* Implement dropdown with download csv options

* Change label to "Original"

* Add tests

* Add form data to query context

* Add form data to query context generator

* Explicitly make form_data optional
 2021-12-03 12:42:28 +01:00
Jesse Yang
73e7928c4b
chore(superset-ui): clean up legacy-plugin-chart-time-table (#17626) 2021-12-02 17:14:10 -08:00
Stephen Liu
b5d13d72f2
fix(dataset): modal sql editor error (#17612) 
* fix(dataset): model sql editor

* add tests
 2021-12-02 13:02:19 -07:00
Hugh A. Miles II
d9e9c3a3de
refactor: Add AutoSizer to react-virtualized Grid (#17606) 
* remove styles from renderCell

* remove styling on grid
 2021-12-02 12:47:47 -05:00
Stephen Liu
a3cce5705d
feat(explore): support show annotation label [ID-8] (#17307) 
* feat(explore): support always show annotation label

* fix: lint

* fix: lint

* Hopefully appeasing the linter

* fix: lint

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* change to allow none

* lint

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
 2021-12-02 00:26:32 -07:00
Matt Houston
54b56fe12f
feat: Add single select and inverse selection to numeric range (#16722) (#17372) 
* feat: add single select and inverse selection to numeric range (#16722)

* Ignore invalid eslint errors regarding conditionally called hooks.

* Add license header to new file.

* Flipped the numerical range values for the minimum slider so that the highlighted range value accurately reflects the applied filter.

* Resolved linting errors

* Remove unnecessary important flag from css
 2021-12-01 15:28:11 -08:00
Geido
8963cca265
Revert "fix(Dashboard): Only apply changes when editing properties (#17392)" (#17618) 
This reverts commit 0712be4c12.
 2021-12-01 11:35:55 -07:00
Daman Arora
c6ba9bf9db
chore: migrate EstimateQueryCostButton component from jsx to tsx (#17603) 
* migrate EstimateQueryCostButton component from jsx to tsx

* re-format spaces using prettier

* Update superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* remove extra onClick and make disabled prop optional

* restore & rename event handler onClick to onClickHandler

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
 2021-12-01 09:28:52 -08:00
Phillip Kelley-Dotson
4e76637252
initial fix (#17547) 2021-11-30 08:24:18 -08:00
Daman Arora
bfba4f1689
chore: migrate Fieldset component from jsx to tsx (#17474) 
* migrate Fieldset component from jsx to tsx

* update type check for fieldKey

* remove unused css class called fieldset
 2021-11-29 14:17:54 -08:00
Michael S. Molina
a959e6df45
fix: Visualizations don't load when using keyboard shortcuts (#17542) 2021-11-29 09:14:21 -03:00
Holger Bruch
6604a6ab28
chore(translations): Add missing i18n (#17525) 
* Add *.ts to babel.cfg

* Add missing i18n calls

* Update pot file

* Fix lint issues and review comment

* Incorparate review feedback

* Fix missing or non-extractable i18n calls

* Update pot file

* Fix syntax error in CommonParameters.tsx

* Fix introduced issues
 2021-11-27 14:50:33 +02:00
Nithin George Philips
4cf429c154
feat: add classNames for apply and clearAll buttons for superset filters (#17554) 
Co-authored-by: Nithin Philips <nithinphilips@Administrators-MacBook-Pro.local>
 2021-11-27 12:09:36 +02:00
Hugh A. Miles II
2e29f36e78
fix: RBAC for export for dashboard viewers (#17527) 
* set out export

* update test

* use default dataset

* update test

* these test work

* fix test

* update

* fix

* fix test

* make the test better
 2021-11-25 20:10:41 -08:00
Daman Arora
cf3f0e5b55
chore: migrate DragHandle component from jsx to tsx (#17326) 
* migrate DragHandle component from jsx to tsx

* Convert class based component to functional component
 2021-11-25 11:18:56 +02:00
Kamil Gabryjelski
7353a2bd75
fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) 2021-11-24 13:06:11 +01:00
Geido
83e49fc9ee
feat: Certify Charts and Dashboards (#17335) 
* Certify charts

* Format

* Certify dashboards

* Format

* Refactor card certification

* Clear details when certified by empty

* Show certification in detail page

* Add RTL tests

* Test charts api

* Enhance integration tests

* Lint

* Fix dashboards count

* Format

* Handle empty value

* Handle empty slice

* Downgrade migration

* Indent

* Use alter

* Fix revision

* Fix revision
 2021-11-24 13:42:52 +02:00
Ajay M
9576478a5d
feat(dashboard): Add divider component in native filters (#17410) 
* Tests are working, type errors are fixed

* Fix filterset

* add license header to the new file

* fix test

* PR comments

* Linting

* test fix

* small fix
 2021-11-23 16:13:56 -08:00
Corbin Robb
c216565190
Remove loading span, add empty-loading-bar css class, change empty loading rows length to 12, remove width logic on empty loading columns (#17515) 
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
 2021-11-23 15:13:53 -08:00
Evan Rusackas
6d66963489
fix: hiding HiddenControl inputs for real, to reduce bootstrap space consumption (#15182) 
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
 2021-11-23 15:08:24 -08:00
Ville Brofeldt
18c7aec985
chore: remove deprecated selects and deps (#17522) 2021-11-23 12:41:16 +02:00
Ville Brofeldt
5d1c9078ad
chore(translations): fix translation literals (#17501) 
* chore(translations): fix translation literals

* fix table name types and translations

* fix lint

* join concat'd messages
 2021-11-23 10:06:09 +02:00
Daman Arora
daff9b4673
chore: migrate FormattedNumber component from jsx to tsx (#17361) 
* migrate FormattedNumber component from jsx to tsx

* Unset default prop on format

* undo asserting and overriding the type for num

* Add a ts comment to ignore error
 2021-11-22 13:42:37 -08:00
Corbin Robb
8e1619b105
fix(sqllab): Have table name tooltip only show when name is truncated (#17386) 
* Add conditional to table name tooltip to only show when overflowing

* Remove uneccessary state and useEffect, a little clean up and slight refactoring

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
 2021-11-19 09:34:28 -08:00
Daniel Vaz Gaspar
69f9ee8f5e
fix: feature flags typing (#15254) 
* fix: feature flags typing

* fix tests

* add note in UPDATING.md

* fix frontend

* also move SCHEDULED_QUERIES to top level

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
 2021-11-19 15:56:16 +00:00
Yongjie Zhao
9070b6b19c
refactor(monorepo): stage 1 (#17427) 
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
 2021-11-17 15:31:36 +08:00
Geido
c2d8b0e72f
chore: Notify user of custom label colors and related Dashboard color scheme (#17422) 
* Add alert for custom label colors

* Fix duplicate linear scheme

* Implement dashboard alert

* Remove trailing space

* Update Cypress

* Simplify check
 2021-11-16 17:46:39 +02:00
Grace Guo
9f1bf1cbd5
fix: do not show migration toast if user not enable dashboard filter components (#17440) 2021-11-15 11:27:24 -08:00
Lyndsi Kay Williams
eb029ab068
fix(sql lab): NULL styling in grid cell (#17385) 
* Fix NULL styling in gridCell

* removed unnecessary imports

* Added null styling back to renderGridCell

* Cleaned up a little code as per Elizabeth

* Found another little cleanup spot
 2021-11-15 10:49:35 -08:00
Elizabeth Thompson
71e3fa1bf3
use full resultType with csv download on chart in dashboard (#17431) 2021-11-15 09:57:05 -08:00
Ville Brofeldt
e2a429b0c8
feat(explore): adhoc column expressions [ID-3] (#17379) 
* add support for adhoc columns to api and sqla model

* fix some types

* fix duplicates in column names

* fix more lint

* fix schema and dedup

* clean up some logic

* first pass at fixing viz.py

* Add frontend support for adhoc columns

* Add title edit

* Fix showing custom title

* Use column name as default value in sql editor

* fix: Adds a loading message when needed in the Select component (#16531)

* fix(tests): make parquet select deterministic with order by (#16570)

* bump emotion to help with cache clobbering (#16559)

* fix: Support Jinja template functions in global async queries (#16412)

* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check

* fix: impersonate user label/tooltip (#16573)

* docs: update for small typos (#16568)

* feat: Add Aurora Data API engine spec (#16535)

* feat: Add Aurora Data API engine spec

* Fix lint

* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)

* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues

* refactor sql_json view endpoint: separate concern into ad hod method (#16595)

* feat: Experimental cross-filter plugins (#16594)

* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF

* chore(deps): bump superset-ui to 0.18.2 (#16601)

* update type guard references

* fix imports

* update series_columns schema

* Add changes that got lost in rebase

* Use current columns name or expression as sql editor init value

* add integration test and do minor fixes

* Bump superset-ui

* fix linting issue

* bump superset-ui to 0.18.22

* resolve merge conflict

* lint

* fix select filter infinite loop

* bump superset-ui to 0.18.23

* Fix auto setting column popover title

* Enable adhoc columns only if UX_BETA enabled

* put back removed test

* Move popover height and width to constants

* Refactor big ternary expression

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
 2021-11-15 12:50:08 +02:00
Phillip Kelley-Dotson
e6ff25c980
fix(chart): ensure samples data is displayed (#16900) 
* initial fix

* use data keys for cols

* add e2e test

* remove code

* trim logic
 2021-11-12 14:23:46 -08:00
John Bodley
bcef8fa13b
feature: Add quarter unit to datetrunc (#17416) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-11-12 09:46:55 -08:00
Geido
0712be4c12
fix(Dashboard): Only apply changes when editing properties (#17392) 
* Apply only

* Test apply button

* Update Cypress

* Rename test
 2021-11-12 19:34:21 +02:00
Geido
7cdd58b2db
Fix missing dashboardId (#17380) 2021-11-11 19:07:00 +02:00
Mayur
8756c9089e
fix(dashboard): don't show report modal for anonymous user (#17106) 
* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>
 2021-11-11 07:50:12 -03:00
John Bodley
675ffaf8df
revert: Partial revert of 17236 (#17383) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-11-10 20:32:35 -08:00
Hugh A. Miles II
a1961cfc6f
fix: Users being able to update datasets across DBs (#17348) 
* add database id back

* add condition to verify dataset is being changed

* Update superset/datasets/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
 2021-11-10 19:45:48 -05:00
Lyndsi Kay Williams
1beda796f2
fix(sqllab): Query limit dropdown number breaks to separate lines (#17382) 
* Limit break fixed

* Used white-space: nowrap instead of width: max-content
 2021-11-10 10:58:03 -08:00
Christian Pfarr
333b1371f7
feat: Drill ODBC/JDBC Impersonation feature (#17353) 
* Added Drill ODBC Impersonation feature and necessary translations/docs

* Code Cleanup

* add jdbc impersonation_target parameter

* add unittests for DrillEngineSpec.modify_url_for_impersonation method

* reformat test_drill.py with black formatter

* run pre-commit locally

Co-authored-by: Christian Pfarr <Christian.Pfarr@deutschebahn.com>
Co-authored-by: Christian Pfarr <z0ltrix+gitlab@pm.me>
 2021-11-10 08:45:16 +02:00
Grace Guo
7d22c9ce17
feat(native_filter_migration): add transition mode (#16992) 
* feat: [Migrate filter_box to filter component] add transition mode

* rebase and fix comments

* rebase and fix commnent -- patch 2
 2021-11-09 09:55:25 -08:00
John Bodley
561d1ac9f2
feat(metrics): Provide override for disabling ad-hoc metrics (#17202) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-11-08 10:31:43 -08:00
Yongjie Zhao
33a8e87513
fix: failed timezone selector UT (#17370) 2021-11-08 23:52:22 +08:00
Yongjie Zhao
b58f94ad2e
chore: bump @typescript-eslint/eslint-plugin to 5.3.0 (#17367) 2021-11-08 23:48:51 +08:00
Michael S. Molina
ed4a628861
fix: Database selector overflow (#17369) 
* fix: Database selector overflow

* Fix TImezoneSelector test

* Removes unused imports
 2021-11-08 11:25:16 -03:00
Erik Ritter
f05a32eeb9
fix: Remove horizontal scroll navigation from SQL Lab (#17356) 2021-11-05 11:12:30 -07:00
Geido
ee7c34b5b3
Make color scheme optional (#17357) 2021-11-05 19:09:59 +02:00
Geido
d0085b1b29
Check validity of control item (#17349) 2021-11-05 12:56:03 +02:00
Hugh A. Miles II
e5fe18660c
fix: Show sqllab state when deleting databases (#17331) 
* saving

* fix ts

* update test

* update test

* log unit

* updated test
 2021-11-04 20:17:08 -04:00
Beto Dealmeida
43f4ab845a
fix: clear 'delete' confirmation (#17345) 
* fix: clear 'delete' confirmation

* Add tests
 2021-11-04 16:26:38 -07:00
John Bodley
1c12167d8d
fix: Revert default series sort-by metric and enforce non-xor with series limit (#17236) 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
 2021-11-03 13:59:38 -07:00
Geido
59a6502efe
fix: Color consistency (#17089) 
* Update label colors on the fly

* Clean up

* Improve getFormDataWithExtraFilters

* Improve code structure

* Remove labelColors from formData

* Exclude label_colors from URL

* Refactor color scheme implementation

* Clean up

* Refactor and simplify

* Fix lint

* Remove unnecessary ColorMapControl

* Lint

* Give json color scheme precedence

* Add label_colors prop in metadata

* Separate owners and dashboard meta requests

* Remove label_colors control

* bump superset-ui 0.18.19

* Fix end of file

* Update tests

* Fix lint

* Update Cypress

* Update setColorScheme method

* Use Antd modal body
 2021-11-03 19:22:38 +02:00
Michael S. Molina
85a19a9cc2
fix: Unable to select None for Alert's log retention (#17268) 2021-11-03 08:48:30 -03:00
Phillip Kelley-Dotson
9a4ab1026e
fix: remove variables from styled component (#17228) 
* remove variables

* fix hovermenu styles
 2021-11-02 16:25:48 -07:00
Erik Ritter
7c6d6f47bf
Revert "fix(native-filters): Fix update ownState (#17181)" (#17311) 
This reverts commit cf284ba3c7.
 2021-11-02 13:17:29 -07:00
Daman Arora
28b494c597
chore: migrate HiddenControl component from jsx to tsx (#17315) 
* migrate HiddenControl component from jsx to tsx

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* updating the type of value in the interface

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
 2021-11-02 11:51:16 -07:00
Geido
a2a457b7ef
fix(Dashboard): Sidepanel positioning (#17200) 
* Refactor

* Adjust top offset

* Calculate padding chart list

* Check for standalone mode

* Rename standaloneMode
 2021-11-02 19:28:16 +02:00
Geido
5491a4d13c
fix(Explore): Remove changes to the properties on cancel (#17184) 
* Remove on close

* Fix lint

* Add tests
 2021-11-02 19:27:56 +02:00
Yongjie Zhao
1f2a7a40c4
fix: datatable crash when column is empty string (#17303) 
* fix: datatable crash when column is empty string

* typo
 2021-11-01 23:58:31 +08:00
AAfghahi
5948a9fd02
fix(AlertReportModal): Text Area Change (#17176) 
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention
 2021-10-29 15:30:20 -07:00
Hugh A. Miles II
d0bad96b1a
fix: Allow users to update database in Dataset Edit Modal (#17265) 
* add condition to fix save

* remove console.log
 2021-10-29 14:19:37 -07:00
Lyndsi Kay Williams
456efc0c20
fix(reports): Owners no longer showing undefined in reports (#17223) 
* Owners no longer showing undefined

* Reverted owners change

* removed print

* Owners now defined - frontend only solution!

* Remove arbitrary space
 2021-10-29 10:17:47 -07:00
Kamil Gabryjelski
fa44325a36
fix(explore): Metrics disappearing after removing metric from dataset (#17201) 
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls
 2021-10-29 16:15:19 +02:00
Phillip Kelley-Dotson
93f59e055e
chore: remove supersetTheme with withTheme (#17069) 
* remove supersettheme

* migrate Datasourceeditor to rtl

* lint fix

* remove file

* fix import

* fix test

* fix lint

* spread tests and remove unused code

* fix lint
 2021-10-27 12:42:56 -07:00
Ajay M
65f1644208
feat(dashboard): Add description to the native filter (#17025) 
* Adding description works

* Add some tests

* Fix tests

* Styled look good

* Tests successful

* Address PR comments

* fix a test
 2021-10-27 11:45:31 -07:00
Yongjie Zhao
faf7c74e44
chore: bump superset-ui v0.18.16 (#17251) 
* chore: import ES module from chart-controls

* chore: bump superset-ui v0.18.16
 2021-10-27 23:35:48 +08:00
Ville Brofeldt
4316fe6ae6
fix(annotataion): handle required fields properly (#17234) 2021-10-27 08:42:28 +03:00
Ajay M
743f4b6512
Fix resetting does not clear form (#17217) 2021-10-26 19:13:47 -07:00
Michael S. Molina
dd71035e58
chore: Removes the ChartIcon component (#17216) 2021-10-26 09:02:31 -03:00
Yongjie Zhao
dbf5225e1f
chore: bump to superset-ui 0.18.15 (#17232) 
* bump 0.18.15

* prettier and update lock file
 2021-10-26 19:25:34 +08:00
Geido
5f8f67e679
Fix tools position (#17221) 2021-10-26 13:00:33 +03:00
Ben Elgren
3641093a44
allow owners to edit chart title (#17047) 2021-10-26 12:58:07 +03:00
Geido
48fd3c185c
chore: Add docs to the Select component props (#17171) 
* Add docs

* Add overall description

* Remove trailing space
 2021-10-26 12:50:23 +03:00
simcha90
cf284ba3c7
fix(native-filters): Fix update ownState (#17181) 
* fix:fix get permission function

* fix: fix own state update

* refactor: fix CR notes
 2021-10-26 11:39:16 +03:00
Elizabeth Thompson
08aab3b399
use full results as csv type (#17194) 2021-10-25 09:36:10 -07:00
Michael S. Molina
4c96ae76e3
chore: Breaks the dataViewCommon folder into TableCollection and Pagination (#17132) 2021-10-25 08:47:24 -03:00
Michael S. Molina
55be249870
fix: Order of Select items when unselecting (#17169) 
* fix: Order of Select items when unselecting

* Adds a property comparator that supports strings and numbers

* Uses a named export for propertyComparator
 2021-10-25 08:47:01 -03:00
Shiva Raisinghani
ef3afbde82
refactor: Repeated boilerplate code between upload to database forms (#16756) 
* abstract boilerplate code into class and rename csv to file

* add db migration

* fix some stuff

* more renaming of csv to file

* rename in translations

* update down revision

* update down revision

* bump chart version

* switch to alter column name approach in db migration

* fix db migration for MySQL

* db migration conflict
 2021-10-25 13:53:06 +03:00
Hugh A. Miles II
b5246b29df
feat: Hide nav create with RBAC (#17157) 
* recommit

* Update MenuRight.tsx
 2021-10-23 03:47:56 -04:00
David Aaron Suddjian
a63a01f158
small changes to dashboard->explore code (#17145) 2021-10-22 10:53:01 -07:00
Youkyoung Cha
35cbcc4643
fix: auto refresh interval won't be updated (#17112) 
* fix: auto refresh interval won't be updated

* leave only cirtical changes
 2021-10-22 12:23:46 +03:00
Phillip Kelley-Dotson
824e62bd1f
fix: dropdown placement for cascading filters popover (#17046) 
* inital fix

* remove content wrapper

* allow dropdown to overflow in long chart

* only pass through filtercontrol

* change to auto

* add ref and pass to child

* fix bug

* fix lint

* add type

* remove code

* add currrent param
 2021-10-21 21:25:25 -06:00
Erik Ritter
80a459f43b
feat: support disabling domain sharding with a query param (#17177) 2021-10-21 12:49:59 -07:00
Geido
91199c30d8
Handle undefined (#17183) 2021-10-21 19:34:32 +03:00
Kamil Gabryjelski
860e481a97
fix(explore): timestamp format when copy datatable to clipboard (#17166) 
* fix(explore): timestamp format when copy datatable to clipboard

* Fix test

* Fix test

* Use translation for aria label

* Memoize stringified cells

* Fix test
 2021-10-21 16:05:14 +02:00
Geido
e5a03423f9
chore(Dashboard): Disable save button in Native Filters when an error is present (#17037) 
* Disable save on error

* Remove removed erroredFilter

* Fix cdisabled check
 2021-10-21 16:43:58 +03:00
Hugh A. Miles II
cd9e99402d
feat: Add prettier to pre-commit workflow (#17134) 
* save

* fix

* fix pre-commit
 2021-10-20 20:53:52 -04:00
Geido
f580f6bcba
fix(Explore): Undefined owners (#17167) 
* Reconcile owners data

* Fix on save
 2021-10-20 09:45:58 -06:00
Michael S. Molina
e32acd22fd
chore: Moves the datasource components to the components folder (#17130) 2021-10-20 08:13:24 -03:00
AAfghahi
dacf79719e
remove title from cancel svg (#17147) 2021-10-18 17:03:55 -04:00
Grace Guo
96f4421961
fix: sql lab crash caused by invalid template (#17133) 2021-10-18 11:09:23 -07:00
Elizabeth Thompson
ae4ced8da6
fix: update values for default timezone selector (#17124) 
* update values for default timezone selector

* fix casing and comment

* Update TimezoneSelector.test.tsx
 2021-10-18 09:39:20 -07:00
Kamil Gabryjelski
2ad9101d1e
perf(native-filters): Decrease number of unnecessary rerenders in native filters (#17115) 
* perf(native-filters): decrease number of redundant rerenders

* More perf improvements

* lint fix
 2021-10-18 14:56:52 +02:00
David Aaron Suddjian
57f869cf22
fix(explore): remove unnecessary parameters from the explore url (#17123) 
* remove unnecessary parameters from the explore url

* refactor, test
 2021-10-18 15:30:15 +03:00
simcha90
37944e18d6
feat(Filter-sets): connect to api (#17055) 
* fix:fix get permission function

* feat: filtersets new

* feat: connect filter sets to api

* lint: fix lint

* doc: add comment
 2021-10-17 09:56:54 +03:00
Hugh A. Miles II
40b88f04f6
feat: DBC UI Snowflake Form (#16856) 
* update snowflake spec for dyanmic form

* feat(snowflake): Snowflake dynamic form (#16861)

* snowflake frontend

* snowflake frontend

* refactor(DB Connections): Build Snowflake Dynamic Form (#16875)

* moved all non-BasicParameters into own field

* refactored DB Connection Form made ValidatedInput

* quick fix

* fixed ValidatedInputField (#16934)

* add logic to check for required fields (#17022)

* fix

* fix linting

* remove host

* Update EncryptedField.tsx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
 2021-10-16 20:46:06 -04:00
Ajay M
9e6d5fc775
feat(dashboard): Let users re-arrange native filters (#16154) 
* feat. flag: ON

* refactor filter tabs

* WIP

* Drag and Rearrange, styling

* refactoring dnd code

* Add apache license header

* Fix bug reported during PR review

* Minor fix on remove

* turn off filters

* Fix status

* Fix a test

* Address PR comments

* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* indent

* PR comments

* PR comments

* Fix failing tests

* Styling

* Fix remove filter

* Fix the drag issue

* Save works

* fix

* Write tests

* Style changes

* New Icon

* Grab & Grabbing Cursor

* Commented out code

* Fix tests, fix CI

* Fix failing tests

* Fix test

* Style fixes

* portal nodes dependency

* More style fixes

* PR comments

* add unique ids to collapse panels

* Filter removal bug fixed

* PR comments

* Fix test warnings

* delete filter tabs

* Fix the breaking test

* Fix warnings

* Fix the weird bug on cancel

* refactor

* Fix broken scope
 2021-10-15 16:56:33 -07:00
simcha90
eebc953dd5
feat: Custom filters control (#17006) 
* fix:fix get permission function

* feat: customize filter control

* fix: fix types

* fix: fix merge

* refactor: update according CR

* refactor: fix CR notes
 2021-10-15 14:14:04 +03:00
wijnanjo
c9c669d179
fix for undefined userId (#17117) 
Co-authored-by: jo.wijnant <jo.wijnant@kontron.com>
 2021-10-15 01:08:57 -07:00
Lyndsi Kay Williams
635898a76d
fix(sqllab): Hover tooltip flashes in SQL Lab (#17068) 
* Changed SQL Lab result column header-style width to max-content

* Changed .ant-tooltip-open to block and tooltip placement to topLeft

* Moved tooltip style changes to local implementation instead of global
 2021-10-14 16:23:22 -07:00
Yongchan Hong
7a2e39449a
feat(config): Add none force-refresh option for auto refresh (#17039) 
* feat(config): Add none force-refresh option for auto refresh

* use general config

* fix lint issues

* last lint fix
 2021-10-14 21:31:10 +03:00
Kamil Gabryjelski
3ad7483dc1
fix(dashboard): race condition between hydrating dashboard and set active tabs (#17084) 
* fix(dashboard): race condition between hydrating dashboard and set active tabs

* Fix linting

* Change variable name
 2021-10-13 20:18:44 +02:00
Beto Dealmeida
40e9add641
fix: accept headers on import (#17080) 
* fix: accept headers on import

* Add unit test
 2021-10-13 10:06:00 -07:00
Hugh A. Miles II
959fd763a8
fix: Owners selection in dataset edit UX (#17063) 
* boilerplate

* update owner select component

* this is working

* update onchange

* refactorig

* you need to useMemo or things break

* update test

* prettier

* move logic into bootstrap data endpoint

* address concerns

* oops

* oops

* fix test
 2021-10-12 20:27:56 -04:00
Erik Ritter
153469dba9
fix: error alert levels again (#17027) 2021-10-11 12:28:36 -07:00
Gabriel Romero
83a783de58
style: Update text for SLL Tooltip (#16993) 
* Updated tooltip text to match Trello task.

* Added graphlib

* Update DatabaseConnectionForm.tsx

Co-authored-by: Gabriel Romero <gabrielromero@Gabriels-MacBook-Pro.local>
 2021-10-11 10:08:52 -07:00
jinghua-qa
f2d41dc416
fix(other): column name in created content on profile page (#17029) 
* fix: fix name in created content on profile page

* add more fix on mutater
 2021-10-11 23:21:05 +08:00
Geido
14b7f6cdba
fix: Exclude SUPERSET_DEFAULT from the list of available color schemes (#17018) 
* Handle SUPERSET_DEFAULT theme

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
 2021-10-11 16:16:06 +03:00
Beto Dealmeida
16a1df75fc
fix: clear modal state after adding dataset (#17044) 
* fix: clear modal state after adding dataset

* Fix test

* Small fixes
 2021-10-10 16:21:14 -07:00
Michael S. Molina
7c1c89c94b
fix: Loading indicator of table and schema selectors (#17040) 2021-10-08 16:17:43 -03:00
Phillip Kelley-Dotson
2c8e06e929
initial fix (#16998) 2021-10-08 10:56:14 -07:00
Phillip Kelley-Dotson
bdbcfbc8fc
fix: show onhover menu only in edit mode (#17034) 
* fix on markdown hover menu

* lint-fix
 2021-10-08 10:54:16 -07:00
AAfghahi
e32a12fa0b
bug fix (#17019) 2021-10-08 10:19:04 -07:00
Geido
a6173f1929
chore(Dashboard): Highlight errored filters on the left pane of the Native Filters form plus several enhancements (#16940) 
* Implement errored filters

* Clean up

* Handle errors on the fly

* Implement handleErroredFilters

* Reset errors
 2021-10-08 17:33:04 +03:00
Geido
a57ae35011
fix: Verify when null value should be undefined in Select (#17013) 
* Check for null value

* Safety chek SelectControl and SelectAsyncControl
 2021-10-08 17:32:09 +03:00
Geido
42efcdf027
chore(Dashboard): Implement dedicated message for missing dataset (#16959) 
* Implement dedicated message

* Clean up
 2021-10-08 17:01:00 +03:00
Erik Ritter
ea700384b3
fix: error alerts again (#17026) 2021-10-07 15:30:56 -07:00
Erik Ritter
03cdbac8bb
fix: error alerts js crash (#17015) 2021-10-07 13:09:54 -07:00
AAfghahi
50ad09bbdc
removing paramProperties (#17024) 2021-10-07 15:28:41 -04:00
Michael S. Molina
be211437de
fix: Filtering db names while creating dataset is not working (#17023) 2021-10-07 16:23:51 -03:00
Michael S. Molina
c471a85170
fix: Unnecessary queries when changing filter values (#16994) 2021-10-07 13:07:33 -03:00
Evan Rusackas
5f73ca85d5
feat(linting): restrict direct use of supersetTheme in favor of ThemeProvider (#17001) 
* feat: restrict direct use of supersetTheme

* allowing a couple of safe instances of supersetTheme
 2021-10-07 08:26:57 -06:00
Geido
66b0877445
Strict undefined check SelectControl (#17008) 2021-10-07 17:22:52 +03:00
Kamil Gabryjelski
45908ff104
fix(dashboard): Race condition when setting activeTabs with nested tabs (#17007) 
* fix(dashboard): Race condition when setting activeTabs with nested tabs

* Remove activeTabs prop from Tabs
 2021-10-07 14:23:26 +02:00
Geido
a782a62097
chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609) 
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
 2021-10-07 14:20:32 +03:00
jinghua-qa
6dc00b3e3f
fix: letter format of sort chart in dashboard edit (#17003) 2021-10-07 16:29:16 +08:00
Evan Rusackas
ac509611b6
chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor (#16999) 
* chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor

* putting the background back in, but using the theme.

* should be no need for this import anymore.
 2021-10-07 09:46:37 +02:00
Evan Rusackas
66fbce9dec
chore: removing use of supersetTheme in favor of ThemeProvider (#17000) 2021-10-07 10:36:57 +03:00
Lyndsi Kay Williams
90cfa7fb22
fix: FilterableTable result div width (#16912) 
* FilterableTable result div width is now inherit

* Changed style to css
 2021-10-06 13:14:35 -07:00
Hugh A. Miles II
40861b3db3
fix: check if owners are actually being updated in PUT /datasets/<id> (#16941) 
* check if owners are actually being updated

* move logic to FE

* fix

* fix
 2021-10-06 11:26:02 -07:00
Michael S. Molina
191033cb44
chore: Translates the favorite filter param (#16990) 2021-10-06 11:04:14 -03:00
Michael S. Molina
c57719128f
fix: When click on "View all" from favorite tab, get error (#16988) 2021-10-06 08:18:56 -03:00
David Aaron Suddjian
1cd0124fd5
chore: upgrade babel (#16885) 
* upgrade babel versions

* upgrade babel eslint parser

* fix test
 2021-10-05 15:02:57 -07:00
Youkyoung Cha
93ebe3d963
fix: handle mixed time-series error (#16928) 
* rebase to master

* Fix line 402

Co-authored-by: yougyoung <yougyoung@pubg.com>
 2021-10-05 16:00:22 +03:00