Commit Graph

2176 Commits

Author SHA1 Message Date
Geido
cf8b57e80d
fix(Explore): Fix cache timeout field not being saved and unit tests (#18738)
* fix cache timeout

* Add unit tests
2022-02-16 16:55:52 +02:00
Corbin Robb
c8df84985c
fix(CRUD/listviews): Errors with rison and search strings using special characters (#18056)
* fix errors with rison and useQueryParams

* add test for encode/decode

* add rison link and make test case more readable

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2022-02-15 16:08:36 -06:00
Adam Dobrawy
8b3e27d68b
refactor: migrate QueryAndSaveBtns to TypeScript and add stories (#18121)
* refactor: Migrate QueryAndSaveBtns to TS and stories

* fix: change typing notation in QueryAndSaveBtns
2022-02-15 17:04:48 +02:00
maltoze
57c4d0f9a4
fix: passing url params in sqllab (#15246)
* fix: passing url params in sqllab

* avoid undefined serach and add test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-15 13:18:04 +02:00
Corbin Robb
5bb406b296
fix(sqllab): fix query results sorting (#18666)
* add sorting for query results grid and add natural order sort

* modify tests for natural/original order state

* clean up setState

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2022-02-14 13:42:04 -08:00
Michael S. Molina
48a80950de
feat: Improve state key generation for dashboards and charts (#18576)
* feat: Improve state key generation for dashboards and charts
2022-02-14 17:09:06 -03:00
Lyndsi Kay Williams
801091be03
Fixed dancing tooltip in databaselist action buttons (#18686) 2022-02-14 10:53:52 -08:00
Kamil Gabryjelski
167e18e806
feat(explore): Implement chart empty states (#18678)
* feat(explore): Implement chart empty states

* Fix test

* Remove unused import

* Fix tests
2022-02-14 16:14:20 +01:00
Kamil Gabryjelski
c1205b5279
feat(explore): Implement metrics and columns popovers empty states (#18681)
* feat(explore): Implement empty states for column and metrics popovers

* Fix test

* Change copy
2022-02-14 15:26:56 +01:00
Kamil Gabryjelski
f8b3ece27b
feat(dashboard): Implement empty states for dashboard (#18712)
* feat(dashboard): Implement empty states for dashboard

* Add empty state to native filters

* Add missing license

* Remove redundant string types from EmptyState
2022-02-14 15:24:02 +01:00
Kamil Gabryjelski
42d97fb078
feat(explore): Implement data table empty states (#18679)
* feat(explore): Implement explore data table empty states

* Make empty state titles easier to translate
2022-02-14 13:06:31 +01:00
David Aaron Suddjian
225015fd5a
feat: Introduce a library for embedded iframe <-> host communication (#18652)
* improved logging

* switchboard, and window size

* lint

* tsconfig

* fix path

* fix release script

* tests, debug mode, and error handling

* moar debug mode

* package lock

* formatting

* comment

* wording

* appease the coverage gods

* Async assertions must be awaited or returned
2022-02-11 20:29:23 -08:00
Grace Guo
35684c54b3
fix: revert handle null values in time-series table (#18684) 2022-02-11 13:29:24 -08:00
Kamil Gabryjelski
a7d505db41
feat: Implement EmptyState components (#18676)
* feat: Implement EmptyState components

* Fix title in storybook

* Add licenses

* Add max widths
2022-02-11 17:43:09 +01:00
Hesoyam
d409d68e7f
refactor: migrate DeleteComponentButton to TypeScript (#18136)
* refactor: migrate DeleteComponentButton to TypeScript

* chore: fix typings

* chore: onDelete default value

* chore: removed props export

* chore: removed onDelete default value

* refactor: functional component
2022-02-11 16:12:19 +02:00
Meitong Qu
9f678e55b9
chore: migrate QueryTable component from jsx to tsx (#17944)
* chore: fix misspelling of button

* changed QuerySearch/index.jsx to index.tsx

* updated Query type at src/SqlLab/types.ts/Query and extended it into QueryTable

* updated defaultQueryLimit to be optional at ResultSetProps of superset-frontend/src/SqlLab/components/ResultSet/index.tsx

* moved statusAttributes into useMemo hook so that it will not make the dependencies of useMemo Hook change on every render and statusAttributes is only used within useMomo hook

* reset package-lock.json and package.json at frontend

* Acquired redux rootestate type for SqlLab, to be used at useSelector(state)

* updated query to be Query type and added a comment for q.status on line 178

* updated queryTable for typescript conversion

* updated actions type on QueryHistory and QuerySearch

* updated type for actions in SouthPane

* created type for SqlLab redux

Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-02-11 06:54:42 -06:00
Adam Dobrawy
7c69a1bc60
chore: improve React import reference consistency (#18608) 2022-02-10 21:03:16 -08:00
Hugh A. Miles II
78e20e21ab
feat: add prop to setDBEngine in DatabaseModal (#18653)
* saving this now

* remove for testing

* added test

* remove this

* remove set

* remove log

* Update index.test.jsx
2022-02-10 16:12:52 -08:00
Adam Dobrawy
bd0b9f25e4
refactor: migrate SliderControl to TypeScript & added story (#18120)
* refactor: migrate SliderControl to TypeScript & added story

* fix: Set default onChange in SliderControl
2022-02-10 14:21:48 +01:00
Emmanuel Bavoux
00eb6b1f57
feat: editable title xl certified badge (#18626)
* Add size to EditableTitle certified badge

* Lint EditableTitle file

Co-authored-by: Emmanuel Bavoux <emmanuel.bavoux@free2move.com>
2022-02-09 17:09:20 -08:00
Michael S. Molina
f03b4dbedb
feat: Improves key expiration handling in Explore (#18624)
* feat: Improves key expiration handling in Explore

* Sets use_slice_data equals true

* Shows toast when recovering
2022-02-09 13:20:21 -03:00
simcha90
bcad1acec2
feat: Dynamic dashboard component (#17208)
* fix:fix get permission function

* feat: dynamic loading of dashboard components

* fix: revert image

* fix: fix py

* fix: fix py

* fix: pass state to dynamic component

* lint: add typing

* lint: fix lint

* lint: fix lint

* refactor: re-run pipeline

* fix: fix CR notes

* fix: fix CR notes

* move types and interfaces to core

* reorder exports

* rename Scope and Target

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-09 17:44:40 +02:00
Kamil Gabryjelski
830f2e71d3
feat(explore): Allow using time formatter on temporal columns in data table (#18569)
* feat(explore): Allow using time formatter on temporal columns in data table

* Fix data table loading

* Return colnames and coltypes from results request

* Fix types

* Fix tests

* Fix copy button

* Fix df is none

* Fix test

* Address comments

* Move useTimeFormattedColumns out of useTableColumns

* Make reducer more readable
2022-02-09 10:29:11 +01:00
Christopher C Fleming
51f716f573
refactor(ExploreCtasResultsButton): convert to functional component (#17939)
* chore: fix misspelling of button

* Feat: Update ExploreCtasResultsButton to functional component

* Fix pull request

* Fix index.tsx

* Fix prettier issues and actions

* Streamline the onClick so it calls visualize directly

* Update MSP and MDP to arrow functions

* Test destructured props

* Fix props destructuring error

* Simplify with optional chaining on line 94 and clean up buildVizOptions

Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-02-08 13:23:45 -08:00
Michael S. Molina
fdf57cc22a
chore: Rename and reposition native filter modal fields (#18558)
* chore: Rename and reposition native filter modal fields

* Fixes collapse initial state

* Changes the button to sentence case
2022-02-08 16:36:40 -03:00
Phillip Kelley-Dotson
9c08bc0ffc
fix: change database database selector (#18609)
* fix: change database selector

* fix lint
2022-02-08 12:22:20 -05:00
EugeneTorap
cdfcbbaf30
refactor: migrate ExploreResultsButton component to FC & tsx (#18143)
* Move ExploreResultsButton to FC & tsx

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Fix test
2022-02-08 10:57:08 -05:00
Adam Dobrawy
fa8c81e1b1
chore: upgrade BoundsControl to TS (#18200)
* chore: upgrade BoundsControl to TS,FC, add storybook

* chore: improve React import reference consistency
2022-02-08 14:45:10 +02:00
Phillip Kelley-Dotson
4e2bdd49c4
chore: allow sqla docs to use supersettext (#18585)
* chore: allow sqla docs to use supersettext

* Update SqlAlchemyForm.tsx
2022-02-07 12:45:42 -08:00
EugeneTorap
85c8d0183b
refactor: remove redundant propTypes in ColumnElement (#18144)
* Remove redundant propTypes

* Refactoring

* Refactoring
2022-02-07 13:25:07 -05:00
Yongjie Zhao
aa21a963a6
feat: smart tooltip in datasourcepanel (#18080) 2022-02-07 22:48:23 +08:00
Phillip Kelley-Dotson
151d30bea4
fix: sqllab schema select error msg (#18564)
* fix: sqllab schema select error msg

* remove console logs

* fix lint
2022-02-04 10:21:18 -08:00
Kamil Gabryjelski
6cad7b1d05
chore(explore): make adhoc columns available without UX BETA ff (#17921)
* chore(explore): make adhoc columns available without UX BETA ff

* Remove redundant imports
2022-02-04 14:01:16 +01:00
Ville Brofeldt
8b0634c9ed
fix(listview): add nowrap to view mode container (#18246) 2022-02-04 07:42:10 +02:00
Grace Guo
a80efa609c
fix: new alert should have force_screenshot be true (#18182)
* fix: new alert should have force_screenshot be true

* fix comments
2022-02-02 17:00:05 -08:00
Kamil Gabryjelski
70969821de
feat(explore): Keep or reset chart config after datasource change (#18215)
* feat(explore): Keep or reset chart config after datasource change

* Update copy

* Remove useDispatch

* fix test

* Fix bugs

* Remove ts ignore

* Scroll top when datasource changes

* Fix crashing when switching viz type
2022-02-02 21:28:35 +01:00
Adam Dobrawy
341d85589c
refactor: upgrade ControlHeader to TSX & FC and add storybook (#18188)
* refactor: upgrade ControlHeader to TSX & FC and add storybook

* fix: Add story for error in ControlHeader

* apply review comments
2022-01-31 10:03:39 -08:00
Lyndsi Kay Williams
c40b337978
feat: Added success toasts for database, dataset, chart, dashboard, and query imports (#18190)
* Added imports toasts

* Removed generic import toast

* Remove addSuccessToast from props

* Added addSuccessToast back to prop type

* Made success toast strings translatable
2022-01-28 15:29:44 -06:00
Michael S. Molina
4b61c76742
fix: Explore long URL problem (#18181)
* fix: Explore long URL problem

* Fixes lint problems

* Fixes default value

* Removes duplicated test

* Fixes share menu items

* Fixes tests

* Debounces form_data updates

* Rewrites debounce function

* Moves history update outside the functional component

* Mocks lodash function in tests

* Fixes Cypress test

* Fixes Cypress test #2
2022-01-28 17:42:16 -03:00
Josue Lugaro
a06e043d7f
refactor: sqleditorleftbar to typescript (#17926)
* Creating draft PR to address bug

* Still working on solving re rendering bug

* Cleaning up in preparation for push

* Starting conversion to TypeScript

* Working on conversion

* Continued working on typescript conversion, referenced other files for different types, still a rough version of final product

* Added type assertion to actions in props, and added types to some component functions

* Progress on typescript conversion

* Fixed typing issue on collapseStyles

* Fixed styling on div, child of StyledScrollbarContainer

* Attempting to address issues with the actions passed into the TableElement

* Resolved typescript warning on actions of the TableElement component

* Made changes suggested by Arash

* Tested the component without dbId, cleaned up lingering comments

* Made more changes suggested by Arash, removed offline from the SqlEditorLeftBarProps interface

* Made change suggested by Hugh

* Changed the expanded type from any to boolean
2022-01-28 12:07:32 -08:00
Yongjie Zhao
ea2d6681dd
chore: move controlPanel into time_table (#18160) 2022-01-28 12:13:12 +08:00
Stephen Liu
7c937ca182
fix(native-filters): values is not sorted when setting sort option (#18145)
* fix(native-filters): values is not sorted when setting sort option

* fix: revert

* pass sortComparator
2022-01-27 19:15:53 -07:00
Geido
a4e93afdbf
Fix default value (#18180) 2022-01-27 17:40:32 +01:00
Yongjie Zhao
20b4ae1ef9
fix: null value and empty string in filter (#18171) 2022-01-27 22:58:06 +08:00
Stephen Liu
a2bad7551e
fix(dashboard): support input undo when editing chart title (#18137) 2022-01-27 14:53:46 +08:00
Hugh A. Miles II
e6bb0fc7ad
feat: Add toast for successful table or schema refreshes in Sqllab (#18169)
* save

* add use redux to test

* update test for db selector

* add condition for refresh only
2022-01-26 20:26:50 -05:00
Phillip Kelley-Dotson
ac564ea6b7
feat: add success message for database modal (#18183) 2022-01-26 15:52:15 -08:00
David Aaron Suddjian
4ad5ad045a
feat: embedded dashboard core (#17530)
* feat(dashboard): embedded dashboard UI configuration (#17175) (#17450)

* setup embedded provider

* update ui configuration

* fix test

* feat: Guest token (for embedded dashboard auth) (#17517)

* generate an embed token

* improve existing tests

* add some auth setup, and rename token

* fix the stuff for compatibility with external request loaders

* docs, standard jwt claims, tweaks

* black

* lint

* tests, and safer token decoding

* linting

* type annotation

* prettier

* add feature flag

* quiet pylint

* apparently typing is a problem again

* Make guest role name configurable

* fake being a non-anonymous user

* just one log entry

* customizable algo

* lint

* lint again

* 403 works now!

* get guest token from header instead of cookie

* Revert "403 works now!"

This reverts commit df2f49a6d4.

* fix tests

* Revert "Revert "403 works now!""

This reverts commit 883dff38f1.

* rename method

* correct import

* feat: entry for embedded dashboard (#17529)

* create entry for embedded dashboard in webpack

* add cookies

* lint

* token message handshake

* guestTokenHeaderName

* use setupClient instead of calling configure

* rename the webpack chunk

* simplified handshake

* embedded entrypoint: render a proper app

* make the embedded page accept anonymous connections

* format

* lint

* fix test
# Conflicts:
#	superset-frontend/src/embedded/index.tsx
#	superset/views/core.py

* lint

* Update superset-frontend/src/embedded/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* comment out origins checks

* move embedded for core to dashboard

* pylint

* isort

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* feat: Authorizing guest access to embedded dashboards (#17757)

* helper methods and dashboard access

* guest token dashboard authz

* adjust csrf exempt list

* eums don't work that way

* Remove unnecessary import

* move row level security tests to their own file

* a bit of refactoring

* add guest token security tests

* refactor tests

* clean imports

* variable names can be too long apparently

* missing argument to get_user_roles

* don't redefine builtins

* remove unused imports

* fix test import

* default to global user when getting roles

* missing import

* mock it

* test get_user_roles

* infer g.user for ease of tests

* remove redundant check

* tests for guest user security manager fns

* use algo to get rid of warning messages

* tweaking access checks

* fix guest token security tests

* missing imports

* more tests

* more testing and also some small refactoring

* move validation out of parsing

* fix dashboard access check again

* add more test

Co-authored-by: Lily Kuang <lily@preset.io>

* feat: Row Level Security rules for guest tokens (#17836)

* helper methods and dashboard access

* guest token dashboard authz

* adjust csrf exempt list

* eums don't work that way

* Remove unnecessary import

* move row level security tests to their own file

* a bit of refactoring

* add guest token security tests

* refactor tests

* clean imports

* variable names can be too long apparently

* missing argument to get_user_roles

* don't redefine builtins

* remove unused imports

* fix test import

* default to global user when getting roles

* missing import

* mock it

* test get_user_roles

* infer g.user for ease of tests

* remove redundant check

* tests for guest user security manager fns

* use algo to get rid of warning messages

* tweaking access checks

* fix guest token security tests

* missing imports

* more tests

* more testing and also some small refactoring

* move validation out of parsing

* fix dashboard access check again

* rls rules for guest tokens

* test guest token rls rules

* more flexible rls rules

* lint

* fix tests

* fix test

* defaults

* fix some tests

* fix some tests

* lint

Co-authored-by: Lily Kuang <lily@preset.io>

* SupersetClient guest token test

* Apply suggestions from code review

Co-authored-by: Lily Kuang <lily@preset.io>

Co-authored-by: Lily Kuang <lily@preset.io>
2022-01-25 16:41:32 -08:00
Lyndsi Kay Williams
2491b89f29
Columns tab name field no longer editable, calculated columns rows now vertically aligned (#18164) 2022-01-25 14:34:56 -06:00
Stephen Liu
7bb867407a
fix(textarea-control): ace editor input exception (#18146) 2022-01-25 16:57:12 +01:00
Kamil Gabryjelski
c77d24cda3
fix: undefined error when adding extra sequential color scheme (#18152) 2022-01-24 19:20:49 +01:00
Kamil Gabryjelski
e632193eb0
feat(explore): more toast feedback on user actions in Explore (#18108)
* feat(explore): add toasts feedback when user copies chart url

* Show toast message when updating chart properties

* Change toast type to success when saving chart

* Use success toast from props

* Fix tests

* Use withToasts instead of dispatch

* Use PropertiesModalProps instead of any
2022-01-24 11:42:24 +01:00
Kamil Gabryjelski
d9eef8ec2f
feat(dashboard): add toast feedback to dashboard actions (#18114) 2022-01-24 11:42:12 +01:00
Kamil Gabryjelski
9fa2812343
feat(annotation): add toast feedback to annotation templates (#18116) 2022-01-24 11:41:39 +01:00
Stephen Liu
b083b3421f
fix(explore): fix chart embed code modal glitch (#17843) 2022-01-21 09:11:33 -07:00
Adam Dobrawy
a5e805ef2a
refactor: migrate RowCountLabel to TypeScript & added story (#18105)
* enable superbook for explore component

* migrate RowCountLabel to TypeScript

* add storybook for RowCountLabel
2022-01-20 15:35:09 +01:00
Adam Dobrawy
c3a17a7228
Migrate Checkbox story to tsx - see #18100 (#18101)
Looks good!
2022-01-20 15:33:45 +01:00
Josue Lugaro
035638c958
refactor: sqleditorleftbar to functional (#17807)
* Working on converting sqleditorleftbar to functional component

* Creating draft PR to address bug

* Still working on solving re rendering bug

* infinite rerender fix

* Creating draft PR to address bug

* Cleaning up in preparation for push

* Made changes suggested by Elizabeth

* Fixed issues as per Lindsey's comment

Co-authored-by: Arash <arash.afghahi@gmail.com>
2022-01-19 15:06:28 -06:00
Stephen Liu
22896f2803
feat: add chart description in info tooltip (#17207)
* feat: add chart list description

* fix: text overflow

* fix: text-overflow with line-height
2022-01-19 21:24:17 +08:00
AAfghahi
88db2cc0ab
refactor(sql_lab): SQL Lab Persistent Saved State (#17771)
* a lot of console logs

* testing

* test

* added saved_query to remoteId

* created useEffect so that title properly changes in modal

* Update superset-frontend/src/SqlLab/actions/sqlLab.js

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-01-18 13:10:31 -05:00
Stephen Liu
3b64563f3f
fix(dashboard): scope of nativefilter not update (#18048) 2022-01-18 16:51:51 +08:00
Grace Guo
26dc600aff
fix: handle null values in time-series table (#18039) 2022-01-13 21:47:07 -08:00
Erik Ritter
343d3f8f7a
fix: Disable filtering on wide result sets (#18021) 2022-01-13 10:11:18 -08:00
Beto Dealmeida
51090c3f1b
feat: shorter timeout on test_connection (#18001)
* feat: shorter timeout on test_connection

* pip-compile-multi --no-upgrade

* Fix for SQLite

* Return 408

* Add test
2022-01-12 13:01:34 -08:00
Erik Ritter
27000da2f8
fix: SQL Lab sorting of non-numbers (#18006) 2022-01-12 11:09:59 -08:00
AAfghahi
536ca1f62c
chore(DatasourceEditor): Create Datasource Legacy Editor Feature Flag (#18003)
* a lot of console logs

* adding new feature flag for datasource editor
2022-01-12 14:02:53 -05:00
Yongjie Zhao
46715b295c
refactor: remove unused ts-jest (#17996) 2022-01-11 23:43:45 +08:00
Phillip Kelley-Dotson
3d829fc3c8
fix: dashboard reload crash (#17992)
* fix dashboard reload

* add more strict case
2022-01-10 18:34:28 -08:00
Lyndsi Kay Williams
f7add546ad
Fixed error handling in Report modal (#17988) 2022-01-10 17:01:08 -06:00
Phillip Kelley-Dotson
c139312bb3
fix: dashboard full screen layout (#17985)
* fix: full screen mode for dashboard

* remove console
2022-01-10 15:58:39 -07:00
Lyndsi Kay Williams
df69920a2e
Moved dataset editor lock to top of component (#17930) 2022-01-10 16:55:00 -06:00
Lyndsi Kay Williams
f6b9393999
Tooltip no longer dancing (#17931) 2022-01-10 16:54:38 -06:00
serenajiang
05d9cde203
feat: update time comparison choices (again) (#17968) 2022-01-10 10:08:15 -08:00
Stephen Liu
bd9e1235a9
fix(dashboard): scope status of filter not update in dashboard metadata (#17945)
* fix(dashboard): scope status of filter not update in dashboard metadata

* fix save
2022-01-10 10:19:25 -07:00
Kamil Gabryjelski
35f4c33245
fix(native-filters): apply default value correctly when it's set (#17982) 2022-01-10 17:32:31 +01:00
Evan Rusackas
c0a769581f
chore: bump typescript to 4.5.4, and adjust storybook story. (#17971)
* chore: bump typescript to 4.5.4, and adjust storybook story to pass linting

* ugh... missed a space. Thanks, linter :)

* nixing erroneous package lock file
2022-01-09 21:01:59 -07:00
Phillip Kelley-Dotson
765c72a858
fix: update slug name (#17961)
* fix: fix update slug name

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-01-07 11:37:12 -08:00
Michael S. Molina
647bbf1ea1
chore: Moves spec files to the src folder - iteration 10 (#17902)
* chore: Moves spec files to the src folder - iteration 10

* Fixes test

* Fixes lint problem

* Uses styledMount in test
2022-01-07 15:24:15 -03:00
Michael S. Molina
bb7e979142
chore: Moves spec files to the src folder - iteration 9 (#17901) 2022-01-07 15:23:57 -03:00
Stephen Liu
2ae29c9281
fix(Select): options will be overwritten due to seState (#17951) 2022-01-07 08:09:25 -07:00
Michael S. Molina
e6ef7da758
chore: Moves spec files to the src folder - iteration 8 (#17899)
* chore: Moves spec files to the src folder - iteration 8

* Fixes tests
2022-01-07 09:25:45 -03:00
Michael S. Molina
aa91662ec8
chore: Moves the Menu to views/components folder (#17897)
* chore: Moves the Menu to views/components folder

* Fixes imports
2022-01-07 09:25:31 -03:00
Michael S. Molina
53d8d383cc
chore: Moves the hooks folder to the src folder (#17896) 2022-01-07 09:25:06 -03:00
Hugh A. Miles II
9e69940171
feat: Update query states to use spinner vs. progress bar (#17804)
* lit

* remove reference for progress bar

* update to loading

* update switch out spinner for loading when progress hits 100

* update test
2022-01-05 10:43:42 -08:00
Yongjie Zhao
ceecc7047b
chore: remove unused eslintrc (#17860)
* chore: remove unused eslintrc

* remove unused lint

* add comments

* change comments
2022-01-05 19:31:12 +08:00
David Aaron Suddjian
de3d3973a2
fix: process color scheme configs correctly (#17786) 2022-01-04 15:27:10 -08:00
Stephen Liu
07998fea68
fix(explore): simple tab content input problem (#17872) 2022-01-03 12:41:19 +08:00
Beto Dealmeida
9baeafec93
feat: configure force_screenshot (#17855)
* Update existing tests

* Add backend test

* feat: add force option to report screenshots

* Add tests

* Rebase fixes

* Do not force screenshot on dashboard alerts

* feat: bypass cache on screenshots for alerts

* Update existing tests

* Add tests

* feat: configure force_screenshot
2021-12-22 13:46:00 -08:00
Beto Dealmeida
2cd8054358
feat: add force option to report screenshots (#17853)
* Update existing tests

* Add backend test

* feat: add force option to report screenshots

* Add tests

* Rebase fixes

* Do not force screenshot on dashboard alerts
2021-12-22 12:16:04 -08:00
Lyndsi Kay Williams
d2ed1b72dc
chore: Help user to find the input fields in the dataset editor (#17824)
* Updated fields in Metrics and Calculated Columns tabs inside dataset editor, deleted label in expanded Metrics tab

* Fix tests

* Vertically aligned rows in columns tab
2021-12-22 12:21:37 -06:00
Beto Dealmeida
b7707e8ff7
feat: bypass cache on screenshots for alerts (#17695)
* feat: bypass cache on screenshots for alerts

* Update existing tests

* Add backend test

* Add frontend test
2021-12-22 08:26:38 -08:00
Stephen Liu
ec48dd5c40
fix(dashboard): update native filter info in metadata is not updated (#17842) 2021-12-22 08:47:27 +02:00
Phillip Kelley-Dotson
cfd851aa13
fix: replace datamask with key from new key value api (#17680)
* afirst stage to ccheck to get initial datamask

* clean up code and update typescript

* remove consoles

* fix ts and update copy dashboard url

* use key when one doesn't exists

* lint clean up

* fix errors

* add suggested changes

* remove line

* add tests and add changes for copydashboard

* fix lint

* fix lint

* fix lint

* Update superset-frontend/src/dashboard/components/Header/index.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* add timeout

* fix test

* fix test, add qs to cypress and add suggestions

* add suggestions

* fix lint

* more suggested changes for backwards comapat

* fix lint

* cleanup naming and add qs parse to tests

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* more changes and fix lint

* remove nativefiler param

* fix path

* remove con

* simplify logic

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-12-21 09:08:48 -08:00
Stephen Liu
d5768ab649
fix(explore): make SORT-Descending visible if Sort-by has value (#17726) 2021-12-21 15:27:21 +08:00
Erik Ritter
5b0aa27f2b
feat: Persist SQL Lab autocomplete setting across tabs and visits (#17708) 2021-12-20 15:53:48 -08:00
Erik Ritter
6edc183c5f
chore: Refactor localstorage into typesafe version (#17832) 2021-12-20 13:58:59 -08:00
Holger Bruch
61a6aa0f97
Map schemes json to SequentialScheme (#17813) 2021-12-20 09:38:24 +02:00
Srini Kadamati
53e2fa6f57
chore: updated screenshots in README.md and added recent events (#17650)
* chore: updated screenshots in readme.md and added recent events

* chore: updated pinot superset connection instructions

* fixed outdated slack link

* addressed all outstanding feedback!

* updated package lock

* reverted package.json to master

* Update README.md

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-12-17 11:43:46 -05:00
Grace Guo
c5af7a48df
fix: [alert] allow decimal for alert threshold value (#17751)
* fix: [alert] add tooltip message for alert threshold value

* support decimal value for alert condition threshold

* add integration test
2021-12-16 22:51:23 -08:00
Ville Brofeldt
961766e833
fix(filter-sets): 404 on dashboard load (#17777) 2021-12-16 11:27:46 +02:00
Geido
274fb37a91
fix: Remove positions from json_metadata (#17766)
* Remove positions from json_metadata

* Update superset-frontend/src/dashboard/components/PropertiesModal/index.tsx

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

* Indent

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2021-12-15 11:32:31 -07:00
Kamil Gabryjelski
124af4c566
chore(explore): Migrate BigNumber to v1 api [ID-28][ID-55] (#17587)
* chore(explore): Migrate BigNumber to v1 api

* Move to echarts

* Use Echarts trendline

* Fix imports

* Fix parsing dates as strings

* Add from_dttm and to_dttm to v1 chart response

* Fix post processing

* Fix timeRangeFixed

* Fix tests

* Remove from and to dttm from cache

* Cleanup date formatting

* Fix storybook

* Fix missing types

* Fix timestamp with timezone

* Add types to demo's tsconfig

* bug fix

* fix import

* Fix cypress tests

* add sort

* add resample to handle missing values properly

* Sync ChartDataResponseResult schema with ts interface

* Lint fix

* Add migration

* Fix migration

* Remove pass

* Re-raise the exception in migration

* Typo fix

* Update revision

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-12-15 10:15:14 +01:00
Stephen Liu
142b5bc506
fix: local warning in the frontend development (#17727) 2021-12-15 09:52:42 +02:00
Beto Dealmeida
2a6e5e5e5c
fix: import DB errors (#17748) 2021-12-14 18:32:57 -08:00
Beto Dealmeida
63d9693f21
feat: add main datetime column to dataset editor (#17739)
* feat: add main dttm col to dataset editor

* Add tests
2021-12-14 14:47:08 -08:00
Geido
4b969710e4
Rename CertifiedIcon to CertifiedBadge (#17715) 2021-12-10 11:45:53 -07:00
Kamil Gabryjelski
b5b6ceb1b3
fix(explore): don't apply time range filter to Samples table (#17711) 2021-12-10 11:40:11 -07:00
Geido
8de93871d7
Fix flacky header (#17690) 2021-12-10 18:25:40 +02:00
Geido
dad8c20af7
fix(Dashboard): Copy dashboard with duplicating charts 500 error (#17707)
* Fix copy dashboard with charts

* Fix Cypress test
2021-12-09 16:25:01 -07:00
Stephen Liu
bdc4e7a322
fix(explore): deck.gl Multiple chart broken (#17703) 2021-12-09 20:03:02 +02:00
Geido
12bd1fcde5
fix: Save properties after applying changes in Dashboard (#17570)
* Refactor PropertiesModal

* Update json_metadata fully

* Clean up

* Verify values

* Catch changed to metadata

* Always updated dashboard info on update

* Avoid unnecessary fetches

* Formt

* Fix copy dashboards

* Fixes onUpdate onCopy handlers

* Pylint

* Update tests

* Clean up

* Handle data on show

* Change Save to Apply

* Update Cypress save test

* Update Cypress edit prop test

* Update PropertiesModal test

* Fix duplicate request with cross filters

* Improve code style

* Fix typo

* Lint
2021-12-09 10:03:07 -07:00
Corbin Robb
f476ba23a2
fix(select): select component sort functionality on certain options (#17638)
* fix: Select component sort function sorting by label instead of value on numbers

* fix: change select component default sorting to sort by the initial index rather than a property like value or label

* fix: select sorting add sortOptions to select components using sortByProperty

* fix: change select component back, add order to options coming in from SelectControl

* fix: select component options intitial sort bug

* fix: add test cases for select fix

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-12-09 11:40:25 -05:00
Geido
aad2abe7f0
Fix undefined error (#17692) 2021-12-08 13:30:41 -07:00
Geido
46cdc77ae6
fix: Redirect on 401 (#17597)
* Redirect on 401

* Bump FAB

* Format

* Update Cypress save test

* Revert Cypress change

* Bump FAB 3.4.1rc2

* Update test

* Update return statement

* Update api test

* Update datasets api test

* Update datasets api 401s to 403s

* Add typeguard

* Use Promise.resolve

* Update callApiAndParseWithhTimeout test

* Disable parseResponse test

* Try catch

* Handle npm 8 issues
2021-12-08 13:14:30 -07:00
Ville Brofeldt
c4b04952d0
feat: customize recent activity access (#17589)
* feat: customize recent activity access

* address comments

* fix and add tests

* add alert assertion and UPDATING.md entry

* replace .get_id() with .id

* fix updating comment

* update config name
2021-12-08 11:30:23 +02:00
Lyndsi Kay Williams
05752e3fe8
fix(sqllab): Floating numbers not sorting correctly in result column (#17573)
* Floating nums now sorting correctly with parseFloatingNums function

* Floating numbers AND strings now sorting correctly, +locale comparison

* Added NULL handling back to sort function

* Moved parseFloatingNums outside of sortResults

* Removed localeCompare and added testing

* Add equality check back to sort function

* Added floatValue nit
2021-12-03 16:31:46 -08:00
Kamil Gabryjelski
07e8837093
feat(explore): export csv data pivoted for Pivot Table [ID-9] (#17512)
* feat(explore): export csv data pivoted for Pivot Table

* Implement dropdown with download csv options

* Change label to "Original"

* Add tests

* Add form data to query context

* Add form data to query context generator

* Explicitly make form_data optional
2021-12-03 12:42:28 +01:00
Jesse Yang
73e7928c4b
chore(superset-ui): clean up legacy-plugin-chart-time-table (#17626) 2021-12-02 17:14:10 -08:00
Stephen Liu
b5d13d72f2
fix(dataset): modal sql editor error (#17612)
* fix(dataset): model sql editor

* add tests
2021-12-02 13:02:19 -07:00
Hugh A. Miles II
d9e9c3a3de
refactor: Add AutoSizer to react-virtualized Grid (#17606)
* remove styles from renderCell

* remove styling on grid
2021-12-02 12:47:47 -05:00
Stephen Liu
a3cce5705d
feat(explore): support show annotation label [ID-8] (#17307)
* feat(explore): support always show annotation label

* fix: lint

* fix: lint

* Hopefully appeasing the linter

* fix: lint

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* change to allow none

* lint

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2021-12-02 00:26:32 -07:00
Matt Houston
54b56fe12f
feat: Add single select and inverse selection to numeric range (#16722) (#17372)
* feat: add single select and inverse selection to numeric range (#16722)

* Ignore invalid eslint errors regarding conditionally called hooks.

* Add license header to new file.

* Flipped the numerical range values for the minimum slider so that the highlighted range value accurately reflects the applied filter.

* Resolved linting errors

* Remove unnecessary important flag from css
2021-12-01 15:28:11 -08:00
Geido
8963cca265
Revert "fix(Dashboard): Only apply changes when editing properties (#17392)" (#17618)
This reverts commit 0712be4c12.
2021-12-01 11:35:55 -07:00
Daman Arora
c6ba9bf9db
chore: migrate EstimateQueryCostButton component from jsx to tsx (#17603)
* migrate EstimateQueryCostButton component from jsx to tsx

* re-format spaces using prettier

* Update superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* remove extra onClick and make disabled prop optional

* restore & rename event handler onClick to onClickHandler

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
2021-12-01 09:28:52 -08:00
Phillip Kelley-Dotson
4e76637252
initial fix (#17547) 2021-11-30 08:24:18 -08:00
Daman Arora
bfba4f1689
chore: migrate Fieldset component from jsx to tsx (#17474)
* migrate Fieldset component from jsx to tsx

* update type check for fieldKey

* remove unused css class called fieldset
2021-11-29 14:17:54 -08:00
Michael S. Molina
a959e6df45
fix: Visualizations don't load when using keyboard shortcuts (#17542) 2021-11-29 09:14:21 -03:00
Holger Bruch
6604a6ab28
chore(translations): Add missing i18n (#17525)
* Add *.ts to babel.cfg

* Add missing i18n calls

* Update pot file

* Fix lint issues and review comment

* Incorparate review feedback

* Fix missing or non-extractable i18n calls

* Update pot file

* Fix syntax error in CommonParameters.tsx

* Fix introduced issues
2021-11-27 14:50:33 +02:00
Nithin George Philips
4cf429c154
feat: add classNames for apply and clearAll buttons for superset filters (#17554)
Co-authored-by: Nithin Philips <nithinphilips@Administrators-MacBook-Pro.local>
2021-11-27 12:09:36 +02:00
Hugh A. Miles II
2e29f36e78
fix: RBAC for export for dashboard viewers (#17527)
* set out export

* update test

* use default dataset

* update test

* these test work

* fix test

* update

* fix

* fix test

* make the test better
2021-11-25 20:10:41 -08:00
Daman Arora
cf3f0e5b55
chore: migrate DragHandle component from jsx to tsx (#17326)
* migrate DragHandle component from jsx to tsx

* Convert class based component to functional component
2021-11-25 11:18:56 +02:00
Kamil Gabryjelski
7353a2bd75
fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) 2021-11-24 13:06:11 +01:00
Geido
83e49fc9ee
feat: Certify Charts and Dashboards (#17335)
* Certify charts

* Format

* Certify dashboards

* Format

* Refactor card certification

* Clear details when certified by empty

* Show certification in detail page

* Add RTL tests

* Test charts api

* Enhance integration tests

* Lint

* Fix dashboards count

* Format

* Handle empty value

* Handle empty slice

* Downgrade migration

* Indent

* Use alter

* Fix revision

* Fix revision
2021-11-24 13:42:52 +02:00
Ajay M
9576478a5d
feat(dashboard): Add divider component in native filters (#17410)
* Tests are working, type errors are fixed

* Fix filterset

* add license header to the new file

* fix test

* PR comments

* Linting

* test fix

* small fix
2021-11-23 16:13:56 -08:00
Corbin Robb
c216565190
Remove loading span, add empty-loading-bar css class, change empty loading rows length to 12, remove width logic on empty loading columns (#17515)
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-11-23 15:13:53 -08:00
Evan Rusackas
6d66963489
fix: hiding HiddenControl inputs for real, to reduce bootstrap space consumption (#15182)
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-11-23 15:08:24 -08:00
Ville Brofeldt
18c7aec985
chore: remove deprecated selects and deps (#17522) 2021-11-23 12:41:16 +02:00
Ville Brofeldt
5d1c9078ad
chore(translations): fix translation literals (#17501)
* chore(translations): fix translation literals

* fix table name types and translations

* fix lint

* join concat'd messages
2021-11-23 10:06:09 +02:00
Daman Arora
daff9b4673
chore: migrate FormattedNumber component from jsx to tsx (#17361)
* migrate FormattedNumber component from jsx to tsx

* Unset default prop on format

* undo asserting and overriding the type for num

* Add a ts comment to ignore error
2021-11-22 13:42:37 -08:00
Corbin Robb
8e1619b105
fix(sqllab): Have table name tooltip only show when name is truncated (#17386)
* Add conditional to table name tooltip to only show when overflowing

* Remove uneccessary state and useEffect, a little clean up and slight refactoring

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-11-19 09:34:28 -08:00
Daniel Vaz Gaspar
69f9ee8f5e
fix: feature flags typing (#15254)
* fix: feature flags typing

* fix tests

* add note in UPDATING.md

* fix frontend

* also move SCHEDULED_QUERIES to top level

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-11-19 15:56:16 +00:00
Yongjie Zhao
9070b6b19c
refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
Geido
c2d8b0e72f
chore: Notify user of custom label colors and related Dashboard color scheme (#17422)
* Add alert for custom label colors

* Fix duplicate linear scheme

* Implement dashboard alert

* Remove trailing space

* Update Cypress

* Simplify check
2021-11-16 17:46:39 +02:00
Grace Guo
9f1bf1cbd5
fix: do not show migration toast if user not enable dashboard filter components (#17440) 2021-11-15 11:27:24 -08:00
Lyndsi Kay Williams
eb029ab068
fix(sql lab): NULL styling in grid cell (#17385)
* Fix NULL styling in gridCell

* removed unnecessary imports

* Added null styling back to renderGridCell

* Cleaned up a little code as per Elizabeth

* Found another little cleanup spot
2021-11-15 10:49:35 -08:00
Elizabeth Thompson
71e3fa1bf3
use full resultType with csv download on chart in dashboard (#17431) 2021-11-15 09:57:05 -08:00
Ville Brofeldt
e2a429b0c8
feat(explore): adhoc column expressions [ID-3] (#17379)
* add support for adhoc columns to api and sqla model

* fix some types

* fix duplicates in column names

* fix more lint

* fix schema and dedup

* clean up some logic

* first pass at fixing viz.py

* Add frontend support for adhoc columns

* Add title edit

* Fix showing custom title

* Use column name as default value in sql editor

* fix: Adds a loading message when needed in the Select component (#16531)

* fix(tests): make parquet select deterministic with order by (#16570)

* bump emotion to help with cache clobbering (#16559)

* fix: Support Jinja template functions in global async queries (#16412)

* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check

* fix: impersonate user label/tooltip (#16573)

* docs: update for small typos (#16568)

* feat: Add Aurora Data API engine spec (#16535)

* feat: Add Aurora Data API engine spec

* Fix lint

* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)

* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues

* refactor sql_json view endpoint: separate concern into ad hod method (#16595)

* feat: Experimental cross-filter plugins (#16594)

* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF

* chore(deps): bump superset-ui to 0.18.2 (#16601)

* update type guard references

* fix imports

* update series_columns schema

* Add changes that got lost in rebase

* Use current columns name or expression as sql editor init value

* add integration test and do minor fixes

* Bump superset-ui

* fix linting issue

* bump superset-ui to 0.18.22

* resolve merge conflict

* lint

* fix select filter infinite loop

* bump superset-ui to 0.18.23

* Fix auto setting column popover title

* Enable adhoc columns only if UX_BETA enabled

* put back removed test

* Move popover height and width to constants

* Refactor big ternary expression

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
2021-11-15 12:50:08 +02:00
Phillip Kelley-Dotson
e6ff25c980
fix(chart): ensure samples data is displayed (#16900)
* initial fix

* use data keys for cols

* add e2e test

* remove code

* trim logic
2021-11-12 14:23:46 -08:00
John Bodley
bcef8fa13b
feature: Add quarter unit to datetrunc (#17416)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-12 09:46:55 -08:00
Geido
0712be4c12
fix(Dashboard): Only apply changes when editing properties (#17392)
* Apply only

* Test apply button

* Update Cypress

* Rename test
2021-11-12 19:34:21 +02:00