Commit Graph

5199 Commits

Author SHA1 Message Date
stevetracvc
a45d011e74
fix: issue with sorting by multiple columns in a table (#19920)
Recent commit to sort alphanumeric columns via case insensitive
comparison broke the multi-column sort option. React-table only sorts
by the second (or third...) column if the first column matches.
Since the alphanumeric sort only returned -1 or 1, it never would move
to the subsequent columns when the earlier column values matched.
2022-06-23 08:39:46 -03:00
Diego Medina
4dc30441b7
fix: alert & reports active toggle optimistic update (#20402) 2022-06-23 08:33:54 -03:00
Eric Briscoe
9f9aae49c9
chore: Convert QueryAutoRefresh to TypeScript functional React component [sc-48362] (#20179)
* git commit -m 'Convert QueryAutoRefresh to functional component [sc-48362]'

* addressing PR comments [sc-48362]

Removes unneeded props and state tracking of offline, adds finally block to simplify clearing pending request, simplifies value comparison in array by using includes in place of indexOf

* Address PR comment to use enum for QueryState [sc-48362]

Original implementation had string literals used in multiple places representing Query.state value options.  This commit creates a formal TypeScript enum for QueryState so we can remove string literals and ensure better consistency

* Address PR comments for object type validation [sc-48362]

This commit resolves an issue why the TypeScript typing for queryList was marked as a Query[] but was actually a Dictionary (associative array) or Queries.  A new type QueryDictionary has been added and the QueryAutoRefresh code was adjusted to use QueryDictionary instead of Query[] in appropriate places as well as unit tests.  Commit also removes QueryAutoRefreshContainer by making the once component using QueryAutoRefresh (which is already redux connected) pass the needed values on props.  this simplifies the code base and reduce files that need unit testing while keeping QueryAutoRefresh out of needing a redux connection directly.

* Addresses PR comment to add QueryState.SCHEDULED to runningQueryStateList [sc-48362]

In previous implementation 'scheduled' was not included int he list of Query States.  Further investigation shows it should be added to as a running state.

* Fix prettier lint error [sc-48362]

* Adjust unit tests for props update hoisting callbacks out of actions wrapper object [sc-48362]

* Update with changes from master [sc-48362]

Merges in updates from master and resolves conflicts from relocation of some of the Query TypeScript definitions into core

* Removes logic setting user offline and relying on results panel error message [sc-48362]

* Fixes bad import after some TypeScript definitions were relocated to core [sc-48362]

* Fixes TypeScript errors [sc-48362]
2022-06-22 13:20:02 -07:00
cccs-Dustin
daded10992
feat(SQL Lab): Make SQL Lab explore use the default viz from the config file (#20056)
* Modified SQL Lab so it uses the default viz to explore a new dataset with

* Added a comment to the config file

* Remove trailing whitespace

* [CLDN-1312] Removed the 'viz_type' variable so that when it is undefinded in the back-end, it gets set to the default viz

* [CLDN-1312] Only sets the 'all_columns' variable if the default viz type is a 'table'

* Will only pop 'selectedColumns' out of 'form_data' if it is present

* [CLDN-1312] Updated files so that the default viz is now being used again in SQL Lab Explore
2022-06-22 11:33:44 -06:00
smileydev
a833674a8d
fix(home): Show home page tabs as pills instead of links (#20257)
* fix(home): make to update the css style of links

* fix(home): make to fix lint issue

* fix(home): make to remove underline when tab is active

* fix(homes): make to fix the issue of tab

* fix(home): make to move styles to a tag
2022-06-21 17:44:48 -06:00
Michael S. Molina
ca526e63c8
feat: Adds support for clearing the Select cache (#20397)
* feat: Adds support for clearing the Select cache

* Fixes lint errors
2022-06-21 15:13:37 -03:00
Cody Leff
44c5e2879b
chore(newchart): update chart creation dataset selection help text, styles (#20369)
* Update dataset selection help text.

* Update 'Create a new chart' flow styles.

* Add support for linking directly to Create Dataset modal via URL hash.

* Add support for linking directly to Create Dataset modal via URL hash.

* Update dataset help text to not include spaces in translated strings and only include an 'Add dataset' link when user has permission to add dataset.

* Clean up test file

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-06-21 14:01:43 -03:00
smileydev
1ae935379f
fix(chart & table): make to prevent dates from wrapping (#20384) 2022-06-21 09:58:50 -03:00
Yongjie Zhao
9fad26fa19
fix: suppress translation warning in jest (#20404) 2022-06-21 20:38:58 +08:00
Diego Medina
93774d1860
fix: table viz sort icon bottom aligned (#20447) 2022-06-21 09:10:37 -03:00
Yongjie Zhao
c79b0d62d0
refactor: create echarts query section (#20445) 2022-06-21 11:38:07 +08:00
Sam Firke
b7eb235440
style(typo): occured -> occurred (#20116)
* Occured -> Occurred

* Occured -> Occurred

* Occured -> Occurred

* Occured - > Occurred

* Update FallbackComponent.tsx

* Update FallbackComponent.tsx

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2022-06-20 08:49:45 -07:00
Yongjie Zhao
111affdb02
chore: move xaxis to superset-ui (#20438) 2022-06-20 22:36:27 +08:00
Diego Medina
c2f01a676c
fix(dashboard): new created chart did not have high lighted effect when using the permalink of chart share in dashboard (#20411) 2022-06-19 08:17:06 -06:00
Lily Kuang
ab9f72f1a1
fix(embedded): CSV download for chart (#20261)
* move postForm to superset client

* lint

* fix lint

* fix type

* update tests

* add tests

* add test for form submit

* add test for request form

* lint

* fix test

* fix tests

* more tests

* more tests

* test

* lint

* more test for postForm

* lint

* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* update tests

* remove useless test

* make test cover happy

* make test cover happy

* make test cover happy

* make codecov happy

* make codecov happy

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-06-17 20:01:08 -07:00
Cody Leff
9f74fb7a84
Skip flaky Cypress test. (#20417) 2022-06-17 10:24:58 -06:00
jiAng
f6f93aad37
fix(cosmetic): cannot find m-r-10 class in superset.less (#20276)
* fix(cosmetic): cannot find m-r-10 class in superset.less

* fix: remove .m-r-10 class and use emotion instead

* Update superset-frontend/src/components/Datasource/CollectionTable.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Datasource/DatasourceEditor.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-06-17 08:54:27 -03:00
Stephen Liu
fa7f144a68
fix: rm eslint-plugin-translation-vars engine requirement (#20420) 2022-06-17 14:29:57 +08:00
Stephen Liu
b32288fddf
fix(bar-chart-v2): remove marker from bar chart V2 (#20409) 2022-06-17 10:52:26 +08:00
Smart-Codi
a8a6b732e9
adding extra metrics after chart configuration (#20410) 2022-06-16 12:55:14 -06:00
Kamil Gabryjelski
c959d92dd1
feat(plugin-chart-echarts): Support stacking negative and positive values (#20408) 2022-06-16 13:58:58 +02:00
Stephen Liu
1665403484
fix(plugin-chart-pivot-table): color weight of Conditional formatting metrics not work (#20396)
* fix(plugin-chart-pivot-table): color weight of Conditional formatting metrics not work

* fix: test
2022-06-16 12:22:09 +08:00
Reese
498987a1a0
Prevent dataset edit modal closing on click-away in edit mode (#20278) 2022-06-15 14:28:13 -06:00
Michael S. Molina
d6f9fb5af1
chore: Removes unused vars (#20194)
* chore: Removes unused vars

* Fixes lint

* Disables no-unused-vars for the operators
2022-06-15 11:01:45 -03:00
Yongjie Zhao
0a50a9b380
feat: setting limit value when Pie chart switches (#20392) 2022-06-15 21:49:00 +08:00
Yongjie Zhao
7c252d7524
feat: adding truncate metric control on timeseries charts (#20373) 2022-06-15 20:55:10 +08:00
smileydev
df8bb46ee2
fix(fonts): Show the all the A's in our workspace correctly, not funky (#20361)
* fix(fonts): make to fix the issue of broking the Inter font char A

* fix(css & fonts): make to install from npmjs.org
2022-06-15 00:28:54 -06:00
Diego Medina
ead10401e7
fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button (#20363)
* fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button

* PR comments
2022-06-14 17:47:37 -06:00
Phillip Kelley-Dotson
160e674b90
fix: update connection modal to use existing catalog (#20372)
* fix: update connection modal to use existing catalog

* remove console
2022-06-14 15:10:01 -04:00
Kamil Gabryjelski
86f146e217
feat(explore): Implement viz switcher redesign (#20248)
* add icons

* Implement fast viz switcher component

* Remove unnecessary keys from ControlsPanelContainer

* Rename icons

* Add unit tests

* Add licenses

* Fix test

* Change BigNumberWithTrendline to BigNumber

* fix test

* fix test

* Add currently rendered viz tile

* Move View all charts to the right side

* Add license

* Fix imports

* Fix e2e test
2022-06-14 15:20:54 +02:00
John Bodley
c3fdd52697
fix(VERSIONED_EXPORTS): Ensure dashboards and charts adher to the VERSIONED_EXPORTS feature flag (#20368)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-13 18:39:15 -07:00
Diego Medina
e1532f63ac
fix: query execution time is not fully displayed in bubble icon (#20364) 2022-06-13 14:30:00 -06:00
Michael S. Molina
cb2ffa530f
chore: Removes no-use-before-define warnings (#20298) 2022-06-13 07:44:34 -03:00
Diego Medina
8345eb4644
fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button (#19967)
* fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button

* include onDatabaseAdd on successful import
2022-06-12 22:21:30 +08:00
Lyndsi Kay Williams
c842c9e2d8
feat(explore): Dataset Panel Options when Source = Query II (#20299)
* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Removed isValidDatasourceType check

* Remove the rest of isValidDatasourceType check
2022-06-10 09:55:52 -07:00
Cody Leff
d0165b617b
chore(dashboard): update Edit Dashboard side panel tabs (#20337)
* Reorder Dashboard Edit tabs and rename 'Components' tab to 'Layout Elements'.

* Add tests for BuilderComponentPane.

* Fix Cypress tests, capitalization, test nesting.
2022-06-10 12:57:32 -03:00
Stephen Liu
07b4a7159d
fix(chart): chart gets cut off on the dashboard (#20315)
* fix(chart): chart gets cut off on the dashboard

* add some failsafe

* address comment
2022-06-09 22:59:58 +08:00
Kamil Gabryjelski
354a89950c
feat(explore): Denormalize form data in echarts, world map and nvd3 bar and line charts (#20313)
* feat(explore): Apply denormalize form data function to echarts and world map

* Denormalize form data in mixed timeseries

* Add dist bar chart
2022-06-09 11:54:09 +02:00
Yongjie Zhao
d04357c47b
fix: superset-ui/core codes coverage (#20324) 2022-06-09 17:43:42 +08:00
Yongjie Zhao
fd129873ce
feat: multiple results pane on explore and dashboard (#20277) 2022-06-09 09:11:34 +08:00
smileydev
1e5cacda8f
fix(explore): make to fix the issue of explore error broken when see more/less (#20282) 2022-06-08 17:00:08 -06:00
Diego Medina
5bfc95e79e
feat: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed (#19898)
* feature: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed

* Apply emotion templating to input/input labels
2022-06-08 16:52:53 -06:00
Stephen Liu
eab0009101
feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 (#16493)
* feat(echarts): [feature-parity] support extra control

* add extra control for plugin

* refactor: extract ExtraControl

* fix: lint

* fix some problems
2022-06-09 00:59:10 +08:00
Hugh A. Miles II
b6c11f2b97
fix: Alpha are unable to perform a second modification to a Dataset when in Explore (#20296)
* handle payload coming back from save

* address concerns
2022-06-08 16:24:36 +02:00
Reese
a57ed76e72
Fix faulty datetime parser regex (#20290) 2022-06-08 22:02:58 +08:00
Stephen Liu
9f02ff656d
fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer doesn't work as expected (#19761)
* fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer does't work

* fix: lint

* fix: test
2022-06-08 17:06:24 +08:00
Yongjie Zhao
8e46ae5c6a
chore: superset-ui/core code coverage (#20304) 2022-06-08 16:54:30 +08:00
Lyndsi Kay Williams
ba0c37d3df
feat(explore): Frontend implementation of dataset creation from infobox (#19855)
* Frontend implementation of create dataset from infobox

* Fixed sl_dataset type

* Fix test

* Fixed sl_dataset type (forgot to save)

* RTL testing

* Adjusted styling/text on infobox and save dataset modal

* Appease lint

* Make infobox invisible and fix tests

* Remove unnecessary placeholder

* Move types to sql lab

* Moved logic into save dataset modal

* Change DatasourceMeta type to Dataset

* Add ExploreDatasource union type to save dataset modal

* Get user info from redux inside save dataset modal

* Addressed comments

* Adjusting to new query type

* Fixed save dataset in explore and union type

* Added testing

* Defined d for queries

* Remove dataset from SaveDatasetModal

* Clarify useSelector parameter

* Fix dndControls union type

* Fix shared-controls union type

* Fix controlPanel union type

* Move ExploreRootState to explore type file

* Remove unnecessary testing playground

* Move datasource type check in DatasourcePanel to a function

* Make all sqllab Query imports reference @superset-ui/core Query type

* Deconstruct query props in ResultSet

* Fix union type in /legacy-plugin-chart-heatmap/src/controlPanel

* Change SaveDatasetModal tests to RTL

* Cleaned datasourceTypeCheck

* Fix infobox styling

* Fix SaveDatasetModal test

* Fix query fixture in sqllab and Query type in SaveDatasetModal test

* Fix Query type and make test query fixture

* Added columns to Query type, separated results property, created QueryResponse union type, and fixed all types affected

* Fixed a couple missed broken types

* Added ExploreDatasource to SqlLab type file

* Removed unneeded Query import from DatasourcePanel

* Address PR comments

* Fix columnChoices

* Fix all incorrect column property checks

* Fix logic on dndGroupByControl

* Dry up savedMetrics type check

* Fixed TIME_COLUMN_OPTION

* Dried savedMetrics type check even further

* Change savedMetricsTypeCheck to defineSavedMetrics

* Change datasourceTypeCheck to isValidDatasourceType

* Fix Query path in groupByControl

* dnd_granularity_sqla now sorts Query types with is_dttm at the top

* Fixed/cleaned query sort

* Add sortedQueryColumns and proper optional chaining to granularity_sqla

* Move testQuery to core-ui, add test coverage for Queries in columnChoices

* Moved DEFAULT_METRICS to core-ui and wrote a test for defineSavedMetrics

* Add license and clean dataset test object

* Change DatasourceType.Dataset to dataset
2022-06-07 15:03:45 -05:00
Yongjie Zhao
27c3ef1ed5
chore: remove unused codes for samples (#20272) 2022-06-07 21:54:15 +08:00
Phillip Kelley-Dotson
6f0d53eed8
feat: add modfied col and timezone info to schedule col (#20165)
* feat: add modfied and timezone to to schedule col

* test if test works

* udpate test

* fix test
2022-06-06 09:41:06 -07:00
Stephen Liu
5425504231
fix(codecov): improve core code coverage (#20274) 2022-06-06 17:21:23 +08:00
Yongjie Zhao
41f33a38bc
feat: showing results pane in dashboard (#20144) 2022-06-05 23:18:42 +08:00
Yongjie Zhao
7faf874c1b
feat: derived metrics use different line style (#20242) 2022-06-05 21:17:31 +08:00
Yongjie Zhao
dd4b581fb5
feat: standardized form_data (#20010) 2022-06-05 21:05:01 +08:00
jiAng
5c02ab7aaf
fix(cosmetic): Fix Datasource Modal Out Of Box (#20237) 2022-06-03 07:58:32 -06:00
Stephen Liu
80b5578680
feat(superset-ui-core): add feature flag for the analogous colors (#19987)
* feat(superset-ui-core): add feature flag for the color analogous generator

* fix: test
2022-06-03 21:32:32 +08:00
Stephen Liu
766f737728
feat(world-map): support color by metric or country column (#19881)
* feat(world-map): support color by metric or country column

* fix lint

* Update superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-world-map/src/controlPanel.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-world-map/src/controlPanel.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* fix lint

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-06-03 21:31:22 +08:00
Diego Medina
0e38c686c6
fix: Support the Clipboard API in modern browsers (#20058)
* fix: Support the Clipboard API in modern browsers

* fix tests

* PR comment

* Improvements
2022-06-03 19:34:00 +08:00
Diego Medina
92057858c2
fix(sql lab): View result button is not showing consistently (#20164) 2022-06-02 22:53:59 -06:00
Yongjie Zhao
a020f75a97
refactor: decouple DataTableControl (#20226) 2022-06-03 09:52:58 +08:00
Elizabeth Thompson
32bb1ce3ff
feat!: pass datasource_type and datasource_id to form_data (#19981)
* pass datasource_type and datasource_id to form_data

* add datasource_type to delete command

* add datasource_type to delete command

* fix old keys implementation

* add more tests
2022-06-02 16:48:16 -07:00
Cedric Gampert
a813528958
fix(charts list): do not trigger ListViewError exception for anonymous users #18210 (#20171) 2022-06-03 00:02:45 +08:00
Ilyas
d4f320f2a0
fix: exporting CSV can't apply pagination #17861 (#20178) 2022-06-02 12:42:51 +08:00
Eric Briscoe
e5f26313a5
Fixes issue where results panel height was incorrect [sc-49045] (#20204)
This commit fixes a dynamic height assignment issue where the SQL Editor results panel would be clipped offscreen and user could not see bottom of results, the height got assigned to zero after toggling online, then offline, and height would be calculated wrong if the result set rows returned message above the results table was long enough for a line wrap.
2022-06-02 10:01:14 +08:00
Yongjie Zhao
3d5ae6226b
fix: dashbaord unable to refresh (#20220) 2022-06-01 20:37:19 +08:00
Yongjie Zhao
1530c34792
fix: failed samples should throw exception (#20228) 2022-06-01 18:24:01 +08:00
Kamil Gabryjelski
3e3fbccdcb
feat(explore): Fill dashboard name when adding new chart from dashboard view (#20129)
* feat(explore): Fill dashboard name when adding new chart from dashboard view

* Update import paths

* Update test

* Fix test
2022-05-31 18:11:02 +02:00
Stephen Liu
9646591d24
fix(legacy-plugin-chart-sunburst): linear color scheme not work when secondary metric is provided (#20221) 2022-05-31 23:37:24 +08:00
Michael S. Molina
834dcef993
chore: Moves date utils to utils folder (#20192) 2022-05-31 12:21:58 -03:00
Stephen Liu
ad72ea53a1
fix(legacy-plugin-chart-sunburst): chart broken when secondary metric is remove (#20223) 2022-05-31 21:18:49 +08:00
Kamil Gabryjelski
0ee1f492a7
feat(explore): Add empty state to annotations (#20160)
* feat(explore): Add empty state to annotations

* Set line height for small empty state description

* Simplify code
2022-05-31 14:30:06 +02:00
Evan Rusackas
c8fe518a7b
fix(cosmetic): Limiting modal height (#20147)
* more changes that didn't make it into the last commit somehow.

* Allow modals to be short, but reach a max height and scroll

* now with template literals
2022-05-27 10:51:03 -06:00
Diego Medina
653cf773f7
fix(sql lab): SQL Lab Compile Query Delay (#20206) 2022-05-27 09:42:01 +03:00
Yongjie Zhao
e140b7aa87
fix: unable to set destroyOnClose on ModalTrigger (#20201) 2022-05-26 22:27:12 +08:00
Yongjie Zhao
e9007e3c2c
refactor: decouple DataTablesPane (#20109) 2022-05-26 18:59:54 +08:00
smileydev
95b28fc134
fix(db): make to allow to show/hide the password when only creating (#20186) 2022-05-26 11:18:17 +08:00
Michael S. Molina
73443cea2f
refactor: Removes embedded/index.tsx warnings (#20193) 2022-05-25 17:42:54 -03:00
Geido
3a4176a8d5
chore: Implement global header in Dashboard (#20146)
* Add gloal header

* Reimplement report dropdown

* Update unit tests

* Clean up

* Clean up

* Remove unused import

* Update Cypress

* Update Cypress save dashboard test

* Fix spacing
2022-05-25 12:56:19 +02:00
Diego Medina
365acee663
fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied (#20173) 2022-05-25 18:04:04 +08:00
stevetracvc
7e9b85f76c
feat: add drag and drop column rearrangement for table viz (#19381) 2022-05-24 19:10:57 -07:00
Kamil Gabryjelski
ce547f4098
chore: Disable flaky assert in reports cypress test (#20174)
* chore: Disable flaky assert in reports cypress test

* Disable flaky assert in alerts cypress test
2022-05-24 14:04:39 -07:00
Stephen Liu
ce01ce9e2f
fix(css): transparent linear gradient not working in safari (#20086)
* fix(css): transparent linear gradient not working in safari

* use emotion-rgba instead
2022-05-24 13:50:01 +08:00
Hugh A. Miles II
f8ea7788a9
feat: Add Certified filter to Datasets (#20136) 2022-05-23 17:58:15 -04:00
AAfghahi
b96e20a2f4
change button name (#20163) 2022-05-23 15:44:10 -04:00
Diego Medina
22b7496d2e
fix: string aggregation is incorrect in PivotTableV2 (#19102)
* fix: string aggregation is incorrect in PivotTableV2

* cleanup

* fix

* updates
2022-05-23 12:39:18 -06:00
Kamil Gabryjelski
b746e6f844
feat(dashboard): Chart title click redirects to Explore (#20111) 2022-05-23 13:18:08 +02:00
Yongjie Zhao
d7e3ac306f
chore: filter undefined operators (#20157) 2022-05-23 18:24:32 +08:00
smileydev
56e96950c1
fix(chart & heatmap): make to fix that y label is rendering out of bounds (#20011) 2022-05-20 12:54:42 -06:00
Ville Brofeldt
e766f8cb57
fix(explore): handle null control sections (#20142)
* fix(explore): handle null control sections

* fix type and add null to test fixture
2022-05-20 19:07:53 +03:00
Ville Brofeldt
0bcc21bc45
chore(data-table): make formatted dttm the default (#20140)
fix test
2022-05-20 15:39:10 +03:00
Ville Brofeldt
d5c5e58583
feat(plugin-chart-echarts): add support for generic axis to mixed chart (#20097)
* feat(plugin-chart-echarts): add support for generic axis to mixed chart

* fix tests + add new tests

* address review comments

* simplify control panel

* fix types and tests
2022-05-19 13:51:52 +03:00
Kamil Gabryjelski
b2a7fadba9
feat(dashboard): Add create chart button in dashboard edit mode (#20126) 2022-05-19 12:27:16 +02:00
Ville Brofeldt
0b3d3dd4ca
fix(generic-chart-axes): set x-axis if unset and ff is enabled (#20107)
* fix(generic-chart-axes): set x-axis if unset and ff is enabled

* simplify

* simplify

* continue cleanup

* yet more cleanup
2022-05-19 13:21:25 +03:00
Geido
1fe30f1f0e
Add tnum property to tables (#20093) 2022-05-18 16:26:29 +02:00
Krishna Gopal
63702c48ab
fix: add primary button loading state to modals (#20018) 2022-05-17 17:58:53 -07:00
Smart-Codi
6244728256
fix: Add cypress test for report page direct link issue (#20099)
* add cypress test for report page direct link issue

* add licence
2022-05-17 11:38:54 -06:00
Kamil Gabryjelski
9cdaa28042
Revert "feat(explore): Show confirmation modal if user exits Explore without saving changes (#19993)" (#20092)
This reverts commit ca9766c109.
2022-05-17 14:56:31 +02:00
smileydev
55aef4db3c
fix(chart & alert): make to show metrics properly (#19939)
* fix(chart & alert): make to show metrics properly

* fix(chart & alert): make to remove duplicate metrics

* fix(chart & alert): make to restore metrics control alert slice

* fix(chart & alert): make to fix lint issue
2022-05-16 14:22:47 -06:00
cccs-RyanS
ddc01ea781
feat(business-types): initial implementation of SIP-78 (#18794)
* add BUSINESS_TYPE_ADDONS to config with example callback

* Removing uneeded whitespace

* [Work in progress] Modifying cidr function to allow for  single ip and adding port outline

* Added test REST endpoint, added some more ports

I've thrown in a test.py script as well that will try to connect to the
business_type endpoint.

* Moving code from config.py into the business api

Very simple api is exposed that will allow someone to call a checkport
endpoint and get back a response.

* Removing commented out bits.

* Adding fucntion dict back to the config

* Moving business_type endpoint to charts

* Adding schema for get endpoint

* Removing imports, updating docstring, fixing typo

Just some small changes as described in the title.  I've updated the
test.py as well so it functions with the endpoint changes.

* Adding translation dict

* Fixing ops

* Adding check for list

* Modifying changes to add quotes where needed

Also changed BusinessTypeResponse to resp.

* Adding in some code to call the filter config

If a column starts with "cidr_" it will call the code in config.py to
try to translate the filter.  Nothing is changed in the JSON being
executed, just some information is dumped to console.

* Porting Ryan's changes

* Adding migration script (as per Ryan's PR)

* Fixing typo

* Prettier fixes

* [CLDN-1043] Adding rough version of filter changes for business types

* fix down migration

* Fixing bugs after merge

* adding functionality to appy filters in back end

* Fixing linting issues

* fix down revision

* Changing conversion callback to handle multiple values at once

* Adding string representation of values

* Code cleanup plus fixing debouce to only be called once for each entry

* Removing non needed logginh

* Changing operator list to use sting values

* Using text value operators

* Removing clear operator call

* Moving business type endpoints

* fix down revision

* Adding port functions

* update migration

* fix bad rebase and add ff

* implement validator

* dont add invalid values to response

* [CLDN-1205] Added a new exception type for a business type translation error. Added the error message in the display_value field within the business type response. Modified the IP and Port business types to populate the error message field in the response if an error occurs

* [CLDN-1205] Added meaningful error message for port translation errors

* Removing status field from businesstype Response and adding in error message

* [CLDN-1205] Added check to make sure the port business type is within the valid range of ports, if it is not, it will populate the error message

* [CLDN-1205] Fixed the if statement that checks to see if the string_value is in the valid range of port numbers. It did not corrently verify this before now.

* [CLDN-1205] Fixed an error where it was trying to use string_value in <= statements. I just casted string_value to an integer if it is numeric, which allows <= operators to be used on it

* [CLDN-1207] Added unit tests for the cidr_func and port_translation_func functions which are located in /superset/config.py

* [CLDN-1207] removed the assertRaises line as it does not work with the cidr_func and port_translation_func functions

* [CLDN-1207] Added the skeleton of the test_cidr_translate_filter_func unit test, still need to update what the expected response from the function will be.

* [CLDN-1207] Added the remainder of the back-end unit tests for the business types

* [CLDN-1207] Fixed the syntax error which caused the test_cidr_translate_filter_func_NOT_IN_double unit test to fail

* [CLDN-1207] Removed the logging that was added for debugging purposes

* [CLDN-1207] Formatted the commands_tests.py file to make it nicer to look at/read through

* [CLDN-1207] Fixed the code so that it conformed to the pylint requirements (i.e., pylint no longer complains about the code in commands_tests.py)

* [CLDN-1207] Modified some of the docstrings so they made better use of the 100 character per line, line limit

* [CLDN-1207] Added the beginnings of the unit tests for the
business types API

* [CLDN-1207] Added a comment to the top of the commands_tests.py file explaining how to run the unit tests. This prevents the next person who tries to run them from having to waste time trying the different forms of testing that Superset supports (e.g., pytest, tox, etc.)

* [CLDN-1207] Added a grammar fix to the comments describing how to run the unit tests

* [CLDN-1207] Modified the description of the business_type API endpoints as they did not represent what the API was actually doing

* [CLDN-1207] Added further instructions on how to run the unit tests that are within the business_type/api_tests.py file

* add request validation

* disable request if business type missing

* [CLDN-1207] Unit tests for the business type API are now working, however, they need to be modified to make use of @mock as we don't want to have to run the server to be able to run the unit tests

* Removing businesss types deffinitons from config

* Adding select to only show valid business types

* Fixed Enzyme tests

* Added scalfolding for selecting filter dropdown

* Adding intigration tests

* fix revision

* fix typos and unnecessary requests

* break out useBusinessTypes

* Added front-end RTL unit tests for the business type API endpoint

* Fixed error from unit tests

* Added a unit test to ensure the operator list is updated after a business type API response is received

* Removing elect compoenet for business types

* Adding feature flag and allowing saving when no business type present

* fixing useEffect hooks

* Adding feature flag to model

* Changing behavior such that an empty string returns a default response

* add form validation

* Modified comments in unit test as command to run test has changed

* Modified comments in unit test as filename to run test has changed

* Modified the api_tests.py file to conform to the linting requirements

* Changed the name of one of the tests to reflect what the test is actually testing

* Added cypress back to the package.json

* Added informative comments

* Updated comments in files as well as removed imports which were not being used

* Changes made by npm run prettier

* Fixed spelling mistakes

* Updated models.py to remove placeholder comments used in development

* Added feature flag mocking in unit test

* Fixing open api failure

* Fixing business types to pass unit tests

* Reverting unsafe connections back to false

* Removing print statement

* Adding business tpye to export test

* setting default feature flag to false for business type

* Reverting pre commit

* Reverting pre commit and running pre commit

* Reverting pre commit and running pre commit

* Fixing formatting

* Adding license

* Fixing Linting

* Protecting api enpoints

* updating model

* Fixing code path when business type exists

* Linting

* Linting

* Fixing linting

* Fixing spelling

* Fixing schemas

* Fixing app import

* fixing item render

* Added RTL test to make sure business type operator list is updated after API response

* Fixing linting

* fix migration

* Changing unit tests

* Fixing import and DB migration after rebase

* Renaming to advanced types

* Fixing Linting

* More renaming

* Removing uneeded change

* Fixing linting and test errors

* Removing unused imports

* linting

* Adding more detailed name for migration

* Moving files to plugins

* more renaming

* Fixing schema name

* Disabling feature flag that should not be enabled by default

* Adding extra cehck

* NameChange

* formatting

* Fixing equals check

* Moveing all advanced type classes and types to one file, and converting tests to functional

* Adding advanced type to test and fix linitng

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Dan Parent <daniel.parent@cse-cst.gc.ca>
Co-authored-by: GITHUB_USERNAME <EMAIL>
Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com>
2022-05-16 17:58:21 +03:00
Stephen Liu
9854d2d0e8
feat(plugin-chart-echarts): support horizontal bar chart (#19918)
* feat(plugin-chart-echarts): support horizontal bar chart

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* improve controlpanel

* default value

* fix ut

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-05-16 21:48:36 +08:00
Ville Brofeldt
d5802f7896
fix(generic-axes): apply contribution before flatten (#20077) 2022-05-16 16:26:31 +03:00
smileydev
1c3c3ae2ea
fix(CRUD): make to fix the dancing when crud view is on hover (#20051)
* fix(CRUD): make to fix the dancing when crud view is on hover

* fix(CRUD): make to restore font size property
2022-05-15 21:51:57 -06:00
smileydev
f43dbc0dfd
fix(chart & gallery): make to add mixed time-series into recommended charts (#20064) 2022-05-14 11:20:49 +08:00
Jesse Yang
6139057dcf
test: make tabbed dashboard a little more complex (#19966) 2022-05-13 17:31:23 -07:00
Diego Medina
c6dd7fedbd
fix: The dynamic form to connect to Snowflake DB is not returning any errors (#20013)
* fix: The dynamic form to connect to Snowflake DB is not returning any errors

* PR comment
2022-05-13 12:50:11 -06:00
Diego Medina
dbc653d442
feat: Explore popovers should close on escape (#19902)
* feat: Explore popovers should close on escape

* review comments
2022-05-13 12:28:39 -06:00
Kamil Gabryjelski
3043a54bfc
feat(dashboard): Rearrange items in chart header controls dropdown (#20049)
* feat(dashboard): Rearrange items in chart header controls dropdown

* Fix download as image and tests
2022-05-13 19:07:19 +02:00
Kamil Gabryjelski
0f68deedf1
perf(plugin-chart-table): Add memoization to avoid rerenders (#19976)
* perf(plugin-chart-table): Add memoization to avoid rerenders

* Fix typing
2022-05-13 18:10:48 +02:00
Stephen Liu
35e6e2709c
fix(plugin-chart-echarts): tooltip of big number truncated at then bottom (#20029) 2022-05-13 22:51:42 +08:00
Stephen Liu
e625c03cd5
feat(viz-gallery): add search weight for viz-name (#19581) 2022-05-13 22:51:01 +08:00
Kamil Gabryjelski
1cd002e801
chore: Create a generic header component for Explore and Dashboard (#20044)
* chore: Create a generic header component for Explore and Dashboard

* Add tests

* Fix undefined error

* Remove duplicate code

* Fix cypress test
2022-05-13 15:36:18 +02:00
Ville Brofeldt
b53daa91ec
fix(plugin-chart-echarts): support adhoc x-axis (#20055)
* fix(plugin-chart-echarts): support adhoc x-axis

* simplify code
2022-05-13 16:29:51 +03:00
Michael S. Molina
fff9ad05d4
fix: Fixes Tabs style (#20050) 2022-05-12 16:49:51 -03:00
Michael S. Molina
a051d91493
chore: Changes the no-literal-colors lint rule to throw errors instead of warnings (#20034) 2022-05-12 15:07:56 -03:00
smileydev
ded9122ceb
fix(homepage): make to show indicator when tab is choosen (#20048) 2022-05-12 11:17:49 -06:00
Michael S. Molina
c4c714fffb
chore: Removes hard-coded colors from the plugins - iteration 2 (#20006)
* chore: Removes hard-coded colors from the plugins - iteration 2

* Fixes lint errors
2022-05-12 10:12:17 -03:00
Kamil Gabryjelski
ca9766c109
feat(explore): Show confirmation modal if user exits Explore without saving changes (#19993)
* feat(explore): Show confirmation modal if user exits Explore without saving changes

* Fix calling cleanup func unnecessarily

* Fix comparing AdhocMetric instance with JSON object

* Replace sliceFormData with the initial form data
2022-05-12 12:24:29 +02:00
smileydev
26c81a70e7
fix(chart & filters): make to padding between textarea and buttons (#20026)
* fix(chart & filters): make to padding between textarea and buttons

* fix(chart & filters): make to change static pixel to them.gridUnit

* fix(chart & filters): make to fix lint issue
2022-05-12 15:54:21 +08:00
Evan Rusackas
60188ef654
feat(css): adds chartId-based class to dashboard chart holder (#19873)
* feat: adds `chartId`-based class to dashboard chart holder

* Adding comment to denote the purpose of the class in the code.
2022-05-11 15:44:37 -06:00
Lily Kuang
3e36d4a0a1
fix(embedded): third party cookies (#20019)
* debugging

* logging

* add comment

* remove logging

* Update superset-frontend/packages/superset-ui-core/src/connection/callApi/callApi.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-05-11 14:42:46 -07:00
AAfghahi
fd611d7653
refactor: Refactor reports for Charts and Dashboards (#19130)
* bumping shillelagh

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* Preset io ch28954 refactor reports (#19129)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* refactoring reports

* ready for review

* added testing

* removed user reducer

* elizabeth suggestions

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

* deleted additional folder

* fixing tests

* all but styling

* bumping shillelagh

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* Preset io ch28954 refactor reports (#19129)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* refactoring reports

* ready for review

* added testing

* removed user reducer

* elizabeth suggestions

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

* deleted additional folder

* fixing tests

* all but styling

* fixed tests

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-05-11 14:19:51 -04:00
Michael S. Molina
8bb8b7f612
chore: Removes hard-coded colors - iteration 3 (#20016) 2022-05-11 15:02:13 -03:00
Etienne Baratte
2e31021ecd
fix: fix word cloud randomness (#19977) 2022-05-11 22:56:09 +08:00
Michael S. Molina
a7e3d6b964
chore: Upgrades Storybook from 6.4.19 to 6.4.22 (#20008) 2022-05-11 10:09:03 -03:00
Diego Medina
cede148d46
fix: native filter truncation rerendering loop on hover (#20021) 2022-05-11 09:37:43 +02:00
Diego Medina
cc026e9fec
fix: URI form is blank when trying to connect from sql lab (#20004) 2022-05-11 08:57:11 +08:00
Daniel Vaz Gaspar
87a4379d0a
feat: deprecate /superset/validate_sql_json migrate to api v1 (#19935)
* feat: deprecate /superset/validate_sql_json migrate to api v1

* use new error handling

* migrate SQLLAb frontend and add tests

* debug test

* debug test

* fix frontend test on sqllab

* fix tests

* fix frontend test on sqllab

* fix tests

* fix tests

* fix tests

* fix tests
2022-05-10 21:25:39 +01:00
Smart-Codi
9376940282
fix: Table chart column config issue (#19841)
* Fix table chart column config issue

* resolve comment
2022-05-10 14:22:48 -06:00
Luis Casillas
35db7fb6c5
fix: Making chart update more truthful (#19877)
* Update index.jsx

* Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx

Fixing case

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-05-10 14:20:56 -06:00
Michael S. Molina
b7cff8335b
chore: Removes hard-coded colors from the plugins - iteration 1 (#19923)
* chore: Removes hard-coded colors from the plugins - iteration 1

* Fixes lint errors

* Fixes tests
2022-05-09 10:44:13 -03:00
Geido
d0b8b1e97d
feat: Applitools Cypress workflow (#19956)
* WIP

* Attempt Github Actions integration

* Add completion notification to workflow

* Update env

* Add new line

* Add license

* Fix whitespaces

* Fix Yaml indentation

* Fix afterEach

* Add initial tests

* Update config

* Use test secret

* Clean up

* Add batchName

* Disable logs - add secret

* Create separate workflow

* Clean up

* Update workflow

* Exclude applitools tests

* Update jobs name

* Run applitools tests separetely

* Fix path pattern

* Run once

* Add more initial tests

* Enhance tests

* Add dashboard edit mode test

* Move env

* Exclude applitools from sqllab test run

* Attempt pull_request_target

* Catch Applitools failures

* Clean up tests

* Add test step

* Add test step

* Remove step

* Fix SqlLab test

* Update CURL request

* Fix Yaml

* Add empty data to batch completion
2022-05-09 15:42:20 +02:00
Geido
c3ba86ecc5
feat: Run Applitools on public Storybook (#19852)
* Test storybook workflow

* Add test workflow

* Fix eof

* Update workflow

* Install apt dependencies

* Schedule nightly

* Enhance workflow

* Add secret Applitools key

* Update config

* Add batchName
2022-05-09 14:17:22 +02:00
Ville Brofeldt
f144de4ee2
Revert "chore(deps): bump d3-svg-legend in /superset-frontend (#19846)" (#19972)
This reverts commit 528a9cd7c7.
2022-05-06 13:11:41 +03:00
Diego Medina
7b5ba39029
fix: Fix auto-reversion of label/title in the Metrics popover (#19889) 2022-05-05 22:30:33 -06:00
Smart-Codi
0eb519c70b
add cy test for downloading chart as image (#19963) 2022-05-05 17:39:14 -06:00
Jesse Yang
54bfd8375a
chore: convert URLShortLinkButton to typescript (#19954) 2022-05-05 13:36:37 -07:00
Luis Casillas
7c3fd06fd6
style approach (#19903) 2022-05-05 14:29:09 -06:00
Jesse Yang
7b88ec7e25
refactor(ReportModal): simplify state reducer and improve error handling (#19942) 2022-05-05 10:06:40 -07:00
smileydev
902ac05372
fix(chart & table): make to allow highlight in case of numeric column (#19938)
* fix(chart & table): make to allow highlight in case of numeric column

* fix(chart & table): make to use emitFilter directly

* fix(chart & table): make to use styled component instead of inline style
2022-05-04 14:20:57 -06:00
Elizabeth Thompson
060b5c0e17
chore: remove druid datasource from the config (#19770)
* remove druid datasource from the config

* remove config related references to DruidDatasource

* Update __init__.py

* Update __init__.py

* Update manager.py

* remove config related references to DruidDatasource

* raise if instance type is not valid
2022-05-04 12:48:48 -07:00
cccs-Dustin
7d3437a98e
Modified the markdown component so that the inner column's handle's mouse target is larger (#19839) 2022-05-04 12:29:49 -07:00
Daniel Vaz Gaspar
4fdf230a56
feat: deprecate /superset/extra_table_metadata migrate to api v1 (#19921)
* feat: deprecate /superset/extra_table_metadata migrate to api v1

* use can_read to table_extra_metadata

* troubleshoot sqlite

* fix test

* fix test

* fix test

* fix frontend test on sqllab
2022-05-04 14:55:52 +01:00
Michael S. Molina
e9032e95ec
chore: Adds theme object to chart properties (#19951) 2022-05-04 09:55:22 -03:00
Yongjie Zhao
24e4ab6a1f
fix: can not correctly set force in store (#19932)
* fix: can not correctly set force in store

* fix ut
2022-05-03 14:37:36 -06:00
David Aaron Suddjian
7f8279b4b3
chore: get embedded user with roles and permissions (#19813)
* feat: get user roles endpoint

* add tests

* fix test

* get user with permission and roles with full user

* frontend

* type juggling

* the hash slinging slasher

* user reducer and action

* make it happy

* result

* lint

Co-authored-by: Lily Kuang <lily@preset.io>
2022-05-03 12:58:06 -07:00
Michael S. Molina
7657e42cff
chore: Adds a storybook to FilterableTable (#19897) 2022-05-03 15:08:10 -03:00
smileydev
7b3d0f040b
feat(chart & legend): make to enable show legend by default (#19927) 2022-05-02 14:37:11 -06:00
Luis Casillas
1fa841ee29
Revert "fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode (#19362)" (#19906)
This reverts commit 6d5d03e592.
2022-05-02 11:45:43 -06:00
dependabot[bot]
6bd025d8d2
chore(deps): bump react-virtualized-auto-sizer in /superset-frontend (#19916)
Bumps [react-virtualized-auto-sizer](https://github.com/bvaughn/react-virtualized-auto-sizer) from 1.0.2 to 1.0.6.
- [Release notes](https://github.com/bvaughn/react-virtualized-auto-sizer/releases)
- [Commits](https://github.com/bvaughn/react-virtualized-auto-sizer/commits)

---
updated-dependencies:
- dependency-name: react-virtualized-auto-sizer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-02 11:24:49 -06:00
smileydev
741033e87d
fix(column-header-tooltip): make that hide the tooltip when the cloum… (#18988)
* fix(column-header-tooltip): make that hide the tooltip when the cloumn header is turncated

* fix(column-header-tooltip): fix lint

* fix(column-header-tooltip): make to dynamic tooltip header in FilterTable

* fix(column-header-tooltip): make to fix the lint issue

* fix(column-header-tooltip): make to remove the tooltip option

* fix(column-header-tooltip): make to add test and storybook for dynamic tooltip

* fix(column-header-tooltip): make to fix lint
2022-05-02 10:11:27 -06:00
Daniel Vaz Gaspar
85b0ef8526
feat: deprecate old API on core superset fave_dashboards (#19754)
* feat: deprecate old API on core superset fave_dashboards

* fix js lint

* remove unused type
2022-05-02 16:24:48 +01:00
dependabot[bot]
b975eeee87
chore(deps-dev): bump eslint-plugin-prettier in /superset-frontend (#19894)
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 3.3.1 to 4.0.0.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-plugin-prettier/compare/v3.3.1...v4.0.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-29 16:20:53 -06:00
Hugh A. Miles II
8b15b68979
fix: Alpha should not be able to edit datasets that they don't own (#19854)
* fix api for checking owners

* fix styles for disabling

* fix styles for disabling

* fix lint

* fix lint

* add owners key

* plzz

* remove

* update test

* add tooltip

* add type

* fix test

* fix user reference

* lit

* fix test

* work
2022-04-29 14:21:05 -07:00
Smart-Codi
7cfd892bb9
fix: Set fixed maxWidth of the cron schedule modal (#19485)
* fix: Set fixed maxWidth of the cron schedule modal

* resolve comment

* resolve comment
2022-04-29 12:32:54 -06:00
Smart-Codi
c2999fdc22
fix: Chart download as image issue (#19885) 2022-04-29 12:23:54 -06:00
dependabot[bot]
9328053521
chore(deps-dev): bump @storybook/client-api in /superset-frontend (#19878)
Bumps [@storybook/client-api](https://github.com/storybookjs/storybook/tree/HEAD/lib/client-api) from 6.4.19 to 6.4.22.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.22/lib/client-api)

---
updated-dependencies:
- dependency-name: "@storybook/client-api"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-28 15:57:48 -06:00
smileydev
ea6753d27d
fix(allow-db-explore): make to check the allow virtual table explore option by default (#19883)
* fix(db & explore): make to check the allow-db-explore option by default

* fix(db-explore): make to remove console.log
2022-04-28 12:52:33 -07:00
Jinghuayao
ad1338fb47
test(native filter): refactor and add new test (#19821)
* refactor and add new test

* fix lint

* fix fail test

* fix front end error

* fix frontend error

* fix fail test for front end check

* add native filter helper

* more changes

* seperated test for different state

* seperated tests by initail state

* fix failure

* one more fix

* enable test
2022-04-28 09:41:22 -07:00
Stephen Liu
11562971fb
fix(plugin-chart-echarts): [feature parity] annotation line chart color not working (#19758) 2022-04-28 19:10:58 +03:00
Ville Brofeldt
d5ea537b0e
fix(plugin-chart-handlebars): fix overflow, debounce and control reset (#19879)
* fix(plugin-chart-handlebars): fix overflow

* add debounce, fix reset controls

* fix deps

* remove redundant code

* improve examples

* add last missing resetOnHides

* fix test

* use isPlainObject
2022-04-28 16:38:23 +03:00
Geido
1d50665da0
Remove font-size hacky usage (#19613) 2022-04-28 11:38:17 +02:00
Geido
0e68e42b7c
Remove hacky font-sizes (#19616) 2022-04-28 11:38:04 +02:00
Geido
ed1309e6bd
fix: Dates alignment in Table viz (#19668)
* Fix dates alignment

* Add package lock changes

* Update package-lock

* Clean up
2022-04-28 11:37:49 +02:00
Ville Brofeldt
3d2fec9604
chore: fix explore pills (#19866)
* chore: fix explore pills

* fix tests

* address comments

* add test and remove redundant div

* switch to dark text
2022-04-28 10:28:47 +03:00
Diego Medina
e4fca89217
fix: Cannot re-order metrics by drag and drop (#19876)
* fix: cannot-re-order-metrics-by-drag-and-drop

* add tests
2022-04-27 20:37:12 -06:00
smileydev
59ee029088
feature(filter): make to hide sort filter when time range (#19871) 2022-04-27 14:07:59 -06:00
smileydev
4a835a4299
fix(dashboard-css): make to load saved css template (#19840)
* fix(dashboard-css): make to load saved css template

* fix(dashboard-css): make to update state css with componentDidMount

* fix(dashobard-css): make to inject custom css after updateCss

* fix(dashboard-css): make to add RTL for custom css

* fix(dashboard-css): make to fix lint issue
2022-04-27 10:57:15 -06:00
Yongjie Zhao
f5e9f0eb3b
feat: add Advanced Analytics into mixed time series chart (#19851) 2022-04-27 23:36:19 +08:00
dependabot[bot]
795da71751
chore(deps): bump react-syntax-highlighter in /superset-frontend (#19864)
Bumps [react-syntax-highlighter](https://github.com/react-syntax-highlighter/react-syntax-highlighter) from 15.4.5 to 15.5.0.
- [Release notes](https://github.com/react-syntax-highlighter/react-syntax-highlighter/releases)
- [Changelog](https://github.com/react-syntax-highlighter/react-syntax-highlighter/blob/master/CHANGELOG.MD)
- [Commits](https://github.com/react-syntax-highlighter/react-syntax-highlighter/compare/v15.4.5...15.5.0)

---
updated-dependencies:
- dependency-name: react-syntax-highlighter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-27 08:19:34 -06:00
Stephen Liu
f9d28a1072
chore: add eslint custom plugin to prevent translation variables (#19828) 2022-04-27 17:44:13 +08:00
Erik Ritter
ad878b07e4
fix: Dashboard report creation error handling (#19859) 2022-04-26 21:52:58 -07:00
Erik Ritter
768e4b7a54
fix: Update eslint error message to reflect location of antd components (#19857) 2022-04-26 21:12:43 -07:00
Smart-Codi
60e06c1692
feat: Update ShortKey for stop query running in SqlLab editor (#19692)
* feat: Update shortkey for stop query running in sqllab editor

* resolve comment

* fix invalid import useMemo
2022-04-26 21:12:47 -06:00
smileydev
1d043e53d0
fix(db & connection): make to show/hide the password when only creating db connection (#19694)
* fix(db & connection): make to show/hide the password when only creating db connection

* fix(db & connection): make to fix unit test of Database Modal
2022-04-26 16:26:07 -06:00
Diego Medina
d65b77ec7d
fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options (#19778)
* fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options

* fix package.json

* fix lint
2022-04-26 16:25:40 -06:00
dependabot[bot]
dc0f09586f
chore(deps): bump react-split from 2.0.9 to 2.0.14 in /superset-frontend (#19845)
Bumps [react-split](https://github.com/nathancahill/split) from 2.0.9 to 2.0.14.
- [Release notes](https://github.com/nathancahill/split/releases)
- [Changelog](https://github.com/nathancahill/split/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nathancahill/split/commits)

---
updated-dependencies:
- dependency-name: react-split
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-26 14:20:38 -06:00
dependabot[bot]
528a9cd7c7
chore(deps): bump d3-svg-legend in /superset-frontend (#19846)
Bumps [d3-svg-legend](https://github.com/susielu/d3-legend) from 1.13.0 to 2.25.6.
- [Release notes](https://github.com/susielu/d3-legend/releases)
- [Commits](https://github.com/susielu/d3-legend/compare/v1.13.0...v2.25.6)

---
updated-dependencies:
- dependency-name: d3-svg-legend
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-26 14:20:19 -06:00
dependabot[bot]
5877470aee
chore(deps-dev): bump eslint-plugin-jsx-a11y in /superset-frontend (#19847)
Bumps [eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y) from 6.4.1 to 6.5.1.
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/CHANGELOG.md)
- [Commits](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/compare/v6.4.1...v6.5.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsx-a11y
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-26 14:19:40 -06:00
Diego Medina
7645eac31f
fix: Regression on Data and Alerts & Reports Headers (#19850) 2022-04-26 14:08:07 -06:00
Josh Soref
bebb10e495
chore(frontend-tests): Spelling (#19853)
* spelling: against

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: been

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: charts

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: clicking

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: columns

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: duplicate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: especially

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extensions

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fields

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: filter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: for

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: label

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: labeled

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: nativefilter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: registry

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: render

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: resizable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: response

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: successful

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: transform

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unfortunately

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: until

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: virtual

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: wrapper

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2022-04-26 10:35:01 -07:00
Josh Soref
c32c505742
chore(docs): Spelling (#19675)
* spelling: adding

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: aggregate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: avoid

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: blacklist

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cached

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: discontinue

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exhaustive

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: from

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: github

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: hybrid

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: implicit

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: interim

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: introduced

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: javascript

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: logstash

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: metadata

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: password

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: recommended

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: redshift

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: refactored

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: referencing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: sqlite

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: the

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: thumbnails

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: undoes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: very

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2022-04-26 13:17:15 -03:00
Yongjie Zhao
25e572a56e
fix: count(distinct column_name) in metrics (#19842) 2022-04-26 20:03:55 +08:00
Jeremy
e632b82395
feat: Adds plugin-chart-handlebars (#17903)
* adds: plugin chart handlebars

* adds: handlebars plugin to main presets

* update: npm install

* chore: lint

* adds: dateFormat handlebars helper

* deletes: unused props

* chore: linting plugin-chart-handlebars

* docs: chart-plugin-handlebars

* adds: moment to peer deps

* update: use error handling

* update: inline config, adds renderTrigger

* update: inline config, adds renderTrigger

* camelCase controls

* (plugins-chart-handlebars) adds: missing props

Adds missing propeties in test formData

* (plugin-chart-handlebars) fixes test

* (plugin-handlebars-chart) use numbers for size

* (feature-handlebars-chart) fix viz_type

* (plugin-handlebars-chart) revert

revert the viz_type change. it was in the wrong place.

* fix test and add license headers

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-04-26 14:34:28 +03:00
Ville Brofeldt
2dafff12ef
fix(explore): ignore temporary controls in altered pill (#19843) 2022-04-26 11:58:47 +03:00
dependabot[bot]
28742e5474
chore(deps-dev): bump babel-loader in /superset-frontend (#19829)
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.2.4 to 8.2.5.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel-loader/compare/v8.2.4...v8.2.5)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-25 12:27:21 -06:00
dependabot[bot]
69aeff911b
chore(deps): bump react-hot-loader in /superset-frontend (#19830)
Bumps [react-hot-loader](https://github.com/gaearon/react-hot-loader) from 4.12.20 to 4.13.0.
- [Release notes](https://github.com/gaearon/react-hot-loader/releases)
- [Changelog](https://github.com/gaearon/react-hot-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/gaearon/react-hot-loader/compare/v4.12.20...v4.13.0)

---
updated-dependencies:
- dependency-name: react-hot-loader
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-25 12:26:59 -06:00
dependabot[bot]
523bd8b79c
chore(deps-dev): bump babel-loader in /superset-frontend (#19403)
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.2.2 to 8.2.4.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel-loader/compare/v8.2.2...v8.2.4)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-24 22:53:52 -06:00
dependabot[bot]
fbedfa3838
chore(deps): bump moment from 2.29.1 to 2.29.2 in /superset-frontend (#19637)
Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.29.1...2.29.2)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-24 22:53:26 -06:00
dependabot[bot]
f8f057d7be
chore(deps): bump async in /superset-frontend/cypress-base (#19681)
Bumps [async](https://github.com/caolan/async) from 3.2.0 to 3.2.3.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/master/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v3.2.0...v3.2.3)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-24 22:53:04 -06:00
Diego Medina
800ced5e25
fix(sql lab): when editing a saved query, the status is lost when switching tabs (#19448) 2022-04-22 15:23:30 -06:00
Diego Medina
3f0413b8cb
fix: Cypress tests reliability improvements (#19800) 2022-04-22 14:57:25 -06:00
dependabot[bot]
0cc2d71d1a
chore(deps): bump url-parse from 1.5.7 to 1.5.10 in /superset-frontend (#19020)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-22 14:51:10 -06:00
dependabot[bot]
e98199d43d
chore(deps): bump @types/d3-time in /superset-frontend (#17978)
Bumps [@types/d3-time](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/d3-time) from 1.1.1 to 3.0.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/d3-time)

---
updated-dependencies:
- dependency-name: "@types/d3-time"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-22 14:50:43 -06:00
Phillip Kelley-Dotson
ad715429f9
chore: simplify error messaging in database modal (#19165)
* testing for dbconn modal error message

* remove consoles and error alert mapping

* lint fix

* update url message

* add modal fix

* update comments

* fix err msg bugs

* fix pylint

* fix line

* fix tests

* fix assertions
2022-04-21 12:44:21 -07:00
Kamil Gabryjelski
12bc30e2c7
Fix display of column config in table chart (#19806) 2022-04-21 19:08:04 +02:00
Yongjie Zhao
108a2a4eaf
fix: lost renameOperator in mixed timeseries chart (#19802) 2022-04-21 15:20:09 +08:00
smileydev
dfbaba97c6
fix(chart & explore): Show labels for SliderControl (#19765)
* fix(chart & explore): make to show label of slidercontrol

* fix(chart & explore): make to update SliderControl props

* fix(chart & explore): make to fix lint
2022-04-20 13:58:25 -06:00
Diego Medina
7f22edfd06
fix: remove & reimplement the tests for AlertReportCronScheduler component (#19288) 2022-04-20 13:51:09 -06:00
serenajiang
5e468f7a4c
fix(world-map): remove categorical color option (#19781) 2022-04-20 09:36:28 -07:00
Kamil Gabryjelski
fcc8080ff3
fix(plugin-chart-table): Resetting controls when switching query mode (#19792) 2022-04-20 17:25:31 +02:00
Stephen Liu
e3a54aa3c1
feat(explore): improve UI in the control panel (#19748)
* feat(explore): improve section header of control panel

* fix checkbox control color and radio button color
2022-04-20 15:06:33 +02:00
Yongjie Zhao
4f997cd9ac
chore: fix grammar error (#19740) 2022-04-20 21:02:14 +08:00
Yongjie Zhao
3c28cd4625
feat: add renameOperator (#19776) 2022-04-20 19:48:12 +08:00
Diego Medina
dfba9ea596
fix: SQL Lab UI Error: Objects are not valid as a React child (#19783) 2022-04-20 09:18:46 +03:00
Diego Medina
1c5d3b73df
fix: dashboard top level tabs edit (#19722) 2022-04-19 16:57:30 -06:00
Ville Brofeldt
e061955fd0
fix(dashboard): copy permalink to dashboard chart (#19772)
* fix(dashboard): copy permalink to dashboard chart

* lint

* address comments
2022-04-19 22:34:41 +03:00
Jesse Yang
4ba62cad95
chore(build): upgrade less-loader (#19703) 2022-04-19 09:18:16 -07:00
Kamil Gabryjelski
3663a33f14
fix(explore): Double divider if no permissions for adding reports (#19777) 2022-04-19 17:47:35 +02:00
Kamil Gabryjelski
6f4480a06c
feat(explore): Replace overlay with alert banner when chart controls change (#19696)
* Rename explore alert

* Rename refreshOverlayVisible to chartIsStale

* Implement banners

* Add tests

* Add clickable text to empty state

* Fix viz type switching

* styling changes

* Fixes after rebasing

* Code review fixes

* Fix bug

* Fix redundant refreshing
2022-04-19 14:57:06 +02:00
Kamil Gabryjelski
594523e895
feat(explore): Implement data panel redesign (#19751)
* feat(explore): Redesign of data panel

* Auto calculate chart panel height and width

* Add tests

* Fix e2e tests

* Increase collapsed data panel height
2022-04-19 10:10:40 +02:00
smileydev
34323f9b5f
fix(explore): make to show the null value as N/A in view result (#19603)
* fix(explore): make to show the null value as N/A in view result

* fix(explore): make to remove console

* fix(explore): make to remove console in Cell

* fix(explore): make to translate N/A
2022-04-18 19:26:15 -06:00
smileydev
a2d34ec4b8
fix(import): Add the error alert on failed database import (#19673)
* fix(import): make to add the error alert

* fix(import): make to add licence

* fix(import): make to create ErrorAlert component and use errorMessage spelling
2022-04-18 17:43:24 -06:00
Diego Medina
a05ff5e598
fix: alert/report created by filter inconsistency with table display (#19518)
* fix: alert/report created by filter inconsistency with table display

* Match column order to dashboard list
2022-04-18 17:41:07 -06:00
Phillip Kelley-Dotson
06ec88eb99
feat: add empty states to sqlab editor and select (#19598)
* feat: add empty states to sqlab editor and select

* add suggestions and test

* update type

* lint fix and add suggestions

* fix typo

* run lint

* remove unused code

* fix test

* remove redux for propagation and other suggestions

* add t

* lint

* fix text and remove code

* ts and fix t in p

* fix spelling

* remove unused prop

* add fn to prop change state

* remove unused code

* remove unused types

* update code and test

* fix lint

* fix ts

* update ts

* add type export and fix test

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* remove handlerror and unused code

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-04-15 15:09:07 -07:00
Diego Medina
154f1ea8c9
fix: Dashboard Edit View Tab Headers Hidden when Dashboard Name is Long (#19472) 2022-04-15 12:58:32 -06:00
Diego Medina
8d4a52c9d0
fix(sql lab): add quotes when autocompleting table names with spaces in the editor (#19311) 2022-04-15 12:55:04 -06:00
Diego Medina
bbe0af348b
fix(sql lab): Selecting edit on a query from query history doesn't update the SQL Editor properly (#19290) 2022-04-15 12:49:32 -06:00
Luis Casillas
56381f4ee8
fix: sql lab ctrl t behaved differently from clicking (#19420)
* initial approach

To have consistent behaviour when creating a new tab with ctrl+t

* consistent behaviour when creating tabs

* fixed bug and added tests

* updates to pass checks
2022-04-15 12:28:40 -06:00
Geido
b8e595413f
fix: Redirect to full url on 401 (#19357)
* Redirect to full url

* Redirect to full url

* Update test
2022-04-15 20:15:30 +02:00
Kamil Gabryjelski
b7759e6fd1
chore: Clean redundant dependency from useMemo dep array (#19732) 2022-04-15 14:56:34 +02:00
smileydev
c320c295dc
fix(dnd&column): make to fix the blank state issue when only one column select (#19651) 2022-04-15 13:43:25 +02:00
Smart-Codi
94075983f8
feat: Remove legacy sql alchemy db connection link from G Sheet connection (#19450)
* feat: Remove legacy sql alchemy db connection link from G Sheet connection

* resolve comment
2022-04-14 14:34:15 -06:00
Smart-Codi
ac2c66ccf6
fix: Line Chart Annotation Info Update (#19001)
* fix Line Chart Annotation Info Updage

* wrap annotation text with transation

* resolve comment
2022-04-14 10:46:32 -07:00
Evan Rusackas
34008f78c9
feat: Enabling source maps full time (#19710) 2022-04-14 09:08:11 -07:00
Michael S. Molina
7bc9123fe5
fix: Filter dependencies are not being applied in default values (#19698) 2022-04-14 12:58:34 -03:00
David Aaron Suddjian
4927685c30
feat: UI override registry (#19671)
* typed registry

* remove unintentional change

* lint

* fix
2022-04-14 08:44:26 -07:00
Yongjie Zhao
9425dd2cac
fix: drop the first level of MultiIndex (#19716) 2022-04-14 23:40:38 +08:00
Jesse Yang
32a9265cc0
fix(nav): infinite redirect and upload dataset nav permissions (#19708) 2022-04-13 23:29:56 -07:00
smileydev
68ed39bcd3
fix(alert & report): make to fix the issue when recreate report (#19419) 2022-04-13 11:02:33 -06:00
Smart-Codi
94e06c2b6a
fix: Reset sorting bar issue in Barchart (#19371)
* fix: Reset sorting bar issue in Barchart

* improving performance

* fix lint error
2022-04-13 11:00:15 -06:00
Diego Medina
d4e7c65f6a
fix(sql lab): replace the output column in the query history table (#19370)
* fix(sql lab): replace the output column in the query history table

* improvements
2022-04-13 10:22:03 -06:00
Kamil Gabryjelski
b81982d8f3
feat(explore): More explicit labels of adhoc filter operators (#19691) 2022-04-13 18:20:38 +02:00
Diego Medina
6d5d03e592
fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode (#19362)
* fix(sql lab): display the 'View Results' button in the history tab when running sync queries

* pr comment
2022-04-13 10:20:32 -06:00
Kamil Gabryjelski
c8304a2821
feat(explore): Redesign of Run/Save buttons (#19558)
* feat(explore): Move save button to header, run button to bottom of control panel

* Make the tabs sticky

* Add error icon to Data tab

* Show message when creating chart and all controls are filled correctly

* Add tests and storybook

* Fix tests

* Disable save button when control have errors

* Fix types

* Apply code review comments

* Replace styled with css

* Remove unused import
2022-04-13 16:58:39 +02:00
Diego Medina
32239b04aa
fix: improve the alerts & reports modal layout on small screens (#19294) 2022-04-13 08:45:38 -06:00
Diego Medina
26a0f05759
fix(sql lab): table selector should display all the selected tables (#19257)
* fix: table Selector should clear once selected

* Multi select

* Add tests

* refactor

* PR comments
2022-04-13 08:42:12 -06:00
Kamil Gabryjelski
de9fb2109d
chore(explore): Change labels "Group by"/"Series" to "Dimensions" (#19647) 2022-04-13 15:16:03 +02:00
Ville Brofeldt
2ba484fe43
fix: login button does not render (#19685)
* fix: login button does not render

* add type guard
2022-04-13 16:04:04 +03:00
Stephen Liu
059cb4ec25
fix(plugin-chart-echarts): xAxis scale is not correct when setting quarter time grain (#19686) 2022-04-13 20:48:13 +08:00
Kamil Gabryjelski
ee85466f2e
fix(dashboard): Fix BigNumber causing dashboard to crash when overflowing (#19688)
* fix(dashboard): fix(plugin-chart-echarts): Fix BigNumber causing dashboard to crash when overflowing

* Add tooltips for truncated titles

* Fix type
2022-04-13 14:22:46 +02:00
Kamil Gabryjelski
4a5dddf52d
fix(explore): Change copy of cross filters checkbox (#19646) 2022-04-13 13:19:02 +02:00
dependabot[bot]
6e8e29ce53
chore(deps): bump urijs from 1.19.8 to 1.19.11 in /superset-frontend (#19679)
Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.8 to 1.19.11.
- [Release notes](https://github.com/medialize/URI.js/releases)
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md)
- [Commits](https://github.com/medialize/URI.js/compare/v1.19.8...v1.19.11)

---
updated-dependencies:
- dependency-name: urijs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 23:23:58 -06:00
Geido
59dda1fa05
fix: Navbar styles and Welcome page text (#19586)
* Enhance navbar styles

* Clean up style
2022-04-12 18:41:00 +03:00
Geido
6a3220f905
Remove TwoTone icons (#19666) 2022-04-12 17:33:12 +03:00
Geido
7b0b029318
chore: Remove wrong usage of font-size in ExploreViewContainer (#19614)
* Remove hacky usage of font-size

* Update font
2022-04-12 16:10:58 +03:00
Ville Brofeldt
87d47987b7
fix(sql-lab): do not replace undefined schema with empty object (#19664) 2022-04-12 15:13:03 +03:00
Diego Medina
955413539b
fix: Table Autosizing Has Unnecessary Scroll Bars (#19628) 2022-04-11 15:20:41 -06:00
smileydev
d8b9e72682
make to change the getBreakPoints of polygon chart (#19573) 2022-04-11 15:20:20 -06:00
AAfghahi
4bf4d58423
fix: update Permissions for right nav (#19051)
* draft pr

* finished styling

* add filter

* added testing

* added tests

* added permissions tests

* Empty-Commit

* new test

* Update superset-frontend/src/views/components/MenuRight.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* revisions

* added to CRUD view

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-04-11 16:50:59 -04:00
Geido
d693f4e970
Update font-sizes (#19593) 2022-04-11 16:46:06 +03:00
Geido
5d418b21a3
Remove font-size hacky usage (#19611) 2022-04-11 16:45:52 +03:00
Geido
d1e17646e2
Remove hacky usage of font-size (#19615) 2022-04-11 16:45:25 +03:00
Geido
03a80d5d2f
chore: Update font-sizes in QueryPreviewModal (#19620)
* Remove hacky font-sizes

* Remove hacky font-size SavedQueryPreviewModal
2022-04-11 16:45:09 +03:00
Stephen Liu
d49fd01ff3
feat(CRUD): add new empty state (#19310)
* feat(CRUD): add new empty state

* fix ci

* add svg license
2022-04-11 12:04:45 +02:00
Ville Brofeldt
f21ba68a30
chore: clean up dynamic translation strings (#19641) 2022-04-11 13:02:20 +03:00
Stephen Liu
a6bf041edd
feat(plugin-chart-echarts): add aggregate total for the Pie/Donuct chart (#19622) 2022-04-11 13:56:45 +08:00
Lyndsi Kay Williams
d52e3867ac
feat: Move Database Import option into DB Connection modal (#19314)
* rebase

* more progress

* Fix unintended changes

* DB import goes to step 3

* debugging

* DB list refreshing properly

* import screens flowing properly

* Code cleanup

* Fixed back button on import flow

* Remove import db tooltip test

* Fix test

* Password field resets properly

* Changed import modal state dictators and removed unneeded comment

* Removed unneeded param pass and corrected modal spelling

* Fixed typos

* Changed file to fileList

* Clarified import footer comment

* Cleaned passwordNeededField and confirmOverwriteField state checks

* debugging

* Import state flow fixed

* Removed unneeded importModal check in unreachable area

* Fixed import db footer behavior when pressing back on step 2

* Import db button now at 14px

* Removed animation from import db button

* Fixed doble-loading successToast

* Fixed errored import behavior

* Updated import password check info box text

* Connect button disables while importing db is loading

* Connect button disables while overwrite confirmation is still needed

* Connect button disables while password confirmation is still needed

* Removed gray line under upload filename

* Hide trashcan icon on import filename

* Modal scroll behavior fixed for importing filename

* Changed errored to failed

* RTL testing for db import
2022-04-08 10:03:40 -07:00
Ville Brofeldt
1ad82af058
fix(select): render when empty multiselect (#19612)
* fix(select): render when empty multiselect

* disable flaky test
2022-04-08 16:40:14 +03:00
Geido
16f193c813
Catch colors when theme top level (#19571) 2022-04-08 15:20:23 +03:00
Yongjie Zhao
761d5c4208
chore: cleanup as unknown conversion (#19587) 2022-04-08 17:32:29 +08:00
Daniel Vaz Gaspar
d6d2777ada
feat: deprecate old API and create new API for dashes created by me (#19434)
* feat: deprecate old API and create new API for dashes created by me

* add tests

* fix previous test

* fix test and lint

* fix sqlite test

* fix lint

* fix lint

* lint

* fix tests

* fix tests

* use dashboards get list instead

* clean unnecessary marshmallow schema

* Update superset/views/core.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* lint

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-04-08 09:05:22 +01:00
Phillip Kelley-Dotson
44e3103fc9
feat: add success toast to alerts and reports (#19482)
* feat: add success toast to alerts and reports

* remove console

* add suggestions
2022-04-07 18:45:35 -07:00
Michael S. Molina
d511e4fbc4
refactor: Removes the CSS files from the Horizon plugin (#19562)
* refactor: Removes the CSS files from the Horizon plugin

* Removes the CSS file

* Uses font-size from the theme
2022-04-07 18:47:41 -03:00
Michael S. Molina
f91f83d011
refactor: Removes the CSS files from the Paired T-Test plugin (#19563)
* refactor: Removes the CSS files from the Paired T Test plugin

* Adjusts some colors
2022-04-07 11:51:22 -03:00
Michael S. Molina
38fbca10e3
refactor: Removes the CSS files from the Parallel Coordinates plugin (#19539)
* refactor: Removes the CSS files from the Parallel Coordinates plugin

* Adds test

* Fixes indentation
2022-04-07 11:51:08 -03:00
Michael S. Molina
97850a80c8
refactor: Removes the CSS files from the Partition plugin (#19521)
* refactor: Removes the CSS files from the Partition plugin

* Fixes bullet

* Always use the color of the partitions
2022-04-07 11:50:51 -03:00
Michael S. Molina
06dee825a4
chore: Removes hard-coded colors from legacy-plugin-chart-sankey (#19493)
* chore: Removes hard-coded colors from legacy-plugin-chart-sankey

* Gets opacity from the theme
2022-04-07 11:50:31 -03:00
Geido
6d5771af34
chore: Remove FilterBox.less (#19462)
* Remove FilterBox less

* Fix test

* Add theme top level

* Use styledMount
2022-04-07 17:17:50 +03:00
Geido
e8f3e8a24e
chore: Remove crud.less from Datasource (#19438)
* Remove crud less

* Remove unused classname

* Remove unused import

* Add theme top level
2022-04-07 15:18:01 +03:00
Geido
e5bab00cb9
chore: Enhance ReactChord style with theme vars (#19517)
* Enhance style with theme vars

* Update superset-frontend/plugins/legacy-plugin-chart-chord/src/ReactChord.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-04-07 15:17:40 +03:00
Ville Brofeldt
db2135109a
fix(dataset): avoid crash if database missing (#19582) 2022-04-07 13:43:17 +03:00
Geido
73e93911ac
chore: Remove TimeTable.less (#19463)
* Remove TimeTable less

* Remove className

* Update superset-frontend/src/visualizations/TimeTable/TimeTable.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-04-06 18:43:25 +03:00
Smart-Codi
f6d550b7fc
fix: weight tooltip issue (#19397)
* fix: weight tooltip issue

* remove console
2022-04-06 09:28:24 -06:00
dependabot[bot]
f29d92867c
chore(deps): bump minimist in /superset-frontend/cypress-base (#19549)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-06 17:41:11 +03:00
Diego Medina
c6c9188a24
fix(sql lab): increase the size of the action icons in the history tab (#19313) 2022-04-06 08:21:07 -06:00
Stephen Liu
0e29871493
fix(explore): clean data when hidding control (#19039) 2022-04-06 20:25:32 +08:00
Yongjie Zhao
2daa071633
fix: big number with trendline can't calculate cumsum (#19542) 2022-04-06 19:23:01 +08:00
Michael S. Molina
c4baa826d5
refactor: Removes the CSS files from the Country Map plugin (#19538) 2022-04-06 07:39:16 -03:00
Michael S. Molina
356a03833b
chore: Removes hard-coded opacity and spacing from BigNumber (#19536) 2022-04-06 07:38:33 -03:00
Michael S. Molina
6fa99d6b07
refactor: Removes the CSS files from the Sankey Loop plugin (#19494)
* refactor: Removes the CSS files from the Sankey Loop plugin

* Gets opacity from the theme
2022-04-06 07:37:56 -03:00
Ville Brofeldt
2d81c4c79f
fix(sqllab): null database with backend persistence (#19548) 2022-04-06 12:32:41 +03:00
Geido
2de5e6fac4
chore: Remove Legacy Force Directed viz plugin (#19492)
* Add theme vars

* Remove plugin
2022-04-06 11:51:51 +03:00
Smart-Codi
156ac7dd79
fix: Error Message is cut off in alerts & reports log page (#19444) 2022-04-05 23:19:45 -06:00
Kamil Gabryjelski
bb96029c9d
fix(explore): Chart header icon paddings (#19534) 2022-04-06 06:50:16 +02:00
Diego Medina
c5b0dc3ea6
fix: native filter dropdown not attached to parent node (#19399) 2022-04-05 22:11:56 -06:00
Smart-Codi
e118b4d733
fix: Dashboard import holding issue (#19112)
* fix dashboard import holding issue

* resolve comment
2022-04-05 21:43:47 -06:00
Smart-Codi
a88fa8910d
fix: Clean up custom css when dashboard unmounted (#19342)
* clean up custom css when dashboard unmounted

* resolve comment
2022-04-05 15:20:31 -06:00
Diego Medina
634693b270
fix: Dynamic form to connect to Snowflake DB is not displaying authentication errors (#19491)
* fix: Dynamic form to connect to Snowflake DB is not displaying authentication errors

* pr comments
2022-04-05 13:11:33 -06:00
Geido
1521ab3b6f
chore(Explore): Change text when saving a chart in a new dashboard (#19467)
* Change text when new dashboard

* Test buttons behavior
2022-04-05 22:05:05 +03:00
Geido
a59718b094
Remove Control less (#19415) 2022-04-05 20:05:09 +03:00
Geido
e391a83947
Remove unused less (#19413) 2022-04-05 20:04:47 +03:00
Kamil Gabryjelski
03d3eaacaf
feat(explore): Move timer, row counter and cached pills to chart container (#19458)
* feat(explore): Move timer, row counter and cached pills to chart container

* Hide pills in standalone mode

* Take pills out of chart-container
2022-04-05 18:03:23 +02:00
Roman Pridybailo
cccec9a6ab
fix: Correct Ukraine map (#19528)
* Crimea

* Update ukraine.geojson

Co-authored-by: Roman Pridybailo <rp@vaix.ai>
2022-04-05 18:46:12 +03:00
Kamil Gabryjelski
602afbaa31
feat(explore): Move chart header to top of the page (#19529)
* Move chart header to top of the page

* Implement truncating and dynamic input

* fix typing

* Prevent cmd+z undoing changes when not in edit mode

* Fix tests, add missing types

* Show changed title in altered
2022-04-05 15:20:29 +02:00
Hugh A. Miles II
c2fae82fa6
fix key reference (#19519) 2022-04-04 14:19:46 -04:00
Michael S. Molina
82a653f64b
refactor: Removes the CSS files from the Treemap plugin (#19486) 2022-04-04 13:46:46 -03:00
Michael S. Molina
47308024a3
refactor: Removes the CSS files from the Sunburst plugin (#19488) 2022-04-04 13:46:34 -03:00
Geido
4b922873ae
Add theme color (#19490) 2022-04-04 17:19:54 +03:00
Geido
7914296d8a
chore: Remove FilterbaleTableStyles.less (#19442)
* Remove FilterbaleTablesStyles less

* Add theme top level
2022-04-04 17:11:22 +03:00
Geido
b601db7809
chore: Remove StyledQueryButton.less (#19441)
* Remove StyledQueryButton less

* Remove unused className
2022-04-04 17:10:20 +03:00
dudasaron
b8891acf4a
fix(dashboard list): do not show favorite star for anonymous users #18210 (#19409)
* fix: Only show favorite star on dashboard list if user is logged in #18210

* Fix linter errors
2022-04-04 10:38:44 +03:00
smileydev
5db36ec81c
fix(sqllab): make to hide the delete button of most recent query history (#19358) 2022-04-03 19:59:38 -06:00
Kamil Gabryjelski
60dcd651f4
feat(explore): SQL popover in datasource panel (#19308)
* feat(explore): SQL popover in datasource panel

* Fix acequire not defined

* Rebase and fix tests

* Disable highlighting gutter

* Use ace-build acequire instead of brace
2022-04-03 13:26:56 +02:00
Michael S. Molina
5fed10dae2
refactor: Removes the CSS files from the Rose plugin (#19473) 2022-04-01 13:13:43 -03:00
Michael S. Molina
7594a02d42
chore: Removes hard-coded colors from legacy-plugin-chart-world-map (#19466) 2022-04-01 13:13:33 -03:00
Michael S. Molina
8cd03181ac
refactor: Removes the CSS files from the DeckGL plugin (#19465) 2022-04-01 13:13:16 -03:00
Stephen Liu
90c9daea08
feat(color): support analogous colors to prevent color conflict (#19325)
* feat(color): support analogous colors

* fix test

* fix range

* add some comment
2022-04-01 18:42:30 +03:00
Geido
08aca83f6c
chore: Remove index.less from showSavedQuery (#19440)
* Remove index less

* Revert change
2022-04-01 17:57:36 +03:00
Kamil Gabryjelski
fc8cb22376
feat(dashboard): Implement empty states for empty tabs (#19408)
* feat(dashboard): Implement empty states in empty tabs

* Change button to in text link

* Add edit dashboard button to dashboard empty state

* Add tests

* Fix test
2022-04-01 15:23:00 +02:00
Ville Brofeldt
11bf0d09cb
chore(plugin-chart-echarts): upgrade echarts 5.3.2 (#19481) 2022-04-01 13:05:03 +03:00
Yongjie Zhao
d954c3df86
fix: can't sync temporal flag on virtual table (#19366) 2022-04-01 16:40:50 +08:00
Ville Brofeldt
d684ad073d
fix: request samples with default row limit (#19456)
* fix: request samples with default row limit

* lodashLint

* fix cypress test
2022-04-01 11:32:36 +03:00
Jinghuayao
2a75e4c3c3
test(native filter): add new test for dependent filter (#19392)
* add new test for dependent filter
2022-04-01 01:06:48 -07:00
Diego Medina
eab9388f7c
feat(sql lab): enable ACE editor search in SQL editors (#19328) 2022-03-31 16:05:00 -07:00
Kamil Gabryjelski
1a1322d3d9
feat(explore): Move chart actions into dropdown (#19446)
* feat(explore): Move chart actions to a dropdown menu

* Fix tests and add some new ones

* Add background color to embed code button

* Fix cypress tests

* Move copy permalink to actions menu

* Remove unused function

* Move share by email above embed code

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test
2022-03-31 20:41:15 +02:00
Michael S. Molina
ac6b2f2d93
refactor: Removes the CSS files from the Heatmap plugin (#19417)
* refactor: Removes the CSS files from the Heatmap plugin

* Adds peer dependencies
2022-03-31 13:32:20 -03:00
Michael S. Molina
13467beb53
refactor: Removes the CSS files from the Calendar Heatmap plugin (#19436) 2022-03-31 13:31:20 -03:00
Michael S. Molina
31095a523d
chore: Removes plugin-chart-pivot-table hard-coded colors (#19439) 2022-03-31 13:30:36 -03:00
Michael S. Molina
47abad8673
chore: Removes hard-coded colors from legacy-preset-chart-nvd3 (#19443) 2022-03-31 13:29:54 -03:00
smileydev
6d89ffbcb7
fix(dashboard): make to show the correct owned objects (#19372)
* fix(dashboard): make to show the correct owned objects

* fix(dashboard): make to filter is reusable

* fix(homepage): make sure the type Array<Filters>

* fix(homepage): make to display dashboard correctly by owners
2022-03-31 17:10:21 +03:00
David Aaron Suddjian
8e29ec5a66
feat: Embedded dashboard configuration (#19364)
* embedded dashboard model

* embedded dashboard endpoints

* DRY up using the with_dashboard decorator elsewhere

* wip

* check feature flags and permissions

* wip

* sdk

* urls

* dao option for id column

* got it working

* Update superset/embedded/view.py

* use the curator check

* put back old endpoint, for now

* allow access by either embedded.uuid or dashboard.id

* keep the old endpoint around, for the time being

* openapi

* lint

* lint

* lint

* test stuff

* lint, test

* typo

* Update superset-frontend/src/embedded/index.tsx

* Update superset-frontend/src/embedded/index.tsx

* fix tests

* bump sdk
2022-03-30 12:34:05 -07:00
Michael S. Molina
193744842b
chore: Disables no literal colors for the theme configuration (#19437) 2022-03-30 11:57:21 -03:00
Kamil Gabryjelski
a076ae6d99
feat(explore): UI changes in dataset panel on Explore page (#19394)
* feat(explore): Implement new design for dataset panel

* Fixes

* Replace drag handle in dashboard builder

* Add missing types

* Type fix

* Fix tests

* Fix non-dnd version

* Fix test

* Replace margin with height
2022-03-29 21:11:08 +02:00
Michael S. Molina
816a2c3e1e
chore: Removes direct theme imports (#19368) 2022-03-29 10:15:07 -03:00
Beto Dealmeida
d304849b46
feat: disable edits on external assets (#19344)
* feat: disable edits on external assets

* Update tests
2022-03-28 16:32:57 -07:00
Evan Rusackas
b689ac2d11
chore: bump storybook to 6.4.19, migrating config, and linting storybook config (#19245)
* chore: bump storybook to 6.4.19 and reconfigure accordingly

* now linting the storybook directory, since it gets validated by CI

* linting 
2022-03-28 14:02:47 -03:00
Yongjie Zhao
a39dd4493e
feat: linear imputation in Resample (#19393) 2022-03-28 22:30:45 +08:00
Geido
6b9113a17b
chore: Eslint custom plugin to warn about hex and literal colors (#19239)
* wip

* Add eslint custom plugin

* Refactor

* Clean up

* Update superset-frontend/buildtools/eslint-plugin-theme-colors/index.js

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Refactor

* Update superset-frontend/buildtools/eslint-plugin-theme-colors/index.js

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Clean up

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-03-28 16:11:34 +03:00
Stephen Liu
6f5778273e
chore: add type checking in plugin test directory (#19387) 2022-03-28 10:20:06 +08:00
smileydev
5ae7e54999
fix(database): make to allow the expose db as default in sqlalchemy form db (#19337) 2022-03-25 15:47:14 -06:00
Ville Brofeldt
6141a9aa4a
chore: add support for npm8 (#19365) 2022-03-25 11:07:30 +02:00
Kamil Gabryjelski
45c28c8046
feat(explore): Dataset panel option tooltips (#19259)
* feat(explore): Add description to column/metric tooltips in dataset panel

* Fix tests

* Address code review comments
2022-03-25 07:55:11 +01:00
smileydev
446358642f
fix(explore-sqllab): make that Timestamp column keep the Is temporal flagged when overwriting (#19010) 2022-03-24 18:20:39 -06:00
Yongjie Zhao
e15573d445
fix: number format should editable when AA in time comparison (#19351) 2022-03-25 07:58:53 +08:00
smileydev
cb0357005e
fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart (#19122)
* fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart

* fix(export-add): make to setup the default error message

* fix(report-add): make to allow the errorMessage undefined in LabeledErrorBoundInput component
2022-03-24 17:18:34 -06:00
Smart-Codi
8947eb9680
fix: Remove gap from SQLLab results bottom (#19138)
* Remove gap from SQLLab results bottom

* resolve comment
2022-03-24 16:53:43 -06:00
Kasia
dc769a9a34
fix: Adaptive formatting spelling (#19359)
Co-authored-by: Kasia Zajac <kasiazajac@Kasias-MacBook-Pro-2.local>
2022-03-24 20:51:06 +01:00
Erik Ritter
2af2d00e85
fix: typo on doc string (#19346) 2022-03-24 09:15:56 +00:00
Michael S. Molina
65c204b288
fix: Null values on Explore filter (#19341) 2022-03-23 17:23:57 -04:00
Kamil Gabryjelski
a08f83bc60
fix(dashboard): Chart stuck in loading state when when datasets request and chart request fail (#19327) 2022-03-23 15:43:32 +01:00
smileydev
468c5ca29a
fix(explore): make to convert null to N/A in view results (#19316)
* fix(explore): make to convert null to N/A in view results

* fix(explore): make to null formatter move before timeFormatter
2022-03-23 08:02:52 -06:00
Diego Medina
9e58916d93
fix: regression on Select component when handling null values (#19326) 2022-03-23 10:31:38 -03:00
Stephen Liu
b0397beb8e
chore: add type checking in package tests directory (#19320) 2022-03-23 18:57:35 +08:00
Ville Brofeldt
b7ecb14230
fix(dashboard): fix default filter bar visibility + add docs (#18741)
* fix(dashboard): fix default filter tab visibility + add tests

* fix types

* lint

* rename docs + add double bang to length
2022-03-23 08:55:03 +02:00
Yongjie Zhao
375c03e084
feat(advanced analysis): support MultiIndex column in post processing stage (#19116) 2022-03-23 13:46:28 +08:00
Evan Rusackas
e45235e482
chore: fixing a pluralization typo (#19295) 2022-03-22 14:44:03 -06:00
Geido
d10a3d8bba
fix: Logo resizing on page load (#19307)
* fix resizing logo

* Refactor
2022-03-22 19:34:49 +02:00
Michael S. Molina
d3ce398448
fix: Don't allow duplicated tag values in the Select (#19283)
* fix: Don't allow duplicated tag values in the Select

* Addresses comments and adds test
2022-03-22 09:05:22 -03:00
Kamil Gabryjelski
a8a48af7fa
chore: Make font-weights themable, fix font faces (#19236)
* fix(fonts): Import all necessary font packages

* Make html tags themable

* Set bold font weight to 600, add medium font weight to theme

* Replace hard coded font weights with theme variables

* Change some font weight light elements to normal

* Fix tests

* Fix bug in pivot table

* Address code review comments
2022-03-22 09:36:15 +01:00
David Aaron Suddjian
35b8a72dae
Update ToastPresenter.tsx (#19296) 2022-03-22 10:10:43 +02:00
Diego Medina
4669b6ce11
fix: most Recently Selected Table Should Appear at the Top of the List on the Left Panel (#19258) 2022-03-21 15:58:23 -06:00
smileydev
29cba2b00c
fix(dashboard): make to show the correct owned objects (#19223)
* fix(dashboard): make to show the correct owned objects

* fix(dashboard): make to filter is reusable

* fix(homepage): make sure the type Array<Filters>
2022-03-21 15:51:10 -06:00
Diego Medina
54f1b35161
chore: add missing keys to components inside lists (#19161) 2022-03-21 15:47:48 -06:00
Phillip Kelley-Dotson
d771ddbb94
feat: allow uploads in crud view (#18953)
* feat: allow uploads in crud view

* fix merge conflict and fix ts

* fix import

* fix tests

* fix lint

* remove unused var

* fix underline flash and alignment

* fix offset

* fix icon alignment

* fix labels and css issues

* make drowdown primary all the time

* make global

* fix lables

* add upload perms to utils

* remove unused code

* add suggested changes

* update menuright
2022-03-21 13:01:36 -07:00
Geido
9ae51f7a48
chore: Remove logo forced width (#19049)
* Remove logo forced width

* improve styling

* improve paddings

* Update UPDATING.md

* Fixes a typo

* Add fixed height

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2022-03-21 19:51:20 +02:00
David Aaron Suddjian
96a123f553
feat: SupersetClient config to override 401 behavior (#19144)
* wip

* feat: make 401 responses configurable in SupersetClient

* sort

* guest unauthorized handler

* add toast container to embedded app

* add option for toast presenter to go at the top

* remove confusing comms logging

* lint

* Update superset-frontend/src/embedded/index.tsx

* type correction
2022-03-21 10:19:21 -07:00
Stephen Liu
dc575080d7
feat: improve color consistency (save all labels) (#19038) 2022-03-21 15:20:04 +08:00
Ville Brofeldt
f341025d80
feat: add support for comments in adhoc clauses (#19248)
* feat: add support for comments in adhoc clauses

* sanitize remaining freeform clauses

* sanitize adhoc having in frontend

* address review comment
2022-03-18 15:08:06 -07:00
David Aaron Suddjian
97abc28a1f
chore!: remove ENABLE_REACT_CRUD_VIEWS feature flag (permanently enable) (#19231)
* remove ENABLE_REACT_CRUD_VIEWS feature flag

* docs

* deal with problematic tests

* empty test suite

* skip test

* test conditions changed

* removing the tests instead of skipping
2022-03-18 14:00:23 -07:00
Grace Guo
d41f9b23a4
chore(superset 2.0): remove front-end deprecated code (#19241) 2022-03-18 11:23:00 -07:00
smileydev
b888341090
fix(chart-crud): make to update Viz type Filter label to Chart type (#19140) 2022-03-18 11:57:34 -06:00
smileydev
e7355b9610
fix(explore comma): make that the comma can be added by removing it from token separators… (#18926)
* make that the comma can be added by removing it from token separators in select component.

* fix(explore comma): add the allowTokenSeperators props into Select

* fix(explore comma): make to allow to customize the token separators in Select.

* fix(explore comma): make to add the unit test and story book.

* fix(explore comma): make to fix the lint

* fix(explore comma): make to fix the spell  & add tokenSeparatprs props to PickedSelectProps

* Update Select.tsx

* fix(explore comma): make to run lint fix
2022-03-18 11:39:26 -03:00
Stephen Liu
10eb6c77a4
chore: use order_desc shared control consistently (#19172) 2022-03-18 21:28:47 +08:00
Jesse Yang
f6291545fb
chore: turn on SQLLAB_BACKEND_PERSISTENCE by default (#19107)
* chore: turn on SQLLAB_BACKEND_PERSISTENCE by default

* Rewrite SQL tabs test to make it more rerunnable
2022-03-17 21:51:47 -07:00
Diego Medina
19fcd03c89
fix: allow to select <NULL> in a native filter single mode (#19076)
* fix: allow to select <NULL> in a native filter single mode

* fix lint issue

* Update superset-frontend/src/components/Select/utils.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* fix

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-03-17 14:05:32 -03:00
smileydev
d099f5ed4a
fix(select): make to consider the case sensitive in case of d3 format selector (#19159) 2022-03-17 10:04:03 -07:00
Hugh A. Miles II
3230415e22
remove config (#19146) 2022-03-17 09:19:11 -07:00
Craig Rueda
4b34817b19
feat(ui): Adding manifest prefix config (#19141)
* Adding manifest prefix config

* Fixing broken tests

* Fixing import

* Adding prefix for remaining assets

* Changing static prefix strategy

* Fixing DST test

* Fixing up formatting

* Fixing up async_query_manager.py types
2022-03-17 08:58:48 -07:00
cccs-Dustin
02ef9ca4cd
feat(sqllab): Add a configuration option to disable data preview (#19104) 2022-03-17 15:22:57 +02:00
Diego Medina
cfb967f430
feat: scroll to bottom when adding a new native filter and the page is filled (#19053)
* feat: Scroll to bottom when adding a new native filter and the page is filled

* Add test
2022-03-16 20:47:15 -06:00
Diego Medina
0277ebc225
fix: Popovers in Explore not attached to the fields they are triggered by (#19139)
* fix: Popovers in Explore not attached to the fields they are triggered by

* fix

* PR comment

* remove unused import
2022-03-16 20:46:52 -06:00
Diego Medina
3b427b2029
fix: auto-complete of tables and names are not working in SQL lab (#19152) 2022-03-16 20:46:06 -06:00
Ville Brofeldt
b7a0559aaf
feat: add permalink to dashboard and explore (#19078)
* rename key_value to temporary_cache

* add migration

* create new key_value package

* add commands

* lots of new stuff

* fix schema reference

* remove redundant filter state from bootstrap data

* add missing license headers

* fix pylint

* fix dashboard permalink access

* use valid json mocks for filter state tests

* fix temporary cache tests

* add anchors to dashboard state

* lint

* fix util test

* fix url shortlink button tests

* remove legacy shortner

* remove unused imports

* fix js tests

* fix test

* add native filter state to anchor link

* add UPDATING.md section

* address comments

* address comments

* lint

* fix test

* add utils tests + other test stubs

* add key_value integration tests

* add filter box state to permalink state

* fully support persisting url parameters

* lint, add redirects and a few integration tests

* fix test + clean up trailing comma

* fix anchor bug

* change value to LargeBinary to support persisting binary values

* fix urlParams type and simplify urlencode

* lint

* add optional entry expiration

* fix incorrect chart id + add test
2022-03-17 01:15:52 +02:00
Hugh A. Miles II
fc8721800b
fix: Revert "refactor: converted QueryAutoRefresh to functional component … (#19226)
* Revert "refactor: converted QueryAutoRefresh to functional component (#18179)"

This reverts commit f497c1900e.

* lint
2022-03-16 15:57:35 -07:00
Jesse Yang
8d53db1db6
test: fix TimezoneSelector tests on daylight saving time (#19156) 2022-03-16 14:47:41 -07:00
Hugh A. Miles II
181ecf4509
fix: Logic for showing extension in Global Nav (#19158)
* fix logic for checking extensions

* add specific types

* fix lint
2022-03-16 14:39:08 -07:00
Lyndsi Kay Williams
bb618a47ff
fix(sqllab): Updated blank states for query results and query history (#19111)
* Empty states updated on result tab and query history tab

* Testing on query history blank state

* Testing on result tab with empty state

* Forgot to remove a comment

* Corrected empty state image size and centered with drag bar

* Centered blank states vertically
2022-03-16 14:09:19 -05:00
David Aaron Suddjian
3d66912d89
fix: clean up chart metadata config (#19143)
* fix: clean up chart metadata config

* missed a spot

* missed another spot

* fix failing time-specific test

* can't call translation functions here

* Revert "fix failing time-specific test"

This reverts commit 3eeb8ab9cc.

* skip problematic test

* extra import
2022-03-16 09:59:56 -07:00
smileydev
30c97ad5bf
fix(dashboard-css): make to stay custom css when reload (#19084)
* fix(dashboard-css): make to stay custome css when reload

* fix(dashboard-css): make to add injectCustomCSS into HeaderActionsDropdown.test.tsx
2022-03-15 23:10:55 -06:00
smileydev
8e7af79aa9
fix(dbs-dropdown): make to allow the search in supported db dropdown (#19125) 2022-03-15 23:09:56 -06:00
Diego Medina
74910f99d8
fix(dashboard): scrolling table viz overlaps next chart (#19121) 2022-03-15 23:01:21 -06:00
Jinghuayao
981f09b5db
test(native filter): add new native filter test (#19115)
* add new native filter test
2022-03-15 08:16:06 -07:00
David Aaron Suddjian
54b60ded8e
chore(embedded): refresh the guest token (#19132)
* refresh the guest token

* put back the date logic

* version

* fix time hijinks

* test

* Update superset-embedded-sdk/src/guestTokenRefresh.ts
2022-03-14 09:32:25 -07:00
Evan Rusackas
76b4a14d30
chore(config): Migrating ENABLE_JAVASCRIPT_CONTROLS from app config to a feature flag (#19113)
* first pass migrating config to ff

* nixing a console log from testing

* adding an entry to `UPDATING.md`

* linting 

* Adding ENABLE_JAVASCRIPT_CONTROLS to FEATURE_FLAGS.md

* no longer in need of state!

* Turning the flag back off

* linting... le sigh

* and more linting...
2022-03-14 08:54:02 -06:00
Hugh A. Miles II
c337491d0e
fix: Add perm for showing DBC-UI in Global Nav (#19023)
* add perm for global db add

* fix permissions

* missing roles params
2022-03-11 13:37:26 -08:00
Jesse Yang
ae13d8313b
feat(select): keep options order when in single mode (#19085) 2022-03-11 13:01:38 -08:00
Stephen Liu
7524e1e3c8
feat(viz-gallery): add 'feature' tag and fuzzy search weighting (#18662)
* feat(viz-gallery): add 'feature' tag and fuzzy search weighting

* add search weight

* Update superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* some improvements

* take metadata out

* use chartLabel enum to unify

* add test chart

* fix cache

* Resolving TS Lint issue

* Appeasing the linter

* Removing one example implementation

* Removing another example label implementation

* Removing the third example label implementation

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-03-11 01:49:10 -07:00
Jesse Yang
3a78165d13
refactor(TimezoneSelector): simplify override logics and tests (#19090) 2022-03-10 18:09:20 -08:00
smileydev
158396fb6c
fix(dashobard-edge-cutting): make to be not cut without Filter (#19080) 2022-03-10 16:15:51 -07:00
Kamil Gabryjelski
70081a698f
fix(dashboard): Empty states overflowing small chart containers (#19095)
* fix(dashboard): Empty states overflowing small chart containers

* Fix test
2022-03-10 15:54:07 +01:00
Kamil Gabryjelski
b8091e33a9
perf(dashboard): Send chart requests before native filter requests (#19077) 2022-03-10 13:37:02 +01:00
smileydev
c79ee56884
fix(plugin-chart-echarts): make to allow the custome of x & y axis title margin i… (#18947)
* fix(chartviz): make to allow the custome of x & y axis title margin in  chart

* fix(chartviz): add eslint radix error in chart.js

* fix(chartviz): change the transformProps in chart plugin & creat helper.

* fix(chartviz): lint fix & chart.js back

* fix(plugin-chart-echarts): make to allow the custom margin of X & y axis in BoxPlot & Mixedtimeseries charts

* fix(plugin-chart-echarts): make to change changeNumber to changeInteger

* fix(plugin-chart-echarts): make to add license & change file name
2022-03-10 12:59:07 +01:00
Smart-Codi
bc6aad0a88
fix: Show Totals error with sort and group by together (#19072) 2022-03-09 21:35:29 -07:00
Hugh A. Miles II
a21d8a0bf4
fix autocomplete (#19047) 2022-03-09 19:07:22 -08:00
Diego Medina
0e0beceac1
fix: Pivot Table Conditional Formatting Doesn't Show All Options (#19071)
* fix: Pivot Table Conditional Formatting Doesn't Show All Options

* PR comments

* PR comments
2022-03-09 15:04:04 -07:00
smileydev
62ad574c24
fix(allow-db-explore): make that the set the allow-db-explore option (#19030) 2022-03-09 14:59:57 -07:00
Kamil Gabryjelski
3c1fb944c1
perf(dashboard): Improve performance of complex dashboards (#19064)
* perf(dashboard): Improve performance of filter indicators

* Improve perf of cross filters

* Rename old function

* Fix undefined

* fix type

* fix tests

* fix undefined

* Address code review comments

* Address code review comments
2022-03-09 22:39:58 +01:00
smileydev
220c46131e
fix(altered-modal): make specified text fields wrap in table (#18822)
* fix(altered-modal): make all text fields wrap

* fix(altered-modal): limit the wrap text in particular column

* fix(altered-modal): make to update the unit test

* fix(altered-modal): make to fix the type of columnsForWrapText

* fix(alerted-modal): make to fix the type of columnsForWrapTest with string type
2022-03-09 12:43:16 -07:00
Diego Medina
fd757c4aa4
fix: enable find text browser functionality inside SQL Lab editor (#19061) 2022-03-09 12:27:10 -07:00
Diego Medina
bd76648e4e
fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW (#19054) 2022-03-09 12:19:18 -07:00