mirror of
https://github.com/apache/superset.git
synced 2024-09-17 11:09:47 -04:00
9f9aae49c9
* git commit -m 'Convert QueryAutoRefresh to functional component [sc-48362]' * addressing PR comments [sc-48362] Removes unneeded props and state tracking of offline, adds finally block to simplify clearing pending request, simplifies value comparison in array by using includes in place of indexOf * Address PR comment to use enum for QueryState [sc-48362] Original implementation had string literals used in multiple places representing Query.state value options. This commit creates a formal TypeScript enum for QueryState so we can remove string literals and ensure better consistency * Address PR comments for object type validation [sc-48362] This commit resolves an issue why the TypeScript typing for queryList was marked as a Query[] but was actually a Dictionary (associative array) or Queries. A new type QueryDictionary has been added and the QueryAutoRefresh code was adjusted to use QueryDictionary instead of Query[] in appropriate places as well as unit tests. Commit also removes QueryAutoRefreshContainer by making the once component using QueryAutoRefresh (which is already redux connected) pass the needed values on props. this simplifies the code base and reduce files that need unit testing while keeping QueryAutoRefresh out of needing a redux connection directly. * Addresses PR comment to add QueryState.SCHEDULED to runningQueryStateList [sc-48362] In previous implementation 'scheduled' was not included int he list of Query States. Further investigation shows it should be added to as a running state. * Fix prettier lint error [sc-48362] * Adjust unit tests for props update hoisting callbacks out of actions wrapper object [sc-48362] * Update with changes from master [sc-48362] Merges in updates from master and resolves conflicts from relocation of some of the Query TypeScript definitions into core * Removes logic setting user offline and relying on results panel error message [sc-48362] * Fixes bad import after some TypeScript definitions were relocated to core [sc-48362] * Fixes TypeScript errors [sc-48362] |
||
|---|---|---|
| .. | ||
| .storybook | ||
| cypress-base | ||
| packages | ||
| plugins | ||
| scripts | ||
| spec | ||
| src | ||
| tools | ||
| .eslintignore | ||
| .eslintrc.js | ||
| .gitignore | ||
| .nvmrc | ||
| .prettierignore | ||
| applitools.config.js | ||
| babel.config.js | ||
| cypress_build.sh | ||
| jest.config.js | ||
| js_build.sh | ||
| lerna.json | ||
| package-lock.json | ||
| package.json | ||
| prettier.config.js | ||
| tsconfig.json | ||
| webpack.config.js | ||
| webpack.proxy-config.js | ||