Commit Graph

2199 Commits

Author SHA1 Message Date
jinghua-qa
9ef9adfd78
test: added some sanity test for native filter (#17231)
* add sanity native filter cypress e2e test

* add liscense

* fix front-end lint

* fix fail

* remove unuse import
2021-10-29 11:08:18 +08:00
John Bodley
ce558e0764
chore: bump superset-ui to 0.18.17 (#17270)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-10-28 14:44:57 -07:00
Yongjie Zhao
be6cca561d
chore: bump deckgl 0.4.13 (#17266) 2021-10-28 16:24:15 +08:00
Phillip Kelley-Dotson
93f59e055e
chore: remove supersetTheme with withTheme (#17069)
* remove supersettheme

* migrate Datasourceeditor to rtl

* lint fix

* remove file

* fix import

* fix test

* fix lint

* spread tests and remove unused code

* fix lint
2021-10-27 12:42:56 -07:00
Ajay M
65f1644208
feat(dashboard): Add description to the native filter (#17025)
* Adding description works

* Add some tests

* Fix tests

* Styled look good

* Tests successful

* Address PR comments

* fix a test
2021-10-27 11:45:31 -07:00
Yongjie Zhao
faf7c74e44
chore: bump superset-ui v0.18.16 (#17251)
* chore: import ES module from chart-controls

* chore: bump superset-ui v0.18.16
2021-10-27 23:35:48 +08:00
Ville Brofeldt
4316fe6ae6
fix(annotataion): handle required fields properly (#17234) 2021-10-27 08:42:28 +03:00
Ajay M
743f4b6512
Fix resetting does not clear form (#17217) 2021-10-26 19:13:47 -07:00
Michael S. Molina
dd71035e58
chore: Removes the ChartIcon component (#17216) 2021-10-26 09:02:31 -03:00
Yongjie Zhao
dbf5225e1f
chore: bump to superset-ui 0.18.15 (#17232)
* bump 0.18.15

* prettier and update lock file
2021-10-26 19:25:34 +08:00
Geido
5f8f67e679
Fix tools position (#17221) 2021-10-26 13:00:33 +03:00
Ben Elgren
3641093a44
allow owners to edit chart title (#17047) 2021-10-26 12:58:07 +03:00
Geido
48fd3c185c
chore: Add docs to the Select component props (#17171)
* Add docs

* Add overall description

* Remove trailing space
2021-10-26 12:50:23 +03:00
simcha90
cf284ba3c7
fix(native-filters): Fix update ownState (#17181)
* fix:fix get permission function

* fix: fix own state update

* refactor: fix CR notes
2021-10-26 11:39:16 +03:00
Evan Rusackas
ef01cbb625
fix: reenabling terser plugin for webpack (#17205)
* fix: reenabling terser plugin

* undoing accidental commit inclusion

* prettier 

* moving the dots.
2021-10-25 15:47:09 -06:00
Elizabeth Thompson
08aab3b399
use full results as csv type (#17194) 2021-10-25 09:36:10 -07:00
Michael S. Molina
4c96ae76e3
chore: Breaks the dataViewCommon folder into TableCollection and Pagination (#17132) 2021-10-25 08:47:24 -03:00
Michael S. Molina
55be249870
fix: Order of Select items when unselecting (#17169)
* fix: Order of Select items when unselecting

* Adds a property comparator that supports strings and numbers

* Uses a named export for propertyComparator
2021-10-25 08:47:01 -03:00
Shiva Raisinghani
ef3afbde82
refactor: Repeated boilerplate code between upload to database forms (#16756)
* abstract boilerplate code into class and rename csv to file

* add db migration

* fix some stuff

* more renaming of csv to file

* rename in translations

* update down revision

* update down revision

* bump chart version

* switch to alter column name approach in db migration

* fix db migration for MySQL

* db migration conflict
2021-10-25 13:53:06 +03:00
Hugh A. Miles II
b5246b29df
feat: Hide nav create with RBAC (#17157)
* recommit

* Update MenuRight.tsx
2021-10-23 03:47:56 -04:00
David Aaron Suddjian
a63a01f158
small changes to dashboard->explore code (#17145) 2021-10-22 10:53:01 -07:00
Youkyoung Cha
35cbcc4643
fix: auto refresh interval won't be updated (#17112)
* fix: auto refresh interval won't be updated

* leave only cirtical changes
2021-10-22 12:23:46 +03:00
Phillip Kelley-Dotson
824e62bd1f
fix: dropdown placement for cascading filters popover (#17046)
* inital fix

* remove content wrapper

* allow dropdown to overflow in long chart

* only pass through filtercontrol

* change to auto

* add ref and pass to child

* fix bug

* fix lint

* add type

* remove code

* add currrent param
2021-10-21 21:25:25 -06:00
Erik Ritter
80a459f43b
feat: support disabling domain sharding with a query param (#17177) 2021-10-21 12:49:59 -07:00
Geido
91199c30d8
Handle undefined (#17183) 2021-10-21 19:34:32 +03:00
Kamil Gabryjelski
860e481a97
fix(explore): timestamp format when copy datatable to clipboard (#17166)
* fix(explore): timestamp format when copy datatable to clipboard

* Fix test

* Fix test

* Use translation for aria label

* Memoize stringified cells

* Fix test
2021-10-21 16:05:14 +02:00
Geido
e5a03423f9
chore(Dashboard): Disable save button in Native Filters when an error is present (#17037)
* Disable save on error

* Remove removed erroredFilter

* Fix cdisabled check
2021-10-21 16:43:58 +03:00
Hugh A. Miles II
cd9e99402d
feat: Add prettier to pre-commit workflow (#17134)
* save

* fix

* fix pre-commit
2021-10-20 20:53:52 -04:00
Geido
f580f6bcba
fix(Explore): Undefined owners (#17167)
* Reconcile owners data

* Fix on save
2021-10-20 09:45:58 -06:00
Michael S. Molina
e32acd22fd
chore: Moves the datasource components to the components folder (#17130) 2021-10-20 08:13:24 -03:00
Phillip Kelley-Dotson
4cc095c10a
update ui packages to 18.14 (#17151) 2021-10-19 08:36:58 -07:00
AAfghahi
dacf79719e
remove title from cancel svg (#17147) 2021-10-18 17:03:55 -04:00
Grace Guo
96f4421961
fix: sql lab crash caused by invalid template (#17133) 2021-10-18 11:09:23 -07:00
Elizabeth Thompson
ae4ced8da6
fix: update values for default timezone selector (#17124)
* update values for default timezone selector

* fix casing and comment

* Update TimezoneSelector.test.tsx
2021-10-18 09:39:20 -07:00
Kamil Gabryjelski
2ad9101d1e
perf(native-filters): Decrease number of unnecessary rerenders in native filters (#17115)
* perf(native-filters): decrease number of redundant rerenders

* More perf improvements

* lint fix
2021-10-18 14:56:52 +02:00
David Aaron Suddjian
57f869cf22
fix(explore): remove unnecessary parameters from the explore url (#17123)
* remove unnecessary parameters from the explore url

* refactor, test
2021-10-18 15:30:15 +03:00
simcha90
37944e18d6
feat(Filter-sets): connect to api (#17055)
* fix:fix get permission function

* feat: filtersets new

* feat: connect filter sets to api

* lint: fix lint

* doc: add comment
2021-10-17 09:56:54 +03:00
Hugh A. Miles II
40b88f04f6
feat: DBC UI Snowflake Form (#16856)
* update snowflake spec for dyanmic form

* feat(snowflake): Snowflake dynamic form (#16861)

* snowflake frontend

* snowflake frontend

* refactor(DB Connections): Build Snowflake Dynamic Form (#16875)

* moved all non-BasicParameters into own field

* refactored DB Connection Form made ValidatedInput

* quick fix

* fixed ValidatedInputField (#16934)

* add logic to check for required fields (#17022)

* fix

* fix linting

* remove host

* Update EncryptedField.tsx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-10-16 20:46:06 -04:00
Ajay M
9e6d5fc775
feat(dashboard): Let users re-arrange native filters (#16154)
* feat. flag: ON

* refactor filter tabs

* WIP

* Drag and Rearrange, styling

* refactoring dnd code

* Add apache license header

* Fix bug reported during PR review

* Minor fix on remove

* turn off filters

* Fix status

* Fix a test

* Address PR comments

* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* indent

* PR comments

* PR comments

* Fix failing tests

* Styling

* Fix remove filter

* Fix the drag issue

* Save works

* fix

* Write tests

* Style changes

* New Icon

* Grab & Grabbing Cursor

* Commented out code

* Fix tests, fix CI

* Fix failing tests

* Fix test

* Style fixes

* portal nodes dependency

* More style fixes

* PR comments

* add unique ids to collapse panels

* Filter removal bug fixed

* PR comments

* Fix test warnings

* delete filter tabs

* Fix the breaking test

* Fix warnings

* Fix the weird bug on cancel

* refactor

* Fix broken scope
2021-10-15 16:56:33 -07:00
David Aaron Suddjian
4a9107d7f1
chore: upgrade highlight.js (#17067) 2021-10-15 10:17:45 -07:00
Phillip Kelley-Dotson
98f6edd16a
upgrade to 18.3 (#17121) 2021-10-15 08:51:45 -07:00
Ville Brofeldt
e055e59a19
chore: remove redundant po2json dev dependency (#17129) 2021-10-15 15:25:39 +03:00
simcha90
eebc953dd5
feat: Custom filters control (#17006)
* fix:fix get permission function

* feat: customize filter control

* fix: fix types

* fix: fix merge

* refactor: update according CR

* refactor: fix CR notes
2021-10-15 14:14:04 +03:00
wijnanjo
c9c669d179
fix for undefined userId (#17117)
Co-authored-by: jo.wijnant <jo.wijnant@kontron.com>
2021-10-15 01:08:57 -07:00
Lyndsi Kay Williams
5253193708
fix: Update package-lock.json of superset-frontend and cypress-base (#17125)
* Copied changes from original PR, minus package-lock.json files

* Reverted command name change

* Fixing superset-ui and package-lock.json

* superset-ui to 0.18.12

* Update cypress package-lock
2021-10-14 18:28:56 -07:00
Lyndsi Kay Williams
732e5891e5
test: Cypress 7.0.0 migration (#16911)
* Copied changes from original PR, minus package-lock.json files

* Reverted command name change

* Fixed package.json in superset-frontend

* Test adjustments
2021-10-14 17:01:11 -07:00
Lyndsi Kay Williams
635898a76d
fix(sqllab): Hover tooltip flashes in SQL Lab (#17068)
* Changed SQL Lab result column header-style width to max-content

* Changed .ant-tooltip-open to block and tooltip placement to topLeft

* Moved tooltip style changes to local implementation instead of global
2021-10-14 16:23:22 -07:00
Yongchan Hong
7a2e39449a
feat(config): Add none force-refresh option for auto refresh (#17039)
* feat(config): Add none force-refresh option for auto refresh

* use general config

* fix lint issues

* last lint fix
2021-10-14 21:31:10 +03:00
Kamil Gabryjelski
3ad7483dc1
fix(dashboard): race condition between hydrating dashboard and set active tabs (#17084)
* fix(dashboard): race condition between hydrating dashboard and set active tabs

* Fix linting

* Change variable name
2021-10-13 20:18:44 +02:00
Beto Dealmeida
40e9add641
fix: accept headers on import (#17080)
* fix: accept headers on import

* Add unit test
2021-10-13 10:06:00 -07:00
John Bodley
b9ff85d9ea
chore(engine): Translate fractional time grains—requires @superset-ui bump (#17078)
* chore(engine): Translate fractional time grains

* Bump @superset-ui

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-10-12 21:40:48 -07:00
Hugh A. Miles II
959fd763a8
fix: Owners selection in dataset edit UX (#17063)
* boilerplate

* update owner select component

* this is working

* update onchange

* refactorig

* you need to useMemo or things break

* update test

* prettier

* move logic into bootstrap data endpoint

* address concerns

* oops

* oops

* fix test
2021-10-12 20:27:56 -04:00
Erik Ritter
153469dba9
fix: error alert levels again (#17027) 2021-10-11 12:28:36 -07:00
Gabriel Romero
83a783de58
style: Update text for SLL Tooltip (#16993)
* Updated tooltip text to match Trello task.

* Added graphlib

* Update DatabaseConnectionForm.tsx

Co-authored-by: Gabriel Romero <gabrielromero@Gabriels-MacBook-Pro.local>
2021-10-11 10:08:52 -07:00
jinghua-qa
f2d41dc416
fix(other): column name in created content on profile page (#17029)
* fix: fix name in created content on profile page

* add more fix on mutater
2021-10-11 23:21:05 +08:00
Geido
14b7f6cdba
fix: Exclude SUPERSET_DEFAULT from the list of available color schemes (#17018)
* Handle SUPERSET_DEFAULT theme

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-11 16:16:06 +03:00
Beto Dealmeida
16a1df75fc
fix: clear modal state after adding dataset (#17044)
* fix: clear modal state after adding dataset

* Fix test

* Small fixes
2021-10-10 16:21:14 -07:00
Michael S. Molina
7c1c89c94b
fix: Loading indicator of table and schema selectors (#17040) 2021-10-08 16:17:43 -03:00
Phillip Kelley-Dotson
2c8e06e929
initial fix (#16998) 2021-10-08 10:56:14 -07:00
Phillip Kelley-Dotson
bdbcfbc8fc
fix: show onhover menu only in edit mode (#17034)
* fix on markdown hover menu

* lint-fix
2021-10-08 10:54:16 -07:00
AAfghahi
e32a12fa0b
bug fix (#17019) 2021-10-08 10:19:04 -07:00
Geido
a6173f1929
chore(Dashboard): Highlight errored filters on the left pane of the Native Filters form plus several enhancements (#16940)
* Implement errored filters

* Clean up

* Handle errors on the fly

* Implement handleErroredFilters

* Reset errors
2021-10-08 17:33:04 +03:00
Geido
a57ae35011
fix: Verify when null value should be undefined in Select (#17013)
* Check for null value

* Safety chek SelectControl and SelectAsyncControl
2021-10-08 17:32:09 +03:00
Geido
42efcdf027
chore(Dashboard): Implement dedicated message for missing dataset (#16959)
* Implement dedicated message

* Clean up
2021-10-08 17:01:00 +03:00
Erik Ritter
ea700384b3
fix: error alerts again (#17026) 2021-10-07 15:30:56 -07:00
Erik Ritter
03cdbac8bb
fix: error alerts js crash (#17015) 2021-10-07 13:09:54 -07:00
AAfghahi
50ad09bbdc
removing paramProperties (#17024) 2021-10-07 15:28:41 -04:00
Michael S. Molina
be211437de
fix: Filtering db names while creating dataset is not working (#17023) 2021-10-07 16:23:51 -03:00
Michael S. Molina
c471a85170
fix: Unnecessary queries when changing filter values (#16994) 2021-10-07 13:07:33 -03:00
Evan Rusackas
5f73ca85d5
feat(linting): restrict direct use of supersetTheme in favor of ThemeProvider (#17001)
* feat: restrict direct use of supersetTheme

* allowing a couple of safe instances of supersetTheme
2021-10-07 08:26:57 -06:00
Geido
66b0877445
Strict undefined check SelectControl (#17008) 2021-10-07 17:22:52 +03:00
Kamil Gabryjelski
45908ff104
fix(dashboard): Race condition when setting activeTabs with nested tabs (#17007)
* fix(dashboard): Race condition when setting activeTabs with nested tabs

* Remove activeTabs prop from Tabs
2021-10-07 14:23:26 +02:00
Yongjie Zhao
6cdb324377
chore: bump superset-ui 0.18.10 (#17009) 2021-10-07 19:37:41 +08:00
Geido
a782a62097
chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609)
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-10-07 14:20:32 +03:00
jinghua-qa
6dc00b3e3f
fix: letter format of sort chart in dashboard edit (#17003) 2021-10-07 16:29:16 +08:00
Evan Rusackas
ac509611b6
chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor (#16999)
* chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor

* putting the background back in, but using the theme.

* should be no need for this import anymore.
2021-10-07 09:46:37 +02:00
Evan Rusackas
66fbce9dec
chore: removing use of supersetTheme in favor of ThemeProvider (#17000) 2021-10-07 10:36:57 +03:00
Lyndsi Kay Williams
90cfa7fb22
fix: FilterableTable result div width (#16912)
* FilterableTable result div width is now inherit

* Changed style to css
2021-10-06 13:14:35 -07:00
Hugh A. Miles II
40861b3db3
fix: check if owners are actually being updated in PUT /datasets/<id> (#16941)
* check if owners are actually being updated

* move logic to FE

* fix

* fix
2021-10-06 11:26:02 -07:00
Michael S. Molina
191033cb44
chore: Translates the favorite filter param (#16990) 2021-10-06 11:04:14 -03:00
Michael S. Molina
c57719128f
fix: When click on "View all" from favorite tab, get error (#16988) 2021-10-06 08:18:56 -03:00
David Aaron Suddjian
1cd0124fd5
chore: upgrade babel (#16885)
* upgrade babel versions

* upgrade babel eslint parser

* fix test
2021-10-05 15:02:57 -07:00
Erik Ritter
2757b93fea
fix: Use production build config for cypress tests (#16978)
* fix: Use production build config for cypress tests

* set usedExports to global
2021-10-05 11:13:33 -07:00
Youkyoung Cha
93ebe3d963
fix: handle mixed time-series error (#16928)
* rebase to master

* Fix line 402

Co-authored-by: yougyoung <yougyoung@pubg.com>
2021-10-05 16:00:22 +03:00
Elizabeth Thompson
5866d5ebb0
fix: Revert "fix: RBAC hide right menu (#16902)" (#16968)
* Revert "fix: RBAC hide right menu (#16902)"

This reverts commit 87baac7650.

* fix failing test
2021-10-04 19:18:12 -07:00
Grace Guo
85e3cec521
chore:upgrade superset-ui dependencies (#16965) 2021-10-04 15:31:36 -07:00
Phillip Kelley-Dotson
50ad84bd03
chore: refactor header menu to show in header grid component (#16689)
* initial commit

* add delete to markdown
2021-10-04 15:01:17 -07:00
Ville Brofeldt
739d8418a7
fix(build): make npm linking work pt. 2 (#16958)
* fix(build): make npm linking work pt. 2

* remove explicit symlinks conf
2021-10-04 19:47:07 +03:00
Geido
3f0756f637
chore: Select component refactoring - SelectControl - Iteration 5 (#16510)
* Refactor Select DatasourceEditor

* Fire onChange with allowNewOptions

* Clean up

* Refactor Select in AnnotationLayer

* Handle on clear

* Update tests

* Refactor Select in SpatialControl

* Show search

* Refactor Select in FilterBox

* Remove search where unnecessary

* Update SelectControl - WIP

* Refactor Controls

* Update SelectControl tests

* Clean up

* Test allowNewOptions false

* Use SelectControl AnnotationLayer

* Use SelectControl SpatialControl

* Clean up

* Render custom label

* Show search

* Implement filterOption

* Improve filterOption

* Update Cypress

* Update Cypress table test

* Use value for defaultValue

* Merge with latest changes

* Reconcile with latest Select changes

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Revert changes to test

* Call onPopoverClear when v value is undefined

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-04 18:24:41 +03:00
Michael S. Molina
1ab36c94f3
chore: Moves spec files to the src folder - iteration 7 (#16943) 2021-10-04 10:56:49 -03:00
Michael S. Molina
028f6c0d3f
chore: Moves spec files to the src folder - iteration 6 (#16935) 2021-10-04 10:56:30 -03:00
Yongjie Zhao
6225c9a4a3
fix: replace absolute difference with difference in legacy charts (#16931) 2021-10-02 09:10:20 +08:00
Phillip Kelley-Dotson
3f6a24fe1a
chore: add certified columns to top of list (#16910)
* initial commit

* inital commit

* add suggestions

* remove changes

* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-01 11:50:03 -07:00
Ville Brofeldt
a07c9d591b
fix(dashboard): recursive parent on dashboard components (#16933)
* fix(dashboard): don't add recursive parents on wrapper component

* add test

* refine logic and add new test
2021-10-01 08:13:38 -07:00
Michael S. Molina
90f711f45c
chore: Moves spec files to the src folder - iteration 5 (#16927) 2021-10-01 11:24:41 -03:00
Hugh A. Miles II
87baac7650
fix: RBAC hide right menu (#16902)
* add provider to right menu

* add roles code

* bad pull
2021-09-30 14:33:54 -04:00
Michael S. Molina
87290ddcc8
fix: Native filters cyclic dependency (#16921) 2021-09-30 14:55:54 -03:00
Michael S. Molina
c5d23fbcc7
fix: Unable to add dataset (#16925) 2021-09-30 14:52:48 -03:00
Geido
7f330c9692
Verify undefined operatorId (#16923) 2021-09-30 18:53:48 +03:00
Geido
c8db435730
fix(Explore): Clear filter value when changing columns (#16871)
* Clear filter value onChange

* Clear filter value on user change action
2021-09-30 17:18:08 +03:00