Commit Graph

2199 Commits

Author SHA1 Message Date
Corbin Robb 8e1619b105
fix(sqllab): Have table name tooltip only show when name is truncated (#17386)
* Add conditional to table name tooltip to only show when overflowing

* Remove uneccessary state and useEffect, a little clean up and slight refactoring

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-11-19 09:34:28 -08:00
Daniel Vaz Gaspar 69f9ee8f5e
fix: feature flags typing (#15254)
* fix: feature flags typing

* fix tests

* add note in UPDATING.md

* fix frontend

* also move SCHEDULED_QUERIES to top level

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-11-19 15:56:16 +00:00
dependabot[bot] 8d8fbac838
chore(deps-dev): bump @types/react-loadable in /superset-frontend (#17454)
Bumps [@types/react-loadable](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-loadable) from 5.5.4 to 5.5.6.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-loadable)

---
updated-dependencies:
- dependency-name: "@types/react-loadable"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-11-19 15:17:39 +02:00
Yongjie Zhao 9070b6b19c
refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
jinghua-qa 1e2c83419c
test: add native filter default value e2e (#17398)
* add native filter default value e2e test

* fix lint

* remove unnecessary check
2021-11-16 18:54:08 +02:00
Evan Rusackas 96bdcc3493
chore: bumping react syntax highlighter and thusly prismjs (#17439) 2021-11-16 08:55:00 -07:00
Geido c2d8b0e72f
chore: Notify user of custom label colors and related Dashboard color scheme (#17422)
* Add alert for custom label colors

* Fix duplicate linear scheme

* Implement dashboard alert

* Remove trailing space

* Update Cypress

* Simplify check
2021-11-16 17:46:39 +02:00
Grace Guo 9f1bf1cbd5
fix: do not show migration toast if user not enable dashboard filter components (#17440) 2021-11-15 11:27:24 -08:00
Lyndsi Kay Williams eb029ab068
fix(sql lab): NULL styling in grid cell (#17385)
* Fix NULL styling in gridCell

* removed unnecessary imports

* Added null styling back to renderGridCell

* Cleaned up a little code as per Elizabeth

* Found another little cleanup spot
2021-11-15 10:49:35 -08:00
Elizabeth Thompson 71e3fa1bf3
use full resultType with csv download on chart in dashboard (#17431) 2021-11-15 09:57:05 -08:00
Yongjie Zhao 7f4c240810
chore: bump superset-ui 0.18.25 (#17438) 2021-11-15 22:21:22 +08:00
Ville Brofeldt e2a429b0c8
feat(explore): adhoc column expressions [ID-3] (#17379)
* add support for adhoc columns to api and sqla model

* fix some types

* fix duplicates in column names

* fix more lint

* fix schema and dedup

* clean up some logic

* first pass at fixing viz.py

* Add frontend support for adhoc columns

* Add title edit

* Fix showing custom title

* Use column name as default value in sql editor

* fix: Adds a loading message when needed in the Select component (#16531)

* fix(tests): make parquet select deterministic with order by (#16570)

* bump emotion to help with cache clobbering (#16559)

* fix: Support Jinja template functions in global async queries (#16412)

* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check

* fix: impersonate user label/tooltip (#16573)

* docs: update for small typos (#16568)

* feat: Add Aurora Data API engine spec (#16535)

* feat: Add Aurora Data API engine spec

* Fix lint

* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)

* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues

* refactor sql_json view endpoint: separate concern into ad hod method (#16595)

* feat: Experimental cross-filter plugins (#16594)

* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF

* chore(deps): bump superset-ui to 0.18.2 (#16601)

* update type guard references

* fix imports

* update series_columns schema

* Add changes that got lost in rebase

* Use current columns name or expression as sql editor init value

* add integration test and do minor fixes

* Bump superset-ui

* fix linting issue

* bump superset-ui to 0.18.22

* resolve merge conflict

* lint

* fix select filter infinite loop

* bump superset-ui to 0.18.23

* Fix auto setting column popover title

* Enable adhoc columns only if UX_BETA enabled

* put back removed test

* Move popover height and width to constants

* Refactor big ternary expression

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
2021-11-15 12:50:08 +02:00
Phillip Kelley-Dotson e6ff25c980
fix(chart): ensure samples data is displayed (#16900)
* initial fix

* use data keys for cols

* add e2e test

* remove code

* trim logic
2021-11-12 14:23:46 -08:00
John Bodley bcef8fa13b
feature: Add quarter unit to datetrunc (#17416)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-12 09:46:55 -08:00
Geido 0712be4c12
fix(Dashboard): Only apply changes when editing properties (#17392)
* Apply only

* Test apply button

* Update Cypress

* Rename test
2021-11-12 19:34:21 +02:00
Yongjie Zhao ffa55f7b7f
chore: add dependencies for monorepo (#17403) 2021-11-12 11:13:51 +08:00
Geido 7cdd58b2db
Fix missing dashboardId (#17380) 2021-11-11 19:07:00 +02:00
Mayur 8756c9089e
fix(dashboard): don't show report modal for anonymous user (#17106)
* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>
2021-11-11 07:50:12 -03:00
John Bodley 675ffaf8df
revert: Partial revert of 17236 (#17383)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-10 20:32:35 -08:00
Hugh A. Miles II a1961cfc6f
fix: Users being able to update datasets across DBs (#17348)
* add database id back

* add condition to verify dataset is being changed

* Update superset/datasets/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-11-10 19:45:48 -05:00
Lyndsi Kay Williams 1beda796f2
fix(sqllab): Query limit dropdown number breaks to separate lines (#17382)
* Limit break fixed

* Used white-space: nowrap instead of width: max-content
2021-11-10 10:58:03 -08:00
Christian Pfarr 333b1371f7
feat: Drill ODBC/JDBC Impersonation feature (#17353)
* Added Drill ODBC Impersonation feature and necessary translations/docs

* Code Cleanup

* add jdbc impersonation_target parameter

* add unittests for DrillEngineSpec.modify_url_for_impersonation method

* reformat test_drill.py with black formatter

* run pre-commit locally

Co-authored-by: Christian Pfarr <Christian.Pfarr@deutschebahn.com>
Co-authored-by: Christian Pfarr <z0ltrix+gitlab@pm.me>
2021-11-10 08:45:16 +02:00
Grace Guo 7d22c9ce17
feat(native_filter_migration): add transition mode (#16992)
* feat: [Migrate filter_box to filter component] add transition mode

* rebase and fix comments

* rebase and fix commnent -- patch 2
2021-11-09 09:55:25 -08:00
John Bodley 561d1ac9f2
feat(metrics): Provide override for disabling ad-hoc metrics (#17202)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-08 10:31:43 -08:00
Yongjie Zhao 33a8e87513
fix: failed timezone selector UT (#17370) 2021-11-08 23:52:22 +08:00
Yongjie Zhao b58f94ad2e
chore: bump @typescript-eslint/eslint-plugin to 5.3.0 (#17367) 2021-11-08 23:48:51 +08:00
Michael S. Molina ed4a628861
fix: Database selector overflow (#17369)
* fix: Database selector overflow

* Fix TImezoneSelector test

* Removes unused imports
2021-11-08 11:25:16 -03:00
Yongjie Zhao ee87b01766
chore: bump superset-ui 0.18.20 (#17362) 2021-11-08 13:04:29 +08:00
Erik Ritter f05a32eeb9
fix: Remove horizontal scroll navigation from SQL Lab (#17356) 2021-11-05 11:12:30 -07:00
Geido ee7c34b5b3
Make color scheme optional (#17357) 2021-11-05 19:09:59 +02:00
jinghua-qa ab1fcf3068
test: add native filter e2e test part3 (#17343)
* add 2 stable test

* fix lint
2021-11-05 22:32:27 +08:00
Geido d0085b1b29
Check validity of control item (#17349) 2021-11-05 12:56:03 +02:00
Hugh A. Miles II e5fe18660c
fix: Show sqllab state when deleting databases (#17331)
* saving

* fix ts

* update test

* update test

* log unit

* updated test
2021-11-04 20:17:08 -04:00
Beto Dealmeida 43f4ab845a
fix: clear 'delete' confirmation (#17345)
* fix: clear 'delete' confirmation

* Add tests
2021-11-04 16:26:38 -07:00
John Bodley 1c12167d8d
fix: Revert default series sort-by metric and enforce non-xor with series limit (#17236)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-03 13:59:38 -07:00
Geido 59a6502efe
fix: Color consistency (#17089)
* Update label colors on the fly

* Clean up

* Improve getFormDataWithExtraFilters

* Improve code structure

* Remove labelColors from formData

* Exclude label_colors from URL

* Refactor color scheme implementation

* Clean up

* Refactor and simplify

* Fix lint

* Remove unnecessary ColorMapControl

* Lint

* Give json color scheme precedence

* Add label_colors prop in metadata

* Separate owners and dashboard meta requests

* Remove label_colors control

* bump superset-ui 0.18.19

* Fix end of file

* Update tests

* Fix lint

* Update Cypress

* Update setColorScheme method

* Use Antd modal body
2021-11-03 19:22:38 +02:00
Michael S. Molina 85a19a9cc2
fix: Unable to select None for Alert's log retention (#17268) 2021-11-03 08:48:30 -03:00
Phillip Kelley-Dotson 9a4ab1026e
fix: remove variables from styled component (#17228)
* remove variables

* fix hovermenu styles
2021-11-02 16:25:48 -07:00
Erik Ritter 7c6d6f47bf
Revert "fix(native-filters): Fix update ownState (#17181)" (#17311)
This reverts commit cf284ba3c7.
2021-11-02 13:17:29 -07:00
Daman Arora 28b494c597
chore: migrate HiddenControl component from jsx to tsx (#17315)
* migrate HiddenControl component from jsx to tsx

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* updating the type of value in the interface

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
2021-11-02 11:51:16 -07:00
Geido a2a457b7ef
fix(Dashboard): Sidepanel positioning (#17200)
* Refactor

* Adjust top offset

* Calculate padding chart list

* Check for standalone mode

* Rename standaloneMode
2021-11-02 19:28:16 +02:00
Geido 5491a4d13c
fix(Explore): Remove changes to the properties on cancel (#17184)
* Remove on close

* Fix lint

* Add tests
2021-11-02 19:27:56 +02:00
Ville Brofeldt 9515ba68dc
chore: bump superset-ui to 0.18.17 (#17310) 2021-11-02 09:13:33 +02:00
Elizabeth Thompson bea8502ebd
run npm install to fix a bad package version (#17314) 2021-11-01 13:57:28 -07:00
Yongjie Zhao 1f2a7a40c4
fix: datatable crash when column is empty string (#17303)
* fix: datatable crash when column is empty string

* typo
2021-11-01 23:58:31 +08:00
jinghua-qa abf24bbb5d
test: add native filter part2 (#17283)
* add native filter part2

* fix lint

* remove unused code

* fix lint after modified
2021-11-01 11:36:47 -03:00
AAfghahi 5948a9fd02
fix(AlertReportModal): Text Area Change (#17176)
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention
2021-10-29 15:30:20 -07:00
Hugh A. Miles II d0bad96b1a
fix: Allow users to update database in Dataset Edit Modal (#17265)
* add condition to fix save

* remove console.log
2021-10-29 14:19:37 -07:00
Lyndsi Kay Williams 456efc0c20
fix(reports): Owners no longer showing undefined in reports (#17223)
* Owners no longer showing undefined

* Reverted owners change

* removed print

* Owners now defined - frontend only solution!

* Remove arbitrary space
2021-10-29 10:17:47 -07:00
Kamil Gabryjelski fa44325a36
fix(explore): Metrics disappearing after removing metric from dataset (#17201)
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls
2021-10-29 16:15:19 +02:00