Commit Graph

477 Commits

Author SHA1 Message Date
KonH 6cbfdea4c0 Fix warning: Type cast is redundant (#2149) 2021-10-03 11:05:18 +07:00
KonH d45fcdd5af Fix warning: Redundant control flow jump statement (#2149) 2021-10-03 11:02:53 +07:00
Bond_009 0d16c48998 Fix some warnings 2021-09-09 15:59:13 +02:00
Fernando Fernández 3d0b1ccae6
Remove all unused usings 2021-09-06 21:15:30 +02:00
Bond_009 637e86478f Fix some warnings 2021-09-03 19:32:11 +02:00
Cody Robibero cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
MrTimscampi 22efb69e92 Document SubtitleDeliveryMethod 2021-06-18 18:26:14 +02:00
Bond-009 b6df851363
Merge pull request #5984 from Bond-009/container
Add regression test for ContainerProfile.ContainsContainer
2021-05-05 13:51:34 +02:00
Bond_009 39931fe3ad Add regression test for ContainerProfile.ContainsContainer 2021-05-05 13:33:34 +02:00
Maxr1998 65a9a4771a
Fix direct play for DirectPlayProfiles without any codecs set
70771fdcd6 broke direct play by treating empty container/codec strings as unsupported in `ContainerProfile.ContainsContainer()`` (which is also used for video and audio codec checks). Instead, they should be treated as supported, for both the positive and negative list option.
2021-05-05 12:25:54 +02:00
Bill Thornton df40828e1f
Merge pull request #5941 from Maxr1998/device-profile-docs
Improve documentation for DeviceProfile
2021-05-05 00:19:49 -04:00
crobibero 1a178e8490 Remove Required attributes 2021-05-04 19:11:01 -06:00
Maxr1998 031a5c122d
Improve documentation for DeviceProfile 2021-05-05 00:58:43 +02:00
Maxr1998 b2bb062ced
Revert shortened 'is ... or' check 2021-05-04 23:38:17 +02:00
Maxr1998 244ad5b225
Apply review feedback 2021-05-04 22:57:27 +02:00
Maxr1998 70771fdcd6
Nullability handling for device profile classes 2021-05-01 13:06:10 +02:00
Bond-009 eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
Code Clean up: Group Methods
2021-04-29 21:14:57 +02:00
Bond-009 f4a59c92e6
Merge pull request #5826 from BaronGreenback/ssdpFix
PlayTo Fix: Use external ip not internal interface
2021-04-25 18:51:11 +02:00
Bond-009 184e05aeb6
Merge pull request #5681 from BaronGreenback/ContentFeatureOptimization
Various DLNA Optimizations
2021-04-22 16:45:36 +02:00
BaronGreenback bb6fddde9a Group Methods 2021-04-17 11:19:09 +01:00
BaronGreenback 3199d1c902 Fix: PlayTo using external ip not internal 2021-04-15 18:36:47 +01:00
Bond-009 fa64d8e4f2
Merge pull request #5637 from dmitrylyzo/check-media-type 2021-04-04 01:25:09 +02:00
Dmitry Lyzo 36da7a06d7
Less negation
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-04-04 02:09:57 +03:00
Bond-009 4f387dca6e
Merge pull request #5598 from cvium/fix_hls_default_values 2021-04-03 19:36:41 +02:00
BaronGreenback d9a50cb510 Various DLNA Optimizations 2021-04-02 19:06:38 +01:00
Max Rumpf 21e7ceae8e
StreamBuilder tweaks (#5668)
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-04-01 19:18:14 +02:00
Dmitry Lyzo 364e8931af Check appropriate profile type 2021-03-27 11:53:57 +03:00
cvium 74e14b4ca5 fix isdirectstream default 2021-03-22 22:34:47 +01:00
cvium 7dedeb6c79 change HLS endpoint defaults to false 2021-03-22 20:53:55 +01:00
Bond_009 401bafbfd0 Address comments 2021-02-20 23:36:22 +01:00
Bond_009 141efafd3d Enable TreatWarningsAsErrors for MediaBrowser.Model 2021-02-20 23:29:33 +01:00
Bond_009 65bab55ca0 Minor improvements 2021-02-13 00:39:18 +01:00
crobibero c8a95e0926 Fix null reference when logging 2020-12-24 10:05:06 -07:00
Bond_009 e4fd61411f Minor improvements 2020-12-02 15:38:52 +01:00
nyanmisaka b4598bd71b Merge remote-tracking branch 'upstream/master' into fmp4-hls 2020-11-20 10:01:17 +08:00
nyanmisaka b02ceea91b increase bitrate to 20Mbps for 1440p transcoding 2020-11-19 23:56:04 +08:00
Nyanmisaka 5ff08338d5
Apply suggestions from code review
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-11-19 15:02:36 +00:00
Greenback 9a323f6df0 More spelling corrections. 2020-11-18 13:46:14 +00:00
Joshua M. Boniface e0f60847c0
Merge pull request #4361 from ssenart/feature/4360-transcoding_flac_downsampling
Add FLAC and define the corresponding target sample rate
2020-11-17 10:29:29 -05:00
Joshua M. Boniface e86db484ef
Merge pull request #4136 from BaronGreenback/Comment1
DLNA Classes - No code change, just added commenting to classes.
2020-11-16 17:11:20 -05:00
nyanmisaka 488dbdb31d Merge remote-tracking branch 'upstream/master' into fmp4-hls 2020-11-16 12:36:55 +08:00
Bond_009 ff49a3bb61
Missed some stuff 2020-11-14 20:28:15 +01:00
BaronGreenback 27bb17ef9d
Merge branch 'master' into Comment1 2020-11-12 09:18:49 +00:00
nyanmisaka 57e5b59b93 adjust bitrate limit for HLS audio codecs 2020-11-11 17:10:08 +08:00
nyanmisaka 85965741f5 add initial support for HEVC over FMP4-HLS 2020-11-08 01:39:32 +08:00
nyanmisaka 00f0c14d7b respect music quality settings when transcoding 2020-10-31 16:09:22 +08:00
Stéphane Senart 5979151f11 [AudioTranscoding] Add FLAC as supported target audio format and be able to define the corresponding target sample rate 2020-10-22 12:22:31 +02:00
Stéphane Senart 28ee4f0a7f [AudioTranscoding] Add FLAC as supported target audio format and be able to define the corresponding target sample rate 2020-10-22 11:09:59 +02:00
BaronGreenback 63be65dd91
Merge branch 'master' into Comment1 2020-10-17 15:00:43 +01:00
Jan-Pieter Baert ec91d3893d
Fix SA 1116 warnings 2020-10-12 20:05:11 +02:00
Maxr1998 e01209a6f5
Log stream type and codec for missing direct play profile 2020-10-03 17:14:09 +02:00
Matt Montgomery 53d5f64e03 Fix SA1513, SA1514, SA1507, and SA1508 2020-09-28 15:04:31 -05:00
dkanada 028c681c15
Merge pull request #3928 from Mygod/patch-1
Add 1440p to the mix
2020-09-23 20:00:26 +09:00
Jim Cartlidge 68de105dc2 Comments part 1 2020-09-13 13:49:11 +01:00
BaronGreenback eedb520af1 Removed code that wasn't used. 2020-09-07 12:14:02 +01:00
Patrick Barron 9fa4fff15d Merge branch 'master' into event-rewrite-1
# Conflicts:
#	Emby.Dlna/Emby.Dlna.csproj
#	Emby.Dlna/Eventing/DlnaEventManager.cs
#	Emby.Dlna/Service/BaseService.cs
#	Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
#	MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
2020-08-24 20:04:13 -04:00
Bond_009 2b400c99ef Fix warnings 2020-08-19 17:50:50 +02:00
Mygod 8b9a380466
Add 1440p to the mix
Partially addresses #3112.
2020-08-18 01:24:24 -04:00
Patrick Barron ca1f15af19 Move GenericEventArgs to Jellyfin.Data.Events 2020-08-13 20:52:55 -04:00
Patrick Barron ab396225ea Migrate Display Preferences to EF Core 2020-07-17 16:11:53 -04:00
Joshua M. Boniface f3151e7dc7
Merge pull request #3505 from Bond-009/minor3
Minor fixes
2020-07-05 00:30:35 -04:00
Bond_009 ae6eaa7f02 Minor fixes 2020-07-04 22:06:27 +02:00
Patrick Barron 6d1b00da64 Use Array.Empty 2020-07-04 11:54:25 -04:00
telans 5bb639a59a
newlines after braces 2020-06-20 21:13:48 +12:00
telans 7f307f9082
brace multiline if statements 2020-06-20 21:12:36 +12:00
telans 98db8f72e0
fix SA1503 for one line if statements 2020-06-20 20:35:29 +12:00
Bond-009 9af6eda0b4
Merge pull request #3343 from telans/comment-stops
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans 9018f8d8be
Add full stop at end of comments (SA1629) 2020-06-16 10:37:52 +12:00
telans 3d9049ef08
fix SA1508 2020-06-15 10:45:55 +12:00
telans acd4389653
fix SA1005 2020-06-15 10:41:00 +12:00
Bond_009 7439e095e2 Merge branch 'master' into nullable3 2020-05-27 20:49:18 +02:00
Bond_009 7659a2ab32 Remove ListHelper extensions 2020-05-01 16:48:33 +02:00
Bond_009 fc049caba2 Merge branch 'master' into nullable3 2020-04-15 11:09:14 +02:00
Vasily 8e514f8d63 Fix check for profile supporting a codec - it should first check if profile is talking about media type
For example, audio-only profiles have "VideoCodec" set to "null" which translates to "any codec", which breaks some logic later on
2020-04-07 14:23:53 +03:00
Bond_009 30ce346f34 Enable nullabe reference types for MediaBrowser.Model 2020-04-05 18:10:56 +02:00
Bond_009 e9d1eabd53 Remove unused usings 2020-03-24 16:12:06 +01:00
Bond-009 94fe9b8f6d
Merge branch 'master' into warn17 2020-03-11 20:26:43 +01:00
Mark Monteiro b67e9cde8c Replace ILogger with ILogger<T> wherever possible
Log entries will contain additional class context when using this interface
2020-03-03 23:07:10 +01:00
Bond_009 07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009 f47ad85011 Fix warnings MediaBrowser.Model 2020-02-04 01:49:27 +01:00
Bond-009 fdbb329118 Remove StringHelper functions 2020-01-09 17:07:13 +01:00
Bond_009 675754bc5c Possible fix for MrMC 2019-09-08 21:07:29 +02:00
Bond_009 ddd1a282ea Remove IpAddressInfo and IpEndPointInfo classes 2019-07-25 00:15:06 +02:00
Bond_009 93e535d3a1 Trying to make sense of the streaming code
Mostly small changes as I was looking through the code.

* async void -> async Task
* Properly implemented dispose methods
* Pass the logstream directly to the JobLogger
* Style fixes
2019-03-26 23:00:14 +01:00
William Lees d18823ced1 Fix potential NullReferenceException 2019-02-12 23:28:02 +11:00
Bond_009 a709cbdc64 Fix more analyzer warnings 2019-01-27 12:12:44 +01:00
Bond_009 883575893b Change image dimentions from double to int
Rename ImageSize -> ImageDimensions
2019-01-26 13:16:47 +01:00
Bond_009 2f8f9e6853 Address comments 2019-01-21 16:57:10 +01:00
Bond_009 06d9423f00 Clean up last bits 2019-01-21 16:48:45 +01:00
Bond_009 37be6c87eb Make ConditionProcessor static 2019-01-21 16:48:45 +01:00
Bond_009 c9b88ab741 Clean up streambuilder 2019-01-21 16:48:45 +01:00
Erwin de Haan 38f96af079 Reformat JustAMan review pt2 changes
Refs #575
2019-01-17 20:24:39 +01:00
Erwin de Haan e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan 65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan a36658f6f0 ReSharper Reformat: Properties to expression bodied form. 2019-01-13 21:31:14 +01:00
Erwin de Haan 8f41ba4d3a Find+Sed BOM removal *.cs: MediaBrowser.LocalMetadata-MediaBrowser.Model 2019-01-13 21:02:23 +01:00
Erwin de Haan 382e8699a2 EditorConfig reformat: MediaBrowser.Model 2019-01-13 20:31:15 +01:00
Erwin de Haan 1a4b271314 Visual Studio Reformat: MediaBrowser.Model 2019-01-13 20:26:15 +01:00
Erwin de Haan e2751d42e8 Merge branch 'dev' into code-cleanup 2019-01-11 12:50:36 +01:00
Erwin de Haan ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
hawken ba1794f64b Remove tabs and trailing whitespace 2019-01-07 23:24:34 +00:00
Bond_009 340a2c6512 Post GPL cleanup 2019-01-03 23:19:02 +01:00
Bond_009 0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
Bond_009 6e5d2aadaa Remove custom ToArray extension 2018-12-28 16:48:26 +01:00
Andrew Rabert a86b71899e Add GPL modules 2018-12-27 18:27:57 -05:00
stefan 48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti 5207067811 fix live tv over dlna 2017-11-29 15:50:18 -05:00
Luke Pulverenti 4f09c1e06d reduce dlna chatter 2017-11-23 10:46:16 -05:00
Luke Pulverenti 43cb11f694 update shared stream support 2017-11-18 23:59:34 -05:00
Luke Pulverenti 1dc8ff9e91 allow specification of m3u stream limit 2017-11-17 16:54:33 -05:00
Luke Pulverenti 0a0303ca64 normalize strm file contents 2017-11-01 15:50:16 -04:00
Luke Pulverenti 8ec8b46394 allow separate configuration of date format 2017-10-30 00:51:43 -04:00
Luke Pulverenti 93676f6838 revise unknown audio stream handling 2017-10-28 23:52:05 -04:00
Luke Pulverenti c583d49541 live tv subtitle fixes 2017-10-13 14:32:58 -04:00
Luke Pulverenti 4e4c145855 update hls query string 2017-09-29 16:10:13 -04:00
Luke Pulverenti a0d82a02c8 update param encoding 2017-09-26 13:09:42 -04:00
Luke Pulverenti d43508a898 update applyconditions 2017-09-25 15:15:01 -04:00
Luke Pulverenti 978eedbcb7 improve support for compressed xmltv 2017-09-25 01:06:15 -04:00
Luke Pulverenti de5a8d579b move season zero display name to per library settings 2017-09-24 16:23:56 -04:00
Luke Pulverenti f3120dbee9 fix application of params 2017-09-22 16:38:59 -04:00
Luke Pulverenti b4851d4789 separate deinterlacing params by video codec 2017-09-21 17:36:19 -04:00
Luke Pulverenti eb63e0d264 update image processor 2017-09-07 14:17:18 -04:00
Luke Pulverenti 8de80d43ba update ResolutionNormalizer 2017-08-30 14:06:54 -04:00
Luke Pulverenti 780b761456 3.2.29.2 2017-08-28 12:41:32 -04:00
Luke Pulverenti 82ab91f209 add property to indicate support for on the fly subtitle extraction 2017-08-23 15:45:40 -04:00
Luke Pulverenti 1ad990ad72 update live tv data transfer 2017-08-19 15:43:35 -04:00
Luke Pulverenti 40442f887b consolidate emby.server.core into emby.server.implementations 2017-08-09 15:56:38 -04:00
Luke Pulverenti d8e2887071 update container value 2017-08-04 16:29:34 -04:00
Luke Pulverenti e208ef19b0 check audio stream for null 2017-08-04 10:49:46 -04:00
Luke Pulverenti b786cca9da consolidate methods 2017-08-04 02:34:46 -04:00
Luke Pulverenti 31841a31a9 3.2.26.7 2017-07-30 14:02:25 -04:00
Luke Pulverenti a0e7cdd2dc support all inclusive direct play profile 2017-07-14 11:57:44 -04:00
Luke Pulverenti 6ea8e7868d add live stream params 2017-07-03 13:16:01 -04:00
Luke Pulverenti 5cafb17e8f fix stream builder error 2017-07-01 14:00:43 -04:00
Luke Pulverenti a759b09577 support max audio bit depth 2017-06-26 11:10:52 -04:00
Luke Pulverenti f2fb52761f update stream building 2017-06-25 13:50:17 -04:00
Luke Pulverenti a107ff0369 capture more transcoding info 2017-06-24 14:33:19 -04:00
Luke Pulverenti 5e57b829d3 update CodecProfile checks 2017-06-07 00:56:48 -04:00
Luke Pulverenti 8a780bc023 add interlaced fix 2017-06-06 02:13:27 -04:00
Luke Pulverenti 3e15b28b18 add IsInterlaced param 2017-05-29 08:35:59 -04:00
Luke Pulverenti 0beb803aed add sample rate condition 2017-05-13 15:31:25 -04:00
Luke Pulverenti 7ee588060d add IgnoreDts option 2017-04-30 16:03:28 -04:00
Luke Pulverenti 118c702c5c fixes #2572 - Issues found by PVS-Studio 2017-04-11 13:04:13 -04:00
Luke Pulverenti 06394d1a9f add break on non keyframes 2017-03-31 15:05:19 -04:00
Luke Pulverenti 6e4074ab8a update multi-version preferences 2017-03-31 15:04:50 -04:00
Luke Pulverenti c9be9b4141 update hls params 2017-03-24 11:03:49 -04:00
Luke Pulverenti 79f3eb3fe2 update live tv osd 2017-03-18 19:37:29 -04:00
Luke Pulverenti c9ee7633ca embed recording button into video player 2017-03-17 16:23:34 -04:00