Commit Graph

477 Commits

Author SHA1 Message Date
Shadowghost 8e8a085b7e Prefer var in StreamBuilder 2022-12-07 18:00:44 +01:00
Shadowghost 08a5c71b90 Add xmldoc for MediaOptions 2022-12-07 18:00:03 +01:00
Shadowghost 1cd7da8889 Apply review suggestions 2022-12-07 18:00:03 +01:00
Shadowghost 697efec86e Cleanup and refactor streambuilder 2022-12-07 18:00:01 +01:00
Bond_009 b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Dmitry Lyzo 2eb00bf3c0 fix secondary audio
Browsers (Chrome, Firefox) can only play the first track,
even if the second track is the default.

Ignore default flag when testing on secondary audio.

External audio tracks are not secondary.
2022-10-31 15:49:34 +03:00
Maxr1998 bf059d5b58 Backport pull request #8411 from jellyfin/release-10.8.z
Allow direct play even if no audio stream is available

Original-merge: bf129ab9b8

Merged-by: Claus Vium <cvium@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-10-28 22:38:56 -04:00
Claus Vium 719e5eae16
Merge pull request #8503 from Bond-009/ThrowIfNull 2022-10-07 07:50:39 +02:00
Jan Sommer 87d460909f Fix minor warnings in MediaBrowser.Model/Configuration (#2149) 2022-10-06 21:44:12 +02:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Hannes Braun 4edeccc5e0
Remove redundant using directives 2022-09-28 16:26:03 +02:00
luz paz 9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Cody Robibero 38102499cb Merge pull request #7947 from nyanmisaka/video-range-condition
(cherry picked from commit f1d56aa5ce)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:14 -04:00
Joshua M. Boniface 47d150565d Merge pull request #7712 from jellyfin/fix-hevc-disable-option
(cherry picked from commit 5a9e5e0d5d)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:57 -04:00
Joshua M. Boniface 2d8f7b46f1 Merge pull request #7699 from Shadowghost/streambuilder-fix
(cherry picked from commit b46d61dfdf)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:57 -04:00
Cody Robibero 688553b9a8 Merge pull request #7537 from dmitrylyzo/fix-streambuilder
(cherry picked from commit 5833c70725)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:10 -04:00
Cody Robibero 1960b5bdce Merge pull request #7523 from crobibero/null-stream
Allow media without streams to playback 

(cherry picked from commit 577325b788)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
Shadowghost 4e91c3ebdc Fix DLNA DirectPlay 2022-03-25 18:02:31 +01:00
Dmitry Lyzo e4137a6279 Fix remuxing 2022-03-20 09:11:46 +03:00
Dmitry Lyzo 1fe82d0deb Add TranscodingProfile conditions 2022-03-20 09:11:46 +03:00
Cody Robibero b9c3a497d5 Use requested bitrate for calculations 2022-03-19 12:08:42 -06:00
Cody Robibero d29c7c1d9e Revert using Math.Clamp 2022-03-13 12:46:13 -06:00
Cody Robibero e6df698df1
Merge pull request #7325 from eyezak/issue/6450 2022-03-12 09:08:25 -07:00
Cody Robibero 3ea4174d12 Fix flipped Clamp args 2022-03-12 07:17:59 -07:00
Claus Vium 53209830e7
Merge pull request #7346 from Bond-009/guid
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Cody Robibero da41cd365c Suggestions from review 2022-03-06 18:17:49 -07:00
Cody Robibero bbd5d11d3b Remove TranscodeReason.None, Add JsonFlagEnum tests 2022-03-06 18:13:54 -07:00
Cody Robibero c331e11c24 Clean up EnumFlags serialization 2022-03-06 18:13:54 -07:00
Isaac Gordezky 9ebd521754 Update MediaBrowser.Model/Dlna/StreamBuilder.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-03-06 18:13:54 -07:00
Isaac Gordezky 84a3db6f84 Fix transcode video matching and add tests for Transcode and Safari 2022-03-06 18:13:54 -07:00
Isaac Gordezky 5e779f20ee Series: issue-6450
Issue: https://github.com/jellyfin/jellyfin/issues/6450

Enable DirectPlay responses
Rewrite DirectPlay and DirectStream resolution
Prefer copy transcode video codec options
Enhance condition processor
Support DirectStream and Transcode with parity
Rework audio stream selection and add tests for ExternalAudio
Update MediaInfoHelper to only call StreamBuilder once
2022-03-06 18:13:54 -07:00
Isaac Gordezky d871dded9f Convert TranscodeReason to Flags 2022-03-06 18:13:54 -07:00
Bond_009 f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Shadowghost ca5112f45a feat(external-media): refactor external subtitle and audio provider 2022-02-18 22:19:24 +01:00
Bond_009 1c14c86b20 Fix some warnings 2022-02-14 14:46:04 +01:00
Cody Robibero 904efeaddc Add null check for audio stream 2022-01-06 08:15:37 -07:00
Cody Robibero 7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
Bond_009 cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
Cody Robibero 55b429edb7
Merge pull request #6920 from marius-luca-87/subtitle_drop 2021-12-24 02:01:44 +00:00
Cody Robibero 076a13abeb
Merge pull request #7029 from cvium/allocations_maybe 2021-12-24 01:59:25 +00:00
cvium a7a7173cd5 Force a remux/transcode with external audio files 2021-12-21 14:35:58 +01:00
cvium b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
Marius Luca 7d86ef6f22 - add an option for dropping specific subtitle formats using the DLNA SubtitleProfile 2021-12-09 17:52:51 +02:00
Marius Luca 5b5ae1ef52 - enable seek function when direct streaming over DLNA 2021-11-26 18:09:34 +02:00
cvium 6985a4f255 Fix SortCriteria and refactor SetSorting 2021-11-09 19:31:54 +01:00
Cody Robibero 64652b6392 Fix and disable new dotnet6 warnings 2021-11-08 12:40:52 -07:00
zehner bbf40d6be2 Update StreamBuilder.cs
LogLevel INFO => DEBUG
2021-11-02 09:35:09 +01:00
Bond_009 1b6eb2ff2d Enable nullable for more files 2021-10-26 13:56:30 +02:00
KonH 6cbfdea4c0 Fix warning: Type cast is redundant (#2149) 2021-10-03 11:05:18 +07:00
KonH d45fcdd5af Fix warning: Redundant control flow jump statement (#2149) 2021-10-03 11:02:53 +07:00
Bond_009 0d16c48998 Fix some warnings 2021-09-09 15:59:13 +02:00
Fernando Fernández 3d0b1ccae6
Remove all unused usings 2021-09-06 21:15:30 +02:00
Bond_009 637e86478f Fix some warnings 2021-09-03 19:32:11 +02:00
Cody Robibero cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
MrTimscampi 22efb69e92 Document SubtitleDeliveryMethod 2021-06-18 18:26:14 +02:00
Bond-009 b6df851363
Merge pull request #5984 from Bond-009/container
Add regression test for ContainerProfile.ContainsContainer
2021-05-05 13:51:34 +02:00
Bond_009 39931fe3ad Add regression test for ContainerProfile.ContainsContainer 2021-05-05 13:33:34 +02:00
Maxr1998 65a9a4771a
Fix direct play for DirectPlayProfiles without any codecs set
70771fdcd6 broke direct play by treating empty container/codec strings as unsupported in `ContainerProfile.ContainsContainer()`` (which is also used for video and audio codec checks). Instead, they should be treated as supported, for both the positive and negative list option.
2021-05-05 12:25:54 +02:00
Bill Thornton df40828e1f
Merge pull request #5941 from Maxr1998/device-profile-docs
Improve documentation for DeviceProfile
2021-05-05 00:19:49 -04:00
crobibero 1a178e8490 Remove Required attributes 2021-05-04 19:11:01 -06:00
Maxr1998 031a5c122d
Improve documentation for DeviceProfile 2021-05-05 00:58:43 +02:00
Maxr1998 b2bb062ced
Revert shortened 'is ... or' check 2021-05-04 23:38:17 +02:00
Maxr1998 244ad5b225
Apply review feedback 2021-05-04 22:57:27 +02:00
Maxr1998 70771fdcd6
Nullability handling for device profile classes 2021-05-01 13:06:10 +02:00
Bond-009 eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
Code Clean up: Group Methods
2021-04-29 21:14:57 +02:00
Bond-009 f4a59c92e6
Merge pull request #5826 from BaronGreenback/ssdpFix
PlayTo Fix: Use external ip not internal interface
2021-04-25 18:51:11 +02:00
Bond-009 184e05aeb6
Merge pull request #5681 from BaronGreenback/ContentFeatureOptimization
Various DLNA Optimizations
2021-04-22 16:45:36 +02:00
BaronGreenback bb6fddde9a Group Methods 2021-04-17 11:19:09 +01:00
BaronGreenback 3199d1c902 Fix: PlayTo using external ip not internal 2021-04-15 18:36:47 +01:00
Bond-009 fa64d8e4f2
Merge pull request #5637 from dmitrylyzo/check-media-type 2021-04-04 01:25:09 +02:00
Dmitry Lyzo 36da7a06d7
Less negation
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-04-04 02:09:57 +03:00
Bond-009 4f387dca6e
Merge pull request #5598 from cvium/fix_hls_default_values 2021-04-03 19:36:41 +02:00
BaronGreenback d9a50cb510 Various DLNA Optimizations 2021-04-02 19:06:38 +01:00
Max Rumpf 21e7ceae8e
StreamBuilder tweaks (#5668)
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-04-01 19:18:14 +02:00
Dmitry Lyzo 364e8931af Check appropriate profile type 2021-03-27 11:53:57 +03:00
cvium 74e14b4ca5 fix isdirectstream default 2021-03-22 22:34:47 +01:00
cvium 7dedeb6c79 change HLS endpoint defaults to false 2021-03-22 20:53:55 +01:00
Bond_009 401bafbfd0 Address comments 2021-02-20 23:36:22 +01:00
Bond_009 141efafd3d Enable TreatWarningsAsErrors for MediaBrowser.Model 2021-02-20 23:29:33 +01:00
Bond_009 65bab55ca0 Minor improvements 2021-02-13 00:39:18 +01:00
crobibero c8a95e0926 Fix null reference when logging 2020-12-24 10:05:06 -07:00
Bond_009 e4fd61411f Minor improvements 2020-12-02 15:38:52 +01:00
nyanmisaka b4598bd71b Merge remote-tracking branch 'upstream/master' into fmp4-hls 2020-11-20 10:01:17 +08:00
nyanmisaka b02ceea91b increase bitrate to 20Mbps for 1440p transcoding 2020-11-19 23:56:04 +08:00
Nyanmisaka 5ff08338d5
Apply suggestions from code review
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-11-19 15:02:36 +00:00
Greenback 9a323f6df0 More spelling corrections. 2020-11-18 13:46:14 +00:00
Joshua M. Boniface e0f60847c0
Merge pull request #4361 from ssenart/feature/4360-transcoding_flac_downsampling
Add FLAC and define the corresponding target sample rate
2020-11-17 10:29:29 -05:00
Joshua M. Boniface e86db484ef
Merge pull request #4136 from BaronGreenback/Comment1
DLNA Classes - No code change, just added commenting to classes.
2020-11-16 17:11:20 -05:00
nyanmisaka 488dbdb31d Merge remote-tracking branch 'upstream/master' into fmp4-hls 2020-11-16 12:36:55 +08:00
Bond_009 ff49a3bb61
Missed some stuff 2020-11-14 20:28:15 +01:00
BaronGreenback 27bb17ef9d
Merge branch 'master' into Comment1 2020-11-12 09:18:49 +00:00
nyanmisaka 57e5b59b93 adjust bitrate limit for HLS audio codecs 2020-11-11 17:10:08 +08:00
nyanmisaka 85965741f5 add initial support for HEVC over FMP4-HLS 2020-11-08 01:39:32 +08:00
nyanmisaka 00f0c14d7b respect music quality settings when transcoding 2020-10-31 16:09:22 +08:00
Stéphane Senart 5979151f11 [AudioTranscoding] Add FLAC as supported target audio format and be able to define the corresponding target sample rate 2020-10-22 12:22:31 +02:00
Stéphane Senart 28ee4f0a7f [AudioTranscoding] Add FLAC as supported target audio format and be able to define the corresponding target sample rate 2020-10-22 11:09:59 +02:00
BaronGreenback 63be65dd91
Merge branch 'master' into Comment1 2020-10-17 15:00:43 +01:00
Jan-Pieter Baert ec91d3893d
Fix SA 1116 warnings 2020-10-12 20:05:11 +02:00