* Update Explore icons and icon colors.
* Change shade of blue and make blue only appear when fields have never been filled in.
* Fix Cypress test.
* Update non-error validation color from blue to yellow.
* Unpack ternary.
* Replace direct AntD imports with our Icons component.
When a custom date field value converted in a string format, some aggregators truncated to the first four digits.
This is caused by the parseFloat function which converts to first matched number rather than NaN(Not-A-Number) value.
This commit replaces the parseFloat by Number wrapper to handle this case correctly.
* add POC ExploreMixin
* Working POC
> columns are loading into page
* Created/tested query dataset dropdown
* Add isValidDatasourceType to @superset-ui/core and hide query dropdown
* Visual updates to explore datasource panel
* Temporarily make Query icon visible
* Remove Query icon visibility
* Removed isValidDatasourceType check
* Added Query preview Modal from DatasourceControl if the data source type is Query [41493]
Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component
* > fix integration point with frontend
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working
* Adjusts conditional logic approach to be extensible for additional types from DatasourceTypes options
* refactor
* set field for sql
* Fixes issue where Missing query parameters error was showing in datasourcePanel
* add query_language
* fix ds main_dttm
* Fixes issue where menu.tsx was blocking access to redux debugging for SqlLab and Explore
* Fixes issue where database id was not available to save query as dataset, adds default metric when chart source is query
* oops
* fix pre-commit to 50 errors now
* fix circuliar dep
* Disables showing Metrics section in DatasourcePanel when Query is the datasource
A follow on separate effort will enable having a default Count metric when Query is the datasource type
* adds condition to use query.columns if query.results is not present enable saving query as a dataset
* down to 26 now
* patch for pre-commit
* one more pre-commit
* added explore_json error
* added error messages
* add for metrics
* add text for columns
* add model open/close method
* add propogation and methods
* change link to span
* lint fix
* Fixes frontend lint and TypeScript errors unit test fixes will be next commit
* Aditional TypeScript error fix
* Fixes unit test failure
* fix some types
* added frontend piece
* fix type
* Fixes bad import caused by merge from master and removes duplicate showSaveDatasetModal check
* Fixes for DartasourceControl Test Suite
* Fix lint error
* Fixes unit test issues due to array instead of a component being passed to modal footer
* Fixes unit test failure for DatasourceControl and simplifies getDatasourceTitle based on PR comment
* fix ts
* pylint
* core_test fix
* Fixes line error post merge from master
* fixed from master
* fixed from master
* Fixes issue where Overwrite dataset does not work due to userid error
SPA refractor changed Redux structure that is used when in explore (which is now within SPA). user object is at the root of the store now for anything under SPA.
* Resolves TypeScript errors with changes made for SPA merging in and changes needed for overwriting dataset from SaveDatasetModal
* fix: top right panel view query functionality
* remove unneeded code from core.py
* working samples endpoint for query
* add owner check
* update FE for it
* handle columns are dict vs object
* fix exceptions
* fix fe lint
* fix test
* add tab_name to payload
* Enables use of tab name from Query
* fix cypress test
* save columns on execution
* fix frontend build test
* remove parathesis around columns
* changing column types
* fixing samples that has literal_columns
* address comments
* add changes
* fix path
* fix merge
* fix types
* remove console
* add type
* fix linting
* update to enum
* fix test
* remove explore from buttons
* fix logic
* fix logic
* oops
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* Add Resizable panel in DashboardBuilder to adjust the width for FiltersPanel
* store the adjusted width for individual dashboard in localStorage to memorize the state
* migrate DashboardBuilder test code by testing-library and jest
* Update explore URLs.
* More URL fixes.
* Make frontend accept true/false query params case-insensitively.
* Fix URL mistake.
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
- Stop clearing the selected dataset after overwritting so users can overwrite as many times as they see fit
- There's a new AsyncSelect we should use now
* feat: have user go to explore after dataset creation
* change flow to create chart
* fix lint
* update with suggestions and add store for toasts
* fix ts
* fix test
* lint
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file.
* feat(dashboard): Use react-router for transition to Explore + cmd click to open in new tab
* Update tooltip
* Add a feature flag
* Update edit chart onclick event
* Fix lint
* Fix tests
* Change feature flag name
* Add tooltip to Edit chart
* feat: truncate long values, a per-column setting
* fix: lint
* fix: removed width for column control
* fix: removed truncate option for time, bool, and numeric columns
* prevent extra div if not truncating
* add flow for dbconnmodal to datasetmodal
* fix bug
* second part
* fix dataset to sql lab
* fix lint
* more lint
* add key value
* fix type
* add new styling
* remove undefined from types
* Save Dataset Modal:
- Use our Select component as substitute of the Autocomplete one so options are loaded initially without the user having to trigger a search and we are mosre consistent with the rest of the app
- Changing datasetId to lowercase so when custom props get into the DOM we don't get warning related to invalid formatting
- We extracted the dropdown out of the radio because it causes invalid click handling when an option is selected
- Updated tests
* Save Dataset Modal:
- Update missing test for DatasourceControl
* Save Dataset Modal:
- Remove conditional from load options function since only guest users dont have userId, and if that is the case they wont reach this part of the application
* Save Dataset Modal:
- Remove unused comment
* Save Dataset Modal:
- Add getPopupContainer as prop for Select component
* Save Dataset Modal:
- Add tests for our new getPopupContainer prop in Select component. So if passed it gets called.
* Save Dataset Modal:
- use lowercased property when calling post form data
* Save Dataset Modal:
- Update tests so there is no need to define a null returning func
* Save Dataset Modal:
- Including getPopupContainer from PickedSelectProps instead
- Updating definition in SelectFilterPlugin
* Respecting max/min opacities, and adding tests.
* revising tests
* Adding missing test case for maximum coverage :)
* removing unnecessary logic and test
* adding another unit test for (hopefully) full coverage.
* no more ternary operator
* New approach with Math.min - take THAT codecov.
* one more stab at making codecov happy... ignoring the file next.
* lint fixes
