mirror of
https://github.com/apache/superset.git
synced 2024-09-17 11:09:47 -04:00
8a57a71bed
* Save Dataset Modal: - Use our Select component as substitute of the Autocomplete one so options are loaded initially without the user having to trigger a search and we are mosre consistent with the rest of the app - Changing datasetId to lowercase so when custom props get into the DOM we don't get warning related to invalid formatting - We extracted the dropdown out of the radio because it causes invalid click handling when an option is selected - Updated tests * Save Dataset Modal: - Update missing test for DatasourceControl * Save Dataset Modal: - Remove conditional from load options function since only guest users dont have userId, and if that is the case they wont reach this part of the application * Save Dataset Modal: - Remove unused comment * Save Dataset Modal: - Add getPopupContainer as prop for Select component * Save Dataset Modal: - Add tests for our new getPopupContainer prop in Select component. So if passed it gets called. * Save Dataset Modal: - use lowercased property when calling post form data * Save Dataset Modal: - Update tests so there is no need to define a null returning func * Save Dataset Modal: - Including getPopupContainer from PickedSelectProps instead - Updating definition in SelectFilterPlugin |
||
---|---|---|
.. | ||
.storybook | ||
cypress-base | ||
packages | ||
plugins | ||
scripts | ||
spec | ||
src | ||
tools | ||
.eslintignore | ||
.eslintrc.js | ||
.gitignore | ||
.nvmrc | ||
.prettierignore | ||
applitools.config.js | ||
babel.config.js | ||
cypress_build.sh | ||
jest.config.js | ||
js_build.sh | ||
lerna.json | ||
package-lock.json | ||
package.json | ||
prettier.config.js | ||
tsconfig.json | ||
webpack.config.js | ||
webpack.proxy-config.js |