* feat(explore): Move save button to header, run button to bottom of control panel
* Make the tabs sticky
* Add error icon to Data tab
* Show message when creating chart and all controls are filled correctly
* Add tests and storybook
* Fix tests
* Disable save button when control have errors
* Fix types
* Apply code review comments
* Replace styled with css
* Remove unused import
* Move chart header to top of the page
* Implement truncating and dynamic input
* fix typing
* Prevent cmd+z undoing changes when not in edit mode
* Fix tests, add missing types
* Show changed title in altered
* feat(explore): Move chart actions to a dropdown menu
* Fix tests and add some new ones
* Add background color to embed code button
* Fix cypress tests
* Move copy permalink to actions menu
* Remove unused function
* Move share by email above embed code
* Fix test
* Fix test
* Fix test
* Fix test
* Fix test
* fix(fonts): Import all necessary font packages
* Make html tags themable
* Set bold font weight to 600, add medium font weight to theme
* Replace hard coded font weights with theme variables
* Change some font weight light elements to normal
* Fix tests
* Fix bug in pivot table
* Address code review comments
* make that the comma can be added by removing it from token separators in select component.
* fix(explore comma): add the allowTokenSeperators props into Select
* fix(explore comma): make to allow to customize the token separators in Select.
* fix(explore comma): make to add the unit test and story book.
* fix(explore comma): make to fix the lint
* fix(explore comma): make to fix the spell & add tokenSeparatprs props to PickedSelectProps
* Update Select.tsx
* fix(explore comma): make to run lint fix
* fix errors with rison and useQueryParams
* add test for encode/decode
* add rison link and make test case more readable
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* feat(explore): Allow using time formatter on temporal columns in data table
* Fix data table loading
* Return colnames and coltypes from results request
* Fix types
* Fix tests
* Fix copy button
* Fix df is none
* Fix test
* Address comments
* Move useTimeFormattedColumns out of useTableColumns
* Make reducer more readable
* feat(explore): Keep or reset chart config after datasource change
* Update copy
* Remove useDispatch
* fix test
* Fix bugs
* Remove ts ignore
* Scroll top when datasource changes
* Fix crashing when switching viz type
* fix: Explore long URL problem
* Fixes lint problems
* Fixes default value
* Removes duplicated test
* Fixes share menu items
* Fixes tests
* Debounces form_data updates
* Rewrites debounce function
* Moves history update outside the functional component
* Mocks lodash function in tests
* Fixes Cypress test
* Fixes Cypress test #2
* feat(explore): add toasts feedback when user copies chart url
* Show toast message when updating chart properties
* Change toast type to success when saving chart
* Use success toast from props
* Fix tests
* Use withToasts instead of dispatch
* Use PropertiesModalProps instead of any
* fix: Select component sort function sorting by label instead of value on numbers
* fix: change select component default sorting to sort by the initial index rather than a property like value or label
* fix: select sorting add sortOptions to select components using sortByProperty
* fix: change select component back, add order to options coming in from SelectControl
* fix: select component options intitial sort bug
* fix: add test cases for select fix
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* Redirect on 401
* Bump FAB
* Format
* Update Cypress save test
* Revert Cypress change
* Bump FAB 3.4.1rc2
* Update test
* Update return statement
* Update api test
* Update datasets api test
* Update datasets api 401s to 403s
* Add typeguard
* Use Promise.resolve
* Update callApiAndParseWithhTimeout test
* Disable parseResponse test
* Try catch
* Handle npm 8 issues
* feat(explore): export csv data pivoted for Pivot Table
* Implement dropdown with download csv options
* Change label to "Original"
* Add tests
* Add form data to query context
* Add form data to query context generator
* Explicitly make form_data optional
* add support for adhoc columns to api and sqla model
* fix some types
* fix duplicates in column names
* fix more lint
* fix schema and dedup
* clean up some logic
* first pass at fixing viz.py
* Add frontend support for adhoc columns
* Add title edit
* Fix showing custom title
* Use column name as default value in sql editor
* fix: Adds a loading message when needed in the Select component (#16531)
* fix(tests): make parquet select deterministic with order by (#16570)
* bump emotion to help with cache clobbering (#16559)
* fix: Support Jinja template functions in global async queries (#16412)
* Support Jinja template functions in async queries
* Pylint
* Add tests for async tasks
* Remove redundant has_request_context check
* fix: impersonate user label/tooltip (#16573)
* docs: update for small typos (#16568)
* feat: Add Aurora Data API engine spec (#16535)
* feat: Add Aurora Data API engine spec
* Fix lint
* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)
* refactor sql_json view endpoint: encapsulate ctas parameters
* fix failed tests
* fix failed tests and ci issues
* refactor sql_json view endpoint: separate concern into ad hod method (#16595)
* feat: Experimental cross-filter plugins (#16594)
* fix:fix get permission function
* feat: add cross filter chart in charts gallery under FF
* chore(deps): bump superset-ui to 0.18.2 (#16601)
* update type guard references
* fix imports
* update series_columns schema
* Add changes that got lost in rebase
* Use current columns name or expression as sql editor init value
* add integration test and do minor fixes
* Bump superset-ui
* fix linting issue
* bump superset-ui to 0.18.22
* resolve merge conflict
* lint
* fix select filter infinite loop
* bump superset-ui to 0.18.23
* Fix auto setting column popover title
* Enable adhoc columns only if UX_BETA enabled
* put back removed test
* Move popover height and width to constants
* Refactor big ternary expression
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
* migrate HiddenControl component from jsx to tsx
* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
* updating the type of value in the interface
* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
* fix(explore): Metrics disappearing after removing metric from dataset
* fix test
* Apply fix to non-dnd controls
* Make adhoc metrics pick up changes from dataset columns
* Remove console log
* Fix bug in nondnd controls
* fix: Order of Select items when unselecting
* Adds a property comparator that supports strings and numbers
* Uses a named export for propertyComparator
* fix(explore): timestamp format when copy datatable to clipboard
* Fix test
* Fix test
* Use translation for aria label
* Memoize stringified cells
* Fix test
* boilerplate
* update owner select component
* this is working
* update onchange
* refactorig
* you need to useMemo or things break
* update test
* prettier
* move logic into bootstrap data endpoint
* address concerns
* oops
* oops
* fix test
* Handle SUPERSET_DEFAULT theme
* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Refactor Select DatasourceEditor
* Fire onChange with allowNewOptions
* Clean up
* Refactor Select in AnnotationLayer
* Handle on clear
* Update tests
* Refactor Select in SpatialControl
* Show search
* Refactor Select in FilterBox
* Remove search where unnecessary
* Update SelectControl - WIP
* Refactor Controls
* Update SelectControl tests
* Clean up
* Test allowNewOptions false
* Use SelectControl AnnotationLayer
* Use SelectControl SpatialControl
* Clean up
* Render custom label
* Show search
* Implement filterOption
* Improve filterOption
* Update Cypress
* Update Cypress table test
* Use value for defaultValue
* Merge with latest changes
* Reconcile with latest Select changes
* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Revert changes to test
* Call onPopoverClear when v value is undefined
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Clean up and reorganize effects
* Enhance optionFilterProps
* Render custom label
* Remove prop filtering
* Create options
* Create option from value in single mode
* Change to customLabel
* Show search by default
* Update superset-frontend/src/components/Select/Select.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/components/Select/Select.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/components/Select/Select.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Apply minor changes
* Fixes a bug that was failing CI
* Adds more tests to the component
* Apply customLabel in ColorSchemeControl
* Remove customLabel from rendered Option
* Hide No data when allowNewOptions
* Remove unnecessary prop from tests
* Adjust loading height
* Show no data with fetchOnlyOnSearch
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
* fix: setupPlugin in chart list page
* fix the order of setupPlugins call
* Fix jest test on loading geojson
* add jest changes
* fix unit tests
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
* copy to Clipboard order
* centralized copyToClipboard
* fixed table order
* fixed tests
* added colnames to all viz types
* added colnames to all viz types
* added colnames to all viz types
* Make ghost buttons clickable
* Popover for column control
* Make column dnd ghost button clickable
* Prefill operator only if column is defined
* Remove data-tests
* lint fix
* Hide new features behind a feature flag
* Change ghost button texts
* Remove caret for non clickable columns
* Implement dynamic tooltip
* Normalize and consolidate
* Clean up
* Refactor and clean up
* Remove unnecessary var
* Fix type import
* Update superset-frontend/src/explore/components/controls/OptionControls/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Remove unnecessary styled span
* Show full tooltip title
* Force show tooltip
* Force show tooltip D&D off
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* chore: switch back tag name to popular from highly-used
* new package lock
* new package lock with npm 7
* fix lint
* remove package changes
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* feat(explore): Create new entrypoints for Echarts Timeseries
* Change order of some charts
* bump superset-ui
* also bump echarts package
* fix UT
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* feat(explore): new datasets have autocomplete filters enabled if UX_BETA is set
* Lint fix
* Set autocomplete to True in example datasets
* Use "IN" as a default operator in dnd filters
* Default operator only if UX_BETA enabled
* chore: implement new mockup to the new viz gallery
* fix: update package-lock
* fix: add license
* fix: reduce duplication and fit within the sidebar
* fix: ut
* feat(explore): default aggregate for string/numeric columns when creating metric
* Fix for editing items with the same label
* Replace componentDidUpdate with getDerivedStateFromProps
* Wrap changes in feature flag
* Enhance Select
* Transition Select to Antd
* Update test
* Fix Cypress
* Change name to aria-label
* Update Cypress search val
* Test Cypress selection
* Transition to Antd for DateFilterLabel
* Enhance styles
* Fix test
* Update superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* hey look, it's a real anchor tag!
* get the explore chart url into the link
* add doc comments to the functions
* remove pointless test
* update weird tests
Co-authored-by: Evan Rusackas <evan@preset.io>
* add modal layout with description, rework styles
* thirty percent
* test correctly
* avoid any changes in modal height
* typescriptify
* feat(viz): add categories to the viz picker (#15304)
* feat(viz): add categories to the viz picker
* fix test types
* add a catch-all category
* tweak layout
* upgrade superset-ui to get new metadata
* do i look like i know what a jpeg is
* fix tests
* lint
* remove script count test requirement
* fix e2e test
* feat(explore): Viz picker search improvements (#15399)
* upgrade superset-ui, install fuse.js
* add metadata to plugin context
* get search working
* layout improvements
* fix tests
* Update superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* use typography size instead of grid unit
* comments
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* feat(explore): Examples image gallery in the viz type control (#15489)
* feat(explore): add section for example images in viz type control
* fix jpg webpack config
* formatting
* feat(Explore): Viz gallery component tweaks (#15520)
* separate viz gallery from the modal
* use gallery directly in add slice view
* more formatting on the add slice container
* restyle the thumbnail list
* explicit thumbnail width and height
* remove crappy hack
* remove useless line
* comment
* sort categories
* comments
* tweak search behavior
* fix tests
* open gallery to the currently selected viz type
* null safety
* show all plugins when searching empty string
* get the new metadatas
* adjust categories scrolling behavior
* add time series table metadata
* upgrade superset-ui
* attempt fixing tests
* upgrade descriptions
* fix unit test
* attempt fixing e2e again
* max width for viz gallery
* update package lock
* undo unnecessary webpack changes
* don't show search results until something is entered
* force modal to open to selected viz type
* tweaks to search behavior
* gallery layout tweaks
* enshrine pivot table v2 in a place of honor
* feat(viz): Clear viz gallery when navigating between categories (#15577)
* start viz gallery with null selection, clear when switching categories
* fix AddSliceContainer tests
* show a message when there is no viz type selected
* composition > inheritance
* clarify searching code
* comment
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Adding a show all button to the column/metrics list in the explore view
* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx
Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx
Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com>
* Fixing typo
Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com>
* fix time range default value
* defer time filter rendering to inView event
* avoid double fetching of time ranges
* lint
* move set to resolved promise
* Front end update - modify OPERATORS, to have SQL operation and display value
* Updated tests
* More tests
* Remove OPERATOR imports
* Fix break tests
* PR comments
* fix issue with comparator loading
* rename a variable
* Linting
* feat(explore): Remove default for time range filter and Metrics
* Merge errors with same messages
* Fix e2e test
* Rename a variable
* Bump packages
* Fix unit tests
* Restrict operators when column is boolean
* refactor 'isOperatorRelevant' a little bit
* Include 'BOOLEAN' to handle presto
* Update tests
* number column should show bool operators
* fix test - some dbs translate true/false to 1/0
* Fix tests and add linting
* When column type is boolean, show bool operators
* Address PR comments - simplify conditions
* Fix a linting error
* Addressing PR comment - remove unused variables
* fix: do not render favorite favStar and filter for anonymous user
* fix: prevent anonymous user to trigger the favstar view route
* fix: lint over previous commit
* fix: linter follow-up
* Add aria-label and twotone
* Enhance LazyIcon
* Fix tests and solve ject warnings
* Add new line
* Revert package-lock to master
* Fix failing test
* Implement icon overrides
* Fix failing storybook
* Clean up
* Improve var name
* test: add tests for filter bar
* test: merge filter bar tests with master
* test: add test for filter set
* test: filter set tests
* test: merge with master
* test: fix tests for filter bar
* fix: fix CR notes
* fix: fix CR notes
* replace Well componenet with Card component
* Fix lint errors
* Fix lint
* Addressing comments
* Addressing comments
* Fix lint errors
* Exporting Card from index.tsx and adding storybook variants
* Fix some refactoring
* Fix errors
* solving conflicts and lint errors
* Update superset-frontend/src/common/components/Card.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/Card.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DataTablesPane
* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Using factory for props
* replacing "data-test"
* removing "act" from tests and fix error
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DisplayQueryButton component
* add factories to props and fetch-mock
* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DatasourceControl
* fix: lint error
* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Remove error comment
* replace component data-test
* factory to props
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DataTableControl
* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* added support to configure the default explorer viz
* code review fix
* lint
Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
* fix(query): properly select adhoc metrics in orderby
* Throw error when sql is empty
* Allow `metrics` to be None
* Always use alias in orderby for metrics
* Bump table chart version and migrate histogram to typescript
* Fix Histogram without groupby
* Fix Presto birth names test
* Raw records mode should not aggregate
* Create a metric immediately when saved metric is dropped
* Display borders around control boxes when metric or column is dragged
* Fix imports
* Display ghost button
* Rename placeholder to ghostButton