pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore(explore): Set Drag&Drop feature flags to True by default (#19046) 

* chore(explore): Set Drag&Drop feature flags to True by default

* fix tests
This commit is contained in:
Kamil Gabryjelski 2022-03-08 18:50:51 +01:00 committed by GitHub
parent 4d96393faf
commit f9c7405e0e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/cypress-base/cypress/integration/explore/AdhocMetrics.test.ts
View File

@ -33,7 +33,7 @@ describe('AdhocMetrics', () => {
.click();
cy.get('[data-test=metrics]')
.find('[data-test="add-metric-button"]')
.contains('Drop columns/metrics here or click')
.click();
// Title edit for saved metrics is disabled - switch to Simple

11
superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
View File

@ -255,10 +255,13 @@ describe('Groupby control', () => {
cy.visitChartByName('Num Births Trend');
cy.verifySliceSuccess({ waitAlias: '@chartData' });
cy.get('[data-test=groupby]').within(() => {
cy.get('.ant-select').click();
cy.get('input[type=search]').type('state{enter}');
});
cy.get('[data-test=groupby]')
.contains('Drop columns here or click')
.click();
cy.get('[id="adhoc-metric-edit-tabs-tab-simple"]').click();
cy.get('input[aria-label="Column"]').click().type('state{enter}');
cy.get('[data-test="ColumnEdit#save"]').contains('Save').click();
cy.get('button[data-test="run-query-button"]').click();
cy.verifySliceSuccess({ waitAlias: '@chartData', chartSelector: 'svg' });
});

2
superset-frontend/cypress-base/cypress/integration/explore/visualizations/line.test.ts
View File

@ -43,7 +43,7 @@ describe('Visualization > Line', () => {
cy.get('.text-danger').contains('Metrics');
cy.get('[data-test=metrics]')
.find('[data-test="add-metric-button"]')
.contains('Drop columns/metrics here or click')
.click();
// Title edit for saved metrics is disabled - switch to Simple

1
superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
View File

@ -348,6 +348,7 @@ const ColumnSelectPopover = ({
}
buttonSize="small"
onClick={onSave}
data-test="ColumnEdit#save"
cta
>
{t('Save')}

4
superset/config.py
View File

@ -417,9 +417,9 @@ DEFAULT_FEATURE_FLAGS: Dict[str, bool] = {
# Enable experimental feature to search for other dashboards
"OMNIBAR": False,
"DASHBOARD_RBAC": False,
"ENABLE_EXPLORE_DRAG_AND_DROP": False,
"ENABLE_EXPLORE_DRAG_AND_DROP": True,
"ENABLE_FILTER_BOX_MIGRATION": False,
"ENABLE_DND_WITH_CLICK_UX": False,
"ENABLE_DND_WITH_CLICK_UX": True,
# Enabling ALERTS_ATTACH_REPORTS, the system sends email and slack message
# with screenshot and link
# Disables ALERTS_ATTACH_REPORTS, the system DOES NOT generate screenshot