Commit Graph

8602 Commits

Author SHA1 Message Date
Phillip Kelley-Dotson bdbcfbc8fc
fix: show onhover menu only in edit mode (#17034)
* fix on markdown hover menu

* lint-fix
2021-10-08 10:54:16 -07:00
AAfghahi e32a12fa0b
bug fix (#17019) 2021-10-08 10:19:04 -07:00
Geido a6173f1929
chore(Dashboard): Highlight errored filters on the left pane of the Native Filters form plus several enhancements (#16940)
* Implement errored filters

* Clean up

* Handle errors on the fly

* Implement handleErroredFilters

* Reset errors
2021-10-08 17:33:04 +03:00
Geido a57ae35011
fix: Verify when null value should be undefined in Select (#17013)
* Check for null value

* Safety chek SelectControl and SelectAsyncControl
2021-10-08 17:32:09 +03:00
Geido 42efcdf027
chore(Dashboard): Implement dedicated message for missing dataset (#16959)
* Implement dedicated message

* Clean up
2021-10-08 17:01:00 +03:00
Ville Brofeldt 9e980b6f2b
ci: fix broken test skips (#17005) 2021-10-08 09:13:01 +03:00
Erik Ritter ea700384b3
fix: error alerts again (#17026) 2021-10-07 15:30:56 -07:00
Erik Ritter 03cdbac8bb
fix: error alerts js crash (#17015) 2021-10-07 13:09:54 -07:00
AAfghahi 50ad09bbdc
removing paramProperties (#17024) 2021-10-07 15:28:41 -04:00
Michael S. Molina be211437de
fix: Filtering db names while creating dataset is not working (#17023) 2021-10-07 16:23:51 -03:00
John Bodley 9ef2861fbd
Update CONTRIBUTING.md (#17016) 2021-10-07 10:38:40 -07:00
Michael S. Molina c471a85170
fix: Unnecessary queries when changing filter values (#16994) 2021-10-07 13:07:33 -03:00
Evan Rusackas 5f73ca85d5
feat(linting): restrict direct use of supersetTheme in favor of ThemeProvider (#17001)
* feat: restrict direct use of supersetTheme

* allowing a couple of safe instances of supersetTheme
2021-10-07 08:26:57 -06:00
Geido 66b0877445
Strict undefined check SelectControl (#17008) 2021-10-07 17:22:52 +03:00
Kamil Gabryjelski 45908ff104
fix(dashboard): Race condition when setting activeTabs with nested tabs (#17007)
* fix(dashboard): Race condition when setting activeTabs with nested tabs

* Remove activeTabs prop from Tabs
2021-10-07 14:23:26 +02:00
Yongjie Zhao 6cdb324377
chore: bump superset-ui 0.18.10 (#17009) 2021-10-07 19:37:41 +08:00
Geido a782a62097
chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609)
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-10-07 14:20:32 +03:00
ofekisr 5fc9970079
chore improve response body (#16974) 2021-10-07 14:03:28 +03:00
Yongjie Zhao fd8461406d
fix: rolling and cum operator on multiple series (#16945)
* fix: rolling and cum operator on multiple series

* add UT

* updates
2021-10-07 16:42:08 +08:00
jinghua-qa 6dc00b3e3f
fix: letter format of sort chart in dashboard edit (#17003) 2021-10-07 16:29:16 +08:00
Evan Rusackas ac509611b6
chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor (#16999)
* chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor

* putting the background back in, but using the theme.

* should be no need for this import anymore.
2021-10-07 09:46:37 +02:00
Evan Rusackas 66fbce9dec
chore: removing use of supersetTheme in favor of ThemeProvider (#17000) 2021-10-07 10:36:57 +03:00
serenajiang cde4cdcd0c
fix(sqllab): SqlJsonExecutionContext.query null pointer (#16997) 2021-10-06 15:40:54 -07:00
Lyndsi Kay Williams 90cfa7fb22
fix: FilterableTable result div width (#16912)
* FilterableTable result div width is now inherit

* Changed style to css
2021-10-06 13:14:35 -07:00
Hugh A. Miles II 40861b3db3
fix: check if owners are actually being updated in `PUT /datasets/<id>` (#16941)
* check if owners are actually being updated

* move logic to FE

* fix

* fix
2021-10-06 11:26:02 -07:00
Beto Dealmeida c993c5845f
fix(BigQuery): explicitly quote columns in select_star (#16822)
* fix (BigQuery): explicitly quote columns in select_star

* Fix test

* Fix SELECT * in BQ

* Add unit tests

* Remove type changes
2021-10-06 07:43:32 -07:00
Michael S. Molina 191033cb44
chore: Translates the favorite filter param (#16990) 2021-10-06 11:04:14 -03:00
Michael S. Molina c57719128f
fix: When click on "View all" from favorite tab, get error (#16988) 2021-10-06 08:18:56 -03:00
Shiva Raisinghani 0b7704a269
remove duplicate line (#16838) 2021-10-06 11:52:14 +03:00
David Aaron Suddjian 1cd0124fd5
chore: upgrade babel (#16885)
* upgrade babel versions

* upgrade babel eslint parser

* fix test
2021-10-05 15:02:57 -07:00
Erik Ritter 2757b93fea
fix: Use production build config for cypress tests (#16978)
* fix: Use production build config for cypress tests

* set usedExports to global
2021-10-05 11:13:33 -07:00
Youkyoung Cha 93ebe3d963
fix: handle mixed time-series error (#16928)
* rebase to master

* Fix line 402

Co-authored-by: yougyoung <yougyoung@pubg.com>
2021-10-05 16:00:22 +03:00
Ville Brofeldt 82601abe17
feat: upgrade docker image to py38 and add support for py39 (#16889)
* feat: upgrade docker image to py38 and add support for py39

* update required tests
2021-10-05 11:35:14 +03:00
Ville Brofeldt 9a8911f18c
test: update required tests to python 3.8 (#16973) 2021-10-05 10:12:53 +03:00
Elizabeth Thompson 5866d5ebb0
fix: Revert "fix: RBAC hide right menu (#16902)" (#16968)
* Revert "fix: RBAC hide right menu (#16902)"

This reverts commit 87baac7650.

* fix failing test
2021-10-04 19:18:12 -07:00
Grace Guo 85e3cec521
chore:upgrade superset-ui dependencies (#16965) 2021-10-04 15:31:36 -07:00
Phillip Kelley-Dotson 50ad84bd03
chore: refactor header menu to show in header grid component (#16689)
* initial commit

* add delete to markdown
2021-10-04 15:01:17 -07:00
Ville Brofeldt 739d8418a7
fix(build): make npm linking work pt. 2 (#16958)
* fix(build): make npm linking work pt. 2

* remove explicit symlinks conf
2021-10-04 19:47:07 +03:00
Geido 3f0756f637
chore: Select component refactoring - SelectControl - Iteration 5 (#16510)
* Refactor Select DatasourceEditor

* Fire onChange with allowNewOptions

* Clean up

* Refactor Select in AnnotationLayer

* Handle on clear

* Update tests

* Refactor Select in SpatialControl

* Show search

* Refactor Select in FilterBox

* Remove search where unnecessary

* Update SelectControl - WIP

* Refactor Controls

* Update SelectControl tests

* Clean up

* Test allowNewOptions false

* Use SelectControl AnnotationLayer

* Use SelectControl SpatialControl

* Clean up

* Render custom label

* Show search

* Implement filterOption

* Improve filterOption

* Update Cypress

* Update Cypress table test

* Use value for defaultValue

* Merge with latest changes

* Reconcile with latest Select changes

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Revert changes to test

* Call onPopoverClear when v value is undefined

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-04 18:24:41 +03:00
Michael S. Molina 1ab36c94f3
chore: Moves spec files to the src folder - iteration 7 (#16943) 2021-10-04 10:56:49 -03:00
Michael S. Molina 028f6c0d3f
chore: Moves spec files to the src folder - iteration 6 (#16935) 2021-10-04 10:56:30 -03:00
Daniel Vaz Gaspar 6d1fbb0668
fix: don't log invalid redirect URL send by user (#16955) 2021-10-04 13:52:57 +01:00
Ville Brofeldt 3dee22adfd
fix(examples): incorrect covid row component id (#16953) 2021-10-04 12:45:31 +03:00
Yongjie Zhao 387ac2b6d3
fix: replace absolute difference with difference in compareOperator (#16930)
* fix: replace absolute difference with difference in compareOperator

* fix ut
2021-10-04 13:31:19 +08:00
Craig Rueda ace9c78684
fix(explore): Ensuring parameters key is included (#16949)
* Ensuring parameters key is included

* Fixing linter
2021-10-03 15:07:13 -07:00
ofekisr c05c6b3db4
fix missing series validation not raised an exception (#16946) 2021-10-03 14:29:56 +03:00
ofekisr 0d0c759cfe
refactor: sql lab command: separate concerns into different modules (#16917)
* chore move sql_execution_context to sqllab package

* add new helper methods into base Dao

* refactor separate get existing query concern from command

* refactor separate query access validation concern

* refactor separate get query's database concern from command

* refactor separate get query rendering concern from command

* refactor sqllab_execution_context

* refactor separate creating payload for view

* chore decouple command from superset app

* fix pylint issues

* fix failed tests

* fix pylint issues

* fix failed test

* fix failed black

* fix failed black

* fix failed test
2021-10-03 11:15:46 +03:00
Junlin Chen f0060a63c0
Native_filter on by default (#16874) 2021-10-02 18:58:59 +03:00
Yongjie Zhao 6225c9a4a3
fix: replace absolute difference with difference in legacy charts (#16931) 2021-10-02 09:10:20 +08:00
Phillip Kelley-Dotson 3f6a24fe1a
chore: add certified columns to top of list (#16910)
* initial commit

* inital commit

* add suggestions

* remove changes

* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-01 11:50:03 -07:00