pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore improve response body (#16974)

This commit is contained in:
ofekisr 2021-10-07 14:03:28 +03:00 committed by GitHub
parent fd8461406d
commit 5fc9970079
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
superset/dashboards/filter_sets/api.py
View File

@ -90,6 +90,7 @@ class FilterSetRestApi(BaseSupersetModelRestApi):
JSON_METADATA_FIELD,
]
list_columns = [
"id",
"created_on",
"changed_on",
"created_by_fk",
@ -101,7 +102,15 @@ class FilterSetRestApi(BaseSupersetModelRestApi):
DASHBOARD_ID_FIELD,
PARAMS_PROPERTY,
]
show_exclude_columns = [OWNER_OBJECT_FIELD, DASHBOARD_FIELD, JSON_METADATA_FIELD]
show_columns = [
"id",
NAME_FIELD,
DESCRIPTION_FIELD,
OWNER_TYPE_FIELD,
OWNER_ID_FIELD,
DASHBOARD_ID_FIELD,
PARAMS_PROPERTY,
]
search_columns = ["id", NAME_FIELD, OWNER_ID_FIELD, DASHBOARD_ID_FIELD]
base_filters = [[OWNER_ID_FIELD, FilterSetFilter, ""]]
@ -232,7 +241,9 @@ class FilterSetRestApi(BaseSupersetModelRestApi):
try:
item = self.add_model_schema.load(request.json)
new_model = CreateFilterSetCommand(g.user, dashboard_id, item).run()
return self.response(201, id=new_model.id, result=item)
return self.response(
201, **self.show_model_schema.dump(new_model, many=False)
)
except ValidationError as error:
return self.response_400(message=error.messages)
except UserIsNotDashboardOwnerError:
@ -302,7 +313,9 @@ class FilterSetRestApi(BaseSupersetModelRestApi):
try:
item = self.edit_model_schema.load(request.json)
changed_model = UpdateFilterSetCommand(g.user, dashboard_id, pk, item).run()
return self.response(200, id=changed_model.id, result=item)
return self.response(
200, **self.show_model_schema.dump(changed_model, many=False)
)
except ValidationError as error:
return self.response_400(message=error.messages)
except (