* Added environment tag and relevant tests
* Reorganize imports
* Prevent errors when config value not set
* Default production tag to be hidden
* Change tag to Label component
* Fix import order
* Allow tag to be colored with theme
* Use theme for tag border radius
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
* Fix styling
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
* Inital duplicate functionality
* Fix formatting
* Create dedicated duplicate API
* Make use of new API
* Make use of new api permissions
* Add integration tests for duplicating datasets
* Add licenses
* Fix linting errors
* Change confirm button to 'Duplicate'
* Fix HTTP status code and response
* Add missing import
* Use user id instead of user object
* Remove stray debug print
* Fix sqlite tests
* Specify type of extra
* Add frontend tests
* Add match statement to test
* Prevent series limit when no series limit columns specified.
* Add timeseries check for legacy charts.
* Apply fix to helpers.py.
* Skip Cypress color consistency tests.
* chore(explore): Add cypress test for creating chart from dataset list
* Add cypress test for creating chart from sqllab query
* Fix the test for editing dataset in exploer
* Fix lint
* Fix tests
* Add new Database Modal
When adding a new database and selecting Snowflake, the database and account fields had the same placeholder. This PR adds a placeholder prop so values can be sent dynamically by field
* Call translation function for string literals
Co-authored-by: Herbert Gainor <herbert.gainor@preset.io>
* fix(database): make to display validation error msg when all cases
* fix(db): make to update the alert error condition
* fix(db): make to add error detail display
* fix(db): make to update error alert display by superset error style guide.
* fix(db): make to style modal header title with h4
* fix(db): make to place see more on bottom instead of top
* fix(db): make to fix shortly
* fix(db): make to fix lint issue
Co-authored-by: Evan Rusackas <evan@preset.io>
* Work in progress to add Chromatic publishing to superset-fronted storybook
Adds new Github action to publish storybook builds to chromatic
Adjusts configuration to support MDX story format
Updates Alert stories to take advantage of MDX format for example in storybook that will publish to Chromatic
Fixes issue in ListViewCard stories that make the story build fail
* Adjust Chromatic Github action
* Adjust action so Gtihub Secret is read into env
Github secrets are not accessible in conditional blocks so this change moves the access of the github secret into an env variable which is accessible in conditional logic
* Removes unneccesary projectToken from package json
* Using a temp key to debug no access to value from github secret
* Refining skipping if no changes to superset-frontend
* Remove typos from Action component story, consolidate on folder check in Chromatic action
* Fix error in Chromatic action event
* Testing action with pul_request_target
* adjustments to Chromatic action triggers
* lint fix
* Testing if pull_request_target is disabled
* More adjustments to Chromatic action
* UI Change to trigger action
* Change to story text to test action
* update package-lock after merge conflicts from master
* Changes to test chromatic action
* Finalize Chromatic actions, fix lint errors
* Backs out addition of @storybook/addon-docs which is included in addon-essentials
* Lint error in package.json
* perf(sqllab): Rendering perf improvement using immutable state
- keep queryEditors immutable during active state
- add unsavedQueryEditor to store all active changes
- refactor each component to subscribe the related unsaved editor state only
* revert ISaveableDatasource type cast
* missing trigger prop
* a default of an empty object and optional operator
* Add drill-to-detail modal.
* Include additional filters from dashboard context in request.
* Set page cache size to be approximately equal to memory usage of Samples pane.
* Update getDatasourceSamples signature.
* One-line import/export.
* Fix incorrect argument order in getDatasourceSamples invocation.
* Fix height of modal.
* Disable option in chart menu unless feature flag is set.
* Open modal on right-click.
* Fix double requests on modal open, controls disappearing on filter update.
* Show formattedVal in clearable filter tag.
* Set force=false for all requests.
* Rearrange/refactor DrillDetailPane.
* Reset page index on reload.
* Fix endless re-requests on request failure.
* Fix modal layout issues.
* Fix bug: some word not translate in js.
delete the 'null,' in messages.json,
so that word can be translate in js.
* docs:No code change. Reformat the database logs with size 400*160,modify the aprt of "Supported dabase" in README
* Mixed TimeSeries:
- When Bar chart is used as serie type, we need to hide values that are greater than the max Y Axis Bound.
* Mixed Time Series:
- Simplify logic for getOverMaxHiddenFormatter
* Mixed Time Series:
- Add tests for new getOverMaxHiddenFormatter util func
* updates to allow insertion of workspace home sidescroll/table UI
* fix types
* fix User type import
* add welcome message to ui registry
* add extra fields to individual chart/query GET results (for workspace home required info)
* update list view card to support a subtitle
* add id to individual chart fetch
* update chart api test
* another test fix
* fix saved query test
* update extension types + insert point
* fix typing
* fix type name
* [sc-54864] Adds safety check to provide near term fix for Queries not saving
There is an error when casting the columns array to String() for saving queries where the objects in the array are missing the toString method. This is a near term rapid patch to fix workflow in production which will have a follow up to identify root cause.
* fix typo
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Adjusted chekc to be explicit for undefined instead of truthy
This fixes issue caught by unit test where the if statement was using a truthy check where it should be explicitly checking for value of undefined
* Adds new unit test to get 100% coverage for callApi
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* feat: Adds drill to detail context menu for ECharts visualizations
* Rebases and adds time grain
* Fixes selected gauge values
* Fixes Treemap edge click
* Adds right click to big number trendline
* Address some comments
* chore: update text for dbconn modal
* fix text and close opts for adddataset modal
* update loading state, add state change for cta btns, and styling
* remove space
* Time Series Chart:
-Apache echarts has this option as false by default for time axis, so we need to override it for our charts so it's uto determined and not fixed to hidden.
- Add AxisType enum so we stop comparing agains raw strings when checking xAxis type
* Time Series Chart:
- set the showMaxLabel option directly without using merge
* Time Series Chart:
- Rename the property to showMaxLabel as it was originally
* beginning of routing
* elizabeth review
* changed folder layout
* Update superset-frontend/src/views/CRUD/data/dataset/DatasetPage/index.tsx
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
* Update superset-frontend/src/views/CRUD/data/dataset/DatasetPage/RightPanel/index.tsx
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
* Moving entire split save btn PR
* Addressed review comments
* Remove arbitrary div from ErrorBoundary in Chart
* Added accidentally removed comment
* Fix act errors in SaveQuery tests
* Fix SaveDatasetActionButton test
* SaveDatasetModal test almost working
* SaveDatasetModal tests all passing
* Clean SaveDatasetModal test
* Fix create chart button and SaveDatasetModal text in SQL Lab
* Fix untitled dataset name on SaveDatasetModal in explore
* Fix styling on split save button
* Update Explore icons and icon colors.
* Change shade of blue and make blue only appear when fields have never been filled in.
* Fix Cypress test.
* Update non-error validation color from blue to yellow.
* Unpack ternary.
* Replace direct AntD imports with our Icons component.
When a custom date field value converted in a string format, some aggregators truncated to the first four digits.
This is caused by the parseFloat function which converts to first matched number rather than NaN(Not-A-Number) value.
This commit replaces the parseFloat by Number wrapper to handle this case correctly.
* add POC ExploreMixin
* Working POC
> columns are loading into page
* Created/tested query dataset dropdown
* Add isValidDatasourceType to @superset-ui/core and hide query dropdown
* Visual updates to explore datasource panel
* Temporarily make Query icon visible
* Remove Query icon visibility
* Removed isValidDatasourceType check
* Added Query preview Modal from DatasourceControl if the data source type is Query [41493]
Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component
* > fix integration point with frontend
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working
* Adjusts conditional logic approach to be extensible for additional types from DatasourceTypes options
* refactor
* set field for sql
* Fixes issue where Missing query parameters error was showing in datasourcePanel
* add query_language
* fix ds main_dttm
* Fixes issue where menu.tsx was blocking access to redux debugging for SqlLab and Explore
* Fixes issue where database id was not available to save query as dataset, adds default metric when chart source is query
* oops
* fix pre-commit to 50 errors now
* fix circuliar dep
* Disables showing Metrics section in DatasourcePanel when Query is the datasource
A follow on separate effort will enable having a default Count metric when Query is the datasource type
* adds condition to use query.columns if query.results is not present enable saving query as a dataset
* down to 26 now
* patch for pre-commit
* one more pre-commit
* added explore_json error
* added error messages
* add for metrics
* add text for columns
* add model open/close method
* add propogation and methods
* change link to span
* lint fix
* Fixes frontend lint and TypeScript errors unit test fixes will be next commit
* Aditional TypeScript error fix
* Fixes unit test failure
* fix some types
* added frontend piece
* fix type
* Fixes bad import caused by merge from master and removes duplicate showSaveDatasetModal check
* Fixes for DartasourceControl Test Suite
* Fix lint error
* Fixes unit test issues due to array instead of a component being passed to modal footer
* Fixes unit test failure for DatasourceControl and simplifies getDatasourceTitle based on PR comment
* fix ts
* pylint
* core_test fix
* Fixes line error post merge from master
* fixed from master
* fixed from master
* Fixes issue where Overwrite dataset does not work due to userid error
SPA refractor changed Redux structure that is used when in explore (which is now within SPA). user object is at the root of the store now for anything under SPA.
* Resolves TypeScript errors with changes made for SPA merging in and changes needed for overwriting dataset from SaveDatasetModal
* fix: top right panel view query functionality
* remove unneeded code from core.py
* working samples endpoint for query
* add owner check
* update FE for it
* handle columns are dict vs object
* fix exceptions
* fix fe lint
* fix test
* add tab_name to payload
* Enables use of tab name from Query
* fix cypress test
* save columns on execution
* fix frontend build test
* remove parathesis around columns
* changing column types
* fixing samples that has literal_columns
* address comments
* add changes
* fix path
* fix merge
* fix types
* remove console
* add type
* fix linting
* update to enum
* fix test
* remove explore from buttons
* fix logic
* fix logic
* oops
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* Add Resizable panel in DashboardBuilder to adjust the width for FiltersPanel
* store the adjusted width for individual dashboard in localStorage to memorize the state
* migrate DashboardBuilder test code by testing-library and jest
* Update explore URLs.
* More URL fixes.
* Make frontend accept true/false query params case-insensitively.
* Fix URL mistake.
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
- Stop clearing the selected dataset after overwritting so users can overwrite as many times as they see fit
- There's a new AsyncSelect we should use now
* feat: have user go to explore after dataset creation
* change flow to create chart
* fix lint
* update with suggestions and add store for toasts
* fix ts
* fix test
* lint
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file.
* feat(dashboard): Use react-router for transition to Explore + cmd click to open in new tab
* Update tooltip
* Add a feature flag
* Update edit chart onclick event
* Fix lint
* Fix tests
* Change feature flag name
* Add tooltip to Edit chart
* feat: truncate long values, a per-column setting
* fix: lint
* fix: removed width for column control
* fix: removed truncate option for time, bool, and numeric columns
* prevent extra div if not truncating
* add flow for dbconnmodal to datasetmodal
* fix bug
* second part
* fix dataset to sql lab
* fix lint
* more lint
* add key value
* fix type
* add new styling
* remove undefined from types
* Save Dataset Modal:
- Use our Select component as substitute of the Autocomplete one so options are loaded initially without the user having to trigger a search and we are mosre consistent with the rest of the app
- Changing datasetId to lowercase so when custom props get into the DOM we don't get warning related to invalid formatting
- We extracted the dropdown out of the radio because it causes invalid click handling when an option is selected
- Updated tests
* Save Dataset Modal:
- Update missing test for DatasourceControl
* Save Dataset Modal:
- Remove conditional from load options function since only guest users dont have userId, and if that is the case they wont reach this part of the application
* Save Dataset Modal:
- Remove unused comment
* Save Dataset Modal:
- Add getPopupContainer as prop for Select component
* Save Dataset Modal:
- Add tests for our new getPopupContainer prop in Select component. So if passed it gets called.
* Save Dataset Modal:
- use lowercased property when calling post form data
* Save Dataset Modal:
- Update tests so there is no need to define a null returning func
* Save Dataset Modal:
- Including getPopupContainer from PickedSelectProps instead
- Updating definition in SelectFilterPlugin
* Respecting max/min opacities, and adding tests.
* revising tests
* Adding missing test case for maximum coverage :)
* removing unnecessary logic and test
* adding another unit test for (hopefully) full coverage.
* no more ternary operator
* New approach with Math.min - take THAT codecov.
* one more stab at making codecov happy... ignoring the file next.
* lint fixes
* Database Modal:
- Add missing invocation to onDatabaseAdd after importing DB from file
- Add keys to our IconButtons
* Database Modal:
- Reduce if clause so it's more concise
* feat(explore): Denormalize form data in Calendar Heatmap
* feat(explore): Denormalize form data in Bubble
* feat(explore): Denormalize form data in Chord
* Dimensions -> Dimension for single selection
* feat(explore): Denormalize form data in Country Map
* feat(explore): Denormalize form data in Heatmap
* feat(explore): Denormalize form data in Histogram
* feat(explore): Denormalize form data in Handlebars
* feat(explore): Denormalize form data in Percent Change
* Use new standardized form data interface
* chore: Restructure explore redux state
* fixes
* fix tests
* add new tests
* Fix type
* Address comments
* Fix bug
* Fix import
* Add new test
* Move unsaved chart id to a constant
* Add todo
Recent commit to sort alphanumeric columns via case insensitive
comparison broke the multi-column sort option. React-table only sorts
by the second (or third...) column if the first column matches.
Since the alphanumeric sort only returned -1 or 1, it never would move
to the subsequent columns when the earlier column values matched.
* git commit -m 'Convert QueryAutoRefresh to functional component [sc-48362]'
* addressing PR comments [sc-48362]
Removes unneeded props and state tracking of offline, adds finally block to simplify clearing pending request, simplifies value comparison in array by using includes in place of indexOf
* Address PR comment to use enum for QueryState [sc-48362]
Original implementation had string literals used in multiple places representing Query.state value options. This commit creates a formal TypeScript enum for QueryState so we can remove string literals and ensure better consistency
* Address PR comments for object type validation [sc-48362]
This commit resolves an issue why the TypeScript typing for queryList was marked as a Query[] but was actually a Dictionary (associative array) or Queries. A new type QueryDictionary has been added and the QueryAutoRefresh code was adjusted to use QueryDictionary instead of Query[] in appropriate places as well as unit tests. Commit also removes QueryAutoRefreshContainer by making the once component using QueryAutoRefresh (which is already redux connected) pass the needed values on props. this simplifies the code base and reduce files that need unit testing while keeping QueryAutoRefresh out of needing a redux connection directly.
* Addresses PR comment to add QueryState.SCHEDULED to runningQueryStateList [sc-48362]
In previous implementation 'scheduled' was not included int he list of Query States. Further investigation shows it should be added to as a running state.
* Fix prettier lint error [sc-48362]
* Adjust unit tests for props update hoisting callbacks out of actions wrapper object [sc-48362]
* Update with changes from master [sc-48362]
Merges in updates from master and resolves conflicts from relocation of some of the Query TypeScript definitions into core
* Removes logic setting user offline and relying on results panel error message [sc-48362]
* Fixes bad import after some TypeScript definitions were relocated to core [sc-48362]
* Fixes TypeScript errors [sc-48362]
* Modified SQL Lab so it uses the default viz to explore a new dataset with
* Added a comment to the config file
* Remove trailing whitespace
* [CLDN-1312] Removed the 'viz_type' variable so that when it is undefinded in the back-end, it gets set to the default viz
* [CLDN-1312] Only sets the 'all_columns' variable if the default viz type is a 'table'
* Will only pop 'selectedColumns' out of 'form_data' if it is present
* [CLDN-1312] Updated files so that the default viz is now being used again in SQL Lab Explore
* fix(home): make to update the css style of links
* fix(home): make to fix lint issue
* fix(home): make to remove underline when tab is active
* fix(homes): make to fix the issue of tab
* fix(home): make to move styles to a tag
* Update dataset selection help text.
* Update 'Create a new chart' flow styles.
* Add support for linking directly to Create Dataset modal via URL hash.
* Add support for linking directly to Create Dataset modal via URL hash.
* Update dataset help text to not include spaces in translated strings and only include an 'Add dataset' link when user has permission to add dataset.
* Clean up test file
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* move postForm to superset client
* lint
* fix lint
* fix type
* update tests
* add tests
* add test for form submit
* add test for request form
* lint
* fix test
* fix tests
* more tests
* more tests
* test
* lint
* more test for postForm
* lint
* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* update tests
* remove useless test
* make test cover happy
* make test cover happy
* make test cover happy
* make codecov happy
* make codecov happy
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* fix(cosmetic): cannot find m-r-10 class in superset.less
* fix: remove .m-r-10 class and use emotion instead
* Update superset-frontend/src/components/Datasource/CollectionTable.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/components/Datasource/DatasourceEditor.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* add icons
* Implement fast viz switcher component
* Remove unnecessary keys from ControlsPanelContainer
* Rename icons
* Add unit tests
* Add licenses
* Fix test
* Change BigNumberWithTrendline to BigNumber
* fix test
* fix test
* Add currently rendered viz tile
* Move View all charts to the right side
* Add license
* Fix imports
* Fix e2e test
* fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button
* include onDatabaseAdd on successful import
* feature: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed
* Apply emotion templating to input/input labels
* feat(echarts): [feature-parity] support extra control
* add extra control for plugin
* refactor: extract ExtraControl
* fix: lint
* fix some problems
* Frontend implementation of create dataset from infobox
* Fixed sl_dataset type
* Fix test
* Fixed sl_dataset type (forgot to save)
* RTL testing
* Adjusted styling/text on infobox and save dataset modal
* Appease lint
* Make infobox invisible and fix tests
* Remove unnecessary placeholder
* Move types to sql lab
* Moved logic into save dataset modal
* Change DatasourceMeta type to Dataset
* Add ExploreDatasource union type to save dataset modal
* Get user info from redux inside save dataset modal
* Addressed comments
* Adjusting to new query type
* Fixed save dataset in explore and union type
* Added testing
* Defined d for queries
* Remove dataset from SaveDatasetModal
* Clarify useSelector parameter
* Fix dndControls union type
* Fix shared-controls union type
* Fix controlPanel union type
* Move ExploreRootState to explore type file
* Remove unnecessary testing playground
* Move datasource type check in DatasourcePanel to a function
* Make all sqllab Query imports reference @superset-ui/core Query type
* Deconstruct query props in ResultSet
* Fix union type in /legacy-plugin-chart-heatmap/src/controlPanel
* Change SaveDatasetModal tests to RTL
* Cleaned datasourceTypeCheck
* Fix infobox styling
* Fix SaveDatasetModal test
* Fix query fixture in sqllab and Query type in SaveDatasetModal test
* Fix Query type and make test query fixture
* Added columns to Query type, separated results property, created QueryResponse union type, and fixed all types affected
* Fixed a couple missed broken types
* Added ExploreDatasource to SqlLab type file
* Removed unneeded Query import from DatasourcePanel
* Address PR comments
* Fix columnChoices
* Fix all incorrect column property checks
* Fix logic on dndGroupByControl
* Dry up savedMetrics type check
* Fixed TIME_COLUMN_OPTION
* Dried savedMetrics type check even further
* Change savedMetricsTypeCheck to defineSavedMetrics
* Change datasourceTypeCheck to isValidDatasourceType
* Fix Query path in groupByControl
* dnd_granularity_sqla now sorts Query types with is_dttm at the top
* Fixed/cleaned query sort
* Add sortedQueryColumns and proper optional chaining to granularity_sqla
* Move testQuery to core-ui, add test coverage for Queries in columnChoices
* Moved DEFAULT_METRICS to core-ui and wrote a test for defineSavedMetrics
* Add license and clean dataset test object
* Change DatasourceType.Dataset to dataset
Michael S. Molina
Geido
Hugh A. Miles II
Reese
JUST.in DO IT
Cody Leff
Kamil Gabryjelski
Paulo Eduardo da Silva
Anthony Gainor
smileydev
Lily Kuang
Eric Briscoe
dependabot[bot]
Lyndsi Kay Williams
Yao Zhou
Antonio Rivero Martinez
stevetracvc
Yongjie Zhao
Diego Medina
Stephen Liu
EugeneTorap
Moriah Kreeger
Jack Fragassi
Evan Rusackas
Jesse Yang
AAfghahi
Phillip Kelley-Dotson
Elizabeth Thompson
Sam Faber-Manning
cccs-RyanK
Srini Kadamati
rizacavus
John Bodley
Usiel Riedl
Smart-Codi
David Aaron Suddjian
Rahul Raj
Alex Lauderbaugh
cccs-Dustin
Sam Firke
jiAng